Commit Graph

32 Commits

Author SHA1 Message Date
Alexander Brandon Coles e8767481e9 [#70166] Fix accessibility errors found by ERB Lint (#21503)
* Fix GitHub/NoTitleAttribute, LinkHasHref errors

- Replaces `title` attribute with `aria-label` for interactive elements.
- Removes `title` from non-interactive elements.
- Converts `<a>` tags without proper `href` to `<button>` elements,
  using Primer `Button`/`IconButton` where possible.

# Conflicts:
#	app/views/custom_fields/_custom_options.html.erb
#	spec/features/admin/custom_fields/shared_custom_field_expectations.rb
#	spec/features/admin/custom_fields/work_packages/list_spec.rb

* Fix Autocomplete missing errors

* Fix GitHub/NoPositiveTabIndex errors

Removes all positive `tabindex` values.

* Fix Rails/LinkToBlank errors

* Replace toast with Primer Banner on LDAP form

* Add frozen_string_literal

* Ignore erb lint for deprecated files

* Fix linting errors in repository module

* Fix linting errors in budgets and custom actions

* Fix linting errors in member form and 2fa

* Fix linting errors in mcost types and wiki help and storages

* Fix linting errors in multi select filters, ifc viewer, and unsupported browser banner

* Fix failing spec

* Use Primer banner instead of op-toast where ever it is possible

* Use octicon instead of op_icon

* Fix failing tests

* Use no-decoration-on-hover for button links and change the button with only an icon to primer icon button

* Keep webhook response modal activation selector class-based

* use icon button for edit of hourly rate

---------

Co-authored-by: Behrokh Satarnejad <b.satarnejad@openproject.com>
2026-05-07 10:31:10 +02:00
Behrokh Satarnejad 8565925b17 [64112] Create an angular breadcrumb as placeholder for the toggle button (#19229)
* create a breadcrumbs angular component

* change the styles of breadcrumbs component so it look like other breadcrumbs

* add breadcrumbs component to the partition query space component

* add breadcrumbs to boards

* add breadcrumbs to team planners and calendar

* add breadcrumbs to ifc viewer and wps and gantt pages

* add feature specs for modules that have breadcrumbs component

* add mobile view for breadcrumbs component

* fix mobile styles in bcf module

* remove margin-bottom from breadcrumb mobile since it has some space from toolbar title

* add a section for active breadcrumb

* move breadcrumb items for gantt and wp to a separate method

* fix urls for work packages and gantt pages when there is no project selected

* use only op- classes

* use existing translations and use capybara accessible selectors

* change gantt translation key

* fix failing test in boards

* add section header of side bar menu to the breadcrumb last item

* change css BEM styles and change the projectWorkPackages path to workPackages path

* undo css changes in bcf view

* fix failing tests

* change target of anchors

* Use real space instead of a margin so that screen readers can read it out correctly

---------

Co-authored-by: Henriette Darge <h.darge@openproject.com>
2025-06-25 15:27:21 +02:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard 8fa8584538 Run rubocop --autocorrect on all files
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
ulferts 5b2bc41f41 Merge remote-tracking branch 'origin/dev' into easier-factory-role-setup 2023-10-12 12:09:27 +02:00
ulferts 2b2abf864a introduce ProjectRole model 2023-10-09 14:34:20 +02:00
Klaus Zanders a256fd85ac Fix a bunch of more usages of member_in_project that was overlooked 2023-10-09 10:40:45 +02:00
Christophe Bliard 4c2a9d0aa8 Enable RSpec zero monkey patching mode
The plan for RSpec 4.0 is to disable monkey patching.

See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.
2023-05-31 19:22:29 +02:00
Christophe Bliard 9e865b4f7b lint: Run rubocop safe autocorrect
Command is `rubocop --safe --autocorrect app lib lib_static modules spec`
2023-03-09 10:25:57 +01:00
Christophe Bliard aa23106c11 lint: autocorrect RSpec/FactoryBot/ConsistentParenthesesStyle
command is

    rubocop -A --only RSpec/FactoryBot/ConsistentParenthesesStyle modules spec
2023-03-07 15:04:32 +01:00
Christophe Bliard 85b3258a29 Autocorrect with some rubocop cops
RSpec/Rails/InferredSpecType and Style/RedundantConstantBase

rubocop --autocorrect-all --only RSpec/Rails/InferredSpecType,Style/RedundantConstantBase spec modules/*/spec
2023-01-13 14:28:59 +01:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Christophe Bliard d17d31eca7 Fix argument alignment since f08bea3467 for modules specs
The FactoryBot.* prefix has been removed in f08bea3. Since then rubocop complains about Layout/ArgumentAlignment. This commit fixes it.
2022-02-03 10:18:24 +01:00
Oliver Günther f08bea3467 Remove FactoryBot.* prefix where applicable 2022-01-25 08:19:06 +01:00
Benjamin Bädorf 3aaac1c7ce Rename most notification to toaster instances (#9765)
* Rename most notification to toaster instances

* Frontend builds

* Fix spec build

* Rename more notification elements to toaster

* Rename toaster-box to op-toast

* Fix op-toast-container

* Rename toasters upload progress

* Try fixing page.rb toaster check

* Fix some specs, break some others

* Correctly overwrite toast_type

* Fix more specs

* Fix one more notification to toaster rename

* Fix linting errors, harmonize naming more

* Remove byebug debugging statement

* Remove byebug debugging statement

* Rename notification in the backend, too

* Rename more instances of notifications to toastService

* Rename backend back to notification since bundle gems expect it there

* expect_toaster -> expect_toast

Co-authored-by: Henriette Darge <h.darge@openproject.com>
2021-11-04 16:25:55 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
Wieland Lindenthal 0b32f19712 [#38032] BCF module: Change default order to ID DESC. (#9464)
https://community.openproject.org/work_packages/38032
2021-08-05 10:50:51 +02:00
ulferts 6140f4c7e9 update copyright to 2021 (#8925)
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.

Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
Oliver Günther 3d2997c449 [33130] Don't prepend BCF component to WP in core edition
https://community.openproject.com/wp/33130
2020-04-23 16:37:44 +02:00
Oliver Günther 8d0a8506d5 [32512] Show empty IFC viewer when no models loaded with warning
https://community.openproject.com/wp/32512

[ci skip]
2020-03-16 13:57:21 +01:00
Oliver Günther 442d26f14f Add timestamps to properly cache invalidate and add spec 2020-03-10 10:35:28 +01:00
Henriette Dinger 1c0494a06e Use clickHandler to load and show viewpoint 2020-03-09 08:15:46 +01:00
Oliver Günther 0ead450de2 Rename classes in partitioned query space page 2020-02-28 14:53:59 +01:00
Oliver Günther ce5095195b Adapt the test to need work package module 2020-02-28 11:19:07 +01:00
Oliver Günther 7bfde5f57e Fix more specs 2020-02-21 08:55:22 +01:00
Oliver Günther 31b53b40c4 Move IFC models into bim 2020-02-21 08:45:53 +01:00