* Fix GitHub/NoTitleAttribute, LinkHasHref errors
- Replaces `title` attribute with `aria-label` for interactive elements.
- Removes `title` from non-interactive elements.
- Converts `<a>` tags without proper `href` to `<button>` elements,
using Primer `Button`/`IconButton` where possible.
# Conflicts:
# app/views/custom_fields/_custom_options.html.erb
# spec/features/admin/custom_fields/shared_custom_field_expectations.rb
# spec/features/admin/custom_fields/work_packages/list_spec.rb
* Fix Autocomplete missing errors
* Fix GitHub/NoPositiveTabIndex errors
Removes all positive `tabindex` values.
* Fix Rails/LinkToBlank errors
* Replace toast with Primer Banner on LDAP form
* Add frozen_string_literal
* Ignore erb lint for deprecated files
* Fix linting errors in repository module
* Fix linting errors in budgets and custom actions
* Fix linting errors in member form and 2fa
* Fix linting errors in mcost types and wiki help and storages
* Fix linting errors in multi select filters, ifc viewer, and unsupported browser banner
* Fix failing spec
* Use Primer banner instead of op-toast where ever it is possible
* Use octicon instead of op_icon
* Fix failing tests
* Use no-decoration-on-hover for button links and change the button with only an icon to primer icon button
* Keep webhook response modal activation selector class-based
* use icon button for edit of hourly rate
---------
Co-authored-by: Behrokh Satarnejad <b.satarnejad@openproject.com>
* create a breadcrumbs angular component
* change the styles of breadcrumbs component so it look like other breadcrumbs
* add breadcrumbs component to the partition query space component
* add breadcrumbs to boards
* add breadcrumbs to team planners and calendar
* add breadcrumbs to ifc viewer and wps and gantt pages
* add feature specs for modules that have breadcrumbs component
* add mobile view for breadcrumbs component
* fix mobile styles in bcf module
* remove margin-bottom from breadcrumb mobile since it has some space from toolbar title
* add a section for active breadcrumb
* move breadcrumb items for gantt and wp to a separate method
* fix urls for work packages and gantt pages when there is no project selected
* use only op- classes
* use existing translations and use capybara accessible selectors
* change gantt translation key
* fix failing test in boards
* add section header of side bar menu to the breadcrumb last item
* change css BEM styles and change the projectWorkPackages path to workPackages path
* undo css changes in bcf view
* fix failing tests
* change target of anchors
* Use real space instead of a margin so that screen readers can read it out correctly
---------
Co-authored-by: Henriette Darge <h.darge@openproject.com>
* Rename most notification to toaster instances
* Frontend builds
* Fix spec build
* Rename more notification elements to toaster
* Rename toaster-box to op-toast
* Fix op-toast-container
* Rename toasters upload progress
* Try fixing page.rb toaster check
* Fix some specs, break some others
* Correctly overwrite toast_type
* Fix more specs
* Fix one more notification to toaster rename
* Fix linting errors, harmonize naming more
* Remove byebug debugging statement
* Remove byebug debugging statement
* Rename notification in the backend, too
* Rename more instances of notifications to toastService
* Rename backend back to notification since bundle gems expect it there
* expect_toaster -> expect_toast
Co-authored-by: Henriette Darge <h.darge@openproject.com>
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.
Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013