Enable RSpec zero monkey patching mode

The plan for RSpec 4.0 is to disable monkey patching.

See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.

modules/auth_plugins/spec/features/auth_provider_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe 'rendering the login buttons', js: true do
+RSpec.describe 'rendering the login buttons', js: true do
   let(:providers) do
     [
       { name: 'mock_auth' }

modules/auth_plugins/spec/requests/auth_plugins_spec.rb

@@ -29,7 +29,7 @@
 require 'spec_helper'
 require 'open_project/auth_plugins'
 
-describe OpenProject::Plugins::AuthPlugin, with_ee: %i[board_view] do
+RSpec.describe OpenProject::Plugins::AuthPlugin, with_ee: %i[board_view] do
   let(:dummy_engine_klass) do
     Class.new { extend OpenProject::Plugins::AuthPlugin }
   end

modules/auth_plugins/spec/requests/flexible_strategy_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe OmniAuth::FlexibleStrategy do
+RSpec.describe OmniAuth::FlexibleStrategy do
   class MockStrategy
     include OmniAuth::Strategy
     include OmniAuth::FlexibleStrategy

modules/auth_plugins/spec/views/base.html.erb_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe 'layouts/base' do
+RSpec.describe 'layouts/base' do
   describe 'authenticator plugin' do
     include Redmine::MenuManager::MenuHelper
     helper Redmine::MenuManager::MenuHelper

modules/auth_plugins/spec/views/hooks/login/_providers.html.erb_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe 'rendering the login buttons for all providers' do
+RSpec.describe 'rendering the login buttons for all providers' do
   let(:providers) do
     [
       { name: 'mock_auth' },

modules/auth_saml/spec/lib/open_project/auth_saml_spec.rb

@@ -1,7 +1,7 @@
 require File.dirname(__FILE__) + '/../../spec_helper'
 require 'open_project/auth_saml'
 
-describe OpenProject::AuthSaml do
+RSpec.describe OpenProject::AuthSaml do
   before do
     OpenProject::AuthSaml.reload_configuration!
   end

modules/auth_saml/spec/requests/saml_provider_callback_spec.rb

@@ -29,7 +29,7 @@
 require 'spec_helper'
 require 'rack/test'
 
-describe 'SAML provider callback', with_ee: %i[openid_providers] do
+RSpec.describe 'SAML provider callback', with_ee: %i[openid_providers] do
   include Rack::Test::Methods
   include API::V3::Utilities::PathHelper
 

modules/avatars/spec/controllers/avatars/avatar_controller_spec.rb

@@ -1,7 +1,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 require File.expand_path(File.dirname(__FILE__) + '/../../shared_examples')
 
-describe Avatars::AvatarController do
+RSpec.describe Avatars::AvatarController do
   include_context "there are users with and without avatars"
   let(:enabled) { true }
 

modules/avatars/spec/controllers/avatars/my_controller_spec.rb

@@ -1,7 +1,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 require File.expand_path(File.dirname(__FILE__) + '/../../shared_examples')
 
-describe Avatars::MyAvatarController do
+RSpec.describe Avatars::MyAvatarController do
   include_context "there are users with and without avatars"
   let(:user) { user_without_avatar }
   let(:enabled) { true }

modules/avatars/spec/controllers/avatars/users_controller_spec.rb

@@ -1,7 +1,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 require File.expand_path(File.dirname(__FILE__) + '/../../shared_examples')
 
-describe Avatars::UsersController do
+RSpec.describe Avatars::UsersController do
   include_context "there are users with and without avatars"
 
   let(:current_user) { create(:admin) }

modules/avatars/spec/features/my_avatar_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 require_relative './shared_avatar_examples'
 
-describe 'My avatar management', js: true do
+RSpec.describe 'My avatar management', js: true do
   include Rails.application.routes.url_helpers
 
   let(:user) { create(:user) }

modules/avatars/spec/features/shared_avatar_examples.rb

@@ -1,6 +1,6 @@
 require 'fastimage'
 
-shared_examples 'avatar management' do
+RSpec.shared_examples 'avatar management' do
   let(:image_base_path) { File.expand_path(File.dirname(__FILE__) + '/../fixtures/') }
 
   let(:enable_gravatars) { false }

modules/avatars/spec/features/user_avatar_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 require_relative './shared_avatar_examples'
 
-describe 'User avatar management', js: true do
+RSpec.describe 'User avatar management', js: true do
   include Rails.application.routes.url_helpers
 
   let(:user) { create(:admin) }

modules/avatars/spec/helpers/avatar_helper_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe AvatarHelper, with_settings: { protocol: 'http' } do
+RSpec.describe AvatarHelper, with_settings: { protocol: 'http' } do
   include AngularHelper
 
   let(:user) { build_stubbed(:user) }

modules/avatars/spec/lib/api/v3/users/user_representer_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe API::V3::Users::UserRepresenter do
+RSpec.describe API::V3::Users::UserRepresenter do
   let(:user) { build_stubbed(:user, status: 1) }
   let(:current_user) { build_stubbed(:user) }
   let(:representer) { described_class.create(user, current_user:) }

modules/avatars/spec/models/user_spec.rb

@@ -1,7 +1,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 require File.expand_path(File.dirname(__FILE__) + '/../shared_examples')
 
-describe User do
+RSpec.describe User do
   let(:user) { build(:user) }
 
   include_examples "there are users with and without avatars"

modules/avatars/spec/requests/user_avatar_api_spec.rb

@@ -29,7 +29,7 @@
 require 'spec_helper'
 require 'rack/test'
 
-describe 'API v3 User avatar resource', content_type: :json do
+RSpec.describe 'API v3 User avatar resource', content_type: :json do
   include Rack::Test::Methods
   include API::V3::Utilities::PathHelper
 

modules/avatars/spec/services/avatars/update_service_spec.rb

@@ -1,6 +1,6 @@
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
-describe Avatars::UpdateService do
+RSpec.describe Avatars::UpdateService do
   let(:user_without_avatar) { build_stubbed(:user) }
   let(:user_with_avatar) do
     u = create(:user)

modules/avatars/spec/shared_examples.rb

@@ -1,4 +1,4 @@
-shared_examples_for "an action checked for required login" do
+RSpec.shared_examples_for "an action checked for required login" do
   describe "WITH no login required" do
     before do
       allow(Setting).to receive(:login_required?).and_return(false)
@@ -22,7 +22,7 @@ shared_examples_for "an action checked for required login" do
   end
 end
 
-shared_examples_for "an action requiring login" do
+RSpec.shared_examples_for "an action requiring login" do
   let(:current) { create(:user) }
 
   before do
@@ -48,7 +48,7 @@ shared_examples_for "an action requiring login" do
   end
 end
 
-shared_examples_for "an action requiring admin" do
+RSpec.shared_examples_for "an action requiring admin" do
   let(:current) { create(:admin) }
 
   before do
@@ -89,7 +89,7 @@ shared_examples_for "an action requiring admin" do
     end
   end
 end
-shared_context "there are users with and without avatars" do
+RSpec.shared_context "there are users with and without avatars" do
   let(:base_path) { File.expand_path 'fixtures', __dir__ }
   let(:user_without_avatar) { create(:user) }
   let(:user_with_avatar) do
@@ -117,7 +117,7 @@ shared_context "there are users with and without avatars" do
     testfile
   end
 end
-shared_examples_for "an action with an invalid user" do
+RSpec.shared_examples_for "an action with an invalid user" do
   it do
     do_action
     expect(response).not_to be_success
@@ -125,13 +125,13 @@ shared_examples_for "an action with an invalid user" do
   end
 end
 
-shared_context "an action with stubbed User.find" do
+RSpec.shared_context "an action with stubbed User.find" do
   before do
     allow(user).to receive(:save).and_return true if user
     allow(User).to receive(:find) { |id, _args| id.to_s == "0" ? nil : user }
   end
 end
-shared_examples_for "an action that deletes the user's avatar" do
+RSpec.shared_examples_for "an action that deletes the user's avatar" do
   it do
     expect_any_instance_of(Attachment).to receive(:destroy).and_call_original
     do_action

modules/backlogs/spec/api/work_package_resource_spec.rb

@@ -29,7 +29,7 @@
 require 'spec_helper'
 require 'rack/test'
 
-describe 'API v3 Work package resource' do
+RSpec.describe 'API v3 Work package resource' do
   include Rack::Test::Methods
   include Capybara::RSpecMatchers
 

modules/backlogs/spec/api/work_packages/form_resource_spec.rb

@@ -29,7 +29,7 @@
 require 'spec_helper'
 require 'rack/test'
 
-describe 'API v3 Work package form resource' do
+RSpec.describe 'API v3 Work package form resource' do
   include Rack::Test::Methods
   include Capybara::RSpecMatchers
 

modules/backlogs/spec/api/work_packages/schema/specific_work_package_schema_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe API::V3::WorkPackages::Schema::SpecificWorkPackageSchema do
+RSpec.describe API::V3::WorkPackages::Schema::SpecificWorkPackageSchema do
   let(:project) { build(:project) }
   let(:type) { build(:type) }
   let(:work_package) do

modules/backlogs/spec/api/work_packages/work_package_schema_representer_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe API::V3::WorkPackages::Schema::WorkPackageSchemaRepresenter do
+RSpec.describe API::V3::WorkPackages::Schema::WorkPackageSchemaRepresenter do
   let(:custom_field) { build(:custom_field) }
   let(:work_package) { build_stubbed(:work_package, type: build_stubbed(:type)) }
   let(:current_user) do

modules/backlogs/spec/contracts/work_packages/base_contract_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper")
 
-describe WorkPackages::BaseContract, type: :model do
+RSpec.describe WorkPackages::BaseContract, type: :model do
   let(:instance) { described_class.new(work_package, user) }
   let(:type_feature) { build(:type_feature) }
   let(:type_task) { build(:type_task) }

modules/backlogs/spec/contracts/work_packages/create_contract_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe WorkPackages::CreateContract do
+RSpec.describe WorkPackages::CreateContract do
   let(:work_package) { build(:work_package, author: other_user, project:) }
   let(:other_user) { build_stubbed(:user) }
   let(:project) { build_stubbed(:project) }

modules/backlogs/spec/contracts/work_packages/update_contract_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe WorkPackages::UpdateContract do
+RSpec.describe WorkPackages::UpdateContract do
   let(:work_package) do
     create(:work_package,
            done_ratio: 50,

modules/backlogs/spec/controllers/backlogs_settings_controller_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe BacklogsSettingsController do
+RSpec.describe BacklogsSettingsController do
   current_user { build_stubbed(:admin) }
 
   describe 'GET show' do

modules/backlogs/spec/controllers/versions_controller_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe VersionsController do
+RSpec.describe VersionsController do
   let(:version) do
     create(:version,
            sharing: 'system')

modules/backlogs/spec/features/backlogs/create_story_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe 'Backlogs', js: true do
+RSpec.describe 'Backlogs', js: true do
   let(:story_type) do
     create(:type_feature)
   end

modules/backlogs/spec/features/backlogs_in_backlog_view_spec.rb

@@ -29,8 +29,8 @@
 require 'spec_helper'
 require_relative '../support/pages/backlogs'
 
-describe 'Backlogs in backlog view',
-         js: true do
+RSpec.describe 'Backlogs in backlog view',
+               js: true do
   let!(:project) do
     create(:project,
            types: [story, task],

modules/backlogs/spec/features/empty_backlogs_spec.rb

@@ -28,8 +28,8 @@
 
 require 'spec_helper'
 
-describe 'Empty backlogs project',
-         js: true do
+RSpec.describe 'Empty backlogs project',
+               js: true do
   let(:project) { create(:project, types: [story, task], enabled_module_names: %w(backlogs)) }
   let(:story) { create(:type_feature) }
   let(:task) { create(:type_task) }

modules/backlogs/spec/features/impediments_spec.rb

@@ -28,8 +28,8 @@
 
 require 'spec_helper'
 
-describe 'Impediments on taskboard',
-         js: true do
+RSpec.describe 'Impediments on taskboard',
+               js: true do
   let!(:project) do
     create(:project,
            types: [story, task],

modules/backlogs/spec/features/onboarding/backlogs_onboarding_tour_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe 'backlogs onboarding tour', js: true do
+RSpec.describe 'backlogs onboarding tour', js: true do
   let(:next_button) { find('.enjoyhint_next_btn') }
   let(:user) { create(:admin) }
   let(:demo_project) do

modules/backlogs/spec/features/resolved_status_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe 'Resolved status' do
+RSpec.describe 'Resolved status' do
   let!(:project) do
     create(:project,
            enabled_module_names: %w(backlogs))

modules/backlogs/spec/features/stories_in_backlog_spec.rb

@@ -29,8 +29,8 @@
 require 'spec_helper'
 require_relative '../support/pages/backlogs'
 
-describe 'Stories in backlog',
-         js: true do
+RSpec.describe 'Stories in backlog',
+               js: true do
   let!(:project) do
     create(:project,
            types: [story, task, other_story],

modules/backlogs/spec/features/tasks_on_taskboard_spec.rb

@@ -29,8 +29,8 @@
 require 'spec_helper'
 require_relative '../support/pages/taskboard'
 
-describe 'Tasks on taskboard',
-         js: true do
+RSpec.describe 'Tasks on taskboard',
+               js: true do
   let!(:project) do
     create(:project,
            types: [story, task, other_story],

modules/backlogs/spec/features/work_packages/filter_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe 'Filter by backlog type', js: true do
+RSpec.describe 'Filter by backlog type', js: true do
   let(:story_type) do
     type = create(:type_feature)
     project.types << type

modules/backlogs/spec/features/work_packages/remaining_time_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe 'Work packages remaining time', js: true do
+RSpec.describe 'Work packages remaining time', js: true do
   before do
     allow(User).to receive(:current).and_return current_user
     allow(Setting).to receive(:plugin_openproject_backlogs).and_return('points_burn_direction' => 'down',

modules/backlogs/spec/features/work_packages/story_points_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe 'Work packages having story points', js: true do
+RSpec.describe 'Work packages having story points', js: true do
   before do
     allow(User).to receive(:current).and_return current_user
     allow(Setting).to receive(:plugin_openproject_backlogs).and_return('points_burn_direction' => 'down',

modules/backlogs/spec/helpers/version_settings_helper_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-describe VersionSettingsHelper do
+RSpec.describe VersionSettingsHelper do
   describe '#position_display_options' do
     before do
       @expected_options = [[I18n.t('version_settings_display_option_none'), 1],

modules/backlogs/spec/models/backlog_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-describe Backlog do
+RSpec.describe Backlog do
   let(:project) { build(:project) }
 
   before do

modules/backlogs/spec/models/burndown_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path("#{File.dirname(__FILE__)}/../spec_helper")
 
-describe Burndown do
+RSpec.describe Burndown do
   def set_attribute_journalized(story, attribute, value, day)
     story.reload
     story.send(attribute, value)

modules/backlogs/spec/models/impediment_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-describe Impediment do
+RSpec.describe Impediment do
   let(:user) { @user ||= create(:user) }
   let(:role) { @role ||= create(:role) }
   let(:type_feature) { @type_feature ||= create(:type_feature) }

modules/backlogs/spec/models/issue_position_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-describe WorkPackage do
+RSpec.describe WorkPackage do
   describe 'Story positions' do
     def build_work_package(options)
       build(:work_package, options.reverse_merge(version_id: sprint_1.id,

modules/backlogs/spec/models/issue_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-describe WorkPackage do
+RSpec.describe WorkPackage do
   describe 'validations' do
     let(:work_package) do
       build(:work_package)

modules/backlogs/spec/models/sprint_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-describe Sprint do
+RSpec.describe Sprint do
   let(:sprint) { build(:sprint) }
   let(:project) { build(:project) }
 

modules/backlogs/spec/models/story_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-describe Story do
+RSpec.describe Story do
   let(:user) { @user ||= create(:user) }
   let(:role) { @role ||= create(:role) }
   let(:status1) { @status1 ||= create(:status, name: 'status 1', is_default: true) }

modules/backlogs/spec/models/task_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-describe Task do
+RSpec.describe Task do
   let(:task_type) { create(:type) }
   let(:default_status) { create(:default_status) }
   let(:project) { create(:project) }

modules/backlogs/spec/models/user_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-describe User do
+RSpec.describe User do
   describe 'backlogs_preference' do
     describe 'task_color' do
       it 'reads from and writes to a user preference' do

modules/backlogs/spec/models/version_setting_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-describe VersionSetting do
+RSpec.describe VersionSetting do
   let(:version_setting) { build(:version_setting) }
 
   it { is_expected.to belong_to(:project) }

modules/backlogs/spec/models/version_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-describe Version do
+RSpec.describe Version do
   it { is_expected.to have_many :version_settings }
 
   describe 'rebuild positions' do

modules/backlogs/spec/models/work_package_export_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
-describe WorkPackage::PDFExport::WorkPackageToPdf do
+RSpec.describe WorkPackage::PDFExport::WorkPackageToPdf do
   let(:project) { create(:project) }
   let(:query) { Query.new_default(project:) }
 

modules/backlogs/spec/models/work_package_spec.rb

@@ -28,7 +28,7 @@
 
 require_relative '../spec_helper'
 
-describe WorkPackage do
+RSpec.describe WorkPackage do
   describe '#backlogs_types' do
     it 'returns all the ids of types that are configures to be considered backlogs types' do
       allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'story_types' => [1], 'task_type' => 2 })

modules/backlogs/spec/routing/rb_burndown_charts_routing_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe RbBurndownChartsController do
+RSpec.describe RbBurndownChartsController do
   describe 'routing' do
     it {
       expect(get('/projects/project_42/sprints/21/burndown_chart')).to route_to(controller: 'rb_burndown_charts',

modules/backlogs/spec/routing/rb_impediments_routing_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe RbImpedimentsController do
+RSpec.describe RbImpedimentsController do
   describe 'routing' do
     it {
       expect(post('/projects/project_42/sprints/21/impediments')).to route_to(controller: 'rb_impediments',

modules/backlogs/spec/routing/rb_master_backlogs_routing_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe RbMasterBacklogsController do
+RSpec.describe RbMasterBacklogsController do
   describe 'routing' do
     it {
       expect(get('/projects/project_42/backlogs')).to route_to(controller: 'rb_master_backlogs',

modules/backlogs/spec/routing/rb_queries_routing_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe RbQueriesController do
+RSpec.describe RbQueriesController do
   describe 'routing' do
     it {
       expect(get('/projects/project_42/sprints/21/query')).to route_to(controller: 'rb_queries',

modules/backlogs/spec/routing/rb_sprints_routing_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe RbSprintsController do
+RSpec.describe RbSprintsController do
   describe 'routing' do
     it {
       expect(put('/projects/project_42/sprints/21')).to route_to(controller: 'rb_sprints',

modules/backlogs/spec/routing/rb_stories_routing_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe RbStoriesController do
+RSpec.describe RbStoriesController do
   describe 'routing' do
     it {
       expect(post('/projects/project_42/sprints/21/stories')).to route_to(controller: 'rb_stories',

modules/backlogs/spec/routing/rb_taskboard_card_configurations_routing_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe RbExportCardConfigurationsController do
+RSpec.describe RbExportCardConfigurationsController do
   describe 'routing' do
     it {
       expect(get('/projects/project_42/sprints/21/export_card_configurations/10')).to route_to(controller: 'rb_export_card_configurations',

modules/backlogs/spec/routing/rb_taskboards_routing_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe RbTaskboardsController do
+RSpec.describe RbTaskboardsController do
   describe 'routing' do
     it {
       expect(get('/projects/project_42/sprints/21/taskboard')).to route_to(controller: 'rb_taskboards',

modules/backlogs/spec/routing/rb_tasks_routing_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe RbTasksController do
+RSpec.describe RbTasksController do
   describe 'routing' do
     it {
       expect(post('/projects/project_42/sprints/21/tasks')).to route_to(controller: 'rb_tasks',

modules/backlogs/spec/routing/rb_wikis_routing_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe RbWikisController do
+RSpec.describe RbWikisController do
   describe 'routing' do
     it {
       expect(get('/projects/project_42/sprints/21/wiki')).to route_to(controller: 'rb_wikis',

modules/backlogs/spec/services/impediments/create_services_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe Impediments::CreateService do
+RSpec.describe Impediments::CreateService do
   let(:instance) { described_class.new(user:) }
   let(:impediment_subject) { 'Impediment A' }
 

modules/backlogs/spec/services/impediments/update_service_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
-describe Impediments::UpdateService, type: :model do
+RSpec.describe Impediments::UpdateService, type: :model do
   let(:instance) { described_class.new(user:, impediment:) }
 
   let(:user) { create(:user) }

modules/backlogs/spec/services/stories/create_service_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
-describe Stories::CreateService, type: :model do
+RSpec.describe Stories::CreateService, type: :model do
   let(:priority) { create(:priority) }
   let(:project) do
     project = create(:project, types: [type_feature])

modules/backlogs/spec/services/work_packages/update_ancestors_service_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper")
 
-describe WorkPackages::UpdateAncestorsService do
+RSpec.describe WorkPackages::UpdateAncestorsService do
   let(:user) { create(:user) }
 
   let(:sibling_remaining_hours) { 7.0 }

modules/backlogs/spec/services/work_packages/update_service_version_inheritance_spec.rb

@@ -28,7 +28,7 @@
 
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 
-describe WorkPackages::UpdateService, "version inheritance", type: :model do
+RSpec.describe WorkPackages::UpdateService, "version inheritance", type: :model do
   let(:type_feature) { build(:type_feature) }
   let(:type_task) { build(:type_task) }
   let(:type_bug) { build(:type_bug) }

modules/backlogs/spec/views/rb_burndown_charts/show_spec.rb

@@ -28,7 +28,7 @@
 
 require File.dirname(__FILE__) + '/../../spec_helper'
 
-describe 'rb_burndown_charts/show' do
+RSpec.describe 'rb_burndown_charts/show' do
   let(:user1) { create(:user) }
   let(:user2) { create(:user) }
   let(:role_allowed) do

modules/backlogs/spec/views/rb_master_backlogs/index.html.erb_spec.rb

@@ -28,7 +28,7 @@
 
 require File.dirname(__FILE__) + '/../../spec_helper'
 
-describe 'rb_master_backlogs/index' do
+RSpec.describe 'rb_master_backlogs/index' do
   let(:user) { create(:user) }
   let(:role_allowed) do
     create(:role,

modules/backlogs/spec/views/rb_taskboards/show_spec.rb

@@ -28,7 +28,7 @@
 
 require File.dirname(__FILE__) + '/../../spec_helper'
 
-describe 'rb_taskboards/show' do
+RSpec.describe 'rb_taskboards/show' do
   let(:user1) { create(:user) }
   let(:user2) { create(:user) }
   let(:role_allowed) do

modules/backlogs/spec/views/shared/not_configured_spec.rb

@@ -28,7 +28,7 @@
 
 require_relative '../../spec_helper'
 
-describe 'shared/not_configured' do
+RSpec.describe 'shared/not_configured' do
   it 'renders without errors' do
     render
   end

modules/bim/spec/api/v3/activities/activity_representer_spec.rb

@@ -29,7 +29,7 @@
 require 'spec_helper'
 require_relative '../../../support/bcf_topic_with_stubbed_comment'
 
-describe API::V3::Activities::ActivityRepresenter do
+RSpec.describe API::V3::Activities::ActivityRepresenter do
   include API::Bim::Utilities::PathHelper
 
   include_context 'user with stubbed permissions'

modules/bim/spec/api/v3/queries/filters/query_filter_instance_representer_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe API::V3::Queries::Filters::QueryFilterInstanceRepresenter do
+RSpec.describe API::V3::Queries::Filters::QueryFilterInstanceRepresenter do
   let(:operator) { '=' }
   let(:filter) do
     Bim::Queries::WorkPackages::Filter::BcfIssueAssociatedFilter

modules/bim/spec/api/v3/work_packages/work_package_representer_spec.rb

@@ -30,7 +30,7 @@ require 'spec_helper'
 
 require_relative '../../../support/bcf_topic_with_stubbed_comment'
 
-describe API::V3::WorkPackages::WorkPackageRepresenter do
+RSpec.describe API::V3::WorkPackages::WorkPackageRepresenter do
   include API::V3::Utilities::PathHelper
   include API::Bim::Utilities::PathHelper
   include_context 'user with stubbed permissions'

modules/bim/spec/bcf/bcf_xml/exporter_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe OpenProject::Bim::BcfXml::Exporter do
+RSpec.describe OpenProject::Bim::BcfXml::Exporter do
   let(:query) { build(:global_query) }
   let(:work_package) { create(:work_package) }
   let(:admin) { create(:admin) }

modules/bim/spec/bcf/bcf_xml/importer_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe OpenProject::Bim::BcfXml::Importer do
+RSpec.describe OpenProject::Bim::BcfXml::Importer do
   let(:filename) { 'MaximumInformation.bcf' }
   let(:file) do
     Rack::Test::UploadedFile.new(

modules/bim/spec/bcf/bcf_xml/issue_reader_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe OpenProject::Bim::BcfXml::IssueReader do
+RSpec.describe OpenProject::Bim::BcfXml::IssueReader do
   let(:absolute_file_path) { "63E78882-7C6A-4BF7-8982-FC478AFB9C97/markup.bcf" }
   let(:type) { create(:type, name: 'Issue', is_standard: true, is_default: true) }
   let(:project) do

modules/bim/spec/bcf/bcf_xml/issue_writer_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe OpenProject::Bim::BcfXml::IssueWriter do
+RSpec.describe OpenProject::Bim::BcfXml::IssueWriter do
   let(:project) { create(:project) }
   let(:markup) do
     <<-MARKUP

modules/bim/spec/bcf/bcf_xml/markup_extractor_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe OpenProject::Bim::BcfXml::MarkupExtractor do
+RSpec.describe OpenProject::Bim::BcfXml::MarkupExtractor do
   let(:filename) { 'MaximumInformation.bcf' }
   let(:file) do
     Rack::Test::UploadedFile.new(

modules/bim/spec/contracts/bcf/issues/create_contract_spec.rb

@@ -29,7 +29,7 @@
 require 'spec_helper'
 require_relative './shared_contract_examples'
 
-describe Bim::Bcf::Issues::CreateContract do
+RSpec.describe Bim::Bcf::Issues::CreateContract do
   it_behaves_like 'issues contract' do
     let(:issue) do
       Bim::Bcf::Issue.new(uuid: issue_uuid,

modules/bim/spec/contracts/bcf/issues/shared_contract_examples.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-shared_examples_for 'issues contract' do
+RSpec.shared_examples_for 'issues contract' do
   let(:current_user) do
     build_stubbed(:user)
   end

modules/bim/spec/contracts/bcf/issues/update_contract_spec.rb

@@ -29,7 +29,7 @@
 require 'spec_helper'
 require_relative './shared_contract_examples'
 
-describe Bim::Bcf::Issues::UpdateContract do
+RSpec.describe Bim::Bcf::Issues::UpdateContract do
   it_behaves_like 'issues contract' do
     let(:issue) do
       build_stubbed(:bcf_issue,

modules/bim/spec/contracts/bcf/viewpoints/create_contract_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe Bim::Bcf::Viewpoints::CreateContract do
+RSpec.describe Bim::Bcf::Viewpoints::CreateContract do
   let(:viewpoint) do
     Bim::Bcf::Viewpoint.new(uuid: viewpoint_uuid,
                             issue: viewpoint_issue,

modules/bim/spec/contracts/ifc_models/create_contract_spec.rb

@@ -29,7 +29,7 @@
 require 'spec_helper'
 require_relative './shared_contract_examples'
 
-describe Bim::IfcModels::CreateContract do
+RSpec.describe Bim::IfcModels::CreateContract do
   it_behaves_like 'ifc model contract' do
     let(:ifc_model) do
       Bim::IfcModels::IfcModel.new(project: model_project,

modules/bim/spec/contracts/ifc_models/shared_contract_examples.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-shared_examples_for 'ifc model contract' do
+RSpec.shared_examples_for 'ifc model contract' do
   let(:current_user) { build_stubbed(:user) }
   let(:other_user) { build_stubbed(:user) }
   let(:model_project) { build_stubbed(:project) }

modules/bim/spec/contracts/ifc_models/update_contract_spec.rb

@@ -29,7 +29,7 @@
 require 'spec_helper'
 require_relative './shared_contract_examples'
 
-describe Bim::IfcModels::UpdateContract do
+RSpec.describe Bim::IfcModels::UpdateContract do
   it_behaves_like 'ifc model contract' do
     subject(:contract) { described_class.new(ifc_model, current_user) }
 

modules/bim/spec/contracts/views/create_contract_bim_spec.rb

@@ -30,7 +30,7 @@ require 'spec_helper'
 require 'contracts/shared/model_contract_shared_context'
 require 'contracts/views/shared_contract_examples'
 
-describe Views::CreateContract do
+RSpec.describe Views::CreateContract do
   it_behaves_like 'view contract', true do
     let(:view) do
       View.new(query: view_query,

modules/bim/spec/controllers/issues_controller_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe Bim::Bcf::IssuesController do
+RSpec.describe Bim::Bcf::IssuesController do
   let(:manage_bcf_role) do
     create(:role,
            permissions: %i[manage_bcf view_linked_issues view_work_packages add_work_packages edit_work_packages])

modules/bim/spec/controllers/work_packages_controller_spec.rb

@@ -28,7 +28,7 @@
 
 require 'spec_helper'
 
-describe WorkPackagesController do
+RSpec.describe WorkPackagesController do
   before do
     login_as current_user
   end

modules/bim/spec/features/bcf/api_authorization_spec.rb

@@ -28,8 +28,8 @@
 
 require 'spec_helper'
 
-describe 'authorization for BCF api',
-         js: true, with_config: { edition: 'bim' } do
+RSpec.describe 'authorization for BCF api',
+               js: true, with_config: { edition: 'bim' } do
   let!(:user) { create(:admin) }
   let(:client_secret) { app.plaintext_secret }
   let(:scope) { 'bcf_v2_1' }

modules/bim/spec/features/bcf/bcf_snapshot_column_spec.rb

@@ -1,9 +1,9 @@
 require 'spec_helper'
 
-describe 'BCF snapshot column',
-         js: true,
-         with_config: { edition: 'bim' },
-         with_mail: false do
+RSpec.describe 'BCF snapshot column',
+               js: true,
+               with_config: { edition: 'bim' },
+               with_mail: false do
   let(:project) { create(:project, enabled_module_names: %w[bim work_package_tracking]) }
   let(:wp_table) { Pages::WorkPackagesTable.new(project) }
   let(:permissions) { %i[add_work_packages view_work_packages view_linked_issues] }

modules/bim/spec/features/bcf/create_spec.rb

@@ -1,9 +1,9 @@
 require_relative '../../spec_helper'
 
-describe 'Create BCF',
-         js: true,
-         with_config: { edition: 'bim' },
-         with_mail: false do
+RSpec.describe 'Create BCF',
+               js: true,
+               with_config: { edition: 'bim' },
+               with_mail: false do
   let(:project) do
     create(:project,
            types: [type, type_with_cf],

modules/bim/spec/features/bcf/export_spec.rb

@@ -28,9 +28,9 @@
 require 'spec_helper'
 require_relative '../../support/pages/ifc_models/show_default'
 
-describe 'bcf export',
-         js: true,
-         with_config: { edition: 'bim' } do
+RSpec.describe 'bcf export',
+               js: true,
+               with_config: { edition: 'bim' } do
   let(:status) { create(:status, name: 'New', is_default: true) }
   let(:closed_status) { create(:closed_status, name: 'Closed') }
   let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }

modules/bim/spec/features/bcf_view_management_spec.rb

@@ -31,8 +31,8 @@ require 'spec_helper'
 require_relative '../support/pages/ifc_models/show_default'
 require_relative '../../../../spec/features/views/shared_examples'
 
-describe 'bcf view management',
-         js: true, with_config: { edition: 'bim' } do
+RSpec.describe 'bcf view management',
+               js: true, with_config: { edition: 'bim' } do
   let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }
   let(:bcf_page) { Pages::IfcModels::ShowDefault.new(project) }
   let(:role) do

modules/bim/spec/features/bim_filter_spec.rb

@@ -31,8 +31,8 @@ require 'spec_helper'
 require_relative '../support/pages/ifc_models/show'
 require_relative '../support/pages/ifc_models/show_default'
 
-describe 'BIM filter spec',
-         js: true, with_config: { edition: 'bim' } do
+RSpec.describe 'BIM filter spec',
+               js: true, with_config: { edition: 'bim' } do
   let(:project) { create(:project, enabled_module_names: %w(bim work_package_tracking)) }
   let(:open_status) { create(:status, is_closed: false) }
   let(:closed_status) { create(:status, is_closed: true) }

modules/bim/spec/features/bim_navigation_spec.rb

@@ -28,8 +28,8 @@
 
 require_relative '../spec_helper'
 
-describe 'BIM navigation spec',
-         js: true, with_config: { edition: 'bim' } do
+RSpec.describe 'BIM navigation spec',
+               js: true, with_config: { edition: 'bim' } do
   let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }
   let!(:work_package) { create(:work_package, project:) }
   let(:role) do

modules/bim/spec/features/ifc_models/direct_ifc_upload_spec.rb

@@ -29,7 +29,7 @@
 require 'spec_helper'
 require_relative './ifc_upload_shared_examples'
 
-describe 'direct IFC upload', js: true, with_config: { edition: 'bim' }, with_direct_uploads: :redirect do
+RSpec.describe 'direct IFC upload', js: true, with_config: { edition: 'bim' }, with_direct_uploads: :redirect do
   it_behaves_like 'can upload an IFC file' do
     # with direct upload, we don't get the model name
     let(:model_name) { 'model.ifc' }

modules/bim/spec/features/ifc_models/ifc_upload_shared_examples.rb

@@ -1,4 +1,4 @@
-shared_examples 'can upload an IFC file' do
+RSpec.shared_examples 'can upload an IFC file' do
   let(:user) { create(:admin) }
   let(:project) { create(:project, enabled_module_names: %i[bim]) }
   let(:ifc_fixture) { UploadedFile.load_from('modules/bim/spec/fixtures/files/minimal.ifc') }

modules/bim/spec/features/ifc_models/regular_ifc_upload_spec.rb

@@ -29,7 +29,7 @@
 require 'spec_helper'
 require_relative './ifc_upload_shared_examples'
 
-describe 'IFC upload', js: true, with_config: { edition: 'bim' } do
+RSpec.describe 'IFC upload', js: true, with_config: { edition: 'bim' } do
   it_behaves_like 'can upload an IFC file' do
     let(:model_name) { 'minimal.ifc' }
   end