mirror of
https://github.com/opf/openproject.git
synced 2026-06-13 19:20:00 +00:00
e8767481e9
* Fix GitHub/NoTitleAttribute, LinkHasHref errors - Replaces `title` attribute with `aria-label` for interactive elements. - Removes `title` from non-interactive elements. - Converts `<a>` tags without proper `href` to `<button>` elements, using Primer `Button`/`IconButton` where possible. # Conflicts: # app/views/custom_fields/_custom_options.html.erb # spec/features/admin/custom_fields/shared_custom_field_expectations.rb # spec/features/admin/custom_fields/work_packages/list_spec.rb * Fix Autocomplete missing errors * Fix GitHub/NoPositiveTabIndex errors Removes all positive `tabindex` values. * Fix Rails/LinkToBlank errors * Replace toast with Primer Banner on LDAP form * Add frozen_string_literal * Ignore erb lint for deprecated files * Fix linting errors in repository module * Fix linting errors in budgets and custom actions * Fix linting errors in member form and 2fa * Fix linting errors in mcost types and wiki help and storages * Fix linting errors in multi select filters, ifc viewer, and unsupported browser banner * Fix failing spec * Use Primer banner instead of op-toast where ever it is possible * Use octicon instead of op_icon * Fix failing tests * Use no-decoration-on-hover for button links and change the button with only an icon to primer icon button * Keep webhook response modal activation selector class-based * use icon button for edit of hourly rate --------- Co-authored-by: Behrokh Satarnejad <b.satarnejad@openproject.com>
105 lines
3.6 KiB
Ruby
105 lines
3.6 KiB
Ruby
#-- copyright
|
|
# OpenProject is an open source project management software.
|
|
# Copyright (C) the OpenProject GmbH
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License version 3.
|
|
#
|
|
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
|
|
# Copyright (C) 2006-2013 Jean-Philippe Lang
|
|
# Copyright (C) 2010-2013 the ChiliProject Team
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License
|
|
# as published by the Free Software Foundation; either version 2
|
|
# of the License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
#
|
|
# See COPYRIGHT and LICENSE files for more details.
|
|
#++
|
|
|
|
require_relative "../spec_helper"
|
|
|
|
RSpec.describe "show default model", :js, with_config: { edition: "bim" } do
|
|
let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) }
|
|
let(:index_page) { Pages::IfcModels::Index.new(project) }
|
|
let(:show_default_page) { Pages::IfcModels::ShowDefault.new(project) }
|
|
let(:role) { create(:project_role, permissions: %i[view_ifc_models view_work_packages manage_ifc_models]) }
|
|
|
|
let(:user) do
|
|
create(:user,
|
|
member_with_roles: { project => role })
|
|
end
|
|
|
|
let(:model) do
|
|
create(:ifc_model_minimal_converted,
|
|
is_default: model_is_default,
|
|
project:,
|
|
uploader: user)
|
|
end
|
|
let(:model_is_default) { true }
|
|
let(:model_tree) { Components::XeokitModelTree.new }
|
|
|
|
before do
|
|
login_as(user)
|
|
model
|
|
end
|
|
|
|
context "when the work package module not loaded" do
|
|
let(:project) { create(:project, enabled_module_names: [:bim]) }
|
|
|
|
it "shows an error loading the page" do
|
|
show_default_page.visit!
|
|
show_default_page.expect_toast(type: :error, message: "Your view is erroneous and could not be processed")
|
|
end
|
|
end
|
|
|
|
context "with everything ready" do
|
|
let(:old_work_package) { create(:work_package, project:) }
|
|
let(:new_work_package) { create(:work_package, project:) }
|
|
|
|
before do
|
|
old_work_package
|
|
new_work_package
|
|
|
|
show_default_page.visit!
|
|
show_default_page.finished_loading
|
|
end
|
|
|
|
it "loads and shows the viewer and WPs correctly" do
|
|
expect(show_default_page).to have_test_selector("op-breadcrumbs--item", text: "BCF")
|
|
expect(show_default_page).to have_css(".op-breadcrumbs--current", text: "All open", aria: { current: "page" })
|
|
|
|
show_default_page.model_viewer_visible true
|
|
show_default_page.model_viewer_shows_a_toolbar true
|
|
show_default_page.page_shows_a_toolbar true
|
|
model_tree.sidebar_shows_viewer_menu true
|
|
|
|
# Check the order of work packages: Latest first
|
|
expect(show_default_page.find_all(".op-wp-single-card--content-id").map(&:text)).to(
|
|
eql(["##{new_work_package.id}", "##{old_work_package.id}"])
|
|
)
|
|
end
|
|
end
|
|
|
|
context "with the default model not being processed" do
|
|
before do
|
|
model.xkt_attachment.destroy
|
|
|
|
show_default_page.visit!
|
|
end
|
|
|
|
it "renders a notification" do
|
|
expect(page).to have_css(".Banner", text: I18n.t(:"ifc_models.processing_notice.processing_default"))
|
|
end
|
|
end
|
|
end
|