This should fix the last known unit test failures occuring due to the usage of
frozen string literal comments. Those were tested in a separate
commit. Broadly enabling frozen string literals will happen in multiple
separate commits after this one and only after feature tests have been fixed
as well.
:change_work_package_status permission is additive, but not disjunct
with :edit_work_packages - this means:
- no DB migration is needed, :edit_work_packages will work as before
- :change_work_package_status added to some tests was removed again
Permission `change_work_package_status` was added to tests that already
used `edit_work_packages`.
There are broken tests using `add_work_packages`, mostly around boards
and backlogs, this will be fixed in the code later.
Found via `codespell -q 3 -S ./.git,./config/locales,./modules/xls_export/config/locales,./modules/job_status/config/locales,./modules/two_factor_authentication/config/locales,./modules/backlogs/config/locales/crowdin,./**/config/locales,./frontend/src/vendor -L ba,inflight,nd,parms,pullrequest,pullrequests,sur,varius`
* Remove work_packages_duration_field_active feature flag
Duration is now globally active for 12.3.0.
* Remove `ignore_non_working_days: false` in tests
Not needed anymore as it is now the default value. Keep it where the test explicitly refers to it, for clarity.
Co-authored-by: Christophe Bliard <c.bliard@openproject.com>
The mail being passed to UserMailer cannot be serialized by ActiveJob,
so this fails whenever background jobs are being used.
Instead of trying to pass a Mail::Message, only pass in the values we
need to send out the response.
https://community.openproject.org/wp/35823
* error reply for failed incoming email
* deprecated date.to_s(:db) replaced with to_fs(:db)
* rubocop concessions
* nest away
* do not report errors to unknown users by default
* use verifying double
* Fix argument alignment since f08bea3467
The FactoryBot.* prefix has been removed in f08bea3467. Since then
rubocop complains about Layout/ArgumentAlignment. This commit fixes it.
* do not fix alignments for modules/*/spec yet
hoping to be under the limit of 65535 characters for reviewdog to report on rubocop errors
Oliver Günther