references/openproject
1
0
Fork 0
mirror of https://github.com/opf/openproject.git synced 2026-06-13 19:20:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add consistent turbo wait for all project filter removal

Browse Source 
Trying to fix spec/features/projects/lists/filters_spec.rb
This commit is contained in:
Oliver Günther
2026-06-09 10:02:32 +02:00
parent 3a15d56e51
commit ca70a08bb3
2 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/features/projects/lists/filters_spec.rb
+8 -8
View File
@@ -790,7 +790,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f
projects_page.expect_projects_not_listed(development_project)
projects_page.expect_projects_in_order(project, public_project)
wait_for_turbo_stream { projects_page.remove_filter("project_phase_any") }
projects_page.remove_filter("project_phase_any")
projects_page.expect_projects_in_order(development_project, project, public_project)
@@ -801,7 +801,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f
projects_page.expect_projects_not_listed(development_project)
projects_page.expect_projects_in_order(project, public_project)
wait_for_turbo_stream { projects_page.remove_filter("project_phase_any") }
projects_page.remove_filter("project_phase_any")
projects_page.expect_projects_in_order(development_project, project, public_project)
@@ -813,7 +813,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f
projects_page.expect_projects_not_listed(development_project)
projects_page.expect_projects_in_order(project, public_project)
wait_for_turbo_stream { projects_page.remove_filter("project_phase_any") }
projects_page.remove_filter("project_phase_any")
projects_page.expect_projects_in_order(development_project, project, public_project)
@@ -824,7 +824,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f
projects_page.expect_projects_not_listed(development_project)
projects_page.expect_projects_in_order(project, public_project)
wait_for_turbo_stream { projects_page.remove_filter("project_phase_any") }
projects_page.remove_filter("project_phase_any")
projects_page.expect_projects_in_order(development_project, project, public_project)
@@ -933,7 +933,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f
projects_page.expect_projects_not_listed(development_project, project)
projects_page.expect_projects_in_order(public_project)
wait_for_turbo_stream { projects_page.remove_filter("project_finish_gate_#{gate.definition_id}") }
projects_page.remove_filter("project_finish_gate_#{gate.definition_id}")
projects_page.expect_projects_in_order(development_project, project, public_project)
@@ -944,7 +944,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f
projects_page.expect_projects_not_listed(development_project, project)
projects_page.expect_projects_in_order(public_project)
wait_for_turbo_stream { projects_page.remove_filter("project_finish_gate_#{gate.definition_id}") }
projects_page.remove_filter("project_finish_gate_#{gate.definition_id}")
projects_page.expect_projects_in_order(development_project, project, public_project)
@@ -956,7 +956,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f
projects_page.expect_projects_not_listed(development_project, project)
projects_page.expect_projects_in_order(public_project)
wait_for_turbo_stream { projects_page.remove_filter("project_finish_gate_#{gate.definition_id}") }
projects_page.remove_filter("project_finish_gate_#{gate.definition_id}")
projects_page.expect_projects_in_order(development_project, project, public_project)
@@ -967,7 +967,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f
projects_page.expect_projects_not_listed(development_project, project)
projects_page.expect_projects_in_order(public_project)
wait_for_turbo_stream { projects_page.remove_filter("project_finish_gate_#{gate.definition_id}") }
projects_page.remove_filter("project_finish_gate_#{gate.definition_id}")
projects_page.expect_projects_in_order(development_project, project, public_project)
spec/support/components/common/filters.rb
+3 -1
View File
@@ -126,7 +126,9 @@ module Components
if name == "name_and_identifier"
page.find_by_id("name_and_identifier").find(:xpath, "following-sibling::button").click
else
page.find("li[data-filter-name='#{name}'] .filter_rem").click
wait_for_turbo_stream do
page.find("li[data-filter-name='#{name}'] .filter_rem").click
end
end
end