From ca70a08bb3b29f7f34ec80065ca6e9733aed7cc3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliver=20G=C3=BCnther?= Date: Tue, 9 Jun 2026 10:02:32 +0200 Subject: [PATCH] Add consistent turbo wait for all project filter removal Trying to fix spec/features/projects/lists/filters_spec.rb --- spec/features/projects/lists/filters_spec.rb | 16 ++++++++-------- spec/support/components/common/filters.rb | 4 +++- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/spec/features/projects/lists/filters_spec.rb b/spec/features/projects/lists/filters_spec.rb index 441356c85af..319ab33c386 100644 --- a/spec/features/projects/lists/filters_spec.rb +++ b/spec/features/projects/lists/filters_spec.rb @@ -790,7 +790,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f projects_page.expect_projects_not_listed(development_project) projects_page.expect_projects_in_order(project, public_project) - wait_for_turbo_stream { projects_page.remove_filter("project_phase_any") } + projects_page.remove_filter("project_phase_any") projects_page.expect_projects_in_order(development_project, project, public_project) @@ -801,7 +801,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f projects_page.expect_projects_not_listed(development_project) projects_page.expect_projects_in_order(project, public_project) - wait_for_turbo_stream { projects_page.remove_filter("project_phase_any") } + projects_page.remove_filter("project_phase_any") projects_page.expect_projects_in_order(development_project, project, public_project) @@ -813,7 +813,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f projects_page.expect_projects_not_listed(development_project) projects_page.expect_projects_in_order(project, public_project) - wait_for_turbo_stream { projects_page.remove_filter("project_phase_any") } + projects_page.remove_filter("project_phase_any") projects_page.expect_projects_in_order(development_project, project, public_project) @@ -824,7 +824,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f projects_page.expect_projects_not_listed(development_project) projects_page.expect_projects_in_order(project, public_project) - wait_for_turbo_stream { projects_page.remove_filter("project_phase_any") } + projects_page.remove_filter("project_phase_any") projects_page.expect_projects_in_order(development_project, project, public_project) @@ -933,7 +933,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f projects_page.expect_projects_not_listed(development_project, project) projects_page.expect_projects_in_order(public_project) - wait_for_turbo_stream { projects_page.remove_filter("project_finish_gate_#{gate.definition_id}") } + projects_page.remove_filter("project_finish_gate_#{gate.definition_id}") projects_page.expect_projects_in_order(development_project, project, public_project) @@ -944,7 +944,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f projects_page.expect_projects_not_listed(development_project, project) projects_page.expect_projects_in_order(public_project) - wait_for_turbo_stream { projects_page.remove_filter("project_finish_gate_#{gate.definition_id}") } + projects_page.remove_filter("project_finish_gate_#{gate.definition_id}") projects_page.expect_projects_in_order(development_project, project, public_project) @@ -956,7 +956,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f projects_page.expect_projects_not_listed(development_project, project) projects_page.expect_projects_in_order(public_project) - wait_for_turbo_stream { projects_page.remove_filter("project_finish_gate_#{gate.definition_id}") } + projects_page.remove_filter("project_finish_gate_#{gate.definition_id}") projects_page.expect_projects_in_order(development_project, project, public_project) @@ -967,7 +967,7 @@ RSpec.describe "Projects list filters", :js, with_settings: { login_required?: f projects_page.expect_projects_not_listed(development_project, project) projects_page.expect_projects_in_order(public_project) - wait_for_turbo_stream { projects_page.remove_filter("project_finish_gate_#{gate.definition_id}") } + projects_page.remove_filter("project_finish_gate_#{gate.definition_id}") projects_page.expect_projects_in_order(development_project, project, public_project) diff --git a/spec/support/components/common/filters.rb b/spec/support/components/common/filters.rb index 93a946a0cf9..92b839c8b28 100644 --- a/spec/support/components/common/filters.rb +++ b/spec/support/components/common/filters.rb @@ -126,7 +126,9 @@ module Components if name == "name_and_identifier" page.find_by_id("name_and_identifier").find(:xpath, "following-sibling::button").click else - page.find("li[data-filter-name='#{name}'] .filter_rem").click + wait_for_turbo_stream do + page.find("li[data-filter-name='#{name}'] .filter_rem").click + end end end