references/openproject
1
0
Fork 0
mirror of https://github.com/opf/openproject.git synced 2026-06-13 19:20:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

[#73887] Remove superfluous project presence checks

Browse Source 
allowed_in_project? will return false for nil-projects, so this check is
not needed.
This commit is contained in:
Tobias Dillmann
2026-06-10 15:10:16 +02:00
committed by Tobias Dillmann
parent d96781f7b1
commit 9b7ca3238b
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/backlogs/lib/open_project/backlogs/patches/api/work_package_representer.rb
+2 -6
View File
@@ -48,8 +48,7 @@ module OpenProject::Backlogs
resource :sprint,
link_cache_if: ->(*) {
represented.project.present? &&
current_user.allowed_in_project?(:view_sprints, represented.project)
current_user.allowed_in_project?(:view_sprints, represented.project)
},
link: ->(*) {
if represented.sprint.present?
@@ -65,7 +64,6 @@ module OpenProject::Backlogs
},
getter: ->(*) do
if embed_links &&
represented.project.present? &&
represented.sprint.present? &&
current_user.allowed_in_project?(:view_sprints, represented.project)
::API::V3::Sprints::SprintRepresenter.create(represented.sprint, current_user:)
@@ -75,8 +73,7 @@ module OpenProject::Backlogs
resource :backlog_bucket,
link_cache_if: ->(*) {
represented.project.present? &&
current_user.allowed_in_project?(:view_sprints, represented.project)
current_user.allowed_in_project?(:view_sprints, represented.project)
},
link: ->(*) {
if represented.backlog_bucket.present?
@@ -92,7 +89,6 @@ module OpenProject::Backlogs
},
getter: ->(*) do
if embed_links &&
represented.project.present? &&
represented.backlog_bucket.present? &&
current_user.allowed_in_project?(:view_sprints, represented.project)
::API::V3::BacklogBuckets::BacklogBucketRepresenter.create(represented.backlog_bucket, current_user:)