From 9b7ca3238b9f0360c65e86787f917497d471c6ca Mon Sep 17 00:00:00 2001 From: Tobias Dillmann Date: Wed, 10 Jun 2026 15:10:16 +0200 Subject: [PATCH] [#73887] Remove superfluous project presence checks allowed_in_project? will return false for nil-projects, so this check is not needed. --- .../backlogs/patches/api/work_package_representer.rb | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/modules/backlogs/lib/open_project/backlogs/patches/api/work_package_representer.rb b/modules/backlogs/lib/open_project/backlogs/patches/api/work_package_representer.rb index 40439ffd5d8..3dc41979d00 100644 --- a/modules/backlogs/lib/open_project/backlogs/patches/api/work_package_representer.rb +++ b/modules/backlogs/lib/open_project/backlogs/patches/api/work_package_representer.rb @@ -48,8 +48,7 @@ module OpenProject::Backlogs resource :sprint, link_cache_if: ->(*) { - represented.project.present? && - current_user.allowed_in_project?(:view_sprints, represented.project) + current_user.allowed_in_project?(:view_sprints, represented.project) }, link: ->(*) { if represented.sprint.present? @@ -65,7 +64,6 @@ module OpenProject::Backlogs }, getter: ->(*) do if embed_links && - represented.project.present? && represented.sprint.present? && current_user.allowed_in_project?(:view_sprints, represented.project) ::API::V3::Sprints::SprintRepresenter.create(represented.sprint, current_user:) @@ -75,8 +73,7 @@ module OpenProject::Backlogs resource :backlog_bucket, link_cache_if: ->(*) { - represented.project.present? && - current_user.allowed_in_project?(:view_sprints, represented.project) + current_user.allowed_in_project?(:view_sprints, represented.project) }, link: ->(*) { if represented.backlog_bucket.present? @@ -92,7 +89,6 @@ module OpenProject::Backlogs }, getter: ->(*) do if embed_links && - represented.project.present? && represented.backlog_bucket.present? && current_user.allowed_in_project?(:view_sprints, represented.project) ::API::V3::BacklogBuckets::BacklogBucketRepresenter.create(represented.backlog_bucket, current_user:)