diff --git a/modules/auth_plugins/spec/features/auth_provider_spec.rb b/modules/auth_plugins/spec/features/auth_provider_spec.rb index 4ebd1528d21..73f001cf443 100644 --- a/modules/auth_plugins/spec/features/auth_provider_spec.rb +++ b/modules/auth_plugins/spec/features/auth_provider_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'rendering the login buttons', js: true do +RSpec.describe 'rendering the login buttons', js: true do let(:providers) do [ { name: 'mock_auth' } diff --git a/modules/auth_plugins/spec/requests/auth_plugins_spec.rb b/modules/auth_plugins/spec/requests/auth_plugins_spec.rb index 022b6558cce..417245207b9 100644 --- a/modules/auth_plugins/spec/requests/auth_plugins_spec.rb +++ b/modules/auth_plugins/spec/requests/auth_plugins_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'open_project/auth_plugins' -describe OpenProject::Plugins::AuthPlugin, with_ee: %i[board_view] do +RSpec.describe OpenProject::Plugins::AuthPlugin, with_ee: %i[board_view] do let(:dummy_engine_klass) do Class.new { extend OpenProject::Plugins::AuthPlugin } end diff --git a/modules/auth_plugins/spec/requests/flexible_strategy_spec.rb b/modules/auth_plugins/spec/requests/flexible_strategy_spec.rb index d10706c952d..c688aa3a22b 100644 --- a/modules/auth_plugins/spec/requests/flexible_strategy_spec.rb +++ b/modules/auth_plugins/spec/requests/flexible_strategy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OmniAuth::FlexibleStrategy do +RSpec.describe OmniAuth::FlexibleStrategy do class MockStrategy include OmniAuth::Strategy include OmniAuth::FlexibleStrategy diff --git a/modules/auth_plugins/spec/views/base.html.erb_spec.rb b/modules/auth_plugins/spec/views/base.html.erb_spec.rb index a4e570fa892..d6cf37342ed 100644 --- a/modules/auth_plugins/spec/views/base.html.erb_spec.rb +++ b/modules/auth_plugins/spec/views/base.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'layouts/base' do +RSpec.describe 'layouts/base' do describe 'authenticator plugin' do include Redmine::MenuManager::MenuHelper helper Redmine::MenuManager::MenuHelper diff --git a/modules/auth_plugins/spec/views/hooks/login/_providers.html.erb_spec.rb b/modules/auth_plugins/spec/views/hooks/login/_providers.html.erb_spec.rb index 53e19ae9ba9..32fad0dd981 100644 --- a/modules/auth_plugins/spec/views/hooks/login/_providers.html.erb_spec.rb +++ b/modules/auth_plugins/spec/views/hooks/login/_providers.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'rendering the login buttons for all providers' do +RSpec.describe 'rendering the login buttons for all providers' do let(:providers) do [ { name: 'mock_auth' }, diff --git a/modules/auth_saml/spec/lib/open_project/auth_saml_spec.rb b/modules/auth_saml/spec/lib/open_project/auth_saml_spec.rb index b0c18c92cf9..3152ea44e08 100644 --- a/modules/auth_saml/spec/lib/open_project/auth_saml_spec.rb +++ b/modules/auth_saml/spec/lib/open_project/auth_saml_spec.rb @@ -1,7 +1,7 @@ require File.dirname(__FILE__) + '/../../spec_helper' require 'open_project/auth_saml' -describe OpenProject::AuthSaml do +RSpec.describe OpenProject::AuthSaml do before do OpenProject::AuthSaml.reload_configuration! end diff --git a/modules/auth_saml/spec/requests/saml_provider_callback_spec.rb b/modules/auth_saml/spec/requests/saml_provider_callback_spec.rb index d0104940266..7e9a61b447a 100644 --- a/modules/auth_saml/spec/requests/saml_provider_callback_spec.rb +++ b/modules/auth_saml/spec/requests/saml_provider_callback_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'SAML provider callback', with_ee: %i[openid_providers] do +RSpec.describe 'SAML provider callback', with_ee: %i[openid_providers] do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/avatars/spec/controllers/avatars/avatar_controller_spec.rb b/modules/avatars/spec/controllers/avatars/avatar_controller_spec.rb index 3c8c7ccfa8f..b510b99e11e 100644 --- a/modules/avatars/spec/controllers/avatars/avatar_controller_spec.rb +++ b/modules/avatars/spec/controllers/avatars/avatar_controller_spec.rb @@ -1,7 +1,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper') require File.expand_path(File.dirname(__FILE__) + '/../../shared_examples') -describe Avatars::AvatarController do +RSpec.describe Avatars::AvatarController do include_context "there are users with and without avatars" let(:enabled) { true } diff --git a/modules/avatars/spec/controllers/avatars/my_controller_spec.rb b/modules/avatars/spec/controllers/avatars/my_controller_spec.rb index 051b1880bfe..836a6c79e69 100644 --- a/modules/avatars/spec/controllers/avatars/my_controller_spec.rb +++ b/modules/avatars/spec/controllers/avatars/my_controller_spec.rb @@ -1,7 +1,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper') require File.expand_path(File.dirname(__FILE__) + '/../../shared_examples') -describe Avatars::MyAvatarController do +RSpec.describe Avatars::MyAvatarController do include_context "there are users with and without avatars" let(:user) { user_without_avatar } let(:enabled) { true } diff --git a/modules/avatars/spec/controllers/avatars/users_controller_spec.rb b/modules/avatars/spec/controllers/avatars/users_controller_spec.rb index 462d8cec00b..e72e6b763b6 100644 --- a/modules/avatars/spec/controllers/avatars/users_controller_spec.rb +++ b/modules/avatars/spec/controllers/avatars/users_controller_spec.rb @@ -1,7 +1,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper') require File.expand_path(File.dirname(__FILE__) + '/../../shared_examples') -describe Avatars::UsersController do +RSpec.describe Avatars::UsersController do include_context "there are users with and without avatars" let(:current_user) { create(:admin) } diff --git a/modules/avatars/spec/features/my_avatar_spec.rb b/modules/avatars/spec/features/my_avatar_spec.rb index b3b89813767..d8d204709e2 100644 --- a/modules/avatars/spec/features/my_avatar_spec.rb +++ b/modules/avatars/spec/features/my_avatar_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require_relative './shared_avatar_examples' -describe 'My avatar management', js: true do +RSpec.describe 'My avatar management', js: true do include Rails.application.routes.url_helpers let(:user) { create(:user) } diff --git a/modules/avatars/spec/features/shared_avatar_examples.rb b/modules/avatars/spec/features/shared_avatar_examples.rb index 1cfa78a0181..2c2e72ea123 100644 --- a/modules/avatars/spec/features/shared_avatar_examples.rb +++ b/modules/avatars/spec/features/shared_avatar_examples.rb @@ -1,6 +1,6 @@ require 'fastimage' -shared_examples 'avatar management' do +RSpec.shared_examples 'avatar management' do let(:image_base_path) { File.expand_path(File.dirname(__FILE__) + '/../fixtures/') } let(:enable_gravatars) { false } diff --git a/modules/avatars/spec/features/user_avatar_spec.rb b/modules/avatars/spec/features/user_avatar_spec.rb index e8ea8737857..fe84abfe520 100644 --- a/modules/avatars/spec/features/user_avatar_spec.rb +++ b/modules/avatars/spec/features/user_avatar_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require_relative './shared_avatar_examples' -describe 'User avatar management', js: true do +RSpec.describe 'User avatar management', js: true do include Rails.application.routes.url_helpers let(:user) { create(:admin) } diff --git a/modules/avatars/spec/helpers/avatar_helper_spec.rb b/modules/avatars/spec/helpers/avatar_helper_spec.rb index 104d4b2935d..b0ecd824a2a 100644 --- a/modules/avatars/spec/helpers/avatar_helper_spec.rb +++ b/modules/avatars/spec/helpers/avatar_helper_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe AvatarHelper, with_settings: { protocol: 'http' } do +RSpec.describe AvatarHelper, with_settings: { protocol: 'http' } do include AngularHelper let(:user) { build_stubbed(:user) } diff --git a/modules/avatars/spec/lib/api/v3/users/user_representer_spec.rb b/modules/avatars/spec/lib/api/v3/users/user_representer_spec.rb index 09d9d178199..5d10fe41387 100644 --- a/modules/avatars/spec/lib/api/v3/users/user_representer_spec.rb +++ b/modules/avatars/spec/lib/api/v3/users/user_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Users::UserRepresenter do +RSpec.describe API::V3::Users::UserRepresenter do let(:user) { build_stubbed(:user, status: 1) } let(:current_user) { build_stubbed(:user) } let(:representer) { described_class.create(user, current_user:) } diff --git a/modules/avatars/spec/models/user_spec.rb b/modules/avatars/spec/models/user_spec.rb index a3ddc822704..7c89cb52e7f 100644 --- a/modules/avatars/spec/models/user_spec.rb +++ b/modules/avatars/spec/models/user_spec.rb @@ -1,7 +1,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') require File.expand_path(File.dirname(__FILE__) + '/../shared_examples') -describe User do +RSpec.describe User do let(:user) { build(:user) } include_examples "there are users with and without avatars" diff --git a/modules/avatars/spec/requests/user_avatar_api_spec.rb b/modules/avatars/spec/requests/user_avatar_api_spec.rb index c4b1b666b7f..bc0100691f2 100644 --- a/modules/avatars/spec/requests/user_avatar_api_spec.rb +++ b/modules/avatars/spec/requests/user_avatar_api_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 User avatar resource', content_type: :json do +RSpec.describe 'API v3 User avatar resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/avatars/spec/services/avatars/update_service_spec.rb b/modules/avatars/spec/services/avatars/update_service_spec.rb index c847f7c1e86..ecad4d42f2d 100644 --- a/modules/avatars/spec/services/avatars/update_service_spec.rb +++ b/modules/avatars/spec/services/avatars/update_service_spec.rb @@ -1,6 +1,6 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper') -describe Avatars::UpdateService do +RSpec.describe Avatars::UpdateService do let(:user_without_avatar) { build_stubbed(:user) } let(:user_with_avatar) do u = create(:user) diff --git a/modules/avatars/spec/shared_examples.rb b/modules/avatars/spec/shared_examples.rb index af1615aa883..1f69d9255f3 100644 --- a/modules/avatars/spec/shared_examples.rb +++ b/modules/avatars/spec/shared_examples.rb @@ -1,4 +1,4 @@ -shared_examples_for "an action checked for required login" do +RSpec.shared_examples_for "an action checked for required login" do describe "WITH no login required" do before do allow(Setting).to receive(:login_required?).and_return(false) @@ -22,7 +22,7 @@ shared_examples_for "an action checked for required login" do end end -shared_examples_for "an action requiring login" do +RSpec.shared_examples_for "an action requiring login" do let(:current) { create(:user) } before do @@ -48,7 +48,7 @@ shared_examples_for "an action requiring login" do end end -shared_examples_for "an action requiring admin" do +RSpec.shared_examples_for "an action requiring admin" do let(:current) { create(:admin) } before do @@ -89,7 +89,7 @@ shared_examples_for "an action requiring admin" do end end end -shared_context "there are users with and without avatars" do +RSpec.shared_context "there are users with and without avatars" do let(:base_path) { File.expand_path 'fixtures', __dir__ } let(:user_without_avatar) { create(:user) } let(:user_with_avatar) do @@ -117,7 +117,7 @@ shared_context "there are users with and without avatars" do testfile end end -shared_examples_for "an action with an invalid user" do +RSpec.shared_examples_for "an action with an invalid user" do it do do_action expect(response).not_to be_success @@ -125,13 +125,13 @@ shared_examples_for "an action with an invalid user" do end end -shared_context "an action with stubbed User.find" do +RSpec.shared_context "an action with stubbed User.find" do before do allow(user).to receive(:save).and_return true if user allow(User).to receive(:find) { |id, _args| id.to_s == "0" ? nil : user } end end -shared_examples_for "an action that deletes the user's avatar" do +RSpec.shared_examples_for "an action that deletes the user's avatar" do it do expect_any_instance_of(Attachment).to receive(:destroy).and_call_original do_action diff --git a/modules/backlogs/spec/api/work_package_resource_spec.rb b/modules/backlogs/spec/api/work_package_resource_spec.rb index 40e9ce55198..00f429dc544 100644 --- a/modules/backlogs/spec/api/work_package_resource_spec.rb +++ b/modules/backlogs/spec/api/work_package_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Work package resource' do +RSpec.describe 'API v3 Work package resource' do include Rack::Test::Methods include Capybara::RSpecMatchers diff --git a/modules/backlogs/spec/api/work_packages/form_resource_spec.rb b/modules/backlogs/spec/api/work_packages/form_resource_spec.rb index e804041b8e4..abde87a6a7b 100644 --- a/modules/backlogs/spec/api/work_packages/form_resource_spec.rb +++ b/modules/backlogs/spec/api/work_packages/form_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Work package form resource' do +RSpec.describe 'API v3 Work package form resource' do include Rack::Test::Methods include Capybara::RSpecMatchers diff --git a/modules/backlogs/spec/api/work_packages/schema/specific_work_package_schema_spec.rb b/modules/backlogs/spec/api/work_packages/schema/specific_work_package_schema_spec.rb index ded62635b85..2c8a8b2e630 100644 --- a/modules/backlogs/spec/api/work_packages/schema/specific_work_package_schema_spec.rb +++ b/modules/backlogs/spec/api/work_packages/schema/specific_work_package_schema_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::Schema::SpecificWorkPackageSchema do +RSpec.describe API::V3::WorkPackages::Schema::SpecificWorkPackageSchema do let(:project) { build(:project) } let(:type) { build(:type) } let(:work_package) do diff --git a/modules/backlogs/spec/api/work_packages/work_package_schema_representer_spec.rb b/modules/backlogs/spec/api/work_packages/work_package_schema_representer_spec.rb index 619ee93e6fd..365df5963ad 100644 --- a/modules/backlogs/spec/api/work_packages/work_package_schema_representer_spec.rb +++ b/modules/backlogs/spec/api/work_packages/work_package_schema_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::Schema::WorkPackageSchemaRepresenter do +RSpec.describe API::V3::WorkPackages::Schema::WorkPackageSchemaRepresenter do let(:custom_field) { build(:custom_field) } let(:work_package) { build_stubbed(:work_package, type: build_stubbed(:type)) } let(:current_user) do diff --git a/modules/backlogs/spec/contracts/work_packages/base_contract_spec.rb b/modules/backlogs/spec/contracts/work_packages/base_contract_spec.rb index 9c84e2d4cbc..66cef45c64a 100644 --- a/modules/backlogs/spec/contracts/work_packages/base_contract_spec.rb +++ b/modules/backlogs/spec/contracts/work_packages/base_contract_spec.rb @@ -28,7 +28,7 @@ require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper") -describe WorkPackages::BaseContract, type: :model do +RSpec.describe WorkPackages::BaseContract, type: :model do let(:instance) { described_class.new(work_package, user) } let(:type_feature) { build(:type_feature) } let(:type_task) { build(:type_task) } diff --git a/modules/backlogs/spec/contracts/work_packages/create_contract_spec.rb b/modules/backlogs/spec/contracts/work_packages/create_contract_spec.rb index fe4d4bd0752..fe104ef94a2 100644 --- a/modules/backlogs/spec/contracts/work_packages/create_contract_spec.rb +++ b/modules/backlogs/spec/contracts/work_packages/create_contract_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::CreateContract do +RSpec.describe WorkPackages::CreateContract do let(:work_package) { build(:work_package, author: other_user, project:) } let(:other_user) { build_stubbed(:user) } let(:project) { build_stubbed(:project) } diff --git a/modules/backlogs/spec/contracts/work_packages/update_contract_spec.rb b/modules/backlogs/spec/contracts/work_packages/update_contract_spec.rb index 0d8c14a5ef4..130b68ffc47 100644 --- a/modules/backlogs/spec/contracts/work_packages/update_contract_spec.rb +++ b/modules/backlogs/spec/contracts/work_packages/update_contract_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::UpdateContract do +RSpec.describe WorkPackages::UpdateContract do let(:work_package) do create(:work_package, done_ratio: 50, diff --git a/modules/backlogs/spec/controllers/backlogs_settings_controller_spec.rb b/modules/backlogs/spec/controllers/backlogs_settings_controller_spec.rb index 920981bfe38..5d409a448a4 100644 --- a/modules/backlogs/spec/controllers/backlogs_settings_controller_spec.rb +++ b/modules/backlogs/spec/controllers/backlogs_settings_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe BacklogsSettingsController do +RSpec.describe BacklogsSettingsController do current_user { build_stubbed(:admin) } describe 'GET show' do diff --git a/modules/backlogs/spec/controllers/versions_controller_spec.rb b/modules/backlogs/spec/controllers/versions_controller_spec.rb index fffe8ab474f..f7b78a8a7ee 100644 --- a/modules/backlogs/spec/controllers/versions_controller_spec.rb +++ b/modules/backlogs/spec/controllers/versions_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe VersionsController do +RSpec.describe VersionsController do let(:version) do create(:version, sharing: 'system') diff --git a/modules/backlogs/spec/features/backlogs/create_story_spec.rb b/modules/backlogs/spec/features/backlogs/create_story_spec.rb index 0aa9426b144..e4d00d8eef5 100644 --- a/modules/backlogs/spec/features/backlogs/create_story_spec.rb +++ b/modules/backlogs/spec/features/backlogs/create_story_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Backlogs', js: true do +RSpec.describe 'Backlogs', js: true do let(:story_type) do create(:type_feature) end diff --git a/modules/backlogs/spec/features/backlogs_in_backlog_view_spec.rb b/modules/backlogs/spec/features/backlogs_in_backlog_view_spec.rb index 7c55b73def1..ec8fe894131 100644 --- a/modules/backlogs/spec/features/backlogs_in_backlog_view_spec.rb +++ b/modules/backlogs/spec/features/backlogs_in_backlog_view_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative '../support/pages/backlogs' -describe 'Backlogs in backlog view', - js: true do +RSpec.describe 'Backlogs in backlog view', + js: true do let!(:project) do create(:project, types: [story, task], diff --git a/modules/backlogs/spec/features/empty_backlogs_spec.rb b/modules/backlogs/spec/features/empty_backlogs_spec.rb index ae8c39168ca..df905ad3b18 100644 --- a/modules/backlogs/spec/features/empty_backlogs_spec.rb +++ b/modules/backlogs/spec/features/empty_backlogs_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Empty backlogs project', - js: true do +RSpec.describe 'Empty backlogs project', + js: true do let(:project) { create(:project, types: [story, task], enabled_module_names: %w(backlogs)) } let(:story) { create(:type_feature) } let(:task) { create(:type_task) } diff --git a/modules/backlogs/spec/features/impediments_spec.rb b/modules/backlogs/spec/features/impediments_spec.rb index 16df6fc20d7..c3063aab6ee 100644 --- a/modules/backlogs/spec/features/impediments_spec.rb +++ b/modules/backlogs/spec/features/impediments_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Impediments on taskboard', - js: true do +RSpec.describe 'Impediments on taskboard', + js: true do let!(:project) do create(:project, types: [story, task], diff --git a/modules/backlogs/spec/features/onboarding/backlogs_onboarding_tour_spec.rb b/modules/backlogs/spec/features/onboarding/backlogs_onboarding_tour_spec.rb index 0996dc22511..72ca3b8ea5f 100644 --- a/modules/backlogs/spec/features/onboarding/backlogs_onboarding_tour_spec.rb +++ b/modules/backlogs/spec/features/onboarding/backlogs_onboarding_tour_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'backlogs onboarding tour', js: true do +RSpec.describe 'backlogs onboarding tour', js: true do let(:next_button) { find('.enjoyhint_next_btn') } let(:user) { create(:admin) } let(:demo_project) do diff --git a/modules/backlogs/spec/features/resolved_status_spec.rb b/modules/backlogs/spec/features/resolved_status_spec.rb index 380bd51a2d5..27ca06372c6 100644 --- a/modules/backlogs/spec/features/resolved_status_spec.rb +++ b/modules/backlogs/spec/features/resolved_status_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Resolved status' do +RSpec.describe 'Resolved status' do let!(:project) do create(:project, enabled_module_names: %w(backlogs)) diff --git a/modules/backlogs/spec/features/stories_in_backlog_spec.rb b/modules/backlogs/spec/features/stories_in_backlog_spec.rb index bac3ab83cce..b884c146540 100644 --- a/modules/backlogs/spec/features/stories_in_backlog_spec.rb +++ b/modules/backlogs/spec/features/stories_in_backlog_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative '../support/pages/backlogs' -describe 'Stories in backlog', - js: true do +RSpec.describe 'Stories in backlog', + js: true do let!(:project) do create(:project, types: [story, task, other_story], diff --git a/modules/backlogs/spec/features/tasks_on_taskboard_spec.rb b/modules/backlogs/spec/features/tasks_on_taskboard_spec.rb index efc80b4aa86..5c1b01e0c18 100644 --- a/modules/backlogs/spec/features/tasks_on_taskboard_spec.rb +++ b/modules/backlogs/spec/features/tasks_on_taskboard_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative '../support/pages/taskboard' -describe 'Tasks on taskboard', - js: true do +RSpec.describe 'Tasks on taskboard', + js: true do let!(:project) do create(:project, types: [story, task, other_story], diff --git a/modules/backlogs/spec/features/work_packages/filter_spec.rb b/modules/backlogs/spec/features/work_packages/filter_spec.rb index d0fc7dbaace..9a11ee68e1e 100644 --- a/modules/backlogs/spec/features/work_packages/filter_spec.rb +++ b/modules/backlogs/spec/features/work_packages/filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Filter by backlog type', js: true do +RSpec.describe 'Filter by backlog type', js: true do let(:story_type) do type = create(:type_feature) project.types << type diff --git a/modules/backlogs/spec/features/work_packages/remaining_time_spec.rb b/modules/backlogs/spec/features/work_packages/remaining_time_spec.rb index e15469eaaf0..165f41c7889 100644 --- a/modules/backlogs/spec/features/work_packages/remaining_time_spec.rb +++ b/modules/backlogs/spec/features/work_packages/remaining_time_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Work packages remaining time', js: true do +RSpec.describe 'Work packages remaining time', js: true do before do allow(User).to receive(:current).and_return current_user allow(Setting).to receive(:plugin_openproject_backlogs).and_return('points_burn_direction' => 'down', diff --git a/modules/backlogs/spec/features/work_packages/story_points_spec.rb b/modules/backlogs/spec/features/work_packages/story_points_spec.rb index 09dbaacd1e4..c155ee76153 100644 --- a/modules/backlogs/spec/features/work_packages/story_points_spec.rb +++ b/modules/backlogs/spec/features/work_packages/story_points_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Work packages having story points', js: true do +RSpec.describe 'Work packages having story points', js: true do before do allow(User).to receive(:current).and_return current_user allow(Setting).to receive(:plugin_openproject_backlogs).and_return('points_burn_direction' => 'down', diff --git a/modules/backlogs/spec/helpers/version_settings_helper_spec.rb b/modules/backlogs/spec/helpers/version_settings_helper_spec.rb index efd8e432530..7ffe2ac49f3 100644 --- a/modules/backlogs/spec/helpers/version_settings_helper_spec.rb +++ b/modules/backlogs/spec/helpers/version_settings_helper_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe VersionSettingsHelper do +RSpec.describe VersionSettingsHelper do describe '#position_display_options' do before do @expected_options = [[I18n.t('version_settings_display_option_none'), 1], diff --git a/modules/backlogs/spec/models/backlog_spec.rb b/modules/backlogs/spec/models/backlog_spec.rb index 694d493991e..b3606e4535c 100644 --- a/modules/backlogs/spec/models/backlog_spec.rb +++ b/modules/backlogs/spec/models/backlog_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe Backlog do +RSpec.describe Backlog do let(:project) { build(:project) } before do diff --git a/modules/backlogs/spec/models/burndown_spec.rb b/modules/backlogs/spec/models/burndown_spec.rb index 9c9a8e6628c..fcbb816dfd2 100644 --- a/modules/backlogs/spec/models/burndown_spec.rb +++ b/modules/backlogs/spec/models/burndown_spec.rb @@ -28,7 +28,7 @@ require File.expand_path("#{File.dirname(__FILE__)}/../spec_helper") -describe Burndown do +RSpec.describe Burndown do def set_attribute_journalized(story, attribute, value, day) story.reload story.send(attribute, value) diff --git a/modules/backlogs/spec/models/impediment_spec.rb b/modules/backlogs/spec/models/impediment_spec.rb index ab22bd01f59..5f0b0f3fd7b 100644 --- a/modules/backlogs/spec/models/impediment_spec.rb +++ b/modules/backlogs/spec/models/impediment_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe Impediment do +RSpec.describe Impediment do let(:user) { @user ||= create(:user) } let(:role) { @role ||= create(:role) } let(:type_feature) { @type_feature ||= create(:type_feature) } diff --git a/modules/backlogs/spec/models/issue_position_spec.rb b/modules/backlogs/spec/models/issue_position_spec.rb index 1f86cd61bc1..fadc59d8721 100644 --- a/modules/backlogs/spec/models/issue_position_spec.rb +++ b/modules/backlogs/spec/models/issue_position_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe WorkPackage do +RSpec.describe WorkPackage do describe 'Story positions' do def build_work_package(options) build(:work_package, options.reverse_merge(version_id: sprint_1.id, diff --git a/modules/backlogs/spec/models/issue_spec.rb b/modules/backlogs/spec/models/issue_spec.rb index 7debf4284e1..4c53feee335 100644 --- a/modules/backlogs/spec/models/issue_spec.rb +++ b/modules/backlogs/spec/models/issue_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe WorkPackage do +RSpec.describe WorkPackage do describe 'validations' do let(:work_package) do build(:work_package) diff --git a/modules/backlogs/spec/models/sprint_spec.rb b/modules/backlogs/spec/models/sprint_spec.rb index 4b266a88d69..e7d4d905519 100644 --- a/modules/backlogs/spec/models/sprint_spec.rb +++ b/modules/backlogs/spec/models/sprint_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe Sprint do +RSpec.describe Sprint do let(:sprint) { build(:sprint) } let(:project) { build(:project) } diff --git a/modules/backlogs/spec/models/story_spec.rb b/modules/backlogs/spec/models/story_spec.rb index b6853865140..799c15285a1 100644 --- a/modules/backlogs/spec/models/story_spec.rb +++ b/modules/backlogs/spec/models/story_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe Story do +RSpec.describe Story do let(:user) { @user ||= create(:user) } let(:role) { @role ||= create(:role) } let(:status1) { @status1 ||= create(:status, name: 'status 1', is_default: true) } diff --git a/modules/backlogs/spec/models/task_spec.rb b/modules/backlogs/spec/models/task_spec.rb index b70d0acad6d..6676109ab29 100644 --- a/modules/backlogs/spec/models/task_spec.rb +++ b/modules/backlogs/spec/models/task_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe Task do +RSpec.describe Task do let(:task_type) { create(:type) } let(:default_status) { create(:default_status) } let(:project) { create(:project) } diff --git a/modules/backlogs/spec/models/user_spec.rb b/modules/backlogs/spec/models/user_spec.rb index e90720ac56f..af8dc06cdd3 100644 --- a/modules/backlogs/spec/models/user_spec.rb +++ b/modules/backlogs/spec/models/user_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe User do +RSpec.describe User do describe 'backlogs_preference' do describe 'task_color' do it 'reads from and writes to a user preference' do diff --git a/modules/backlogs/spec/models/version_setting_spec.rb b/modules/backlogs/spec/models/version_setting_spec.rb index 6108416b85a..4cb4ec18271 100644 --- a/modules/backlogs/spec/models/version_setting_spec.rb +++ b/modules/backlogs/spec/models/version_setting_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe VersionSetting do +RSpec.describe VersionSetting do let(:version_setting) { build(:version_setting) } it { is_expected.to belong_to(:project) } diff --git a/modules/backlogs/spec/models/version_spec.rb b/modules/backlogs/spec/models/version_spec.rb index 7585bc4d42a..1d0688c1db3 100644 --- a/modules/backlogs/spec/models/version_spec.rb +++ b/modules/backlogs/spec/models/version_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe Version do +RSpec.describe Version do it { is_expected.to have_many :version_settings } describe 'rebuild positions' do diff --git a/modules/backlogs/spec/models/work_package_export_spec.rb b/modules/backlogs/spec/models/work_package_export_spec.rb index 66be5e85890..3b0e62d3e5b 100644 --- a/modules/backlogs/spec/models/work_package_export_spec.rb +++ b/modules/backlogs/spec/models/work_package_export_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe WorkPackage::PDFExport::WorkPackageToPdf do +RSpec.describe WorkPackage::PDFExport::WorkPackageToPdf do let(:project) { create(:project) } let(:query) { Query.new_default(project:) } diff --git a/modules/backlogs/spec/models/work_package_spec.rb b/modules/backlogs/spec/models/work_package_spec.rb index 4516e9854b0..0cc06d4fbb3 100644 --- a/modules/backlogs/spec/models/work_package_spec.rb +++ b/modules/backlogs/spec/models/work_package_spec.rb @@ -28,7 +28,7 @@ require_relative '../spec_helper' -describe WorkPackage do +RSpec.describe WorkPackage do describe '#backlogs_types' do it 'returns all the ids of types that are configures to be considered backlogs types' do allow(Setting).to receive(:plugin_openproject_backlogs).and_return({ 'story_types' => [1], 'task_type' => 2 }) diff --git a/modules/backlogs/spec/routing/rb_burndown_charts_routing_spec.rb b/modules/backlogs/spec/routing/rb_burndown_charts_routing_spec.rb index 5ebb4a02ad1..ec46437ba28 100644 --- a/modules/backlogs/spec/routing/rb_burndown_charts_routing_spec.rb +++ b/modules/backlogs/spec/routing/rb_burndown_charts_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RbBurndownChartsController do +RSpec.describe RbBurndownChartsController do describe 'routing' do it { expect(get('/projects/project_42/sprints/21/burndown_chart')).to route_to(controller: 'rb_burndown_charts', diff --git a/modules/backlogs/spec/routing/rb_impediments_routing_spec.rb b/modules/backlogs/spec/routing/rb_impediments_routing_spec.rb index 13a27c7be1c..376bcf29541 100644 --- a/modules/backlogs/spec/routing/rb_impediments_routing_spec.rb +++ b/modules/backlogs/spec/routing/rb_impediments_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RbImpedimentsController do +RSpec.describe RbImpedimentsController do describe 'routing' do it { expect(post('/projects/project_42/sprints/21/impediments')).to route_to(controller: 'rb_impediments', diff --git a/modules/backlogs/spec/routing/rb_master_backlogs_routing_spec.rb b/modules/backlogs/spec/routing/rb_master_backlogs_routing_spec.rb index 15af56bbfda..2e74586ef2f 100644 --- a/modules/backlogs/spec/routing/rb_master_backlogs_routing_spec.rb +++ b/modules/backlogs/spec/routing/rb_master_backlogs_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RbMasterBacklogsController do +RSpec.describe RbMasterBacklogsController do describe 'routing' do it { expect(get('/projects/project_42/backlogs')).to route_to(controller: 'rb_master_backlogs', diff --git a/modules/backlogs/spec/routing/rb_queries_routing_spec.rb b/modules/backlogs/spec/routing/rb_queries_routing_spec.rb index c2d3a1b6f9d..b85d3e9290c 100644 --- a/modules/backlogs/spec/routing/rb_queries_routing_spec.rb +++ b/modules/backlogs/spec/routing/rb_queries_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RbQueriesController do +RSpec.describe RbQueriesController do describe 'routing' do it { expect(get('/projects/project_42/sprints/21/query')).to route_to(controller: 'rb_queries', diff --git a/modules/backlogs/spec/routing/rb_sprints_routing_spec.rb b/modules/backlogs/spec/routing/rb_sprints_routing_spec.rb index 18c1c527ad9..a2ab1ee5f22 100644 --- a/modules/backlogs/spec/routing/rb_sprints_routing_spec.rb +++ b/modules/backlogs/spec/routing/rb_sprints_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RbSprintsController do +RSpec.describe RbSprintsController do describe 'routing' do it { expect(put('/projects/project_42/sprints/21')).to route_to(controller: 'rb_sprints', diff --git a/modules/backlogs/spec/routing/rb_stories_routing_spec.rb b/modules/backlogs/spec/routing/rb_stories_routing_spec.rb index 3b492e71e50..54737e38e10 100644 --- a/modules/backlogs/spec/routing/rb_stories_routing_spec.rb +++ b/modules/backlogs/spec/routing/rb_stories_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RbStoriesController do +RSpec.describe RbStoriesController do describe 'routing' do it { expect(post('/projects/project_42/sprints/21/stories')).to route_to(controller: 'rb_stories', diff --git a/modules/backlogs/spec/routing/rb_taskboard_card_configurations_routing_spec.rb b/modules/backlogs/spec/routing/rb_taskboard_card_configurations_routing_spec.rb index d61c2d94612..6f7c8f2b286 100644 --- a/modules/backlogs/spec/routing/rb_taskboard_card_configurations_routing_spec.rb +++ b/modules/backlogs/spec/routing/rb_taskboard_card_configurations_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RbExportCardConfigurationsController do +RSpec.describe RbExportCardConfigurationsController do describe 'routing' do it { expect(get('/projects/project_42/sprints/21/export_card_configurations/10')).to route_to(controller: 'rb_export_card_configurations', diff --git a/modules/backlogs/spec/routing/rb_taskboards_routing_spec.rb b/modules/backlogs/spec/routing/rb_taskboards_routing_spec.rb index 9224cfad766..55db91d0e9b 100644 --- a/modules/backlogs/spec/routing/rb_taskboards_routing_spec.rb +++ b/modules/backlogs/spec/routing/rb_taskboards_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RbTaskboardsController do +RSpec.describe RbTaskboardsController do describe 'routing' do it { expect(get('/projects/project_42/sprints/21/taskboard')).to route_to(controller: 'rb_taskboards', diff --git a/modules/backlogs/spec/routing/rb_tasks_routing_spec.rb b/modules/backlogs/spec/routing/rb_tasks_routing_spec.rb index ce6fdf516cf..b893ceb86ff 100644 --- a/modules/backlogs/spec/routing/rb_tasks_routing_spec.rb +++ b/modules/backlogs/spec/routing/rb_tasks_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RbTasksController do +RSpec.describe RbTasksController do describe 'routing' do it { expect(post('/projects/project_42/sprints/21/tasks')).to route_to(controller: 'rb_tasks', diff --git a/modules/backlogs/spec/routing/rb_wikis_routing_spec.rb b/modules/backlogs/spec/routing/rb_wikis_routing_spec.rb index aff5b211cbc..219019185f5 100644 --- a/modules/backlogs/spec/routing/rb_wikis_routing_spec.rb +++ b/modules/backlogs/spec/routing/rb_wikis_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RbWikisController do +RSpec.describe RbWikisController do describe 'routing' do it { expect(get('/projects/project_42/sprints/21/wiki')).to route_to(controller: 'rb_wikis', diff --git a/modules/backlogs/spec/services/impediments/create_services_spec.rb b/modules/backlogs/spec/services/impediments/create_services_spec.rb index c99caa82e3d..3f95ba6d7f8 100644 --- a/modules/backlogs/spec/services/impediments/create_services_spec.rb +++ b/modules/backlogs/spec/services/impediments/create_services_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Impediments::CreateService do +RSpec.describe Impediments::CreateService do let(:instance) { described_class.new(user:) } let(:impediment_subject) { 'Impediment A' } diff --git a/modules/backlogs/spec/services/impediments/update_service_spec.rb b/modules/backlogs/spec/services/impediments/update_service_spec.rb index ef96fe39f91..95eaf48bb9b 100644 --- a/modules/backlogs/spec/services/impediments/update_service_spec.rb +++ b/modules/backlogs/spec/services/impediments/update_service_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper') -describe Impediments::UpdateService, type: :model do +RSpec.describe Impediments::UpdateService, type: :model do let(:instance) { described_class.new(user:, impediment:) } let(:user) { create(:user) } diff --git a/modules/backlogs/spec/services/stories/create_service_spec.rb b/modules/backlogs/spec/services/stories/create_service_spec.rb index 2df172eb882..19d9d7fd393 100644 --- a/modules/backlogs/spec/services/stories/create_service_spec.rb +++ b/modules/backlogs/spec/services/stories/create_service_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper') -describe Stories::CreateService, type: :model do +RSpec.describe Stories::CreateService, type: :model do let(:priority) { create(:priority) } let(:project) do project = create(:project, types: [type_feature]) diff --git a/modules/backlogs/spec/services/work_packages/update_ancestors_service_spec.rb b/modules/backlogs/spec/services/work_packages/update_ancestors_service_spec.rb index a4ccfe204e3..bb94e3a397d 100644 --- a/modules/backlogs/spec/services/work_packages/update_ancestors_service_spec.rb +++ b/modules/backlogs/spec/services/work_packages/update_ancestors_service_spec.rb @@ -28,7 +28,7 @@ require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper") -describe WorkPackages::UpdateAncestorsService do +RSpec.describe WorkPackages::UpdateAncestorsService do let(:user) { create(:user) } let(:sibling_remaining_hours) { 7.0 } diff --git a/modules/backlogs/spec/services/work_packages/update_service_version_inheritance_spec.rb b/modules/backlogs/spec/services/work_packages/update_service_version_inheritance_spec.rb index ce0cb4ff613..e14dd9e5200 100644 --- a/modules/backlogs/spec/services/work_packages/update_service_version_inheritance_spec.rb +++ b/modules/backlogs/spec/services/work_packages/update_service_version_inheritance_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper') -describe WorkPackages::UpdateService, "version inheritance", type: :model do +RSpec.describe WorkPackages::UpdateService, "version inheritance", type: :model do let(:type_feature) { build(:type_feature) } let(:type_task) { build(:type_task) } let(:type_bug) { build(:type_bug) } diff --git a/modules/backlogs/spec/views/rb_burndown_charts/show_spec.rb b/modules/backlogs/spec/views/rb_burndown_charts/show_spec.rb index f74ef601776..a3d3b1e2729 100644 --- a/modules/backlogs/spec/views/rb_burndown_charts/show_spec.rb +++ b/modules/backlogs/spec/views/rb_burndown_charts/show_spec.rb @@ -28,7 +28,7 @@ require File.dirname(__FILE__) + '/../../spec_helper' -describe 'rb_burndown_charts/show' do +RSpec.describe 'rb_burndown_charts/show' do let(:user1) { create(:user) } let(:user2) { create(:user) } let(:role_allowed) do diff --git a/modules/backlogs/spec/views/rb_master_backlogs/index.html.erb_spec.rb b/modules/backlogs/spec/views/rb_master_backlogs/index.html.erb_spec.rb index 7830ef97e39..4a0e07c0bea 100644 --- a/modules/backlogs/spec/views/rb_master_backlogs/index.html.erb_spec.rb +++ b/modules/backlogs/spec/views/rb_master_backlogs/index.html.erb_spec.rb @@ -28,7 +28,7 @@ require File.dirname(__FILE__) + '/../../spec_helper' -describe 'rb_master_backlogs/index' do +RSpec.describe 'rb_master_backlogs/index' do let(:user) { create(:user) } let(:role_allowed) do create(:role, diff --git a/modules/backlogs/spec/views/rb_taskboards/show_spec.rb b/modules/backlogs/spec/views/rb_taskboards/show_spec.rb index 6aed4793627..c3ada5e293a 100644 --- a/modules/backlogs/spec/views/rb_taskboards/show_spec.rb +++ b/modules/backlogs/spec/views/rb_taskboards/show_spec.rb @@ -28,7 +28,7 @@ require File.dirname(__FILE__) + '/../../spec_helper' -describe 'rb_taskboards/show' do +RSpec.describe 'rb_taskboards/show' do let(:user1) { create(:user) } let(:user2) { create(:user) } let(:role_allowed) do diff --git a/modules/backlogs/spec/views/shared/not_configured_spec.rb b/modules/backlogs/spec/views/shared/not_configured_spec.rb index 6805ebec4e9..fc6749a39d6 100644 --- a/modules/backlogs/spec/views/shared/not_configured_spec.rb +++ b/modules/backlogs/spec/views/shared/not_configured_spec.rb @@ -28,7 +28,7 @@ require_relative '../../spec_helper' -describe 'shared/not_configured' do +RSpec.describe 'shared/not_configured' do it 'renders without errors' do render end diff --git a/modules/bim/spec/api/v3/activities/activity_representer_spec.rb b/modules/bim/spec/api/v3/activities/activity_representer_spec.rb index 3c676ab2d76..9f65c267b46 100644 --- a/modules/bim/spec/api/v3/activities/activity_representer_spec.rb +++ b/modules/bim/spec/api/v3/activities/activity_representer_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../../../support/bcf_topic_with_stubbed_comment' -describe API::V3::Activities::ActivityRepresenter do +RSpec.describe API::V3::Activities::ActivityRepresenter do include API::Bim::Utilities::PathHelper include_context 'user with stubbed permissions' diff --git a/modules/bim/spec/api/v3/queries/filters/query_filter_instance_representer_spec.rb b/modules/bim/spec/api/v3/queries/filters/query_filter_instance_representer_spec.rb index 35ad424d89d..27a99d3aa2c 100644 --- a/modules/bim/spec/api/v3/queries/filters/query_filter_instance_representer_spec.rb +++ b/modules/bim/spec/api/v3/queries/filters/query_filter_instance_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Filters::QueryFilterInstanceRepresenter do +RSpec.describe API::V3::Queries::Filters::QueryFilterInstanceRepresenter do let(:operator) { '=' } let(:filter) do Bim::Queries::WorkPackages::Filter::BcfIssueAssociatedFilter diff --git a/modules/bim/spec/api/v3/work_packages/work_package_representer_spec.rb b/modules/bim/spec/api/v3/work_packages/work_package_representer_spec.rb index a43f38d1af4..5da6b7751c4 100644 --- a/modules/bim/spec/api/v3/work_packages/work_package_representer_spec.rb +++ b/modules/bim/spec/api/v3/work_packages/work_package_representer_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../../../support/bcf_topic_with_stubbed_comment' -describe API::V3::WorkPackages::WorkPackageRepresenter do +RSpec.describe API::V3::WorkPackages::WorkPackageRepresenter do include API::V3::Utilities::PathHelper include API::Bim::Utilities::PathHelper include_context 'user with stubbed permissions' diff --git a/modules/bim/spec/bcf/bcf_xml/exporter_spec.rb b/modules/bim/spec/bcf/bcf_xml/exporter_spec.rb index 230b0ba2bce..c8abc1532b7 100644 --- a/modules/bim/spec/bcf/bcf_xml/exporter_spec.rb +++ b/modules/bim/spec/bcf/bcf_xml/exporter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::Bim::BcfXml::Exporter do +RSpec.describe OpenProject::Bim::BcfXml::Exporter do let(:query) { build(:global_query) } let(:work_package) { create(:work_package) } let(:admin) { create(:admin) } diff --git a/modules/bim/spec/bcf/bcf_xml/importer_spec.rb b/modules/bim/spec/bcf/bcf_xml/importer_spec.rb index 5c37abd9205..b6ea72477c0 100644 --- a/modules/bim/spec/bcf/bcf_xml/importer_spec.rb +++ b/modules/bim/spec/bcf/bcf_xml/importer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::Bim::BcfXml::Importer do +RSpec.describe OpenProject::Bim::BcfXml::Importer do let(:filename) { 'MaximumInformation.bcf' } let(:file) do Rack::Test::UploadedFile.new( diff --git a/modules/bim/spec/bcf/bcf_xml/issue_reader_spec.rb b/modules/bim/spec/bcf/bcf_xml/issue_reader_spec.rb index e2b7b54484e..8ef5687062b 100644 --- a/modules/bim/spec/bcf/bcf_xml/issue_reader_spec.rb +++ b/modules/bim/spec/bcf/bcf_xml/issue_reader_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::Bim::BcfXml::IssueReader do +RSpec.describe OpenProject::Bim::BcfXml::IssueReader do let(:absolute_file_path) { "63E78882-7C6A-4BF7-8982-FC478AFB9C97/markup.bcf" } let(:type) { create(:type, name: 'Issue', is_standard: true, is_default: true) } let(:project) do diff --git a/modules/bim/spec/bcf/bcf_xml/issue_writer_spec.rb b/modules/bim/spec/bcf/bcf_xml/issue_writer_spec.rb index fbedff9bd20..1dcebe4349c 100644 --- a/modules/bim/spec/bcf/bcf_xml/issue_writer_spec.rb +++ b/modules/bim/spec/bcf/bcf_xml/issue_writer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::Bim::BcfXml::IssueWriter do +RSpec.describe OpenProject::Bim::BcfXml::IssueWriter do let(:project) { create(:project) } let(:markup) do <<-MARKUP diff --git a/modules/bim/spec/bcf/bcf_xml/markup_extractor_spec.rb b/modules/bim/spec/bcf/bcf_xml/markup_extractor_spec.rb index 5679bc6cc40..9fb645e727e 100644 --- a/modules/bim/spec/bcf/bcf_xml/markup_extractor_spec.rb +++ b/modules/bim/spec/bcf/bcf_xml/markup_extractor_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::Bim::BcfXml::MarkupExtractor do +RSpec.describe OpenProject::Bim::BcfXml::MarkupExtractor do let(:filename) { 'MaximumInformation.bcf' } let(:file) do Rack::Test::UploadedFile.new( diff --git a/modules/bim/spec/contracts/bcf/issues/create_contract_spec.rb b/modules/bim/spec/contracts/bcf/issues/create_contract_spec.rb index d480f7dea99..2d174035c04 100644 --- a/modules/bim/spec/contracts/bcf/issues/create_contract_spec.rb +++ b/modules/bim/spec/contracts/bcf/issues/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe Bim::Bcf::Issues::CreateContract do +RSpec.describe Bim::Bcf::Issues::CreateContract do it_behaves_like 'issues contract' do let(:issue) do Bim::Bcf::Issue.new(uuid: issue_uuid, diff --git a/modules/bim/spec/contracts/bcf/issues/shared_contract_examples.rb b/modules/bim/spec/contracts/bcf/issues/shared_contract_examples.rb index 3339a15b49c..040c1553477 100644 --- a/modules/bim/spec/contracts/bcf/issues/shared_contract_examples.rb +++ b/modules/bim/spec/contracts/bcf/issues/shared_contract_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'issues contract' do +RSpec.shared_examples_for 'issues contract' do let(:current_user) do build_stubbed(:user) end diff --git a/modules/bim/spec/contracts/bcf/issues/update_contract_spec.rb b/modules/bim/spec/contracts/bcf/issues/update_contract_spec.rb index 53b7dca1a75..24f2e3620cc 100644 --- a/modules/bim/spec/contracts/bcf/issues/update_contract_spec.rb +++ b/modules/bim/spec/contracts/bcf/issues/update_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe Bim::Bcf::Issues::UpdateContract do +RSpec.describe Bim::Bcf::Issues::UpdateContract do it_behaves_like 'issues contract' do let(:issue) do build_stubbed(:bcf_issue, diff --git a/modules/bim/spec/contracts/bcf/viewpoints/create_contract_spec.rb b/modules/bim/spec/contracts/bcf/viewpoints/create_contract_spec.rb index 72e9151de7a..efd36d0fdd4 100644 --- a/modules/bim/spec/contracts/bcf/viewpoints/create_contract_spec.rb +++ b/modules/bim/spec/contracts/bcf/viewpoints/create_contract_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Bim::Bcf::Viewpoints::CreateContract do +RSpec.describe Bim::Bcf::Viewpoints::CreateContract do let(:viewpoint) do Bim::Bcf::Viewpoint.new(uuid: viewpoint_uuid, issue: viewpoint_issue, diff --git a/modules/bim/spec/contracts/ifc_models/create_contract_spec.rb b/modules/bim/spec/contracts/ifc_models/create_contract_spec.rb index 03bde549d67..47d1a1c9129 100644 --- a/modules/bim/spec/contracts/ifc_models/create_contract_spec.rb +++ b/modules/bim/spec/contracts/ifc_models/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe Bim::IfcModels::CreateContract do +RSpec.describe Bim::IfcModels::CreateContract do it_behaves_like 'ifc model contract' do let(:ifc_model) do Bim::IfcModels::IfcModel.new(project: model_project, diff --git a/modules/bim/spec/contracts/ifc_models/shared_contract_examples.rb b/modules/bim/spec/contracts/ifc_models/shared_contract_examples.rb index 2b63b626bea..c2acc23614b 100644 --- a/modules/bim/spec/contracts/ifc_models/shared_contract_examples.rb +++ b/modules/bim/spec/contracts/ifc_models/shared_contract_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'ifc model contract' do +RSpec.shared_examples_for 'ifc model contract' do let(:current_user) { build_stubbed(:user) } let(:other_user) { build_stubbed(:user) } let(:model_project) { build_stubbed(:project) } diff --git a/modules/bim/spec/contracts/ifc_models/update_contract_spec.rb b/modules/bim/spec/contracts/ifc_models/update_contract_spec.rb index e49cae98148..20fe17adc09 100644 --- a/modules/bim/spec/contracts/ifc_models/update_contract_spec.rb +++ b/modules/bim/spec/contracts/ifc_models/update_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe Bim::IfcModels::UpdateContract do +RSpec.describe Bim::IfcModels::UpdateContract do it_behaves_like 'ifc model contract' do subject(:contract) { described_class.new(ifc_model, current_user) } diff --git a/modules/bim/spec/contracts/views/create_contract_bim_spec.rb b/modules/bim/spec/contracts/views/create_contract_bim_spec.rb index b0c253c0487..69702d49f3b 100644 --- a/modules/bim/spec/contracts/views/create_contract_bim_spec.rb +++ b/modules/bim/spec/contracts/views/create_contract_bim_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' require 'contracts/views/shared_contract_examples' -describe Views::CreateContract do +RSpec.describe Views::CreateContract do it_behaves_like 'view contract', true do let(:view) do View.new(query: view_query, diff --git a/modules/bim/spec/controllers/issues_controller_spec.rb b/modules/bim/spec/controllers/issues_controller_spec.rb index d2356f7f620..ea1aced2acd 100644 --- a/modules/bim/spec/controllers/issues_controller_spec.rb +++ b/modules/bim/spec/controllers/issues_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Bim::Bcf::IssuesController do +RSpec.describe Bim::Bcf::IssuesController do let(:manage_bcf_role) do create(:role, permissions: %i[manage_bcf view_linked_issues view_work_packages add_work_packages edit_work_packages]) diff --git a/modules/bim/spec/controllers/work_packages_controller_spec.rb b/modules/bim/spec/controllers/work_packages_controller_spec.rb index 582d5ba176b..6a6e1b48065 100644 --- a/modules/bim/spec/controllers/work_packages_controller_spec.rb +++ b/modules/bim/spec/controllers/work_packages_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackagesController do +RSpec.describe WorkPackagesController do before do login_as current_user end diff --git a/modules/bim/spec/features/bcf/api_authorization_spec.rb b/modules/bim/spec/features/bcf/api_authorization_spec.rb index 71caa48bdfc..9dad97126f6 100644 --- a/modules/bim/spec/features/bcf/api_authorization_spec.rb +++ b/modules/bim/spec/features/bcf/api_authorization_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'authorization for BCF api', - js: true, with_config: { edition: 'bim' } do +RSpec.describe 'authorization for BCF api', + js: true, with_config: { edition: 'bim' } do let!(:user) { create(:admin) } let(:client_secret) { app.plaintext_secret } let(:scope) { 'bcf_v2_1' } diff --git a/modules/bim/spec/features/bcf/bcf_snapshot_column_spec.rb b/modules/bim/spec/features/bcf/bcf_snapshot_column_spec.rb index d6f8055dea7..9cafd57bfc6 100644 --- a/modules/bim/spec/features/bcf/bcf_snapshot_column_spec.rb +++ b/modules/bim/spec/features/bcf/bcf_snapshot_column_spec.rb @@ -1,9 +1,9 @@ require 'spec_helper' -describe 'BCF snapshot column', - js: true, - with_config: { edition: 'bim' }, - with_mail: false do +RSpec.describe 'BCF snapshot column', + js: true, + with_config: { edition: 'bim' }, + with_mail: false do let(:project) { create(:project, enabled_module_names: %w[bim work_package_tracking]) } let(:wp_table) { Pages::WorkPackagesTable.new(project) } let(:permissions) { %i[add_work_packages view_work_packages view_linked_issues] } diff --git a/modules/bim/spec/features/bcf/create_spec.rb b/modules/bim/spec/features/bcf/create_spec.rb index 7bf4a65e90b..133bd0e7dc0 100644 --- a/modules/bim/spec/features/bcf/create_spec.rb +++ b/modules/bim/spec/features/bcf/create_spec.rb @@ -1,9 +1,9 @@ require_relative '../../spec_helper' -describe 'Create BCF', - js: true, - with_config: { edition: 'bim' }, - with_mail: false do +RSpec.describe 'Create BCF', + js: true, + with_config: { edition: 'bim' }, + with_mail: false do let(:project) do create(:project, types: [type, type_with_cf], diff --git a/modules/bim/spec/features/bcf/export_spec.rb b/modules/bim/spec/features/bcf/export_spec.rb index 922995d4d16..9dc3b694db6 100644 --- a/modules/bim/spec/features/bcf/export_spec.rb +++ b/modules/bim/spec/features/bcf/export_spec.rb @@ -28,9 +28,9 @@ require 'spec_helper' require_relative '../../support/pages/ifc_models/show_default' -describe 'bcf export', - js: true, - with_config: { edition: 'bim' } do +RSpec.describe 'bcf export', + js: true, + with_config: { edition: 'bim' } do let(:status) { create(:status, name: 'New', is_default: true) } let(:closed_status) { create(:closed_status, name: 'Closed') } let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) } diff --git a/modules/bim/spec/features/bcf_view_management_spec.rb b/modules/bim/spec/features/bcf_view_management_spec.rb index 8fd72257256..7dbf7876847 100644 --- a/modules/bim/spec/features/bcf_view_management_spec.rb +++ b/modules/bim/spec/features/bcf_view_management_spec.rb @@ -31,8 +31,8 @@ require 'spec_helper' require_relative '../support/pages/ifc_models/show_default' require_relative '../../../../spec/features/views/shared_examples' -describe 'bcf view management', - js: true, with_config: { edition: 'bim' } do +RSpec.describe 'bcf view management', + js: true, with_config: { edition: 'bim' } do let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) } let(:bcf_page) { Pages::IfcModels::ShowDefault.new(project) } let(:role) do diff --git a/modules/bim/spec/features/bim_filter_spec.rb b/modules/bim/spec/features/bim_filter_spec.rb index 2a9fde8e6db..59c735a7d90 100644 --- a/modules/bim/spec/features/bim_filter_spec.rb +++ b/modules/bim/spec/features/bim_filter_spec.rb @@ -31,8 +31,8 @@ require 'spec_helper' require_relative '../support/pages/ifc_models/show' require_relative '../support/pages/ifc_models/show_default' -describe 'BIM filter spec', - js: true, with_config: { edition: 'bim' } do +RSpec.describe 'BIM filter spec', + js: true, with_config: { edition: 'bim' } do let(:project) { create(:project, enabled_module_names: %w(bim work_package_tracking)) } let(:open_status) { create(:status, is_closed: false) } let(:closed_status) { create(:status, is_closed: true) } diff --git a/modules/bim/spec/features/bim_navigation_spec.rb b/modules/bim/spec/features/bim_navigation_spec.rb index f8d8123b9c5..e6fa07a552e 100644 --- a/modules/bim/spec/features/bim_navigation_spec.rb +++ b/modules/bim/spec/features/bim_navigation_spec.rb @@ -28,8 +28,8 @@ require_relative '../spec_helper' -describe 'BIM navigation spec', - js: true, with_config: { edition: 'bim' } do +RSpec.describe 'BIM navigation spec', + js: true, with_config: { edition: 'bim' } do let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) } let!(:work_package) { create(:work_package, project:) } let(:role) do diff --git a/modules/bim/spec/features/ifc_models/direct_ifc_upload_spec.rb b/modules/bim/spec/features/ifc_models/direct_ifc_upload_spec.rb index 3f42dc5d0e4..ae8e57fd521 100644 --- a/modules/bim/spec/features/ifc_models/direct_ifc_upload_spec.rb +++ b/modules/bim/spec/features/ifc_models/direct_ifc_upload_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './ifc_upload_shared_examples' -describe 'direct IFC upload', js: true, with_config: { edition: 'bim' }, with_direct_uploads: :redirect do +RSpec.describe 'direct IFC upload', js: true, with_config: { edition: 'bim' }, with_direct_uploads: :redirect do it_behaves_like 'can upload an IFC file' do # with direct upload, we don't get the model name let(:model_name) { 'model.ifc' } diff --git a/modules/bim/spec/features/ifc_models/ifc_upload_shared_examples.rb b/modules/bim/spec/features/ifc_models/ifc_upload_shared_examples.rb index c3b7dad0aca..37c1b3a6f14 100644 --- a/modules/bim/spec/features/ifc_models/ifc_upload_shared_examples.rb +++ b/modules/bim/spec/features/ifc_models/ifc_upload_shared_examples.rb @@ -1,4 +1,4 @@ -shared_examples 'can upload an IFC file' do +RSpec.shared_examples 'can upload an IFC file' do let(:user) { create(:admin) } let(:project) { create(:project, enabled_module_names: %i[bim]) } let(:ifc_fixture) { UploadedFile.load_from('modules/bim/spec/fixtures/files/minimal.ifc') } diff --git a/modules/bim/spec/features/ifc_models/regular_ifc_upload_spec.rb b/modules/bim/spec/features/ifc_models/regular_ifc_upload_spec.rb index c199fd4b0f6..bb1f89bdbc9 100644 --- a/modules/bim/spec/features/ifc_models/regular_ifc_upload_spec.rb +++ b/modules/bim/spec/features/ifc_models/regular_ifc_upload_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './ifc_upload_shared_examples' -describe 'IFC upload', js: true, with_config: { edition: 'bim' } do +RSpec.describe 'IFC upload', js: true, with_config: { edition: 'bim' } do it_behaves_like 'can upload an IFC file' do let(:model_name) { 'minimal.ifc' } end diff --git a/modules/bim/spec/features/model_management_spec.rb b/modules/bim/spec/features/model_management_spec.rb index c7b143aa19f..99f03a12394 100644 --- a/modules/bim/spec/features/model_management_spec.rb +++ b/modules/bim/spec/features/model_management_spec.rb @@ -30,8 +30,8 @@ require 'spec_helper' require_relative '../support/pages/ifc_models/index' -describe 'model management', - js: true, with_config: { edition: 'bim' } do +RSpec.describe 'model management', + js: true, with_config: { edition: 'bim' } do let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) } let(:index_page) { Pages::IfcModels::Index.new(project) } let(:role) { create(:role, permissions: %i[view_ifc_models manage_bcf manage_ifc_models view_work_packages]) } diff --git a/modules/bim/spec/features/model_viewer_spec.rb b/modules/bim/spec/features/model_viewer_spec.rb index cfe8a5f0bcd..21e8093f6d6 100644 --- a/modules/bim/spec/features/model_viewer_spec.rb +++ b/modules/bim/spec/features/model_viewer_spec.rb @@ -28,8 +28,8 @@ require_relative '../spec_helper' -describe 'model viewer', - js: true, with_config: { edition: 'bim' } do +RSpec.describe 'model viewer', + js: true, with_config: { edition: 'bim' } do let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) } # TODO: Add empty viewpoint and stub method to load viewpoints once defined let(:work_package) { create(:work_package, project:) } diff --git a/modules/bim/spec/features/revit_add_in/bim_revit_add_in_navigation_spec.rb b/modules/bim/spec/features/revit_add_in/bim_revit_add_in_navigation_spec.rb index ff41cd78e18..d12b779d68d 100644 --- a/modules/bim/spec/features/revit_add_in/bim_revit_add_in_navigation_spec.rb +++ b/modules/bim/spec/features/revit_add_in/bim_revit_add_in_navigation_spec.rb @@ -28,8 +28,8 @@ require_relative '../../spec_helper' -describe 'BIM Revit Add-in navigation spec', - driver: :chrome_revit_add_in, js: true, with_config: { edition: 'bim' } do +RSpec.describe 'BIM Revit Add-in navigation spec', + driver: :chrome_revit_add_in, js: true, with_config: { edition: 'bim' } do let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) } let!(:work_package) { create(:work_package, project:) } let(:role) do diff --git a/modules/bim/spec/features/revit_add_in/bim_revit_add_in_refresh_button_spec.rb b/modules/bim/spec/features/revit_add_in/bim_revit_add_in_refresh_button_spec.rb index 5573ea603dd..18268108775 100644 --- a/modules/bim/spec/features/revit_add_in/bim_revit_add_in_refresh_button_spec.rb +++ b/modules/bim/spec/features/revit_add_in/bim_revit_add_in_refresh_button_spec.rb @@ -28,8 +28,8 @@ require_relative '../../spec_helper' -describe 'BIM Revit Add-in navigation spec', - driver: :chrome_revit_add_in, js: true, with_config: { edition: 'bim' } do +RSpec.describe 'BIM Revit Add-in navigation spec', + driver: :chrome_revit_add_in, js: true, with_config: { edition: 'bim' } do let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) } let!(:work_package) { create(:work_package, project:) } let(:role) do diff --git a/modules/bim/spec/features/show_default_spec.rb b/modules/bim/spec/features/show_default_spec.rb index 438bd31138d..fd6a23b1b3b 100644 --- a/modules/bim/spec/features/show_default_spec.rb +++ b/modules/bim/spec/features/show_default_spec.rb @@ -28,8 +28,8 @@ require_relative '../spec_helper' -describe 'show default model', - js: true, with_config: { edition: 'bim' } do +RSpec.describe 'show default model', + js: true, with_config: { edition: 'bim' } do let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) } let(:index_page) { Pages::IfcModels::Index.new(project) } let(:show_default_page) { Pages::IfcModels::ShowDefault.new(project) } diff --git a/modules/bim/spec/features/viewer/create_viewpoint_spec.rb b/modules/bim/spec/features/viewer/create_viewpoint_spec.rb index b5ae7425f5e..a5a9bb1fc82 100644 --- a/modules/bim/spec/features/viewer/create_viewpoint_spec.rb +++ b/modules/bim/spec/features/viewer/create_viewpoint_spec.rb @@ -28,8 +28,8 @@ require_relative '../../spec_helper' -describe 'Create viewpoint from BCF details page', - js: true, with_config: { edition: 'bim' } do +RSpec.describe 'Create viewpoint from BCF details page', + js: true, with_config: { edition: 'bim' } do let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) } let(:user) { create(:admin) } diff --git a/modules/bim/spec/features/viewer/delete_viewpoint_spec.rb b/modules/bim/spec/features/viewer/delete_viewpoint_spec.rb index 28079d606a5..dc3f48b937b 100644 --- a/modules/bim/spec/features/viewer/delete_viewpoint_spec.rb +++ b/modules/bim/spec/features/viewer/delete_viewpoint_spec.rb @@ -28,8 +28,8 @@ require_relative '../../spec_helper' -describe 'Delete viewpoint in model viewer', - js: true, with_config: { edition: 'bim' } do +RSpec.describe 'Delete viewpoint in model viewer', + js: true, with_config: { edition: 'bim' } do let(:project) { create(:project, enabled_module_names: %i[bim work_package_tracking]) } let(:user) { create(:admin) } diff --git a/modules/bim/spec/features/viewer/show_viewpoint_spec.rb b/modules/bim/spec/features/viewer/show_viewpoint_spec.rb index a8f598cc3e5..d73b7a8ef1c 100644 --- a/modules/bim/spec/features/viewer/show_viewpoint_spec.rb +++ b/modules/bim/spec/features/viewer/show_viewpoint_spec.rb @@ -28,8 +28,8 @@ require_relative '../../spec_helper' -describe 'Show viewpoint in model viewer', - js: true, with_config: { edition: 'bim' } do +RSpec.describe 'Show viewpoint in model viewer', + js: true, with_config: { edition: 'bim' } do let(:project) do create(:project, enabled_module_names: %i[bim work_package_tracking], diff --git a/modules/bim/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb b/modules/bim/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb index d198bbcfc7f..6132f5d6fd2 100644 --- a/modules/bim/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb +++ b/modules/bim/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require Rails.root + 'spec/lib/api/v3/work_packages/eager_loading/eager_loading_mock_wrapper' -describe API::V3::WorkPackages::EagerLoading::Checksum do +RSpec.describe API::V3::WorkPackages::EagerLoading::Checksum do let!(:bcf_issue) do create(:bcf_issue, work_package:) diff --git a/modules/bim/spec/lib/open_project/access_control_spec.rb b/modules/bim/spec/lib/open_project/access_control_spec.rb index 5d1ca822fa8..0a44137167f 100644 --- a/modules/bim/spec/lib/open_project/access_control_spec.rb +++ b/modules/bim/spec/lib/open_project/access_control_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::AccessControl do +RSpec.describe OpenProject::AccessControl do describe '.sorted_module_names' do context 'with bim disabled' do before do diff --git a/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_shared_examples.rb b/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_shared_examples.rb index c6fa43154df..334e65dde62 100644 --- a/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_shared_examples.rb +++ b/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_shared_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples 'viewpoint keys' do +RSpec.shared_examples 'viewpoint keys' do let(:expected) { %w[guid components orthogonal_camera perspective_camera lines clipping_planes bitmaps] } it 'has only allowed keys' do @@ -47,7 +47,7 @@ shared_examples 'viewpoint keys' do end end -shared_examples 'has camera' do |camera_type| +RSpec.shared_examples 'has camera' do |camera_type| it 'has a camera object' do # camera xyz floats expect(subject.dig(camera_type)).to be_a(Hash) @@ -63,7 +63,7 @@ shared_examples 'has camera' do |camera_type| end end -shared_examples 'has lines' do +RSpec.shared_examples 'has lines' do it 'has a lines entry' do lines = subject['lines'] expect(lines).to be_a(Array) @@ -79,7 +79,7 @@ shared_examples 'has lines' do end end -shared_examples 'has clipping planes' do +RSpec.shared_examples 'has clipping planes' do it 'has a lines entry' do clipping_planes = subject['clipping_planes'] expect(clipping_planes).to be_a(Array) @@ -95,7 +95,7 @@ shared_examples 'has clipping planes' do end end -shared_examples 'has bitmaps' do +RSpec.shared_examples 'has bitmaps' do it 'has a bitmaps entry' do bitmaps = subject['bitmaps'] expect(bitmaps).to be_a(Array) @@ -114,7 +114,7 @@ shared_examples 'has bitmaps' do end end -shared_examples 'has components selection' do +RSpec.shared_examples 'has components selection' do it 'has components selections' do selection = subject.dig('components', 'selection') expect(selection).to be_a(Array) @@ -129,7 +129,7 @@ shared_examples 'has components selection' do end end -shared_examples 'has components coloring' do +RSpec.shared_examples 'has components coloring' do it 'has components coloring' do coloring = subject.dig('components', 'coloring') expect(coloring).to be_a(Array) @@ -148,7 +148,7 @@ shared_examples 'has components coloring' do end end -shared_examples 'has components visibility' do +RSpec.shared_examples 'has components visibility' do it 'has components visibility' do visibility = subject.dig('components', 'visibility') expect(visibility).to be_a(Hash) @@ -167,7 +167,7 @@ shared_examples 'has components visibility' do end end -shared_examples 'matches the JSON counterpart' do +RSpec.shared_examples 'matches the JSON counterpart' do it 'matches the JSON viewpoint counterpart' do path = OpenProject::Bim::Engine.root.join("spec/fixtures/viewpoints/#{xml_viewpoint.viewpoint_name}.json") raise "Expected #{path} to be readable for JSON comparison" unless path.readable? diff --git a/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_spec.rb b/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_spec.rb index 7dad188722f..7fd64af0161 100644 --- a/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_spec.rb +++ b/modules/bim/spec/lib/open_project/bcf/bcf_json/viewpoint_reader_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './viewpoint_reader_shared_examples' -describe OpenProject::Bim::BcfJson::ViewpointReader do +RSpec.describe OpenProject::Bim::BcfJson::ViewpointReader do let(:instance) { described_class.new xml_viewpoint.uuid, xml_viewpoint.viewpoint } subject { instance.result } diff --git a/modules/bim/spec/lib/open_project/bcf/bcf_xml/viewpoint_writer_spec.rb b/modules/bim/spec/lib/open_project/bcf/bcf_xml/viewpoint_writer_spec.rb index d7c0ae3dac4..477cbec700c 100644 --- a/modules/bim/spec/lib/open_project/bcf/bcf_xml/viewpoint_writer_spec.rb +++ b/modules/bim/spec/lib/open_project/bcf/bcf_xml/viewpoint_writer_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'compare-xml' -describe OpenProject::Bim::BcfXml::ViewpointWriter do +RSpec.describe OpenProject::Bim::BcfXml::ViewpointWriter do let(:writer_instance) { described_class.new json_resource } let(:reader_instance) { OpenProject::Bim::BcfJson::ViewpointReader.new xml_resource.uuid, subject.to_xml } let(:xml_comparison) { Nokogiri::XML(xml_resource.viewpoint) } diff --git a/modules/bim/spec/lib/open_project/bim/work_package/exporter/formatters/bcf_thumbnail_spec.rb b/modules/bim/spec/lib/open_project/bim/work_package/exporter/formatters/bcf_thumbnail_spec.rb index 197a500c488..883913f86de 100644 --- a/modules/bim/spec/lib/open_project/bim/work_package/exporter/formatters/bcf_thumbnail_spec.rb +++ b/modules/bim/spec/lib/open_project/bim/work_package/exporter/formatters/bcf_thumbnail_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::Bim::WorkPackage::Exporter::Formatters::BcfThumbnail do +RSpec.describe OpenProject::Bim::WorkPackage::Exporter::Formatters::BcfThumbnail do describe '::apply?' do it 'returns TRUE the bcf thumbnail' do expect(described_class).to be_apply(:bcf_thumbnail) diff --git a/modules/bim/spec/models/bcf/issue_spec.rb b/modules/bim/spec/models/bcf/issue_spec.rb index 2eeaa262287..5bac7923ebd 100644 --- a/modules/bim/spec/models/bcf/issue_spec.rb +++ b/modules/bim/spec/models/bcf/issue_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Bim::Bcf::Issue do +RSpec.describe Bim::Bcf::Issue do let(:type) { create(:type, name: "Issue [BCF]") } let(:work_package) { create(:work_package, type:) } let(:issue) { create(:bcf_issue, work_package:) } diff --git a/modules/bim/spec/models/ifc_model_spec.rb b/modules/bim/spec/models/ifc_model_spec.rb index 8e28acb492d..82db5b26360 100644 --- a/modules/bim/spec/models/ifc_model_spec.rb +++ b/modules/bim/spec/models/ifc_model_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Bim::IfcModels::IfcModel do +RSpec.describe Bim::IfcModels::IfcModel do subject { described_class.new params } let(:params) { { title: 'foo', is_default: true } } diff --git a/modules/bim/spec/models/queries/views/filters/type_filter_spec.rb b/modules/bim/spec/models/queries/views/filters/type_filter_spec.rb index 29e7b76a65a..3b22ba231a8 100644 --- a/modules/bim/spec/models/queries/views/filters/type_filter_spec.rb +++ b/modules/bim/spec/models/queries/views/filters/type_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Views::Filters::TypeFilter do +RSpec.describe Queries::Views::Filters::TypeFilter do let(:current_user) { create(:user) } before do diff --git a/modules/bim/spec/models/queries/work_packages/columns/bcf_thumbnail_column_spec.rb b/modules/bim/spec/models/queries/work_packages/columns/bcf_thumbnail_column_spec.rb index 74d68f2182d..7aba00c9afc 100644 --- a/modules/bim/spec/models/queries/work_packages/columns/bcf_thumbnail_column_spec.rb +++ b/modules/bim/spec/models/queries/work_packages/columns/bcf_thumbnail_column_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require Rails.root + 'spec/models/queries/work_packages/columns/shared_query_column_specs' -describe Bim::Queries::WorkPackages::Columns::BcfThumbnailColumn do +RSpec.describe Bim::Queries::WorkPackages::Columns::BcfThumbnailColumn do let(:instance) { described_class.new(:query_column) } it_behaves_like 'query column' diff --git a/modules/bim/spec/models/queries/work_packages/filter/bcf_issue_associated_filter_spec.rb b/modules/bim/spec/models/queries/work_packages/filter/bcf_issue_associated_filter_spec.rb index a62dedfab44..0c4c561c2f7 100644 --- a/modules/bim/spec/models/queries/work_packages/filter/bcf_issue_associated_filter_spec.rb +++ b/modules/bim/spec/models/queries/work_packages/filter/bcf_issue_associated_filter_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe Bim::Queries::WorkPackages::Filter::BcfIssueAssociatedFilter do +RSpec.describe Bim::Queries::WorkPackages::Filter::BcfIssueAssociatedFilter do include_context 'filter tests' let(:values) { [OpenProject::Database::DB_VALUE_TRUE] } diff --git a/modules/bim/spec/models/type_spec.rb b/modules/bim/spec/models/type_spec.rb index bb34e28ed8a..b83f7c0415a 100644 --- a/modules/bim/spec/models/type_spec.rb +++ b/modules/bim/spec/models/type_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Type do +RSpec.describe Type do let(:type) { create(:type, name: "Issue") } it 'bcf_thumbnail is available as a WorkPackageRepresenter attribute' do diff --git a/modules/bim/spec/representers/bcf/api/v2_1/auth/single_representer_rendering_spec.rb b/modules/bim/spec/representers/bcf/api/v2_1/auth/single_representer_rendering_spec.rb index fe4cea1181b..8a95f5531a1 100644 --- a/modules/bim/spec/representers/bcf/api/v2_1/auth/single_representer_rendering_spec.rb +++ b/modules/bim/spec/representers/bcf/api/v2_1/auth/single_representer_rendering_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../shared_examples' -describe Bim::Bcf::API::V2_1::Auth::SingleRepresenter, 'rendering' do +RSpec.describe Bim::Bcf::API::V2_1::Auth::SingleRepresenter, 'rendering' do let(:instance) { described_class.new(nil) } include OpenProject::StaticRouting::UrlHelpers diff --git a/modules/bim/spec/representers/bcf/api/v2_1/project_extensions/representer_spec.rb b/modules/bim/spec/representers/bcf/api/v2_1/project_extensions/representer_spec.rb index 5447660c439..dce9706a695 100644 --- a/modules/bim/spec/representers/bcf/api/v2_1/project_extensions/representer_spec.rb +++ b/modules/bim/spec/representers/bcf/api/v2_1/project_extensions/representer_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../shared_examples' -describe Bim::Bcf::API::V2_1::ProjectExtensions::Representer, 'rendering' do +RSpec.describe Bim::Bcf::API::V2_1::ProjectExtensions::Representer, 'rendering' do let(:type_task) { build_stubbed(:type_task, name: 'My BCF type') } let(:status) { build_stubbed(:status) } let(:user) { build_stubbed(:user) } diff --git a/modules/bim/spec/representers/bcf/api/v2_1/projects/single_representer_rendering_spec.rb b/modules/bim/spec/representers/bcf/api/v2_1/projects/single_representer_rendering_spec.rb index 10cfdf209a9..256cdd7e576 100644 --- a/modules/bim/spec/representers/bcf/api/v2_1/projects/single_representer_rendering_spec.rb +++ b/modules/bim/spec/representers/bcf/api/v2_1/projects/single_representer_rendering_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../shared_examples' -describe Bim::Bcf::API::V2_1::Projects::SingleRepresenter, 'rendering' do +RSpec.describe Bim::Bcf::API::V2_1::Projects::SingleRepresenter, 'rendering' do let(:project) { build_stubbed(:project) } let(:instance) { described_class.new(project) } diff --git a/modules/bim/spec/representers/bcf/api/v2_1/shared_examples.rb b/modules/bim/spec/representers/bcf/api/v2_1/shared_examples.rb index e389597ccec..8590df5de8c 100644 --- a/modules/bim/spec/representers/bcf/api/v2_1/shared_examples.rb +++ b/modules/bim/spec/representers/bcf/api/v2_1/shared_examples.rb @@ -1,4 +1,4 @@ -shared_examples_for 'attribute' do +RSpec.shared_examples_for 'attribute' do it 'reflects the value in the object' do expect(subject) .to be_json_eql(value.to_json) diff --git a/modules/bim/spec/representers/bcf/api/v2_1/topics/single_representer_rendering_spec.rb b/modules/bim/spec/representers/bcf/api/v2_1/topics/single_representer_rendering_spec.rb index 60c24d97c43..ad0560e38e3 100644 --- a/modules/bim/spec/representers/bcf/api/v2_1/topics/single_representer_rendering_spec.rb +++ b/modules/bim/spec/representers/bcf/api/v2_1/topics/single_representer_rendering_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../shared_examples' -describe Bim::Bcf::API::V2_1::Topics::SingleRepresenter, 'rendering' do +RSpec.describe Bim::Bcf::API::V2_1::Topics::SingleRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:assignee) { build_stubbed(:user) } diff --git a/modules/bim/spec/representers/bcf/api/v2_1/users/single_representer_rendering_spec.rb b/modules/bim/spec/representers/bcf/api/v2_1/users/single_representer_rendering_spec.rb index 3a68a70498a..d7fee6e87b2 100644 --- a/modules/bim/spec/representers/bcf/api/v2_1/users/single_representer_rendering_spec.rb +++ b/modules/bim/spec/representers/bcf/api/v2_1/users/single_representer_rendering_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../shared_examples' -describe Bim::Bcf::API::V2_1::Users::SingleRepresenter, 'rendering' do +RSpec.describe Bim::Bcf::API::V2_1::Users::SingleRepresenter, 'rendering' do let(:user) { build_stubbed(:user) } let(:instance) { described_class.new(user) } diff --git a/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representer_rendering_spec.rb b/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representer_rendering_spec.rb index a1bc3be0314..27c2448d270 100644 --- a/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representer_rendering_spec.rb +++ b/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representer_rendering_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../shared_examples' -describe Bim::Bcf::API::V2_1::Viewpoints::SingleRepresenter, 'rendering' do +RSpec.describe Bim::Bcf::API::V2_1::Viewpoints::SingleRepresenter, 'rendering' do let(:viewpoint) { build_stubbed(:bcf_viewpoint) } let(:instance) { described_class.new(viewpoint) } diff --git a/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representers_parsing_spec.rb b/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representers_parsing_spec.rb index 5032ba09cc9..b7c84af5528 100644 --- a/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representers_parsing_spec.rb +++ b/modules/bim/spec/representers/bcf/api/v2_1/viewpoints/single_representers_parsing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Bim::Bcf::API::V2_1::Viewpoints::SingleRepresenter, 'rendering' do +RSpec.describe Bim::Bcf::API::V2_1::Viewpoints::SingleRepresenter, 'rendering' do let(:struct) do OpenStruct.new end diff --git a/modules/bim/spec/requests/api/bcf/v2_1/auth_api_spec.rb b/modules/bim/spec/requests/api/bcf/v2_1/auth_api_spec.rb index 60e871f043b..6d8fb8e6948 100644 --- a/modules/bim/spec/requests/api/bcf/v2_1/auth_api_spec.rb +++ b/modules/bim/spec/requests/api/bcf/v2_1/auth_api_spec.rb @@ -31,7 +31,7 @@ require 'rack/test' require_relative './shared_responses' -describe 'BCF 2.1 auth resource', content_type: :json do +RSpec.describe 'BCF 2.1 auth resource', content_type: :json do include Rack::Test::Methods let(:current_user) do diff --git a/modules/bim/spec/requests/api/bcf/v2_1/comments_api_spec.rb b/modules/bim/spec/requests/api/bcf/v2_1/comments_api_spec.rb index d2544d5cc14..fd44d93e22d 100644 --- a/modules/bim/spec/requests/api/bcf/v2_1/comments_api_spec.rb +++ b/modules/bim/spec/requests/api/bcf/v2_1/comments_api_spec.rb @@ -31,7 +31,7 @@ require 'rack/test' require_relative './shared_responses' -describe 'BCF 2.1 comments resource', content_type: :json, with_mail: false do +RSpec.describe 'BCF 2.1 comments resource', content_type: :json, with_mail: false do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/bim/spec/requests/api/bcf/v2_1/current_user_api_spec.rb b/modules/bim/spec/requests/api/bcf/v2_1/current_user_api_spec.rb index 23e36302254..4e086ae01cf 100644 --- a/modules/bim/spec/requests/api/bcf/v2_1/current_user_api_spec.rb +++ b/modules/bim/spec/requests/api/bcf/v2_1/current_user_api_spec.rb @@ -31,7 +31,7 @@ require 'rack/test' require_relative './shared_responses' -describe 'BCF 2.1 current-user resource', content_type: :json do +RSpec.describe 'BCF 2.1 current-user resource', content_type: :json do include Rack::Test::Methods let(:current_user) do diff --git a/modules/bim/spec/requests/api/bcf/v2_1/project_extensions_api_spec.rb b/modules/bim/spec/requests/api/bcf/v2_1/project_extensions_api_spec.rb index 8464f79dc51..0c83d4978f6 100644 --- a/modules/bim/spec/requests/api/bcf/v2_1/project_extensions_api_spec.rb +++ b/modules/bim/spec/requests/api/bcf/v2_1/project_extensions_api_spec.rb @@ -31,7 +31,7 @@ require 'rack/test' require_relative './shared_responses' -describe 'BCF 2.1 project extensions resource', content_type: :json do +RSpec.describe 'BCF 2.1 project extensions resource', content_type: :json do include Rack::Test::Methods shared_let(:type_task) { create(:type_task) } shared_let(:status) { create(:default_status) } diff --git a/modules/bim/spec/requests/api/bcf/v2_1/projects_api_spec.rb b/modules/bim/spec/requests/api/bcf/v2_1/projects_api_spec.rb index b9269a2ee48..ca7b81f62b4 100644 --- a/modules/bim/spec/requests/api/bcf/v2_1/projects_api_spec.rb +++ b/modules/bim/spec/requests/api/bcf/v2_1/projects_api_spec.rb @@ -31,7 +31,7 @@ require 'rack/test' require_relative './shared_responses' -describe 'BCF 2.1 projects resource', content_type: :json do +RSpec.describe 'BCF 2.1 projects resource', content_type: :json do include Rack::Test::Methods let(:view_only_user) do diff --git a/modules/bim/spec/requests/api/bcf/v2_1/shared_responses.rb b/modules/bim/spec/requests/api/bcf/v2_1/shared_responses.rb index 0a56bfc61bd..3c1be305a86 100644 --- a/modules/bim/spec/requests/api/bcf/v2_1/shared_responses.rb +++ b/modules/bim/spec/requests/api/bcf/v2_1/shared_responses.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_examples_for 'bcf api successful response' do +RSpec.shared_examples_for 'bcf api successful response' do def expect_identical_without_time(subject, expected_body) body = Array.wrap(JSON.parse(subject.body)) expected = Array.wrap(expected_body) @@ -73,7 +73,7 @@ shared_examples_for 'bcf api successful response' do end end -shared_examples_for 'bcf api successful response expectation' do +RSpec.shared_examples_for 'bcf api successful response expectation' do it 'responds correctly with the expected body', :aggregate_failures do expect(subject.status).to eq 200 @@ -83,7 +83,7 @@ shared_examples_for 'bcf api successful response expectation' do end end -shared_examples_for 'bcf api not found response' do +RSpec.shared_examples_for 'bcf api not found response' do let(:expect404) do { message: 'The requested resource could not be found.' } end @@ -95,7 +95,7 @@ shared_examples_for 'bcf api not found response' do end end -shared_examples_for 'bcf api method not allowed response' do +RSpec.shared_examples_for 'bcf api method not allowed response' do let(:expect405) { "405 Not Allowed" } it 'responds 405 METHOD NOT ALLOWED', :aggregate_failures do @@ -105,7 +105,7 @@ shared_examples_for 'bcf api method not allowed response' do end end -shared_examples_for 'bcf api not allowed response' do +RSpec.shared_examples_for 'bcf api not allowed response' do let(:expect403) do { message: 'You are not authorized to access this resource.' } end @@ -117,7 +117,7 @@ shared_examples_for 'bcf api not allowed response' do end end -shared_examples_for 'bcf api unprocessable response' do +RSpec.shared_examples_for 'bcf api unprocessable response' do let(:expect422) do { message: } end @@ -129,7 +129,7 @@ shared_examples_for 'bcf api unprocessable response' do end end -shared_examples_for 'bcf api not implemented response' do +RSpec.shared_examples_for 'bcf api not implemented response' do it 'responds 501 not implemented', :aggregate_failures do expect(subject.status).to be 501 diff --git a/modules/bim/spec/requests/api/bcf/v2_1/topics_api_spec.rb b/modules/bim/spec/requests/api/bcf/v2_1/topics_api_spec.rb index 01eaf4e1019..fcf1d3ad1be 100644 --- a/modules/bim/spec/requests/api/bcf/v2_1/topics_api_spec.rb +++ b/modules/bim/spec/requests/api/bcf/v2_1/topics_api_spec.rb @@ -31,7 +31,7 @@ require 'rack/test' require_relative './shared_responses' -describe 'BCF 2.1 topics resource', content_type: :json, with_mail: false do +RSpec.describe 'BCF 2.1 topics resource', content_type: :json, with_mail: false do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/bim/spec/requests/api/bcf/v2_1/viewpoints_api_spec.rb b/modules/bim/spec/requests/api/bcf/v2_1/viewpoints_api_spec.rb index f0c14ed5893..2c266722f50 100644 --- a/modules/bim/spec/requests/api/bcf/v2_1/viewpoints_api_spec.rb +++ b/modules/bim/spec/requests/api/bcf/v2_1/viewpoints_api_spec.rb @@ -31,7 +31,7 @@ require 'rack/test' require_relative './shared_responses' -describe 'BCF 2.1 viewpoints resource', content_type: :json, with_mail: false do +RSpec.describe 'BCF 2.1 viewpoints resource', content_type: :json, with_mail: false do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/bim/spec/requests/api/bcf_xml/v1/bcf_xml_api_spec.rb b/modules/bim/spec/requests/api/bcf_xml/v1/bcf_xml_api_spec.rb index a3f592dd944..a01f0b3e1b7 100644 --- a/modules/bim/spec/requests/api/bcf_xml/v1/bcf_xml_api_spec.rb +++ b/modules/bim/spec/requests/api/bcf_xml/v1/bcf_xml_api_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'BCF XML API v1 bcf_xml resource' do +RSpec.describe 'BCF XML API v1 bcf_xml resource' do include Rack::Test::Methods let!(:status) { create(:status, name: 'New', is_default: true) } diff --git a/modules/bim/spec/seeders/root_seeder_bim_edition_spec.rb b/modules/bim/spec/seeders/root_seeder_bim_edition_spec.rb index 1b9dac6cc6f..0fd48adb8b7 100644 --- a/modules/bim/spec/seeders/root_seeder_bim_edition_spec.rb +++ b/modules/bim/spec/seeders/root_seeder_bim_edition_spec.rb @@ -31,9 +31,9 @@ require_relative '../../../../spec/seeders/root_seeder_shared_examples' RSpec::Matchers.define_negated_matcher :not_start_with, :start_with -describe RootSeeder, - 'BIM edition', - with_config: { edition: 'bim' } do +RSpec.describe RootSeeder, + 'BIM edition', + with_config: { edition: 'bim' } do include RootSeederTestHelpers shared_examples 'creates BIM demo data' do diff --git a/modules/bim/spec/services/bcf/issues/create_service_spec.rb b/modules/bim/spec/services/bcf/issues/create_service_spec.rb index 2d4601b7aee..0f6af4ed34b 100644 --- a/modules/bim/spec/services/bcf/issues/create_service_spec.rb +++ b/modules/bim/spec/services/bcf/issues/create_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Bim::Bcf::Issues::CreateService, type: :model do +RSpec.describe Bim::Bcf::Issues::CreateService, type: :model do it_behaves_like 'BaseServices create service' do let(:model_class) { Bim::Bcf::Issue } let(:factory) { :bcf_issue } diff --git a/modules/bim/spec/services/bcf/viewpoints/create_service_spec.rb b/modules/bim/spec/services/bcf/viewpoints/create_service_spec.rb index 8e0e3678ddd..43d9267e8b3 100644 --- a/modules/bim/spec/services/bcf/viewpoints/create_service_spec.rb +++ b/modules/bim/spec/services/bcf/viewpoints/create_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Bim::Bcf::Viewpoints::CreateService, type: :model do +RSpec.describe Bim::Bcf::Viewpoints::CreateService, type: :model do let(:user) { build_stubbed(:user) } let(:contract_class) do double('contract_class', '<=': true) diff --git a/modules/bim/spec/services/bcf/viewpoints/set_attributes_service_spec.rb b/modules/bim/spec/services/bcf/viewpoints/set_attributes_service_spec.rb index ba52ba071f0..c39cd65bd9d 100644 --- a/modules/bim/spec/services/bcf/viewpoints/set_attributes_service_spec.rb +++ b/modules/bim/spec/services/bcf/viewpoints/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Bim::Bcf::Viewpoints::SetAttributesService, type: :model do +RSpec.describe Bim::Bcf::Viewpoints::SetAttributesService, type: :model do let(:user) { build_stubbed(:user) } let(:contract_class) do contract = double('contract_class') diff --git a/modules/bim/spec/services/ifc_models/create_service_spec.rb b/modules/bim/spec/services/ifc_models/create_service_spec.rb index 3274c83874e..4c219aafe82 100644 --- a/modules/bim/spec/services/ifc_models/create_service_spec.rb +++ b/modules/bim/spec/services/ifc_models/create_service_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Bim::IfcModels::CreateService do +RSpec.describe Bim::IfcModels::CreateService do it_behaves_like 'BaseServices create service' do let(:model_class) { Bim::IfcModels::IfcModel } let(:factory) { :ifc_model } diff --git a/modules/bim/spec/services/ifc_models/set_attributes_service_spec.rb b/modules/bim/spec/services/ifc_models/set_attributes_service_spec.rb index 20eea6dc57e..be2a2904f8c 100644 --- a/modules/bim/spec/services/ifc_models/set_attributes_service_spec.rb +++ b/modules/bim/spec/services/ifc_models/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Bim::IfcModels::SetAttributesService, type: :model do +RSpec.describe Bim::IfcModels::SetAttributesService, type: :model do shared_let(:project) { create(:project, enabled_module_names: %i[bim]) } shared_let(:other_project) { create(:project, enabled_module_names: %i[bim]) } shared_let(:user) { create(:user, member_in_project: project, member_with_permissions: %i[manage_ifc_models]) } diff --git a/modules/bim/spec/services/ifc_models/update_service_spec.rb b/modules/bim/spec/services/ifc_models/update_service_spec.rb index 31f56e81975..2a7b0f52ea9 100644 --- a/modules/bim/spec/services/ifc_models/update_service_spec.rb +++ b/modules/bim/spec/services/ifc_models/update_service_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Bim::IfcModels::UpdateService do +RSpec.describe Bim::IfcModels::UpdateService do let(:user) { build_stubbed(:user) } let(:contract_class) do double('contract_class', '<=': true) diff --git a/modules/bim/spec/services/ifc_models/view_conversion_service_spec.rb b/modules/bim/spec/services/ifc_models/view_conversion_service_spec.rb index 29c6c3c7cb5..b309bad50d3 100644 --- a/modules/bim/spec/services/ifc_models/view_conversion_service_spec.rb +++ b/modules/bim/spec/services/ifc_models/view_conversion_service_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Bim::IfcModels::ViewConverterService do +RSpec.describe Bim::IfcModels::ViewConverterService do let(:model) { build(:ifc_model) } subject { described_class.new(model) } diff --git a/modules/bim/spec/support/bcf_topic_with_stubbed_comment.rb b/modules/bim/spec/support/bcf_topic_with_stubbed_comment.rb index 096725ab56f..08e3c52ca1e 100644 --- a/modules/bim/spec/support/bcf_topic_with_stubbed_comment.rb +++ b/modules/bim/spec/support/bcf_topic_with_stubbed_comment.rb @@ -1,4 +1,4 @@ -shared_context 'bcf_topic with stubbed comment' do |attributes = {}| +RSpec.shared_context 'bcf_topic with stubbed comment' do |attributes = {}| let(:attachment) { build_stubbed(:attachment, description: 'snapshot') } let(:viewpoint) { build_stubbed(:bcf_viewpoint, attachments: [attachment]) } let(:bcf_comment) { build_stubbed(:bcf_comment, viewpoint:) } diff --git a/modules/bim/spec/views/bim/ifc_models/ifc_models/index.html.erb_spec.rb b/modules/bim/spec/views/bim/ifc_models/ifc_models/index.html.erb_spec.rb index 630b657fb55..09fd5d9d2d2 100644 --- a/modules/bim/spec/views/bim/ifc_models/ifc_models/index.html.erb_spec.rb +++ b/modules/bim/spec/views/bim/ifc_models/ifc_models/index.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'bim/ifc_models/ifc_models/index' do +RSpec.describe 'bim/ifc_models/ifc_models/index' do let(:project) { create(:project, enabled_module_names: %i[bim]) } let(:ifc_model) do create(:ifc_model, diff --git a/modules/bim/spec/workers/ifc_conversion_job_spec.rb b/modules/bim/spec/workers/ifc_conversion_job_spec.rb index 5d302a995a3..0edbe69c763 100644 --- a/modules/bim/spec/workers/ifc_conversion_job_spec.rb +++ b/modules/bim/spec/workers/ifc_conversion_job_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Bim::IfcModels::IfcConversionJob, type: :job do +RSpec.describe Bim::IfcModels::IfcConversionJob, type: :job do let(:model) { build(:ifc_model) } subject { described_class.perform_now(model) } diff --git a/modules/bim/spec/workers/work_packages/exports/export_job_spec.rb b/modules/bim/spec/workers/work_packages/exports/export_job_spec.rb index 5de872cb32c..2f39edd9a0c 100644 --- a/modules/bim/spec/workers/work_packages/exports/export_job_spec.rb +++ b/modules/bim/spec/workers/work_packages/exports/export_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::ExportJob do +RSpec.describe WorkPackages::ExportJob do let(:user) { build_stubbed(:user) } let(:attachment) { double('Attachment', id: 1234) } let(:export) do diff --git a/modules/boards/spec/contracts/grids/create_contract_spec.rb b/modules/boards/spec/contracts/grids/create_contract_spec.rb index 2436b0894ef..5b67896c128 100644 --- a/modules/boards/spec/contracts/grids/create_contract_spec.rb +++ b/modules/boards/spec/contracts/grids/create_contract_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Grids::CreateContract, 'for Boards::Grid' do +RSpec.describe Grids::CreateContract, 'for Boards::Grid' do let(:project) { build_stubbed(:project) } let(:instance) { described_class.new(grid, user) } let(:user) { build_stubbed(:user) } diff --git a/modules/boards/spec/features/action_boards/assignee_board_spec.rb b/modules/boards/spec/features/action_boards/assignee_board_spec.rb index 1c03ac1a34c..0ea6828f7e2 100644 --- a/modules/boards/spec/features/action_boards/assignee_board_spec.rb +++ b/modules/boards/spec/features/action_boards/assignee_board_spec.rb @@ -30,9 +30,9 @@ require 'spec_helper' require_relative './../support/board_index_page' require_relative './../support/board_page' -describe 'Assignee action board', - js: true, - with_ee: %i[board_view] do +RSpec.describe 'Assignee action board', + js: true, + with_ee: %i[board_view] do let(:bobself_user) do create(:user, firstname: 'Bob', diff --git a/modules/boards/spec/features/action_boards/custom_field_filters_spec.rb b/modules/boards/spec/features/action_boards/custom_field_filters_spec.rb index 201186890c2..c14bb1ef0c6 100644 --- a/modules/boards/spec/features/action_boards/custom_field_filters_spec.rb +++ b/modules/boards/spec/features/action_boards/custom_field_filters_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './../support//board_index_page' require_relative './../support/board_page' -describe 'Custom field filter in boards', js: true, with_ee: %i[board_view] do +RSpec.describe 'Custom field filter in boards', js: true, with_ee: %i[board_view] do let(:user) do create(:user, member_in_project: project, diff --git a/modules/boards/spec/features/action_boards/status_board_spec.rb b/modules/boards/spec/features/action_boards/status_board_spec.rb index 43922a6e8e6..36a6feec7f4 100644 --- a/modules/boards/spec/features/action_boards/status_board_spec.rb +++ b/modules/boards/spec/features/action_boards/status_board_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './../support//board_index_page' require_relative './../support/board_page' -describe 'Status action board', js: true, with_ee: %i[board_view] do +RSpec.describe 'Status action board', js: true, with_ee: %i[board_view] do let(:user) do create(:user, member_in_project: project, diff --git a/modules/boards/spec/features/action_boards/status_type_moving_board_spec.rb b/modules/boards/spec/features/action_boards/status_type_moving_board_spec.rb index e55ff24ea4c..239d9552f4e 100644 --- a/modules/boards/spec/features/action_boards/status_type_moving_board_spec.rb +++ b/modules/boards/spec/features/action_boards/status_type_moving_board_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './../support//board_index_page' require_relative './../support/board_page' -describe 'Status action board', js: true, with_ee: %i[board_view] do +RSpec.describe 'Status action board', js: true, with_ee: %i[board_view] do let(:user) do create(:user, member_in_project: project, diff --git a/modules/boards/spec/features/action_boards/subproject_board_spec.rb b/modules/boards/spec/features/action_boards/subproject_board_spec.rb index 6c21b15f5af..9afa89bc00f 100644 --- a/modules/boards/spec/features/action_boards/subproject_board_spec.rb +++ b/modules/boards/spec/features/action_boards/subproject_board_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './../support//board_index_page' require_relative './../support/board_page' -describe 'Subproject action board', js: true, with_ee: %i[board_view] do +RSpec.describe 'Subproject action board', js: true, with_ee: %i[board_view] do let(:user) do create(:user, member_in_project: project, diff --git a/modules/boards/spec/features/action_boards/subtasks_board_spec.rb b/modules/boards/spec/features/action_boards/subtasks_board_spec.rb index e9b648a118c..34296bee7ee 100644 --- a/modules/boards/spec/features/action_boards/subtasks_board_spec.rb +++ b/modules/boards/spec/features/action_boards/subtasks_board_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './../support//board_index_page' require_relative './../support/board_page' -describe 'Subtasks action board', js: true, with_ee: %i[board_view] do +RSpec.describe 'Subtasks action board', js: true, with_ee: %i[board_view] do let(:type) { create(:type_standard) } let(:project) { create(:project, types: [type], enabled_module_names: %i[work_package_tracking board_view]) } let(:role) { create(:role, permissions:) } diff --git a/modules/boards/spec/features/action_boards/version_board_spec.rb b/modules/boards/spec/features/action_boards/version_board_spec.rb index 0f5e85d5a71..25d3ac3227b 100644 --- a/modules/boards/spec/features/action_boards/version_board_spec.rb +++ b/modules/boards/spec/features/action_boards/version_board_spec.rb @@ -31,7 +31,7 @@ require_relative './../support//board_index_page' require_relative './../support/board_page' # rubocop:disable RSpec:MultipleMemoizedHelpers -describe 'Version action board', js: true, with_ee: %i[board_view] do +RSpec.describe 'Version action board', js: true, with_ee: %i[board_view] do let(:user) do create(:user, member_in_projects: [project, second_project], diff --git a/modules/boards/spec/features/board_conflicts_spec.rb b/modules/boards/spec/features/board_conflicts_spec.rb index b280f44c697..e8d1ceed5c0 100644 --- a/modules/boards/spec/features/board_conflicts_spec.rb +++ b/modules/boards/spec/features/board_conflicts_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './support/board_index_page' require_relative './support/board_page' -describe 'Board remote changes resolution', js: true, with_ee: %i[board_view] do +RSpec.describe 'Board remote changes resolution', js: true, with_ee: %i[board_view] do let(:user1) do create(:user, member_in_project: project, diff --git a/modules/boards/spec/features/board_enterprise_spec.rb b/modules/boards/spec/features/board_enterprise_spec.rb index d96dc917b46..bf63571d675 100644 --- a/modules/boards/spec/features/board_enterprise_spec.rb +++ b/modules/boards/spec/features/board_enterprise_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './support/board_index_page' require_relative './support/board_page' -describe 'Boards enterprise spec', js: true do +RSpec.describe 'Boards enterprise spec', js: true do shared_let(:admin) { create(:admin) } shared_let(:project) { create(:project, enabled_module_names: %i[work_package_tracking board_view]) } diff --git a/modules/boards/spec/features/board_highlighting_spec.rb b/modules/boards/spec/features/board_highlighting_spec.rb index 07b05da2b29..40eaa63b0c5 100644 --- a/modules/boards/spec/features/board_highlighting_spec.rb +++ b/modules/boards/spec/features/board_highlighting_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './support/board_index_page' require_relative './support/board_page' -describe 'Work Package boards spec', js: true, with_ee: %i[board_view] do +RSpec.describe 'Work Package boards spec', js: true, with_ee: %i[board_view] do let(:user) do create(:user, member_in_project: project, diff --git a/modules/boards/spec/features/board_management_spec.rb b/modules/boards/spec/features/board_management_spec.rb index e46ad55b4b4..c77202a3404 100644 --- a/modules/boards/spec/features/board_management_spec.rb +++ b/modules/boards/spec/features/board_management_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './support/board_index_page' require_relative './support/board_page' -describe 'Board management spec', js: true, with_ee: %i[board_view] do +RSpec.describe 'Board management spec', js: true, with_ee: %i[board_view] do let(:user) do create(:user, member_in_project: project, diff --git a/modules/boards/spec/features/board_navigation_spec.rb b/modules/boards/spec/features/board_navigation_spec.rb index ef6227650e1..8a3f21e7de9 100644 --- a/modules/boards/spec/features/board_navigation_spec.rb +++ b/modules/boards/spec/features/board_navigation_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './support/board_index_page' require_relative './support/board_page' -describe 'Work Package boards spec', js: true, with_ee: %i[board_view] do +RSpec.describe 'Work Package boards spec', js: true, with_ee: %i[board_view] do let(:user) do create(:user, member_in_project: project, diff --git a/modules/boards/spec/features/board_overview_spec.rb b/modules/boards/spec/features/board_overview_spec.rb index f83934d4da8..9b4e602f4d3 100644 --- a/modules/boards/spec/features/board_overview_spec.rb +++ b/modules/boards/spec/features/board_overview_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './support/board_overview_page' -describe 'Work Package boards overview spec', with_ee: %i[board_view], with_flag: { more_global_index_pages: true } do +RSpec.describe 'Work Package boards overview spec', with_ee: %i[board_view], with_flag: { more_global_index_pages: true } do let(:user) do create(:user, member_in_project: project, diff --git a/modules/boards/spec/features/board_reference_work_package_spec.rb b/modules/boards/spec/features/board_reference_work_package_spec.rb index 9c7547ff0f7..ecb427a7695 100644 --- a/modules/boards/spec/features/board_reference_work_package_spec.rb +++ b/modules/boards/spec/features/board_reference_work_package_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './support/board_index_page' require_relative './support/board_page' -describe 'Board reference work package spec', js: true, with_ee: %i[board_view] do +RSpec.describe 'Board reference work package spec', js: true, with_ee: %i[board_view] do let(:user) do create(:user, member_in_project: project, diff --git a/modules/boards/spec/features/board_update_spec.rb b/modules/boards/spec/features/board_update_spec.rb index 091706ed228..2eb5f1a83ef 100644 --- a/modules/boards/spec/features/board_update_spec.rb +++ b/modules/boards/spec/features/board_update_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './support/board_index_page' require_relative './support/board_page' -describe 'Work Package boards updating spec', js: true, with_ee: %i[board_view] do +RSpec.describe 'Work Package boards updating spec', js: true, with_ee: %i[board_view] do let(:admin) { create(:admin) } let(:project) { create(:project, enabled_module_names: %i[work_package_tracking board_view]) } diff --git a/modules/boards/spec/features/boards_sorting_spec.rb b/modules/boards/spec/features/boards_sorting_spec.rb index 801593e5dbd..13b0f2d39be 100644 --- a/modules/boards/spec/features/boards_sorting_spec.rb +++ b/modules/boards/spec/features/boards_sorting_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './support/board_index_page' require_relative './support/board_page' -describe 'Work Package boards sorting spec', js: true, with_ee: %i[board_view] do +RSpec.describe 'Work Package boards sorting spec', js: true, with_ee: %i[board_view] do let(:admin) { create(:admin) } let(:project) { create(:project, enabled_module_names: %i[work_package_tracking board_view]) } let(:board_index) { Pages::BoardIndex.new(project) } diff --git a/modules/boards/spec/features/menu_items/top_menu_item_spec.rb b/modules/boards/spec/features/menu_items/top_menu_item_spec.rb index 33e26ccd5d1..ba6370c64b8 100644 --- a/modules/boards/spec/features/menu_items/top_menu_item_spec.rb +++ b/modules/boards/spec/features/menu_items/top_menu_item_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Top menu item for boards', js: true, selenium: true do +RSpec.describe 'Top menu item for boards', js: true, selenium: true do let(:user) { create(:admin) } let(:menu) { find(".op-app-menu a[title='#{I18n.t('label_modules')}']") } diff --git a/modules/boards/spec/features/onboarding/boards_onboarding_tour_spec.rb b/modules/boards/spec/features/onboarding/boards_onboarding_tour_spec.rb index 78b4ba01634..68fea7249f8 100644 --- a/modules/boards/spec/features/onboarding/boards_onboarding_tour_spec.rb +++ b/modules/boards/spec/features/onboarding/boards_onboarding_tour_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './../support/onboarding_steps' -describe 'boards onboarding tour', js: true do +RSpec.describe 'boards onboarding tour', js: true do let(:next_button) { find('.enjoyhint_next_btn') } let(:user) do create(:admin, diff --git a/modules/boards/spec/lib/open_project/boards/grid_registration_spec.rb b/modules/boards/spec/lib/open_project/boards/grid_registration_spec.rb index 46beb3678e1..3a6aaff6d37 100644 --- a/modules/boards/spec/lib/open_project/boards/grid_registration_spec.rb +++ b/modules/boards/spec/lib/open_project/boards/grid_registration_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe OpenProject::Boards::GridRegistration do +RSpec.describe OpenProject::Boards::GridRegistration do let(:project) { create(:project) } let(:permissions) { [:show_board_views] } let(:board) { create(:board_grid, project:) } diff --git a/modules/boards/spec/models/boards/grid_spec.rb b/modules/boards/spec/models/boards/grid_spec.rb index 7757b44534a..996abd2f7f4 100644 --- a/modules/boards/spec/models/boards/grid_spec.rb +++ b/modules/boards/spec/models/boards/grid_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Boards::Grid do +RSpec.describe Boards::Grid do let(:instance) { described_class.new } let(:project) { build_stubbed(:project) } diff --git a/modules/boards/spec/queries/grids/query_integration_spec.rb b/modules/boards/spec/queries/grids/query_integration_spec.rb index 30db843b511..8a420439180 100644 --- a/modules/boards/spec/queries/grids/query_integration_spec.rb +++ b/modules/boards/spec/queries/grids/query_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Grids::Query, type: :model do +RSpec.describe Grids::Query, type: :model do include OpenProject::StaticRouting::UrlHelpers shared_let(:project) { create(:project) } diff --git a/modules/boards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb b/modules/boards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb index f3a509c2652..cb1678176a5 100644 --- a/modules/boards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb +++ b/modules/boards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe "POST /api/v3/grids/form for Board Grids", content_type: :json do +RSpec.describe "POST /api/v3/grids/form for Board Grids", content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/boards/spec/requests/api/v3/grids/grids_resource_spec.rb b/modules/boards/spec/requests/api/v3/grids/grids_resource_spec.rb index 919b97fbdb7..6364f22eb28 100644 --- a/modules/boards/spec/requests/api/v3/grids/grids_resource_spec.rb +++ b/modules/boards/spec/requests/api/v3/grids/grids_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Grids resource for Board Grids', content_type: :json do +RSpec.describe 'API v3 Grids resource for Board Grids', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/boards/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb b/modules/boards/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb index 5b6f0cba093..06167ce4034 100644 --- a/modules/boards/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb +++ b/modules/boards/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe "PATCH /api/v3/grids/:id/form for Board Grids", content_type: :json do +RSpec.describe "PATCH /api/v3/grids/:id/form for Board Grids", content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/boards/spec/routing/boards_routing_spec.rb b/modules/boards/spec/routing/boards_routing_spec.rb index 3d543d72e46..9a938ad8c7d 100644 --- a/modules/boards/spec/routing/boards_routing_spec.rb +++ b/modules/boards/spec/routing/boards_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Boards routing' do +RSpec.describe 'Boards routing' do it { expect(subject) .to route(:get, '/projects/foobar/boards/state') diff --git a/modules/boards/spec/services/copy_service_integration_spec.rb b/modules/boards/spec/services/copy_service_integration_spec.rb index eb555da8c16..f01e170e582 100644 --- a/modules/boards/spec/services/copy_service_integration_spec.rb +++ b/modules/boards/spec/services/copy_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::CopyService, 'integration', type: :model do +RSpec.describe Projects::CopyService, 'integration', type: :model do let(:current_user) do create(:user, member_in_project: source, diff --git a/modules/budgets/spec/features/budgets/add_budget_spec.rb b/modules/budgets/spec/features/budgets/add_budget_spec.rb index cd56c57b655..ad0e23c2810 100644 --- a/modules/budgets/spec/features/budgets/add_budget_spec.rb +++ b/modules/budgets/spec/features/budgets/add_budget_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper.rb') -describe 'adding a new budget', js: true do +RSpec.describe 'adding a new budget', js: true do let(:project) { create(:project_with_types, members: project_members) } let(:user) { create(:admin) } let(:project_members) { {} } diff --git a/modules/budgets/spec/features/budgets/attachment_upload_spec.rb b/modules/budgets/spec/features/budgets/attachment_upload_spec.rb index f4999408ce2..987b0563a11 100644 --- a/modules/budgets/spec/features/budgets/attachment_upload_spec.rb +++ b/modules/budgets/spec/features/budgets/attachment_upload_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/page_objects/notification' -describe 'Upload attachment to budget', js: true do +RSpec.describe 'Upload attachment to budget', js: true do let(:user) do create(:user, member_in_project: project, member_with_permissions: %i[view_budgets edit_budgets]) end diff --git a/modules/budgets/spec/features/budgets/copy_budget_spec.rb b/modules/budgets/spec/features/budgets/copy_budget_spec.rb index 0ba1529c8ca..efaf1d9369c 100644 --- a/modules/budgets/spec/features/budgets/copy_budget_spec.rb +++ b/modules/budgets/spec/features/budgets/copy_budget_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper.rb') -describe 'Copying a budget', js: true do +RSpec.describe 'Copying a budget', js: true do let(:project) { create(:project, enabled_module_names: %i[budgets costs]) } let(:current_user) do create(:user, diff --git a/modules/budgets/spec/features/budgets/delete_budget_spec.rb b/modules/budgets/spec/features/budgets/delete_budget_spec.rb index 911877db57a..1dce6022553 100644 --- a/modules/budgets/spec/features/budgets/delete_budget_spec.rb +++ b/modules/budgets/spec/features/budgets/delete_budget_spec.rb @@ -28,7 +28,7 @@ require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper.rb") -describe 'Deleting a budget', js: true do +RSpec.describe 'Deleting a budget', js: true do let(:project) { create(:project, enabled_module_names: %i[budgets costs]) } let(:user) { create(:admin) } let(:budget_subject) { "A budget subject" } diff --git a/modules/budgets/spec/features/budgets/update_budget_spec.rb b/modules/budgets/spec/features/budgets/update_budget_spec.rb index fe7a5f532cd..82f07956cea 100644 --- a/modules/budgets/spec/features/budgets/update_budget_spec.rb +++ b/modules/budgets/spec/features/budgets/update_budget_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper.rb') -describe 'updating a budget', js: true do +RSpec.describe 'updating a budget', js: true do let(:project) do create(:project_with_types, enabled_module_names: %i[budgets costs work_package_tracking], diff --git a/modules/budgets/spec/features/costs_edit_fields_spec.rb b/modules/budgets/spec/features/costs_edit_fields_spec.rb index e1a98a10741..240ebcda9a6 100644 --- a/modules/budgets/spec/features/costs_edit_fields_spec.rb +++ b/modules/budgets/spec/features/costs_edit_fields_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb') -describe 'Work Package budget fields', js: true do +RSpec.describe 'Work Package budget fields', js: true do let(:type_task) { create(:type_task) } let!(:status) { create(:status, is_default: true) } let!(:priority) { create(:priority, is_default: true) } diff --git a/modules/budgets/spec/features/work_package_filter_spec.rb b/modules/budgets/spec/features/work_package_filter_spec.rb index 21b4a33767d..22580461e6a 100644 --- a/modules/budgets/spec/features/work_package_filter_spec.rb +++ b/modules/budgets/spec/features/work_package_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Filter by budget', js: true do +RSpec.describe 'Filter by budget', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/modules/budgets/spec/helpers/budgets_helper_spec.rb b/modules/budgets/spec/helpers/budgets_helper_spec.rb index 9766b1c399d..9e3e070cdf8 100644 --- a/modules/budgets/spec/helpers/budgets_helper_spec.rb +++ b/modules/budgets/spec/helpers/budgets_helper_spec.rb @@ -28,7 +28,7 @@ require File.dirname(__FILE__) + '/../spec_helper' -describe BudgetsHelper do +RSpec.describe BudgetsHelper do let(:project) { build(:project) } let(:budget) { build(:budget, project:) } diff --git a/modules/budgets/spec/lib/api/v3/budgets/budget_representer_spec.rb b/modules/budgets/spec/lib/api/v3/budgets/budget_representer_spec.rb index cca7a3ee935..99f26c3aa28 100644 --- a/modules/budgets/spec/lib/api/v3/budgets/budget_representer_spec.rb +++ b/modules/budgets/spec/lib/api/v3/budgets/budget_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Budgets::BudgetRepresenter do +RSpec.describe API::V3::Budgets::BudgetRepresenter do include API::V3::Utilities::PathHelper let(:project) { build(:project, id: 999) } diff --git a/modules/budgets/spec/lib/api/v3/path_helper_spec.rb b/modules/budgets/spec/lib/api/v3/path_helper_spec.rb index d238f9a6e07..6119f014c6e 100644 --- a/modules/budgets/spec/lib/api/v3/path_helper_spec.rb +++ b/modules/budgets/spec/lib/api/v3/path_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Utilities::PathHelper do +RSpec.describe API::V3::Utilities::PathHelper do let(:helper) { Class.new.tap { |c| c.extend(described_class) }.api_v3_paths } describe '#budget' do diff --git a/modules/budgets/spec/lib/api/v3/queries/schemas/cost_object_dependency_representer_spec.rb b/modules/budgets/spec/lib/api/v3/queries/schemas/cost_object_dependency_representer_spec.rb index e7428262edc..2fe863c03aa 100644 --- a/modules/budgets/spec/lib/api/v3/queries/schemas/cost_object_dependency_representer_spec.rb +++ b/modules/budgets/spec/lib/api/v3/queries/schemas/cost_object_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::BudgetFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::BudgetFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/modules/budgets/spec/models/budget_spec.rb b/modules/budgets/spec/models/budget_spec.rb index fa386eca9cf..c52bc60a760 100644 --- a/modules/budgets/spec/models/budget_spec.rb +++ b/modules/budgets/spec/models/budget_spec.rb @@ -28,7 +28,7 @@ require File.dirname(__FILE__) + '/../spec_helper' -describe Budget do +RSpec.describe Budget do let(:budget) { build(:budget, project:) } let(:type) { create(:type_feature) } let(:project) { create(:project_with_types) } diff --git a/modules/budgets/spec/models/labor_budget_item_spec.rb b/modules/budgets/spec/models/labor_budget_item_spec.rb index 9be7e30db55..6b1e0f69eba 100644 --- a/modules/budgets/spec/models/labor_budget_item_spec.rb +++ b/modules/budgets/spec/models/labor_budget_item_spec.rb @@ -28,7 +28,7 @@ require File.dirname(__FILE__) + '/../spec_helper' -describe LaborBudgetItem do +RSpec.describe LaborBudgetItem do let(:item) { build(:labor_budget_item, budget:, user:) } let(:budget) { build(:budget, project:) } let(:user) { create(:user) } diff --git a/modules/budgets/spec/models/permitted_params_spec.rb b/modules/budgets/spec/models/permitted_params_spec.rb index 721e12c6a67..f4a1979f1fa 100644 --- a/modules/budgets/spec/models/permitted_params_spec.rb +++ b/modules/budgets/spec/models/permitted_params_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe PermittedParams do +RSpec.describe PermittedParams do let(:user) { build(:user) } shared_examples_for 'allows params' do diff --git a/modules/budgets/spec/requests/api/v3/budgets/budget_resource_spec.rb b/modules/budgets/spec/requests/api/v3/budgets/budget_resource_spec.rb index 1463d3a4b93..fa9a56f72f8 100644 --- a/modules/budgets/spec/requests/api/v3/budgets/budget_resource_spec.rb +++ b/modules/budgets/spec/requests/api/v3/budgets/budget_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Budget resource' do +RSpec.describe 'API v3 Budget resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/budgets/spec/services/budgets/create_service_spec.rb b/modules/budgets/spec/services/budgets/create_service_spec.rb index 6b188a5ce44..a9981da1da8 100644 --- a/modules/budgets/spec/services/budgets/create_service_spec.rb +++ b/modules/budgets/spec/services/budgets/create_service_spec.rb @@ -29,6 +29,6 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Budgets::CreateService, type: :model do +RSpec.describe Budgets::CreateService, type: :model do it_behaves_like 'BaseServices create service' end diff --git a/modules/budgets/spec/services/budgets/update_service_spec.rb b/modules/budgets/spec/services/budgets/update_service_spec.rb index 33d2865d92b..8c861ba68b7 100644 --- a/modules/budgets/spec/services/budgets/update_service_spec.rb +++ b/modules/budgets/spec/services/budgets/update_service_spec.rb @@ -29,6 +29,6 @@ require 'spec_helper' require 'services/base_services/behaves_like_update_service' -describe Budgets::UpdateService, type: :model do +RSpec.describe Budgets::UpdateService, type: :model do it_behaves_like 'BaseServices update service' end diff --git a/modules/calendar/spec/controllers/calendar_controller_spec.rb b/modules/calendar/spec/controllers/calendar_controller_spec.rb index ab67f7aa99c..834510f4843 100644 --- a/modules/calendar/spec/controllers/calendar_controller_spec.rb +++ b/modules/calendar/spec/controllers/calendar_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Calendar::CalendarsController do +RSpec.describe Calendar::CalendarsController do let(:project) do build_stubbed(:project).tap do |p| allow(Project) diff --git a/modules/calendar/spec/features/calendar_create_work_package_spec.rb b/modules/calendar/spec/features/calendar_create_work_package_spec.rb index 48989d02cff..e6371390ec7 100644 --- a/modules/calendar/spec/features/calendar_create_work_package_spec.rb +++ b/modules/calendar/spec/features/calendar_create_work_package_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_context' -describe 'Calendar create new work package', js: true do +RSpec.describe 'Calendar create new work package', js: true do include_context 'with calendar full access' let(:type_task) { create(:type_task) } diff --git a/modules/calendar/spec/features/calendar_dates_spec.rb b/modules/calendar/spec/features/calendar_dates_spec.rb index 824a6e09be4..c7117296ad6 100644 --- a/modules/calendar/spec/features/calendar_dates_spec.rb +++ b/modules/calendar/spec/features/calendar_dates_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_context' -describe 'Calendar non working days', js: true do +RSpec.describe 'Calendar non working days', js: true do include_context 'with calendar full access' let!(:other_user) do diff --git a/modules/calendar/spec/features/calendar_project_include_spec.rb b/modules/calendar/spec/features/calendar_project_include_spec.rb index 2004b39531e..24645ee25ab 100644 --- a/modules/calendar/spec/features/calendar_project_include_spec.rb +++ b/modules/calendar/spec/features/calendar_project_include_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'features/work_packages/project_include/project_include_shared_examples' require_relative '../support/pages/calendar' -describe 'Calendar project include', js: true do +RSpec.describe 'Calendar project include', js: true do shared_let(:enabled_modules) { %w[work_package_tracking calendar_view] } shared_let(:permissions) do %i[view_work_packages view_calendar edit_work_packages add_work_packages save_queries manage_public_queries] diff --git a/modules/calendar/spec/features/calendar_user_interaction_spec.rb b/modules/calendar/spec/features/calendar_user_interaction_spec.rb index b029daf396e..ae0b9eea208 100644 --- a/modules/calendar/spec/features/calendar_user_interaction_spec.rb +++ b/modules/calendar/spec/features/calendar_user_interaction_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_context' -describe 'Calendar drag&dop and resizing', js: true do +RSpec.describe 'Calendar drag&dop and resizing', js: true do include_context 'with calendar full access' let!(:other_user) do diff --git a/modules/calendar/spec/features/calendar_widget_spec.rb b/modules/calendar/spec/features/calendar_widget_spec.rb index 6746b1c07ff..f794d5d3e77 100644 --- a/modules/calendar/spec/features/calendar_widget_spec.rb +++ b/modules/calendar/spec/features/calendar_widget_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../../../overviews/spec/support/pages/overview' -describe 'Calendar drag&dop and resizing', js: true do +RSpec.describe 'Calendar drag&dop and resizing', js: true do let(:project) do create(:project, enabled_module_names: %w[work_package_tracking calendar_view]) end diff --git a/modules/calendar/spec/features/calendars_index_spec.rb b/modules/calendar/spec/features/calendars_index_spec.rb index be71c7b0240..3efd4d99d66 100644 --- a/modules/calendar/spec/features/calendars_index_spec.rb +++ b/modules/calendar/spec/features/calendars_index_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Team planner index', js: true, with_ee: %i[team_planner_view] do +RSpec.describe 'Team planner index', js: true, with_ee: %i[team_planner_view] do shared_let(:project) do create(:project, enabled_module_names: %w[work_package_tracking calendar_view]) end diff --git a/modules/calendar/spec/features/calendars_spec.rb b/modules/calendar/spec/features/calendars_spec.rb index 176aee3d8ae..01cf2f65f54 100644 --- a/modules/calendar/spec/features/calendars_spec.rb +++ b/modules/calendar/spec/features/calendars_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Work package calendars', js: true do +RSpec.describe 'Work package calendars', js: true do let(:project) { create(:project) } let(:user) do create(:user, diff --git a/modules/calendar/spec/features/query_handling_spec.rb b/modules/calendar/spec/features/query_handling_spec.rb index 833f4c5df12..94b468e62b2 100644 --- a/modules/calendar/spec/features/query_handling_spec.rb +++ b/modules/calendar/spec/features/query_handling_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/calendar' require_relative '../../../../spec/features/views/shared_examples' -describe 'Calendar query handling', js: true do +RSpec.describe 'Calendar query handling', js: true do shared_let(:type_task) { create(:type_task) } shared_let(:type_bug) { create(:type_bug) } shared_let(:project) do diff --git a/modules/calendar/spec/features/shared_context.rb b/modules/calendar/spec/features/shared_context.rb index b121b1a1f70..7d720fbc3a3 100644 --- a/modules/calendar/spec/features/shared_context.rb +++ b/modules/calendar/spec/features/shared_context.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../support/pages/calendar' -shared_context 'with calendar full access' do +RSpec.shared_context 'with calendar full access' do shared_let(:project) do create(:project, enabled_module_names: %w[work_package_tracking calendar_view]) end diff --git a/modules/calendar/spec/routing/calendar_routing_spec.rb b/modules/calendar/spec/routing/calendar_routing_spec.rb index 3bf5593511c..6dff3cf7e3a 100644 --- a/modules/calendar/spec/routing/calendar_routing_spec.rb +++ b/modules/calendar/spec/routing/calendar_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Calendar::CalendarsController do +RSpec.describe Calendar::CalendarsController do it do expect(get('/projects/1/calendars')).to route_to(controller: 'calendar/calendars', action: 'index', diff --git a/modules/costs/spec/contracts/time_entries/create_contract_spec.rb b/modules/costs/spec/contracts/time_entries/create_contract_spec.rb index a21448d81ad..732f6294247 100644 --- a/modules/costs/spec/contracts/time_entries/create_contract_spec.rb +++ b/modules/costs/spec/contracts/time_entries/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe TimeEntries::CreateContract do +RSpec.describe TimeEntries::CreateContract do it_behaves_like 'time entry contract' do subject(:contract) do described_class.new(time_entry, current_user) diff --git a/modules/costs/spec/contracts/time_entries/delete_contract_spec.rb b/modules/costs/spec/contracts/time_entries/delete_contract_spec.rb index fac3299c76d..c1b4bfb3ac5 100644 --- a/modules/costs/spec/contracts/time_entries/delete_contract_spec.rb +++ b/modules/costs/spec/contracts/time_entries/delete_contract_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe TimeEntries::DeleteContract do +RSpec.describe TimeEntries::DeleteContract do let(:current_user) do build_stubbed(:user) do |user| allow(user) diff --git a/modules/costs/spec/contracts/time_entries/shared_contract_examples.rb b/modules/costs/spec/contracts/time_entries/shared_contract_examples.rb index 7ef1f811d62..4def22d08d7 100644 --- a/modules/costs/spec/contracts/time_entries/shared_contract_examples.rb +++ b/modules/costs/spec/contracts/time_entries/shared_contract_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'time entry contract' do +RSpec.shared_examples_for 'time entry contract' do let(:current_user) do build_stubbed(:user) do |user| allow(user) diff --git a/modules/costs/spec/contracts/time_entries/update_contract_spec.rb b/modules/costs/spec/contracts/time_entries/update_contract_spec.rb index ffc8010e66e..51db3560bb0 100644 --- a/modules/costs/spec/contracts/time_entries/update_contract_spec.rb +++ b/modules/costs/spec/contracts/time_entries/update_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe TimeEntries::UpdateContract do +RSpec.describe TimeEntries::UpdateContract do it_behaves_like 'time entry contract' do let(:time_entry) do build_stubbed(:time_entry, diff --git a/modules/costs/spec/controllers/cost_types_controller_spec.rb b/modules/costs/spec/controllers/cost_types_controller_spec.rb index 05a47b52921..7a5fbe489fa 100644 --- a/modules/costs/spec/controllers/cost_types_controller_spec.rb +++ b/modules/costs/spec/controllers/cost_types_controller_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb') -describe CostTypesController do +RSpec.describe CostTypesController do let(:admin) { create(:admin) } let(:cost_type) { create(:cost_type) } diff --git a/modules/costs/spec/controllers/costlog_controller_spec.rb b/modules/costs/spec/controllers/costlog_controller_spec.rb index 5171a588145..a1f054ca029 100644 --- a/modules/costs/spec/controllers/costlog_controller_spec.rb +++ b/modules/costs/spec/controllers/costlog_controller_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb') -describe CostlogController do +RSpec.describe CostlogController do include Cost::PluginSpecHelper let (:project) { create(:project_with_types) } let (:work_package) do diff --git a/modules/costs/spec/controllers/hourly_rates_controller_spec.rb b/modules/costs/spec/controllers/hourly_rates_controller_spec.rb index fc83bbc1123..6033c791c3c 100644 --- a/modules/costs/spec/controllers/hourly_rates_controller_spec.rb +++ b/modules/costs/spec/controllers/hourly_rates_controller_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb') -describe HourlyRatesController do +RSpec.describe HourlyRatesController do shared_let(:admin) { create(:admin) } let(:user) { create(:user) } diff --git a/modules/costs/spec/controllers/work_packages_bulk_controller_spec.rb b/modules/costs/spec/controllers/work_packages_bulk_controller_spec.rb index 7858a7306fb..f3608091760 100644 --- a/modules/costs/spec/controllers/work_packages_bulk_controller_spec.rb +++ b/modules/costs/spec/controllers/work_packages_bulk_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::BulkController do +RSpec.describe WorkPackages::BulkController do let(:project) { create(:project_with_types) } let(:controller_role) { build(:role, permissions: %i[view_work_packages edit_work_packages]) } let(:user) { create(:user, member_in_project: project, member_through_role: controller_role) } diff --git a/modules/costs/spec/features/cost_entries/add_cost_entry_spec.rb b/modules/costs/spec/features/cost_entries/add_cost_entry_spec.rb index 136b3b18706..bb56dd09191 100644 --- a/modules/costs/spec/features/cost_entries/add_cost_entry_spec.rb +++ b/modules/costs/spec/features/cost_entries/add_cost_entry_spec.rb @@ -28,7 +28,7 @@ require_relative '../../spec_helper' -describe 'Work Package cost fields', js: true do +RSpec.describe 'Work Package cost fields', js: true do shared_let(:type_task) { create(:type_task) } shared_let(:status) { create(:status, is_default: true) } shared_let(:priority) { create(:priority, is_default: true) } diff --git a/modules/costs/spec/features/cost_entries/add_entry_without_rate_permission_spec.rb b/modules/costs/spec/features/cost_entries/add_entry_without_rate_permission_spec.rb index 59e32754113..eda2552aa69 100644 --- a/modules/costs/spec/features/cost_entries/add_entry_without_rate_permission_spec.rb +++ b/modules/costs/spec/features/cost_entries/add_entry_without_rate_permission_spec.rb @@ -28,7 +28,7 @@ require_relative '../../spec_helper' -describe 'Create cost entry without rate permissions', js: true do +RSpec.describe 'Create cost entry without rate permissions', js: true do shared_let(:type_task) { create(:type_task) } shared_let(:status) { create(:status, is_default: true) } shared_let(:priority) { create(:priority, is_default: true) } diff --git a/modules/costs/spec/features/cost_types/create_cost_type_spec.rb b/modules/costs/spec/features/cost_types/create_cost_type_spec.rb index 46d39797a82..3ff350857f5 100644 --- a/modules/costs/spec/features/cost_types/create_cost_type_spec.rb +++ b/modules/costs/spec/features/cost_types/create_cost_type_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'creating a cost type', js: true do +RSpec.describe 'creating a cost type', js: true do let!(:user) { create(:admin) } let!(:cost_type) do type = create(:cost_type, name: 'Translations') diff --git a/modules/costs/spec/features/cost_types/delete_cost_type_spec.rb b/modules/costs/spec/features/cost_types/delete_cost_type_spec.rb index 90a588eccb9..e50afb68e26 100644 --- a/modules/costs/spec/features/cost_types/delete_cost_type_spec.rb +++ b/modules/costs/spec/features/cost_types/delete_cost_type_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'deleting a cost type', js: true do +RSpec.describe 'deleting a cost type', js: true do let!(:user) { create(:admin) } let!(:cost_type) do type = create(:cost_type, name: 'Translations') diff --git a/modules/costs/spec/features/costs_context_menu_spec.rb b/modules/costs/spec/features/costs_context_menu_spec.rb index cc07620efae..1cb8cf88e16 100644 --- a/modules/costs/spec/features/costs_context_menu_spec.rb +++ b/modules/costs/spec/features/costs_context_menu_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Work package table log unit costs', js: true do +RSpec.describe 'Work package table log unit costs', js: true do let(:user) { create(:admin) } let(:work_package) { create(:work_package) } diff --git a/modules/costs/spec/features/destroy_work_package_with_cost_entries_spec.rb b/modules/costs/spec/features/destroy_work_package_with_cost_entries_spec.rb index 1e1f5b88ed5..108adb0e503 100644 --- a/modules/costs/spec/features/destroy_work_package_with_cost_entries_spec.rb +++ b/modules/costs/spec/features/destroy_work_package_with_cost_entries_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb') -describe 'Deleting time entries', js: true do +RSpec.describe 'Deleting time entries', js: true do let(:project) { work_package.project } let(:user) do create(:user, diff --git a/modules/costs/spec/features/members_hourly_rates_spec.rb b/modules/costs/spec/features/members_hourly_rates_spec.rb index 43fa5c22bd8..b96e656ca67 100644 --- a/modules/costs/spec/features/members_hourly_rates_spec.rb +++ b/modules/costs/spec/features/members_hourly_rates_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb') -describe 'hourly rates on a member', js: true do +RSpec.describe 'hourly rates on a member', js: true do let(:project) { build(:project) } let(:user) do create(:admin, diff --git a/modules/costs/spec/features/time_entries_spec.rb b/modules/costs/spec/features/time_entries_spec.rb index 580dafdf2c8..2f9867aff7d 100644 --- a/modules/costs/spec/features/time_entries_spec.rb +++ b/modules/costs/spec/features/time_entries_spec.rb @@ -28,7 +28,7 @@ require_relative '../spec_helper' -describe 'Work Package table cost entries', js: true do +RSpec.describe 'Work Package table cost entries', js: true do shared_let(:project) { create(:project_with_types) } shared_let(:user) { create(:admin) } diff --git a/modules/costs/spec/features/time_entry/activity_spec.rb b/modules/costs/spec/features/time_entry/activity_spec.rb index 74bf5bdb646..f901808ad58 100644 --- a/modules/costs/spec/features/time_entry/activity_spec.rb +++ b/modules/costs/spec/features/time_entry/activity_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Time entry activity' do +RSpec.describe 'Time entry activity' do shared_let(:admin) { create(:admin) } let(:project) { create(:project) } diff --git a/modules/costs/spec/features/users_hourly_rates_spec.rb b/modules/costs/spec/features/users_hourly_rates_spec.rb index 07a479fbb85..b7aef734958 100644 --- a/modules/costs/spec/features/users_hourly_rates_spec.rb +++ b/modules/costs/spec/features/users_hourly_rates_spec.rb @@ -28,7 +28,7 @@ require_relative '../spec_helper' -describe 'hourly rates on user edit', js: true do +RSpec.describe 'hourly rates on user edit', js: true do let(:user) { create(:admin) } def view_rates diff --git a/modules/costs/spec/features/view_own_rates_spec.rb b/modules/costs/spec/features/view_own_rates_spec.rb index 563bdf07ffe..a78fc102b26 100644 --- a/modules/costs/spec/features/view_own_rates_spec.rb +++ b/modules/costs/spec/features/view_own_rates_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb') -describe 'Only see your own rates', js: true do +RSpec.describe 'Only see your own rates', js: true do let(:project) { work_package.project } let(:user) do create(:user, diff --git a/modules/costs/spec/helpers/costs/number_helper_spec.rb b/modules/costs/spec/helpers/costs/number_helper_spec.rb index 657a9e7cf0e..855313eb9f4 100644 --- a/modules/costs/spec/helpers/costs/number_helper_spec.rb +++ b/modules/costs/spec/helpers/costs/number_helper_spec.rb @@ -28,7 +28,7 @@ require File.dirname(__FILE__) + '/../../spec_helper' -describe Costs::NumberHelper do +RSpec.describe Costs::NumberHelper do describe '#parse_number_string' do context 'with a german local' do it 'parses a string with delimiter and separator correctly' do diff --git a/modules/costs/spec/lib/api/v3/cost_entries/aggregated_cost_entry_representer_spec.rb b/modules/costs/spec/lib/api/v3/cost_entries/aggregated_cost_entry_representer_spec.rb index a72b9596700..983c25cdaf2 100644 --- a/modules/costs/spec/lib/api/v3/cost_entries/aggregated_cost_entry_representer_spec.rb +++ b/modules/costs/spec/lib/api/v3/cost_entries/aggregated_cost_entry_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::CostEntries::AggregatedCostEntryRepresenter do +RSpec.describe API::V3::CostEntries::AggregatedCostEntryRepresenter do include API::V3::Utilities::PathHelper let(:cost_entry) { build_stubbed(:cost_entry) } diff --git a/modules/costs/spec/lib/api/v3/cost_entries/cost_entry_representer_spec.rb b/modules/costs/spec/lib/api/v3/cost_entries/cost_entry_representer_spec.rb index 813915a6793..503f6ac7809 100644 --- a/modules/costs/spec/lib/api/v3/cost_entries/cost_entry_representer_spec.rb +++ b/modules/costs/spec/lib/api/v3/cost_entries/cost_entry_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::CostEntries::CostEntryRepresenter do +RSpec.describe API::V3::CostEntries::CostEntryRepresenter do include API::V3::Utilities::PathHelper let(:cost_entry) { build_stubbed(:cost_entry) } diff --git a/modules/costs/spec/lib/api/v3/cost_entries/work_package_costs_by_type_representer_spec.rb b/modules/costs/spec/lib/api/v3/cost_entries/work_package_costs_by_type_representer_spec.rb index 8fa16b8b88b..2782a67f612 100644 --- a/modules/costs/spec/lib/api/v3/cost_entries/work_package_costs_by_type_representer_spec.rb +++ b/modules/costs/spec/lib/api/v3/cost_entries/work_package_costs_by_type_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::CostEntries::WorkPackageCostsByTypeRepresenter do +RSpec.describe API::V3::CostEntries::WorkPackageCostsByTypeRepresenter do include API::V3::Utilities::PathHelper let(:project) { create(:project) } diff --git a/modules/costs/spec/lib/api/v3/cost_types/cost_type_representer_spec.rb b/modules/costs/spec/lib/api/v3/cost_types/cost_type_representer_spec.rb index fd5987ab769..c4777424482 100644 --- a/modules/costs/spec/lib/api/v3/cost_types/cost_type_representer_spec.rb +++ b/modules/costs/spec/lib/api/v3/cost_types/cost_type_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::CostTypes::CostTypeRepresenter do +RSpec.describe API::V3::CostTypes::CostTypeRepresenter do include API::V3::Utilities::PathHelper let(:cost_type) { build_stubbed(:cost_type) } diff --git a/modules/costs/spec/lib/api/v3/costs_api_user_permission_check_spec.rb b/modules/costs/spec/lib/api/v3/costs_api_user_permission_check_spec.rb index 93d22443630..6564f0b7b05 100644 --- a/modules/costs/spec/lib/api/v3/costs_api_user_permission_check_spec.rb +++ b/modules/costs/spec/lib/api/v3/costs_api_user_permission_check_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::CostsApiUserPermissionCheck do +RSpec.describe API::V3::CostsApiUserPermissionCheck do class CostsApiUserPermissionCheckTestClass # mimic representer def view_time_entries_allowed? diff --git a/modules/costs/spec/lib/api/v3/path_helper_spec.rb b/modules/costs/spec/lib/api/v3/path_helper_spec.rb index a4966420d29..6ee4b492fcb 100644 --- a/modules/costs/spec/lib/api/v3/path_helper_spec.rb +++ b/modules/costs/spec/lib/api/v3/path_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Utilities::PathHelper do +RSpec.describe API::V3::Utilities::PathHelper do let(:helper) { Class.new.tap { |c| c.extend(described_class) }.api_v3_paths } describe '#cost_entry' do diff --git a/modules/costs/spec/lib/api/v3/time_entries/schemas/time_entry_schema_representer_spec.rb b/modules/costs/spec/lib/api/v3/time_entries/schemas/time_entry_schema_representer_spec.rb index 811dcea0d59..acee6b3c952 100644 --- a/modules/costs/spec/lib/api/v3/time_entries/schemas/time_entry_schema_representer_spec.rb +++ b/modules/costs/spec/lib/api/v3/time_entries/schemas/time_entry_schema_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::TimeEntries::Schemas::TimeEntrySchemaRepresenter do +RSpec.describe API::V3::TimeEntries::Schemas::TimeEntrySchemaRepresenter do include API::V3::Utilities::PathHelper let(:current_user) { build_stubbed(:user) } diff --git a/modules/costs/spec/lib/api/v3/time_entries/time_entries_activity_representer_rendering_spec.rb b/modules/costs/spec/lib/api/v3/time_entries/time_entries_activity_representer_rendering_spec.rb index 8a86c66214d..36948c6e775 100644 --- a/modules/costs/spec/lib/api/v3/time_entries/time_entries_activity_representer_rendering_spec.rb +++ b/modules/costs/spec/lib/api/v3/time_entries/time_entries_activity_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::TimeEntries::TimeEntriesActivityRepresenter, 'rendering' do +RSpec.describe API::V3::TimeEntries::TimeEntriesActivityRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:activity) do diff --git a/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_parsing_spec.rb b/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_parsing_spec.rb index 6a33b3be299..f6a2ad429e0 100644 --- a/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_parsing_spec.rb +++ b/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_parsing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::TimeEntries::TimeEntryRepresenter, 'parsing' do +RSpec.describe API::V3::TimeEntries::TimeEntryRepresenter, 'parsing' do include API::V3::Utilities::PathHelper let(:time_entry) do diff --git a/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_rendering_spec.rb b/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_rendering_spec.rb index f7d4e5b16a9..fdbc82adca8 100644 --- a/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_rendering_spec.rb +++ b/modules/costs/spec/lib/api/v3/time_entries/time_entry_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::TimeEntries::TimeEntryRepresenter, 'rendering' do +RSpec.describe API::V3::TimeEntries::TimeEntryRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:time_entry) do diff --git a/modules/costs/spec/lib/api/v3/work_packages/work_package_representer_spec.rb b/modules/costs/spec/lib/api/v3/work_packages/work_package_representer_spec.rb index 1bdecdee97d..de5621c9830 100644 --- a/modules/costs/spec/lib/api/v3/work_packages/work_package_representer_spec.rb +++ b/modules/costs/spec/lib/api/v3/work_packages/work_package_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::WorkPackageRepresenter do +RSpec.describe API::V3::WorkPackages::WorkPackageRepresenter do include API::V3::Utilities::PathHelper let(:project) { create(:project) } diff --git a/modules/costs/spec/lib/api/v3/work_packages/work_package_schema_representer_spec.rb b/modules/costs/spec/lib/api/v3/work_packages/work_package_schema_representer_spec.rb index ba0e748b4d0..c69b1dc62f0 100644 --- a/modules/costs/spec/lib/api/v3/work_packages/work_package_schema_representer_spec.rb +++ b/modules/costs/spec/lib/api/v3/work_packages/work_package_schema_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::Schema::WorkPackageSchemaRepresenter do +RSpec.describe API::V3::WorkPackages::Schema::WorkPackageSchemaRepresenter do let(:custom_field) { build(:custom_field) } let(:work_package) { build_stubbed(:work_package) } let(:current_user) do diff --git a/modules/costs/spec/lib/costs/query_currency_column_spec.rb b/modules/costs/spec/lib/costs/query_currency_column_spec.rb index 43c0408c78a..aa00beb9589 100644 --- a/modules/costs/spec/lib/costs/query_currency_column_spec.rb +++ b/modules/costs/spec/lib/costs/query_currency_column_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Costs::QueryCurrencyColumn, type: :model do +RSpec.describe Costs::QueryCurrencyColumn, type: :model do let(:project) do build_stubbed(:project).tap do |p| allow(p) diff --git a/modules/costs/spec/lib/open_project/costs/default_data_spec.rb b/modules/costs/spec/lib/open_project/costs/default_data_spec.rb index 84df39dbaa7..4ed5c50e5bc 100644 --- a/modules/costs/spec/lib/open_project/costs/default_data_spec.rb +++ b/modules/costs/spec/lib/open_project/costs/default_data_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Costs::DefaultData do +RSpec.describe Costs::DefaultData do let(:seeder) { BasicData::RoleSeeder.new } let(:member) { Costs::DefaultData.member_role } let(:permissions) { Costs::DefaultData.member_permissions } diff --git a/modules/costs/spec/models/cost_entry_spec.rb b/modules/costs/spec/models/cost_entry_spec.rb index 69fa46baa57..19b8448fde5 100644 --- a/modules/costs/spec/models/cost_entry_spec.rb +++ b/modules/costs/spec/models/cost_entry_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe CostEntry do +RSpec.describe CostEntry do include Cost::PluginSpecHelper let(:project) { create(:project_with_types) } diff --git a/modules/costs/spec/models/cost_type_spec.rb b/modules/costs/spec/models/cost_type_spec.rb index 9e51b53cb3f..91a3739fc76 100644 --- a/modules/costs/spec/models/cost_type_spec.rb +++ b/modules/costs/spec/models/cost_type_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb') -describe CostType do +RSpec.describe CostType do let(:klass) { CostType } let(:cost_type) do klass.new name: 'ct1', diff --git a/modules/costs/spec/models/default_hourly_rate_spec.rb b/modules/costs/spec/models/default_hourly_rate_spec.rb index 5b79dd66cca..d1ff40d6f69 100644 --- a/modules/costs/spec/models/default_hourly_rate_spec.rb +++ b/modules/costs/spec/models/default_hourly_rate_spec.rb @@ -28,7 +28,7 @@ require File.dirname(__FILE__) + '/../spec_helper' -describe DefaultHourlyRate do +RSpec.describe DefaultHourlyRate do let(:project) { create(:project) } let(:user) { create(:user) } let(:rate) do diff --git a/modules/costs/spec/models/hourly_rate_spec.rb b/modules/costs/spec/models/hourly_rate_spec.rb index acff63696f4..99810a85f88 100644 --- a/modules/costs/spec/models/hourly_rate_spec.rb +++ b/modules/costs/spec/models/hourly_rate_spec.rb @@ -28,7 +28,7 @@ require File.dirname(__FILE__) + '/../spec_helper' -describe HourlyRate do +RSpec.describe HourlyRate do let(:project) { create(:project) } let(:user) { create(:user) } let(:rate) do diff --git a/modules/costs/spec/models/permitted_params_spec.rb b/modules/costs/spec/models/permitted_params_spec.rb index 44698745866..78651042396 100644 --- a/modules/costs/spec/models/permitted_params_spec.rb +++ b/modules/costs/spec/models/permitted_params_spec.rb @@ -28,7 +28,7 @@ require File.expand_path('../spec_helper', __dir__) -describe PermittedParams do +RSpec.describe PermittedParams do let(:user) { build(:user) } shared_examples_for 'allows params' do diff --git a/modules/costs/spec/models/project/activity_spec.rb b/modules/costs/spec/models/project/activity_spec.rb index e35802cb00c..005e304f2ef 100644 --- a/modules/costs/spec/models/project/activity_spec.rb +++ b/modules/costs/spec/models/project/activity_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::Activity, 'costs' do +RSpec.describe Projects::Activity, 'costs' do shared_let(:project) do create(:project, :updated_a_long_time_ago) end diff --git a/modules/costs/spec/models/projects/scopes/activated_time_activity_spec.rb b/modules/costs/spec/models/projects/scopes/activated_time_activity_spec.rb index 500c7a95c1b..e323c8d4825 100644 --- a/modules/costs/spec/models/projects/scopes/activated_time_activity_spec.rb +++ b/modules/costs/spec/models/projects/scopes/activated_time_activity_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::Scopes::ActivatedTimeActivity do +RSpec.describe Projects::Scopes::ActivatedTimeActivity do let!(:activity) { create(:time_entry_activity) } let!(:project) { create(:project) } let!(:other_project) { create(:project) } diff --git a/modules/costs/spec/models/projects/scopes/visible_with_activated_time_activity_spec.rb b/modules/costs/spec/models/projects/scopes/visible_with_activated_time_activity_spec.rb index 485980f1827..e8cdbd4cd5d 100644 --- a/modules/costs/spec/models/projects/scopes/visible_with_activated_time_activity_spec.rb +++ b/modules/costs/spec/models/projects/scopes/visible_with_activated_time_activity_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::Scopes::VisibleWithActivatedTimeActivity do +RSpec.describe Projects::Scopes::VisibleWithActivatedTimeActivity do let!(:activity) { create(:time_entry_activity) } let!(:project) { create(:project) } let!(:other_project) { create(:project) } diff --git a/modules/costs/spec/models/queries/time_entries/filters/activity_filter_spec.rb b/modules/costs/spec/models/queries/time_entries/filters/activity_filter_spec.rb index 7c226246bd3..ac22ca27d47 100644 --- a/modules/costs/spec/models/queries/time_entries/filters/activity_filter_spec.rb +++ b/modules/costs/spec/models/queries/time_entries/filters/activity_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::TimeEntries::Filters::ActivityFilter do +RSpec.describe Queries::TimeEntries::Filters::ActivityFilter do let(:time_entry_activity1) { build_stubbed(:time_entry_activity) } let(:time_entry_activity2) { build_stubbed(:time_entry_activity) } let(:activities) { [time_entry_activity1, time_entry_activity2] } diff --git a/modules/costs/spec/models/queries/time_entries/filters/created_at_filter_spec.rb b/modules/costs/spec/models/queries/time_entries/filters/created_at_filter_spec.rb index 9f4fb0f19ea..7cf75d07c2d 100644 --- a/modules/costs/spec/models/queries/time_entries/filters/created_at_filter_spec.rb +++ b/modules/costs/spec/models/queries/time_entries/filters/created_at_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::TimeEntries::Filters::CreatedAtFilter do +RSpec.describe Queries::TimeEntries::Filters::CreatedAtFilter do it_behaves_like 'basic query filter' do let(:type) { :datetime_past } let(:class_key) { :created_at } diff --git a/modules/costs/spec/models/queries/time_entries/filters/project_filter_spec.rb b/modules/costs/spec/models/queries/time_entries/filters/project_filter_spec.rb index 46ab58da1c6..5afe0593827 100644 --- a/modules/costs/spec/models/queries/time_entries/filters/project_filter_spec.rb +++ b/modules/costs/spec/models/queries/time_entries/filters/project_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::TimeEntries::Filters::ProjectFilter do +RSpec.describe Queries::TimeEntries::Filters::ProjectFilter do let(:project1) { build_stubbed(:project) } let(:project2) { build_stubbed(:project) } diff --git a/modules/costs/spec/models/queries/time_entries/filters/spent_on_filter_spec.rb b/modules/costs/spec/models/queries/time_entries/filters/spent_on_filter_spec.rb index ce4ddb69765..802a08f321c 100644 --- a/modules/costs/spec/models/queries/time_entries/filters/spent_on_filter_spec.rb +++ b/modules/costs/spec/models/queries/time_entries/filters/spent_on_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::TimeEntries::Filters::SpentOnFilter do +RSpec.describe Queries::TimeEntries::Filters::SpentOnFilter do it_behaves_like 'basic query filter' do let(:type) { :date } let(:class_key) { :spent_on } diff --git a/modules/costs/spec/models/queries/time_entries/filters/updated_at_filter_spec.rb b/modules/costs/spec/models/queries/time_entries/filters/updated_at_filter_spec.rb index 5c7311943d4..c0b3d293a90 100644 --- a/modules/costs/spec/models/queries/time_entries/filters/updated_at_filter_spec.rb +++ b/modules/costs/spec/models/queries/time_entries/filters/updated_at_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::TimeEntries::Filters::UpdatedAtFilter do +RSpec.describe Queries::TimeEntries::Filters::UpdatedAtFilter do it_behaves_like 'basic query filter' do let(:type) { :datetime_past } let(:class_key) { :updated_at } diff --git a/modules/costs/spec/models/queries/time_entries/filters/user_filter_spec.rb b/modules/costs/spec/models/queries/time_entries/filters/user_filter_spec.rb index e039547975f..4d83f37dea4 100644 --- a/modules/costs/spec/models/queries/time_entries/filters/user_filter_spec.rb +++ b/modules/costs/spec/models/queries/time_entries/filters/user_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::TimeEntries::Filters::UserFilter do +RSpec.describe Queries::TimeEntries::Filters::UserFilter do let(:user1) { build_stubbed(:user) } let(:user2) { build_stubbed(:user) } diff --git a/modules/costs/spec/models/queries/time_entries/filters/work_package_filter_spec.rb b/modules/costs/spec/models/queries/time_entries/filters/work_package_filter_spec.rb index ae1a9a2ca23..189dda9393e 100644 --- a/modules/costs/spec/models/queries/time_entries/filters/work_package_filter_spec.rb +++ b/modules/costs/spec/models/queries/time_entries/filters/work_package_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::TimeEntries::Filters::WorkPackageFilter do +RSpec.describe Queries::TimeEntries::Filters::WorkPackageFilter do let(:work_package1) { build_stubbed(:work_package) } let(:work_package2) { build_stubbed(:work_package) } diff --git a/modules/costs/spec/models/queries/time_entries/time_entry_query_spec.rb b/modules/costs/spec/models/queries/time_entries/time_entry_query_spec.rb index f7d04120874..fdceea95443 100644 --- a/modules/costs/spec/models/queries/time_entries/time_entry_query_spec.rb +++ b/modules/costs/spec/models/queries/time_entries/time_entry_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::TimeEntries::TimeEntryQuery do +RSpec.describe Queries::TimeEntries::TimeEntryQuery do let(:user) { build_stubbed(:user) } let(:base_scope) { TimeEntry.visible(user).order(id: :desc) } let(:instance) { described_class.new } diff --git a/modules/costs/spec/models/rate_spec.rb b/modules/costs/spec/models/rate_spec.rb index baee66e40d2..289092e61f5 100644 --- a/modules/costs/spec/models/rate_spec.rb +++ b/modules/costs/spec/models/rate_spec.rb @@ -28,7 +28,7 @@ require File.dirname(__FILE__) + '/../spec_helper' -describe Rate do +RSpec.describe Rate do let(:rate) { build(:rate) } describe '#valid?' do diff --git a/modules/costs/spec/models/time_entries/scopes/of_user_and_day_spec.rb b/modules/costs/spec/models/time_entries/scopes/of_user_and_day_spec.rb index 3c5da975bfe..80710550229 100644 --- a/modules/costs/spec/models/time_entries/scopes/of_user_and_day_spec.rb +++ b/modules/costs/spec/models/time_entries/scopes/of_user_and_day_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe TimeEntries::Scopes::OfUserAndDay do +RSpec.describe TimeEntries::Scopes::OfUserAndDay do let(:user) { create(:user) } let(:spent_on) { Date.today } let!(:time_entry) do diff --git a/modules/costs/spec/models/time_entries/scopes/visible_spec.rb b/modules/costs/spec/models/time_entries/scopes/visible_spec.rb index 67e2c15bc87..0cdb263215f 100644 --- a/modules/costs/spec/models/time_entries/scopes/visible_spec.rb +++ b/modules/costs/spec/models/time_entries/scopes/visible_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe TimeEntries::Scopes::Visible do +RSpec.describe TimeEntries::Scopes::Visible do let(:project) { create(:project) } let(:user) do create(:user, diff --git a/modules/costs/spec/models/time_entry_activities/scopes/active_in_project_spec.rb b/modules/costs/spec/models/time_entry_activities/scopes/active_in_project_spec.rb index e87103dc30d..aff1c2f0bb9 100644 --- a/modules/costs/spec/models/time_entry_activities/scopes/active_in_project_spec.rb +++ b/modules/costs/spec/models/time_entry_activities/scopes/active_in_project_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe TimeEntryActivities::Scopes::ActiveInProject do +RSpec.describe TimeEntryActivities::Scopes::ActiveInProject do let!(:activity) { create(:time_entry_activity) } let!(:other_activity) { create(:time_entry_activity) } let(:project) { create(:project) } diff --git a/modules/costs/spec/models/time_entry_activity_spec.rb b/modules/costs/spec/models/time_entry_activity_spec.rb index 67d3e882533..f2210fb2c27 100644 --- a/modules/costs/spec/models/time_entry_activity_spec.rb +++ b/modules/costs/spec/models/time_entry_activity_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe TimeEntryActivity do +RSpec.describe TimeEntryActivity do let(:new_activity) { described_class.new } let(:saved_activity) { described_class.create name: 'Design' } diff --git a/modules/costs/spec/models/time_entry_spec.rb b/modules/costs/spec/models/time_entry_spec.rb index cae3c56555a..c399872623e 100644 --- a/modules/costs/spec/models/time_entry_spec.rb +++ b/modules/costs/spec/models/time_entry_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe TimeEntry do +RSpec.describe TimeEntry do let(:project) { create(:project_with_types, public: false) } let(:project2) { create(:project_with_types, public: false) } let(:work_package) do diff --git a/modules/costs/spec/models/user_spec.rb b/modules/costs/spec/models/user_spec.rb index 2e3c2b6896c..3a1624ac0e7 100644 --- a/modules/costs/spec/models/user_spec.rb +++ b/modules/costs/spec/models/user_spec.rb @@ -28,7 +28,7 @@ require File.dirname(__FILE__) + '/../spec_helper' -describe User do +RSpec.describe User do include Cost::PluginSpecHelper let(:klass) { User } let(:user) { build(:user) } diff --git a/modules/costs/spec/models/work_package/ask_before_destruction_spec.rb b/modules/costs/spec/models/work_package/ask_before_destruction_spec.rb index 1ab00083943..0e243093f66 100644 --- a/modules/costs/spec/models/work_package/ask_before_destruction_spec.rb +++ b/modules/costs/spec/models/work_package/ask_before_destruction_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage do +RSpec.describe WorkPackage do let(:work_package) do create(:work_package, project:, status:) diff --git a/modules/costs/spec/models/work_package_spec.rb b/modules/costs/spec/models/work_package_spec.rb index 894a09b41cf..be5fb0a6a2b 100644 --- a/modules/costs/spec/models/work_package_spec.rb +++ b/modules/costs/spec/models/work_package_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe WorkPackage do +RSpec.describe WorkPackage do let(:user) { create(:admin) } let(:role) { create(:role) } let(:project) do diff --git a/modules/costs/spec/requests/api/attachments/attachments_by_budget_resource_spec.rb b/modules/costs/spec/requests/api/attachments/attachments_by_budget_resource_spec.rb index 74a04ebbcf5..fa0f39d00c5 100644 --- a/modules/costs/spec/requests/api/attachments/attachments_by_budget_resource_spec.rb +++ b/modules/costs/spec/requests/api/attachments/attachments_by_budget_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'requests/api/v3/attachments/attachment_resource_shared_examples' -describe "budget attachments" do +RSpec.describe "budget attachments" do it_behaves_like "an APIv3 attachment resource" do let(:attachment_type) { :budget } diff --git a/modules/costs/spec/requests/api/cost_entries/cost_entries_by_work_package_resource_spec.rb b/modules/costs/spec/requests/api/cost_entries/cost_entries_by_work_package_resource_spec.rb index c614386a0fd..53be388317d 100644 --- a/modules/costs/spec/requests/api/cost_entries/cost_entries_by_work_package_resource_spec.rb +++ b/modules/costs/spec/requests/api/cost_entries/cost_entries_by_work_package_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Cost Entry resource' do +RSpec.describe 'API v3 Cost Entry resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/costs/spec/requests/api/cost_entries/cost_entry_resource_spec.rb b/modules/costs/spec/requests/api/cost_entries/cost_entry_resource_spec.rb index f942d8f6358..75a43d8d4fe 100644 --- a/modules/costs/spec/requests/api/cost_entries/cost_entry_resource_spec.rb +++ b/modules/costs/spec/requests/api/cost_entries/cost_entry_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Cost Entry resource' do +RSpec.describe 'API v3 Cost Entry resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/costs/spec/requests/api/cost_types/cost_type_resource_spec.rb b/modules/costs/spec/requests/api/cost_types/cost_type_resource_spec.rb index 72a85f58a13..f3d3bf6f7cd 100644 --- a/modules/costs/spec/requests/api/cost_types/cost_type_resource_spec.rb +++ b/modules/costs/spec/requests/api/cost_types/cost_type_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Cost Type resource' do +RSpec.describe 'API v3 Cost Type resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/costs/spec/requests/api/time_entries/available_projects_resource_spec.rb b/modules/costs/spec/requests/api/time_entries/available_projects_resource_spec.rb index 962a4c8a54f..33fbb71d0e4 100644 --- a/modules/costs/spec/requests/api/time_entries/available_projects_resource_spec.rb +++ b/modules/costs/spec/requests/api/time_entries/available_projects_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 time entries available projects resource' do +RSpec.describe 'API v3 time entries available projects resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/costs/spec/requests/api/time_entries/create_form_resource_spec.rb b/modules/costs/spec/requests/api/time_entries/create_form_resource_spec.rb index 191c39fa503..8fb787010b4 100644 --- a/modules/costs/spec/requests/api/time_entries/create_form_resource_spec.rb +++ b/modules/costs/spec/requests/api/time_entries/create_form_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::TimeEntries::CreateFormAPI, content_type: :json do +RSpec.describe API::V3::TimeEntries::CreateFormAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/costs/spec/requests/api/time_entries/schemas/time_entry_schema_resource_spec.rb b/modules/costs/spec/requests/api/time_entries/schemas/time_entry_schema_resource_spec.rb index 57e4e253e59..4e57b25f483 100644 --- a/modules/costs/spec/requests/api/time_entries/schemas/time_entry_schema_resource_spec.rb +++ b/modules/costs/spec/requests/api/time_entries/schemas/time_entry_schema_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Time entry schema resource', content_type: :json do +RSpec.describe 'API v3 Time entry schema resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/costs/spec/requests/api/time_entries/update_form_resource_spec.rb b/modules/costs/spec/requests/api/time_entries/update_form_resource_spec.rb index 923ab34400a..c598118b572 100644 --- a/modules/costs/spec/requests/api/time_entries/update_form_resource_spec.rb +++ b/modules/costs/spec/requests/api/time_entries/update_form_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::TimeEntries::UpdateFormAPI, content_type: :json do +RSpec.describe API::V3::TimeEntries::UpdateFormAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/costs/spec/requests/api/time_entry_activity_resource_spec.rb b/modules/costs/spec/requests/api/time_entry_activity_resource_spec.rb index 68a357bd72e..b4acb7df582 100644 --- a/modules/costs/spec/requests/api/time_entry_activity_resource_spec.rb +++ b/modules/costs/spec/requests/api/time_entry_activity_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 time_entry_activity resource' do +RSpec.describe 'API v3 time_entry_activity resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/costs/spec/requests/api/time_entry_resource_spec.rb b/modules/costs/spec/requests/api/time_entry_resource_spec.rb index e8c7558aded..d58d7ec13fe 100644 --- a/modules/costs/spec/requests/api/time_entry_resource_spec.rb +++ b/modules/costs/spec/requests/api/time_entry_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 time_entry resource' do +RSpec.describe 'API v3 time_entry resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/costs/spec/routing/cost_objects_routing_spec.rb b/modules/costs/spec/routing/cost_objects_routing_spec.rb index 1d5444d5d99..8230f996560 100644 --- a/modules/costs/spec/routing/cost_objects_routing_spec.rb +++ b/modules/costs/spec/routing/cost_objects_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe BudgetsController do +RSpec.describe BudgetsController do describe 'routing' do it { expect(get('/projects/blubs/budgets/new')).to route_to(controller: 'budgets', diff --git a/modules/costs/spec/routing/cost_types_routing_spec.rb b/modules/costs/spec/routing/cost_types_routing_spec.rb index 3f5976d3ac1..b6c22a5fbed 100644 --- a/modules/costs/spec/routing/cost_types_routing_spec.rb +++ b/modules/costs/spec/routing/cost_types_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CostTypesController do +RSpec.describe CostTypesController do describe 'routing' do it { expect(get('/cost_types')).to route_to(controller: 'cost_types', diff --git a/modules/costs/spec/routing/costlog_routing_spec.rb b/modules/costs/spec/routing/costlog_routing_spec.rb index 810c2547051..d8c7263bd90 100644 --- a/modules/costs/spec/routing/costlog_routing_spec.rb +++ b/modules/costs/spec/routing/costlog_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CostlogController do +RSpec.describe CostlogController do describe 'routing' do it { expect(get('/projects/blubs/cost_entries/new')).to route_to(controller: 'costlog', diff --git a/modules/costs/spec/routing/hourly_rates_routing_spec.rb b/modules/costs/spec/routing/hourly_rates_routing_spec.rb index 2627469588d..2f11f7a0b94 100644 --- a/modules/costs/spec/routing/hourly_rates_routing_spec.rb +++ b/modules/costs/spec/routing/hourly_rates_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe HourlyRatesController do +RSpec.describe HourlyRatesController do describe 'routing' do it { expect(get('/projects/blubs/hourly_rates/5')).to route_to(controller: 'hourly_rates', diff --git a/modules/costs/spec/services/time_entries/set_attributes_service_spec.rb b/modules/costs/spec/services/time_entries/set_attributes_service_spec.rb index 906d714945d..980c6b58e73 100644 --- a/modules/costs/spec/services/time_entries/set_attributes_service_spec.rb +++ b/modules/costs/spec/services/time_entries/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe TimeEntries::SetAttributesService, type: :model do +RSpec.describe TimeEntries::SetAttributesService, type: :model do let(:user) { build_stubbed(:user) } let(:activity) { build_stubbed(:time_entry_activity, project:) } let!(:default_activity) { build_stubbed(:time_entry_activity, project:, is_default: true) } diff --git a/modules/dashboards/spec/contracts/grids/create_contract_spec.rb b/modules/dashboards/spec/contracts/grids/create_contract_spec.rb index d596e5179b6..f0474731aa7 100644 --- a/modules/dashboards/spec/contracts/grids/create_contract_spec.rb +++ b/modules/dashboards/spec/contracts/grids/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_examples' -describe Grids::CreateContract do +RSpec.describe Grids::CreateContract do include_context 'grid contract' include_context 'model contract' diff --git a/modules/dashboards/spec/contracts/grids/shared_examples.rb b/modules/dashboards/spec/contracts/grids/shared_examples.rb index 1226782b2cc..27fa9a5de72 100644 --- a/modules/dashboards/spec/contracts/grids/shared_examples.rb +++ b/modules/dashboards/spec/contracts/grids/shared_examples.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_context 'grid contract' do +RSpec.shared_context 'grid contract' do let(:user) { build_stubbed(:user) } let(:instance) { described_class.new(grid, user) } let(:project) { build_stubbed(:project) } @@ -52,7 +52,7 @@ shared_context 'grid contract' do end end -shared_examples_for 'shared grid contract attributes' do +RSpec.shared_examples_for 'shared grid contract attributes' do include_context 'model contract' let(:model) { grid } diff --git a/modules/dashboards/spec/features/custom_text_spec.rb b/modules/dashboards/spec/features/custom_text_spec.rb index 012b7c0bebb..35afed7b9f5 100644 --- a/modules/dashboards/spec/features/custom_text_spec.rb +++ b/modules/dashboards/spec/features/custom_text_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'Project description widget on dashboard', js: true do +RSpec.describe 'Project description widget on dashboard', js: true do let!(:type) { create(:type_task, name: 'Task') } let!(:project) do create(:project, types: [type]) diff --git a/modules/dashboards/spec/features/docments_spec.rb b/modules/dashboards/spec/features/docments_spec.rb index 821a9a9e7a4..c8bf2bc56c7 100644 --- a/modules/dashboards/spec/features/docments_spec.rb +++ b/modules/dashboards/spec/features/docments_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'Documents widget on dashboard', js: true do +RSpec.describe 'Documents widget on dashboard', js: true do let!(:project) { create(:project) } let!(:other_project) { create(:project) } let!(:visible_document) do diff --git a/modules/dashboards/spec/features/members_principals_spec.rb b/modules/dashboards/spec/features/members_principals_spec.rb index 4e2cfaf17f2..c713117d080 100644 --- a/modules/dashboards/spec/features/members_principals_spec.rb +++ b/modules/dashboards/spec/features/members_principals_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'Dashboard page members', js: true, with_mail: false do +RSpec.describe 'Dashboard page members', js: true, with_mail: false do shared_let(:type) { create(:type) } shared_let(:project) { create(:project, types: [type], description: 'My **custom** description') } diff --git a/modules/dashboards/spec/features/members_spec.rb b/modules/dashboards/spec/features/members_spec.rb index 86ebb6390e8..b87dbf18fda 100644 --- a/modules/dashboards/spec/features/members_spec.rb +++ b/modules/dashboards/spec/features/members_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'Members widget on dashboard', js: true do +RSpec.describe 'Members widget on dashboard', js: true do let!(:project) { create(:project) } let!(:other_project) { create(:project) } diff --git a/modules/dashboards/spec/features/modifying_with_unallowed_spec.rb b/modules/dashboards/spec/features/modifying_with_unallowed_spec.rb index 2d681cfd737..907fe3f70da 100644 --- a/modules/dashboards/spec/features/modifying_with_unallowed_spec.rb +++ b/modules/dashboards/spec/features/modifying_with_unallowed_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'Modifying a dashboard which already has widgets for which permissions are lacking', js: true do +RSpec.describe 'Modifying a dashboard which already has widgets for which permissions are lacking', js: true do let!(:project) do create(:project) end diff --git a/modules/dashboards/spec/features/navigation_spec.rb b/modules/dashboards/spec/features/navigation_spec.rb index edc497c8da1..cb5e4903dda 100644 --- a/modules/dashboards/spec/features/navigation_spec.rb +++ b/modules/dashboards/spec/features/navigation_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Navigate to dashboard', js: true do +RSpec.describe 'Navigate to dashboard', js: true do let(:project) { create(:project) } let(:permissions) { [:view_dashboards] } let(:user) do diff --git a/modules/dashboards/spec/features/news_spec.rb b/modules/dashboards/spec/features/news_spec.rb index 7ab12349a91..388399efd57 100644 --- a/modules/dashboards/spec/features/news_spec.rb +++ b/modules/dashboards/spec/features/news_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'News widget on dashboard', js: true do +RSpec.describe 'News widget on dashboard', js: true do let!(:project) { create(:project) } let!(:other_project) { create(:project) } let!(:visible_news) do diff --git a/modules/dashboards/spec/features/project_description_spec.rb b/modules/dashboards/spec/features/project_description_spec.rb index 2bc9a8fa13a..75df9fd5245 100644 --- a/modules/dashboards/spec/features/project_description_spec.rb +++ b/modules/dashboards/spec/features/project_description_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'Project description widget on dashboard', js: true do +RSpec.describe 'Project description widget on dashboard', js: true do let(:project_description) { "Some text I like to write" } let!(:project) do create(:project, description: project_description) diff --git a/modules/dashboards/spec/features/project_details_spec.rb b/modules/dashboards/spec/features/project_details_spec.rb index e9a1ce85a0f..79bfda16dbe 100644 --- a/modules/dashboards/spec/features/project_details_spec.rb +++ b/modules/dashboards/spec/features/project_details_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'Project details widget on dashboard', js: true do +RSpec.describe 'Project details widget on dashboard', js: true do let!(:version_cf) { create(:version_project_custom_field) } let!(:bool_cf) { create(:bool_project_custom_field) } let!(:user_cf) { create(:user_project_custom_field) } diff --git a/modules/dashboards/spec/features/project_status_spec.rb b/modules/dashboards/spec/features/project_status_spec.rb index 24b0c14589e..f7134c1b56f 100644 --- a/modules/dashboards/spec/features/project_status_spec.rb +++ b/modules/dashboards/spec/features/project_status_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'Project status widget on dashboard', js: true do +RSpec.describe 'Project status widget on dashboard', js: true do let!(:project) do create(:project, status_code: 'on_track', diff --git a/modules/dashboards/spec/features/read_only_allowed_spec.rb b/modules/dashboards/spec/features/read_only_allowed_spec.rb index 57404110283..7885742e2c0 100644 --- a/modules/dashboards/spec/features/read_only_allowed_spec.rb +++ b/modules/dashboards/spec/features/read_only_allowed_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'Read only mode when user lacks edit permission on dashboard', js: true do +RSpec.describe 'Read only mode when user lacks edit permission on dashboard', js: true do let!(:type) { create(:type) } let!(:project) { create(:project, types: [type]) } let!(:work_package) do diff --git a/modules/dashboards/spec/features/subprojects_spec.rb b/modules/dashboards/spec/features/subprojects_spec.rb index 9490d21b14f..74fd6cb0129 100644 --- a/modules/dashboards/spec/features/subprojects_spec.rb +++ b/modules/dashboards/spec/features/subprojects_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'Subprojects widget on dashboard', js: true do +RSpec.describe 'Subprojects widget on dashboard', js: true do let!(:project) do create(:project, parent: parent_project) end diff --git a/modules/dashboards/spec/features/time_entries_spec.rb b/modules/dashboards/spec/features/time_entries_spec.rb index c1914003521..627bb170d57 100644 --- a/modules/dashboards/spec/features/time_entries_spec.rb +++ b/modules/dashboards/spec/features/time_entries_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'Time entries widget on dashboard', js: true, with_mail: false do +RSpec.describe 'Time entries widget on dashboard', js: true, with_mail: false do let!(:type) { create(:type) } let!(:project) { create(:project, types: [type]) } let!(:other_project) { create(:project, types: [type]) } diff --git a/modules/dashboards/spec/features/work_package_calendar_spec.rb b/modules/dashboards/spec/features/work_package_calendar_spec.rb index f7d7d0553af..de188a046ae 100644 --- a/modules/dashboards/spec/features/work_package_calendar_spec.rb +++ b/modules/dashboards/spec/features/work_package_calendar_spec.rb @@ -30,8 +30,8 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'Work package calendar widget on dashboard', - js: true, with_mail: false do +RSpec.describe 'Work package calendar widget on dashboard', + js: true, with_mail: false do let!(:type) { create(:type) } let!(:priority) { create(:default_priority) } let!(:project) { create(:project, types: [type]) } diff --git a/modules/dashboards/spec/features/work_package_graph_overview_spec.rb b/modules/dashboards/spec/features/work_package_graph_overview_spec.rb index fcc75a06b55..444deef4605 100644 --- a/modules/dashboards/spec/features/work_package_graph_overview_spec.rb +++ b/modules/dashboards/spec/features/work_package_graph_overview_spec.rb @@ -30,8 +30,8 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'Work package overview graph widget on dashboard', - js: true, with_mail: false do +RSpec.describe 'Work package overview graph widget on dashboard', + js: true, with_mail: false do let!(:type) { create(:type) } let!(:priority) { create(:default_priority) } let!(:project) { create(:project, types: [type]) } diff --git a/modules/dashboards/spec/features/work_package_graph_spec.rb b/modules/dashboards/spec/features/work_package_graph_spec.rb index 72043797a0e..105caeeb2e6 100644 --- a/modules/dashboards/spec/features/work_package_graph_spec.rb +++ b/modules/dashboards/spec/features/work_package_graph_spec.rb @@ -30,8 +30,8 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'Arbitrary WorkPackage query graph widget dashboard', - js: true, with_ee: %i[grid_widget_wp_graph], with_mail: false do +RSpec.describe 'Arbitrary WorkPackage query graph widget dashboard', + js: true, with_ee: %i[grid_widget_wp_graph], with_mail: false do let!(:type) { create(:type) } let!(:other_type) { create(:type) } let!(:priority) { create(:default_priority) } diff --git a/modules/dashboards/spec/features/work_package_table_spec.rb b/modules/dashboards/spec/features/work_package_table_spec.rb index caabcbe9455..7baff690500 100644 --- a/modules/dashboards/spec/features/work_package_table_spec.rb +++ b/modules/dashboards/spec/features/work_package_table_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/dashboard' -describe 'Arbitrary WorkPackage query table widget dashboard', js: true, with_mail: false do +RSpec.describe 'Arbitrary WorkPackage query table widget dashboard', js: true, with_mail: false do let!(:type) { create(:type) } let!(:other_type) { create(:type) } let!(:priority) { create(:default_priority) } diff --git a/modules/dashboards/spec/lib/dashboards/grid_registration_spec.rb b/modules/dashboards/spec/lib/dashboards/grid_registration_spec.rb index e2f0c5e0478..611d1f19eaa 100644 --- a/modules/dashboards/spec/lib/dashboards/grid_registration_spec.rb +++ b/modules/dashboards/spec/lib/dashboards/grid_registration_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Dashboards::GridRegistration do +RSpec.describe Dashboards::GridRegistration do let(:user) { build_stubbed(:user) } let(:project) { build_stubbed(:project) } let(:grid) { build_stubbed(:dashboard, project:) } diff --git a/modules/dashboards/spec/requests/api/v3/attachments/grid_spec.rb b/modules/dashboards/spec/requests/api/v3/attachments/grid_spec.rb index 61648098cae..4a35327e9dd 100644 --- a/modules/dashboards/spec/requests/api/v3/attachments/grid_spec.rb +++ b/modules/dashboards/spec/requests/api/v3/attachments/grid_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require File.join(Rails.root, 'spec', 'requests', 'api', 'v3', 'attachments', 'attachment_resource_shared_examples') -describe "grid attachments" do +RSpec.describe "grid attachments" do before do Grids::Dashboard end diff --git a/modules/dashboards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb b/modules/dashboards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb index d96881299ef..ce301e01cab 100644 --- a/modules/dashboards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb +++ b/modules/dashboards/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe "POST /api/v3/grids/form for Dashboard Grids", content_type: :json do +RSpec.describe "POST /api/v3/grids/form for Dashboard Grids", content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/dashboards/spec/requests/api/v3/grids/grids_resource_spec.rb b/modules/dashboards/spec/requests/api/v3/grids/grids_resource_spec.rb index b62bb2bbe1a..95afde92b79 100644 --- a/modules/dashboards/spec/requests/api/v3/grids/grids_resource_spec.rb +++ b/modules/dashboards/spec/requests/api/v3/grids/grids_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Grids resource', content_type: :json do +RSpec.describe 'API v3 Grids resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/documents/spec/api/v3/documents/document_representer_rendering_spec.rb b/modules/documents/spec/api/v3/documents/document_representer_rendering_spec.rb index 01a5d326d9e..299b9e61b97 100644 --- a/modules/documents/spec/api/v3/documents/document_representer_rendering_spec.rb +++ b/modules/documents/spec/api/v3/documents/document_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Documents::DocumentRepresenter, 'rendering' do +RSpec.describe API::V3::Documents::DocumentRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:document) do diff --git a/modules/documents/spec/application_helper_spec.rb b/modules/documents/spec/application_helper_spec.rb index b31771db849..4877038fad6 100644 --- a/modules/documents/spec/application_helper_spec.rb +++ b/modules/documents/spec/application_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ApplicationHelper do +RSpec.describe ApplicationHelper do include ApplicationHelper include ActionView::Helpers include ActionDispatch::Routing diff --git a/modules/documents/spec/controllers/documents_controller_spec.rb b/modules/documents/spec/controllers/documents_controller_spec.rb index 6e73db67998..121c7f9e416 100644 --- a/modules/documents/spec/controllers/documents_controller_spec.rb +++ b/modules/documents/spec/controllers/documents_controller_spec.rb @@ -28,7 +28,7 @@ require "#{File.dirname(__FILE__)}/../spec_helper" -describe DocumentsController do +RSpec.describe DocumentsController do render_views let(:admin) { create(:admin) } diff --git a/modules/documents/spec/features/attachment_upload_spec.rb b/modules/documents/spec/features/attachment_upload_spec.rb index 52802071614..e329469665f 100644 --- a/modules/documents/spec/features/attachment_upload_spec.rb +++ b/modules/documents/spec/features/attachment_upload_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/page_objects/notification' -describe 'Upload attachment to documents', +RSpec.describe 'Upload attachment to documents', js: true, with_settings: { journal_aggregation_time_minutes: 0 diff --git a/modules/documents/spec/lib/open_project/markdown_formatting_spec.rb b/modules/documents/spec/lib/open_project/markdown_formatting_spec.rb index 1d2fd4bee23..af8c4dd2c35 100644 --- a/modules/documents/spec/lib/open_project/markdown_formatting_spec.rb +++ b/modules/documents/spec/lib/open_project/markdown_formatting_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe OpenProject::TextFormatting, - 'Document links' do +RSpec.describe OpenProject::TextFormatting, + 'Document links' do include ActionView::Helpers::UrlHelper # soft-dependency include ActionView::Context include OpenProject::StaticRouting::UrlHelpers diff --git a/modules/documents/spec/lib/redmine/access_control_spec.rb b/modules/documents/spec/lib/redmine/access_control_spec.rb index cea1bf04534..485a36f4fbf 100644 --- a/modules/documents/spec/lib/redmine/access_control_spec.rb +++ b/modules/documents/spec/lib/redmine/access_control_spec.rb @@ -27,7 +27,7 @@ #++ require File.dirname(__FILE__) + '/../../spec_helper' -describe OpenProject::AccessControl do +RSpec.describe OpenProject::AccessControl do describe 'manage documents permission' do it 'is part of the documents project module' do permission = OpenProject::AccessControl.permission(:manage_documents) diff --git a/modules/documents/spec/mailers/documents_mailer_spec.rb b/modules/documents/spec/mailers/documents_mailer_spec.rb index 6158def1484..b6ab65b7cd9 100644 --- a/modules/documents/spec/mailers/documents_mailer_spec.rb +++ b/modules/documents/spec/mailers/documents_mailer_spec.rb @@ -27,7 +27,7 @@ #++ require File.dirname(__FILE__) + '/../spec_helper' -describe DocumentsMailer do +RSpec.describe DocumentsMailer do let(:user) do create(:user, firstname: 'Test', lastname: "User", mail: 'test@test.com') end diff --git a/modules/documents/spec/models/document_category_spec.rb b/modules/documents/spec/models/document_category_spec.rb index 75bfdd0f559..b4bf1e631ed 100644 --- a/modules/documents/spec/models/document_category_spec.rb +++ b/modules/documents/spec/models/document_category_spec.rb @@ -27,7 +27,7 @@ #++ require File.dirname(__FILE__) + '/../spec_helper' -describe DocumentCategory do +RSpec.describe DocumentCategory do let(:project) { create(:project) } it "is an enumeration" do diff --git a/modules/documents/spec/models/document_spec.rb b/modules/documents/spec/models/document_spec.rb index 1375be94573..1c2f35ea53f 100644 --- a/modules/documents/spec/models/document_spec.rb +++ b/modules/documents/spec/models/document_spec.rb @@ -27,7 +27,7 @@ #++ require File.dirname(__FILE__) + '/../spec_helper' -describe Document do +RSpec.describe Document do let(:documentation_category) { create(:document_category, name: 'User documentation') } let(:project) { create(:project) } let(:user) { create(:user) } diff --git a/modules/documents/spec/models/queries/documents/document_query_spec.rb b/modules/documents/spec/models/queries/documents/document_query_spec.rb index ee840ab219f..79602f4eb1f 100644 --- a/modules/documents/spec/models/queries/documents/document_query_spec.rb +++ b/modules/documents/spec/models/queries/documents/document_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Documents::DocumentQuery do +RSpec.describe Queries::Documents::DocumentQuery do let(:user) { build_stubbed(:user) } let(:base_scope) { Document.visible(user).order(id: :desc) } let(:instance) { described_class.new } diff --git a/modules/documents/spec/models/queries/documents/filters/project_filter_spec.rb b/modules/documents/spec/models/queries/documents/filters/project_filter_spec.rb index 2eb0999898f..8b0877874da 100644 --- a/modules/documents/spec/models/queries/documents/filters/project_filter_spec.rb +++ b/modules/documents/spec/models/queries/documents/filters/project_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Documents::Filters::ProjectFilter do +RSpec.describe Queries::Documents::Filters::ProjectFilter do let(:project1) { build_stubbed(:project) } let(:project2) { build_stubbed(:project) } diff --git a/modules/documents/spec/requests/api/v3/attachments/attachments_by_documents_resource_spec.rb b/modules/documents/spec/requests/api/v3/attachments/attachments_by_documents_resource_spec.rb index 9146a8898a2..a92be6370f3 100644 --- a/modules/documents/spec/requests/api/v3/attachments/attachments_by_documents_resource_spec.rb +++ b/modules/documents/spec/requests/api/v3/attachments/attachments_by_documents_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'requests/api/v3/attachments/attachment_resource_shared_examples' -describe "document attachments" do +RSpec.describe "document attachments" do it_behaves_like "an APIv3 attachment resource" do let(:attachment_type) { :document } diff --git a/modules/documents/spec/requests/api/v3/documents/documents_resource_spec.rb b/modules/documents/spec/requests/api/v3/documents/documents_resource_spec.rb index 495dfb586c4..d7850b942b7 100644 --- a/modules/documents/spec/requests/api/v3/documents/documents_resource_spec.rb +++ b/modules/documents/spec/requests/api/v3/documents/documents_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 documents resource' do +RSpec.describe 'API v3 documents resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/documents/spec/routing/documents_routing_spec.rb b/modules/documents/spec/routing/documents_routing_spec.rb index d6fdd63659e..afae8c81934 100644 --- a/modules/documents/spec/routing/documents_routing_spec.rb +++ b/modules/documents/spec/routing/documents_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe DocumentsController do +RSpec.describe DocumentsController do describe "routing" do it { expect(get('/projects/567/documents')).to route_to(controller: 'documents', diff --git a/modules/documents/spec/services/notifications/create_from_model_service_document_spec.rb b/modules/documents/spec/services/notifications/create_from_model_service_document_spec.rb index e366a4bfbee..5959993b297 100644 --- a/modules/documents/spec/services/notifications/create_from_model_service_document_spec.rb +++ b/modules/documents/spec/services/notifications/create_from_model_service_document_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require Rails.root.join('spec/services/notifications/create_from_journal_job_shared') -describe Notifications::CreateFromModelService, 'document', with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe Notifications::CreateFromModelService, 'document', with_settings: { journal_aggregation_time_minutes: 0 } do subject(:call) do described_class.new(journal).call(send_notifications) end diff --git a/modules/documents/spec/services/notifications/mail_service_spec.rb b/modules/documents/spec/services/notifications/mail_service_spec.rb index eb398ae3cad..7045e1aa2d2 100644 --- a/modules/documents/spec/services/notifications/mail_service_spec.rb +++ b/modules/documents/spec/services/notifications/mail_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Notifications::MailService, type: :model do +RSpec.describe Notifications::MailService, type: :model do subject(:call) { instance.call } let(:recipient) do diff --git a/modules/github_integration/spec/features/work_package_github_tab_spec.rb b/modules/github_integration/spec/features/work_package_github_tab_spec.rb index e822dae4850..f19b625387b 100644 --- a/modules/github_integration/spec/features/work_package_github_tab_spec.rb +++ b/modules/github_integration/spec/features/work_package_github_tab_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../support/pages/work_package_github_tab' -describe 'Open the GitHub tab', js: true do +RSpec.describe 'Open the GitHub tab', js: true do let(:user) do create(:user, member_in_project: project, diff --git a/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_check_run_representer_spec.rb b/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_check_run_representer_spec.rb index e9deeade612..defe5c6a76b 100644 --- a/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_check_run_representer_spec.rb +++ b/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_check_run_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::GithubPullRequests::GithubCheckRunRepresenter do +RSpec.describe API::V3::GithubPullRequests::GithubCheckRunRepresenter do include API::V3::Utilities::PathHelper subject(:generated) { representer.to_json } diff --git a/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_pull_request_representer_spec.rb b/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_pull_request_representer_spec.rb index 8c6880ab0bd..687e1dd5793 100644 --- a/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_pull_request_representer_spec.rb +++ b/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_pull_request_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::GithubPullRequests::GithubPullRequestRepresenter do +RSpec.describe API::V3::GithubPullRequests::GithubPullRequestRepresenter do include API::V3::Utilities::PathHelper subject(:generated) { representer.to_json } diff --git a/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_user_representer_spec.rb b/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_user_representer_spec.rb index 4b6717a63ff..75837142dca 100644 --- a/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_user_representer_spec.rb +++ b/modules/github_integration/spec/lib/api/v3/github_pull_requests/github_user_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::GithubPullRequests::GithubUserRepresenter do +RSpec.describe API::V3::GithubPullRequests::GithubUserRepresenter do include API::V3::Utilities::PathHelper subject(:generated) { representer.to_json } diff --git a/modules/github_integration/spec/lib/open_project/github_integration/hook_handler_integration_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/hook_handler_integration_spec.rb index 742afc81f10..3642299005f 100644 --- a/modules/github_integration/spec/lib/open_project/github_integration/hook_handler_integration_spec.rb +++ b/modules/github_integration/spec/lib/open_project/github_integration/hook_handler_integration_spec.rb @@ -28,7 +28,7 @@ require File.expand_path('../../../spec_helper', __dir__) -describe OpenProject::GithubIntegration::HookHandler do +RSpec.describe OpenProject::GithubIntegration::HookHandler do subject(:process_webhook) do described_class.new .tap { journal_counts_before } diff --git a/modules/github_integration/spec/lib/open_project/github_integration/hook_handler_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/hook_handler_spec.rb index dbf20866dfb..cf9885a5bfd 100644 --- a/modules/github_integration/spec/lib/open_project/github_integration/hook_handler_spec.rb +++ b/modules/github_integration/spec/lib/open_project/github_integration/hook_handler_spec.rb @@ -28,7 +28,7 @@ require File.expand_path('../../../spec_helper', __dir__) -describe OpenProject::GithubIntegration::HookHandler do +RSpec.describe OpenProject::GithubIntegration::HookHandler do describe '#process' do let(:handler) { described_class.new } let(:hook) { 'fake hook' } diff --git a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/check_run_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/check_run_spec.rb index 34d13951f8b..4815082b6d9 100644 --- a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/check_run_spec.rb +++ b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/check_run_spec.rb @@ -28,7 +28,7 @@ require File.expand_path('../../../../spec_helper', __dir__) -describe OpenProject::GithubIntegration::NotificationHandler::CheckRun do +RSpec.describe OpenProject::GithubIntegration::NotificationHandler::CheckRun do subject(:process) { described_class.new.process(payload) } let(:upsert_check_run_service) do diff --git a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/helper_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/helper_spec.rb index ce49e5ff7fd..73f17c8e942 100644 --- a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/helper_spec.rb +++ b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/helper_spec.rb @@ -28,7 +28,7 @@ require File.expand_path('../../../../spec_helper', __dir__) -describe OpenProject::GithubIntegration::NotificationHandler::Helper do +RSpec.describe OpenProject::GithubIntegration::NotificationHandler::Helper do subject(:handler) { Class.new.include(described_class).new } before do diff --git a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/issue_comment_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/issue_comment_spec.rb index cca26a3a596..e9da0b94bf3 100644 --- a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/issue_comment_spec.rb +++ b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/issue_comment_spec.rb @@ -28,7 +28,7 @@ require File.expand_path('../../../../spec_helper', __dir__) -describe OpenProject::GithubIntegration::NotificationHandler::IssueComment do +RSpec.describe OpenProject::GithubIntegration::NotificationHandler::IssueComment do subject(:process) { handler_instance.process(payload) } let(:handler_instance) { described_class.new } diff --git a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/pull_request_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/pull_request_spec.rb index 7e1cec1a5ad..5d18abb143b 100644 --- a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/pull_request_spec.rb +++ b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler/pull_request_spec.rb @@ -28,7 +28,7 @@ require File.expand_path('../../../../spec_helper', __dir__) -describe OpenProject::GithubIntegration::NotificationHandler::PullRequest do +RSpec.describe OpenProject::GithubIntegration::NotificationHandler::PullRequest do subject(:process) { handler_instance.process(payload) } let(:handler_instance) { described_class.new } diff --git a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler_spec.rb index f4aa6141d05..effc85ff833 100644 --- a/modules/github_integration/spec/lib/open_project/github_integration/notification_handler_spec.rb +++ b/modules/github_integration/spec/lib/open_project/github_integration/notification_handler_spec.rb @@ -28,7 +28,7 @@ require File.expand_path('../../../spec_helper', __dir__) -describe OpenProject::GithubIntegration::NotificationHandler do +RSpec.describe OpenProject::GithubIntegration::NotificationHandler do let(:payload) { {} } shared_examples_for 'a notification handler' do diff --git a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_check_run_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_check_run_spec.rb index b8f7344e7b5..5f9c6a0cad1 100644 --- a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_check_run_spec.rb +++ b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_check_run_spec.rb @@ -28,7 +28,7 @@ require File.expand_path('../../../../spec_helper', __dir__) -describe OpenProject::GithubIntegration::Services::UpsertCheckRun do +RSpec.describe OpenProject::GithubIntegration::Services::UpsertCheckRun do subject(:upsert) { described_class.new.call(params, pull_request: github_pull_request) } let(:github_pull_request) { create(:github_pull_request) } diff --git a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_github_user_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_github_user_spec.rb index bf35f6d6754..7542197c6e2 100644 --- a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_github_user_spec.rb +++ b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_github_user_spec.rb @@ -28,7 +28,7 @@ require File.expand_path('../../../../spec_helper', __dir__) -describe OpenProject::GithubIntegration::Services::UpsertGithubUser do +RSpec.describe OpenProject::GithubIntegration::Services::UpsertGithubUser do subject(:upsert) { described_class.new.call(params) } let(:params) do diff --git a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_partial_pull_request_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_partial_pull_request_spec.rb index 70cbc1d6dbd..a1d89f8b54c 100644 --- a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_partial_pull_request_spec.rb +++ b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_partial_pull_request_spec.rb @@ -28,7 +28,7 @@ require File.expand_path('../../../../spec_helper', __dir__) -describe OpenProject::GithubIntegration::Services::UpsertPartialPullRequest do +RSpec.describe OpenProject::GithubIntegration::Services::UpsertPartialPullRequest do subject(:upsert) do described_class.new.call(OpenProject::GithubIntegration::NotificationHandler::Helper::Payload.new(payload), work_packages:) diff --git a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_pull_request_spec.rb b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_pull_request_spec.rb index 762827a04c2..f3a6047c72b 100644 --- a/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_pull_request_spec.rb +++ b/modules/github_integration/spec/lib/open_project/github_integration/services/upsert_pull_request_spec.rb @@ -28,7 +28,7 @@ require File.expand_path('../../../../spec_helper', __dir__) -describe OpenProject::GithubIntegration::Services::UpsertPullRequest do +RSpec.describe OpenProject::GithubIntegration::Services::UpsertPullRequest do subject(:upsert) { described_class.new.call(params, work_packages:) } let(:params) do diff --git a/modules/github_integration/spec/models/github_check_run_spec.rb b/modules/github_integration/spec/models/github_check_run_spec.rb index 6e749295d40..8d96ccaec4f 100644 --- a/modules/github_integration/spec/models/github_check_run_spec.rb +++ b/modules/github_integration/spec/models/github_check_run_spec.rb @@ -27,7 +27,7 @@ #++ require "#{File.dirname(__FILE__)}/../spec_helper" -describe GithubCheckRun do +RSpec.describe GithubCheckRun do describe "validations" do it { is_expected.to validate_presence_of :github_app_owner_avatar_url } it { is_expected.to validate_presence_of :github_html_url } diff --git a/modules/github_integration/spec/models/github_pull_request_spec.rb b/modules/github_integration/spec/models/github_pull_request_spec.rb index 230557d5b35..8ce395da6f6 100644 --- a/modules/github_integration/spec/models/github_pull_request_spec.rb +++ b/modules/github_integration/spec/models/github_pull_request_spec.rb @@ -27,7 +27,7 @@ #++ require "#{File.dirname(__FILE__)}/../spec_helper" -describe GithubPullRequest do +RSpec.describe GithubPullRequest do describe "validations" do it { is_expected.to validate_presence_of :github_html_url } it { is_expected.to validate_presence_of :number } diff --git a/modules/github_integration/spec/models/github_user_spec.rb b/modules/github_integration/spec/models/github_user_spec.rb index 13d3c690e58..8b041e15dff 100644 --- a/modules/github_integration/spec/models/github_user_spec.rb +++ b/modules/github_integration/spec/models/github_user_spec.rb @@ -27,7 +27,7 @@ #++ require "#{File.dirname(__FILE__)}/../spec_helper" -describe GithubUser do +RSpec.describe GithubUser do describe "validations" do it { is_expected.to validate_presence_of :github_id } it { is_expected.to validate_presence_of :github_login } diff --git a/modules/github_integration/spec/workers/cron/clear_old_pull_requests_job_spec.rb b/modules/github_integration/spec/workers/cron/clear_old_pull_requests_job_spec.rb index 76afd3b6272..5a512a4139f 100644 --- a/modules/github_integration/spec/workers/cron/clear_old_pull_requests_job_spec.rb +++ b/modules/github_integration/spec/workers/cron/clear_old_pull_requests_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Cron::ClearOldPullRequestsJob, type: :job do +RSpec.describe Cron::ClearOldPullRequestsJob, type: :job do let(:pull_request_without_work_package) do create(:github_pull_request, work_packages: []) end diff --git a/modules/grids/spec/contracts/grids/create_contract_spec.rb b/modules/grids/spec/contracts/grids/create_contract_spec.rb index ce0a476cc93..24fe7781068 100644 --- a/modules/grids/spec/contracts/grids/create_contract_spec.rb +++ b/modules/grids/spec/contracts/grids/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_examples' -describe Grids::CreateContract do +RSpec.describe Grids::CreateContract do include_context 'grid contract' include_context 'model contract' diff --git a/modules/grids/spec/contracts/grids/delete_contract_spec.rb b/modules/grids/spec/contracts/grids/delete_contract_spec.rb index fe9fa0ea41e..cb8cb98bb91 100644 --- a/modules/grids/spec/contracts/grids/delete_contract_spec.rb +++ b/modules/grids/spec/contracts/grids/delete_contract_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Grids::DeleteContract do +RSpec.describe Grids::DeleteContract do let(:user) { build_stubbed(:user) } let(:grid) do build_stubbed(:grid) diff --git a/modules/grids/spec/contracts/grids/shared_examples.rb b/modules/grids/spec/contracts/grids/shared_examples.rb index cfc72caae8d..c7437da65cf 100644 --- a/modules/grids/spec/contracts/grids/shared_examples.rb +++ b/modules/grids/spec/contracts/grids/shared_examples.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_context 'grid contract' do +RSpec.shared_context 'grid contract' do let(:user) { build_stubbed(:user) } let(:instance) { described_class.new(grid, user) } let(:widgets) { [] } @@ -66,7 +66,7 @@ shared_context 'grid contract' do end end -shared_examples_for 'shared grid contract attributes' do +RSpec.shared_examples_for 'shared grid contract attributes' do include_context 'model contract' let(:model) { grid } diff --git a/modules/grids/spec/contracts/grids/update_contract_spec.rb b/modules/grids/spec/contracts/grids/update_contract_spec.rb index 08c88f66579..117b7e035bd 100644 --- a/modules/grids/spec/contracts/grids/update_contract_spec.rb +++ b/modules/grids/spec/contracts/grids/update_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_examples' -describe Grids::UpdateContract do +RSpec.describe Grids::UpdateContract do include_context 'model contract' include_context 'grid contract' diff --git a/modules/grids/spec/lib/api/v3/grids/grid_payload_representer_parsing_spec.rb b/modules/grids/spec/lib/api/v3/grids/grid_payload_representer_parsing_spec.rb index ecf6333a55e..3d0de89b585 100644 --- a/modules/grids/spec/lib/api/v3/grids/grid_payload_representer_parsing_spec.rb +++ b/modules/grids/spec/lib/api/v3/grids/grid_payload_representer_parsing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Grids::GridPayloadRepresenter, 'parsing' do +RSpec.describe API::V3::Grids::GridPayloadRepresenter, 'parsing' do include API::V3::Utilities::PathHelper let(:object) do diff --git a/modules/grids/spec/lib/api/v3/grids/grid_representer_rendering_spec.rb b/modules/grids/spec/lib/api/v3/grids/grid_representer_rendering_spec.rb index d30c3ec60de..35b81dfeefc 100644 --- a/modules/grids/spec/lib/api/v3/grids/grid_representer_rendering_spec.rb +++ b/modules/grids/spec/lib/api/v3/grids/grid_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Grids::GridRepresenter, 'rendering' do +RSpec.describe API::V3::Grids::GridRepresenter, 'rendering' do include OpenProject::StaticRouting::UrlHelpers include API::V3::Utilities::PathHelper diff --git a/modules/grids/spec/lib/api/v3/grids/schemas/grid_schema_representer_spec.rb b/modules/grids/spec/lib/api/v3/grids/schemas/grid_schema_representer_spec.rb index 8b3a979b5ec..a23b5661963 100644 --- a/modules/grids/spec/lib/api/v3/grids/schemas/grid_schema_representer_spec.rb +++ b/modules/grids/spec/lib/api/v3/grids/schemas/grid_schema_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Grids::Schemas::GridSchemaRepresenter do +RSpec.describe API::V3::Grids::Schemas::GridSchemaRepresenter do include API::V3::Utilities::PathHelper let(:current_user) { build_stubbed(:user) } diff --git a/modules/grids/spec/lib/api/v3/utilities/file_helper_spec.rb b/modules/grids/spec/lib/api/v3/utilities/file_helper_spec.rb index 48926fe4662..de523eb4fbf 100644 --- a/modules/grids/spec/lib/api/v3/utilities/file_helper_spec.rb +++ b/modules/grids/spec/lib/api/v3/utilities/file_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Utilities::PathHelper do +RSpec.describe API::V3::Utilities::PathHelper do let(:helper) { Class.new.tap { |c| c.extend(API::V3::Utilities::PathHelper) }.api_v3_paths } context 'attachments paths' do diff --git a/modules/grids/spec/models/grids/grid_spec.rb b/modules/grids/spec/models/grids/grid_spec.rb index 115ac9b798f..4e5ec6cde5a 100644 --- a/modules/grids/spec/models/grids/grid_spec.rb +++ b/modules/grids/spec/models/grids/grid_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_model' -describe Grids::Grid do +RSpec.describe Grids::Grid do let(:instance) { Grids::Grid.new column_count: 5, row_count: 5 } it_behaves_like 'grid attributes' diff --git a/modules/grids/spec/models/grids/shared_model.rb b/modules/grids/spec/models/grids/shared_model.rb index c149f2d0b7a..69a5e47fb21 100644 --- a/modules/grids/spec/models/grids/shared_model.rb +++ b/modules/grids/spec/models/grids/shared_model.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_examples_for 'grid attributes' do +RSpec.shared_examples_for 'grid attributes' do describe 'attributes' do it '#row_count' do instance.row_count = 5 diff --git a/modules/grids/spec/models/grids/widget_spec.rb b/modules/grids/spec/models/grids/widget_spec.rb index 14cc2e1f5ee..dc980b48106 100644 --- a/modules/grids/spec/models/grids/widget_spec.rb +++ b/modules/grids/spec/models/grids/widget_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Grids::Widget do +RSpec.describe Grids::Widget do let(:instance) { Grids::Widget.new } describe 'attributes' do diff --git a/modules/grids/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb b/modules/grids/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb index 33379639cc8..1a32b77a127 100644 --- a/modules/grids/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb +++ b/modules/grids/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe "POST /api/v3/grids/form", content_type: :json do +RSpec.describe "POST /api/v3/grids/form", content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/grids/spec/requests/api/v3/grids/grids_resource_spec.rb b/modules/grids/spec/requests/api/v3/grids/grids_resource_spec.rb index 5b49dc89e18..a405906e81d 100644 --- a/modules/grids/spec/requests/api/v3/grids/grids_resource_spec.rb +++ b/modules/grids/spec/requests/api/v3/grids/grids_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Grids resource', content_type: :json do +RSpec.describe 'API v3 Grids resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/grids/spec/requests/api/v3/grids/grids_schema_resource_spec.rb b/modules/grids/spec/requests/api/v3/grids/grids_schema_resource_spec.rb index cf377d97268..32614d138ce 100644 --- a/modules/grids/spec/requests/api/v3/grids/grids_schema_resource_spec.rb +++ b/modules/grids/spec/requests/api/v3/grids/grids_schema_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Grids schema resource', content_type: :json do +RSpec.describe 'API v3 Grids schema resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/grids/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb b/modules/grids/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb index baf03b9c627..8c3ddb79030 100644 --- a/modules/grids/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb +++ b/modules/grids/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe "PATCH /api/v3/grids/:id/form", content_type: :json do +RSpec.describe "PATCH /api/v3/grids/:id/form", content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/grids/spec/services/grids/create_service_spec.rb b/modules/grids/spec/services/grids/create_service_spec.rb index 2dd4315da83..2f8f87ad82b 100644 --- a/modules/grids/spec/services/grids/create_service_spec.rb +++ b/modules/grids/spec/services/grids/create_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Grids::CreateService, type: :model do +RSpec.describe Grids::CreateService, type: :model do it_behaves_like 'BaseServices create service' do let(:model_class) { Grids::Grid } end diff --git a/modules/grids/spec/services/grids/set_attributes_service_spec.rb b/modules/grids/spec/services/grids/set_attributes_service_spec.rb index 9b30b432ae4..38e4415f877 100644 --- a/modules/grids/spec/services/grids/set_attributes_service_spec.rb +++ b/modules/grids/spec/services/grids/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Grids::SetAttributesService, type: :model do +RSpec.describe Grids::SetAttributesService, type: :model do let(:user) { build_stubbed(:user) } let(:contract_class) do contract = double('contract_class') diff --git a/modules/grids/spec/services/grids/update_service_spec.rb b/modules/grids/spec/services/grids/update_service_spec.rb index 69cf1f9a492..f0c8bbdc9f8 100644 --- a/modules/grids/spec/services/grids/update_service_spec.rb +++ b/modules/grids/spec/services/grids/update_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Grids::UpdateService, type: :model do +RSpec.describe Grids::UpdateService, type: :model do let(:user) { build_stubbed(:user) } let(:contract_class) do double('contract_class', '<=': true) diff --git a/modules/job_status/spec/features/job_status_spec.rb b/modules/job_status/spec/features/job_status_spec.rb index 1e5c78fb418..d44b98eefcb 100644 --- a/modules/job_status/spec/features/job_status_spec.rb +++ b/modules/job_status/spec/features/job_status_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Job status', js: true do +RSpec.describe 'Job status', js: true do shared_let(:admin) { create(:admin) } before do diff --git a/modules/job_status/spec/services/documents/create_service_spec.rb b/modules/job_status/spec/services/documents/create_service_spec.rb index cd6172b6fce..f2c55384923 100644 --- a/modules/job_status/spec/services/documents/create_service_spec.rb +++ b/modules/job_status/spec/services/documents/create_service_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Documents::CreateService, type: :model do +RSpec.describe Documents::CreateService, type: :model do it_behaves_like 'BaseServices create service' end diff --git a/modules/job_status/spec/services/documents/update_service_spec.rb b/modules/job_status/spec/services/documents/update_service_spec.rb index 399b5231c80..4b22b2fa783 100644 --- a/modules/job_status/spec/services/documents/update_service_spec.rb +++ b/modules/job_status/spec/services/documents/update_service_spec.rb @@ -29,6 +29,6 @@ require 'spec_helper' require 'services/base_services/behaves_like_update_service' -describe Documents::UpdateService, type: :model do +RSpec.describe Documents::UpdateService, type: :model do it_behaves_like 'BaseServices update service' end diff --git a/modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb b/modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb index 3ba4e60ed3f..edfb6063b6b 100644 --- a/modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb +++ b/modules/ldap_groups/spec/controllers/synchronized_groups_controller_spec.rb @@ -1,6 +1,6 @@ require_relative '../spec_helper' -describe LdapGroups::SynchronizedGroupsController, with_ee: %i[ldap_groups] do +RSpec.describe LdapGroups::SynchronizedGroupsController, with_ee: %i[ldap_groups] do let(:user) { create(:user) } let(:admin) { create(:admin) } diff --git a/modules/ldap_groups/spec/features/administration_spec.rb b/modules/ldap_groups/spec/features/administration_spec.rb index 8a70f572ecc..cb78c8b751a 100644 --- a/modules/ldap_groups/spec/features/administration_spec.rb +++ b/modules/ldap_groups/spec/features/administration_spec.rb @@ -1,6 +1,6 @@ require_relative '../spec_helper' -describe 'LDAP group sync administration spec', js: true do +RSpec.describe 'LDAP group sync administration spec', js: true do let(:admin) { create(:admin) } before do diff --git a/modules/ldap_groups/spec/models/membership_spec.rb b/modules/ldap_groups/spec/models/membership_spec.rb index b8ac38029fc..5a75336299d 100644 --- a/modules/ldap_groups/spec/models/membership_spec.rb +++ b/modules/ldap_groups/spec/models/membership_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe LdapGroups::Membership do +RSpec.describe LdapGroups::Membership do describe 'destroy' do let(:synchronized_group) { create(:ldap_synchronized_group, group:) } let(:group) { create(:group) } diff --git a/modules/ldap_groups/spec/models/synchronized_filter_spec.rb b/modules/ldap_groups/spec/models/synchronized_filter_spec.rb index 347d3ead1c4..7dead83d118 100644 --- a/modules/ldap_groups/spec/models/synchronized_filter_spec.rb +++ b/modules/ldap_groups/spec/models/synchronized_filter_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe LdapGroups::SynchronizedFilter do +RSpec.describe LdapGroups::SynchronizedFilter do describe '#used_base_dn' do let(:auth_source) { build(:ldap_auth_source, base_dn: 'dc=example,dc=com') } let(:filter) { build(:ldap_synchronized_filter, auth_source:) } diff --git a/modules/ldap_groups/spec/models/synchronized_group_spec.rb b/modules/ldap_groups/spec/models/synchronized_group_spec.rb index c9a82811e48..d9475dde697 100644 --- a/modules/ldap_groups/spec/models/synchronized_group_spec.rb +++ b/modules/ldap_groups/spec/models/synchronized_group_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe LdapGroups::SynchronizedGroup do +RSpec.describe LdapGroups::SynchronizedGroup do describe 'validations' do subject { build(:ldap_synchronized_group) } diff --git a/modules/ldap_groups/spec/services/synchronization_spec.rb b/modules/ldap_groups/spec/services/synchronization_spec.rb index a53eb75c32c..32684166d4c 100644 --- a/modules/ldap_groups/spec/services/synchronization_spec.rb +++ b/modules/ldap_groups/spec/services/synchronization_spec.rb @@ -1,7 +1,7 @@ require File.dirname(__FILE__) + '/../spec_helper' require 'ladle' -describe LdapGroups::SynchronizeGroupsService, with_ee: %i[ldap_groups] do +RSpec.describe LdapGroups::SynchronizeGroupsService, with_ee: %i[ldap_groups] do include_context 'with temporary LDAP' let(:plugin_settings) do diff --git a/modules/ldap_groups/spec/services/synchronize_filter_spec.rb b/modules/ldap_groups/spec/services/synchronize_filter_spec.rb index ebdaadfe023..07a7156ae1e 100644 --- a/modules/ldap_groups/spec/services/synchronize_filter_spec.rb +++ b/modules/ldap_groups/spec/services/synchronize_filter_spec.rb @@ -1,7 +1,7 @@ require File.dirname(__FILE__) + '/../spec_helper' require 'ladle' -describe LdapGroups::SynchronizeFilterService, with_ee: %i[ldap_groups] do +RSpec.describe LdapGroups::SynchronizeFilterService, with_ee: %i[ldap_groups] do before(:all) do ldif = Rails.root.join('spec/fixtures/ldap/users.ldif') @ldap_server = Ladle::Server.new(quiet: false, port: ParallelHelper.port_for_ldap.to_s, domain: 'dc=example,dc=com', diff --git a/modules/meeting/spec/contracts/meeting_contents/update_contract_spec.rb b/modules/meeting/spec/contracts/meeting_contents/update_contract_spec.rb index 8f9dae2093a..d7be2b29233 100644 --- a/modules/meeting/spec/contracts/meeting_contents/update_contract_spec.rb +++ b/modules/meeting/spec/contracts/meeting_contents/update_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe MeetingContents::UpdateContract do +RSpec.describe MeetingContents::UpdateContract do include_context 'ModelContract shared context' let(:agenda) { build_stubbed(:meeting_agenda) } let(:current_user) { build_stubbed(:user) } diff --git a/modules/meeting/spec/controllers/meeting_contents_controller_spec.rb b/modules/meeting/spec/controllers/meeting_contents_controller_spec.rb index 862318a6863..664c35a09aa 100644 --- a/modules/meeting/spec/controllers/meeting_contents_controller_spec.rb +++ b/modules/meeting/spec/controllers/meeting_contents_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe MeetingContentsController do +RSpec.describe MeetingContentsController do shared_let(:role) { create(:role, permissions: [:view_meetings]) } shared_let(:project) { create(:project) } shared_let(:author) { create(:user, member_in_project: project, member_through_role: role) } diff --git a/modules/meeting/spec/controllers/meetings_controller_spec.rb b/modules/meeting/spec/controllers/meetings_controller_spec.rb index 3a9e3a3e9ab..e08f617abe8 100644 --- a/modules/meeting/spec/controllers/meetings_controller_spec.rb +++ b/modules/meeting/spec/controllers/meetings_controller_spec.rb @@ -28,7 +28,7 @@ require "#{File.dirname(__FILE__)}/../spec_helper" -describe MeetingsController do +RSpec.describe MeetingsController do let(:user) { create(:admin) } let(:project) { create(:project) } let(:other_project) { create(:project) } diff --git a/modules/meeting/spec/features/meetings_activity_spec.rb b/modules/meeting/spec/features/meetings_activity_spec.rb index d054b57c53a..c1bcd4d1f80 100644 --- a/modules/meeting/spec/features/meetings_activity_spec.rb +++ b/modules/meeting/spec/features/meetings_activity_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Meetings', js: true do +RSpec.describe 'Meetings', js: true do let(:project) { create(:project, enabled_module_names: %w[meetings activity]) } let(:user) { create(:admin) } diff --git a/modules/meeting/spec/features/meetings_attachments_spec.rb b/modules/meeting/spec/features/meetings_attachments_spec.rb index c3625d68a90..adb5cfb995d 100644 --- a/modules/meeting/spec/features/meetings_attachments_spec.rb +++ b/modules/meeting/spec/features/meetings_attachments_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require 'features/page_objects/notification' -describe 'Add an attachment to a meeting (agenda)', js: true do +RSpec.describe 'Add an attachment to a meeting (agenda)', js: true do let(:role) do create(:role, permissions: %i[view_meetings edit_meetings create_meeting_agendas]) end diff --git a/modules/meeting/spec/features/meetings_close_spec.rb b/modules/meeting/spec/features/meetings_close_spec.rb index b33bc265c20..2e09039bdd6 100644 --- a/modules/meeting/spec/features/meetings_close_spec.rb +++ b/modules/meeting/spec/features/meetings_close_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Meetings close' do +RSpec.describe 'Meetings close' do let(:project) { create(:project, enabled_module_names: %w[meetings]) } let(:user) do create(:user, diff --git a/modules/meeting/spec/features/meetings_copy_spec.rb b/modules/meeting/spec/features/meetings_copy_spec.rb index 99474556023..514a5a6157a 100644 --- a/modules/meeting/spec/features/meetings_copy_spec.rb +++ b/modules/meeting/spec/features/meetings_copy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Meetings copy', js: true do +RSpec.describe 'Meetings copy', js: true do let(:project) { create(:project, enabled_module_names: %w[meetings]) } let(:user) do create(:user, diff --git a/modules/meeting/spec/features/meetings_delete_spec.rb b/modules/meeting/spec/features/meetings_delete_spec.rb index 43fc4620bed..fd079e69f59 100644 --- a/modules/meeting/spec/features/meetings_delete_spec.rb +++ b/modules/meeting/spec/features/meetings_delete_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Meetings deletion' do +RSpec.describe 'Meetings deletion' do let(:project) { create(:project, enabled_module_names: %w[meetings]) } let(:user) do create(:user, diff --git a/modules/meeting/spec/features/meetings_index_spec.rb b/modules/meeting/spec/features/meetings_index_spec.rb index a7c0276707c..f2ba4630234 100644 --- a/modules/meeting/spec/features/meetings_index_spec.rb +++ b/modules/meeting/spec/features/meetings_index_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/meetings/index' -describe 'Meetings' do +RSpec.describe 'Meetings' do let(:project) { create(:project, enabled_module_names: %w[meetings]) } let(:other_project) { create(:project, enabled_module_names: %w[meetings]) } let(:role) { create(:role, permissions:) } diff --git a/modules/meeting/spec/features/meetings_locking_spec.rb b/modules/meeting/spec/features/meetings_locking_spec.rb index 44ace8e5866..4d8e70e21bf 100644 --- a/modules/meeting/spec/features/meetings_locking_spec.rb +++ b/modules/meeting/spec/features/meetings_locking_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Meetings locking', js: true do +RSpec.describe 'Meetings locking', js: true do let(:project) { create(:project, enabled_module_names: %w[meetings]) } let(:user) { create(:admin) } let!(:meeting) { create(:meeting) } diff --git a/modules/meeting/spec/features/meetings_new_spec.rb b/modules/meeting/spec/features/meetings_new_spec.rb index 8c6c3d194ad..103d2a07bfb 100644 --- a/modules/meeting/spec/features/meetings_new_spec.rb +++ b/modules/meeting/spec/features/meetings_new_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/meetings/index' -describe 'Meetings new', js: true do +RSpec.describe 'Meetings new', js: true do let(:project) { create(:project, enabled_module_names: %w[meetings]) } let(:index_page) { Pages::Meetings::Index.new(project:) } let(:time_zone) { 'utc' } diff --git a/modules/meeting/spec/features/meetings_participants_spec.rb b/modules/meeting/spec/features/meetings_participants_spec.rb index 1eb563cfbc1..c401ab50034 100644 --- a/modules/meeting/spec/features/meetings_participants_spec.rb +++ b/modules/meeting/spec/features/meetings_participants_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/meetings/edit' -describe 'Meetings participants' do +RSpec.describe 'Meetings participants' do let(:project) { create(:project, enabled_module_names: %w[meetings]) } let!(:user) do create(:user, diff --git a/modules/meeting/spec/features/meetings_search_spec.rb b/modules/meeting/spec/features/meetings_search_spec.rb index 4e6ce9af7a4..ea4fde75439 100644 --- a/modules/meeting/spec/features/meetings_search_spec.rb +++ b/modules/meeting/spec/features/meetings_search_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Meeting search', js: true do +RSpec.describe 'Meeting search', js: true do include Components::Autocompleter::NgSelectAutocompleteHelpers let(:project) { create(:project) } let(:user) { create(:user, member_in_project: project, member_through_role: role) } diff --git a/modules/meeting/spec/features/meetings_show_spec.rb b/modules/meeting/spec/features/meetings_show_spec.rb index a917ed4d4ea..e6550372546 100644 --- a/modules/meeting/spec/features/meetings_show_spec.rb +++ b/modules/meeting/spec/features/meetings_show_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Meetings', js: true do +RSpec.describe 'Meetings', js: true do let(:project) { create(:project, enabled_module_names: %w[meetings]) } let(:role) { create(:role, permissions:) } let(:user) do diff --git a/modules/meeting/spec/lib/open_project/markdown_formatting_spec.rb b/modules/meeting/spec/lib/open_project/markdown_formatting_spec.rb index 42660914632..a2901448de8 100644 --- a/modules/meeting/spec/lib/open_project/markdown_formatting_spec.rb +++ b/modules/meeting/spec/lib/open_project/markdown_formatting_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe OpenProject::TextFormatting, - 'Meeting links' do +RSpec.describe OpenProject::TextFormatting, + 'Meeting links' do include ActionView::Helpers::UrlHelper # soft-dependency include ActionView::Context include OpenProject::StaticRouting::UrlHelpers diff --git a/modules/meeting/spec/lib/open_project/meeting/default_data_spec.rb b/modules/meeting/spec/lib/open_project/meeting/default_data_spec.rb index 76a449ee76b..0433bf2cc59 100644 --- a/modules/meeting/spec/lib/open_project/meeting/default_data_spec.rb +++ b/modules/meeting/spec/lib/open_project/meeting/default_data_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::Meeting::DefaultData, with_clean_fixture: true do +RSpec.describe OpenProject::Meeting::DefaultData, with_clean_fixture: true do let(:seeder) { BasicData::RoleSeeder.new } let(:roles) { [member, reader] } diff --git a/modules/meeting/spec/mailers/meeting_mailer_spec.rb b/modules/meeting/spec/mailers/meeting_mailer_spec.rb index 5fb790ba6b2..3e0b1cfd408 100644 --- a/modules/meeting/spec/mailers/meeting_mailer_spec.rb +++ b/modules/meeting/spec/mailers/meeting_mailer_spec.rb @@ -28,7 +28,7 @@ require_relative '../spec_helper' -describe MeetingMailer do +RSpec.describe MeetingMailer do shared_let(:role) { create(:role, permissions: [:view_meetings]) } shared_let(:project) { create(:project, name: 'My project') } shared_let(:author) do diff --git a/modules/meeting/spec/models/meeting_agenda_spec.rb b/modules/meeting/spec/models/meeting_agenda_spec.rb index 42fa43c736d..e7ebf00a7dd 100644 --- a/modules/meeting/spec/models/meeting_agenda_spec.rb +++ b/modules/meeting/spec/models/meeting_agenda_spec.rb @@ -28,7 +28,7 @@ require File.dirname(__FILE__) + '/../spec_helper' -describe 'MeetingAgenda' do +RSpec.describe 'MeetingAgenda' do before do @a = build(:meeting_agenda, text: "Some content...\n\nMore content!\n\nExtraordinary content!!") end diff --git a/modules/meeting/spec/models/meeting_minutes_spec.rb b/modules/meeting/spec/models/meeting_minutes_spec.rb index 0dc3b80390e..496192a8235 100644 --- a/modules/meeting/spec/models/meeting_minutes_spec.rb +++ b/modules/meeting/spec/models/meeting_minutes_spec.rb @@ -28,7 +28,7 @@ require File.dirname(__FILE__) + '/../spec_helper' -describe 'MeetingMinutes' do +RSpec.describe 'MeetingMinutes' do before do @min = build(:meeting_minutes) end diff --git a/modules/meeting/spec/models/meeting_spec.rb b/modules/meeting/spec/models/meeting_spec.rb index b0e0f9bd851..bc05fa7df5b 100644 --- a/modules/meeting/spec/models/meeting_spec.rb +++ b/modules/meeting/spec/models/meeting_spec.rb @@ -28,7 +28,7 @@ require File.dirname(__FILE__) + '/../spec_helper' -describe Meeting do +RSpec.describe Meeting do shared_let (:user1) { create(:user) } shared_let (:user2) { create(:user) } let(:project) { create(:project, members: project_members) } diff --git a/modules/meeting/spec/models/permitted_params_spec.rb b/modules/meeting/spec/models/permitted_params_spec.rb index e03241bc59c..04c570668b9 100644 --- a/modules/meeting/spec/models/permitted_params_spec.rb +++ b/modules/meeting/spec/models/permitted_params_spec.rb @@ -28,7 +28,7 @@ require File.dirname(__FILE__) + '/../spec_helper' -describe PermittedParams do +RSpec.describe PermittedParams do let(:user) { build_stubbed(:user) } describe '#search' do diff --git a/modules/meeting/spec/models/project/activity_spec.rb b/modules/meeting/spec/models/project/activity_spec.rb index 481a625ace1..7bb800de09c 100644 --- a/modules/meeting/spec/models/project/activity_spec.rb +++ b/modules/meeting/spec/models/project/activity_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::Activity, 'meeting' do +RSpec.describe Projects::Activity, 'meeting' do shared_let(:project) do create(:project, :updated_a_long_time_ago) end diff --git a/modules/meeting/spec/requests/api/v3/attachments/meeting_agenda_spec.rb b/modules/meeting/spec/requests/api/v3/attachments/meeting_agenda_spec.rb index 2adb3988a16..f4f80c2b4fd 100644 --- a/modules/meeting/spec/requests/api/v3/attachments/meeting_agenda_spec.rb +++ b/modules/meeting/spec/requests/api/v3/attachments/meeting_agenda_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'requests/api/v3/attachments/attachment_resource_shared_examples' -describe "meeting agenda attachments" do +RSpec.describe "meeting agenda attachments" do it_behaves_like "an APIv3 attachment resource" do let(:attachment_type) { :meeting_content } diff --git a/modules/meeting/spec/requests/api/v3/attachments/meeting_minutes_spec.rb b/modules/meeting/spec/requests/api/v3/attachments/meeting_minutes_spec.rb index 1a27670ff80..7989ea9f811 100644 --- a/modules/meeting/spec/requests/api/v3/attachments/meeting_minutes_spec.rb +++ b/modules/meeting/spec/requests/api/v3/attachments/meeting_minutes_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'requests/api/v3/attachments/attachment_resource_shared_examples' -describe "meeting minutes attachments" do +RSpec.describe "meeting minutes attachments" do it_behaves_like "an APIv3 attachment resource" do let(:attachment_type) { :meeting_content } diff --git a/modules/meeting/spec/routing/previews_routing_spec.rb b/modules/meeting/spec/routing/previews_routing_spec.rb index c0fc52c4a2d..9006cbdefac 100644 --- a/modules/meeting/spec/routing/previews_routing_spec.rb +++ b/modules/meeting/spec/routing/previews_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'preview' do +RSpec.describe 'preview' do it 'connects POST /meetings/:meeting_id/agenda/preview to meeting_agendas#preview' do expect(post('/meetings/1/agenda/preview')).to route_to(controller: 'meeting_agendas', meeting_id: '1', diff --git a/modules/meeting/spec/services/meeting_contents/update_service_spec.rb b/modules/meeting/spec/services/meeting_contents/update_service_spec.rb index c712dc83860..504ab549165 100644 --- a/modules/meeting/spec/services/meeting_contents/update_service_spec.rb +++ b/modules/meeting/spec/services/meeting_contents/update_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_update_service' -describe MeetingContents::UpdateService, type: :model do +RSpec.describe MeetingContents::UpdateService, type: :model do it_behaves_like 'BaseServices update service' do let(:factory) { :meeting_agenda } end diff --git a/modules/my_page/spec/contracts/grids/create_contract_spec.rb b/modules/my_page/spec/contracts/grids/create_contract_spec.rb index cbc6a67a5e8..066c3f921c3 100644 --- a/modules/my_page/spec/contracts/grids/create_contract_spec.rb +++ b/modules/my_page/spec/contracts/grids/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_examples' -describe Grids::CreateContract do +RSpec.describe Grids::CreateContract do include_context 'grid contract' include_context 'model contract' diff --git a/modules/my_page/spec/contracts/grids/shared_examples.rb b/modules/my_page/spec/contracts/grids/shared_examples.rb index decbe5c8bbf..774ee2abc14 100644 --- a/modules/my_page/spec/contracts/grids/shared_examples.rb +++ b/modules/my_page/spec/contracts/grids/shared_examples.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_context 'grid contract' do +RSpec.shared_context 'grid contract' do let(:user) { build_stubbed(:user) } let(:instance) { described_class.new(grid, user) } let(:default_values) do @@ -41,7 +41,7 @@ shared_context 'grid contract' do end end -shared_examples_for 'shared grid contract attributes' do +RSpec.shared_examples_for 'shared grid contract attributes' do include_context 'model contract' let(:model) { grid } diff --git a/modules/my_page/spec/contracts/grids/update_contract_spec.rb b/modules/my_page/spec/contracts/grids/update_contract_spec.rb index 54cf39d78d6..ef0625f01f7 100644 --- a/modules/my_page/spec/contracts/grids/update_contract_spec.rb +++ b/modules/my_page/spec/contracts/grids/update_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_examples' -describe Grids::UpdateContract do +RSpec.describe Grids::UpdateContract do include_context 'model contract' include_context 'grid contract' diff --git a/modules/my_page/spec/features/my/accountable_spec.rb b/modules/my_page/spec/features/my/accountable_spec.rb index b729a6c3861..8819b2ba873 100644 --- a/modules/my_page/spec/features/my/accountable_spec.rb +++ b/modules/my_page/spec/features/my/accountable_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../../support/pages/my/page' -describe 'Accountable widget on my page', js: true do +RSpec.describe 'Accountable widget on my page', js: true do let!(:type) { create(:type) } let!(:priority) { create(:default_priority) } let!(:project) { create(:project, types: [type]) } diff --git a/modules/my_page/spec/features/my/assigned_to_me_spec.rb b/modules/my_page/spec/features/my/assigned_to_me_spec.rb index 62f5992ef0b..b1c95049726 100644 --- a/modules/my_page/spec/features/my/assigned_to_me_spec.rb +++ b/modules/my_page/spec/features/my/assigned_to_me_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../../support/pages/my/page' -describe 'Assigned to me embedded query on my page', js: true do +RSpec.describe 'Assigned to me embedded query on my page', js: true do let!(:type) { create(:type) } let!(:priority) { create(:default_priority) } let!(:project) { create(:project, types: [type]) } diff --git a/modules/my_page/spec/features/my/custom_text_spec.rb b/modules/my_page/spec/features/my/custom_text_spec.rb index 16bad40f86a..6aaa3cade00 100644 --- a/modules/my_page/spec/features/my/custom_text_spec.rb +++ b/modules/my_page/spec/features/my/custom_text_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../../support/pages/my/page' -describe 'Custom text widget on my page', js: true do +RSpec.describe 'Custom text widget on my page', js: true do let(:permissions) do [] end diff --git a/modules/my_page/spec/features/my/documents_spec.rb b/modules/my_page/spec/features/my/documents_spec.rb index f62474d66e9..c5a7ef66be8 100644 --- a/modules/my_page/spec/features/my/documents_spec.rb +++ b/modules/my_page/spec/features/my/documents_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../../support/pages/my/page' -describe 'My page documents widget', js: true do +RSpec.describe 'My page documents widget', js: true do let!(:project) { create(:project) } let!(:other_project) { create(:project) } let!(:visible_document) do diff --git a/modules/my_page/spec/features/my/my_page_spec.rb b/modules/my_page/spec/features/my/my_page_spec.rb index b56c6288345..af071502b81 100644 --- a/modules/my_page/spec/features/my/my_page_spec.rb +++ b/modules/my_page/spec/features/my/my_page_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../../support/pages/my/page' -describe 'My page', js: true do +RSpec.describe 'My page', js: true do let!(:type) { create(:type) } let!(:project) { create(:project, types: [type]) } let!(:open_status) { create(:default_status) } diff --git a/modules/my_page/spec/features/my/news_spec.rb b/modules/my_page/spec/features/my/news_spec.rb index b645ac11ca9..2f44d9c79b3 100644 --- a/modules/my_page/spec/features/my/news_spec.rb +++ b/modules/my_page/spec/features/my/news_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../../support/pages/my/page' -describe 'My page news widget spec', js: true do +RSpec.describe 'My page news widget spec', js: true do let!(:project) { create(:project) } let!(:other_project) { create(:project) } let!(:visible_news) do diff --git a/modules/my_page/spec/features/my/time_entries_current_user_spec.rb b/modules/my_page/spec/features/my/time_entries_current_user_spec.rb index 04e9fc87029..4b249412d1b 100644 --- a/modules/my_page/spec/features/my/time_entries_current_user_spec.rb +++ b/modules/my_page/spec/features/my/time_entries_current_user_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../../support/pages/my/page' -describe 'My page time entries current user widget spec', js: true, with_mail: false do +RSpec.describe 'My page time entries current user widget spec', js: true, with_mail: false do let!(:type) { create(:type) } let!(:project) { create(:project, types: [type]) } let!(:activity) { create(:time_entry_activity) } diff --git a/modules/my_page/spec/features/my/work_package_table_spec.rb b/modules/my_page/spec/features/my/work_package_table_spec.rb index 4e3f89bea1c..cff49d1feb4 100644 --- a/modules/my_page/spec/features/my/work_package_table_spec.rb +++ b/modules/my_page/spec/features/my/work_package_table_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../../support/pages/my/page' -describe 'Arbitrary WorkPackage query table widget on my page', js: true, with_mail: false do +RSpec.describe 'Arbitrary WorkPackage query table widget on my page', js: true, with_mail: false do let!(:type) { create(:type) } let!(:other_type) { create(:type) } let!(:priority) { create(:default_priority) } diff --git a/modules/my_page/spec/models/grids/my_page_spec.rb b/modules/my_page/spec/models/grids/my_page_spec.rb index ab8ce9cb19e..19ca30f8701 100644 --- a/modules/my_page/spec/models/grids/my_page_spec.rb +++ b/modules/my_page/spec/models/grids/my_page_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './shared_model' -describe Grids::MyPage do +RSpec.describe Grids::MyPage do let(:instance) { described_class.new(row_count: 5, column_count: 5) } let(:user) { build_stubbed(:user) } diff --git a/modules/my_page/spec/models/grids/shared_model.rb b/modules/my_page/spec/models/grids/shared_model.rb index 2bb9255afaf..a5a410a3f49 100644 --- a/modules/my_page/spec/models/grids/shared_model.rb +++ b/modules/my_page/spec/models/grids/shared_model.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_examples_for 'grid attributes' do +RSpec.shared_examples_for 'grid attributes' do describe 'attributes' do it '#row_count' do instance.row_count = 5 diff --git a/modules/my_page/spec/queries/grids/filters/scope_filter_spec.rb b/modules/my_page/spec/queries/grids/filters/scope_filter_spec.rb index 947052bfcc7..0df97537b8a 100644 --- a/modules/my_page/spec/queries/grids/filters/scope_filter_spec.rb +++ b/modules/my_page/spec/queries/grids/filters/scope_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Grids::Filters::ScopeFilter, type: :model do +RSpec.describe Grids::Filters::ScopeFilter, type: :model do include_context 'filter tests' let(:values) { ['/my/page'] } let(:user) { build_stubbed(:user) } diff --git a/modules/my_page/spec/queries/grids/query_integration_spec.rb b/modules/my_page/spec/queries/grids/query_integration_spec.rb index f6fcaadeda4..e385e2ff540 100644 --- a/modules/my_page/spec/queries/grids/query_integration_spec.rb +++ b/modules/my_page/spec/queries/grids/query_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Grids::Query, type: :model do +RSpec.describe Grids::Query, type: :model do let(:user) { create(:user) } let(:other_user) { create(:user) } let!(:my_page_grid) do diff --git a/modules/my_page/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb b/modules/my_page/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb index 95a7485390b..321a544ec98 100644 --- a/modules/my_page/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb +++ b/modules/my_page/spec/requests/api/v3/grids/grids_create_form_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe "POST /api/v3/grids/form", content_type: :json do +RSpec.describe "POST /api/v3/grids/form", content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/my_page/spec/requests/api/v3/grids/grids_resource_spec.rb b/modules/my_page/spec/requests/api/v3/grids/grids_resource_spec.rb index 0d81eafe88b..20ccf149278 100644 --- a/modules/my_page/spec/requests/api/v3/grids/grids_resource_spec.rb +++ b/modules/my_page/spec/requests/api/v3/grids/grids_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Grids resource', content_type: :json do +RSpec.describe 'API v3 Grids resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/my_page/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb b/modules/my_page/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb index cbef8e48130..48f7eb705b8 100644 --- a/modules/my_page/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb +++ b/modules/my_page/spec/requests/api/v3/grids/grids_update_form_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe "PATCH /api/v3/grids/:id/form", content_type: :json do +RSpec.describe "PATCH /api/v3/grids/:id/form", content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/openid_connect/spec/controllers/providers_controller_spec.rb b/modules/openid_connect/spec/controllers/providers_controller_spec.rb index 075c5a40573..1f3427f97d2 100644 --- a/modules/openid_connect/spec/controllers/providers_controller_spec.rb +++ b/modules/openid_connect/spec/controllers/providers_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenIDConnect::ProvidersController do +RSpec.describe OpenIDConnect::ProvidersController do let(:user) { build_stubbed(:admin) } let(:valid_params) do diff --git a/modules/openid_connect/spec/lib/session_mapper_spec.rb b/modules/openid_connect/spec/lib/session_mapper_spec.rb index 16f506dd7b0..89cf187bace 100644 --- a/modules/openid_connect/spec/lib/session_mapper_spec.rb +++ b/modules/openid_connect/spec/lib/session_mapper_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe OpenProject::OpenIDConnect::SessionMapper do +RSpec.describe OpenProject::OpenIDConnect::SessionMapper do let(:mock_session) do Class.new(Rack::Session::Abstract::SessionHash) do def initialize(id) diff --git a/modules/openid_connect/spec/models/provider_spec.rb b/modules/openid_connect/spec/models/provider_spec.rb index 7118fe1867c..5c0357d6e07 100644 --- a/modules/openid_connect/spec/models/provider_spec.rb +++ b/modules/openid_connect/spec/models/provider_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenIDConnect::Provider do +RSpec.describe OpenIDConnect::Provider do let(:provider) do described_class.initialize_with name: "azure", identifier: "id", secret: "secret" end diff --git a/modules/openid_connect/spec/models/user_session_link_spec.rb b/modules/openid_connect/spec/models/user_session_link_spec.rb index e5eb050e15f..4e61e732850 100644 --- a/modules/openid_connect/spec/models/user_session_link_spec.rb +++ b/modules/openid_connect/spec/models/user_session_link_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe OpenIDConnect::UserSessionLink do +RSpec.describe OpenIDConnect::UserSessionLink do describe 'session' do let(:plain_session) { create(:user_session) } let(:user_session) { Sessions::UserSession.find_by(session_id: plain_session.session_id) } diff --git a/modules/openid_connect/spec/requests/openid_connect_spec.rb b/modules/openid_connect/spec/requests/openid_connect_spec.rb index 33b9223fe9d..3fd6409c7fe 100644 --- a/modules/openid_connect/spec/requests/openid_connect_spec.rb +++ b/modules/openid_connect/spec/requests/openid_connect_spec.rb @@ -33,10 +33,10 @@ RSpec.configure do |c| c.include OpenIDConnectSpecHelpers end -describe 'OpenID Connect', - skip_2fa_stage: true, # Prevent redirects to 2FA stage - type: :rails_request, - with_ee: %i[openid_providers] do +RSpec.describe 'OpenID Connect', + skip_2fa_stage: true, # Prevent redirects to 2FA stage + type: :rails_request, + with_ee: %i[openid_providers] do let(:host) { OmniAuth::OpenIDConnect::Heroku.new('foo', {}).host } let(:user_info) do { diff --git a/modules/openid_connect/spec/routing/openid_connect/providers_controller_spec.rb b/modules/openid_connect/spec/routing/openid_connect/providers_controller_spec.rb index cdd0197bf25..751daa02b10 100644 --- a/modules/openid_connect/spec/routing/openid_connect/providers_controller_spec.rb +++ b/modules/openid_connect/spec/routing/openid_connect/providers_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'OpenIDConnect Providers' do +RSpec.describe 'OpenIDConnect Providers' do it 'routes to index' do expect(get('/admin/openid_connect/providers')).to route_to('openid_connect/providers#index') end diff --git a/modules/overviews/spec/contracts/grids/create_contract_spec.rb b/modules/overviews/spec/contracts/grids/create_contract_spec.rb index 81967ef1526..315fa283ada 100644 --- a/modules/overviews/spec/contracts/grids/create_contract_spec.rb +++ b/modules/overviews/spec/contracts/grids/create_contract_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Grids::CreateContract, 'for Grids::Overview' do +RSpec.describe Grids::CreateContract, 'for Grids::Overview' do let(:project) do build_stubbed(:project).tap do |p| allow(Project) diff --git a/modules/overviews/spec/contracts/roles/base_contract_spec.rb b/modules/overviews/spec/contracts/roles/base_contract_spec.rb index 836b469d4a3..e8f149c4ad2 100644 --- a/modules/overviews/spec/contracts/roles/base_contract_spec.rb +++ b/modules/overviews/spec/contracts/roles/base_contract_spec.rb @@ -26,7 +26,7 @@ require 'spec_helper' -describe Roles::BaseContract do +RSpec.describe Roles::BaseContract do let(:member_role) { build_stubbed(:role) } let(:global_role) { build_stubbed(:global_role) } let(:anonymous_role) { build_stubbed(:anonymous_role) } diff --git a/modules/overviews/spec/controllers/overviews/overviews_controller_spec.rb b/modules/overviews/spec/controllers/overviews/overviews_controller_spec.rb index c0dee738b34..be2eed6e5a1 100644 --- a/modules/overviews/spec/controllers/overviews/overviews_controller_spec.rb +++ b/modules/overviews/spec/controllers/overviews/overviews_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Overviews::OverviewsController do +RSpec.describe Overviews::OverviewsController do let(:permissions) do %i(view_project) end diff --git a/modules/overviews/spec/features/low_permissions_page_creation_spec.rb b/modules/overviews/spec/features/low_permissions_page_creation_spec.rb index 63dbd557d0a..3bdb25ab497 100644 --- a/modules/overviews/spec/features/low_permissions_page_creation_spec.rb +++ b/modules/overviews/spec/features/low_permissions_page_creation_spec.rb @@ -30,8 +30,8 @@ require 'spec_helper' require_relative '../support/pages/overview' -describe 'Overview page on the fly creation if user lacks :mange_overview permission', - js: true, with_mail: false do +RSpec.describe 'Overview page on the fly creation if user lacks :mange_overview permission', + js: true, with_mail: false do let!(:type) { create(:type) } let!(:project) { create(:project, types: [type]) } let!(:open_status) { create(:default_status) } diff --git a/modules/overviews/spec/features/managing_overview_page_spec.rb b/modules/overviews/spec/features/managing_overview_page_spec.rb index ef98bf0f7fd..efb3e403447 100644 --- a/modules/overviews/spec/features/managing_overview_page_spec.rb +++ b/modules/overviews/spec/features/managing_overview_page_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/overview' -describe 'Overview page managing', js: true, with_mail: false do +RSpec.describe 'Overview page managing', js: true, with_mail: false do let!(:type) { create(:type) } let!(:project) { create(:project, types: [type], description: 'My **custom** description') } let!(:open_status) { create(:default_status) } diff --git a/modules/overviews/spec/features/navigation_spec.rb b/modules/overviews/spec/features/navigation_spec.rb index 020c8b62a70..b35c67d0ee8 100644 --- a/modules/overviews/spec/features/navigation_spec.rb +++ b/modules/overviews/spec/features/navigation_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Navigate to overview', js: true do +RSpec.describe 'Navigate to overview', js: true do let(:project) { create(:project) } let(:permissions) { [] } let(:user) do diff --git a/modules/overviews/spec/lib/overview/grid_registration_spec.rb b/modules/overviews/spec/lib/overview/grid_registration_spec.rb index c7bcda467d4..dc326832519 100644 --- a/modules/overviews/spec/lib/overview/grid_registration_spec.rb +++ b/modules/overviews/spec/lib/overview/grid_registration_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Overviews::GridRegistration do +RSpec.describe Overviews::GridRegistration do let(:user) { build_stubbed(:user) } let(:project) { build_stubbed(:project) } let(:grid) { build_stubbed(:overview, project:) } diff --git a/modules/overviews/spec/requests/api/v3/grids/grids_resource_spec.rb b/modules/overviews/spec/requests/api/v3/grids/grids_resource_spec.rb index fd25e8129ce..f093174551f 100644 --- a/modules/overviews/spec/requests/api/v3/grids/grids_resource_spec.rb +++ b/modules/overviews/spec/requests/api/v3/grids/grids_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Grids resource', content_type: :json do +RSpec.describe 'API v3 Grids resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/modules/overviews/spec/services/copy_service_integration_spec.rb b/modules/overviews/spec/services/copy_service_integration_spec.rb index ce9d3d4fd1f..5475227d741 100644 --- a/modules/overviews/spec/services/copy_service_integration_spec.rb +++ b/modules/overviews/spec/services/copy_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::CopyService, 'integration', type: :model do +RSpec.describe Projects::CopyService, 'integration', type: :model do shared_let(:source) { create(:project, enabled_module_names: %w[wiki work_package_tracking]) } shared_let(:source_category) { create(:category, project: source, name: 'Stock management') } shared_let(:source_version) { create(:version, project: source, name: 'Version A') } diff --git a/modules/pdf_export/spec/controllers/export_card_configurations_controller_spec.rb b/modules/pdf_export/spec/controllers/export_card_configurations_controller_spec.rb index 13b3b803886..04074b79508 100644 --- a/modules/pdf_export/spec/controllers/export_card_configurations_controller_spec.rb +++ b/modules/pdf_export/spec/controllers/export_card_configurations_controller_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require File.dirname(__FILE__) + '/../shared_examples' -describe ExportCardConfigurationsController do +RSpec.describe ExportCardConfigurationsController do before do allow(@controller).to receive(:require_admin).and_return(true) diff --git a/modules/pdf_export/spec/export_card/document_generator_spec.rb b/modules/pdf_export/spec/export_card/document_generator_spec.rb index db6dace47b7..771715368f3 100644 --- a/modules/pdf_export/spec/export_card/document_generator_spec.rb +++ b/modules/pdf_export/spec/export_card/document_generator_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe OpenProject::PDFExport::ExportCard::DocumentGenerator do +RSpec.describe OpenProject::PDFExport::ExportCard::DocumentGenerator do let(:config) do ExportCardConfiguration.new({ name: "Default", diff --git a/modules/pdf_export/spec/features/export_card_configurations_admin_spec.rb b/modules/pdf_export/spec/features/export_card_configurations_admin_spec.rb index a614a290d95..1ad5d56d0d4 100644 --- a/modules/pdf_export/spec/features/export_card_configurations_admin_spec.rb +++ b/modules/pdf_export/spec/features/export_card_configurations_admin_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe "export card configurations Admin", js: true do +RSpec.describe "export card configurations Admin", js: true do let(:user) { create(:admin) } let!(:config1) { create(:export_card_configuration) } diff --git a/modules/pdf_export/spec/shared_examples.rb b/modules/pdf_export/spec/shared_examples.rb index 0fc01efce36..25b248c5cf2 100644 --- a/modules/pdf_export/spec/shared_examples.rb +++ b/modules/pdf_export/spec/shared_examples.rb @@ -1,4 +1,4 @@ -shared_examples_for "should let you create a configuration" do +RSpec.shared_examples_for "should let you create a configuration" do before do post 'create', params: end @@ -7,7 +7,7 @@ shared_examples_for "should let you create a configuration" do it { expect(flash[:notice]).to eq(I18n.t(:notice_successful_create)) } end -shared_examples_for "should not let you create a configuration" do +RSpec.shared_examples_for "should not let you create a configuration" do before do post 'create', params: end diff --git a/modules/pdf_export/spec/views/edit.html.erb_spec.rb b/modules/pdf_export/spec/views/edit.html.erb_spec.rb index 6630222bcb0..df94eeea279 100644 --- a/modules/pdf_export/spec/views/edit.html.erb_spec.rb +++ b/modules/pdf_export/spec/views/edit.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'export_card_configurations/edit' do +RSpec.describe 'export_card_configurations/edit' do let(:config) { build(:export_card_configuration) } before do diff --git a/modules/pdf_export/spec/views/index.html.erb_spec.rb b/modules/pdf_export/spec/views/index.html.erb_spec.rb index ff5b7eee2f6..493e453fbfc 100644 --- a/modules/pdf_export/spec/views/index.html.erb_spec.rb +++ b/modules/pdf_export/spec/views/index.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'export_card_configurations/index' do +RSpec.describe 'export_card_configurations/index' do let(:config1) { build(:export_card_configuration, name: "Config 1") } let(:config2) { build(:export_card_configuration, name: "Config 2") } diff --git a/modules/pdf_export/spec/views/new.html.erb_spec.rb b/modules/pdf_export/spec/views/new.html.erb_spec.rb index c92290293c1..ac282714747 100644 --- a/modules/pdf_export/spec/views/new.html.erb_spec.rb +++ b/modules/pdf_export/spec/views/new.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'export_card_configurations/new' do +RSpec.describe 'export_card_configurations/new' do let(:config) { build(:export_card_configuration) } before do diff --git a/modules/recaptcha/spec/controllers/admin_controller_spec.rb b/modules/recaptcha/spec/controllers/admin_controller_spec.rb index 52ba93edf95..e253baf1d79 100644 --- a/modules/recaptcha/spec/controllers/admin_controller_spec.rb +++ b/modules/recaptcha/spec/controllers/admin_controller_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Recaptcha::AdminController do +RSpec.describe Recaptcha::AdminController do let(:user) { build_stubbed(:admin) } before do diff --git a/modules/recaptcha/spec/controllers/request_controller_spec.rb b/modules/recaptcha/spec/controllers/request_controller_spec.rb index 76a8808dd8a..ac8ac0233ce 100644 --- a/modules/recaptcha/spec/controllers/request_controller_spec.rb +++ b/modules/recaptcha/spec/controllers/request_controller_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Recaptcha::RequestController do +RSpec.describe Recaptcha::RequestController do let(:user) { create(:user) } include_context 'with settings' do diff --git a/modules/reporting/spec/controllers/cost_reports_controller_spec.rb b/modules/reporting/spec/controllers/cost_reports_controller_spec.rb index afff39ec144..67b78271cb5 100644 --- a/modules/reporting/spec/controllers/cost_reports_controller_spec.rb +++ b/modules/reporting/spec/controllers/cost_reports_controller_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') -describe CostReportsController do +RSpec.describe CostReportsController do include OpenProject::Reporting::PluginSpecHelper let(:user) { build(:user) } diff --git a/modules/reporting/spec/controllers/custom_fields_controller_spec.rb b/modules/reporting/spec/controllers/custom_fields_controller_spec.rb index 2fd5b202fa4..d2b6b87ae48 100644 --- a/modules/reporting/spec/controllers/custom_fields_controller_spec.rb +++ b/modules/reporting/spec/controllers/custom_fields_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomFieldsController do +RSpec.describe CustomFieldsController do let!(:custom_field) { create(:work_package_custom_field) } let!(:custom_field_permanent) { create(:work_package_custom_field) } let(:custom_field_name) { "CustomField#{custom_field.id}" } diff --git a/modules/reporting/spec/features/calculations_spec.rb b/modules/reporting/spec/features/calculations_spec.rb index 18b580ac274..a5a26d04912 100644 --- a/modules/reporting/spec/features/calculations_spec.rb +++ b/modules/reporting/spec/features/calculations_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Cost report calculations', js: true do +RSpec.describe 'Cost report calculations', js: true do let(:project) { create(:project) } let(:user) { create(:admin) } diff --git a/modules/reporting/spec/features/custom_fields_spec.rb b/modules/reporting/spec/features/custom_fields_spec.rb index 1ebfb84891f..f83c8ebbf4c 100644 --- a/modules/reporting/spec/features/custom_fields_spec.rb +++ b/modules/reporting/spec/features/custom_fields_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Custom fields reporting', js: true do +RSpec.describe 'Custom fields reporting', js: true do let(:type) { create(:type) } let(:project) { create(:project, types: [type]) } diff --git a/modules/reporting/spec/features/filter_spec.rb b/modules/reporting/spec/features/filter_spec.rb index 242b8be9d64..318fd140244 100644 --- a/modules/reporting/spec/features/filter_spec.rb +++ b/modules/reporting/spec/features/filter_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Cost report calculations', js: true do +RSpec.describe 'Cost report calculations', js: true do let(:project) { create(:project) } let(:user) { create(:admin) } diff --git a/modules/reporting/spec/features/group_by_spec.rb b/modules/reporting/spec/features/group_by_spec.rb index 8e9a6bd0c4f..c350fc50b22 100644 --- a/modules/reporting/spec/features/group_by_spec.rb +++ b/modules/reporting/spec/features/group_by_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require_relative 'support/pages/cost_report_page' -describe 'Cost report calculations', js: true do +RSpec.describe 'Cost report calculations', js: true do let(:project) { create(:project) } let(:user) { create(:admin) } diff --git a/modules/reporting/spec/features/me_value_spec.rb b/modules/reporting/spec/features/me_value_spec.rb index 4399dcb389a..0a061ee6a49 100644 --- a/modules/reporting/spec/features/me_value_spec.rb +++ b/modules/reporting/spec/features/me_value_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Cost report showing my own times', js: true do +RSpec.describe 'Cost report showing my own times', js: true do let(:project) { create(:project) } let(:user) { create(:admin) } let(:user2) { create(:admin) } diff --git a/modules/reporting/spec/features/menu_spec.rb b/modules/reporting/spec/features/menu_spec.rb index 9efa915bd76..4491fa72add 100644 --- a/modules/reporting/spec/features/menu_spec.rb +++ b/modules/reporting/spec/features/menu_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'project menu' do +RSpec.describe 'project menu' do let(:current_user) { create(:admin) } let!(:project) { create(:valid_project, identifier: 'ponyo', name: 'Ponyo') } diff --git a/modules/reporting/spec/features/my_time_spec.rb b/modules/reporting/spec/features/my_time_spec.rb index da4bf176a10..e232bc3ef35 100644 --- a/modules/reporting/spec/features/my_time_spec.rb +++ b/modules/reporting/spec/features/my_time_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Cost report showing my own times', js: true do +RSpec.describe 'Cost report showing my own times', js: true do let(:project) { create(:project) } let(:user) { create(:admin) } let(:user2) { create(:admin) } diff --git a/modules/reporting/spec/features/permissions_spec.rb b/modules/reporting/spec/features/permissions_spec.rb index c6bc73ed5bf..ccf58052231 100644 --- a/modules/reporting/spec/features/permissions_spec.rb +++ b/modules/reporting/spec/features/permissions_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require_relative 'support/pages/cost_report_page' -describe 'Cost report calculations', js: true do +RSpec.describe 'Cost report calculations', js: true do let(:project) { create(:project) } let(:admin) { create(:admin) } diff --git a/modules/reporting/spec/features/project_context_spec.rb b/modules/reporting/spec/features/project_context_spec.rb index aa7b3c836d8..806e57d9067 100644 --- a/modules/reporting/spec/features/project_context_spec.rb +++ b/modules/reporting/spec/features/project_context_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require_relative 'support/pages/cost_report_page' -describe 'Cost report project context', js: true do +RSpec.describe 'Cost report project context', js: true do let(:project1) { create(:project) } let(:project2) { create(:project) } let(:admin) { create(:admin) } diff --git a/modules/reporting/spec/features/saving_spec.rb b/modules/reporting/spec/features/saving_spec.rb index 32f95664366..f7a0cd15a21 100644 --- a/modules/reporting/spec/features/saving_spec.rb +++ b/modules/reporting/spec/features/saving_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require_relative 'support/pages/cost_report_page' -describe 'Cost report saving', js: true do +RSpec.describe 'Cost report saving', js: true do let(:project) { create(:project) } let(:user) { create(:admin) } diff --git a/modules/reporting/spec/features/subproject_spec.rb b/modules/reporting/spec/features/subproject_spec.rb index b7792109599..b3e3d1e1cdb 100644 --- a/modules/reporting/spec/features/subproject_spec.rb +++ b/modules/reporting/spec/features/subproject_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Cost report in subproject', js: true do +RSpec.describe 'Cost report in subproject', js: true do let!(:project) { create(:project) } let!(:subproject) { create(:project, parent: project) } diff --git a/modules/reporting/spec/features/top_menu_item_spec.rb b/modules/reporting/spec/features/top_menu_item_spec.rb index f937397d299..fe35e19b1da 100644 --- a/modules/reporting/spec/features/top_menu_item_spec.rb +++ b/modules/reporting/spec/features/top_menu_item_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Top menu items', js: true do +RSpec.describe 'Top menu items', js: true do let(:user) { create(:user) } let(:open_menu) { true } diff --git a/modules/reporting/spec/features/update_cost_report_spec.rb b/modules/reporting/spec/features/update_cost_report_spec.rb index 4fe5d720653..a7c7e81648e 100644 --- a/modules/reporting/spec/features/update_cost_report_spec.rb +++ b/modules/reporting/spec/features/update_cost_report_spec.rb @@ -29,7 +29,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../spec_helper.rb') require_relative 'support/pages/cost_report_page' -describe "updating a cost report's cost type", js: true do +RSpec.describe "updating a cost report's cost type", js: true do let(:project) { create(:project_with_types, members: { user => create(:role) }) } let(:user) do create(:admin) diff --git a/modules/reporting/spec/features/update_entries_spec.rb b/modules/reporting/spec/features/update_entries_spec.rb index ad346b6a2c5..3b3e580e5f2 100644 --- a/modules/reporting/spec/features/update_entries_spec.rb +++ b/modules/reporting/spec/features/update_entries_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative 'support/pages/cost_report_page' require_relative 'support/components/cost_reports_base_table' -describe 'Updating entries within the cost report', js: true do +RSpec.describe 'Updating entries within the cost report', js: true do let(:project) { create(:project) } let(:user) { create(:admin, member_in_project: project, member_with_permissions: %i[work_package_assigned]) } let(:work_package) { create(:work_package, project:) } diff --git a/modules/reporting/spec/features/work_package_costlog_spec.rb b/modules/reporting/spec/features/work_package_costlog_spec.rb index 39b79e97a0f..220764c764e 100644 --- a/modules/reporting/spec/features/work_package_costlog_spec.rb +++ b/modules/reporting/spec/features/work_package_costlog_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Cost report showing my own times', js: true do +RSpec.describe 'Cost report showing my own times', js: true do let(:project) { create(:project) } let(:user) do create(:user, member_in_project: project, member_through_role: role) diff --git a/modules/reporting/spec/helpers/reporting_helper_spec.rb b/modules/reporting/spec/helpers/reporting_helper_spec.rb index 916f2eedbb2..2a96186d419 100644 --- a/modules/reporting/spec/helpers/reporting_helper_spec.rb +++ b/modules/reporting/spec/helpers/reporting_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ReportingHelper do +RSpec.describe ReportingHelper do describe '#field_representation_map' do context 'for a custom field' do context 'for which a custom option exists (e.g. a list field)' do diff --git a/modules/reporting/spec/lib/open_project/configuration_spec.rb b/modules/reporting/spec/lib/open_project/configuration_spec.rb index 3899555a81e..4276b41ce91 100644 --- a/modules/reporting/spec/lib/open_project/configuration_spec.rb +++ b/modules/reporting/spec/lib/open_project/configuration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'OpenProject::Configuration' do +RSpec.describe 'OpenProject::Configuration' do describe '.cost_reporting_cache_filter_classes' do it 'is a true by default via the method' do expect(OpenProject::Configuration.cost_reporting_cache_filter_classes).to be_truthy diff --git a/modules/reporting/spec/lib/open_project/reporting/default_data_spec.rb b/modules/reporting/spec/lib/open_project/reporting/default_data_spec.rb index 7350649330d..947353f0707 100644 --- a/modules/reporting/spec/lib/open_project/reporting/default_data_spec.rb +++ b/modules/reporting/spec/lib/open_project/reporting/default_data_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::Reporting::DefaultData do +RSpec.describe OpenProject::Reporting::DefaultData do let(:seeder) { BasicData::RoleSeeder.new } let(:project_admin) { OpenProject::Reporting::DefaultData.project_admin_role } let(:permissions) do diff --git a/modules/reporting/spec/models/cost_query/cache_spec.rb b/modules/reporting/spec/models/cost_query/cache_spec.rb index 98b062f2451..c22b9ab65d1 100644 --- a/modules/reporting/spec/models/cost_query/cache_spec.rb +++ b/modules/reporting/spec/models/cost_query/cache_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require File.join(File.dirname(__FILE__), '..', '..', 'support', 'configuration_helper') -describe CostQuery::Cache do +RSpec.describe CostQuery::Cache do include OpenProject::Reporting::SpecHelper::ConfigurationHelper def all_caches diff --git a/modules/reporting/spec/models/cost_query/chaining_spec.rb b/modules/reporting/spec/models/cost_query/chaining_spec.rb index f378f29e24a..0be611424e6 100644 --- a/modules/reporting/spec/models/cost_query/chaining_spec.rb +++ b/modules/reporting/spec/models/cost_query/chaining_spec.rb @@ -28,7 +28,7 @@ require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper") -describe CostQuery, reporting_query_helper: true do +RSpec.describe CostQuery, reporting_query_helper: true do let(:project) { create(:project) } minimal_query diff --git a/modules/reporting/spec/models/cost_query/filter_spec.rb b/modules/reporting/spec/models/cost_query/filter_spec.rb index 6abbea4f2a1..bcf237b438f 100644 --- a/modules/reporting/spec/models/cost_query/filter_spec.rb +++ b/modules/reporting/spec/models/cost_query/filter_spec.rb @@ -29,7 +29,7 @@ require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper") require File.join(File.dirname(__FILE__), '..', '..', 'support', 'custom_field_filter') -describe CostQuery, reporting_query_helper: true do +RSpec.describe CostQuery, reporting_query_helper: true do minimal_query let!(:project) { create(:project_with_types) } diff --git a/modules/reporting/spec/models/cost_query/group_by_spec.rb b/modules/reporting/spec/models/cost_query/group_by_spec.rb index 1dc998efe71..d5de61a315a 100644 --- a/modules/reporting/spec/models/cost_query/group_by_spec.rb +++ b/modules/reporting/spec/models/cost_query/group_by_spec.rb @@ -29,7 +29,7 @@ require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper") require File.join(File.dirname(__FILE__), '..', '..', 'support', 'custom_field_filter') -describe CostQuery, reporting_query_helper: true do +RSpec.describe CostQuery, reporting_query_helper: true do let!(:type) { create(:type) } let!(:project1) { create(:project_with_types, types: [type]) } let!(:work_package1) { create(:work_package, project: project1, type:) } diff --git a/modules/reporting/spec/models/cost_query/integration_spec.rb b/modules/reporting/spec/models/cost_query/integration_spec.rb index cd13c38d5a7..3bddc101b80 100644 --- a/modules/reporting/spec/models/cost_query/integration_spec.rb +++ b/modules/reporting/spec/models/cost_query/integration_spec.rb @@ -28,7 +28,7 @@ require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper") -describe CostQuery, reporting_query_helper: true do +RSpec.describe CostQuery, reporting_query_helper: true do minimal_query let!(:project1) { create(:project_with_types) } diff --git a/modules/reporting/spec/models/cost_query/operator_spec.rb b/modules/reporting/spec/models/cost_query/operator_spec.rb index a0d039cadee..49c364ed11d 100644 --- a/modules/reporting/spec/models/cost_query/operator_spec.rb +++ b/modules/reporting/spec/models/cost_query/operator_spec.rb @@ -28,7 +28,7 @@ require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper") -describe CostQuery, reporting_query_helper: true do +RSpec.describe CostQuery, reporting_query_helper: true do minimal_query let!(:project1) { create(:project, name: "project1", created_at: 5.minutes.ago) } diff --git a/modules/reporting/spec/models/cost_query/result_spec.rb b/modules/reporting/spec/models/cost_query/result_spec.rb index 8d81b08633f..a15b6fee94d 100644 --- a/modules/reporting/spec/models/cost_query/result_spec.rb +++ b/modules/reporting/spec/models/cost_query/result_spec.rb @@ -28,7 +28,7 @@ require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper") -describe CostQuery, reporting_query_helper: true do +RSpec.describe CostQuery, reporting_query_helper: true do before do create(:admin) project = create(:project_with_types) diff --git a/modules/reporting/spec/models/cost_query/validation_spec.rb b/modules/reporting/spec/models/cost_query/validation_spec.rb index 9fd7ede81ff..35d30665210 100644 --- a/modules/reporting/spec/models/cost_query/validation_spec.rb +++ b/modules/reporting/spec/models/cost_query/validation_spec.rb @@ -28,7 +28,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper') -describe "CostQuery::Validation" do +RSpec.describe "CostQuery::Validation" do class CostQuery::SomeBase include Report::Validation diff --git a/modules/reporting/spec/models/cost_query/walker_spec.rb b/modules/reporting/spec/models/cost_query/walker_spec.rb index 33c2322fe10..a52a9c762e6 100644 --- a/modules/reporting/spec/models/cost_query/walker_spec.rb +++ b/modules/reporting/spec/models/cost_query/walker_spec.rb @@ -28,7 +28,7 @@ require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper") -describe CostQuery, reporting_query_helper: true do +RSpec.describe CostQuery, reporting_query_helper: true do minimal_query before do diff --git a/modules/reporting/spec/requests/custom_field_cache_spec.rb b/modules/reporting/spec/requests/custom_field_cache_spec.rb index 4f303466150..0a5341dfe9d 100644 --- a/modules/reporting/spec/requests/custom_field_cache_spec.rb +++ b/modules/reporting/spec/requests/custom_field_cache_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require File.join(File.dirname(__FILE__), '..', 'support', 'custom_field_filter') require File.join(File.dirname(__FILE__), '..', 'support', 'configuration_helper') -describe 'Custom field filter and group by caching' do +RSpec.describe 'Custom field filter and group by caching' do include OpenProject::Reporting::SpecHelper::CustomFieldFilterHelper include OpenProject::Reporting::SpecHelper::ConfigurationHelper diff --git a/modules/storages/spec/common/peripherals/storage_requests_spec.rb b/modules/storages/spec/common/peripherals/storage_requests_spec.rb index 006ac940af1..78b6fbe298e 100644 --- a/modules/storages/spec/common/peripherals/storage_requests_spec.rb +++ b/modules/storages/spec/common/peripherals/storage_requests_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Storages::Peripherals::StorageRequests, webmock: true do +RSpec.describe Storages::Peripherals::StorageRequests, webmock: true do using Storages::Peripherals::ServiceResultRefinements let(:user) { build_stubbed(:user) } diff --git a/modules/storages/spec/contracts/storages/file_links/create_contract_spec.rb b/modules/storages/spec/contracts/storages/file_links/create_contract_spec.rb index f2aee087636..64a099bc556 100644 --- a/modules/storages/spec/contracts/storages/file_links/create_contract_spec.rb +++ b/modules/storages/spec/contracts/storages/file_links/create_contract_spec.rb @@ -31,7 +31,7 @@ require_module_spec_helper require 'contracts/shared/model_contract_shared_context' require_relative 'shared_contract_examples' -describe Storages::FileLinks::CreateContract do +RSpec.describe Storages::FileLinks::CreateContract do include_context 'ModelContract shared context' it_behaves_like 'file_link contract' do diff --git a/modules/storages/spec/contracts/storages/file_links/delete_contract_spec.rb b/modules/storages/spec/contracts/storages/file_links/delete_contract_spec.rb index cfcccb4bc95..47afe23f9c7 100644 --- a/modules/storages/spec/contracts/storages/file_links/delete_contract_spec.rb +++ b/modules/storages/spec/contracts/storages/file_links/delete_contract_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_module_spec_helper require 'contracts/shared/model_contract_shared_context' -describe Storages::FileLinks::DeleteContract do +RSpec.describe Storages::FileLinks::DeleteContract do include_context 'ModelContract shared context' let(:current_user) { create(:user) } diff --git a/modules/storages/spec/contracts/storages/file_links/shared_contract_examples.rb b/modules/storages/spec/contracts/storages/file_links/shared_contract_examples.rb index d53c7659fe9..8676319bb32 100644 --- a/modules/storages/spec/contracts/storages/file_links/shared_contract_examples.rb +++ b/modules/storages/spec/contracts/storages/file_links/shared_contract_examples.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../../../support/storage_server_helpers' -shared_examples_for 'file_link contract' do +RSpec.shared_examples_for 'file_link contract' do let(:current_user) { create(:user) } let(:role) { create(:existing_role, permissions: [:manage_file_links]) } let(:project) { create(:project, members: { current_user => role }) } diff --git a/modules/storages/spec/contracts/storages/project_storages/base_contract_spec.rb b/modules/storages/spec/contracts/storages/project_storages/base_contract_spec.rb index 35796e76887..26b7c240b88 100644 --- a/modules/storages/spec/contracts/storages/project_storages/base_contract_spec.rb +++ b/modules/storages/spec/contracts/storages/project_storages/base_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe Storages::ProjectStorages::BaseContract do +RSpec.describe Storages::ProjectStorages::BaseContract do include_context 'ModelContract shared context' let(:contract) { described_class.new(project_storage, build_stubbed(:admin)) } diff --git a/modules/storages/spec/contracts/storages/project_storages/create_contract_spec.rb b/modules/storages/spec/contracts/storages/project_storages/create_contract_spec.rb index d75bf878aac..4c1b9d2dd91 100644 --- a/modules/storages/spec/contracts/storages/project_storages/create_contract_spec.rb +++ b/modules/storages/spec/contracts/storages/project_storages/create_contract_spec.rb @@ -31,7 +31,7 @@ require_module_spec_helper require 'contracts/shared/model_contract_shared_context' require_relative 'shared_contract_examples' -describe Storages::ProjectStorages::CreateContract do +RSpec.describe Storages::ProjectStorages::CreateContract do include_context 'ModelContract shared context' it_behaves_like 'ProjectStorages contract' do diff --git a/modules/storages/spec/contracts/storages/project_storages/delete_contract_spec.rb b/modules/storages/spec/contracts/storages/project_storages/delete_contract_spec.rb index b86ea6b3334..296127bedcd 100644 --- a/modules/storages/spec/contracts/storages/project_storages/delete_contract_spec.rb +++ b/modules/storages/spec/contracts/storages/project_storages/delete_contract_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_module_spec_helper require 'contracts/shared/model_contract_shared_context' -describe Storages::ProjectStorages::DeleteContract do +RSpec.describe Storages::ProjectStorages::DeleteContract do include_context 'ModelContract shared context' let(:current_user) { create(:user) } diff --git a/modules/storages/spec/contracts/storages/project_storages/shared_contract_examples.rb b/modules/storages/spec/contracts/storages/project_storages/shared_contract_examples.rb index 5f800509e95..6b2d2bfbc3d 100644 --- a/modules/storages/spec/contracts/storages/project_storages/shared_contract_examples.rb +++ b/modules/storages/spec/contracts/storages/project_storages/shared_contract_examples.rb @@ -30,7 +30,7 @@ require 'spec_helper' # Purpose: Common testing logic shared between create and update specs. -shared_examples_for 'ProjectStorages contract' do +RSpec.shared_examples_for 'ProjectStorages contract' do let(:current_user) { create(:user) } # The user needs "edit_project" to see the project's settings page let(:role) { create(:role, permissions: %i[manage_storages_in_project edit_project]) } diff --git a/modules/storages/spec/contracts/storages/storages/base_contract_spec.rb b/modules/storages/spec/contracts/storages/storages/base_contract_spec.rb index 2a65f4d0084..fef869bc642 100644 --- a/modules/storages/spec/contracts/storages/storages/base_contract_spec.rb +++ b/modules/storages/spec/contracts/storages/storages/base_contract_spec.rb @@ -28,7 +28,7 @@ require_relative '../../../spec_helper' -describe Storages::Storages::BaseContract, :storage_server_helpers, webmock: true do +RSpec.describe Storages::Storages::BaseContract, :storage_server_helpers, webmock: true do let(:current_user) { create(:admin) } let(:storage_host) { 'https://host1.example.com' } let(:storage) { build(:storage, host: storage_host) } diff --git a/modules/storages/spec/contracts/storages/storages/create_contract_spec.rb b/modules/storages/spec/contracts/storages/storages/create_contract_spec.rb index 0797bd81a3d..bcb67c35315 100644 --- a/modules/storages/spec/contracts/storages/storages/create_contract_spec.rb +++ b/modules/storages/spec/contracts/storages/storages/create_contract_spec.rb @@ -31,7 +31,7 @@ require_module_spec_helper require 'contracts/shared/model_contract_shared_context' require_relative 'shared_contract_examples' -describe Storages::Storages::CreateContract do +RSpec.describe Storages::Storages::CreateContract do include_context 'ModelContract shared context' it_behaves_like 'storage contract' do diff --git a/modules/storages/spec/contracts/storages/storages/delete_contract_spec.rb b/modules/storages/spec/contracts/storages/storages/delete_contract_spec.rb index 612c5bb836c..f68a3565088 100644 --- a/modules/storages/spec/contracts/storages/storages/delete_contract_spec.rb +++ b/modules/storages/spec/contracts/storages/storages/delete_contract_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_module_spec_helper require 'contracts/shared/model_contract_shared_context' -describe Storages::Storages::DeleteContract do +RSpec.describe Storages::Storages::DeleteContract do include_context 'ModelContract shared context' let(:storage) { create(:storage) } diff --git a/modules/storages/spec/contracts/storages/storages/shared_contract_examples.rb b/modules/storages/spec/contracts/storages/storages/shared_contract_examples.rb index 9dc39841830..8d68419d716 100644 --- a/modules/storages/spec/contracts/storages/storages/shared_contract_examples.rb +++ b/modules/storages/spec/contracts/storages/storages/shared_contract_examples.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../../../support/storage_server_helpers' -shared_examples_for 'storage contract', :storage_server_helpers, webmock: true do +RSpec.shared_examples_for 'storage contract', :storage_server_helpers, webmock: true do # Only admins have the right to create/delete storages. let(:current_user) { create(:admin) } let(:storage_name) { 'Storage 1' } diff --git a/modules/storages/spec/contracts/storages/storages/update_contract_spec.rb b/modules/storages/spec/contracts/storages/storages/update_contract_spec.rb index 6a78dfb3b66..dd988b047a7 100644 --- a/modules/storages/spec/contracts/storages/storages/update_contract_spec.rb +++ b/modules/storages/spec/contracts/storages/storages/update_contract_spec.rb @@ -31,7 +31,7 @@ require_module_spec_helper require 'contracts/shared/model_contract_shared_context' require_relative 'shared_contract_examples' -describe Storages::Storages::UpdateContract do +RSpec.describe Storages::Storages::UpdateContract do include_context 'ModelContract shared context' it_behaves_like 'storage contract' do diff --git a/modules/storages/spec/controller/storages_controller_spec.rb b/modules/storages/spec/controller/storages_controller_spec.rb index d0cf69fc70c..b7c8875aeb0 100644 --- a/modules/storages/spec/controller/storages_controller_spec.rb +++ b/modules/storages/spec/controller/storages_controller_spec.rb @@ -30,7 +30,7 @@ require_relative '../spec_helper' # These specs mainly check that error messages from a sub-service # (about unsafe hosts with HTTP protocol) are passed to the main form. -describe Storages::Admin::StoragesController, type: :controller, webmock: true do +RSpec.describe Storages::Admin::StoragesController, type: :controller, webmock: true do render_views # rendering views is stubbed by default in controller specs include StorageServerHelpers diff --git a/modules/storages/spec/features/admin_storages_spec.rb b/modules/storages/spec/features/admin_storages_spec.rb index fdc4d135fe8..1ee97b9eab4 100644 --- a/modules/storages/spec/features/admin_storages_spec.rb +++ b/modules/storages/spec/features/admin_storages_spec.rb @@ -28,7 +28,7 @@ require_relative '../spec_helper' -describe 'Admin storages', :storage_server_helpers, js: true do +RSpec.describe 'Admin storages', :storage_server_helpers, js: true do let(:admin) { create(:admin) } before do diff --git a/modules/storages/spec/features/create_file_links_spec.rb b/modules/storages/spec/features/create_file_links_spec.rb index 86fd186dc46..8ec27288f3b 100644 --- a/modules/storages/spec/features/create_file_links_spec.rb +++ b/modules/storages/spec/features/create_file_links_spec.rb @@ -28,7 +28,7 @@ require_relative '../spec_helper' -describe 'Managing file links in work package', js: true, webmock: true do +RSpec.describe 'Managing file links in work package', js: true, webmock: true do let(:permissions) { %i(view_work_packages edit_work_packages view_file_links manage_file_links) } let(:project) { create(:project) } let(:current_user) { create(:user, member_in_project: project, member_with_permissions: permissions) } diff --git a/modules/storages/spec/features/delete_project_storage_and_file_links_spec.rb b/modules/storages/spec/features/delete_project_storage_and_file_links_spec.rb index 17d527f58b3..f0f631ec8db 100644 --- a/modules/storages/spec/features/delete_project_storage_and_file_links_spec.rb +++ b/modules/storages/spec/features/delete_project_storage_and_file_links_spec.rb @@ -30,7 +30,7 @@ require_relative '../spec_helper' # Test if the deletion of a ProjectStorage actually deletes related FileLink # objects. -describe 'Delete ProjectStorage with FileLinks', js: true do +RSpec.describe 'Delete ProjectStorage with FileLinks', js: true do let(:user) { create(:user) } let(:role) { create(:existing_role, permissions: [:manage_storages_in_project]) } let(:project) do diff --git a/modules/storages/spec/features/manage_project_storage_spec.rb b/modules/storages/spec/features/manage_project_storage_spec.rb index 91486afcc14..9a11ad101b4 100644 --- a/modules/storages/spec/features/manage_project_storage_spec.rb +++ b/modules/storages/spec/features/manage_project_storage_spec.rb @@ -31,7 +31,7 @@ require_relative '../spec_helper' # Setup storages in Project -> Settings -> File Storages # This tests assumes that a Storage has already been setup # in the Admin section, tested by admin_storage_spec.rb. -describe 'Activation of storages in projects', js: true, webmock: true, with_flag: { storage_project_folders: true } do +RSpec.describe 'Activation of storages in projects', js: true, webmock: true, with_flag: { storage_project_folders: true } do let(:user) { create(:user) } # The first page is the Project -> Settings -> General page, so we need # to provide the user with the edit_project permission in the role. diff --git a/modules/storages/spec/features/shared_context.rb b/modules/storages/spec/features/shared_context.rb index 1ef5069759c..56720d58e9e 100644 --- a/modules/storages/spec/features/shared_context.rb +++ b/modules/storages/spec/features/shared_context.rb @@ -29,6 +29,6 @@ require 'spec_helper' require_relative '../support/pages/storage_tab' -shared_context 'with storages full access' do +RSpec.shared_context 'with storages full access' do current_user { user } end diff --git a/modules/storages/spec/features/show_file_links_spec.rb b/modules/storages/spec/features/show_file_links_spec.rb index 899247b5624..0bcb2fb9e35 100644 --- a/modules/storages/spec/features/show_file_links_spec.rb +++ b/modules/storages/spec/features/show_file_links_spec.rb @@ -28,7 +28,7 @@ require_relative '../spec_helper' -describe 'Showing of file links in work package', js: true do +RSpec.describe 'Showing of file links in work package', js: true do let(:permissions) { %i(view_work_packages edit_work_packages view_file_links manage_file_links) } let(:project) { create(:project) } let(:current_user) { create(:user, member_in_project: project, member_with_permissions: permissions) } diff --git a/modules/storages/spec/features/storages_menu_links_spec.rb b/modules/storages/spec/features/storages_menu_links_spec.rb index b93a07e2e7e..39a17a57060 100644 --- a/modules/storages/spec/features/storages_menu_links_spec.rb +++ b/modules/storages/spec/features/storages_menu_links_spec.rb @@ -28,7 +28,7 @@ require_relative '../spec_helper' -describe 'Project menu', js: true do +RSpec.describe 'Project menu', js: true do let(:storage) { create(:storage, name: "Storage 1") } let(:another_storage) { create(:storage, name: "Storage 2") } let(:unlinked_storage) { create(:storage, name: "Storage 3") } diff --git a/modules/storages/spec/features/storages_module_spec.rb b/modules/storages/spec/features/storages_module_spec.rb index 5e2cb1e291c..c70693d1c1a 100644 --- a/modules/storages/spec/features/storages_module_spec.rb +++ b/modules/storages/spec/features/storages_module_spec.rb @@ -28,7 +28,7 @@ require_relative '../spec_helper' -describe 'Storages module', js: true do +RSpec.describe 'Storages module', js: true do current_user { create(:admin) } let(:role) { create(:role, permissions: %i[manage_storages_in_project select_project_modules edit_project]) } diff --git a/modules/storages/spec/lib/api/v3/file_links/file_link_representer_parsing_spec.rb b/modules/storages/spec/lib/api/v3/file_links/file_link_representer_parsing_spec.rb index f9c86747139..ad4b95ce9a9 100644 --- a/modules/storages/spec/lib/api/v3/file_links/file_link_representer_parsing_spec.rb +++ b/modules/storages/spec/lib/api/v3/file_links/file_link_representer_parsing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::FileLinks::FileLinkRepresenter, 'parsing' do +RSpec.describe API::V3::FileLinks::FileLinkRepresenter, 'parsing' do include API::V3::Utilities::PathHelper let(:file_link) { build_stubbed(:file_link) } diff --git a/modules/storages/spec/lib/api/v3/file_links/file_link_representer_rendering_spec.rb b/modules/storages/spec/lib/api/v3/file_links/file_link_representer_rendering_spec.rb index ae034dbdb25..e12bbf77fd4 100644 --- a/modules/storages/spec/lib/api/v3/file_links/file_link_representer_rendering_spec.rb +++ b/modules/storages/spec/lib/api/v3/file_links/file_link_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::FileLinks::FileLinkRepresenter, 'rendering' do +RSpec.describe API::V3::FileLinks::FileLinkRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:storage) { build_stubbed(:storage) } diff --git a/modules/storages/spec/lib/api/v3/project_storages/project_storage_representer_spec.rb b/modules/storages/spec/lib/api/v3/project_storages/project_storage_representer_spec.rb index c60048f7fa1..b0aa3e88280 100644 --- a/modules/storages/spec/lib/api/v3/project_storages/project_storage_representer_spec.rb +++ b/modules/storages/spec/lib/api/v3/project_storages/project_storage_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::ProjectStorages::ProjectStorageRepresenter do +RSpec.describe API::V3::ProjectStorages::ProjectStorageRepresenter do include API::V3::Utilities::PathHelper let(:user) { build_stubbed(:user) } diff --git a/modules/storages/spec/lib/api/v3/storage_files/storage_file_representer_spec.rb b/modules/storages/spec/lib/api/v3/storage_files/storage_file_representer_spec.rb index d8f8f421542..ed40ac1fdd4 100644 --- a/modules/storages/spec/lib/api/v3/storage_files/storage_file_representer_spec.rb +++ b/modules/storages/spec/lib/api/v3/storage_files/storage_file_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::StorageFiles::StorageFileRepresenter do +RSpec.describe API::V3::StorageFiles::StorageFileRepresenter do let(:user) { build_stubbed(:user) } let(:created_at) { DateTime.now } let(:last_modified_at) { DateTime.now } diff --git a/modules/storages/spec/lib/api/v3/storage_files/storage_files_representer_spec.rb b/modules/storages/spec/lib/api/v3/storage_files/storage_files_representer_spec.rb index 9b3f98132d6..a30cbd48dda 100644 --- a/modules/storages/spec/lib/api/v3/storage_files/storage_files_representer_spec.rb +++ b/modules/storages/spec/lib/api/v3/storage_files/storage_files_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::StorageFiles::StorageFilesRepresenter do +RSpec.describe API::V3::StorageFiles::StorageFilesRepresenter do let(:user) { build_stubbed(:user) } let(:storage) { build_stubbed(:storage) } let(:created_at) { DateTime.now } diff --git a/modules/storages/spec/lib/api/v3/storage_files/storage_upload_link_representer_spec.rb b/modules/storages/spec/lib/api/v3/storage_files/storage_upload_link_representer_spec.rb index 417e5773526..d6133f5396e 100644 --- a/modules/storages/spec/lib/api/v3/storage_files/storage_upload_link_representer_spec.rb +++ b/modules/storages/spec/lib/api/v3/storage_files/storage_upload_link_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::StorageFiles::StorageUploadLinkRepresenter, 'rendering' do +RSpec.describe API::V3::StorageFiles::StorageUploadLinkRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:user) { build_stubbed(:user) } diff --git a/modules/storages/spec/lib/api/v3/storages/storages_representer_rendering_spec.rb b/modules/storages/spec/lib/api/v3/storages/storages_representer_rendering_spec.rb index 5e055232af9..756de7a1906 100644 --- a/modules/storages/spec/lib/api/v3/storages/storages_representer_rendering_spec.rb +++ b/modules/storages/spec/lib/api/v3/storages/storages_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Storages::StorageRepresenter, 'rendering' do +RSpec.describe API::V3::Storages::StorageRepresenter, 'rendering' do let(:oauth_application) { build_stubbed(:oauth_application) } let(:oauth_client_credentials) { build_stubbed(:oauth_client) } let(:storage) { build_stubbed(:storage, oauth_application:, oauth_client: oauth_client_credentials) } diff --git a/modules/storages/spec/lib/append_storages_hosts_to_csp_hook_spec.rb b/modules/storages/spec/lib/append_storages_hosts_to_csp_hook_spec.rb index cbceb3d4bde..56c0fd108a1 100644 --- a/modules/storages/spec/lib/append_storages_hosts_to_csp_hook_spec.rb +++ b/modules/storages/spec/lib/append_storages_hosts_to_csp_hook_spec.rb @@ -30,7 +30,7 @@ require_relative '../spec_helper' # These specs mainly check that error messages from a sub-service # (about unsafe hosts with HTTP protocol) are passed to the main form. -describe OpenProject::Storages::AppendStoragesHostsToCspHook do +RSpec.describe OpenProject::Storages::AppendStoragesHostsToCspHook do shared_let(:admin) { create(:admin) } shared_let(:project) { create(:project) } let(:storage) { create(:storage) } diff --git a/modules/storages/spec/models/file_link_spec.rb b/modules/storages/spec/models/file_link_spec.rb index cc2f0235105..4103fb82ee2 100644 --- a/modules/storages/spec/models/file_link_spec.rb +++ b/modules/storages/spec/models/file_link_spec.rb @@ -28,7 +28,7 @@ require_relative '../spec_helper' -describe Storages::FileLink do +RSpec.describe Storages::FileLink do let(:creator) { create(:user) } let(:project) { create(:project) } let(:work_package) { create(:work_package, project:) } diff --git a/modules/storages/spec/models/project_storage_spec.rb b/modules/storages/spec/models/project_storage_spec.rb index b4da7b5f15b..e1f46d18b63 100644 --- a/modules/storages/spec/models/project_storage_spec.rb +++ b/modules/storages/spec/models/project_storage_spec.rb @@ -28,7 +28,7 @@ require_relative '../spec_helper' -describe Storages::ProjectStorage do +RSpec.describe Storages::ProjectStorage do let(:creator) { create(:user) } let(:project) { create(:project, enabled_module_names: %i[storages work_packages]) } let(:storage) { create(:storage) } diff --git a/modules/storages/spec/models/storage_spec.rb b/modules/storages/spec/models/storage_spec.rb index 43294db443b..f492faae12c 100644 --- a/modules/storages/spec/models/storage_spec.rb +++ b/modules/storages/spec/models/storage_spec.rb @@ -28,7 +28,7 @@ require_relative '../spec_helper' -describe Storages::Storage do +RSpec.describe Storages::Storage do let(:creator) { create(:user) } let(:default_attributes) do { name: "NC 1", diff --git a/modules/storages/spec/permissions/manage_storage_in_project_spec.rb b/modules/storages/spec/permissions/manage_storage_in_project_spec.rb index d7de7a9e7b9..7cbc3114ade 100644 --- a/modules/storages/spec/permissions/manage_storage_in_project_spec.rb +++ b/modules/storages/spec/permissions/manage_storage_in_project_spec.rb @@ -31,7 +31,7 @@ require 'support/permission_specs' require_module_spec_helper # rubocop:disable RSpec/EmptyExampleGroup -describe Storages::Admin::ProjectsStoragesController, 'manage_storage_in_project permission', type: :controller do +RSpec.describe Storages::Admin::ProjectsStoragesController, 'manage_storage_in_project permission', type: :controller do include PermissionSpecs controller_actions.each do |action| diff --git a/modules/storages/spec/requests/api/v3/file_links/file_links_spec.rb b/modules/storages/spec/requests/api/v3/file_links/file_links_spec.rb index f27c656d6bd..2464f716dbd 100644 --- a/modules/storages/spec/requests/api/v3/file_links/file_links_spec.rb +++ b/modules/storages/spec/requests/api/v3/file_links/file_links_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_module_spec_helper -describe 'API v3 file links resource' do +RSpec.describe 'API v3 file links resource' do include API::V3::Utilities::PathHelper let(:permissions) { %i(view_work_packages view_file_links) } diff --git a/modules/storages/spec/requests/api/v3/file_links/mixed_case_file_links_integration_spec.rb b/modules/storages/spec/requests/api/v3/file_links/mixed_case_file_links_integration_spec.rb index 21892366e06..20cfad600fa 100644 --- a/modules/storages/spec/requests/api/v3/file_links/mixed_case_file_links_integration_spec.rb +++ b/modules/storages/spec/requests/api/v3/file_links/mixed_case_file_links_integration_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_module_spec_helper # We want to check the case of file_links from multiple storages -describe 'API v3 file links resource' do +RSpec.describe 'API v3 file links resource' do include API::V3::Utilities::PathHelper let(:project) { create(:project) } diff --git a/modules/storages/spec/requests/api/v3/project_storages/project_storages_spec.rb b/modules/storages/spec/requests/api/v3/project_storages/project_storages_spec.rb index b1a396ff7d1..51dee39ce1e 100644 --- a/modules/storages/spec/requests/api/v3/project_storages/project_storages_spec.rb +++ b/modules/storages/spec/requests/api/v3/project_storages/project_storages_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_module_spec_helper -describe 'API v3 project storages resource', content_type: :json, webmock: true do +RSpec.describe 'API v3 project storages resource', content_type: :json, webmock: true do include API::V3::Utilities::PathHelper let(:view_permissions) { %i(view_work_packages view_file_links) } diff --git a/modules/storages/spec/requests/api/v3/storages/storage_files_spec.rb b/modules/storages/spec/requests/api/v3/storages/storage_files_spec.rb index 71985d1b6d5..bd59d895002 100644 --- a/modules/storages/spec/requests/api/v3/storages/storage_files_spec.rb +++ b/modules/storages/spec/requests/api/v3/storages/storage_files_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_module_spec_helper -describe 'API v3 storage files', content_type: :json, webmock: true do +RSpec.describe 'API v3 storage files', content_type: :json, webmock: true do include API::V3::Utilities::PathHelper include StorageServerHelpers diff --git a/modules/storages/spec/requests/api/v3/storages/storages_spec.rb b/modules/storages/spec/requests/api/v3/storages/storages_spec.rb index 978253c7dfc..9b6d86f8fc3 100644 --- a/modules/storages/spec/requests/api/v3/storages/storages_spec.rb +++ b/modules/storages/spec/requests/api/v3/storages/storages_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_module_spec_helper -describe 'API v3 storages resource', content_type: :json, webmock: true do +RSpec.describe 'API v3 storages resource', content_type: :json, webmock: true do include API::V3::Utilities::PathHelper include StorageServerHelpers diff --git a/modules/storages/spec/requests/api/v3/work_packages/work_packages_linkable_filter_spec.rb b/modules/storages/spec/requests/api/v3/work_packages/work_packages_linkable_filter_spec.rb index be8b79224e4..acd54bd105d 100644 --- a/modules/storages/spec/requests/api/v3/work_packages/work_packages_linkable_filter_spec.rb +++ b/modules/storages/spec/requests/api/v3/work_packages/work_packages_linkable_filter_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_module_spec_helper -describe 'API v3 work packages resource with filters for the linkable to storage attribute', - content_type: :json do +RSpec.describe 'API v3 work packages resource with filters for the linkable to storage attribute', + content_type: :json do include API::V3::Utilities::PathHelper let(:file_link_permissions) { %i(view_work_packages view_file_links manage_file_links) } diff --git a/modules/storages/spec/requests/api/v3/work_packages/work_packages_linked_filter_spec.rb b/modules/storages/spec/requests/api/v3/work_packages/work_packages_linked_filter_spec.rb index 48c308be275..908c3582a5b 100644 --- a/modules/storages/spec/requests/api/v3/work_packages/work_packages_linked_filter_spec.rb +++ b/modules/storages/spec/requests/api/v3/work_packages/work_packages_linked_filter_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_module_spec_helper -describe 'API v3 work packages resource with filters for linked storage file', - content_type: :json do +RSpec.describe 'API v3 work packages resource with filters for linked storage file', + content_type: :json do include API::V3::Utilities::PathHelper let(:file_link_permissions) { %i(view_work_packages view_file_links) } diff --git a/modules/storages/spec/requests/append_content_security_policy_spec.rb b/modules/storages/spec/requests/append_content_security_policy_spec.rb index bbeb1a71f1d..fd169a550ca 100644 --- a/modules/storages/spec/requests/append_content_security_policy_spec.rb +++ b/modules/storages/spec/requests/append_content_security_policy_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_module_spec_helper -describe 'Appendix of default CSP for external file storage hosts' do +RSpec.describe 'Appendix of default CSP for external file storage hosts' do shared_let(:project) { create(:project) } shared_let(:storage) { create(:storage) } shared_let(:project_storage) { create(:project_storage, project:, storage:) } diff --git a/modules/storages/spec/seeders/seeder_spec.rb b/modules/storages/spec/seeders/seeder_spec.rb index 0a1cd19faf4..7165fb55f3b 100644 --- a/modules/storages/spec/seeders/seeder_spec.rb +++ b/modules/storages/spec/seeders/seeder_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RootSeeder, 'Storage module' do +RSpec.describe RootSeeder, 'Storage module' do it 'seeds role permissions for Storages' do described_class.new.seed_data! diff --git a/modules/storages/spec/services/principals/replace_references_service_call_integration_spec.rb b/modules/storages/spec/services/principals/replace_references_service_call_integration_spec.rb index 41d4e3bf568..927d9088359 100644 --- a/modules/storages/spec/services/principals/replace_references_service_call_integration_spec.rb +++ b/modules/storages/spec/services/principals/replace_references_service_call_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Principals::ReplaceReferencesService, '#call', type: :model do +RSpec.describe Principals::ReplaceReferencesService, '#call', type: :model do shared_let(:principal) { create(:user) } shared_let(:to_principal) { create(:user) } diff --git a/modules/storages/spec/services/storages/file_links/create_service_spec.rb b/modules/storages/spec/services/storages/file_links/create_service_spec.rb index 2e829fedb0f..d44ba66a729 100644 --- a/modules/storages/spec/services/storages/file_links/create_service_spec.rb +++ b/modules/storages/spec/services/storages/file_links/create_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Storages::FileLinks::CreateService, type: :model do +RSpec.describe Storages::FileLinks::CreateService, type: :model do it_behaves_like 'BaseServices create service' do let(:factory) { :file_link } end diff --git a/modules/storages/spec/services/storages/file_links/delete_service_spec.rb b/modules/storages/spec/services/storages/file_links/delete_service_spec.rb index afd92f309fc..da9d19286fd 100644 --- a/modules/storages/spec/services/storages/file_links/delete_service_spec.rb +++ b/modules/storages/spec/services/storages/file_links/delete_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_delete_service' -describe Storages::FileLinks::DeleteService, type: :model do +RSpec.describe Storages::FileLinks::DeleteService, type: :model do it_behaves_like 'BaseServices delete service' do let(:factory) { :file_link } end diff --git a/modules/storages/spec/services/storages/file_links/file_link_sync_service_spec.rb b/modules/storages/spec/services/storages/file_links/file_link_sync_service_spec.rb index 1e0fc61acbe..49c6cc8211f 100644 --- a/modules/storages/spec/services/storages/file_links/file_link_sync_service_spec.rb +++ b/modules/storages/spec/services/storages/file_links/file_link_sync_service_spec.rb @@ -35,7 +35,7 @@ require 'webmock/rspec' # We want to test that permissions are processed correctoy and also # test the reaction to various types of network issues. # This spec bears some similarities to the connection_manager_spec.rb. -describe Storages::FileLinkSyncService, type: :model do +RSpec.describe Storages::FileLinkSyncService, type: :model do let(:user) { create(:user) } let(:role) { create(:existing_role, permissions: [:manage_file_links]) } let(:project) { create(:project, members: { user => role }) } diff --git a/modules/storages/spec/services/storages/file_links/set_attributes_service_spec.rb b/modules/storages/spec/services/storages/file_links/set_attributes_service_spec.rb index 1228f8c172a..9a3323ec760 100644 --- a/modules/storages/spec/services/storages/file_links/set_attributes_service_spec.rb +++ b/modules/storages/spec/services/storages/file_links/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Storages::FileLinks::SetAttributesService, type: :model do +RSpec.describe Storages::FileLinks::SetAttributesService, type: :model do let(:current_user) { build_stubbed(:admin) } let(:contract_instance) do diff --git a/modules/storages/spec/services/storages/oauth_applications/create_service_spec.rb b/modules/storages/spec/services/storages/oauth_applications/create_service_spec.rb index 8a82055d557..01dc796f07f 100644 --- a/modules/storages/spec/services/storages/oauth_applications/create_service_spec.rb +++ b/modules/storages/spec/services/storages/oauth_applications/create_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Storages::OAuthApplications::CreateService, type: :model do +RSpec.describe Storages::OAuthApplications::CreateService, type: :model do let(:user) { create(:admin) } let(:storage) { create(:storage, creator: user) } let(:instance) { described_class.new(user:, storage:) } diff --git a/modules/storages/spec/services/storages/project_storages/create_service_spec.rb b/modules/storages/spec/services/storages/project_storages/create_service_spec.rb index 321511660a5..480ffd9ba69 100644 --- a/modules/storages/spec/services/storages/project_storages/create_service_spec.rb +++ b/modules/storages/spec/services/storages/project_storages/create_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Storages::ProjectStorages::CreateService, type: :model do +RSpec.describe Storages::ProjectStorages::CreateService, type: :model do it_behaves_like 'BaseServices create service' do let(:factory) { :project_storage } end diff --git a/modules/storages/spec/services/storages/project_storages/delete_service_spec.rb b/modules/storages/spec/services/storages/project_storages/delete_service_spec.rb index dd463ad69f9..813f12cd62c 100644 --- a/modules/storages/spec/services/storages/project_storages/delete_service_spec.rb +++ b/modules/storages/spec/services/storages/project_storages/delete_service_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_module_spec_helper require 'services/base_services/behaves_like_delete_service' -describe Storages::ProjectStorages::DeleteService, type: :model do +RSpec.describe Storages::ProjectStorages::DeleteService, type: :model do context 'with records written to DB' do let(:user) { create(:user) } let(:role) { create(:existing_role, permissions: [:manage_storages_in_project]) } diff --git a/modules/storages/spec/services/storages/project_storages/set_attributes_service_spec.rb b/modules/storages/spec/services/storages/project_storages/set_attributes_service_spec.rb index 2ff4819d5d9..f65516e18a9 100644 --- a/modules/storages/spec/services/storages/project_storages/set_attributes_service_spec.rb +++ b/modules/storages/spec/services/storages/project_storages/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Storages::ProjectStorages::SetAttributesService, type: :model do +RSpec.describe Storages::ProjectStorages::SetAttributesService, type: :model do let(:current_user) { build_stubbed(:admin) } let(:contract_instance) do diff --git a/modules/storages/spec/services/storages/project_storages/update_service_spec.rb b/modules/storages/spec/services/storages/project_storages/update_service_spec.rb index 9b2795905bb..f4c2691f0f3 100644 --- a/modules/storages/spec/services/storages/project_storages/update_service_spec.rb +++ b/modules/storages/spec/services/storages/project_storages/update_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_update_service' -describe Storages::ProjectStorages::UpdateService, type: :model do +RSpec.describe Storages::ProjectStorages::UpdateService, type: :model do it_behaves_like 'BaseServices update service' do let(:factory) { :project_storage } end diff --git a/modules/storages/spec/services/storages/storages/create_service_spec.rb b/modules/storages/spec/services/storages/storages/create_service_spec.rb index 38cbf8269cb..8f154af09ef 100644 --- a/modules/storages/spec/services/storages/storages/create_service_spec.rb +++ b/modules/storages/spec/services/storages/storages/create_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Storages::Storages::CreateService, type: :model do +RSpec.describe Storages::Storages::CreateService, type: :model do it_behaves_like 'BaseServices create service' do let(:factory) { :storage } diff --git a/modules/storages/spec/services/storages/storages/delete_service_spec.rb b/modules/storages/spec/services/storages/storages/delete_service_spec.rb index 2a64976948a..e739b90c0e0 100644 --- a/modules/storages/spec/services/storages/storages/delete_service_spec.rb +++ b/modules/storages/spec/services/storages/storages/delete_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_delete_service' -describe Storages::Storages::DeleteService, type: :model do +RSpec.describe Storages::Storages::DeleteService, type: :model do it_behaves_like 'BaseServices delete service' do let(:factory) { :storage } end diff --git a/modules/storages/spec/services/storages/storages/set_attributes_service_spec.rb b/modules/storages/spec/services/storages/storages/set_attributes_service_spec.rb index f61314a99ef..d02161de754 100644 --- a/modules/storages/spec/services/storages/storages/set_attributes_service_spec.rb +++ b/modules/storages/spec/services/storages/storages/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Storages::Storages::SetAttributesService, type: :model do +RSpec.describe Storages::Storages::SetAttributesService, type: :model do let(:current_user) { build_stubbed(:admin) } let(:contract_instance) do diff --git a/modules/storages/spec/services/storages/storages/update_service_spec.rb b/modules/storages/spec/services/storages/storages/update_service_spec.rb index 3a403e16055..40ea8dc1fdd 100644 --- a/modules/storages/spec/services/storages/storages/update_service_spec.rb +++ b/modules/storages/spec/services/storages/storages/update_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_update_service' -describe Storages::Storages::UpdateService, type: :model do +RSpec.describe Storages::Storages::UpdateService, type: :model do it_behaves_like 'BaseServices update service' do let(:factory) { :storage } let!(:user) { create(:admin) } diff --git a/modules/storages/spec/workers/cleanup_uncontainered_file_links_job_spec.rb b/modules/storages/spec/workers/cleanup_uncontainered_file_links_job_spec.rb index 5ae569ec547..6123afd5ab5 100644 --- a/modules/storages/spec/workers/cleanup_uncontainered_file_links_job_spec.rb +++ b/modules/storages/spec/workers/cleanup_uncontainered_file_links_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CleanupUncontaineredFileLinksJob, type: :job do +RSpec.describe CleanupUncontaineredFileLinksJob, type: :job do it 'has a schedule set' do expect(described_class.cron_expression).to eq('06 22 * * *') end diff --git a/modules/team_planner/spec/contracts/views/create_contract_team_planner_spec.rb b/modules/team_planner/spec/contracts/views/create_contract_team_planner_spec.rb index b80f9b91e3a..50e0a423c90 100644 --- a/modules/team_planner/spec/contracts/views/create_contract_team_planner_spec.rb +++ b/modules/team_planner/spec/contracts/views/create_contract_team_planner_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' require 'contracts/views/shared_contract_examples' -describe Views::CreateContract do +RSpec.describe Views::CreateContract do it_behaves_like 'view contract', true do let(:view) do View.new(query: view_query, diff --git a/modules/team_planner/spec/features/onboarding/team_planner_onboarding_tour_spec.rb b/modules/team_planner/spec/features/onboarding/team_planner_onboarding_tour_spec.rb index 09078e05efb..c6d84923349 100644 --- a/modules/team_planner/spec/features/onboarding/team_planner_onboarding_tour_spec.rb +++ b/modules/team_planner/spec/features/onboarding/team_planner_onboarding_tour_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './../../support/onboarding/onboarding_steps' -describe 'team planner onboarding tour', js: true, with_ee: %i[team_planner_view] do +RSpec.describe 'team planner onboarding tour', js: true, with_ee: %i[team_planner_view] do let(:next_button) { find('.enjoyhint_next_btn') } let(:demo_project) do diff --git a/modules/team_planner/spec/features/query_handling_spec.rb b/modules/team_planner/spec/features/query_handling_spec.rb index ced63490ce8..e9fbc76ac29 100644 --- a/modules/team_planner/spec/features/query_handling_spec.rb +++ b/modules/team_planner/spec/features/query_handling_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative '../support/pages/team_planner' require_relative '../../../../spec/features/views/shared_examples' -describe 'Team planner query handling', js: true, with_ee: %i[team_planner_view] do +RSpec.describe 'Team planner query handling', js: true, with_ee: %i[team_planner_view] do shared_let(:type_task) { create(:type_task) } shared_let(:type_bug) { create(:type_bug) } shared_let(:project) do diff --git a/modules/team_planner/spec/features/shared_context.rb b/modules/team_planner/spec/features/shared_context.rb index f3837e01cba..3291217b882 100644 --- a/modules/team_planner/spec/features/shared_context.rb +++ b/modules/team_planner/spec/features/shared_context.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../support/pages/team_planner' -shared_context 'with team planner full access' do +RSpec.shared_context 'with team planner full access' do shared_let(:project) do create(:project) end diff --git a/modules/team_planner/spec/features/team_planner_add_existing_work_packages_spec.rb b/modules/team_planner/spec/features/team_planner_add_existing_work_packages_spec.rb index c94ade5f454..94086d2491d 100644 --- a/modules/team_planner/spec/features/team_planner_add_existing_work_packages_spec.rb +++ b/modules/team_planner/spec/features/team_planner_add_existing_work_packages_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './shared_context' require_relative '../support/components/add_existing_pane' -describe 'Team planner add existing work packages', js: true do +RSpec.describe 'Team planner add existing work packages', js: true do include_context 'with team planner full access' let(:closed_status) { create(:status, is_closed: true) } diff --git a/modules/team_planner/spec/features/team_planner_context_menu_spec.rb b/modules/team_planner/spec/features/team_planner_context_menu_spec.rb index 7941e2d51ec..e44348f5392 100644 --- a/modules/team_planner/spec/features/team_planner_context_menu_spec.rb +++ b/modules/team_planner/spec/features/team_planner_context_menu_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' require_relative 'shared_context' require 'features/work_packages/table/context_menu/context_menu_shared_examples' -describe 'Work package table context menu', js: true, with_ee: %i[team_planner_view] do +RSpec.describe 'Work package table context menu', js: true, with_ee: %i[team_planner_view] do include_context 'with team planner full access' let!(:work_package) do diff --git a/modules/team_planner/spec/features/team_planner_create_spec.rb b/modules/team_planner/spec/features/team_planner_create_spec.rb index e5adc5923cd..662492a65fb 100644 --- a/modules/team_planner/spec/features/team_planner_create_spec.rb +++ b/modules/team_planner/spec/features/team_planner_create_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_context' -describe 'Team planner create new work package', js: true, with_ee: %i[team_planner_view] do +RSpec.describe 'Team planner create new work package', js: true, with_ee: %i[team_planner_view] do include_context 'with team planner full access' let(:type_task) { create(:type_task) } diff --git a/modules/team_planner/spec/features/team_planner_dates_spec.rb b/modules/team_planner/spec/features/team_planner_dates_spec.rb index c495d614bcd..d9f4278a5ed 100644 --- a/modules/team_planner/spec/features/team_planner_dates_spec.rb +++ b/modules/team_planner/spec/features/team_planner_dates_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_context' -describe 'Team planner working days', js: true, with_ee: %i[team_planner_view] do +RSpec.describe 'Team planner working days', js: true, with_ee: %i[team_planner_view] do include_context 'with team planner full access' context 'with week days defined' do diff --git a/modules/team_planner/spec/features/team_planner_error_handling_spec.rb b/modules/team_planner/spec/features/team_planner_error_handling_spec.rb index 1e0fc331dcf..17254224970 100644 --- a/modules/team_planner/spec/features/team_planner_error_handling_spec.rb +++ b/modules/team_planner/spec/features/team_planner_error_handling_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_context' -describe 'Team planner error handling', js: true do +RSpec.describe 'Team planner error handling', js: true do include_context 'with team planner full access' let!(:work_package) do diff --git a/modules/team_planner/spec/features/team_planner_index_spec.rb b/modules/team_planner/spec/features/team_planner_index_spec.rb index 6e7eb7c7018..35dd86154a1 100644 --- a/modules/team_planner/spec/features/team_planner_index_spec.rb +++ b/modules/team_planner/spec/features/team_planner_index_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_context' -describe 'Team planner index', js: true, with_ee: %i[team_planner_view] do +RSpec.describe 'Team planner index', js: true, with_ee: %i[team_planner_view] do include_context 'with team planner full access' let(:current_user) { user } diff --git a/modules/team_planner/spec/features/team_planner_menu_spec.rb b/modules/team_planner/spec/features/team_planner_menu_spec.rb index 3ae87c10aef..8977072da21 100644 --- a/modules/team_planner/spec/features/team_planner_menu_spec.rb +++ b/modules/team_planner/spec/features/team_planner_menu_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Team planner sidemenu', js: true do +RSpec.describe 'Team planner sidemenu', js: true do shared_let(:project) do create(:project, enabled_module_names: %w[work_package_tracking team_planner_view]) end diff --git a/modules/team_planner/spec/features/team_planner_project_include_spec.rb b/modules/team_planner/spec/features/team_planner_project_include_spec.rb index a95bf71160f..f46f511eb8b 100644 --- a/modules/team_planner/spec/features/team_planner_project_include_spec.rb +++ b/modules/team_planner/spec/features/team_planner_project_include_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'features/work_packages/project_include/project_include_shared_examples' require_relative '../support/pages/team_planner' -describe 'Team planner project include', js: true, with_ee: %i[team_planner_view] do +RSpec.describe 'Team planner project include', js: true, with_ee: %i[team_planner_view] do shared_let(:enabled_modules) { %w[work_package_tracking team_planner_view] } shared_let(:permissions) do %w[view_work_packages edit_work_packages add_work_packages diff --git a/modules/team_planner/spec/features/team_planner_remove_event_spec.rb b/modules/team_planner/spec/features/team_planner_remove_event_spec.rb index 78fa27f7629..81943837f89 100644 --- a/modules/team_planner/spec/features/team_planner_remove_event_spec.rb +++ b/modules/team_planner/spec/features/team_planner_remove_event_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './shared_context' require_relative '../support/components/add_existing_pane' -describe 'Team planner remove event', js: true, with_ee: %i[team_planner_view] do +RSpec.describe 'Team planner remove event', js: true, with_ee: %i[team_planner_view] do include_context 'with team planner full access' let!(:viewer_role) { create(:existing_role, permissions: [:view_work_packages]) } diff --git a/modules/team_planner/spec/features/team_planner_spec.rb b/modules/team_planner/spec/features/team_planner_spec.rb index 664a14fa2ad..d3d15e379c9 100644 --- a/modules/team_planner/spec/features/team_planner_spec.rb +++ b/modules/team_planner/spec/features/team_planner_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_context' -describe 'Team planner', js: true, with_ee: %i[team_planner_view] do +RSpec.describe 'Team planner', js: true, with_ee: %i[team_planner_view] do include_context 'with team planner full access' it 'hides the internally used filters' do diff --git a/modules/team_planner/spec/features/team_planner_split_view_spec.rb b/modules/team_planner/spec/features/team_planner_split_view_spec.rb index 0a3c78f72ae..fd75cb7721e 100644 --- a/modules/team_planner/spec/features/team_planner_split_view_spec.rb +++ b/modules/team_planner/spec/features/team_planner_split_view_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_context' -describe 'Team planner split view navigation', js: true, with_ee: %i[team_planner_view] do +RSpec.describe 'Team planner split view navigation', js: true, with_ee: %i[team_planner_view] do include_context 'with team planner full access' let!(:view) { create(:view_team_planner, query:) } diff --git a/modules/team_planner/spec/features/team_planner_subproject_constraints_spec.rb b/modules/team_planner/spec/features/team_planner_subproject_constraints_spec.rb index 84e99f64786..dd782fab7aa 100644 --- a/modules/team_planner/spec/features/team_planner_subproject_constraints_spec.rb +++ b/modules/team_planner/spec/features/team_planner_subproject_constraints_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_context' -describe 'Team planner constraints for a subproject', js: true, with_ee: %i[team_planner_view] do +RSpec.describe 'Team planner constraints for a subproject', js: true, with_ee: %i[team_planner_view] do include_context 'with team planner full access' let!(:other_user) do diff --git a/modules/team_planner/spec/features/team_planner_upsale_spec.rb b/modules/team_planner/spec/features/team_planner_upsale_spec.rb index 3b1d9cddf34..8d38e56ac48 100644 --- a/modules/team_planner/spec/features/team_planner_upsale_spec.rb +++ b/modules/team_planner/spec/features/team_planner_upsale_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_context' -describe 'Team planner index', js: true do +RSpec.describe 'Team planner index', js: true do include_context 'with team planner full access' let(:current_user) { user } diff --git a/modules/team_planner/spec/features/team_planner_user_interaction_spec.rb b/modules/team_planner/spec/features/team_planner_user_interaction_spec.rb index 11bc0455d2b..8df43bf8758 100644 --- a/modules/team_planner/spec/features/team_planner_user_interaction_spec.rb +++ b/modules/team_planner/spec/features/team_planner_user_interaction_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_context' -describe 'Team planner drag&dop and resizing', js: true, with_ee: %i[team_planner_view] do +RSpec.describe 'Team planner drag&dop and resizing', js: true, with_ee: %i[team_planner_view] do include_context 'with team planner full access' let!(:other_user) do diff --git a/modules/team_planner/spec/features/team_planner_view_modes_spec.rb b/modules/team_planner/spec/features/team_planner_view_modes_spec.rb index 67495da63d2..df9b43e9e37 100644 --- a/modules/team_planner/spec/features/team_planner_view_modes_spec.rb +++ b/modules/team_planner/spec/features/team_planner_view_modes_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_context' -describe 'Team planner', js: true, with_ee: %i[team_planner_view] do +RSpec.describe 'Team planner', js: true, with_ee: %i[team_planner_view] do include_context 'with team planner full access' it 'allows switching of view modes', with_settings: { working_days: [1, 2, 3, 4, 5] } do diff --git a/modules/team_planner/spec/permissions/view_team_planner_spec.rb b/modules/team_planner/spec/permissions/view_team_planner_spec.rb index 9cc1043b0de..d1b978b724c 100644 --- a/modules/team_planner/spec/permissions/view_team_planner_spec.rb +++ b/modules/team_planner/spec/permissions/view_team_planner_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'support/permission_specs' -describe TeamPlanner::TeamPlannerController, 'view_team_planner permission', type: :controller do +RSpec.describe TeamPlanner::TeamPlannerController, 'view_team_planner permission', type: :controller do include PermissionSpecs check_permission_required_for('team_planner/team_planner#index', :view_team_planner) diff --git a/modules/team_planner/spec/requests/api/v3/views/create_resource_spec.rb b/modules/team_planner/spec/requests/api/v3/views/create_resource_spec.rb index 14956b6831b..6e005ebfd7c 100644 --- a/modules/team_planner/spec/requests/api/v3/views/create_resource_spec.rb +++ b/modules/team_planner/spec/requests/api/v3/views/create_resource_spec.rb @@ -27,9 +27,9 @@ require 'spec_helper' -describe API::V3::Views::ViewsAPI, - 'create', - content_type: :json do +RSpec.describe API::V3::Views::ViewsAPI, + 'create', + content_type: :json do include API::V3::Utilities::PathHelper shared_let(:permitted_user) { create(:user) } diff --git a/modules/team_planner/spec/routing/team_planner_routing_spec.rb b/modules/team_planner/spec/routing/team_planner_routing_spec.rb index c4ebf3eeef3..ab150a5313e 100644 --- a/modules/team_planner/spec/routing/team_planner_routing_spec.rb +++ b/modules/team_planner/spec/routing/team_planner_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Team planner routing' do +RSpec.describe 'Team planner routing' do it 'routes to team_planner#index' do expect(subject) .to route(:get, '/projects/foobar/team_planners') diff --git a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_shared_examples.rb b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_shared_examples.rb index 3f1005ea37d..cb6ea2cefd6 100644 --- a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_shared_examples.rb +++ b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_shared_examples.rb @@ -1,6 +1,6 @@ require_relative '../../spec_helper' -shared_examples 'immediate success login' do +RSpec.shared_examples 'immediate success login' do context 'with valid credentials' do it "does not yet log in user" do expect(User.current).not_to eq(user) @@ -16,7 +16,7 @@ shared_examples 'immediate success login' do end end -shared_examples '2FA forced registry' do +RSpec.shared_examples '2FA forced registry' do it "does not log in user" do expect(User.current).not_to eq(user) end @@ -35,7 +35,7 @@ shared_examples '2FA forced registry' do end end -shared_examples '2FA response failure' do |expected_error| +RSpec.shared_examples '2FA response failure' do |expected_error| it "does not log in user" do expect(User.current).not_to eq(user) end @@ -50,7 +50,7 @@ shared_examples '2FA response failure' do |expected_error| end end -shared_examples '2FA login request failure' do |expected_error| +RSpec.shared_examples '2FA login request failure' do |expected_error| before do session[:authenticated_user_id] = user.id get :request_otp @@ -59,7 +59,7 @@ shared_examples '2FA login request failure' do |expected_error| it_behaves_like '2FA response failure', expected_error end -shared_examples '2FA credentials authentication success' do +RSpec.shared_examples '2FA credentials authentication success' do describe 'requesting the token' do before do session[:authenticated_user_id] = user.id @@ -80,7 +80,7 @@ shared_examples '2FA credentials authentication success' do end end -shared_examples '2FA login_otp fails without authenticated user' do +RSpec.shared_examples '2FA login_otp fails without authenticated user' do describe 'follow-up post of the login token without authenticated user' do before do # Assume the user is NOT pending @@ -98,7 +98,7 @@ shared_examples '2FA login_otp fails without authenticated user' do end end -shared_examples '2FA TOTP request success' do +RSpec.shared_examples '2FA TOTP request success' do # 1FA redirects to login_otp it_behaves_like '2FA credentials authentication success' @@ -128,7 +128,7 @@ shared_examples '2FA TOTP request success' do end end -shared_examples '2FA SMS request success' do +RSpec.shared_examples '2FA SMS request success' do # 1FA redirects to login_otp it_behaves_like '2FA credentials authentication success' diff --git a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_spec.rb b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_spec.rb index 10c81305490..45b439fddf9 100644 --- a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_spec.rb +++ b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/authentication_controller_spec.rb @@ -1,7 +1,7 @@ require_relative '../../spec_helper' require_relative './authentication_controller_shared_examples' -describe TwoFactorAuthentication::AuthenticationController, with_settings: { login_required?: true } do +RSpec.describe TwoFactorAuthentication::AuthenticationController, with_settings: { login_required?: true } do let(:valid_credentials) do { username: 'foobar', password: 'AAA1111!!!!' } end diff --git a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/forced_registration/two_factor_devices_controller_spec.rb b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/forced_registration/two_factor_devices_controller_spec.rb index 84624f6e9c0..da243fc8bfe 100644 --- a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/forced_registration/two_factor_devices_controller_spec.rb +++ b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/forced_registration/two_factor_devices_controller_spec.rb @@ -1,7 +1,7 @@ require_relative '../../../spec_helper' require_relative './../authentication_controller_shared_examples' -describe TwoFactorAuthentication::ForcedRegistration::TwoFactorDevicesController do +RSpec.describe TwoFactorAuthentication::ForcedRegistration::TwoFactorDevicesController do let(:user) { create(:user, login: 'foobar') } let(:logged_in_user) { User.anonymous } let(:active_strategies) { [] } diff --git a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/remember_cookie_controller_spec.rb b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/remember_cookie_controller_spec.rb index 656dbcabf7f..2501f3256c9 100644 --- a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/remember_cookie_controller_spec.rb +++ b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/remember_cookie_controller_spec.rb @@ -1,7 +1,7 @@ require_relative '../../../spec_helper' require_relative './../authentication_controller_shared_examples' -describe TwoFactorAuthentication::My::RememberCookieController do +RSpec.describe TwoFactorAuthentication::My::RememberCookieController do let(:user) { create(:user, login: 'foobar') } let(:logged_in_user) { user } diff --git a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/two_factor_devices_controller_spec.rb b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/two_factor_devices_controller_spec.rb index bab9fbc6748..09b463c8d99 100644 --- a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/two_factor_devices_controller_spec.rb +++ b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/my/two_factor_devices_controller_spec.rb @@ -1,7 +1,7 @@ require_relative '../../../spec_helper' require_relative './../authentication_controller_shared_examples' -describe TwoFactorAuthentication::My::TwoFactorDevicesController do +RSpec.describe TwoFactorAuthentication::My::TwoFactorDevicesController do let(:user) { create(:user, login: 'foobar') } let(:other_user) { create(:user) } let(:logged_in_user) { user } diff --git a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/users/two_factor_devices_controller_spec.rb b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/users/two_factor_devices_controller_spec.rb index bca221bc385..abca0305a7d 100644 --- a/modules/two_factor_authentication/spec/controllers/two_factor_authentication/users/two_factor_devices_controller_spec.rb +++ b/modules/two_factor_authentication/spec/controllers/two_factor_authentication/users/two_factor_devices_controller_spec.rb @@ -1,7 +1,7 @@ require_relative '../../../spec_helper' require_relative './../authentication_controller_shared_examples' -describe TwoFactorAuthentication::Users::TwoFactorDevicesController do +RSpec.describe TwoFactorAuthentication::Users::TwoFactorDevicesController do let(:admin) { create(:admin) } let(:user) { create(:user, login: 'foobar') } let(:other_user) { create(:user) } diff --git a/modules/two_factor_authentication/spec/features/account_activation_spec.rb b/modules/two_factor_authentication/spec/features/account_activation_spec.rb index 230589d74a3..0b570b723f6 100644 --- a/modules/two_factor_authentication/spec/features/account_activation_spec.rb +++ b/modules/two_factor_authentication/spec/features/account_activation_spec.rb @@ -1,11 +1,11 @@ require_relative '../spec_helper' require_relative './shared_2fa_examples' -describe 'activating an invited account', - js: true, - with_settings: { - plugin_openproject_two_factor_authentication: { 'active_strategies' => [:developer] } - } do +RSpec.describe 'activating an invited account', + js: true, + with_settings: { + plugin_openproject_two_factor_authentication: { 'active_strategies' => [:developer] } + } do let(:user) do user = build(:user, first_login: true) UserInvitation.invite_user! user diff --git a/modules/two_factor_authentication/spec/features/admin_edit_two_factor_devices_spec.rb b/modules/two_factor_authentication/spec/features/admin_edit_two_factor_devices_spec.rb index 0390e360a0f..5ea672922a0 100644 --- a/modules/two_factor_authentication/spec/features/admin_edit_two_factor_devices_spec.rb +++ b/modules/two_factor_authentication/spec/features/admin_edit_two_factor_devices_spec.rb @@ -1,9 +1,9 @@ require_relative '../spec_helper' -describe 'Admin 2FA management', - js: true, with_settings: { - plugin_openproject_two_factor_authentication: { 'active_strategies' => %i[developer totp] } - } do +RSpec.describe 'Admin 2FA management', + js: true, with_settings: { + plugin_openproject_two_factor_authentication: { 'active_strategies' => %i[developer totp] } + } do let(:dialog) { Components::PasswordConfirmationDialog.new } let(:user_password) { 'admin!' * 4 } let(:other_user) { create(:user, login: 'bob') } diff --git a/modules/two_factor_authentication/spec/features/backup_codes/generate_backup_codes_spec.rb b/modules/two_factor_authentication/spec/features/backup_codes/generate_backup_codes_spec.rb index c1a6957a06b..5e6465c1b94 100644 --- a/modules/two_factor_authentication/spec/features/backup_codes/generate_backup_codes_spec.rb +++ b/modules/two_factor_authentication/spec/features/backup_codes/generate_backup_codes_spec.rb @@ -1,7 +1,7 @@ require_relative '../../spec_helper' require_relative '../shared_2fa_examples' -describe 'Generate 2FA backup codes', js: true, with_config: { '2fa': { active_strategies: [:developer] } } do +RSpec.describe 'Generate 2FA backup codes', js: true, with_config: { '2fa': { active_strategies: [:developer] } } do let(:user_password) { 'bob!' * 4 } let(:user) do create(:user, diff --git a/modules/two_factor_authentication/spec/features/backup_codes/login_with_backup_code_spec.rb b/modules/two_factor_authentication/spec/features/backup_codes/login_with_backup_code_spec.rb index 3ebcd043025..89c514e571f 100644 --- a/modules/two_factor_authentication/spec/features/backup_codes/login_with_backup_code_spec.rb +++ b/modules/two_factor_authentication/spec/features/backup_codes/login_with_backup_code_spec.rb @@ -1,7 +1,7 @@ require_relative '../../spec_helper' require_relative '../shared_2fa_examples' -describe 'Login with 2FA backup code', js: true, with_settings: { +RSpec.describe 'Login with 2FA backup code', js: true, with_settings: { plugin_openproject_two_factor_authentication: { 'active_strategies' => [:developer] } } do let(:user_password) { 'bob!' * 4 } diff --git a/modules/two_factor_authentication/spec/features/login/login_enforced_2fa_spec.rb b/modules/two_factor_authentication/spec/features/login/login_enforced_2fa_spec.rb index 54f03635e02..bf7cb570f79 100644 --- a/modules/two_factor_authentication/spec/features/login/login_enforced_2fa_spec.rb +++ b/modules/two_factor_authentication/spec/features/login/login_enforced_2fa_spec.rb @@ -1,13 +1,13 @@ require_relative '../../spec_helper' require_relative '../shared_2fa_examples' -describe 'Login with enforced 2FA', - js: true, with_settings: { - plugin_openproject_two_factor_authentication: { - 'active_strategies' => [:developer], - 'enforced' => true - } - } do +RSpec.describe 'Login with enforced 2FA', + js: true, with_settings: { + plugin_openproject_two_factor_authentication: { + 'active_strategies' => [:developer], + 'enforced' => true + } + } do let(:user_password) { 'bob!' * 4 } let(:user) do create(:user, diff --git a/modules/two_factor_authentication/spec/features/login/login_with_2fa_spec.rb b/modules/two_factor_authentication/spec/features/login/login_with_2fa_spec.rb index ef07b0dc412..81e6b38f6fc 100644 --- a/modules/two_factor_authentication/spec/features/login/login_with_2fa_spec.rb +++ b/modules/two_factor_authentication/spec/features/login/login_with_2fa_spec.rb @@ -1,12 +1,12 @@ require_relative '../../spec_helper' require_relative '../shared_2fa_examples' -describe 'Login with 2FA device', - js: true, with_settings: { - plugin_openproject_two_factor_authentication: { - 'active_strategies' => [:developer] - } - } do +RSpec.describe 'Login with 2FA device', + js: true, with_settings: { + plugin_openproject_two_factor_authentication: { + 'active_strategies' => [:developer] + } + } do let(:user_password) { 'bob!' * 4 } let(:user) do create(:user, diff --git a/modules/two_factor_authentication/spec/features/login/login_without_2fa_spec.rb b/modules/two_factor_authentication/spec/features/login/login_without_2fa_spec.rb index a9a7ac485e0..6b1acc6851a 100644 --- a/modules/two_factor_authentication/spec/features/login/login_without_2fa_spec.rb +++ b/modules/two_factor_authentication/spec/features/login/login_without_2fa_spec.rb @@ -1,7 +1,7 @@ require_relative '../../spec_helper' require_relative '../shared_2fa_examples' -describe 'Login with no required OTP', js: true, with_config: { '2fa': { active_strategies: [:developer] } } do +RSpec.describe 'Login with no required OTP', js: true, with_config: { '2fa': { active_strategies: [:developer] } } do let(:user_password) { 'bob!' * 4 } let(:user) do create(:user, diff --git a/modules/two_factor_authentication/spec/features/login/switch_available_devices_spec.rb b/modules/two_factor_authentication/spec/features/login/switch_available_devices_spec.rb index 937e5f251c8..98e8a290a62 100644 --- a/modules/two_factor_authentication/spec/features/login/switch_available_devices_spec.rb +++ b/modules/two_factor_authentication/spec/features/login/switch_available_devices_spec.rb @@ -1,10 +1,10 @@ require_relative '../../spec_helper' require_relative '../shared_2fa_examples' -describe 'Login by switching 2FA device', - js: true, with_settings: { - plugin_openproject_two_factor_authentication: { 'active_strategies' => %i[developer totp] } - } do +RSpec.describe 'Login by switching 2FA device', + js: true, with_settings: { + plugin_openproject_two_factor_authentication: { 'active_strategies' => %i[developer totp] } + } do let(:user_password) { 'bob!' * 4 } let(:user) do create(:user, diff --git a/modules/two_factor_authentication/spec/features/my_two_factor_devices_spec.rb b/modules/two_factor_authentication/spec/features/my_two_factor_devices_spec.rb index 41a0f65af6f..14674510589 100644 --- a/modules/two_factor_authentication/spec/features/my_two_factor_devices_spec.rb +++ b/modules/two_factor_authentication/spec/features/my_two_factor_devices_spec.rb @@ -1,9 +1,9 @@ require_relative '../spec_helper' -describe 'My Account 2FA configuration', - js: true, with_settings: { - plugin_openproject_two_factor_authentication: { 'active_strategies' => %i[developer totp] } - } do +RSpec.describe 'My Account 2FA configuration', + js: true, with_settings: { + plugin_openproject_two_factor_authentication: { 'active_strategies' => %i[developer totp] } + } do let(:dialog) { Components::PasswordConfirmationDialog.new } let(:user_password) { 'boB!4' * 4 } let(:user) do diff --git a/modules/two_factor_authentication/spec/features/password_change_spec.rb b/modules/two_factor_authentication/spec/features/password_change_spec.rb index 809d92b0c4d..89a4ccf050d 100644 --- a/modules/two_factor_authentication/spec/features/password_change_spec.rb +++ b/modules/two_factor_authentication/spec/features/password_change_spec.rb @@ -1,11 +1,11 @@ require_relative '../spec_helper' -describe 'Password change with OTP', - js: true, with_settings: { - plugin_openproject_two_factor_authentication: { - 'active_strategies' => [:developer] - } - } do +RSpec.describe 'Password change with OTP', + js: true, with_settings: { + plugin_openproject_two_factor_authentication: { + 'active_strategies' => [:developer] + } + } do let(:user_password) { 'boB&' * 4 } let(:new_user_password) { '%obB' * 4 } let(:user) do diff --git a/modules/two_factor_authentication/spec/features/remember_cookie/login_with_remember_cookie_spec.rb b/modules/two_factor_authentication/spec/features/remember_cookie/login_with_remember_cookie_spec.rb index 89de082bc08..70d91e1f8bd 100644 --- a/modules/two_factor_authentication/spec/features/remember_cookie/login_with_remember_cookie_spec.rb +++ b/modules/two_factor_authentication/spec/features/remember_cookie/login_with_remember_cookie_spec.rb @@ -1,13 +1,13 @@ require_relative '../../spec_helper' require_relative '../shared_2fa_examples' -describe 'Login with 2FA remember cookie', - js: true, with_settings: { - plugin_openproject_two_factor_authentication: { - active_strategies: [:developer], - allow_remember_for_days: 30 - } - } do +RSpec.describe 'Login with 2FA remember cookie', + js: true, with_settings: { + plugin_openproject_two_factor_authentication: { + active_strategies: [:developer], + allow_remember_for_days: 30 + } + } do let(:user_password) do "user!user!" end diff --git a/modules/two_factor_authentication/spec/features/shared_2fa_examples.rb b/modules/two_factor_authentication/spec/features/shared_2fa_examples.rb index 1ac82d8fb9c..1753fd250ff 100644 --- a/modules/two_factor_authentication/spec/features/shared_2fa_examples.rb +++ b/modules/two_factor_authentication/spec/features/shared_2fa_examples.rb @@ -26,14 +26,14 @@ def expect_not_logged_in expect(page).not_to have_selector('.form--field-container', text: user.login) end -shared_examples 'login without 2FA' do +RSpec.shared_examples 'login without 2FA' do it 'logs in the user without any active devices' do first_login_step expect_logged_in end end -shared_examples 'create enforced sms device' do +RSpec.shared_examples 'create enforced sms device' do it do expect(page).to have_selector('.flash.info', text: I18n.t('two_factor_authentication.forced_registration.required_to_add_device')) diff --git a/modules/two_factor_authentication/spec/lib/token_strategies/message_bird_spec.rb b/modules/two_factor_authentication/spec/lib/token_strategies/message_bird_spec.rb index 16bd5ca1c62..6c49196a182 100644 --- a/modules/two_factor_authentication/spec/lib/token_strategies/message_bird_spec.rb +++ b/modules/two_factor_authentication/spec/lib/token_strategies/message_bird_spec.rb @@ -1,7 +1,7 @@ require_relative '../../spec_helper' require 'messagebird' -describe OpenProject::TwoFactorAuthentication::TokenStrategy::MessageBird do +RSpec.describe OpenProject::TwoFactorAuthentication::TokenStrategy::MessageBird do let(:channel) { :sms } let(:locale) { 'en' } let(:user) { create(:user, language: locale) } diff --git a/modules/two_factor_authentication/spec/lib/token_strategy_manager_spec.rb b/modules/two_factor_authentication/spec/lib/token_strategy_manager_spec.rb index d12523c6516..4e948f49167 100644 --- a/modules/two_factor_authentication/spec/lib/token_strategy_manager_spec.rb +++ b/modules/two_factor_authentication/spec/lib/token_strategy_manager_spec.rb @@ -1,6 +1,6 @@ require_relative '../spec_helper' -describe OpenProject::TwoFactorAuthentication::TokenStrategyManager do +RSpec.describe OpenProject::TwoFactorAuthentication::TokenStrategyManager do let(:dev_strategy) { OpenProject::TwoFactorAuthentication::TokenStrategy::Developer } let(:totp_strategy) { OpenProject::TwoFactorAuthentication::TokenStrategy::Totp } let(:configuration) do diff --git a/modules/two_factor_authentication/spec/models/devices/default_device_spec.rb b/modules/two_factor_authentication/spec/models/devices/default_device_spec.rb index 97610bf954e..14cf614d04c 100644 --- a/modules/two_factor_authentication/spec/models/devices/default_device_spec.rb +++ b/modules/two_factor_authentication/spec/models/devices/default_device_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Default device' do +RSpec.describe 'Default device' do let(:user) { create(:user) } let(:other_otp) { build(:two_factor_authentication_device_totp, user:, default: true) } diff --git a/modules/two_factor_authentication/spec/models/devices/totp_spec.rb b/modules/two_factor_authentication/spec/models/devices/totp_spec.rb index ab912a694a8..2b7c87ad5d2 100644 --- a/modules/two_factor_authentication/spec/models/devices/totp_spec.rb +++ b/modules/two_factor_authentication/spec/models/devices/totp_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require 'timecop' -describe TwoFactorAuthentication::Device::Totp do +RSpec.describe TwoFactorAuthentication::Device::Totp do let(:user) { create(:user) } let(:channel) { :totp } diff --git a/modules/two_factor_authentication/spec/models/login_token_spec.rb b/modules/two_factor_authentication/spec/models/login_token_spec.rb index 485b03e585c..a13e74cb045 100644 --- a/modules/two_factor_authentication/spec/models/login_token_spec.rb +++ b/modules/two_factor_authentication/spec/models/login_token_spec.rb @@ -1,6 +1,6 @@ require_relative '../spec_helper' -describe TwoFactorAuthentication::LoginToken, with_2fa_ee: true do +RSpec.describe TwoFactorAuthentication::LoginToken, with_2fa_ee: true do shared_let(:user) { create(:user) } let!(:token) { described_class.new user: } diff --git a/modules/two_factor_authentication/spec/models/user_spec.rb b/modules/two_factor_authentication/spec/models/user_spec.rb index 70d7ff0dbd6..d6a15efa574 100644 --- a/modules/two_factor_authentication/spec/models/user_spec.rb +++ b/modules/two_factor_authentication/spec/models/user_spec.rb @@ -2,7 +2,7 @@ require_relative '../spec_helper' module OpenProject::TwoFactorAuthentication::Patches module UserSpec - describe User do + RSpec.describe User do def create_user(auth_source_id = nil) @user = build(:user) @username = @user.login diff --git a/modules/two_factor_authentication/spec/routing/two_factor_authentication/my/two_factor_devices_spec.rb b/modules/two_factor_authentication/spec/routing/two_factor_authentication/my/two_factor_devices_spec.rb index 41dee82526d..d2af75cadc5 100644 --- a/modules/two_factor_authentication/spec/routing/two_factor_authentication/my/two_factor_devices_spec.rb +++ b/modules/two_factor_authentication/spec/routing/two_factor_authentication/my/two_factor_devices_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'users 2fa devices' do +RSpec.describe 'users 2fa devices' do it 'route to index' do expect(get('/my/two_factor_devices')).to route_to('two_factor_authentication/my/two_factor_devices#index') end diff --git a/modules/two_factor_authentication/spec/routing/two_factor_authentication/users/two_factor_devices_spec.rb b/modules/two_factor_authentication/spec/routing/two_factor_authentication/users/two_factor_devices_spec.rb index 4f21e742698..5c2db765376 100644 --- a/modules/two_factor_authentication/spec/routing/two_factor_authentication/users/two_factor_devices_spec.rb +++ b/modules/two_factor_authentication/spec/routing/two_factor_authentication/users/two_factor_devices_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'users 2fa devices' do +RSpec.describe 'users 2fa devices' do it 'route to GET new' do expect(get('/users/2/two_factor_devices/new')).to route_to(controller: 'two_factor_authentication/users/two_factor_devices', action: 'new', diff --git a/modules/two_factor_authentication/spec/services/token_delivery/message_bird_spec.rb b/modules/two_factor_authentication/spec/services/token_delivery/message_bird_spec.rb index 753a33d3ccd..6093eae370e 100644 --- a/modules/two_factor_authentication/spec/services/token_delivery/message_bird_spec.rb +++ b/modules/two_factor_authentication/spec/services/token_delivery/message_bird_spec.rb @@ -1,7 +1,7 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper') require 'messagebird' -describe OpenProject::TwoFactorAuthentication::TokenStrategy::MessageBird do +RSpec.describe OpenProject::TwoFactorAuthentication::TokenStrategy::MessageBird do describe 'sending messages' do let!(:user) { create(:user, language: locale) } let!(:locale) { 'en' } diff --git a/modules/two_factor_authentication/spec/services/token_delivery/sns_spec.rb b/modules/two_factor_authentication/spec/services/token_delivery/sns_spec.rb index 44094201004..1480d90be35 100644 --- a/modules/two_factor_authentication/spec/services/token_delivery/sns_spec.rb +++ b/modules/two_factor_authentication/spec/services/token_delivery/sns_spec.rb @@ -1,6 +1,6 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper') -describe OpenProject::TwoFactorAuthentication::TokenStrategy::Sns do +RSpec.describe OpenProject::TwoFactorAuthentication::TokenStrategy::Sns do describe 'sending messages' do let(:phone) { '+49 123456789' } let!(:user) { create(:user) } diff --git a/modules/two_factor_authentication/spec/services/token_delivery/totp_spec.rb b/modules/two_factor_authentication/spec/services/token_delivery/totp_spec.rb index a6767cf173f..b8718c58f82 100644 --- a/modules/two_factor_authentication/spec/services/token_delivery/totp_spec.rb +++ b/modules/two_factor_authentication/spec/services/token_delivery/totp_spec.rb @@ -1,6 +1,6 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper') -describe OpenProject::TwoFactorAuthentication::TokenStrategy::Totp do +RSpec.describe OpenProject::TwoFactorAuthentication::TokenStrategy::Totp do describe 'sending messages' do let!(:user) { create(:user) } let!(:device) { create(:two_factor_authentication_device_totp, user:, default: true) } diff --git a/modules/two_factor_authentication/spec/services/token_service_spec.rb b/modules/two_factor_authentication/spec/services/token_service_spec.rb index 1bfbbb23887..067f86dcc61 100644 --- a/modules/two_factor_authentication/spec/services/token_service_spec.rb +++ b/modules/two_factor_authentication/spec/services/token_service_spec.rb @@ -1,6 +1,6 @@ require_relative '../spec_helper' -describe TwoFactorAuthentication::TokenService do +RSpec.describe TwoFactorAuthentication::TokenService do describe 'sending messages' do let(:user) { create(:user) } let(:dev_strategy) { OpenProject::TwoFactorAuthentication::TokenStrategy::Developer } diff --git a/modules/webhooks/spec/components/webhooks/outgoing/deliveries/table_component_spec.rb b/modules/webhooks/spec/components/webhooks/outgoing/deliveries/table_component_spec.rb index 3d61377f275..b27afe366f6 100644 --- a/modules/webhooks/spec/components/webhooks/outgoing/deliveries/table_component_spec.rb +++ b/modules/webhooks/spec/components/webhooks/outgoing/deliveries/table_component_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe Webhooks::Outgoing::Deliveries::TableComponent, type: :component do +RSpec.describe Webhooks::Outgoing::Deliveries::TableComponent, type: :component do it 'escapes response body html' do delivery = create(:webhook_log, response_body: 'Hello world!') render_inline described_class.new(rows: [delivery]) diff --git a/modules/webhooks/spec/controllers/outgoing/admin_controller_spec.rb b/modules/webhooks/spec/controllers/outgoing/admin_controller_spec.rb index 212cd8eb105..55d98ba5796 100644 --- a/modules/webhooks/spec/controllers/outgoing/admin_controller_spec.rb +++ b/modules/webhooks/spec/controllers/outgoing/admin_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Webhooks::Outgoing::AdminController do +RSpec.describe Webhooks::Outgoing::AdminController do let(:user) { build_stubbed(:admin) } before do diff --git a/modules/webhooks/spec/controllers/webhooks_controller_spec.rb b/modules/webhooks/spec/controllers/webhooks_controller_spec.rb index b0cbdc98e47..5c1f7aa5999 100644 --- a/modules/webhooks/spec/controllers/webhooks_controller_spec.rb +++ b/modules/webhooks/spec/controllers/webhooks_controller_spec.rb @@ -28,7 +28,7 @@ require File.expand_path('../spec_helper', __dir__) -describe Webhooks::Incoming::HooksController do +RSpec.describe Webhooks::Incoming::HooksController do let(:hook) { double(OpenProject::Webhooks::Hook) } let(:user) { double(User).as_null_object } diff --git a/modules/webhooks/spec/features/manage_webhooks_spec.rb b/modules/webhooks/spec/features/manage_webhooks_spec.rb index f595910247b..b462a14ff3a 100644 --- a/modules/webhooks/spec/features/manage_webhooks_spec.rb +++ b/modules/webhooks/spec/features/manage_webhooks_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Manage webhooks through UI', js: true do +RSpec.describe 'Manage webhooks through UI', js: true do before do login_as user end diff --git a/modules/webhooks/spec/lib/hook_spec.rb b/modules/webhooks/spec/lib/hook_spec.rb index b0474cad81b..5c38551511f 100644 --- a/modules/webhooks/spec/lib/hook_spec.rb +++ b/modules/webhooks/spec/lib/hook_spec.rb @@ -28,7 +28,7 @@ require File.expand_path('../spec_helper', __dir__) -describe OpenProject::Webhooks::Hook do +RSpec.describe OpenProject::Webhooks::Hook do describe '#relative_url' do let(:hook) { OpenProject::Webhooks::Hook.new('myhook') } diff --git a/modules/webhooks/spec/lib/webhooks_spec.rb b/modules/webhooks/spec/lib/webhooks_spec.rb index d149818d338..716d98b892a 100644 --- a/modules/webhooks/spec/lib/webhooks_spec.rb +++ b/modules/webhooks/spec/lib/webhooks_spec.rb @@ -28,7 +28,7 @@ require File.expand_path('../spec_helper', __dir__) -describe OpenProject::Webhooks do +RSpec.describe OpenProject::Webhooks do describe '.register_hook' do after do OpenProject::Webhooks.unregister_hook('testhook1') diff --git a/modules/webhooks/spec/models/webhook_spec.rb b/modules/webhooks/spec/models/webhook_spec.rb index cf80e52627c..04e95c8f090 100644 --- a/modules/webhooks/spec/models/webhook_spec.rb +++ b/modules/webhooks/spec/models/webhook_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Webhooks::Webhook do +RSpec.describe Webhooks::Webhook do subject { build(:webhook) } describe 'attributes' do diff --git a/modules/webhooks/spec/routing/webhooks/outgoing/admin_controller_spec.rb b/modules/webhooks/spec/routing/webhooks/outgoing/admin_controller_spec.rb index daebee52db9..dee63e420f8 100644 --- a/modules/webhooks/spec/routing/webhooks/outgoing/admin_controller_spec.rb +++ b/modules/webhooks/spec/routing/webhooks/outgoing/admin_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Outgoing webhooks administration' do +RSpec.describe 'Outgoing webhooks administration' do it 'route to index' do expect(get('/admin/settings/webhooks')).to route_to('webhooks/outgoing/admin#index') end diff --git a/modules/webhooks/spec/workers/attachment_webhook_job_spec.rb b/modules/webhooks/spec/workers/attachment_webhook_job_spec.rb index 0032b84b228..f0a0e7eb172 100644 --- a/modules/webhooks/spec/workers/attachment_webhook_job_spec.rb +++ b/modules/webhooks/spec/workers/attachment_webhook_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe AttachmentWebhookJob, type: :job, webmock: true do +RSpec.describe AttachmentWebhookJob, type: :job, webmock: true do shared_let(:user) { create(:admin) } shared_let(:request_url) { "http://example.net/test/42" } shared_let(:project) { create(:project, name: 'Foo Bar') } diff --git a/modules/webhooks/spec/workers/project_webhook_job_spec.rb b/modules/webhooks/spec/workers/project_webhook_job_spec.rb index 1e07e32902d..6811d30f576 100644 --- a/modules/webhooks/spec/workers/project_webhook_job_spec.rb +++ b/modules/webhooks/spec/workers/project_webhook_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ProjectWebhookJob, type: :job, webmock: true do +RSpec.describe ProjectWebhookJob, type: :job, webmock: true do shared_let(:user) { create(:admin) } shared_let(:request_url) { "http://example.net/test/42" } shared_let(:project) { create(:project, name: 'Foo Bar') } diff --git a/modules/webhooks/spec/workers/time_entry_webhook_job_spec.rb b/modules/webhooks/spec/workers/time_entry_webhook_job_spec.rb index 11d24f8532e..38478ddfbba 100644 --- a/modules/webhooks/spec/workers/time_entry_webhook_job_spec.rb +++ b/modules/webhooks/spec/workers/time_entry_webhook_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe TimeEntryWebhookJob, type: :job, webmock: true do +RSpec.describe TimeEntryWebhookJob, type: :job, webmock: true do shared_let(:user) { create(:admin) } shared_let(:request_url) { "http://example.net/test/42" } shared_let(:time_entry) { create(:time_entry, hours: 10) } diff --git a/modules/webhooks/spec/workers/work_package_webhook_job_spec.rb b/modules/webhooks/spec/workers/work_package_webhook_job_spec.rb index 5db29794fc4..7fa4e40c8e2 100644 --- a/modules/webhooks/spec/workers/work_package_webhook_job_spec.rb +++ b/modules/webhooks/spec/workers/work_package_webhook_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackageWebhookJob, type: :model, webmock: true do +RSpec.describe WorkPackageWebhookJob, type: :model, webmock: true do shared_let(:user) { create(:admin) } shared_let(:title) { "Some workpackage subject" } shared_let(:request_url) { "http://example.net/test/42" } diff --git a/modules/xls_export/spec/lib/custom_field_xls_export_spec.rb b/modules/xls_export/spec/lib/custom_field_xls_export_spec.rb index e6a4d452d69..495f3da7b08 100644 --- a/modules/xls_export/spec/lib/custom_field_xls_export_spec.rb +++ b/modules/xls_export/spec/lib/custom_field_xls_export_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require 'spreadsheet' -describe "WorkPackageXlsExport Custom Fields" do +RSpec.describe "WorkPackageXlsExport Custom Fields" do let(:type) { create(:type) } let(:project) { create(:project, types: [type]) } diff --git a/modules/xls_export/spec/lib/spreadsheet_builder_spec.rb b/modules/xls_export/spec/lib/spreadsheet_builder_spec.rb index 2e282aef424..b5761857369 100644 --- a/modules/xls_export/spec/lib/spreadsheet_builder_spec.rb +++ b/modules/xls_export/spec/lib/spreadsheet_builder_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe "SpreadsheetBuilder" do +RSpec.describe "SpreadsheetBuilder" do before do @spreadsheet = OpenProject::XlsExport::SpreadsheetBuilder.new @sheet = @spreadsheet.send(:raw_sheet) diff --git a/modules/xls_export/spec/models/xls_export/project/exporter/xls_integration_spec.rb b/modules/xls_export/spec/models/xls_export/project/exporter/xls_integration_spec.rb index 7a252282430..8ad614ee09a 100644 --- a/modules/xls_export/spec/models/xls_export/project/exporter/xls_integration_spec.rb +++ b/modules/xls_export/spec/models/xls_export/project/exporter/xls_integration_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' require 'spreadsheet' require 'models/projects/exporter/exportable_project_context' -describe XlsExport::Project::Exporter::XLS do +RSpec.describe XlsExport::Project::Exporter::XLS do include_context 'with a project with an arrangement of custom fields' include_context 'with an instance of the described exporter' diff --git a/modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb b/modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb index 2645bf19d59..4aadad93760 100644 --- a/modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb +++ b/modules/xls_export/spec/models/xls_export/work_package/exporter/xls_integration_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require 'spreadsheet' -describe XlsExport::WorkPackage::Exporter::XLS do +RSpec.describe XlsExport::WorkPackage::Exporter::XLS do let(:project) { create(:project) } let(:current_user) { create(:admin) } diff --git a/modules/xls_export/spec/patches/cost_reports_controller_patch_spec.rb b/modules/xls_export/spec/patches/cost_reports_controller_patch_spec.rb index d2b24bbfea4..0ec56df2360 100644 --- a/modules/xls_export/spec/patches/cost_reports_controller_patch_spec.rb +++ b/modules/xls_export/spec/patches/cost_reports_controller_patch_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'CostReportsController', "rendering to xls" do +RSpec.describe 'CostReportsController', "rendering to xls" do skip 'XlsExport: CostReports support not yet migrated to Rails 3' it "responds with the xls if requested in the index" do diff --git a/modules/xls_export/spec/patches/work_packages_controller_patch_spec.rb b/modules/xls_export/spec/patches/work_packages_controller_patch_spec.rb index 32685419e8d..ab7d9ede3a7 100644 --- a/modules/xls_export/spec/patches/work_packages_controller_patch_spec.rb +++ b/modules/xls_export/spec/patches/work_packages_controller_patch_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackagesController, type: :controller do +RSpec.describe WorkPackagesController, type: :controller do before do login_as current_user end diff --git a/spec/constants/settings/definition_spec.rb b/spec/constants/settings/definition_spec.rb index 7a856fc823a..aaba8e0332e 100644 --- a/spec/constants/settings/definition_spec.rb +++ b/spec/constants/settings/definition_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Settings::Definition, :settings_reset do +RSpec.describe Settings::Definition, :settings_reset do describe '.add_all' do it 'adds all core setting definitions if they are not loaded' do described_class.instance_variable_set(:@all, nil) diff --git a/spec/contracts/attachments/create_contract_integration_spec.rb b/spec/contracts/attachments/create_contract_integration_spec.rb index db34d172030..00e8f5ad173 100644 --- a/spec/contracts/attachments/create_contract_integration_spec.rb +++ b/spec/contracts/attachments/create_contract_integration_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe Attachments::CreateContract, 'integration' do +RSpec.describe Attachments::CreateContract, 'integration' do include_context 'ModelContract shared context' let(:model) do diff --git a/spec/contracts/attachments/create_contract_spec.rb b/spec/contracts/attachments/create_contract_spec.rb index d5fae7fa2da..4fd31a668e4 100644 --- a/spec/contracts/attachments/create_contract_spec.rb +++ b/spec/contracts/attachments/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe Attachments::CreateContract do +RSpec.describe Attachments::CreateContract do include_context 'ModelContract shared context' let(:current_user) { build_stubbed(:user) } diff --git a/spec/contracts/attribute_help_texts/base_contract_spec.rb b/spec/contracts/attribute_help_texts/base_contract_spec.rb index 7cb2ccce95e..f5db8f8601c 100644 --- a/spec/contracts/attribute_help_texts/base_contract_spec.rb +++ b/spec/contracts/attribute_help_texts/base_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe AttributeHelpTexts::BaseContract do +RSpec.describe AttributeHelpTexts::BaseContract do include_context 'ModelContract shared context' let(:model) { build_stubbed(:work_package_help_text) } diff --git a/spec/contracts/authentication/omniauth_auth_hash_contract_spec.rb b/spec/contracts/authentication/omniauth_auth_hash_contract_spec.rb index 4e76b6ea797..82923a33b56 100644 --- a/spec/contracts/authentication/omniauth_auth_hash_contract_spec.rb +++ b/spec/contracts/authentication/omniauth_auth_hash_contract_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Authentication::OmniauthAuthHashContract do +RSpec.describe Authentication::OmniauthAuthHashContract do let(:auth_hash) do OmniAuth::AuthHash.new( provider: 'google', diff --git a/spec/contracts/backups/create_contract_spec.rb b/spec/contracts/backups/create_contract_spec.rb index 517b1713206..c1bf9100523 100644 --- a/spec/contracts/backups/create_contract_spec.rb +++ b/spec/contracts/backups/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe Backups::CreateContract do +RSpec.describe Backups::CreateContract do let(:backup) { Backup.new } let(:contract) { described_class.new backup, current_user, options: { backup_token: backup_token.plain_value } } let(:backup_token) { create(:backup_token, user: current_user) } diff --git a/spec/contracts/custom_actions/cu_contract_spec.rb b/spec/contracts/custom_actions/cu_contract_spec.rb index a53d1967c0d..83cf25e82af 100644 --- a/spec/contracts/custom_actions/cu_contract_spec.rb +++ b/spec/contracts/custom_actions/cu_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe CustomActions::CuContract do +RSpec.describe CustomActions::CuContract do include_context 'ModelContract shared context' let(:user) { build_stubbed(:user) } diff --git a/spec/contracts/custom_fields/create_contract_spec.rb b/spec/contracts/custom_fields/create_contract_spec.rb index 850e994fdf6..3fb77e12b0a 100644 --- a/spec/contracts/custom_fields/create_contract_spec.rb +++ b/spec/contracts/custom_fields/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe CustomFields::CreateContract do +RSpec.describe CustomFields::CreateContract do include_context 'ModelContract shared context' let(:cf) { build(:project_custom_field) } diff --git a/spec/contracts/custom_fields/update_contract_spec.rb b/spec/contracts/custom_fields/update_contract_spec.rb index 9bef745abaa..59d8cca5ba9 100644 --- a/spec/contracts/custom_fields/update_contract_spec.rb +++ b/spec/contracts/custom_fields/update_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe CustomFields::UpdateContract do +RSpec.describe CustomFields::UpdateContract do include_context 'ModelContract shared context' let(:cf) { build(:project_custom_field) } diff --git a/spec/contracts/groups/create_contract_spec.rb b/spec/contracts/groups/create_contract_spec.rb index 155f6f6d51a..98458c02ea4 100644 --- a/spec/contracts/groups/create_contract_spec.rb +++ b/spec/contracts/groups/create_contract_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' require_relative 'shared_contract_examples' -describe Groups::CreateContract do +RSpec.describe Groups::CreateContract do include_context 'ModelContract shared context' it_behaves_like 'group contract' do diff --git a/spec/contracts/groups/shared_contract_examples.rb b/spec/contracts/groups/shared_contract_examples.rb index 9fa2a0232be..049766ade79 100644 --- a/spec/contracts/groups/shared_contract_examples.rb +++ b/spec/contracts/groups/shared_contract_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'group contract' do +RSpec.shared_examples_for 'group contract' do let(:group_name) { 'The group' } let(:group_users_user_ids) { [42, 43] } let(:group_users) do diff --git a/spec/contracts/groups/update_contract_spec.rb b/spec/contracts/groups/update_contract_spec.rb index a7bbed0c939..01fd004c566 100644 --- a/spec/contracts/groups/update_contract_spec.rb +++ b/spec/contracts/groups/update_contract_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' require_relative 'shared_contract_examples' -describe Groups::UpdateContract do +RSpec.describe Groups::UpdateContract do include_context 'ModelContract shared context' it_behaves_like 'group contract' do diff --git a/spec/contracts/members/create_contract_spec.rb b/spec/contracts/members/create_contract_spec.rb index 19a0cb7dd71..f015d888bd9 100644 --- a/spec/contracts/members/create_contract_spec.rb +++ b/spec/contracts/members/create_contract_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './shared_contract_examples' require 'contracts/shared/model_contract_shared_context' -describe Members::CreateContract do +RSpec.describe Members::CreateContract do include_context 'ModelContract shared context' it_behaves_like 'member contract' do diff --git a/spec/contracts/members/shared_contract_examples.rb b/spec/contracts/members/shared_contract_examples.rb index 0305d24df00..52c31cf8af3 100644 --- a/spec/contracts/members/shared_contract_examples.rb +++ b/spec/contracts/members/shared_contract_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'member contract' do +RSpec.shared_examples_for 'member contract' do let(:current_user) do build_stubbed(:user, admin: current_user_admin) do |user| allow(user) diff --git a/spec/contracts/members/update_contract_spec.rb b/spec/contracts/members/update_contract_spec.rb index 1cf2f7d3794..48cbad5ac1d 100644 --- a/spec/contracts/members/update_contract_spec.rb +++ b/spec/contracts/members/update_contract_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_relative './shared_contract_examples' require 'contracts/shared/model_contract_shared_context' -describe Members::UpdateContract do +RSpec.describe Members::UpdateContract do include_context 'ModelContract shared context' it_behaves_like 'member contract' do diff --git a/spec/contracts/messages/create_contract_spec.rb b/spec/contracts/messages/create_contract_spec.rb index 2d1cc0aec62..b51bb01faba 100644 --- a/spec/contracts/messages/create_contract_spec.rb +++ b/spec/contracts/messages/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe Messages::CreateContract do +RSpec.describe Messages::CreateContract do it_behaves_like 'message contract' do let(:message) do Message.new(forum: message_forum, diff --git a/spec/contracts/messages/shared_contract_examples.rb b/spec/contracts/messages/shared_contract_examples.rb index 73c17625e3b..c551b98ae1d 100644 --- a/spec/contracts/messages/shared_contract_examples.rb +++ b/spec/contracts/messages/shared_contract_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'message contract' do +RSpec.shared_examples_for 'message contract' do let(:current_user) do build_stubbed(:user) do |user| allow(user) diff --git a/spec/contracts/messages/update_contract_spec.rb b/spec/contracts/messages/update_contract_spec.rb index 3ba20575638..0a7741a5933 100644 --- a/spec/contracts/messages/update_contract_spec.rb +++ b/spec/contracts/messages/update_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe Messages::UpdateContract do +RSpec.describe Messages::UpdateContract do it_behaves_like 'message contract' do let(:message) do build_stubbed(:message).tap do |message| diff --git a/spec/contracts/notifications/create_contract_spec.rb b/spec/contracts/notifications/create_contract_spec.rb index 75e27b16081..739f65f8cc2 100644 --- a/spec/contracts/notifications/create_contract_spec.rb +++ b/spec/contracts/notifications/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe Notifications::CreateContract do +RSpec.describe Notifications::CreateContract do include_context 'ModelContract shared context' let(:current_user) do diff --git a/spec/contracts/oauth_clients/create_contract_spec.rb b/spec/contracts/oauth_clients/create_contract_spec.rb index b64b7c9b13f..380a7f54ebd 100644 --- a/spec/contracts/oauth_clients/create_contract_spec.rb +++ b/spec/contracts/oauth_clients/create_contract_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require_module_spec_helper require 'contracts/shared/model_contract_shared_context' -describe OAuthClients::CreateContract do +RSpec.describe OAuthClients::CreateContract do include_context 'ModelContract shared context' let(:current_user) { create(:admin) } diff --git a/spec/contracts/oauth_clients/delete_contract_spec.rb b/spec/contracts/oauth_clients/delete_contract_spec.rb index 42205e34486..dfb5e1b8b7a 100644 --- a/spec/contracts/oauth_clients/delete_contract_spec.rb +++ b/spec/contracts/oauth_clients/delete_contract_spec.rb @@ -32,7 +32,7 @@ require 'contracts/shared/model_contract_shared_context' # This DeleteContract spec just tests if the user is _allowed_ # to execute the operation. -describe OAuthClients::DeleteContract do +RSpec.describe OAuthClients::DeleteContract do include_context 'ModelContract shared context' let(:oauth_client) { create(:oauth_client) } diff --git a/spec/contracts/placeholder_users/create_contract_spec.rb b/spec/contracts/placeholder_users/create_contract_spec.rb index 78577eb0b28..a667b9be2ab 100644 --- a/spec/contracts/placeholder_users/create_contract_spec.rb +++ b/spec/contracts/placeholder_users/create_contract_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' require_relative 'shared_contract_examples' -describe PlaceholderUsers::CreateContract do +RSpec.describe PlaceholderUsers::CreateContract do include_context 'ModelContract shared context' context 'without enterprise' do diff --git a/spec/contracts/placeholder_users/delete_contract_spec.rb b/spec/contracts/placeholder_users/delete_contract_spec.rb index 03c7bd87011..95558481ba5 100644 --- a/spec/contracts/placeholder_users/delete_contract_spec.rb +++ b/spec/contracts/placeholder_users/delete_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe PlaceholderUsers::DeleteContract do +RSpec.describe PlaceholderUsers::DeleteContract do include_context 'ModelContract shared context' let(:placeholder_user) { create(:placeholder_user) } diff --git a/spec/contracts/placeholder_users/shared_contract_examples.rb b/spec/contracts/placeholder_users/shared_contract_examples.rb index 4a5c6346c1f..e125f1dc2e8 100644 --- a/spec/contracts/placeholder_users/shared_contract_examples.rb +++ b/spec/contracts/placeholder_users/shared_contract_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'placeholder user contract' do +RSpec.shared_examples_for 'placeholder user contract' do let(:placeholder_user_name) { 'UX Designer' } context 'when user with global permission' do diff --git a/spec/contracts/placeholder_users/update_contract_spec.rb b/spec/contracts/placeholder_users/update_contract_spec.rb index 12fcb7e7ff6..3613b600030 100644 --- a/spec/contracts/placeholder_users/update_contract_spec.rb +++ b/spec/contracts/placeholder_users/update_contract_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' require_relative 'shared_contract_examples' -describe PlaceholderUsers::UpdateContract do +RSpec.describe PlaceholderUsers::UpdateContract do include_context 'ModelContract shared context' it_behaves_like 'placeholder user contract' do diff --git a/spec/contracts/projects/archive_contract_spec.rb b/spec/contracts/projects/archive_contract_spec.rb index b91f035978a..144dc10e423 100644 --- a/spec/contracts/projects/archive_contract_spec.rb +++ b/spec/contracts/projects/archive_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe Projects::ArchiveContract do +RSpec.describe Projects::ArchiveContract do include_context 'ModelContract shared context' shared_let(:archivist_role) { create(:role, permissions: %i[archive_project]) } diff --git a/spec/contracts/projects/base_contract_spec.rb b/spec/contracts/projects/base_contract_spec.rb index 38a140f0910..7f91eb16065 100644 --- a/spec/contracts/projects/base_contract_spec.rb +++ b/spec/contracts/projects/base_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe Projects::BaseContract do +RSpec.describe Projects::BaseContract do let(:project) { Project.new(name: 'Foo', identifier: 'foo', templated: false) } let(:contract) { described_class.new(project, current_user) } diff --git a/spec/contracts/projects/create_contract_spec.rb b/spec/contracts/projects/create_contract_spec.rb index a8f6e1a7b75..1315002927f 100644 --- a/spec/contracts/projects/create_contract_spec.rb +++ b/spec/contracts/projects/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe Projects::CreateContract do +RSpec.describe Projects::CreateContract do it_behaves_like 'project contract' do let(:project) do Project.new(name: project_name, diff --git a/spec/contracts/projects/delete_contract_spec.rb b/spec/contracts/projects/delete_contract_spec.rb index 0760f8078d2..c0427633b97 100644 --- a/spec/contracts/projects/delete_contract_spec.rb +++ b/spec/contracts/projects/delete_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe Projects::DeleteContract do +RSpec.describe Projects::DeleteContract do include_context 'ModelContract shared context' let(:project) { build_stubbed(:project) } diff --git a/spec/contracts/projects/enabled_modules_contract_spec.rb b/spec/contracts/projects/enabled_modules_contract_spec.rb index ec1feef8196..91ef126f9fa 100644 --- a/spec/contracts/projects/enabled_modules_contract_spec.rb +++ b/spec/contracts/projects/enabled_modules_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe Projects::EnabledModulesContract do +RSpec.describe Projects::EnabledModulesContract do include_context 'ModelContract shared context' let(:project) { build_stubbed(:project, enabled_module_names: enabled_modules) } diff --git a/spec/contracts/projects/shared_contract_examples.rb b/spec/contracts/projects/shared_contract_examples.rb index 5102a4f27c1..53128e6e6fe 100644 --- a/spec/contracts/projects/shared_contract_examples.rb +++ b/spec/contracts/projects/shared_contract_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'project contract' do +RSpec.shared_examples_for 'project contract' do let(:current_user) do build_stubbed(:user) end diff --git a/spec/contracts/projects/unarchive_contract_spec.rb b/spec/contracts/projects/unarchive_contract_spec.rb index c4964a1aefd..c6bda5c2198 100644 --- a/spec/contracts/projects/unarchive_contract_spec.rb +++ b/spec/contracts/projects/unarchive_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe Projects::UnarchiveContract do +RSpec.describe Projects::UnarchiveContract do include_context 'ModelContract shared context' let(:project) { build_stubbed(:project) } diff --git a/spec/contracts/projects/update_contract_spec.rb b/spec/contracts/projects/update_contract_spec.rb index 1e9f4890927..f40dc0647fc 100644 --- a/spec/contracts/projects/update_contract_spec.rb +++ b/spec/contracts/projects/update_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe Projects::UpdateContract do +RSpec.describe Projects::UpdateContract do it_behaves_like 'project contract' do let(:project) do build_stubbed(:project, diff --git a/spec/contracts/queries/base_contract_spec.rb b/spec/contracts/queries/base_contract_spec.rb index 9434f58401e..c5448500213 100644 --- a/spec/contracts/queries/base_contract_spec.rb +++ b/spec/contracts/queries/base_contract_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' require_relative 'shared_contract_examples' -describe Queries::BaseContract do +RSpec.describe Queries::BaseContract do include_context 'ModelContract shared context' include_context 'with queries contract' diff --git a/spec/contracts/queries/create_contract_spec.rb b/spec/contracts/queries/create_contract_spec.rb index 1a5f0367ae0..5f24da02865 100644 --- a/spec/contracts/queries/create_contract_spec.rb +++ b/spec/contracts/queries/create_contract_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' require_relative 'shared_contract_examples' -describe Queries::CreateContract do +RSpec.describe Queries::CreateContract do include_context 'ModelContract shared context' include_context 'with queries contract' diff --git a/spec/contracts/queries/shared_contract_examples.rb b/spec/contracts/queries/shared_contract_examples.rb index 3c2febe20ec..f0e2e71f95f 100644 --- a/spec/contracts/queries/shared_contract_examples.rb +++ b/spec/contracts/queries/shared_contract_examples.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -shared_context 'with queries contract' do +RSpec.shared_context 'with queries contract' do let(:project) { build_stubbed(:project) } let(:name) { 'Some query name' } let(:public) { false } diff --git a/spec/contracts/queries/update_contract_spec.rb b/spec/contracts/queries/update_contract_spec.rb index f0975ffbb86..32fa2aaa73b 100644 --- a/spec/contracts/queries/update_contract_spec.rb +++ b/spec/contracts/queries/update_contract_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' require_relative 'shared_contract_examples' -describe Queries::UpdateContract do +RSpec.describe Queries::UpdateContract do include_context 'ModelContract shared context' include_context 'with queries contract' diff --git a/spec/contracts/relations/create_contract_spec.rb b/spec/contracts/relations/create_contract_spec.rb index e859524b712..6ccb9e0a949 100644 --- a/spec/contracts/relations/create_contract_spec.rb +++ b/spec/contracts/relations/create_contract_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Relations::CreateContract do +RSpec.describe Relations::CreateContract do let(:from) { build_stubbed(:work_package) } let(:to) { build_stubbed(:work_package) } let(:user) { build_stubbed(:admin) } diff --git a/spec/contracts/roles/create_contract_spec.rb b/spec/contracts/roles/create_contract_spec.rb index 6427fce2fdc..ae8429bb4dc 100644 --- a/spec/contracts/roles/create_contract_spec.rb +++ b/spec/contracts/roles/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe Roles::CreateContract do +RSpec.describe Roles::CreateContract do it_behaves_like 'roles contract' do let(:role) do Role.new.tap do |r| diff --git a/spec/contracts/roles/shared_contract_examples.rb b/spec/contracts/roles/shared_contract_examples.rb index 9fd9d11ef4c..5ef34f54a42 100644 --- a/spec/contracts/roles/shared_contract_examples.rb +++ b/spec/contracts/roles/shared_contract_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'roles contract' do +RSpec.shared_examples_for 'roles contract' do let(:current_user) do build_stubbed(:admin) end diff --git a/spec/contracts/roles/update_contract_spec.rb b/spec/contracts/roles/update_contract_spec.rb index 41017799f70..a9bafda0b2c 100644 --- a/spec/contracts/roles/update_contract_spec.rb +++ b/spec/contracts/roles/update_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe Roles::UpdateContract do +RSpec.describe Roles::UpdateContract do it_behaves_like 'roles contract' do let(:role) do build_stubbed(:role, diff --git a/spec/contracts/settings/update_contract_spec.rb b/spec/contracts/settings/update_contract_spec.rb index 7ea86e481eb..e37a1dcd598 100644 --- a/spec/contracts/settings/update_contract_spec.rb +++ b/spec/contracts/settings/update_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe Settings::UpdateContract do +RSpec.describe Settings::UpdateContract do include_context 'ModelContract shared context' let(:contract) do diff --git a/spec/contracts/settings/working_days_params_contract_spec.rb b/spec/contracts/settings/working_days_params_contract_spec.rb index c522ed09c50..a481df2a99a 100644 --- a/spec/contracts/settings/working_days_params_contract_spec.rb +++ b/spec/contracts/settings/working_days_params_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe Settings::WorkingDaysParamsContract do +RSpec.describe Settings::WorkingDaysParamsContract do include_context 'ModelContract shared context' let(:setting) { Setting } let(:current_user) { build_stubbed(:admin) } diff --git a/spec/contracts/shared/model_contract_shared_context.rb b/spec/contracts/shared/model_contract_shared_context.rb index e6bdbf4274f..e5bd4b37a0c 100644 --- a/spec/contracts/shared/model_contract_shared_context.rb +++ b/spec/contracts/shared/model_contract_shared_context.rb @@ -1,4 +1,4 @@ -shared_context 'ModelContract shared context' do # rubocop:disable RSpec/ContextWording +RSpec.shared_context 'ModelContract shared context' do # rubocop:disable RSpec/ContextWording def expect_contract_valid expect(contract.validate) .to be(true), diff --git a/spec/contracts/user_preferences/params_contract_spec.rb b/spec/contracts/user_preferences/params_contract_spec.rb index e5af5be3de7..02ac36cd013 100644 --- a/spec/contracts/user_preferences/params_contract_spec.rb +++ b/spec/contracts/user_preferences/params_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe UserPreferences::ParamsContract do +RSpec.describe UserPreferences::ParamsContract do include_context 'ModelContract shared context' let(:current_user) { build_stubbed(:user) } diff --git a/spec/contracts/user_preferences/update_contract_spec.rb b/spec/contracts/user_preferences/update_contract_spec.rb index b7808024858..b50c10041ca 100644 --- a/spec/contracts/user_preferences/update_contract_spec.rb +++ b/spec/contracts/user_preferences/update_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe UserPreferences::UpdateContract do +RSpec.describe UserPreferences::UpdateContract do include_context 'ModelContract shared context' let(:current_user) { build_stubbed(:user) } diff --git a/spec/contracts/users/create_contract_spec.rb b/spec/contracts/users/create_contract_spec.rb index b2ca37a8ecd..d5b749fff2b 100644 --- a/spec/contracts/users/create_contract_spec.rb +++ b/spec/contracts/users/create_contract_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' require_relative 'shared_contract_examples' -describe Users::CreateContract do +RSpec.describe Users::CreateContract do include_context 'ModelContract shared context' it_behaves_like 'user contract' do diff --git a/spec/contracts/users/shared_contract_examples.rb b/spec/contracts/users/shared_contract_examples.rb index 2900cee2b6a..4d50207ae81 100644 --- a/spec/contracts/users/shared_contract_examples.rb +++ b/spec/contracts/users/shared_contract_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'user contract' do +RSpec.shared_examples_for 'user contract' do let(:user_firstname) { 'Bob' } let(:user_lastname) { 'Bobbit' } let(:user_login) { 'bob' } diff --git a/spec/contracts/users/update_contract_spec.rb b/spec/contracts/users/update_contract_spec.rb index 20688f6ac75..5f45d0155b4 100644 --- a/spec/contracts/users/update_contract_spec.rb +++ b/spec/contracts/users/update_contract_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' require_relative 'shared_contract_examples' -describe Users::UpdateContract do +RSpec.describe Users::UpdateContract do include_context 'ModelContract shared context' it_behaves_like 'user contract' do diff --git a/spec/contracts/versions/create_contract_spec.rb b/spec/contracts/versions/create_contract_spec.rb index 88ef7581f1a..c696eddb66a 100644 --- a/spec/contracts/versions/create_contract_spec.rb +++ b/spec/contracts/versions/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe Versions::CreateContract do +RSpec.describe Versions::CreateContract do it_behaves_like 'version contract' do let(:version) do Version.new(name: version_name, diff --git a/spec/contracts/versions/shared_contract_examples.rb b/spec/contracts/versions/shared_contract_examples.rb index 2a679148eac..7e77609fa5c 100644 --- a/spec/contracts/versions/shared_contract_examples.rb +++ b/spec/contracts/versions/shared_contract_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'version contract' do +RSpec.shared_examples_for 'version contract' do let(:current_user) do build_stubbed(:user) do |user| allow(user) diff --git a/spec/contracts/versions/update_contract_spec.rb b/spec/contracts/versions/update_contract_spec.rb index 5612d14d145..7a3e967646c 100644 --- a/spec/contracts/versions/update_contract_spec.rb +++ b/spec/contracts/versions/update_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe Versions::UpdateContract do +RSpec.describe Versions::UpdateContract do it_behaves_like 'version contract' do let(:version) do build_stubbed(:version, diff --git a/spec/contracts/views/create_contract_work_packages_table_spec.rb b/spec/contracts/views/create_contract_work_packages_table_spec.rb index f1c5609c929..44d20398027 100644 --- a/spec/contracts/views/create_contract_work_packages_table_spec.rb +++ b/spec/contracts/views/create_contract_work_packages_table_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe Views::CreateContract do +RSpec.describe Views::CreateContract do it_behaves_like 'view contract' do let(:view) do View.new(query: view_query, diff --git a/spec/contracts/views/shared_contract_examples.rb b/spec/contracts/views/shared_contract_examples.rb index c495527425c..479adec46a2 100644 --- a/spec/contracts/views/shared_contract_examples.rb +++ b/spec/contracts/views/shared_contract_examples.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -shared_examples_for 'view contract' do |disabled_permission_checks| +RSpec.shared_examples_for 'view contract' do |disabled_permission_checks| include_context 'ModelContract shared context' let(:current_user) do diff --git a/spec/contracts/views/update_contract_spec.rb b/spec/contracts/views/update_contract_spec.rb index 7e8c7505f7a..16c57172d41 100644 --- a/spec/contracts/views/update_contract_spec.rb +++ b/spec/contracts/views/update_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe Views::UpdateContract do +RSpec.describe Views::UpdateContract do # TODO: this is just a stub to ensure that the type is not altered it_behaves_like 'view contract' do let(:view) do diff --git a/spec/contracts/wiki_pages/create_contract_spec.rb b/spec/contracts/wiki_pages/create_contract_spec.rb index 5a916b5205f..beb5908a649 100644 --- a/spec/contracts/wiki_pages/create_contract_spec.rb +++ b/spec/contracts/wiki_pages/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_contract_examples' -describe WikiPages::CreateContract do +RSpec.describe WikiPages::CreateContract do it_behaves_like 'wiki page contract' do subject(:contract) { described_class.new(page, current_user, options: {}) } diff --git a/spec/contracts/wiki_pages/shared_contract_examples.rb b/spec/contracts/wiki_pages/shared_contract_examples.rb index 76e87163160..aaa34187d12 100644 --- a/spec/contracts/wiki_pages/shared_contract_examples.rb +++ b/spec/contracts/wiki_pages/shared_contract_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'wiki page contract' do +RSpec.shared_examples_for 'wiki page contract' do let(:current_user) do build_stubbed(:user) do |user| allow(user) diff --git a/spec/contracts/work_packages/base_contract_spec.rb b/spec/contracts/work_packages/base_contract_spec.rb index 85ae283d588..4f13ad706f1 100644 --- a/spec/contracts/work_packages/base_contract_spec.rb +++ b/spec/contracts/work_packages/base_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/shared/model_contract_shared_context' -describe WorkPackages::BaseContract do +RSpec.describe WorkPackages::BaseContract do let(:work_package) do build_stubbed(:work_package, type:, diff --git a/spec/contracts/work_packages/create_contract_spec.rb b/spec/contracts/work_packages/create_contract_spec.rb index db5c11f1b3f..c9f107538c7 100644 --- a/spec/contracts/work_packages/create_contract_spec.rb +++ b/spec/contracts/work_packages/create_contract_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'contracts/work_packages/shared_base_contract' -describe WorkPackages::CreateContract do +RSpec.describe WorkPackages::CreateContract do let(:work_package) do WorkPackage.new(project: work_package_project).tap do |wp| wp.extend(OpenProject::ChangedBySystem) diff --git a/spec/contracts/work_packages/create_note_contract_spec.rb b/spec/contracts/work_packages/create_note_contract_spec.rb index 42eb795446b..8a1be2dd33b 100644 --- a/spec/contracts/work_packages/create_note_contract_spec.rb +++ b/spec/contracts/work_packages/create_note_contract_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe WorkPackages::CreateNoteContract do +RSpec.describe WorkPackages::CreateNoteContract do let(:work_package) do # As we only want to test the contract, we mock checking whether the work_package is valid wp = build_stubbed(:work_package) diff --git a/spec/contracts/work_packages/shared_base_contract.rb b/spec/contracts/work_packages/shared_base_contract.rb index 5d21a91d651..fe7ae9e8ae6 100644 --- a/spec/contracts/work_packages/shared_base_contract.rb +++ b/spec/contracts/work_packages/shared_base_contract.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_examples_for 'work package contract' do +RSpec.shared_examples_for 'work package contract' do let(:user) { build_stubbed(:user) } let(:other_user) { build_stubbed(:user) } let(:policy) { double(WorkPackagePolicy, allowed?: true) } diff --git a/spec/contracts/work_packages/update_contract_spec.rb b/spec/contracts/work_packages/update_contract_spec.rb index 3ac500cceb1..482207cb1ed 100644 --- a/spec/contracts/work_packages/update_contract_spec.rb +++ b/spec/contracts/work_packages/update_contract_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'contracts/work_packages/shared_base_contract' -describe WorkPackages::UpdateContract do +RSpec.describe WorkPackages::UpdateContract do let(:work_package_project) do create(:project, public: false).tap do |p| allow(Project) diff --git a/spec/controllers/account_controller_spec.rb b/spec/controllers/account_controller_spec.rb index badfd1431c6..212e4d9fe30 100644 --- a/spec/controllers/account_controller_spec.rb +++ b/spec/controllers/account_controller_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe AccountController, - skip_2fa_stage: true do +RSpec.describe AccountController, + skip_2fa_stage: true do class UserHook < OpenProject::Hook::ViewListener attr_reader :registered_user, :first_login_user diff --git a/spec/controllers/activities_controller_spec.rb b/spec/controllers/activities_controller_spec.rb index 803afa00167..34bebe77fde 100644 --- a/spec/controllers/activities_controller_spec.rb +++ b/spec/controllers/activities_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ActivitiesController do +RSpec.describe ActivitiesController do shared_let(:admin) { create(:admin) } current_user { admin } diff --git a/spec/controllers/admin/settings/authentication_controller_spec.rb b/spec/controllers/admin/settings/authentication_controller_spec.rb index 74d7503efa7..efd849e69d8 100644 --- a/spec/controllers/admin/settings/authentication_controller_spec.rb +++ b/spec/controllers/admin/settings/authentication_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Admin::Settings::AuthenticationSettingsController do +RSpec.describe Admin::Settings::AuthenticationSettingsController do describe 'show.html' do def fetch get 'show' diff --git a/spec/controllers/admin/settings/projects_settings_controller_spec.rb b/spec/controllers/admin/settings/projects_settings_controller_spec.rb index d9b67d9cbdc..f639ebf1b8c 100644 --- a/spec/controllers/admin/settings/projects_settings_controller_spec.rb +++ b/spec/controllers/admin/settings/projects_settings_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Admin::Settings::ProjectsSettingsController do +RSpec.describe Admin::Settings::ProjectsSettingsController do before do allow(@controller).to receive(:set_localization) @params = {} diff --git a/spec/controllers/admin/settings/working_days_settings_controller_spec.rb b/spec/controllers/admin/settings/working_days_settings_controller_spec.rb index a9ff7e12730..cb0639741dd 100644 --- a/spec/controllers/admin/settings/working_days_settings_controller_spec.rb +++ b/spec/controllers/admin/settings/working_days_settings_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Admin::Settings::WorkingDaysSettingsController do +RSpec.describe Admin::Settings::WorkingDaysSettingsController do shared_let(:user) { create(:admin) } current_user { user } diff --git a/spec/controllers/admin_controller_spec.rb b/spec/controllers/admin_controller_spec.rb index 55c9612f655..ec785196a90 100644 --- a/spec/controllers/admin_controller_spec.rb +++ b/spec/controllers/admin_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe AdminController do +RSpec.describe AdminController do let(:user) { build(:admin) } before do diff --git a/spec/controllers/announcements_controller_spec.rb b/spec/controllers/announcements_controller_spec.rb index e7b90102872..f679e07b967 100644 --- a/spec/controllers/announcements_controller_spec.rb +++ b/spec/controllers/announcements_controller_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe AnnouncementsController do +RSpec.describe AnnouncementsController do let(:announcement) { build(:announcement) } before do diff --git a/spec/controllers/application_controller_spec.rb b/spec/controllers/application_controller_spec.rb index 5b2c52eaf0e..c87edf1c96f 100644 --- a/spec/controllers/application_controller_spec.rb +++ b/spec/controllers/application_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ApplicationController do +RSpec.describe ApplicationController do let(:user) { create(:user, lastname: "Crazy! Name with \r\n Newline") } # Fake controller to test calling an action diff --git a/spec/controllers/attribute_help_texts_controller_spec.rb b/spec/controllers/attribute_help_texts_controller_spec.rb index 686468bb17a..28cd47739e5 100644 --- a/spec/controllers/attribute_help_texts_controller_spec.rb +++ b/spec/controllers/attribute_help_texts_controller_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe AttributeHelpTextsController, with_ee: %i[attribute_help_texts] do +RSpec.describe AttributeHelpTextsController, with_ee: %i[attribute_help_texts] do let(:user) { build_stubbed(:admin) } let(:model) { build(:work_package_help_text) } diff --git a/spec/controllers/auth_sources_controller_spec.rb b/spec/controllers/auth_sources_controller_spec.rb index 1c1e6674e49..981a5f300c0 100644 --- a/spec/controllers/auth_sources_controller_spec.rb +++ b/spec/controllers/auth_sources_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe AuthSourcesController do +RSpec.describe AuthSourcesController do let(:current_user) { create(:admin) } before do diff --git a/spec/controllers/categories_controller_spec.rb b/spec/controllers/categories_controller_spec.rb index 4346dffbaaa..485d99358d7 100644 --- a/spec/controllers/categories_controller_spec.rb +++ b/spec/controllers/categories_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CategoriesController do +RSpec.describe CategoriesController do let(:user) { create(:user) } let(:project) { create(:project) } let(:role) do diff --git a/spec/controllers/colors_controller_spec.rb b/spec/controllers/colors_controller_spec.rb index 45436cce44a..e58774a73eb 100644 --- a/spec/controllers/colors_controller_spec.rb +++ b/spec/controllers/colors_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ColorsController do +RSpec.describe ColorsController do let(:current_user) { create(:admin) } before do diff --git a/spec/controllers/concerns/auth_source_slo_spec.rb b/spec/controllers/concerns/auth_source_slo_spec.rb index 7d0eda26f3f..29a1e957998 100644 --- a/spec/controllers/concerns/auth_source_slo_spec.rb +++ b/spec/controllers/concerns/auth_source_slo_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' ## -describe AccountController, 'Auth header logout' do +RSpec.describe AccountController, 'Auth header logout' do render_views let!(:auth_source) { DummyAuthSource.create name: "Dummy LDAP" } diff --git a/spec/controllers/concerns/auth_source_sso_spec.rb b/spec/controllers/concerns/auth_source_sso_spec.rb index ec24008e443..1ffe567fc95 100644 --- a/spec/controllers/concerns/auth_source_sso_spec.rb +++ b/spec/controllers/concerns/auth_source_sso_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe MyController, - skip_2fa_stage: true do +RSpec.describe MyController, + skip_2fa_stage: true do render_views let(:sso_config) do diff --git a/spec/controllers/concerns/omniauth_login_spec.rb b/spec/controllers/concerns/omniauth_login_spec.rb index eae6566198c..e8ba08eb976 100644 --- a/spec/controllers/concerns/omniauth_login_spec.rb +++ b/spec/controllers/concerns/omniauth_login_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' # Concern is included into AccountController and depends on methods available there -describe AccountController, - skip_2fa_stage: true do +RSpec.describe AccountController, + skip_2fa_stage: true do let(:omniauth_strategy) { double('Google Strategy', name: 'google') } let(:omniauth_hash) do OmniAuth::AuthHash.new( diff --git a/spec/controllers/concerns/user_invitation_spec.rb b/spec/controllers/concerns/user_invitation_spec.rb index 495c3526b6d..aad4aa78ab8 100644 --- a/spec/controllers/concerns/user_invitation_spec.rb +++ b/spec/controllers/concerns/user_invitation_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe UserInvitation do +RSpec.describe UserInvitation do describe '.reinvite_user' do let(:user) { create(:invited_user) } let!(:token) { create(:invitation_token, user:) } diff --git a/spec/controllers/custom_actions_controller_spec.rb b/spec/controllers/custom_actions_controller_spec.rb index b1967e0b7ba..5e96c89180a 100644 --- a/spec/controllers/custom_actions_controller_spec.rb +++ b/spec/controllers/custom_actions_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomActionsController, with_ee: %i[custom_actions] do +RSpec.describe CustomActionsController, with_ee: %i[custom_actions] do let(:admin) { build(:admin) } let(:non_admin) { build(:user) } let(:action) { build_stubbed(:custom_action) } diff --git a/spec/controllers/custom_fields_controller_spec.rb b/spec/controllers/custom_fields_controller_spec.rb index 53b4ebf0bf5..f9e01b325c0 100644 --- a/spec/controllers/custom_fields_controller_spec.rb +++ b/spec/controllers/custom_fields_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomFieldsController do +RSpec.describe CustomFieldsController do shared_let(:admin) { create(:admin) } let(:custom_field) { build_stubbed(:custom_field) } diff --git a/spec/controllers/custom_styles_controller_spec.rb b/spec/controllers/custom_styles_controller_spec.rb index 04b5fd4b467..37a0b391157 100644 --- a/spec/controllers/custom_styles_controller_spec.rb +++ b/spec/controllers/custom_styles_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomStylesController do +RSpec.describe CustomStylesController do before do login_as user end diff --git a/spec/controllers/enterprises_controller_spec.rb b/spec/controllers/enterprises_controller_spec.rb index 990c758e99d..43ba6d248b4 100644 --- a/spec/controllers/enterprises_controller_spec.rb +++ b/spec/controllers/enterprises_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe EnterprisesController do +RSpec.describe EnterprisesController do let(:a_token) { EnterpriseToken.new } let(:token_attributes) do diff --git a/spec/controllers/enumerations_controller_spec.rb b/spec/controllers/enumerations_controller_spec.rb index dfe5b6b5fa2..29bae01e477 100644 --- a/spec/controllers/enumerations_controller_spec.rb +++ b/spec/controllers/enumerations_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe EnumerationsController do +RSpec.describe EnumerationsController do shared_let(:admin) { create(:admin) } current_user do diff --git a/spec/controllers/forums_controller_spec.rb b/spec/controllers/forums_controller_spec.rb index cdaf2ac0ae1..c5757c88a33 100644 --- a/spec/controllers/forums_controller_spec.rb +++ b/spec/controllers/forums_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ForumsController do +RSpec.describe ForumsController do shared_let(:user) { create(:user) } let(:project) { create(:project) } let!(:forum) { create(:forum, project:) } diff --git a/spec/controllers/groups_controller_spec.rb b/spec/controllers/groups_controller_spec.rb index 1107183f2d0..0ae7df926f8 100644 --- a/spec/controllers/groups_controller_spec.rb +++ b/spec/controllers/groups_controller_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe GroupsController do +RSpec.describe GroupsController do let(:group) { create(:group, members: group_members) } let(:group_members) { [] } diff --git a/spec/controllers/homescreen_controller_spec.rb b/spec/controllers/homescreen_controller_spec.rb index bb2a9adc36a..1960c73eb9a 100644 --- a/spec/controllers/homescreen_controller_spec.rb +++ b/spec/controllers/homescreen_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe HomescreenController do +RSpec.describe HomescreenController do before do login_as(user) diff --git a/spec/controllers/journals_controller_spec.rb b/spec/controllers/journals_controller_spec.rb index 0dc572cb271..982a4529515 100644 --- a/spec/controllers/journals_controller_spec.rb +++ b/spec/controllers/journals_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe JournalsController do +RSpec.describe JournalsController do shared_let(:project) { create(:project_with_types) } shared_let(:user) { create(:user, member_in_project: project, member_with_permissions: [:view_work_packages]) } diff --git a/spec/controllers/ldap_auth_sources_controller_spec.rb b/spec/controllers/ldap_auth_sources_controller_spec.rb index 01012ed3c84..5ba8d27aaba 100644 --- a/spec/controllers/ldap_auth_sources_controller_spec.rb +++ b/spec/controllers/ldap_auth_sources_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe LdapAuthSourcesController do +RSpec.describe LdapAuthSourcesController do let(:current_user) { create(:admin) } before do diff --git a/spec/controllers/members_controller_spec.rb b/spec/controllers/members_controller_spec.rb index 3c656d41b86..4f6c66a01d0 100644 --- a/spec/controllers/members_controller_spec.rb +++ b/spec/controllers/members_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe MembersController do +RSpec.describe MembersController do shared_let(:admin) { create(:admin) } let(:user) { create(:user) } let(:project) { create(:project, identifier: 'pet_project') } diff --git a/spec/controllers/messages_controller_spec.rb b/spec/controllers/messages_controller_spec.rb index 515e49db293..785d4b4d7ed 100644 --- a/spec/controllers/messages_controller_spec.rb +++ b/spec/controllers/messages_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe MessagesController, with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe MessagesController, with_settings: { journal_aggregation_time_minutes: 0 } do let(:user) { create(:user) } let(:project) { create(:project) } let(:role) { create(:role) } diff --git a/spec/controllers/my_controller_spec.rb b/spec/controllers/my_controller_spec.rb index 0c12dce25bc..11b042e4371 100644 --- a/spec/controllers/my_controller_spec.rb +++ b/spec/controllers/my_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe MyController do +RSpec.describe MyController do let(:user) { create(:user) } before do diff --git a/spec/controllers/news/comments_controller_spec.rb b/spec/controllers/news/comments_controller_spec.rb index 2670768da95..7088683b3a0 100644 --- a/spec/controllers/news/comments_controller_spec.rb +++ b/spec/controllers/news/comments_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe News::CommentsController do +RSpec.describe News::CommentsController do render_views let(:user) { create(:admin) } diff --git a/spec/controllers/news_controller_spec.rb b/spec/controllers/news_controller_spec.rb index 0ed0447c555..cad3ce085a0 100644 --- a/spec/controllers/news_controller_spec.rb +++ b/spec/controllers/news_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe NewsController do +RSpec.describe NewsController do render_views include BecomeMember diff --git a/spec/controllers/oauth/applications_controller_spec.rb b/spec/controllers/oauth/applications_controller_spec.rb index d40541e2f54..7a0820876e2 100644 --- a/spec/controllers/oauth/applications_controller_spec.rb +++ b/spec/controllers/oauth/applications_controller_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'work_package' -describe OAuth::ApplicationsController do +RSpec.describe OAuth::ApplicationsController do let(:user) { build_stubbed(:admin) } let(:application_stub) { build_stubbed(:oauth_application, id: 1, secret: 'foo') } diff --git a/spec/controllers/oauth/grants_controller_spec.rb b/spec/controllers/oauth/grants_controller_spec.rb index fabf3cdf9c9..bcb39724585 100644 --- a/spec/controllers/oauth/grants_controller_spec.rb +++ b/spec/controllers/oauth/grants_controller_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'work_package' -describe OAuth::GrantsController do +RSpec.describe OAuth::GrantsController do let(:user) { build_stubbed(:user) } let(:application_stub) { instance_double(Doorkeeper::Application, name: 'Foo', id: 1) } diff --git a/spec/controllers/placeholder_users/memberships_controller_spec.rb b/spec/controllers/placeholder_users/memberships_controller_spec.rb index 0bdf6522b89..5666dcec8a6 100644 --- a/spec/controllers/placeholder_users/memberships_controller_spec.rb +++ b/spec/controllers/placeholder_users/memberships_controller_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'work_package' -describe PlaceholderUsers::MembershipsController do +RSpec.describe PlaceholderUsers::MembershipsController do shared_let(:placeholder_user) { create(:placeholder_user) } shared_let(:anonymous) { create(:anonymous) } shared_let(:project) { create(:project) } diff --git a/spec/controllers/placeholder_users_controller_spec.rb b/spec/controllers/placeholder_users_controller_spec.rb index fdd1960e568..482ced0de9b 100644 --- a/spec/controllers/placeholder_users_controller_spec.rb +++ b/spec/controllers/placeholder_users_controller_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'work_package' -describe PlaceholderUsersController do +RSpec.describe PlaceholderUsersController do shared_let(:placeholder_user) { create(:placeholder_user) } shared_examples 'do not allow non-admins' do diff --git a/spec/controllers/projects_controller_spec.rb b/spec/controllers/projects_controller_spec.rb index 2753a5ed6d7..f280db2e127 100644 --- a/spec/controllers/projects_controller_spec.rb +++ b/spec/controllers/projects_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ProjectsController do +RSpec.describe ProjectsController do shared_let(:admin) { create(:admin) } let(:non_member) { create(:non_member) } diff --git a/spec/controllers/projects_settings_menu_controller_spec.rb b/spec/controllers/projects_settings_menu_controller_spec.rb index b35bfd664c0..d7283b31012 100644 --- a/spec/controllers/projects_settings_menu_controller_spec.rb +++ b/spec/controllers/projects_settings_menu_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::Settings::ModulesController, 'menu' do +RSpec.describe Projects::Settings::ModulesController, 'menu' do let(:current_user) do build_stubbed(:user).tap do |u| allow(u) diff --git a/spec/controllers/repositories_controller_spec.rb b/spec/controllers/repositories_controller_spec.rb index 2c8ef253a0b..683f86a9cf2 100644 --- a/spec/controllers/repositories_controller_spec.rb +++ b/spec/controllers/repositories_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RepositoriesController do +RSpec.describe RepositoriesController do let(:project) do project = create(:project) allow(Project).to receive(:find).and_return(project) diff --git a/spec/controllers/roles_controller_spec.rb b/spec/controllers/roles_controller_spec.rb index e35e1e9e196..387e5d6a9e4 100644 --- a/spec/controllers/roles_controller_spec.rb +++ b/spec/controllers/roles_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RolesController do +RSpec.describe RolesController do let(:user) do build_stubbed(:admin) end diff --git a/spec/controllers/search_controller_spec.rb b/spec/controllers/search_controller_spec.rb index 814335e0d73..a651e993687 100644 --- a/spec/controllers/search_controller_spec.rb +++ b/spec/controllers/search_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe SearchController do +RSpec.describe SearchController do shared_let(:project) do create(:project, name: 'eCookbook') diff --git a/spec/controllers/statuses_controller_spec.rb b/spec/controllers/statuses_controller_spec.rb index 54707ec3020..697a6789ad0 100644 --- a/spec/controllers/statuses_controller_spec.rb +++ b/spec/controllers/statuses_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe StatusesController do +RSpec.describe StatusesController do shared_let(:user) { create(:admin) } shared_let(:status) { create(:status) } diff --git a/spec/controllers/sys_controller_spec.rb b/spec/controllers/sys_controller_spec.rb index 00a0232960a..00523736424 100644 --- a/spec/controllers/sys_controller_spec.rb +++ b/spec/controllers/sys_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe SysController, with_settings: { sys_api_enabled: true } do +RSpec.describe SysController, with_settings: { sys_api_enabled: true } do let(:commit_role) do create(:role, permissions: %i[commit_access browse_repository]) end diff --git a/spec/controllers/types_controller_spec.rb b/spec/controllers/types_controller_spec.rb index a3b4ed5c4fb..3c928def1da 100644 --- a/spec/controllers/types_controller_spec.rb +++ b/spec/controllers/types_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe TypesController do +RSpec.describe TypesController do let(:project) do create(:project, work_package_custom_fields: [custom_field_2]) diff --git a/spec/controllers/users/memberships_controller_spec.rb b/spec/controllers/users/memberships_controller_spec.rb index ead43e8886c..16fb8868e7a 100644 --- a/spec/controllers/users/memberships_controller_spec.rb +++ b/spec/controllers/users/memberships_controller_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'work_package' -describe Users::MembershipsController do +RSpec.describe Users::MembershipsController do shared_let(:admin) { create(:admin) } let(:user) { create(:user) } diff --git a/spec/controllers/users_controller_spec.rb b/spec/controllers/users_controller_spec.rb index d4986be9c1d..fd92bcd5683 100644 --- a/spec/controllers/users_controller_spec.rb +++ b/spec/controllers/users_controller_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'work_package' -describe UsersController do +RSpec.describe UsersController do shared_let(:admin) { create(:admin) } shared_let(:anonymous) { User.anonymous } diff --git a/spec/controllers/versions_controller_spec.rb b/spec/controllers/versions_controller_spec.rb index 010328ea742..ef5e51b262f 100644 --- a/spec/controllers/versions_controller_spec.rb +++ b/spec/controllers/versions_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe VersionsController do +RSpec.describe VersionsController do let(:user) { create(:admin) } let(:project) { create(:public_project) } let(:version1) { create(:version, project:, effective_date: nil) } diff --git a/spec/controllers/wiki_controller_spec.rb b/spec/controllers/wiki_controller_spec.rb index e38624c84f4..06b3ca8bf09 100644 --- a/spec/controllers/wiki_controller_spec.rb +++ b/spec/controllers/wiki_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WikiController do +RSpec.describe WikiController do shared_let(:admin) { create(:admin) } shared_let(:project) do diff --git a/spec/controllers/wiki_menu_authentication_spec.rb b/spec/controllers/wiki_menu_authentication_spec.rb index c47c1e02b18..fd44696045f 100644 --- a/spec/controllers/wiki_menu_authentication_spec.rb +++ b/spec/controllers/wiki_menu_authentication_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WikiMenuItemsController do +RSpec.describe WikiMenuItemsController do before do User.delete_all Role.delete_all diff --git a/spec/controllers/wiki_menu_items_controller_spec.rb b/spec/controllers/wiki_menu_items_controller_spec.rb index df28f7d98fd..219e0a245aa 100644 --- a/spec/controllers/wiki_menu_items_controller_spec.rb +++ b/spec/controllers/wiki_menu_items_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WikiMenuItemsController do +RSpec.describe WikiMenuItemsController do let(:current_user) { create(:admin) } # create project with wiki diff --git a/spec/controllers/work_packages/auto_completes_controller_spec.rb b/spec/controllers/work_packages/auto_completes_controller_spec.rb index 2f89a1c109d..057990c263e 100644 --- a/spec/controllers/work_packages/auto_completes_controller_spec.rb +++ b/spec/controllers/work_packages/auto_completes_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::AutoCompletesController do +RSpec.describe WorkPackages::AutoCompletesController do let(:user) { create(:user) } let(:project) { create(:project) } let(:role) do diff --git a/spec/controllers/work_packages/bulk_controller_spec.rb b/spec/controllers/work_packages/bulk_controller_spec.rb index c754a2f6140..0ac16f7271b 100644 --- a/spec/controllers/work_packages/bulk_controller_spec.rb +++ b/spec/controllers/work_packages/bulk_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::BulkController, with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe WorkPackages::BulkController, with_settings: { journal_aggregation_time_minutes: 0 } do let(:user) { create(:user) } let(:user2) { create(:user) } let(:custom_field_value) { '125' } diff --git a/spec/controllers/work_packages/moves_controller_spec.rb b/spec/controllers/work_packages/moves_controller_spec.rb index 228cd7f247b..66a4fa4599f 100644 --- a/spec/controllers/work_packages/moves_controller_spec.rb +++ b/spec/controllers/work_packages/moves_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::MovesController, with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe WorkPackages::MovesController, with_settings: { journal_aggregation_time_minutes: 0 } do shared_let(:user) { create(:user) } shared_let(:role) do create(:role, diff --git a/spec/controllers/work_packages/reports_controller_spec.rb b/spec/controllers/work_packages/reports_controller_spec.rb index 3faac5ccf7c..325d98a01c4 100644 --- a/spec/controllers/work_packages/reports_controller_spec.rb +++ b/spec/controllers/work_packages/reports_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::ReportsController do +RSpec.describe WorkPackages::ReportsController do let(:user) { create(:user) } let(:project) { create(:project) } let(:role) do diff --git a/spec/controllers/work_packages_controller_spec.rb b/spec/controllers/work_packages_controller_spec.rb index 245aeb3c443..b482f7994e9 100644 --- a/spec/controllers/work_packages_controller_spec.rb +++ b/spec/controllers/work_packages_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackagesController do +RSpec.describe WorkPackagesController do before do login_as current_user end diff --git a/spec/controllers/workflows_controller_spec.rb b/spec/controllers/workflows_controller_spec.rb index 8c98c4362df..20c094a46a9 100644 --- a/spec/controllers/workflows_controller_spec.rb +++ b/spec/controllers/workflows_controller_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkflowsController do +RSpec.describe WorkflowsController do let!(:role) do build_stubbed(:role).tap do |r| allow(Role) diff --git a/spec/decorators/single_spec.rb b/spec/decorators/single_spec.rb index 7f6f223b26e..9a79b49f107 100644 --- a/spec/decorators/single_spec.rb +++ b/spec/decorators/single_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe API::Decorators::Single do +RSpec.describe API::Decorators::Single do let(:user) { create(:user, member_in_project: project, member_through_role: role) } let(:project) { create(:project_with_types) } let(:role) { create(:role, permissions:) } diff --git a/spec/features/accessibility/work_packages/work_package_query_spec.rb b/spec/features/accessibility/work_packages/work_package_query_spec.rb index 89a9cc581f0..5cf2fcc13ee 100644 --- a/spec/features/accessibility/work_packages/work_package_query_spec.rb +++ b/spec/features/accessibility/work_packages/work_package_query_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/work_packages/work_packages_page' -describe 'Work package index accessibility', selenium: true do +RSpec.describe 'Work package index accessibility', selenium: true do let(:user) { create(:admin) } let(:project) { create(:project) } let(:work_package) { create(:work_package, project:) } diff --git a/spec/features/activities/disabled_activity_spec.rb b/spec/features/activities/disabled_activity_spec.rb index 6494a8c9b40..a3857e78a07 100644 --- a/spec/features/activities/disabled_activity_spec.rb +++ b/spec/features/activities/disabled_activity_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Disabled activity' do +RSpec.describe 'Disabled activity' do shared_let(:admin) { create(:admin) } let(:project1) do diff --git a/spec/features/activities/project_attributes_activity_spec.rb b/spec/features/activities/project_attributes_activity_spec.rb index 4c89b459fc4..b7ba1eae500 100644 --- a/spec/features/activities/project_attributes_activity_spec.rb +++ b/spec/features/activities/project_attributes_activity_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Project attributes activities' do +RSpec.describe 'Project attributes activities' do let(:user) do create(:user, member_in_project: project, diff --git a/spec/features/activities/time_entry_activity_spec.rb b/spec/features/activities/time_entry_activity_spec.rb index 43cf8d1f4af..a3a3d68ee03 100644 --- a/spec/features/activities/time_entry_activity_spec.rb +++ b/spec/features/activities/time_entry_activity_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'TimeEntry activities', with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe 'TimeEntry activities', with_settings: { journal_aggregation_time_minutes: 0 } do let(:user) do create(:user, member_in_project: project, diff --git a/spec/features/activities/wiki_activity_spec.rb b/spec/features/activities/wiki_activity_spec.rb index 4ae7f245cbf..37fa5dac01f 100644 --- a/spec/features/activities/wiki_activity_spec.rb +++ b/spec/features/activities/wiki_activity_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Wiki activities' do +RSpec.describe 'Wiki activities' do let(:user) do create(:user, member_in_project: project, diff --git a/spec/features/admin/attribute_help_texts_spec.rb b/spec/features/admin/attribute_help_texts_spec.rb index b80e8556499..caf024ceb0b 100644 --- a/spec/features/admin/attribute_help_texts_spec.rb +++ b/spec/features/admin/attribute_help_texts_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Attribute help texts', js: true do +RSpec.describe 'Attribute help texts', js: true do shared_let(:admin) { create(:admin) } let(:instance) { AttributeHelpText.last } diff --git a/spec/features/admin/backup_spec.rb b/spec/features/admin/backup_spec.rb index e47244dc5c6..824341f24e6 100644 --- a/spec/features/admin/backup_spec.rb +++ b/spec/features/admin/backup_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'backup', js: true do +RSpec.describe 'backup', js: true do let(:current_user) do create(:user, global_permissions: [:create_backup], diff --git a/spec/features/admin/custom_fields/list_custom_field_spec.rb b/spec/features/admin/custom_fields/list_custom_field_spec.rb index bb47ef24fad..5d249e428ac 100644 --- a/spec/features/admin/custom_fields/list_custom_field_spec.rb +++ b/spec/features/admin/custom_fields/list_custom_field_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'List custom fields edit', js: true do +RSpec.describe 'List custom fields edit', js: true do shared_let(:admin) { create(:admin) } before do diff --git a/spec/features/admin/custom_fields/multi_value_custom_fields_spec.rb b/spec/features/admin/custom_fields/multi_value_custom_fields_spec.rb index 605e48ec7ac..298b293106a 100644 --- a/spec/features/admin/custom_fields/multi_value_custom_fields_spec.rb +++ b/spec/features/admin/custom_fields/multi_value_custom_fields_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Multi-value custom fields creation', js: true do +RSpec.describe 'Multi-value custom fields creation', js: true do shared_let(:admin) { create(:admin) } before do diff --git a/spec/features/admin/enterprise/enterprise_spec.rb b/spec/features/admin/enterprise/enterprise_spec.rb index 4dd31b13035..a799f009c47 100644 --- a/spec/features/admin/enterprise/enterprise_spec.rb +++ b/spec/features/admin/enterprise/enterprise_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Enterprise token', js: true do +RSpec.describe 'Enterprise token', js: true do include Redmine::I18n shared_let(:admin) { create(:admin) } diff --git a/spec/features/admin/enterprise/enterprise_trial_spec.rb b/spec/features/admin/enterprise/enterprise_trial_spec.rb index c1f34ca1e7d..160f12a22a9 100644 --- a/spec/features/admin/enterprise/enterprise_trial_spec.rb +++ b/spec/features/admin/enterprise/enterprise_trial_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Enterprise trial management', - driver: :chrome_billy do +RSpec.describe 'Enterprise trial management', + driver: :chrome_billy do let(:admin) { create(:admin) } let(:trial_id) { '1b6486b4-5a30-4042-8714-99d7c8e6b637' } diff --git a/spec/features/admin/enterprise/token_domain_spec.rb b/spec/features/admin/enterprise/token_domain_spec.rb index 5eb80de97c0..846b02834b9 100644 --- a/spec/features/admin/enterprise/token_domain_spec.rb +++ b/spec/features/admin/enterprise/token_domain_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Enterprise Edition token domain', js: true do +RSpec.describe 'Enterprise Edition token domain', js: true do let(:current_user) { create(:admin) } let(:ee_token) { Rails.root.join("spec/fixtures/ee_tokens/v2_1_user_localhost_3001.token").read } diff --git a/spec/features/admin/enumerations_spec.rb b/spec/features/admin/enumerations_spec.rb index 2c8607e7987..e48603ea26b 100644 --- a/spec/features/admin/enumerations_spec.rb +++ b/spec/features/admin/enumerations_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Enumerations' do +RSpec.describe 'Enumerations' do shared_let(:admin) { create(:admin) } before do diff --git a/spec/features/admin/menu_item_traversal_spec.rb b/spec/features/admin/menu_item_traversal_spec.rb index 2d57d936c58..a59a716790e 100644 --- a/spec/features/admin/menu_item_traversal_spec.rb +++ b/spec/features/admin/menu_item_traversal_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Menu item traversal' do +RSpec.describe 'Menu item traversal' do shared_let(:admin) { create(:admin) } describe 'EnterpriseToken management' do diff --git a/spec/features/admin/oauth/oauth_applications_management_spec.rb b/spec/features/admin/oauth/oauth_applications_management_spec.rb index 1ae84c24abd..9c533b4b682 100644 --- a/spec/features/admin/oauth/oauth_applications_management_spec.rb +++ b/spec/features/admin/oauth/oauth_applications_management_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'OAuth applications management', js: true do +RSpec.describe 'OAuth applications management', js: true do let(:admin) { create(:admin) } before do diff --git a/spec/features/admin/settings_spec.rb b/spec/features/admin/settings_spec.rb index 165a98652ac..4e3ab81fa07 100644 --- a/spec/features/admin/settings_spec.rb +++ b/spec/features/admin/settings_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Settings' do +RSpec.describe 'Settings' do let(:admin) { create(:admin) } describe 'subsection' do diff --git a/spec/features/admin/test_mail_notification_spec.rb b/spec/features/admin/test_mail_notification_spec.rb index a8bab53b18d..d8e54177638 100644 --- a/spec/features/admin/test_mail_notification_spec.rb +++ b/spec/features/admin/test_mail_notification_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Test mail notification', js: true do +RSpec.describe 'Test mail notification', js: true do shared_let(:admin) { create(:admin) } before do diff --git a/spec/features/admin/working_days_spec.rb b/spec/features/admin/working_days_spec.rb index 035de2e154c..d66d093eaab 100644 --- a/spec/features/admin/working_days_spec.rb +++ b/spec/features/admin/working_days_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Working Days', js: true do +RSpec.describe 'Working Days', js: true do create_shared_association_defaults_for_work_package_factory shared_let(:week_days) { week_with_saturday_and_sunday_as_weekend } diff --git a/spec/features/attachments/attachments_spec.rb b/spec/features/attachments/attachments_spec.rb index 2999ccdbb2f..5816d218f9b 100644 --- a/spec/features/attachments/attachments_spec.rb +++ b/spec/features/attachments/attachments_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'attachments' do +RSpec.describe 'attachments' do let(:project) { create(:valid_project) } let(:current_user) { create(:admin) } let!(:priority) { create(:default_priority) } diff --git a/spec/features/auth/auth_source_sso_login_spec.rb b/spec/features/auth/auth_source_sso_login_spec.rb index 2b9091ef5f8..e99d83c5290 100644 --- a/spec/features/auth/auth_source_sso_login_spec.rb +++ b/spec/features/auth/auth_source_sso_login_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Login with auth source SSO' do +RSpec.describe 'Login with auth source SSO' do before do if sso_config allow(OpenProject::Configuration) diff --git a/spec/features/auth/auth_source_sso_logout_spec.rb b/spec/features/auth/auth_source_sso_logout_spec.rb index 544baef16a0..1ea4b4c0fca 100644 --- a/spec/features/auth/auth_source_sso_logout_spec.rb +++ b/spec/features/auth/auth_source_sso_logout_spec.rb @@ -32,8 +32,8 @@ Capybara.register_driver :auth_source_sso do |app| Capybara::RackTest::Driver.new(app, headers: { 'HTTP_X_REMOTE_USER' => 'bob' }) end -describe 'Login with auth source SSO', - driver: :auth_source_sso do +RSpec.describe 'Login with auth source SSO', + driver: :auth_source_sso do before do allow(OpenProject::Configuration) .to receive(:auth_source_sso) diff --git a/spec/features/auth/auth_stages_spec.rb b/spec/features/auth/auth_stages_spec.rb index dd2eb2ff920..b582633a1e0 100644 --- a/spec/features/auth/auth_stages_spec.rb +++ b/spec/features/auth/auth_stages_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Authentication Stages', - skip_2fa_stage: true do +RSpec.describe 'Authentication Stages', + skip_2fa_stage: true do before do @capybara_ignore_elements = Capybara.ignore_hidden_elements Capybara.ignore_hidden_elements = true diff --git a/spec/features/auth/consent_auth_stage_spec.rb b/spec/features/auth/consent_auth_stage_spec.rb index ac39d871c7a..eb378bf5c8f 100644 --- a/spec/features/auth/consent_auth_stage_spec.rb +++ b/spec/features/auth/consent_auth_stage_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Authentication Stages' do +RSpec.describe 'Authentication Stages' do let(:language) { 'en' } let(:user_password) { 'bob' * 4 } let(:user) do diff --git a/spec/features/auth/login_spec.rb b/spec/features/auth/login_spec.rb index 62375119e52..627d18b9b48 100644 --- a/spec/features/auth/login_spec.rb +++ b/spec/features/auth/login_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Login' do +RSpec.describe 'Login' do before do @capybara_ignore_elements = Capybara.ignore_hidden_elements Capybara.ignore_hidden_elements = true diff --git a/spec/features/auth/logout_spec.rb b/spec/features/auth/logout_spec.rb index 4033a1a2c86..af414f3d1cc 100644 --- a/spec/features/auth/logout_spec.rb +++ b/spec/features/auth/logout_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Logout', js: true do +RSpec.describe 'Logout', js: true do let(:user_password) { 'b0B' * 4 } let(:user) do create(:user, diff --git a/spec/features/auth/lost_password_spec.rb b/spec/features/auth/lost_password_spec.rb index 04f0dba6bb9..24e600dab73 100644 --- a/spec/features/auth/lost_password_spec.rb +++ b/spec/features/auth/lost_password_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Lost password' do +RSpec.describe 'Lost password' do let!(:user) { create(:user) } let(:new_password) { "new_PassW0rd!" } diff --git a/spec/features/auth/omniauth_spec.rb b/spec/features/auth/omniauth_spec.rb index adf9ce9c694..9be7e9c1dc0 100644 --- a/spec/features/auth/omniauth_spec.rb +++ b/spec/features/auth/omniauth_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Omniauth authentication' do +RSpec.describe 'Omniauth authentication' do # Load ViewAccountLoginAuthProvider to have this spec passing OpenProject::Hooks::ViewAccountLoginAuthProvider diff --git a/spec/features/categories/delete_spec.rb b/spec/features/categories/delete_spec.rb index 14a404aab2b..2bc0a0ae0c7 100644 --- a/spec/features/categories/delete_spec.rb +++ b/spec/features/categories/delete_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/categories/categories_page' -describe 'Deletion', js: true do +RSpec.describe 'Deletion', js: true do let(:current_user) do create(:user, member_in_project: category.project, diff --git a/spec/features/colors/color_administration_spec.rb b/spec/features/colors/color_administration_spec.rb index ad8dffc6e62..8c1b89923a3 100644 --- a/spec/features/colors/color_administration_spec.rb +++ b/spec/features/colors/color_administration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'color administration' do +RSpec.describe 'color administration' do shared_let(:admin) { create(:admin) } before do diff --git a/spec/features/custom_fields/activate_in_project_spec.rb b/spec/features/custom_fields/activate_in_project_spec.rb index fad6790b2a6..196c1f98c03 100644 --- a/spec/features/custom_fields/activate_in_project_spec.rb +++ b/spec/features/custom_fields/activate_in_project_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'support/pages/custom_fields' -describe 'custom fields', js: true do +RSpec.describe 'custom fields', js: true do let(:user) { create(:admin) } let(:cf_page) { Pages::CustomFields.new } let(:for_all_cf) { create(:list_wp_custom_field, is_for_all: true) } diff --git a/spec/features/custom_fields/create_bool_spec.rb b/spec/features/custom_fields/create_bool_spec.rb index 0fc67d02d9d..20cc5cd6420 100644 --- a/spec/features/custom_fields/create_bool_spec.rb +++ b/spec/features/custom_fields/create_bool_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require 'support/pages/custom_fields' -describe 'custom fields', js: true do +RSpec.describe 'custom fields', js: true do let(:user) { create(:admin) } let(:cf_page) { Pages::CustomFields.new } diff --git a/spec/features/custom_fields/create_date_spec.rb b/spec/features/custom_fields/create_date_spec.rb index e76f042dfa6..40c8899dbd4 100644 --- a/spec/features/custom_fields/create_date_spec.rb +++ b/spec/features/custom_fields/create_date_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require 'support/pages/custom_fields' -describe 'custom fields', js: true do +RSpec.describe 'custom fields', js: true do let(:user) { create(:admin) } let(:cf_page) { Pages::CustomFields.new } diff --git a/spec/features/custom_fields/create_float_spec.rb b/spec/features/custom_fields/create_float_spec.rb index d41776e9879..9e5530ab2c7 100644 --- a/spec/features/custom_fields/create_float_spec.rb +++ b/spec/features/custom_fields/create_float_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require 'support/pages/custom_fields' -describe 'custom fields', js: true do +RSpec.describe 'custom fields', js: true do let(:user) { create(:admin) } let(:cf_page) { Pages::CustomFields.new } diff --git a/spec/features/custom_fields/create_int_spec.rb b/spec/features/custom_fields/create_int_spec.rb index 76080ac458b..0f0ae016a6a 100644 --- a/spec/features/custom_fields/create_int_spec.rb +++ b/spec/features/custom_fields/create_int_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require 'support/pages/custom_fields' -describe 'custom fields', js: true do +RSpec.describe 'custom fields', js: true do let(:user) { create(:admin) } let(:cf_page) { Pages::CustomFields.new } diff --git a/spec/features/custom_fields/create_long_text_spec.rb b/spec/features/custom_fields/create_long_text_spec.rb index d0ccefb8e92..9b6067078c5 100644 --- a/spec/features/custom_fields/create_long_text_spec.rb +++ b/spec/features/custom_fields/create_long_text_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require 'support/pages/custom_fields' -describe 'custom fields', js: true do +RSpec.describe 'custom fields', js: true do let(:user) { create(:admin) } let(:cf_page) { Pages::CustomFields.new } let(:editor) { Components::WysiwygEditor.new '#custom_field_form' } diff --git a/spec/features/custom_fields/custom_fields_spec.rb b/spec/features/custom_fields/custom_fields_spec.rb index baf865d9442..e06e8374718 100644 --- a/spec/features/custom_fields/custom_fields_spec.rb +++ b/spec/features/custom_fields/custom_fields_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require 'support/pages/custom_fields' -describe 'custom fields', js: true do +RSpec.describe 'custom fields', js: true do let(:user) { create(:admin) } let(:cf_page) { Pages::CustomFields.new } diff --git a/spec/features/custom_fields/multi_user_custom_field_spec.rb b/spec/features/custom_fields/multi_user_custom_field_spec.rb index 03dc654f92f..22beb6e26c8 100644 --- a/spec/features/custom_fields/multi_user_custom_field_spec.rb +++ b/spec/features/custom_fields/multi_user_custom_field_spec.rb @@ -1,7 +1,7 @@ require "spec_helper" require "support/pages/work_packages/abstract_work_package" -describe "multi select custom values", js: true do +RSpec.describe "multi select custom values", js: true do shared_let(:admin) { create(:admin) } let(:current_user) { admin } let(:wp_page) { Pages::FullWorkPackage.new work_package } diff --git a/spec/features/custom_fields/multi_value_custom_field_spec.rb b/spec/features/custom_fields/multi_value_custom_field_spec.rb index 5afff1e01f3..2d327ee0b40 100644 --- a/spec/features/custom_fields/multi_value_custom_field_spec.rb +++ b/spec/features/custom_fields/multi_value_custom_field_spec.rb @@ -1,7 +1,7 @@ require "spec_helper" require "support/pages/work_packages/abstract_work_package" -describe "multi select custom values", js: true do +RSpec.describe "multi select custom values", js: true do let(:type) { create(:type) } let(:wp_page) { Pages::FullWorkPackage.new work_package } let(:wp_table) { Pages::WorkPackagesTable.new project } diff --git a/spec/features/custom_fields/reorder_options_spec.rb b/spec/features/custom_fields/reorder_options_spec.rb index 7febe8acb35..9ccd8269612 100644 --- a/spec/features/custom_fields/reorder_options_spec.rb +++ b/spec/features/custom_fields/reorder_options_spec.rb @@ -13,7 +13,7 @@ def get_possible_values_reordered(amount) get_possible_values(amount).sort end -describe 'Reordering custom options of a list custom field', js: true do +RSpec.describe 'Reordering custom options of a list custom field', js: true do let(:user) { create(:admin) } let(:cf_page) { Pages::CustomFields.new } diff --git a/spec/features/errors/errors_handler_spec.rb b/spec/features/errors/errors_handler_spec.rb index b89477e7e21..47095353a51 100644 --- a/spec/features/errors/errors_handler_spec.rb +++ b/spec/features/errors/errors_handler_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Errors handling' do +RSpec.describe 'Errors handling' do it 'renders the internal error page in case of exceptions' do # We unfortunately cannot test raising exceptions as the test environment # marks all requests as local and thus shows exception details instead (like in dev mode) diff --git a/spec/features/forums/attachment_upload_spec.rb b/spec/features/forums/attachment_upload_spec.rb index 93bae34d48d..fb82396e14c 100644 --- a/spec/features/forums/attachment_upload_spec.rb +++ b/spec/features/forums/attachment_upload_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/page_objects/notification' -describe 'Upload attachment to forum message', js: true do +RSpec.describe 'Upload attachment to forum message', js: true do let(:forum) { create(:forum) } let(:user) do create(:user, diff --git a/spec/features/forums/message_spec.rb b/spec/features/forums/message_spec.rb index 58d2dab83b3..07c4306b1fb 100644 --- a/spec/features/forums/message_spec.rb +++ b/spec/features/forums/message_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'messages', js: true do +RSpec.describe 'messages', js: true do let(:forum) do create(:forum) end diff --git a/spec/features/forums/sticky_spec.rb b/spec/features/forums/sticky_spec.rb index 0a25c28f116..3ee3c2013fc 100644 --- a/spec/features/forums/sticky_spec.rb +++ b/spec/features/forums/sticky_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'sticky messages' do +RSpec.describe 'sticky messages' do let(:forum) { create(:forum) } let!(:message1) do diff --git a/spec/features/global_roles/global_create_project_spec.rb b/spec/features/global_roles/global_create_project_spec.rb index 53b06663429..de2f5fcdd39 100644 --- a/spec/features/global_roles/global_create_project_spec.rb +++ b/spec/features/global_roles/global_create_project_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Global role: Global Create project', js: true do +RSpec.describe 'Global role: Global Create project', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/spec/features/global_roles/global_role_assignment_spec.rb b/spec/features/global_roles/global_role_assignment_spec.rb index caa89e1079f..e1f9bad355d 100644 --- a/spec/features/global_roles/global_role_assignment_spec.rb +++ b/spec/features/global_roles/global_role_assignment_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './mock_global_permissions' -describe 'Global role: Global role assignment', js: true do +RSpec.describe 'Global role: Global role assignment', js: true do before do login_as(current_user) end diff --git a/spec/features/global_roles/global_role_crud_spec.rb b/spec/features/global_roles/global_role_crud_spec.rb index 8868d287143..de7423fed44 100644 --- a/spec/features/global_roles/global_role_crud_spec.rb +++ b/spec/features/global_roles/global_role_crud_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './mock_global_permissions' -describe 'Global role: Global role CRUD', js: true do +RSpec.describe 'Global role: Global role CRUD', js: true do # Scenario: Global Role creation # Given there is the global permission "glob_test" of the module "global_group" before do diff --git a/spec/features/global_roles/member_roles_spec.rb b/spec/features/global_roles/member_roles_spec.rb index eaee8d01ad2..acb33175e92 100644 --- a/spec/features/global_roles/member_roles_spec.rb +++ b/spec/features/global_roles/member_roles_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Global role: Unchanged Member Roles', js: true do +RSpec.describe 'Global role: Unchanged Member Roles', js: true do let(:admin) { create(:admin) } let(:project) { create(:project) } let!(:role) { create(:role, name: 'MemberRole1') } diff --git a/spec/features/global_roles/no_module_spec.rb b/spec/features/global_roles/no_module_spec.rb index 48c0ee1b514..59d69bf77d5 100644 --- a/spec/features/global_roles/no_module_spec.rb +++ b/spec/features/global_roles/no_module_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './mock_global_permissions' -describe 'Global role: No module', js: true do +RSpec.describe 'Global role: No module', js: true do let(:admin) { create(:admin) } let(:project) { create(:project) } let!(:role) { create(:role) } diff --git a/spec/features/groups/group_memberships_spec.rb b/spec/features/groups/group_memberships_spec.rb index 215c9283816..6007f6db7da 100644 --- a/spec/features/groups/group_memberships_spec.rb +++ b/spec/features/groups/group_memberships_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'group memberships through groups page', js: true do +RSpec.describe 'group memberships through groups page', js: true do shared_let(:admin) { create(:admin) } let!(:project) do create(:project, name: 'Project 1', identifier: 'project1', members: project_members) diff --git a/spec/features/groups/group_show_spec.rb b/spec/features/groups/group_show_spec.rb index 23f4c6fd51f..f7ed8966790 100644 --- a/spec/features/groups/group_show_spec.rb +++ b/spec/features/groups/group_show_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'group show page' do +RSpec.describe 'group show page' do let!(:member) { create(:user) } let!(:group) { create(:group, lastname: "Bob's Team", members: [member]) } diff --git a/spec/features/groups/groups_spec.rb b/spec/features/groups/groups_spec.rb index f6b52c6269b..8bb56f194de 100644 --- a/spec/features/groups/groups_spec.rb +++ b/spec/features/groups/groups_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'group memberships through groups page', js: true do +RSpec.describe 'group memberships through groups page', js: true do shared_let(:admin) { create(:admin) } let!(:group) { create(:group, lastname: "Bob's Team") } diff --git a/spec/features/groups/membership_spec.rb b/spec/features/groups/membership_spec.rb index 5328c491346..e9cd5150544 100644 --- a/spec/features/groups/membership_spec.rb +++ b/spec/features/groups/membership_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'group memberships through project members page', js: true do +RSpec.describe 'group memberships through project members page', js: true do shared_let(:admin) { create(:admin) } let(:project) { create(:project, name: 'Project 1', identifier: 'project1', members: project_member) } diff --git a/spec/features/homescreen/robots_spec.rb b/spec/features/homescreen/robots_spec.rb index 31a7a137b21..cf807210d45 100644 --- a/spec/features/homescreen/robots_spec.rb +++ b/spec/features/homescreen/robots_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'robots.txt' do +RSpec.describe 'robots.txt' do let!(:project) { create(:public_project) } before do diff --git a/spec/features/localization_spec.rb b/spec/features/localization_spec.rb index 158578410b6..2043520d703 100644 --- a/spec/features/localization_spec.rb +++ b/spec/features/localization_spec.rb @@ -28,9 +28,9 @@ require 'spec_helper' -describe 'Localization', with_settings: { login_required?: false, - available_languages: %i[de en], - default_language: 'en' } do +RSpec.describe 'Localization', with_settings: { login_required?: false, + available_languages: %i[de en], + default_language: 'en' } do it 'set localization' do Capybara.current_session.driver.header('Accept-Language', 'de,de-de;q=0.8,en-us;q=0.5,en;q=0.3') diff --git a/spec/features/members/error_messages_spec.rb b/spec/features/members/error_messages_spec.rb index db86542055a..c8583b79b05 100644 --- a/spec/features/members/error_messages_spec.rb +++ b/spec/features/members/error_messages_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Group memberships through groups page' do +RSpec.describe 'Group memberships through groups page' do shared_let(:admin) { create(:admin) } let!(:project) { create(:project, name: 'Project 1', identifier: 'project1') } diff --git a/spec/features/members/invitation_spec.rb b/spec/features/members/invitation_spec.rb index 6825c629f0c..a4281ee37de 100644 --- a/spec/features/members/invitation_spec.rb +++ b/spec/features/members/invitation_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'invite user via email', js: true do +RSpec.describe 'invite user via email', js: true do let!(:project) { create(:project, name: 'Project 1', identifier: 'project1', members: project_members) } let!(:developer) { create(:role, name: 'Developer') } let(:project_members) { {} } diff --git a/spec/features/members/membership_filter_spec.rb b/spec/features/members/membership_filter_spec.rb index 6d7465b9d97..47f52a72a29 100644 --- a/spec/features/members/membership_filter_spec.rb +++ b/spec/features/members/membership_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'group memberships through groups page', js: true do +RSpec.describe 'group memberships through groups page', js: true do shared_let(:admin) { create(:admin) } let!(:project) { create(:project, name: 'Project 1', identifier: 'project1') } diff --git a/spec/features/members/membership_spec.rb b/spec/features/members/membership_spec.rb index 70b072ff7ca..12592acaa57 100644 --- a/spec/features/members/membership_spec.rb +++ b/spec/features/members/membership_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Administrating memberships via the project settings', js: true do +RSpec.describe 'Administrating memberships via the project settings', js: true do shared_let(:admin) { create(:admin) } let(:current_user) do create(:user, diff --git a/spec/features/members/pagination_spec.rb b/spec/features/members/pagination_spec.rb index 6de57f29410..192d9334aaa 100644 --- a/spec/features/members/pagination_spec.rb +++ b/spec/features/members/pagination_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'members pagination', js: true do +RSpec.describe 'members pagination', js: true do shared_let(:admin) { create(:admin) } let(:project) do create(:project, diff --git a/spec/features/members/roles_spec.rb b/spec/features/members/roles_spec.rb index 8f20c094d51..1852025593f 100644 --- a/spec/features/members/roles_spec.rb +++ b/spec/features/members/roles_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'members pagination', js: true do +RSpec.describe 'members pagination', js: true do shared_let(:admin) { create(:admin) } let(:project) do create(:project, diff --git a/spec/features/menu_items/admin_menu_item_spec.rb b/spec/features/menu_items/admin_menu_item_spec.rb index d1a86cbe7e5..bc6283e936a 100644 --- a/spec/features/menu_items/admin_menu_item_spec.rb +++ b/spec/features/menu_items/admin_menu_item_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Admin menu items', js: true do +RSpec.describe 'Admin menu items', js: true do let(:user) { create(:admin) } before do diff --git a/spec/features/menu_items/menu_permissions_spec.rb b/spec/features/menu_items/menu_permissions_spec.rb index d62e6fdc78b..efa3371182c 100644 --- a/spec/features/menu_items/menu_permissions_spec.rb +++ b/spec/features/menu_items/menu_permissions_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'menu permissions', js: true do +RSpec.describe 'menu permissions', js: true do let(:user) do create(:user, member_in_project: project, diff --git a/spec/features/menu_items/quick_add_menu_spec.rb b/spec/features/menu_items/quick_add_menu_spec.rb index 30f8cf3df13..3842f18906b 100644 --- a/spec/features/menu_items/quick_add_menu_spec.rb +++ b/spec/features/menu_items/quick_add_menu_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Quick-add menu', js: true, selenium: true do +RSpec.describe 'Quick-add menu', js: true, selenium: true do let(:quick_add) { Components::QuickAddMenu.new } context 'as a logged in user with add_project permission' do diff --git a/spec/features/menu_items/top_menu_item_spec.rb b/spec/features/menu_items/top_menu_item_spec.rb index 59a5713d31e..340a4a0b111 100644 --- a/spec/features/menu_items/top_menu_item_spec.rb +++ b/spec/features/menu_items/top_menu_item_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Top menu items', js: true, selenium: true do +RSpec.describe 'Top menu items', js: true, selenium: true do let(:user) { create(:user) } let(:open_menu) { true } diff --git a/spec/features/menu_items/wiki_menu_item_spec.rb b/spec/features/menu_items/wiki_menu_item_spec.rb index dad813d26bf..af66ae81ee1 100644 --- a/spec/features/menu_items/wiki_menu_item_spec.rb +++ b/spec/features/menu_items/wiki_menu_item_spec.rb @@ -31,7 +31,7 @@ require 'features/page_objects/notification' require 'features/work_packages/shared_contexts' require 'features/work_packages/work_packages_page' -describe 'Wiki menu items' do +RSpec.describe 'Wiki menu items' do let(:user) do create(:user, member_in_project: project, diff --git a/spec/features/news/creation_and_commenting_spec.rb b/spec/features/news/creation_and_commenting_spec.rb index e45a956fcdb..b2555174e89 100644 --- a/spec/features/news/creation_and_commenting_spec.rb +++ b/spec/features/news/creation_and_commenting_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'News creation and commenting', js: true do +RSpec.describe 'News creation and commenting', js: true do let(:project) { create(:project) } let!(:other_user) do create(:user, diff --git a/spec/features/notifications/navigation_spec.rb b/spec/features/notifications/navigation_spec.rb index 94dad8e9f60..318f803dd48 100644 --- a/spec/features/notifications/navigation_spec.rb +++ b/spec/features/notifications/navigation_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe "Notification center navigation", js: true do +RSpec.describe "Notification center navigation", js: true do shared_association_default(:project) { create(:project) } shared_let(:work_package) { create(:work_package, project:) } diff --git a/spec/features/notifications/notification_center/notification_center_date_alerts_spec.rb b/spec/features/notifications/notification_center/notification_center_date_alerts_spec.rb index f2d4fe78aff..94f2903d01f 100644 --- a/spec/features/notifications/notification_center/notification_center_date_alerts_spec.rb +++ b/spec/features/notifications/notification_center/notification_center_date_alerts_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' require 'features/page_objects/notification' # rubocop:disable RSpec/ScatteredLet -describe "Notification center date alerts", js: true, with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe "Notification center date alerts", js: true, with_settings: { journal_aggregation_time_minutes: 0 } do include ActiveSupport::Testing::TimeHelpers # Find an assignable time zone with the same UTC offset as the local time zone diff --git a/spec/features/notifications/notification_center/notification_center_sidemenu_spec.rb b/spec/features/notifications/notification_center/notification_center_sidemenu_spec.rb index f2c6d19ab1b..61a291c6a29 100644 --- a/spec/features/notifications/notification_center/notification_center_sidemenu_spec.rb +++ b/spec/features/notifications/notification_center/notification_center_sidemenu_spec.rb @@ -1,8 +1,8 @@ require 'spec_helper' -describe "Notification center sidemenu", - js: true, - with_ee: %i[date_alerts] do +RSpec.describe "Notification center sidemenu", + js: true, + with_ee: %i[date_alerts] do shared_let(:project) { create(:project) } shared_let(:project2) { create(:project) } shared_let(:project3) { create(:project, parent: project2) } diff --git a/spec/features/notifications/notification_center/notification_center_spec.rb b/spec/features/notifications/notification_center/notification_center_spec.rb index d04e41e18b2..3aea43552bd 100644 --- a/spec/features/notifications/notification_center/notification_center_spec.rb +++ b/spec/features/notifications/notification_center/notification_center_spec.rb @@ -1,9 +1,9 @@ require 'spec_helper' -describe "Notification center", - js: true, - with_ee: %i[date_alerts], - with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe "Notification center", + js: true, + with_ee: %i[date_alerts], + with_settings: { journal_aggregation_time_minutes: 0 } do # Notice that the setup in this file here is not following the normal rules as # it also tests notification creation. let!(:project1) { create(:project) } diff --git a/spec/features/notifications/notification_center/split_screen_spec.rb b/spec/features/notifications/notification_center/split_screen_spec.rb index cb0904409a4..e2f2fd4df52 100644 --- a/spec/features/notifications/notification_center/split_screen_spec.rb +++ b/spec/features/notifications/notification_center/split_screen_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe "Split screen in the notification center", js: true do +RSpec.describe "Split screen in the notification center", js: true do let(:global_html_title) { Components::HtmlTitle.new } let(:center) { Pages::Notifications::Center.new } let(:split_screen) { Pages::Notifications::SplitScreen.new work_package } diff --git a/spec/features/notifications/reminder_mail_spec.rb b/spec/features/notifications/reminder_mail_spec.rb index a836d8c38e3..92848ba6404 100644 --- a/spec/features/notifications/reminder_mail_spec.rb +++ b/spec/features/notifications/reminder_mail_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require_relative '../users/notifications/shared_examples' -describe "Reminder email sending", js: true do +RSpec.describe "Reminder email sending", js: true do let!(:project) { create(:project, members: { current_user => role }) } let!(:mute_project) { create(:project, members: { current_user => role }) } let(:role) { create(:role, permissions: %i[view_work_packages]) } diff --git a/spec/features/notifications/settings/immediate_reminder_spec.rb b/spec/features/notifications/settings/immediate_reminder_spec.rb index b257c3b7953..f1f7be8c738 100644 --- a/spec/features/notifications/settings/immediate_reminder_spec.rb +++ b/spec/features/notifications/settings/immediate_reminder_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe "Immediate reminder settings", js: true do +RSpec.describe "Immediate reminder settings", js: true do shared_examples 'immediate reminder settings' do it 'allows to configure the reminder settings' do # Save prefs so we can reload them later diff --git a/spec/features/notifications/settings/my_notifications_settings_spec.rb b/spec/features/notifications/settings/my_notifications_settings_spec.rb index 310698e085d..201caf10122 100644 --- a/spec/features/notifications/settings/my_notifications_settings_spec.rb +++ b/spec/features/notifications/settings/my_notifications_settings_spec.rb @@ -2,7 +2,7 @@ require 'rails_helper' require_relative '../../users/notifications/shared_examples' require 'support/pages/my/notifications' -describe "My notifications settings", js: true do +RSpec.describe "My notifications settings", js: true do current_user { create(:user) } let(:settings_page) { Pages::My::Notifications.new(current_user) } diff --git a/spec/features/notifications/settings/pause_reminder_settings_spec.rb b/spec/features/notifications/settings/pause_reminder_settings_spec.rb index 578046b6dea..6532a2c0bd8 100644 --- a/spec/features/notifications/settings/pause_reminder_settings_spec.rb +++ b/spec/features/notifications/settings/pause_reminder_settings_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe "Pause reminder settings", js: true do +RSpec.describe "Pause reminder settings", js: true do shared_examples 'pause reminder settings' do let(:first) { Time.zone.today.beginning_of_month } let(:last) { (Time.zone.today.beginning_of_month + 10.days) } diff --git a/spec/features/notifications/settings/reminder_email_settings_spec.rb b/spec/features/notifications/settings/reminder_email_settings_spec.rb index 9e228fbc71e..2b5508557a9 100644 --- a/spec/features/notifications/settings/reminder_email_settings_spec.rb +++ b/spec/features/notifications/settings/reminder_email_settings_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require_relative '../../users/notifications/shared_examples' -describe "Reminder email", js: true do +RSpec.describe "Reminder email", js: true do shared_examples 'reminder settings' do it 'allows to configure the reminder settings' do # Configure the digest diff --git a/spec/features/notifications/settings/workdays_settings_spec.rb b/spec/features/notifications/settings/workdays_settings_spec.rb index b0179d8c7b3..84a117ec6cc 100644 --- a/spec/features/notifications/settings/workdays_settings_spec.rb +++ b/spec/features/notifications/settings/workdays_settings_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe "Workday notification settings", js: true do +RSpec.describe "Workday notification settings", js: true do shared_examples 'workday settings' do before do current_user.language = locale diff --git a/spec/features/oauth/authorization_code_flow_spec.rb b/spec/features/oauth/authorization_code_flow_spec.rb index 6fdddbcea26..b982b619a09 100644 --- a/spec/features/oauth/authorization_code_flow_spec.rb +++ b/spec/features/oauth/authorization_code_flow_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'OAuth authorization code flow', - js: true do +RSpec.describe 'OAuth authorization code flow', + js: true do let!(:user) { create(:user) } let!(:redirect_uri) { 'urn:ietf:wg:oauth:2.0:oob' } let!(:allowed_redirect_uri) { redirect_uri } diff --git a/spec/features/oauth/pkce_spec.rb b/spec/features/oauth/pkce_spec.rb index ff860e7d681..29075fa45dd 100644 --- a/spec/features/oauth/pkce_spec.rb +++ b/spec/features/oauth/pkce_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'OAuth authorization code flow with PKCE', - js: true do +RSpec.describe 'OAuth authorization code flow with PKCE', + js: true do let!(:user) { create(:user) } let!(:redirect_uri) { 'urn:ietf:wg:oauth:2.0:oob' } let!(:allowed_redirect_uri) { redirect_uri } diff --git a/spec/features/onboarding/onboarding_tour_spec.rb b/spec/features/onboarding/onboarding_tour_spec.rb index f719675628e..02ff22f2835 100644 --- a/spec/features/onboarding/onboarding_tour_spec.rb +++ b/spec/features/onboarding/onboarding_tour_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'onboarding tour for new users', js: true do +RSpec.describe 'onboarding tour for new users', js: true do let(:user) { create(:admin) } let(:project) do create(:project, name: 'Demo project', identifier: 'demo-project', public: true, diff --git a/spec/features/placeholder_users/create_spec.rb b/spec/features/placeholder_users/create_spec.rb index 0fd4f6e03e5..f32f1cd6bac 100644 --- a/spec/features/placeholder_users/create_spec.rb +++ b/spec/features/placeholder_users/create_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'create placeholder users', selenium: true do +RSpec.describe 'create placeholder users', selenium: true do let(:new_placeholder_user_page) { Pages::NewPlaceholderUser.new } shared_examples_for 'placeholders creation flow' do diff --git a/spec/features/placeholder_users/delete_spec.rb b/spec/features/placeholder_users/delete_spec.rb index 2717cac92e9..52a55eebd26 100644 --- a/spec/features/placeholder_users/delete_spec.rb +++ b/spec/features/placeholder_users/delete_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'delete placeholder user', js: true do +RSpec.describe 'delete placeholder user', js: true do shared_let(:placeholder_user) { create(:placeholder_user, name: 'UX Developer') } shared_examples 'placeholders delete flow' do diff --git a/spec/features/placeholder_users/edit_placeholder_users_spec.rb b/spec/features/placeholder_users/edit_placeholder_users_spec.rb index 73cc328c010..2691606d26c 100644 --- a/spec/features/placeholder_users/edit_placeholder_users_spec.rb +++ b/spec/features/placeholder_users/edit_placeholder_users_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'edit placeholder users', js: true do +RSpec.describe 'edit placeholder users', js: true do shared_let(:placeholder_user) { create(:placeholder_user, name: 'UX Developer') } shared_examples 'placeholders edit flow' do diff --git a/spec/features/placeholder_users/index_spec.rb b/spec/features/placeholder_users/index_spec.rb index de67fe2c79d..5b399ac5a68 100644 --- a/spec/features/placeholder_users/index_spec.rb +++ b/spec/features/placeholder_users/index_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'index placeholder users', js: true, with_ee: %i[placeholder_users] do +RSpec.describe 'index placeholder users', js: true, with_ee: %i[placeholder_users] do let!(:current_user) { create(:admin) } let!(:anonymous) { create(:anonymous) } let!(:placeholder_user_1) do diff --git a/spec/features/placeholder_users/placeholder_user_memberships_spec.rb b/spec/features/placeholder_users/placeholder_user_memberships_spec.rb index 93f334d1a7e..64fd4ac31e5 100644 --- a/spec/features/placeholder_users/placeholder_user_memberships_spec.rb +++ b/spec/features/placeholder_users/placeholder_user_memberships_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../principals/shared_memberships_examples' -describe 'placeholder user memberships through placeholder user page', js: true do +RSpec.describe 'placeholder user memberships through placeholder user page', js: true do shared_let(:principal) { create(:placeholder_user, name: 'UX Designer') } shared_let(:principal_page) { Pages::Admin::IndividualPrincipals::Edit.new(principal) } diff --git a/spec/features/principals/shared_memberships_examples.rb b/spec/features/principals/shared_memberships_examples.rb index 8e8a8935a11..1246afe69eb 100644 --- a/spec/features/principals/shared_memberships_examples.rb +++ b/spec/features/principals/shared_memberships_examples.rb @@ -1,4 +1,4 @@ -shared_context 'principal membership management context' do +RSpec.shared_context 'principal membership management context' do shared_let(:project) do create(:project, name: 'Project 1', @@ -10,7 +10,7 @@ shared_context 'principal membership management context' do shared_let(:developer) { create(:role, name: 'Developer') } end -shared_examples 'principal membership management flows' do +RSpec.shared_examples 'principal membership management flows' do it 'handles role modification flow' do principal_page.visit! principal_page.open_projects_tab! @@ -44,7 +44,7 @@ shared_examples 'principal membership management flows' do end end -shared_examples 'global user principal membership management flows' do |permission| +RSpec.shared_examples 'global user principal membership management flows' do |permission| context 'as global user' do shared_let(:global_user) { create(:user, global_permission: permission) } shared_let(:project_members) { { global_user => manager } } diff --git a/spec/features/projects/attribute_help_texts_spec.rb b/spec/features/projects/attribute_help_texts_spec.rb index db0083bab21..7b5bdad5756 100644 --- a/spec/features/projects/attribute_help_texts_spec.rb +++ b/spec/features/projects/attribute_help_texts_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Project attribute help texts', js: true do +RSpec.describe 'Project attribute help texts', js: true do let(:project) { create(:project) } let(:instance) do diff --git a/spec/features/projects/copy_spec.rb b/spec/features/projects/copy_spec.rb index 2c94964ea35..01e445accea 100644 --- a/spec/features/projects/copy_spec.rb +++ b/spec/features/projects/copy_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' # rubocop:disable RSpec:MultipleMemoizedHelpers -describe 'Projects copy', - js: true do +RSpec.describe 'Projects copy', + js: true do describe 'with a full copy example' do let!(:project) do create(:project, diff --git a/spec/features/projects/create_spec.rb b/spec/features/projects/create_spec.rb index fe9a506a59d..05b49d44e4c 100644 --- a/spec/features/projects/create_spec.rb +++ b/spec/features/projects/create_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Projects', 'creation', js: true do +RSpec.describe 'Projects', 'creation', js: true do let(:name_field) { FormFields::InputFormField.new :name } current_user { create(:admin) } diff --git a/spec/features/projects/destroy_spec.rb b/spec/features/projects/destroy_spec.rb index a3e6b5b8dfb..a2283b8c060 100644 --- a/spec/features/projects/destroy_spec.rb +++ b/spec/features/projects/destroy_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Projects#destroy', - js: true do +RSpec.describe 'Projects#destroy', + js: true do let!(:project) { create(:project, name: 'foo', identifier: 'foo') } let(:project_page) { Pages::Projects::Destroy.new(project) } let(:danger_zone) { DangerZone.new(page) } diff --git a/spec/features/projects/edit_settings_spec.rb b/spec/features/projects/edit_settings_spec.rb index 6ea9af29837..621cc78fa10 100644 --- a/spec/features/projects/edit_settings_spec.rb +++ b/spec/features/projects/edit_settings_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Projects', 'editing settings', js: true do +RSpec.describe 'Projects', 'editing settings', js: true do let(:name_field) { FormFields::InputFormField.new :name } let(:parent_field) { FormFields::SelectFormField.new :parent } let(:permissions) { %i(edit_project) } diff --git a/spec/features/projects/export_spec.rb b/spec/features/projects/export_spec.rb index 548ae88c180..0df8964e857 100644 --- a/spec/features/projects/export_spec.rb +++ b/spec/features/projects/export_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/work_packages/work_packages_page' -describe 'project export', js: true do +RSpec.describe 'project export', js: true do shared_let(:important_project) { create(:project, name: 'Important schedule plan') } shared_let(:party_project) { create(:project, name: 'Christmas party') } shared_let(:user) do diff --git a/spec/features/projects/modules_spec.rb b/spec/features/projects/modules_spec.rb index d85f5008dd5..d46a8137f60 100644 --- a/spec/features/projects/modules_spec.rb +++ b/spec/features/projects/modules_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Projects module administration' do +RSpec.describe 'Projects module administration' do let!(:project) do create(:project, enabled_module_names: []) diff --git a/spec/features/projects/project_autocomplete_spec.rb b/spec/features/projects/project_autocomplete_spec.rb index 39f0f52264e..d6dce5ed134 100644 --- a/spec/features/projects/project_autocomplete_spec.rb +++ b/spec/features/projects/project_autocomplete_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Projects autocomplete page', js: true do +RSpec.describe 'Projects autocomplete page', js: true do let!(:user) { create(:user) } let(:top_menu) { Components::Projects::TopMenu.new } diff --git a/spec/features/projects/project_status_administration_spec.rb b/spec/features/projects/project_status_administration_spec.rb index 57e70d5c8ce..c24262c9467 100644 --- a/spec/features/projects/project_status_administration_spec.rb +++ b/spec/features/projects/project_status_administration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Projects status administration', js: true do +RSpec.describe 'Projects status administration', js: true do include_context 'ng-select-autocomplete helpers' let(:current_user) do diff --git a/spec/features/projects/projects_custom_fields_spec.rb b/spec/features/projects/projects_custom_fields_spec.rb index e33db0bb3ee..b4790c0fe23 100644 --- a/spec/features/projects/projects_custom_fields_spec.rb +++ b/spec/features/projects/projects_custom_fields_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Projects custom fields', js: true do +RSpec.describe 'Projects custom fields', js: true do shared_let(:current_user) { create(:admin) } shared_let(:project) { create(:project, name: 'Foo project', identifier: 'foo-project') } let(:name_field) { FormFields::InputFormField.new :name } diff --git a/spec/features/projects/projects_index_spec.rb b/spec/features/projects/projects_index_spec.rb index 25bdc23b811..4bdc2e78e60 100644 --- a/spec/features/projects/projects_index_spec.rb +++ b/spec/features/projects/projects_index_spec.rb @@ -28,9 +28,9 @@ require 'spec_helper' -describe 'Projects index page', - js: true, - with_settings: { login_required?: false } do +RSpec.describe 'Projects index page', + js: true, + with_settings: { login_required?: false } do shared_let(:admin) { create(:admin) } shared_let(:manager) { create(:role, name: 'Manager') } diff --git a/spec/features/projects/projects_portfolio_spec.rb b/spec/features/projects/projects_portfolio_spec.rb index 644cb1de1ef..43baf87f21e 100644 --- a/spec/features/projects/projects_portfolio_spec.rb +++ b/spec/features/projects/projects_portfolio_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Projects index page', - js: true, with_ee: %i[custom_fields_in_projects_list], with_settings: { login_required?: false } do +RSpec.describe 'Projects index page', + js: true, with_ee: %i[custom_fields_in_projects_list], with_settings: { login_required?: false } do shared_let(:admin) { create(:admin) } let(:modal) { Components::WorkPackages::TableConfigurationModal.new } diff --git a/spec/features/projects/subproject_creation_spec.rb b/spec/features/projects/subproject_creation_spec.rb index 7f3e9502e18..a9130e8a934 100644 --- a/spec/features/projects/subproject_creation_spec.rb +++ b/spec/features/projects/subproject_creation_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Subproject creation', js: true do +RSpec.describe 'Subproject creation', js: true do let(:name_field) { FormFields::InputFormField.new :name } let(:parent_field) { FormFields::SelectFormField.new :parent } let(:add_subproject_role) { create(:role, permissions: %i[edit_project add_subprojects]) } diff --git a/spec/features/projects/template_spec.rb b/spec/features/projects/template_spec.rb index 39b084a91ec..fccfbee9dc6 100644 --- a/spec/features/projects/template_spec.rb +++ b/spec/features/projects/template_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Project templates', js: true do +RSpec.describe 'Project templates', js: true do describe 'making project a template' do let(:project) { create(:project) } diff --git a/spec/features/projects/work_package_type_mgmt_spec.rb b/spec/features/projects/work_package_type_mgmt_spec.rb index f4af895002c..8e002100216 100644 --- a/spec/features/projects/work_package_type_mgmt_spec.rb +++ b/spec/features/projects/work_package_type_mgmt_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Projects', 'work package type mgmt', js: true do +RSpec.describe 'Projects', 'work package type mgmt', js: true do current_user { create(:user, member_in_project: project, member_with_permissions: %i[edit_project manage_types]) } let(:phase_type) { create(:type, name: 'Phase', is_default: true) } diff --git a/spec/features/repositories/checkout_instructions_spec.rb b/spec/features/repositories/checkout_instructions_spec.rb index 3d6e60b478e..e364fbc3bee 100644 --- a/spec/features/repositories/checkout_instructions_spec.rb +++ b/spec/features/repositories/checkout_instructions_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Create repository', js: true do +RSpec.describe 'Create repository', js: true do let(:current_user) { create (:admin) } let(:project) { create(:project) } let(:enabled_scms) { %w[git] } diff --git a/spec/features/repositories/create_repository_spec.rb b/spec/features/repositories/create_repository_spec.rb index 724036ceb90..eb007115c76 100644 --- a/spec/features/repositories/create_repository_spec.rb +++ b/spec/features/repositories/create_repository_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/repositories/repository_settings_page' -describe 'Create repository', js: true, selenium: true do +RSpec.describe 'Create repository', js: true, selenium: true do let(:current_user) { create(:admin) } let(:project) { create(:project) } let(:settings_page) { RepositorySettingsPage.new(project) } diff --git a/spec/features/repositories/repository_settings_spec.rb b/spec/features/repositories/repository_settings_spec.rb index c2823705342..df5b1020a74 100644 --- a/spec/features/repositories/repository_settings_spec.rb +++ b/spec/features/repositories/repository_settings_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'features/repositories/repository_settings_page' require 'features/support/components/danger_zone' -describe 'Repository Settings', js: true do +RSpec.describe 'Repository Settings', js: true do let(:current_user) { create (:admin) } let(:project) { create(:project) } let(:settings_page) { RepositorySettingsPage.new(project) } diff --git a/spec/features/roles/create_spec.rb b/spec/features/roles/create_spec.rb index 8d5c9198457..d91e4c8f03d 100644 --- a/spec/features/roles/create_spec.rb +++ b/spec/features/roles/create_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Role creation', js: true do +RSpec.describe 'Role creation', js: true do let!(:admin) { create(:admin) } let!(:existing_role) { create(:role) } let!(:existing_workflow) { create(:workflow_with_default_status, role: existing_role, type:) } diff --git a/spec/features/search_spec.rb b/spec/features/search_spec.rb index fc4e1d7404a..3046ad7ca2a 100644 --- a/spec/features/search_spec.rb +++ b/spec/features/search_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Search', js: true, with_mail: false, with_settings: { per_page_options: '5' } do +RSpec.describe 'Search', js: true, with_mail: false, with_settings: { per_page_options: '5' } do include Components::Autocompleter::NgSelectAutocompleteHelpers shared_let(:admin) { create(:admin) } diff --git a/spec/features/security/expire_sessions_spec.rb b/spec/features/security/expire_sessions_spec.rb index bfd55d9437f..9934eaf7344 100644 --- a/spec/features/security/expire_sessions_spec.rb +++ b/spec/features/security/expire_sessions_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Expire old user sessions' do +RSpec.describe 'Expire old user sessions' do shared_let(:admin) { create(:admin) } let(:admin_password) { 'adminADMIN!' } diff --git a/spec/features/security/session_ttl_spec.rb b/spec/features/security/session_ttl_spec.rb index 73cd5738b4c..ef4ff59bb9c 100644 --- a/spec/features/security/session_ttl_spec.rb +++ b/spec/features/security/session_ttl_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Session TTL', - with_settings: { session_ttl_enabled?: true, session_ttl: '10' } do +RSpec.describe 'Session TTL', + with_settings: { session_ttl_enabled?: true, session_ttl: '10' } do shared_let(:admin) { create(:admin) } let(:admin_password) { 'adminADMIN!' } diff --git a/spec/features/statuses/read_only_statuses_spec.rb b/spec/features/statuses/read_only_statuses_spec.rb index 5e48ec0a926..b248739ca2c 100644 --- a/spec/features/statuses/read_only_statuses_spec.rb +++ b/spec/features/statuses/read_only_statuses_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Read-only statuses affect work package editing', - js: true, with_ee: %i[readonly_work_packages] do +RSpec.describe 'Read-only statuses affect work package editing', + js: true, with_ee: %i[readonly_work_packages] do let(:locked_status) { create(:status, name: 'Locked', is_readonly: true) } let(:unlocked_status) { create(:status, name: 'Unlocked', is_readonly: false) } let(:cf_all) do diff --git a/spec/features/statuses/statuses_administration_spec.rb b/spec/features/statuses/statuses_administration_spec.rb index 0ec232de5fa..0ff7deb4db4 100644 --- a/spec/features/statuses/statuses_administration_spec.rb +++ b/spec/features/statuses/statuses_administration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Statuses administration' do +RSpec.describe 'Statuses administration' do let(:admin) { create(:admin) } before do diff --git a/spec/features/support/components/ng_select_autocomplete.rb b/spec/features/support/components/ng_select_autocomplete.rb index 55285433a1c..bb88785f4a3 100644 --- a/spec/features/support/components/ng_select_autocomplete.rb +++ b/spec/features/support/components/ng_select_autocomplete.rb @@ -26,6 +26,6 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_context 'ng-select-autocomplete helpers' do +RSpec.shared_context 'ng-select-autocomplete helpers' do include Components::Autocompleter::NgSelectAutocompleteHelpers end diff --git a/spec/features/support/work_package_table.rb b/spec/features/support/work_package_table.rb index 03e828f18c8..a11c9079091 100644 --- a/spec/features/support/work_package_table.rb +++ b/spec/features/support/work_package_table.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_context 'work package table helpers' do +RSpec.shared_context 'work package table helpers' do def expect_work_packages_to_be_in_order(order) within_wp_table do preceeding_elements = order[0..-2] diff --git a/spec/features/types/activate_in_project_spec.rb b/spec/features/types/activate_in_project_spec.rb index a9125c4f299..812d38ff81f 100644 --- a/spec/features/types/activate_in_project_spec.rb +++ b/spec/features/types/activate_in_project_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'support/pages/custom_fields' -describe 'types', js: true do +RSpec.describe 'types', js: true do let(:user) do create(:user, member_in_project: project, diff --git a/spec/features/types/crud_spec.rb b/spec/features/types/crud_spec.rb index c9ef41dce73..023fe962da3 100644 --- a/spec/features/types/crud_spec.rb +++ b/spec/features/types/crud_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Types', js: true do +RSpec.describe 'Types', js: true do shared_let(:admin) { create(:admin) } let!(:existing_role) { create(:role) } diff --git a/spec/features/types/form_configuration_query_spec.rb b/spec/features/types/form_configuration_query_spec.rb index 0f03f0505c6..71cbd105736 100644 --- a/spec/features/types/form_configuration_query_spec.rb +++ b/spec/features/types/form_configuration_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'form query configuration', js: true do +RSpec.describe 'form query configuration', js: true do shared_let(:admin) { create(:admin) } let(:type_bug) { create(:type_bug) } let(:type_task) { create(:type_task) } diff --git a/spec/features/types/form_configuration_spec.rb b/spec/features/types/form_configuration_spec.rb index 02c059f2834..7194eff598d 100644 --- a/spec/features/types/form_configuration_spec.rb +++ b/spec/features/types/form_configuration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'form configuration', js: true do +RSpec.describe 'form configuration', js: true do shared_let(:admin) { create(:admin) } let(:type) { create(:type) } diff --git a/spec/features/types/reset_form_configuration_spec.rb b/spec/features/types/reset_form_configuration_spec.rb index 4413537a80e..af54d1178b1 100644 --- a/spec/features/types/reset_form_configuration_spec.rb +++ b/spec/features/types/reset_form_configuration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Reset form configuration', js: true do +RSpec.describe 'Reset form configuration', js: true do shared_let(:admin) { create(:admin) } let(:type) { create(:type) } diff --git a/spec/features/users/brute_force_spec.rb b/spec/features/users/brute_force_spec.rb index 4c5f8e8da85..e0371c8d15f 100644 --- a/spec/features/users/brute_force_spec.rb +++ b/spec/features/users/brute_force_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Loggin (with brute force protection)' do +RSpec.describe 'Loggin (with brute force protection)' do let(:login) { 'my_user' } let(:password) { "PassW0rd!!!" } let(:invalid_password) { password[0..-2] } diff --git a/spec/features/users/create_spec.rb b/spec/features/users/create_spec.rb index ebf99654f7d..a9718240edd 100644 --- a/spec/features/users/create_spec.rb +++ b/spec/features/users/create_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'create users', selenium: true do +RSpec.describe 'create users', selenium: true do shared_let(:admin) { create(:admin) } let(:current_user) { admin } let!(:auth_source) { create(:dummy_auth_source) } diff --git a/spec/features/users/delete_spec.rb b/spec/features/users/delete_spec.rb index 69b1d016492..d44dde1f692 100644 --- a/spec/features/users/delete_spec.rb +++ b/spec/features/users/delete_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'user deletion:', js: true do +RSpec.describe 'user deletion:', js: true do let(:dialog) { Components::PasswordConfirmationDialog.new } before do diff --git a/spec/features/users/edit_users_spec.rb b/spec/features/users/edit_users_spec.rb index f10f297c172..6bb540a050a 100644 --- a/spec/features/users/edit_users_spec.rb +++ b/spec/features/users/edit_users_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'edit users', js: true do +RSpec.describe 'edit users', js: true do shared_let(:admin) { create(:admin) } let(:current_user) { admin } let(:user) { create(:user, mail: 'foo@example.com') } diff --git a/spec/features/users/index_spec.rb b/spec/features/users/index_spec.rb index 327900c7938..5c8c9d84985 100644 --- a/spec/features/users/index_spec.rb +++ b/spec/features/users/index_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'index users', js: true do +RSpec.describe 'index users', js: true do shared_let(:current_user) { create(:admin, firstname: 'admin', lastname: 'admin', created_at: 1.hour.ago) } let(:index_page) { Pages::Admin::Users::Index.new } diff --git a/spec/features/users/invitation_spec.rb b/spec/features/users/invitation_spec.rb index 2190f4259a5..926d8e8a41b 100644 --- a/spec/features/users/invitation_spec.rb +++ b/spec/features/users/invitation_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'invitation spec', js: true do +RSpec.describe 'invitation spec', js: true do let(:user) { create(:invited_user, mail: 'holly@openproject.com') } before do diff --git a/spec/features/users/invite_user_modal/custom_fields_spec.rb b/spec/features/users/invite_user_modal/custom_fields_spec.rb index 4a8768602a3..17da8ec9d9d 100644 --- a/spec/features/users/invite_user_modal/custom_fields_spec.rb +++ b/spec/features/users/invite_user_modal/custom_fields_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Invite user modal custom fields', js: true do +RSpec.describe 'Invite user modal custom fields', js: true do shared_let(:project) { create(:project) } let(:permissions) { %i[view_project manage_members] } diff --git a/spec/features/users/invite_user_modal/invite_user_modal_spec.rb b/spec/features/users/invite_user_modal/invite_user_modal_spec.rb index 0072199cf19..976ad5855d8 100644 --- a/spec/features/users/invite_user_modal/invite_user_modal_spec.rb +++ b/spec/features/users/invite_user_modal/invite_user_modal_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Invite user modal', js: true do +RSpec.describe 'Invite user modal', js: true do shared_let(:project) { create(:project) } shared_let(:work_package) { create(:work_package, project:) } diff --git a/spec/features/users/invite_user_modal/permission_lacking_current_project_spec.rb b/spec/features/users/invite_user_modal/permission_lacking_current_project_spec.rb index 0ac9aedc124..663c3a87d0d 100644 --- a/spec/features/users/invite_user_modal/permission_lacking_current_project_spec.rb +++ b/spec/features/users/invite_user_modal/permission_lacking_current_project_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Inviting user in project the current user is lacking permission in', js: true do +RSpec.describe 'Inviting user in project the current user is lacking permission in', js: true do let(:modal) do Components::Users::InviteUserModal.new project: invite_project, principal: other_user, diff --git a/spec/features/users/invite_user_modal/subproject_invite_spec.rb b/spec/features/users/invite_user_modal/subproject_invite_spec.rb index 32239b4a1e6..cf934a197eb 100644 --- a/spec/features/users/invite_user_modal/subproject_invite_spec.rb +++ b/spec/features/users/invite_user_modal/subproject_invite_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Invite user modal subprojects', js: true do +RSpec.describe 'Invite user modal subprojects', js: true do shared_let(:project) { create(:project, name: 'Parent project') } shared_let(:subproject) { create(:project, name: 'Subproject', parent: project) } shared_let(:work_package) { create(:work_package, project: subproject) } diff --git a/spec/features/users/my_spec.rb b/spec/features/users/my_spec.rb index 5104090557d..8837ac1165a 100644 --- a/spec/features/users/my_spec.rb +++ b/spec/features/users/my_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'my', js: true do +RSpec.describe 'my', js: true do let(:user_password) { 'bob' * 4 } let(:user) do create(:user, diff --git a/spec/features/users/notifications/shared_examples.rb b/spec/features/users/notifications/shared_examples.rb index 276d6c2a26b..89dfe378a1d 100644 --- a/spec/features/users/notifications/shared_examples.rb +++ b/spec/features/users/notifications/shared_examples.rb @@ -1,4 +1,4 @@ -shared_examples 'notification settings workflow' do +RSpec.shared_examples 'notification settings workflow' do describe 'with another project the user can see', with_ee: %i[date_alerts] do let!(:project) { create(:project) } let!(:project_alt) { create(:project) } diff --git a/spec/features/users/notifications/user_notifications_settings_spec.rb b/spec/features/users/notifications/user_notifications_settings_spec.rb index 40e9fe4bd67..c4db5f68c50 100644 --- a/spec/features/users/notifications/user_notifications_settings_spec.rb +++ b/spec/features/users/notifications/user_notifications_settings_spec.rb @@ -1,7 +1,7 @@ require 'rails_helper' require_relative './shared_examples' -describe "user notifications settings", js: true do +RSpec.describe "user notifications settings", js: true do shared_let(:user) { create(:user) } let(:settings_page) { Pages::Notifications::Settings.new(user) } diff --git a/spec/features/users/password_change_spec.rb b/spec/features/users/password_change_spec.rb index 89628b3825c..b9c645c0252 100644 --- a/spec/features/users/password_change_spec.rb +++ b/spec/features/users/password_change_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'random password generation', js: true do +RSpec.describe 'random password generation', js: true do shared_let(:admin) { create(:admin) } let(:auth_source) { build(:dummy_auth_source) } diff --git a/spec/features/users/self_registration_spec.rb b/spec/features/users/self_registration_spec.rb index f5542d835a6..7a7fd759467 100644 --- a/spec/features/users/self_registration_spec.rb +++ b/spec/features/users/self_registration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'user self registration', js: true do +RSpec.describe 'user self registration', js: true do let(:admin_password) { 'Test123Test123' } let(:admin) { create(:admin, password: admin_password, password_confirmation: admin_password) } let(:home_page) { Pages::Home.new } diff --git a/spec/features/users/show_spec.rb b/spec/features/users/show_spec.rb index 3b01da2e447..cf0e819798a 100644 --- a/spec/features/users/show_spec.rb +++ b/spec/features/users/show_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'index users', js: true do +RSpec.describe 'index users', js: true do current_user { create(:admin) } let(:index_page) { Pages::Admin::Users::Index.new } diff --git a/spec/features/users/user_memberships_spec.rb b/spec/features/users/user_memberships_spec.rb index a6256fcdb30..88dcff24734 100644 --- a/spec/features/users/user_memberships_spec.rb +++ b/spec/features/users/user_memberships_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../principals/shared_memberships_examples' -describe 'user memberships through user page', js: true do +RSpec.describe 'user memberships through user page', js: true do include_context 'principal membership management context' shared_let(:principal) { create(:user, firstname: 'Foobar', lastname: 'Blabla') } diff --git a/spec/features/versions/create_spec.rb b/spec/features/versions/create_spec.rb index ddc5578b8cd..a6bdd5900bd 100644 --- a/spec/features/versions/create_spec.rb +++ b/spec/features/versions/create_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'version create', js: false do +RSpec.describe 'version create', js: false do let(:user) do create(:user, member_in_project: project, diff --git a/spec/features/versions/edit_spec.rb b/spec/features/versions/edit_spec.rb index 7a06c1c0ecb..f53767befe7 100644 --- a/spec/features/versions/edit_spec.rb +++ b/spec/features/versions/edit_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'version edit' do +RSpec.describe 'version edit' do let(:user) do create(:user, member_in_project: version.project, diff --git a/spec/features/versions/graph_spec.rb b/spec/features/versions/graph_spec.rb index 5b96e9effdb..b88d1f09dd1 100644 --- a/spec/features/versions/graph_spec.rb +++ b/spec/features/versions/graph_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'version show graph', js: true do +RSpec.describe 'version show graph', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } let(:version) { create(:version, project:) } diff --git a/spec/features/versions/project_settings_index_spec.rb b/spec/features/versions/project_settings_index_spec.rb index 8e3bb534550..1348d1e2654 100644 --- a/spec/features/versions/project_settings_index_spec.rb +++ b/spec/features/versions/project_settings_index_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'project settings index' do +RSpec.describe 'project settings index' do let(:user) do create(:user, member_in_project: project, diff --git a/spec/features/views/shared_examples.rb b/spec/features/views/shared_examples.rb index 607bd358366..25da85689a2 100644 --- a/spec/features/views/shared_examples.rb +++ b/spec/features/views/shared_examples.rb @@ -1,4 +1,4 @@ -shared_examples 'module specific query view management' do +RSpec.shared_examples 'module specific query view management' do describe 'within a module' do let(:query_title) { Components::WorkPackages::QueryTitle.new } let(:query_menu) { Components::WorkPackages::QueryMenu.new } diff --git a/spec/features/watching/toggle_watching_spec.rb b/spec/features/watching/toggle_watching_spec.rb index d48215fdbc2..f0f6cf63509 100644 --- a/spec/features/watching/toggle_watching_spec.rb +++ b/spec/features/watching/toggle_watching_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Toggle watching', js: true do +RSpec.describe 'Toggle watching', js: true do let(:project) { create(:project) } let(:role) { create(:role, permissions: %i[view_messages view_wiki_pages]) } let(:user) { create(:user, member_in_project: project, member_through_role: role) } diff --git a/spec/features/wiki/adding_editing_history_spec.rb b/spec/features/wiki/adding_editing_history_spec.rb index 9aee016361f..4269cc1bb39 100644 --- a/spec/features/wiki/adding_editing_history_spec.rb +++ b/spec/features/wiki/adding_editing_history_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'wiki pages', js: true, with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe 'wiki pages', js: true, with_settings: { journal_aggregation_time_minutes: 0 } do let(:project) do create(:project, enabled_module_names: [:news]) end diff --git a/spec/features/wiki/attachment_upload_spec.rb b/spec/features/wiki/attachment_upload_spec.rb index b5d2b1c2685..c46827e238c 100644 --- a/spec/features/wiki/attachment_upload_spec.rb +++ b/spec/features/wiki/attachment_upload_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/page_objects/notification' -describe 'Upload attachment to wiki page', js: true do +RSpec.describe 'Upload attachment to wiki page', js: true do let(:user) do create(:user, member_in_project: project, diff --git a/spec/features/wiki/child_pages_spec.rb b/spec/features/wiki/child_pages_spec.rb index e85fe0ec5c7..b03eeebb950 100644 --- a/spec/features/wiki/child_pages_spec.rb +++ b/spec/features/wiki/child_pages_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'wiki child pages', js: true do +RSpec.describe 'wiki child pages', js: true do let(:project) do create(:project) end diff --git a/spec/features/wiki/edit_new_page_spec.rb b/spec/features/wiki/edit_new_page_spec.rb index 56dac7bc24c..14b6572d8a5 100644 --- a/spec/features/wiki/edit_new_page_spec.rb +++ b/spec/features/wiki/edit_new_page_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Editing a new wiki page', js: true do +RSpec.describe 'Editing a new wiki page', js: true do let(:project) { create(:project, enabled_module_names: %w[wiki]) } let(:user) { create(:admin) } diff --git a/spec/features/wiki/rename_spec.rb b/spec/features/wiki/rename_spec.rb index 55528b9b7fd..89ed631d0c9 100644 --- a/spec/features/wiki/rename_spec.rb +++ b/spec/features/wiki/rename_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Wiki page', js: true do +RSpec.describe 'Wiki page', js: true do let(:project) { create(:project, enabled_module_names: %w[wiki]) } let(:user) do create(:user, diff --git a/spec/features/wiki/restore_main_item_spec.rb b/spec/features/wiki/restore_main_item_spec.rb index 06366a1794f..12db49a35e8 100644 --- a/spec/features/wiki/restore_main_item_spec.rb +++ b/spec/features/wiki/restore_main_item_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Wiki page - restoring main wiki item' do +RSpec.describe 'Wiki page - restoring main wiki item' do let(:project) { create(:project, enabled_module_names: %w[wiki]) } let(:user) do create(:user, diff --git a/spec/features/wiki/wiki_page_navigation_spec.rb b/spec/features/wiki/wiki_page_navigation_spec.rb index 9436d0e0168..a7e9554035d 100644 --- a/spec/features/wiki/wiki_page_navigation_spec.rb +++ b/spec/features/wiki/wiki_page_navigation_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Wiki page navigation spec', js: true do +RSpec.describe 'Wiki page navigation spec', js: true do shared_let(:admin) { create(:admin) } current_user { admin } diff --git a/spec/features/wiki/wiki_unicode_spec.rb b/spec/features/wiki/wiki_unicode_spec.rb index e0c121ad7c1..781fd2d2c92 100644 --- a/spec/features/wiki/wiki_unicode_spec.rb +++ b/spec/features/wiki/wiki_unicode_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Wiki unicode title spec', js: true do +RSpec.describe 'Wiki unicode title spec', js: true do shared_let(:admin) { create(:admin) } let(:user) { admin } diff --git a/spec/features/work_packages/attachments/attachment_upload_spec.rb b/spec/features/work_packages/attachments/attachment_upload_spec.rb index c9cc525d471..2a9e9897955 100644 --- a/spec/features/work_packages/attachments/attachment_upload_spec.rb +++ b/spec/features/work_packages/attachments/attachment_upload_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/page_objects/notification' -describe 'Upload attachment to work package', js: true do +RSpec.describe 'Upload attachment to work package', js: true do let(:role) do create(:role, permissions: %i[view_work_packages add_work_packages edit_work_packages add_work_package_notes]) diff --git a/spec/features/work_packages/attribute_help_texts_spec.rb b/spec/features/work_packages/attribute_help_texts_spec.rb index 683067fec0a..5088009536c 100644 --- a/spec/features/work_packages/attribute_help_texts_spec.rb +++ b/spec/features/work_packages/attribute_help_texts_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Work package attribute help texts', js: true do +RSpec.describe 'Work package attribute help texts', js: true do let(:project) { create(:project) } let(:work_package) { create(:work_package, project:) } diff --git a/spec/features/work_packages/bulk/copy_work_package_spec.rb b/spec/features/work_packages/bulk/copy_work_package_spec.rb index 569a36f4502..967d43e2a78 100644 --- a/spec/features/work_packages/bulk/copy_work_package_spec.rb +++ b/spec/features/work_packages/bulk/copy_work_package_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' require 'features/page_objects/notification' require 'support/components/autocompleter/ng_select_autocomplete_helpers' -describe 'Copy work packages through Rails view', js: true do +RSpec.describe 'Copy work packages through Rails view', js: true do include Components::Autocompleter::NgSelectAutocompleteHelpers shared_let(:type) { create(:type, name: 'Bug') } diff --git a/spec/features/work_packages/bulk/move_work_package_spec.rb b/spec/features/work_packages/bulk/move_work_package_spec.rb index 09bdea36ee4..8d9c83b870f 100644 --- a/spec/features/work_packages/bulk/move_work_package_spec.rb +++ b/spec/features/work_packages/bulk/move_work_package_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' require 'features/page_objects/notification' require 'support/components/autocompleter/ng_select_autocomplete_helpers' -describe 'Moving a work package through Rails view', js: true do +RSpec.describe 'Moving a work package through Rails view', js: true do include Components::Autocompleter::NgSelectAutocompleteHelpers let(:dev_role) do diff --git a/spec/features/work_packages/bulk/update_work_package_spec.rb b/spec/features/work_packages/bulk/update_work_package_spec.rb index c6f95e6eff0..41bfac37465 100644 --- a/spec/features/work_packages/bulk/update_work_package_spec.rb +++ b/spec/features/work_packages/bulk/update_work_package_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require 'features/page_objects/notification' -describe 'Bulk update work packages through Rails view', js: true do +RSpec.describe 'Bulk update work packages through Rails view', js: true do shared_let(:type) { create(:type, name: 'Bug') } shared_let(:project) { create(:project, name: 'Source', types: [type]) } shared_let(:status) { create(:status) } diff --git a/spec/features/work_packages/cancel_editing_spec.rb b/spec/features/work_packages/cancel_editing_spec.rb index a56a90bea71..82477fac672 100644 --- a/spec/features/work_packages/cancel_editing_spec.rb +++ b/spec/features/work_packages/cancel_editing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Cancel editing work package', js: true do +RSpec.describe 'Cancel editing work package', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } let(:work_package) { create(:work_package, project:) } diff --git a/spec/features/work_packages/cards/wp_card_status_spec.rb b/spec/features/work_packages/cards/wp_card_status_spec.rb index 683ac197693..1940bf21191 100644 --- a/spec/features/work_packages/cards/wp_card_status_spec.rb +++ b/spec/features/work_packages/cards/wp_card_status_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Update status from WP card', js: true do +RSpec.describe 'Update status from WP card', js: true do let(:manager_role) do create(:role, permissions: %i[view_work_packages edit_work_packages]) end diff --git a/spec/features/work_packages/custom_actions/custom_actions_me_value_spec.rb b/spec/features/work_packages/custom_actions/custom_actions_me_value_spec.rb index de57ceb5bed..46216548be3 100644 --- a/spec/features/work_packages/custom_actions/custom_actions_me_value_spec.rb +++ b/spec/features/work_packages/custom_actions/custom_actions_me_value_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Custom actions me value', js: true, with_ee: %i[custom_actions] do +RSpec.describe 'Custom actions me value', js: true, with_ee: %i[custom_actions] do shared_let(:admin) { create(:admin) } let(:permissions) { %i(view_work_packages edit_work_packages) } diff --git a/spec/features/work_packages/custom_actions/custom_actions_spec.rb b/spec/features/work_packages/custom_actions/custom_actions_spec.rb index 1c8425757a0..8fa8be658fd 100644 --- a/spec/features/work_packages/custom_actions/custom_actions_spec.rb +++ b/spec/features/work_packages/custom_actions/custom_actions_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Custom actions', js: true, with_ee: %i[custom_actions] do +RSpec.describe 'Custom actions', js: true, with_ee: %i[custom_actions] do shared_let(:admin) { create(:admin) } let(:permissions) { %i(view_work_packages edit_work_packages move_work_packages work_package_assigned) } diff --git a/spec/features/work_packages/datepicker/datepicker_follows_relation_spec.rb b/spec/features/work_packages/datepicker/datepicker_follows_relation_spec.rb index ecddf9f82f9..1f665b765ca 100644 --- a/spec/features/work_packages/datepicker/datepicker_follows_relation_spec.rb +++ b/spec/features/work_packages/datepicker/datepicker_follows_relation_spec.rb @@ -29,9 +29,9 @@ require 'spec_helper' require 'support/edit_fields/edit_field' -describe 'Datepicker logic on follow relationships', - js: true, - with_settings: { date_format: '%Y-%m-%d' } do +RSpec.describe 'Datepicker logic on follow relationships', + js: true, + with_settings: { date_format: '%Y-%m-%d' } do shared_let(:user) { create(:admin) } shared_let(:type) { create(:type_bug) } diff --git a/spec/features/work_packages/datepicker/datepicker_logic_spec.rb b/spec/features/work_packages/datepicker/datepicker_logic_spec.rb index 0fa01dc8ebb..1ccf4803287 100644 --- a/spec/features/work_packages/datepicker/datepicker_logic_spec.rb +++ b/spec/features/work_packages/datepicker/datepicker_logic_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require 'support/edit_fields/edit_field' -describe 'Datepicker modal logic test cases (WP #43539)', - js: true, with_settings: { date_format: '%Y-%m-%d' } do +RSpec.describe 'Datepicker modal logic test cases (WP #43539)', + js: true, with_settings: { date_format: '%Y-%m-%d' } do shared_let(:user) { create(:admin) } shared_let(:type_bug) { create(:type_bug) } diff --git a/spec/features/work_packages/datepicker/datepicker_non_working_day_spec.rb b/spec/features/work_packages/datepicker/datepicker_non_working_day_spec.rb index 05ac219cf6b..ed133bb048a 100644 --- a/spec/features/work_packages/datepicker/datepicker_non_working_day_spec.rb +++ b/spec/features/work_packages/datepicker/datepicker_non_working_day_spec.rb @@ -29,9 +29,9 @@ require 'spec_helper' require 'support/edit_fields/edit_field' -describe 'Datepicker modal individual non working days (WP #44453)', - js: true, - with_settings: { date_format: '%Y-%m-%d' } do +RSpec.describe 'Datepicker modal individual non working days (WP #44453)', + js: true, + with_settings: { date_format: '%Y-%m-%d' } do shared_let(:user) { create(:admin) } shared_let(:project) { create(:project) } diff --git a/spec/features/work_packages/datepicker/datepicker_parent_spec.rb b/spec/features/work_packages/datepicker/datepicker_parent_spec.rb index 1061aec8b16..0c3b12ef90b 100644 --- a/spec/features/work_packages/datepicker/datepicker_parent_spec.rb +++ b/spec/features/work_packages/datepicker/datepicker_parent_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require 'support/edit_fields/edit_field' -describe 'Datepicker logic on parents', - js: true, with_settings: { date_format: '%Y-%m-%d' } do +RSpec.describe 'Datepicker logic on parents', + js: true, with_settings: { date_format: '%Y-%m-%d' } do shared_let(:user) { create(:admin) } # assume sat+sun are non working days diff --git a/spec/features/work_packages/details/closed_status_and_version_spec.rb b/spec/features/work_packages/details/closed_status_and_version_spec.rb index 255b0b07583..942bc9c1e57 100644 --- a/spec/features/work_packages/details/closed_status_and_version_spec.rb +++ b/spec/features/work_packages/details/closed_status_and_version_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Closed status and version in full view', js: true do +RSpec.describe 'Closed status and version in full view', js: true do let(:type) { create(:type) } let(:status) { create(:closed_status) } diff --git a/spec/features/work_packages/details/context_menu_spec.rb b/spec/features/work_packages/details/context_menu_spec.rb index 470f8a42019..51be0ff6711 100644 --- a/spec/features/work_packages/details/context_menu_spec.rb +++ b/spec/features/work_packages/details/context_menu_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Work package single context menu', js: true do +RSpec.describe 'Work package single context menu', js: true do let(:user) { create(:admin) } let(:work_package) { create(:work_package) } diff --git a/spec/features/work_packages/details/custom_fields/custom_field_spec.rb b/spec/features/work_packages/details/custom_fields/custom_field_spec.rb index 79b765cb63c..6bb73cdc63c 100644 --- a/spec/features/work_packages/details/custom_fields/custom_field_spec.rb +++ b/spec/features/work_packages/details/custom_fields/custom_field_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' require 'features/work_packages/work_packages_page' require 'features/work_packages/details/inplace_editor/shared_examples' -describe 'custom field inplace editor', js: true do +RSpec.describe 'custom field inplace editor', js: true do let(:user) { create(:admin) } let(:type) { create(:type_standard, custom_fields:) } let(:project) do diff --git a/spec/features/work_packages/details/date_editor_spec.rb b/spec/features/work_packages/details/date_editor_spec.rb index e5d03b10235..73f4ab616b0 100644 --- a/spec/features/work_packages/details/date_editor_spec.rb +++ b/spec/features/work_packages/details/date_editor_spec.rb @@ -33,8 +33,8 @@ require 'features/work_packages/shared_contexts' require 'support/edit_fields/edit_field' require 'features/work_packages/work_packages_page' -describe 'date inplace editor', - js: true, selenium: true, with_settings: { date_format: '%Y-%m-%d' } do +RSpec.describe 'date inplace editor', + js: true, selenium: true, with_settings: { date_format: '%Y-%m-%d' } do shared_let(:project) { create(:project_with_types, public: true) } shared_let(:user) { create(:admin) } shared_let(:type) { project.types.first } diff --git a/spec/features/work_packages/details/details_refreshing_spec.rb b/spec/features/work_packages/details/details_refreshing_spec.rb index fa1dd6bbc39..d45ef2be63a 100644 --- a/spec/features/work_packages/details/details_refreshing_spec.rb +++ b/spec/features/work_packages/details/details_refreshing_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/work_packages/work_packages_page' -describe 'Work package table refreshing due to split view', js: true do +RSpec.describe 'Work package table refreshing due to split view', js: true do let(:project) { create(:project_with_types) } let!(:work_package) { create(:work_package, project:) } let(:wp_split) { Pages::SplitWorkPackage.new work_package } diff --git a/spec/features/work_packages/details/details_toolbar_spec.rb b/spec/features/work_packages/details/details_toolbar_spec.rb index 175c88a2dad..5671f94a55b 100644 --- a/spec/features/work_packages/details/details_toolbar_spec.rb +++ b/spec/features/work_packages/details/details_toolbar_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/work_packages/work_packages_page' -describe 'Work package details toolbar', js: true, selenium: true do +RSpec.describe 'Work package details toolbar', js: true, selenium: true do let(:project) { create(:project_with_types, public: true) } let!(:work_package) { create(:work_package, project:) } let(:work_packages_page) { WorkPackagesPage.new(project) } diff --git a/spec/features/work_packages/details/inplace_editor/shared_examples.rb b/spec/features/work_packages/details/inplace_editor/shared_examples.rb index 6625772a32a..22eb5c146d5 100644 --- a/spec/features/work_packages/details/inplace_editor/shared_examples.rb +++ b/spec/features/work_packages/details/inplace_editor/shared_examples.rb @@ -1,4 +1,4 @@ -shared_examples 'as an accessible inplace editor' do +RSpec.shared_examples 'as an accessible inplace editor' do it 'triggers edit mode on click' do scroll_to_element(field.display_element) field.activate_edition @@ -23,7 +23,7 @@ shared_examples 'as an accessible inplace editor' do end end -shared_examples 'as an auth aware field' do +RSpec.shared_examples 'as an auth aware field' do context 'when is editable' do it_behaves_like 'as an accessible inplace editor' end @@ -52,7 +52,7 @@ shared_examples 'as an auth aware field' do end end -shared_context 'as a single validation point' do +RSpec.shared_context 'as a single validation point' do let(:other_field) { EditField.new page, :type } before do other_field.activate_edition @@ -67,7 +67,7 @@ shared_context 'as a single validation point' do end end -shared_context 'as a required field' do +RSpec.shared_context 'as a required field' do before do field.activate_edition field.input_element.set '' @@ -79,7 +79,7 @@ shared_context 'as a required field' do end end -shared_examples 'a cancellable field' do +RSpec.shared_examples 'a cancellable field' do shared_examples 'cancelling properly' do it 'reverts to read state and keeps its focus' do expect(field).not_to be_editing @@ -101,7 +101,7 @@ shared_examples 'a cancellable field' do end end -shared_examples 'a workpackage autocomplete field' do +RSpec.shared_examples 'a workpackage autocomplete field' do let!(:wp2) { create(:work_package, project:, subject: 'AutoFoo') } it 'autocompletes the other work package' do @@ -112,7 +112,7 @@ shared_examples 'a workpackage autocomplete field' do end end -shared_examples 'a principal autocomplete field' do +RSpec.shared_examples 'a principal autocomplete field' do let(:role) { create(:role, permissions: %i[view_work_packages edit_work_packages]) } let!(:user) do create(:user, @@ -176,7 +176,7 @@ shared_examples 'a principal autocomplete field' do end end -shared_examples 'not a principal autocomplete field' do +RSpec.shared_examples 'not a principal autocomplete field' do let(:role) { create(:role, permissions: %i[view_work_packages edit_work_packages]) } let!(:user) do create(:user, diff --git a/spec/features/work_packages/details/inplace_editor/subject_editor_spec.rb b/spec/features/work_packages/details/inplace_editor/subject_editor_spec.rb index 5ac2271c2a7..02e81b9c2f7 100644 --- a/spec/features/work_packages/details/inplace_editor/subject_editor_spec.rb +++ b/spec/features/work_packages/details/inplace_editor/subject_editor_spec.rb @@ -5,7 +5,7 @@ require 'features/work_packages/shared_contexts' require 'support/edit_fields/edit_field' require 'features/work_packages/work_packages_page' -describe 'subject inplace editor', js: true, selenium: true do +RSpec.describe 'subject inplace editor', js: true, selenium: true do let(:project) { create(:project_with_types, public: true) } let(:property_name) { :subject } let(:property_title) { 'Subject' } diff --git a/spec/features/work_packages/details/inplace_editor/version_editor_spec.rb b/spec/features/work_packages/details/inplace_editor/version_editor_spec.rb index f41306a1b17..c90f5680599 100644 --- a/spec/features/work_packages/details/inplace_editor/version_editor_spec.rb +++ b/spec/features/work_packages/details/inplace_editor/version_editor_spec.rb @@ -4,7 +4,7 @@ require 'features/work_packages/shared_contexts' require 'support/edit_fields/edit_field' require 'features/work_packages/work_packages_page' -describe 'subject inplace editor', js: true, selenium: true do +RSpec.describe 'subject inplace editor', js: true, selenium: true do let(:project) { create(:project_with_types, name: 'Root', public: true) } let(:subproject1) { create(:project_with_types, name: 'Child', parent: project) } let(:subproject2) { create(:project_with_types, name: 'Aunt', parent: project) } diff --git a/spec/features/work_packages/details/markdown/activity_comments_spec.rb b/spec/features/work_packages/details/markdown/activity_comments_spec.rb index fe9b590f0c3..a79d3e4afdf 100644 --- a/spec/features/work_packages/details/markdown/activity_comments_spec.rb +++ b/spec/features/work_packages/details/markdown/activity_comments_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' require 'features/work_packages/shared_contexts' require 'features/work_packages/details/inplace_editor/shared_examples' -describe 'activity comments', js: true, with_mail: false do +RSpec.describe 'activity comments', js: true, with_mail: false do let(:project) { create(:project, public: true) } let!(:work_package) do create(:work_package, diff --git a/spec/features/work_packages/details/markdown/description_editor_spec.rb b/spec/features/work_packages/details/markdown/description_editor_spec.rb index 72da66f09ad..27c78f20d37 100644 --- a/spec/features/work_packages/details/markdown/description_editor_spec.rb +++ b/spec/features/work_packages/details/markdown/description_editor_spec.rb @@ -32,7 +32,7 @@ require 'features/work_packages/shared_contexts' require 'support/edit_fields/edit_field' require 'features/work_packages/work_packages_page' -describe 'description inplace editor', js: true, selenium: true do +RSpec.describe 'description inplace editor', js: true, selenium: true do let(:project) { create(:project_with_types, public: true) } let(:property_name) { :description } let(:property_title) { 'Description' } diff --git a/spec/features/work_packages/details/markdown/todolist_spec.rb b/spec/features/work_packages/details/markdown/todolist_spec.rb index 315d753a4fc..0fa57451394 100644 --- a/spec/features/work_packages/details/markdown/todolist_spec.rb +++ b/spec/features/work_packages/details/markdown/todolist_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Todolists in CKEditor', js: true do +RSpec.describe 'Todolists in CKEditor', js: true do let(:user) { create(:admin) } before do diff --git a/spec/features/work_packages/details/milestones_spec.rb b/spec/features/work_packages/details/milestones_spec.rb index 193d2296af4..9d4ffdb1fde 100644 --- a/spec/features/work_packages/details/milestones_spec.rb +++ b/spec/features/work_packages/details/milestones_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Milestones full screen v iew', js: true do +RSpec.describe 'Milestones full screen v iew', js: true do let(:type) { create(:type, is_milestone: true) } let(:project) { create(:project, types: [type]) } let!(:work_package) do diff --git a/spec/features/work_packages/details/query_groups/relation_query_group_spec.rb b/spec/features/work_packages/details/query_groups/relation_query_group_spec.rb index e46cb109f2c..cc31d4c9306 100644 --- a/spec/features/work_packages/details/query_groups/relation_query_group_spec.rb +++ b/spec/features/work_packages/details/query_groups/relation_query_group_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Work package with relation query group', js: true, selenium: true do +RSpec.describe 'Work package with relation query group', js: true, selenium: true do include_context 'ng-select-autocomplete helpers' let(:user) { create(:admin) } diff --git a/spec/features/work_packages/details/relations/hierarchy_custom_fields_spec.rb b/spec/features/work_packages/details/relations/hierarchy_custom_fields_spec.rb index 995d86bc2bb..7c00733fece 100644 --- a/spec/features/work_packages/details/relations/hierarchy_custom_fields_spec.rb +++ b/spec/features/work_packages/details/relations/hierarchy_custom_fields_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'creating a child directly after the wp itself was created', js: true do +RSpec.describe 'creating a child directly after the wp itself was created', js: true do let(:user) { create(:admin) } let(:project) { create(:project, types: [type]) } let(:wp_page) { Pages::FullWorkPackageCreate.new } diff --git a/spec/features/work_packages/details/relations/hierarchy_milestone_spec.rb b/spec/features/work_packages/details/relations/hierarchy_milestone_spec.rb index 0d9f22232d3..09fb24b023a 100644 --- a/spec/features/work_packages/details/relations/hierarchy_milestone_spec.rb +++ b/spec/features/work_packages/details/relations/hierarchy_milestone_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'work package hierarchies for milestones', js: true, selenium: true do +RSpec.describe 'work package hierarchies for milestones', js: true, selenium: true do let(:user) { create(:admin) } let(:type) { create(:type, is_milestone: true) } let(:project) { create(:project, types: [type]) } diff --git a/spec/features/work_packages/details/relations/hierarchy_spec.rb b/spec/features/work_packages/details/relations/hierarchy_spec.rb index a8301ef0532..f1370945356 100644 --- a/spec/features/work_packages/details/relations/hierarchy_spec.rb +++ b/spec/features/work_packages/details/relations/hierarchy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples 'work package relations tab', js: true, selenium: true do +RSpec.shared_examples 'work package relations tab', js: true, selenium: true do include_context 'ng-select-autocomplete helpers' let(:user) { create(:admin) } @@ -267,13 +267,13 @@ shared_examples 'work package relations tab', js: true, selenium: true do end end -context 'Split screen' do +RSpec.context 'Split screen' do let(:wp_page) { Pages::SplitWorkPackage.new(work_package) } it_behaves_like 'work package relations tab' end -context 'Full screen' do +RSpec.context 'Full screen' do let(:wp_page) { Pages::FullWorkPackage.new(work_package) } it_behaves_like 'work package relations tab' diff --git a/spec/features/work_packages/details/relations/relations_spec.rb b/spec/features/work_packages/details/relations/relations_spec.rb index 3ab48316224..ab63f8bfec7 100644 --- a/spec/features/work_packages/details/relations/relations_spec.rb +++ b/spec/features/work_packages/details/relations/relations_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Work package relations tab', js: true, selenium: true do +RSpec.describe 'Work package relations tab', js: true, selenium: true do include_context 'ng-select-autocomplete helpers' let(:user) { create(:admin) } diff --git a/spec/features/work_packages/details/workdays_spec.rb b/spec/features/work_packages/details/workdays_spec.rb index 5ea15cfc954..b362efce359 100644 --- a/spec/features/work_packages/details/workdays_spec.rb +++ b/spec/features/work_packages/details/workdays_spec.rb @@ -33,8 +33,8 @@ require 'features/work_packages/shared_contexts' require 'support/edit_fields/edit_field' require 'features/work_packages/work_packages_page' -describe 'Work packages datepicker workdays', - js: true, with_settings: { date_format: '%Y-%m-%d' } do +RSpec.describe 'Work packages datepicker workdays', + js: true, with_settings: { date_format: '%Y-%m-%d' } do shared_let(:project) { create(:project_with_types, public: true) } shared_let(:work_package) { create(:work_package, project:, start_date: Date.parse('2022-01-01')) } shared_let(:user) { create(:admin) } diff --git a/spec/features/work_packages/display_fields/date_field_display_spec.rb b/spec/features/work_packages/display_fields/date_field_display_spec.rb index 4ba2ea3dc7c..af604f37f52 100644 --- a/spec/features/work_packages/display_fields/date_field_display_spec.rb +++ b/spec/features/work_packages/display_fields/date_field_display_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Show the date of a Work Package', js: true do +RSpec.describe 'Show the date of a Work Package', js: true do let(:project) { create(:project) } let(:admin) { create(:admin) } let(:work_package) do diff --git a/spec/features/work_packages/display_fields/spent_time_display_spec.rb b/spec/features/work_packages/display_fields/spent_time_display_spec.rb index dc29d41f904..89fab1cce7c 100644 --- a/spec/features/work_packages/display_fields/spent_time_display_spec.rb +++ b/spec/features/work_packages/display_fields/spent_time_display_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Logging time within the work package view', js: true do +RSpec.describe 'Logging time within the work package view', js: true do shared_let(:project) { create(:project) } shared_let(:admin) { create(:admin) } shared_let(:work_package) { create(:work_package, project:) } diff --git a/spec/features/work_packages/display_representations/switch_display_representations_spec.rb b/spec/features/work_packages/display_representations/switch_display_representations_spec.rb index 1ed0165c25a..79f8d54764b 100644 --- a/spec/features/work_packages/display_representations/switch_display_representations_spec.rb +++ b/spec/features/work_packages/display_representations/switch_display_representations_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Switching work package view', - js: true, with_ee: %i[conditional_highlighting] do +RSpec.describe 'Switching work package view', + js: true, with_ee: %i[conditional_highlighting] do let(:user) { create(:admin) } let(:project) { create(:project) } let(:wp_table) { Pages::WorkPackagesTable.new(project) } diff --git a/spec/features/work_packages/edit_on_assign_version_permission_spec.rb b/spec/features/work_packages/edit_on_assign_version_permission_spec.rb index ddc7cee0dcc..3edd100b626 100644 --- a/spec/features/work_packages/edit_on_assign_version_permission_spec.rb +++ b/spec/features/work_packages/edit_on_assign_version_permission_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require 'features/page_objects/notification' -describe 'edit work package', js: true do +RSpec.describe 'edit work package', js: true do let(:current_user) do create(:user, firstname: 'Dev', diff --git a/spec/features/work_packages/edit_work_package_spec.rb b/spec/features/work_packages/edit_work_package_spec.rb index b9e1afb6839..382304281f0 100644 --- a/spec/features/work_packages/edit_work_package_spec.rb +++ b/spec/features/work_packages/edit_work_package_spec.rb @@ -1,8 +1,8 @@ require 'spec_helper' require 'features/page_objects/notification' -describe 'edit work package', - js: true do +RSpec.describe 'edit work package', + js: true do let(:dev_role) do create(:role, permissions: %i[view_work_packages diff --git a/spec/features/work_packages/export_spec.rb b/spec/features/work_packages/export_spec.rb index 4bc32af90c0..2de6cd8c110 100644 --- a/spec/features/work_packages/export_spec.rb +++ b/spec/features/work_packages/export_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/work_packages/work_packages_page' -describe 'work package export' do +RSpec.describe 'work package export' do let(:project) { create(:project_with_types, types: [type_a, type_b]) } let(:export_type) { 'CSV' } let(:current_user) { create(:admin) } diff --git a/spec/features/work_packages/highlighting_spec.rb b/spec/features/work_packages/highlighting_spec.rb index bbd6ea99fa4..cdd108ffea3 100644 --- a/spec/features/work_packages/highlighting_spec.rb +++ b/spec/features/work_packages/highlighting_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' -describe 'Work Package highlighting fields', - js: true, with_ee: %i[conditional_highlighting] do +RSpec.describe 'Work Package highlighting fields', + js: true, with_ee: %i[conditional_highlighting] do let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/spec/features/work_packages/navigation_spec.rb b/spec/features/work_packages/navigation_spec.rb index 379fdc0b53c..b08c57d21c2 100644 --- a/spec/features/work_packages/navigation_spec.rb +++ b/spec/features/work_packages/navigation_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Work package navigation', js: true, selenium: true do +RSpec.describe 'Work package navigation', js: true, selenium: true do let(:user) { create(:admin) } let(:project) { create(:project, name: 'Some project', enabled_module_names: [:work_package_tracking]) } let(:work_package) { build(:work_package, project:) } diff --git a/spec/features/work_packages/new/new_work_package_datepicker_spec.rb b/spec/features/work_packages/new/new_work_package_datepicker_spec.rb index 5ace7b56154..c873de25891 100644 --- a/spec/features/work_packages/new/new_work_package_datepicker_spec.rb +++ b/spec/features/work_packages/new/new_work_package_datepicker_spec.rb @@ -33,8 +33,8 @@ require 'features/work_packages/shared_contexts' require 'support/edit_fields/edit_field' require 'features/work_packages/work_packages_page' -describe 'New work package datepicker', - js: true, selenium: true, with_settings: { date_format: '%Y-%m-%d' } do +RSpec.describe 'New work package datepicker', + js: true, selenium: true, with_settings: { date_format: '%Y-%m-%d' } do let(:project) { create(:project_with_types, public: true) } let(:user) { create(:admin) } diff --git a/spec/features/work_packages/new/new_work_package_spec.rb b/spec/features/work_packages/new/new_work_package_spec.rb index 17d02362a0d..8ab4cf8f325 100644 --- a/spec/features/work_packages/new/new_work_package_spec.rb +++ b/spec/features/work_packages/new/new_work_package_spec.rb @@ -3,7 +3,7 @@ require 'support/edit_fields/edit_field' require 'features/work_packages/work_packages_page' require 'features/page_objects/notification' -describe 'new work package', js: true do +RSpec.describe 'new work package', js: true do let(:type_task) { create(:type_task) } let(:type_milestone) { create(:type_milestone, position: type_task.position + 1) } let(:type_bug) { create(:type_bug, position: type_milestone.position + 1) } diff --git a/spec/features/work_packages/new/work_package_default_description_spec.rb b/spec/features/work_packages/new/work_package_default_description_spec.rb index acc28bb2c8d..c05fdf08c93 100644 --- a/spec/features/work_packages/new/work_package_default_description_spec.rb +++ b/spec/features/work_packages/new/work_package_default_description_spec.rb @@ -3,7 +3,7 @@ require 'support/edit_fields/edit_field' require 'features/work_packages/work_packages_page' require 'features/page_objects/notification' -describe 'new work package', js: true, with_mail: false do +RSpec.describe 'new work package', js: true, with_mail: false do let(:type_task) { create(:type_task, description: "# New Task template\n\nHello there") } let(:type_feature) { create(:type_feature, description: "", is_default: true) } let(:type_bug) { create(:type_bug, description: "# New Bug template\n\nGeneral Kenobi") } diff --git a/spec/features/work_packages/project_context_switch_spec.rb b/spec/features/work_packages/project_context_switch_spec.rb index 904593831cb..c817bc40741 100644 --- a/spec/features/work_packages/project_context_switch_spec.rb +++ b/spec/features/work_packages/project_context_switch_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Project context switching spec', js: true do +RSpec.describe 'Project context switching spec', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/spec/features/work_packages/project_include/project_include_shared_examples.rb b/spec/features/work_packages/project_include/project_include_shared_examples.rb index 921dece5cef..f3c17519fe0 100644 --- a/spec/features/work_packages/project_include/project_include_shared_examples.rb +++ b/spec/features/work_packages/project_include/project_include_shared_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples 'has a project include dropdown', js: true, type: :feature do +RSpec.shared_examples 'has a project include dropdown', js: true, type: :feature do let(:dropdown) { Components::ProjectIncludeComponent.new } shared_let(:project) do diff --git a/spec/features/work_packages/reports_spec.rb b/spec/features/work_packages/reports_spec.rb index ce398b14f21..367e1be00b0 100644 --- a/spec/features/work_packages/reports_spec.rb +++ b/spec/features/work_packages/reports_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'work package reports', js: true do +RSpec.describe 'work package reports', js: true do let(:project) { create(:project_with_types, types: [type_a]) } let(:user) { create(:user, member_in_project: project, member_with_permissions: %i(view_work_packages)) } diff --git a/spec/features/work_packages/scheduling/scheduling_mode_spec.rb b/spec/features/work_packages/scheduling/scheduling_mode_spec.rb index e1a0d2c4bf0..61096c703e1 100644 --- a/spec/features/work_packages/scheduling/scheduling_mode_spec.rb +++ b/spec/features/work_packages/scheduling/scheduling_mode_spec.rb @@ -33,8 +33,8 @@ require 'features/work_packages/shared_contexts' require 'support/edit_fields/edit_field' require 'features/work_packages/work_packages_page' -describe 'scheduling mode', - js: true do +RSpec.describe 'scheduling mode', + js: true do let(:project) { create(:project_with_types, public: true) } # Constructing a work package graph that looks like this: # diff --git a/spec/features/work_packages/select/select_card_view_spec.rb b/spec/features/work_packages/select/select_card_view_spec.rb index 164a0cdc705..ecae6ca1f37 100644 --- a/spec/features/work_packages/select/select_card_view_spec.rb +++ b/spec/features/work_packages/select/select_card_view_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Selecting cards in the card view (regression #31962)', js: true do +RSpec.describe 'Selecting cards in the card view (regression #31962)', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } let(:wp_table) { Pages::WorkPackagesTable.new(project) } diff --git a/spec/features/work_packages/select/select_query_spec.rb b/spec/features/work_packages/select/select_query_spec.rb index 90fa0056b55..703ec473011 100644 --- a/spec/features/work_packages/select/select_query_spec.rb +++ b/spec/features/work_packages/select/select_query_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/work_packages/work_packages_page' -describe 'Query selection' do +RSpec.describe 'Query selection' do let(:project) { create(:project, identifier: 'test_project', public: false) } let(:role) { create(:role, permissions: [:view_work_packages]) } let(:current_user) do diff --git a/spec/features/work_packages/select/select_work_package_row_spec.rb b/spec/features/work_packages/select/select_work_package_row_spec.rb index 9cb27b527ee..43de269a52a 100644 --- a/spec/features/work_packages/select/select_work_package_row_spec.rb +++ b/spec/features/work_packages/select/select_work_package_row_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Select work package row', js: true, selenium: true do +RSpec.describe 'Select work package row', js: true, selenium: true do let(:user) { create(:admin) } let(:project) { create(:project) } let(:work_package_1) { create(:work_package, project:) } diff --git a/spec/features/work_packages/select/select_wp_card_spec.rb b/spec/features/work_packages/select/select_wp_card_spec.rb index 3dab2cfd0ec..f8ccf5ba2fc 100644 --- a/spec/features/work_packages/select/select_wp_card_spec.rb +++ b/spec/features/work_packages/select/select_wp_card_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Select work package card', js: true, selenium: true do +RSpec.describe 'Select work package card', js: true, selenium: true do let(:user) { create(:admin) } let(:project) { create(:project) } let(:work_package_1) { create(:work_package, project:) } diff --git a/spec/features/work_packages/shared_contexts.rb b/spec/features/work_packages/shared_contexts.rb index 02c0b51b1ad..a58a782dda9 100644 --- a/spec/features/work_packages/shared_contexts.rb +++ b/spec/features/work_packages/shared_contexts.rb @@ -28,7 +28,7 @@ # Ensure the page is completely loaded before the spec is run. # The status filter is loaded very late in the page setup. -shared_context 'ensure wp details pane update done' do +RSpec.shared_context 'ensure wp details pane update done' do after do unless update_user raise "Expect to have a let called 'update_user' defining which user \ diff --git a/spec/features/work_packages/sorting/manual_sorting_spec.rb b/spec/features/work_packages/sorting/manual_sorting_spec.rb index 49212bf410f..8403f765abd 100644 --- a/spec/features/work_packages/sorting/manual_sorting_spec.rb +++ b/spec/features/work_packages/sorting/manual_sorting_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/work_packages/work_packages_page' -describe 'Manual sorting of WP table', js: true do +RSpec.describe 'Manual sorting of WP table', js: true do let(:user) { create(:admin) } let(:wp_table) { Pages::WorkPackagesTable.new(project) } diff --git a/spec/features/work_packages/sorting/table_sorting_spec.rb b/spec/features/work_packages/sorting/table_sorting_spec.rb index d9c44658dec..23cbcd082a0 100644 --- a/spec/features/work_packages/sorting/table_sorting_spec.rb +++ b/spec/features/work_packages/sorting/table_sorting_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/work_packages/work_packages_page' -describe 'Select work package row', js: true do +RSpec.describe 'Select work package row', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } let(:work_packages_page) { WorkPackagesPage.new(project) } diff --git a/spec/features/work_packages/table/baseline/baseline_query_spec.rb b/spec/features/work_packages/table/baseline/baseline_query_spec.rb index 0e5bd289d5d..b9dce01eee5 100644 --- a/spec/features/work_packages/table/baseline/baseline_query_spec.rb +++ b/spec/features/work_packages/table/baseline/baseline_query_spec.rb @@ -28,10 +28,10 @@ require 'spec_helper' -describe 'baseline query saving', - js: true, - with_ee: %i[baseline_comparison], - with_settings: { date_format: '%Y-%m-%d' } do +RSpec.describe 'baseline query saving', + js: true, + with_ee: %i[baseline_comparison], + with_settings: { date_format: '%Y-%m-%d' } do shared_let(:project) { create(:project) } shared_let(:work_package) { create(:work_package, project:) } diff --git a/spec/features/work_packages/table/baseline/baseline_rendering_spec.rb b/spec/features/work_packages/table/baseline/baseline_rendering_spec.rb index 9d9683965e7..45b56ac65b1 100644 --- a/spec/features/work_packages/table/baseline/baseline_rendering_spec.rb +++ b/spec/features/work_packages/table/baseline/baseline_rendering_spec.rb @@ -28,9 +28,9 @@ require 'spec_helper' -describe 'baseline rendering', - js: true, - with_settings: { date_format: '%Y-%m-%d' } do +RSpec.describe 'baseline rendering', + js: true, + with_settings: { date_format: '%Y-%m-%d' } do shared_let(:type_bug) { create(:type_bug) } shared_let(:type_task) { create(:type_task) } shared_let(:project) { create(:project, types: [type_bug, type_task]) } diff --git a/spec/features/work_packages/table/configuration_modal/column_spec.rb b/spec/features/work_packages/table/configuration_modal/column_spec.rb index c97d4ed7692..0060a9b0397 100644 --- a/spec/features/work_packages/table/configuration_modal/column_spec.rb +++ b/spec/features/work_packages/table/configuration_modal/column_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Work Package table configuration modal columns spec', js: true do +RSpec.describe 'Work Package table configuration modal columns spec', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/spec/features/work_packages/table/configuration_modal/filter_spec.rb b/spec/features/work_packages/table/configuration_modal/filter_spec.rb index f8f7f53f62c..e8b8fbf355c 100644 --- a/spec/features/work_packages/table/configuration_modal/filter_spec.rb +++ b/spec/features/work_packages/table/configuration_modal/filter_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Work Package table configuration modal filters spec', js: true do +RSpec.describe 'Work Package table configuration modal filters spec', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/spec/features/work_packages/table/configuration_modal/table_configuration_modal_spec.rb b/spec/features/work_packages/table/configuration_modal/table_configuration_modal_spec.rb index 2a1d2368ef7..2591435afd7 100644 --- a/spec/features/work_packages/table/configuration_modal/table_configuration_modal_spec.rb +++ b/spec/features/work_packages/table/configuration_modal/table_configuration_modal_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Work Package table configuration modal', js: true do +RSpec.describe 'Work Package table configuration modal', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/spec/features/work_packages/table/context_menu/context_menu_shared_examples.rb b/spec/features/work_packages/table/context_menu/context_menu_shared_examples.rb index 6fd79836811..ad9b940d2f7 100644 --- a/spec/features/work_packages/table/context_menu/context_menu_shared_examples.rb +++ b/spec/features/work_packages/table/context_menu/context_menu_shared_examples.rb @@ -1,6 +1,6 @@ require 'spec_helper' -shared_examples_for 'provides a single WP context menu' do +RSpec.shared_examples_for 'provides a single WP context menu' do let(:open_context_menu) { raise 'needs to be defined' } let(:destroy_modal) { Components::WorkPackages::DestroyModal.new } let(:time_logging_modal) { Components::TimeLoggingModal.new } diff --git a/spec/features/work_packages/table/context_menu/context_menu_spec.rb b/spec/features/work_packages/table/context_menu/context_menu_spec.rb index 48fa12740a0..9b61695769d 100644 --- a/spec/features/work_packages/table/context_menu/context_menu_spec.rb +++ b/spec/features/work_packages/table/context_menu/context_menu_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require_relative 'context_menu_shared_examples' -describe 'Work package table context menu', js: true do +RSpec.describe 'Work package table context menu', js: true do let(:user) { create(:admin) } let(:work_package) { create(:work_package) } diff --git a/spec/features/work_packages/table/delete_work_packages_spec.rb b/spec/features/work_packages/table/delete_work_packages_spec.rb index cb04f58f303..bdb5978a07a 100644 --- a/spec/features/work_packages/table/delete_work_packages_spec.rb +++ b/spec/features/work_packages/table/delete_work_packages_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Delete work package', js: true do +RSpec.describe 'Delete work package', js: true do let(:user) { create(:admin) } let(:context_menu) { Components::WorkPackages::ContextMenu.new } let(:destroy_modal) { Components::WorkPackages::DestroyModal.new } diff --git a/spec/features/work_packages/table/duration_field_spec.rb b/spec/features/work_packages/table/duration_field_spec.rb index dfbdd51efb4..e6103b8e363 100644 --- a/spec/features/work_packages/table/duration_field_spec.rb +++ b/spec/features/work_packages/table/duration_field_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' -describe 'Duration field in the work package table', - js: true do +RSpec.describe 'Duration field in the work package table', + js: true do shared_let(:current_user) { create(:admin) } shared_let(:work_package) do next_monday = Time.zone.today.beginning_of_week.next_occurring(:monday) diff --git a/spec/features/work_packages/table/edit_work_packages_spec.rb b/spec/features/work_packages/table/edit_work_packages_spec.rb index e72d7e4ef61..4d8aa7b7c9b 100644 --- a/spec/features/work_packages/table/edit_work_packages_spec.rb +++ b/spec/features/work_packages/table/edit_work_packages_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Inline editing work packages', js: true do +RSpec.describe 'Inline editing work packages', js: true do let(:manager_role) do create(:role, permissions: %i[view_work_packages diff --git a/spec/features/work_packages/table/empty_filters_spec.rb b/spec/features/work_packages/table/empty_filters_spec.rb index 6eb2853701f..f145955b6ec 100644 --- a/spec/features/work_packages/table/empty_filters_spec.rb +++ b/spec/features/work_packages/table/empty_filters_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Empty query filters', js: true do +RSpec.describe 'Empty query filters', js: true do let(:user) { create(:admin) } let(:work_package) { create(:work_package) } let(:wp_table) { Pages::WorkPackagesTable.new } diff --git a/spec/features/work_packages/table/group_by/group_by_boolean_spec.rb b/spec/features/work_packages/table/group_by/group_by_boolean_spec.rb index 828638a7c19..f1270954fe3 100644 --- a/spec/features/work_packages/table/group_by/group_by_boolean_spec.rb +++ b/spec/features/work_packages/table/group_by/group_by_boolean_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Work Package group by boolean field', js: true do +RSpec.describe 'Work Package group by boolean field', js: true do let(:user) { create(:admin) } let(:project) { create(:project, types: [type], work_package_custom_fields: [bool_cf]) } diff --git a/spec/features/work_packages/table/group_by/group_by_progress_spec.rb b/spec/features/work_packages/table/group_by/group_by_progress_spec.rb index af94c28c3d8..5cca515c3da 100644 --- a/spec/features/work_packages/table/group_by/group_by_progress_spec.rb +++ b/spec/features/work_packages/table/group_by/group_by_progress_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Work Package group by progress', js: true do +RSpec.describe 'Work Package group by progress', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/spec/features/work_packages/table/group_by/group_headers_spec.rb b/spec/features/work_packages/table/group_by/group_headers_spec.rb index b1b02420678..bbd5d9d0da9 100644 --- a/spec/features/work_packages/table/group_by/group_headers_spec.rb +++ b/spec/features/work_packages/table/group_by/group_headers_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Work Package table group headers', js: true do +RSpec.describe 'Work Package table group headers', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/spec/features/work_packages/table/hierarchy/hierarchy_indent_spec.rb b/spec/features/work_packages/table/hierarchy/hierarchy_indent_spec.rb index 5254a18e5c5..0e154dcd5f4 100644 --- a/spec/features/work_packages/table/hierarchy/hierarchy_indent_spec.rb +++ b/spec/features/work_packages/table/hierarchy/hierarchy_indent_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Work Package table hierarchy and sorting', js: true do +RSpec.describe 'Work Package table hierarchy and sorting', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/spec/features/work_packages/table/hierarchy/hierarchy_parent_below_spec.rb b/spec/features/work_packages/table/hierarchy/hierarchy_parent_below_spec.rb index 1246e6ae17e..b2bd7949571 100644 --- a/spec/features/work_packages/table/hierarchy/hierarchy_parent_below_spec.rb +++ b/spec/features/work_packages/table/hierarchy/hierarchy_parent_below_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Work Package table hierarchy parent below', js: true do +RSpec.describe 'Work Package table hierarchy parent below', js: true do let(:user) { create(:admin) } let(:type_bug) { create(:type_bug) } let(:type_task) { create(:type_task) } diff --git a/spec/features/work_packages/table/hierarchy/hierarchy_sorting_spec.rb b/spec/features/work_packages/table/hierarchy/hierarchy_sorting_spec.rb index 45dc8257a41..ebeb987cb09 100644 --- a/spec/features/work_packages/table/hierarchy/hierarchy_sorting_spec.rb +++ b/spec/features/work_packages/table/hierarchy/hierarchy_sorting_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Work Package table hierarchy and sorting', js: true do +RSpec.describe 'Work Package table hierarchy and sorting', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/spec/features/work_packages/table/hierarchy/hierarchy_spec.rb b/spec/features/work_packages/table/hierarchy/hierarchy_spec.rb index 926841ab37b..48b9c0ab9f0 100644 --- a/spec/features/work_packages/table/hierarchy/hierarchy_spec.rb +++ b/spec/features/work_packages/table/hierarchy/hierarchy_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Work Package table hierarchy', js: true do +RSpec.describe 'Work Package table hierarchy', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/spec/features/work_packages/table/hierarchy/hierarchy_vs_grouping_spec.rb b/spec/features/work_packages/table/hierarchy/hierarchy_vs_grouping_spec.rb index 70cbe2aa354..27353ad8d27 100644 --- a/spec/features/work_packages/table/hierarchy/hierarchy_vs_grouping_spec.rb +++ b/spec/features/work_packages/table/hierarchy/hierarchy_vs_grouping_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Work Package table hierarchy vs grouping', js: true do +RSpec.describe 'Work Package table hierarchy vs grouping', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/spec/features/work_packages/table/hierarchy/parent_column_spec.rb b/spec/features/work_packages/table/hierarchy/parent_column_spec.rb index ce1df278c2e..ddab51aae8d 100644 --- a/spec/features/work_packages/table/hierarchy/parent_column_spec.rb +++ b/spec/features/work_packages/table/hierarchy/parent_column_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Work Package table parent column', js: true do +RSpec.describe 'Work Package table parent column', js: true do let(:user) { create(:admin) } let!(:parent) { create(:work_package, project:) } let!(:child) { create(:work_package, project:, parent:) } diff --git a/spec/features/work_packages/table/inline_create/create_work_packages_spec.rb b/spec/features/work_packages/table/inline_create/create_work_packages_spec.rb index 7532d0d6810..8a3f5b96e76 100644 --- a/spec/features/work_packages/table/inline_create/create_work_packages_spec.rb +++ b/spec/features/work_packages/table/inline_create/create_work_packages_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'inline create work package', js: true do +RSpec.describe 'inline create work package', js: true do let(:type) { create(:type) } let(:types) { [type] } diff --git a/spec/features/work_packages/table/inline_create/inline_create_refresh_spec.rb b/spec/features/work_packages/table/inline_create/inline_create_refresh_spec.rb index ca97201036d..32cab6ec6a0 100644 --- a/spec/features/work_packages/table/inline_create/inline_create_refresh_spec.rb +++ b/spec/features/work_packages/table/inline_create/inline_create_refresh_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Refreshing in inline-create row', flaky: true, js: true do +RSpec.describe 'Refreshing in inline-create row', flaky: true, js: true do let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/spec/features/work_packages/table/inline_create/parallel_creation_spec.rb b/spec/features/work_packages/table/inline_create/parallel_creation_spec.rb index d6aa765fec1..b66c9e2f3be 100644 --- a/spec/features/work_packages/table/inline_create/parallel_creation_spec.rb +++ b/spec/features/work_packages/table/inline_create/parallel_creation_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Parallel work package creation spec', js: true do +RSpec.describe 'Parallel work package creation spec', js: true do let(:type) { project.types.first } let(:permissions) { %i(view_work_packages add_work_packages edit_work_packages) } diff --git a/spec/features/work_packages/table/invalid_query_spec.rb b/spec/features/work_packages/table/invalid_query_spec.rb index 86b004e62e6..8a532b86b59 100644 --- a/spec/features/work_packages/table/invalid_query_spec.rb +++ b/spec/features/work_packages/table/invalid_query_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Invalid query spec', js: true do +RSpec.describe 'Invalid query spec', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/spec/features/work_packages/table/milestones_spec.rb b/spec/features/work_packages/table/milestones_spec.rb index 263c769a0ba..f9ea1a684e5 100644 --- a/spec/features/work_packages/table/milestones_spec.rb +++ b/spec/features/work_packages/table/milestones_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Inline editing milestones', js: true do +RSpec.describe 'Inline editing milestones', js: true do let(:user) { create(:admin) } let(:type) { create(:type, is_milestone: true) } diff --git a/spec/features/work_packages/table/queries/assignee_filter_spec.rb b/spec/features/work_packages/table/queries/assignee_filter_spec.rb index a50c5c3b9d2..7b8e1b875c9 100644 --- a/spec/features/work_packages/table/queries/assignee_filter_spec.rb +++ b/spec/features/work_packages/table/queries/assignee_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Work package filtering by assignee', js: true do +RSpec.describe 'Work package filtering by assignee', js: true do let(:project) { create(:project) } let(:invisible_project) { create(:project) } let(:wp_table) { Pages::WorkPackagesTable.new(project) } diff --git a/spec/features/work_packages/table/queries/assignees_role_filter_spec.rb b/spec/features/work_packages/table/queries/assignees_role_filter_spec.rb index b15839044e4..bc5753fb93d 100644 --- a/spec/features/work_packages/table/queries/assignees_role_filter_spec.rb +++ b/spec/features/work_packages/table/queries/assignees_role_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe "Work package filtering by assignee's role", js: true do +RSpec.describe "Work package filtering by assignee's role", js: true do shared_let(:project) { create(:project) } shared_let(:role) { create(:role, permissions: %i[view_work_packages save_queries]) } shared_let(:global_role) { create(:global_role, permissions: %i[view_work_packages save_queries]) } diff --git a/spec/features/work_packages/table/queries/bool_cf_filter_spec.rb b/spec/features/work_packages/table/queries/bool_cf_filter_spec.rb index 6e8476a4187..ec8ef280076 100644 --- a/spec/features/work_packages/table/queries/bool_cf_filter_spec.rb +++ b/spec/features/work_packages/table/queries/bool_cf_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Work package filtering by bool custom field', js: true do +RSpec.describe 'Work package filtering by bool custom field', js: true do let(:project) { create(:project) } let(:type) { project.types.first } let(:wp_table) { Pages::WorkPackagesTable.new(project) } diff --git a/spec/features/work_packages/table/queries/default_queries_spec.rb b/spec/features/work_packages/table/queries/default_queries_spec.rb index 50ce2306794..cc4d93bf7d0 100644 --- a/spec/features/work_packages/table/queries/default_queries_spec.rb +++ b/spec/features/work_packages/table/queries/default_queries_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Default work package queries', js: true do +RSpec.describe 'Default work package queries', js: true do create_shared_association_defaults_for_work_package_factory shared_let(:user) { create(:admin) } diff --git a/spec/features/work_packages/table/queries/filter_pagination_spec.rb b/spec/features/work_packages/table/queries/filter_pagination_spec.rb index d8567d3ff72..c8bf5c12246 100644 --- a/spec/features/work_packages/table/queries/filter_pagination_spec.rb +++ b/spec/features/work_packages/table/queries/filter_pagination_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/work_packages/work_packages_page' -describe 'Filter updates pagination', js: true do +RSpec.describe 'Filter updates pagination', js: true do let(:user) do create(:user, member_in_project: project, diff --git a/spec/features/work_packages/table/queries/filter_spec.rb b/spec/features/work_packages/table/queries/filter_spec.rb index a73f5fa8fbf..0af9362be36 100644 --- a/spec/features/work_packages/table/queries/filter_spec.rb +++ b/spec/features/work_packages/table/queries/filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'filter work packages', js: true do +RSpec.describe 'filter work packages', js: true do shared_let(:user) { create(:admin) } shared_let(:watcher) { create(:user) } shared_let(:role) { create(:existing_role, permissions: [:view_work_packages]) } diff --git a/spec/features/work_packages/table/queries/id_filter_spec.rb b/spec/features/work_packages/table/queries/id_filter_spec.rb index da20c989a9d..5e89069d7cb 100644 --- a/spec/features/work_packages/table/queries/id_filter_spec.rb +++ b/spec/features/work_packages/table/queries/id_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Work package filtering by id', js: true do +RSpec.describe 'Work package filtering by id', js: true do let(:project) { create(:project) } let(:wp_table) { Pages::WorkPackagesTable.new(project) } let(:filters) { Components::WorkPackages::Filters.new } diff --git a/spec/features/work_packages/table/queries/me_filter_spec.rb b/spec/features/work_packages/table/queries/me_filter_spec.rb index fcb7ccf7736..af7df86689d 100644 --- a/spec/features/work_packages/table/queries/me_filter_spec.rb +++ b/spec/features/work_packages/table/queries/me_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'filter me value', js: true do +RSpec.describe 'filter me value', js: true do let(:status) { create(:default_status) } let!(:priority) { create(:default_priority) } let(:project) do diff --git a/spec/features/work_packages/table/queries/mobile_date_filter_spec.rb b/spec/features/work_packages/table/queries/mobile_date_filter_spec.rb index 7c6973d2482..78155b56580 100644 --- a/spec/features/work_packages/table/queries/mobile_date_filter_spec.rb +++ b/spec/features/work_packages/table/queries/mobile_date_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'mobile date filter work packages', js: true do +RSpec.describe 'mobile date filter work packages', js: true do shared_let(:user) { create(:admin) } shared_let(:project) { create(:project) } shared_let(:wp_table) { Pages::WorkPackagesTable.new(project) } diff --git a/spec/features/work_packages/table/queries/query_history_spec.rb b/spec/features/work_packages/table/queries/query_history_spec.rb index 13b5ef9342b..0acf4e9288f 100644 --- a/spec/features/work_packages/table/queries/query_history_spec.rb +++ b/spec/features/work_packages/table/queries/query_history_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Going back and forth through the browser history', js: true do +RSpec.describe 'Going back and forth through the browser history', js: true do let(:user) do create(:user, member_in_project: project, diff --git a/spec/features/work_packages/table/queries/query_menu_refresh_spec.rb b/spec/features/work_packages/table/queries/query_menu_refresh_spec.rb index 9a3a97429ec..99bed4876cf 100644 --- a/spec/features/work_packages/table/queries/query_menu_refresh_spec.rb +++ b/spec/features/work_packages/table/queries/query_menu_refresh_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Refreshing query menu item', js: true do +RSpec.describe 'Refreshing query menu item', js: true do let(:user) { create(:admin) } let(:project) { create(:project) } let(:wp_table) { Pages::WorkPackagesTable.new(project) } diff --git a/spec/features/work_packages/table/queries/query_menu_spec.rb b/spec/features/work_packages/table/queries/query_menu_spec.rb index 36684677375..1fa42e8d749 100644 --- a/spec/features/work_packages/table/queries/query_menu_spec.rb +++ b/spec/features/work_packages/table/queries/query_menu_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Query menu item', js: true do +RSpec.describe 'Query menu item', js: true do let(:project) { create(:project) } let(:wp_table) { Pages::WorkPackagesTable.new(project) } let(:filters) { Components::WorkPackages::Filters.new } diff --git a/spec/features/work_packages/table/queries/query_name_inline_edit_spec.rb b/spec/features/work_packages/table/queries/query_name_inline_edit_spec.rb index 4db3fa4cf7f..9261dff89f0 100644 --- a/spec/features/work_packages/table/queries/query_name_inline_edit_spec.rb +++ b/spec/features/work_packages/table/queries/query_name_inline_edit_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Query name inline edit', js: true do +RSpec.describe 'Query name inline edit', js: true do let(:user) do create(:user, member_in_project: project, diff --git a/spec/features/work_packages/table/queries/responsible_filter_spec.rb b/spec/features/work_packages/table/queries/responsible_filter_spec.rb index c9f5822c4b4..b63f719c631 100644 --- a/spec/features/work_packages/table/queries/responsible_filter_spec.rb +++ b/spec/features/work_packages/table/queries/responsible_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Work package filtering by responsible', js: true do +RSpec.describe 'Work package filtering by responsible', js: true do let(:project) { create(:project) } let(:wp_table) { Pages::WorkPackagesTable.new(project) } let(:filters) { Components::WorkPackages::Filters.new } diff --git a/spec/features/work_packages/table/queries/subject_filter_spec.rb b/spec/features/work_packages/table/queries/subject_filter_spec.rb index 34bac10c48b..c86ab1a3c91 100644 --- a/spec/features/work_packages/table/queries/subject_filter_spec.rb +++ b/spec/features/work_packages/table/queries/subject_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Work package filtering by subject', js: true do +RSpec.describe 'Work package filtering by subject', js: true do let(:project) { create(:project, public: true) } let(:admin) { create(:admin) } let(:wp_table) { Pages::WorkPackagesTable.new(project) } diff --git a/spec/features/work_packages/table/queries/summary_spec.rb b/spec/features/work_packages/table/queries/summary_spec.rb index 604e2bd1c71..6308f3a8d0a 100644 --- a/spec/features/work_packages/table/queries/summary_spec.rb +++ b/spec/features/work_packages/table/queries/summary_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/work_packages/work_packages_page' -describe 'Work package query summary item', js: true do +RSpec.describe 'Work package query summary item', js: true do let(:project) { create(:project, identifier: 'test_project', public: false) } let(:role) { create(:role, permissions: [:view_work_packages]) } let(:work_package) { create(:work_package, project:) } diff --git a/spec/features/work_packages/table/queries/user_cf_filter_spec.rb b/spec/features/work_packages/table/queries/user_cf_filter_spec.rb index 91be08f1311..e67c17f9fe0 100644 --- a/spec/features/work_packages/table/queries/user_cf_filter_spec.rb +++ b/spec/features/work_packages/table/queries/user_cf_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Work package filtering by user custom field', js: true do +RSpec.describe 'Work package filtering by user custom field', js: true do let(:project) { create(:project) } let(:type) { project.types.first } let(:wp_table) { Pages::WorkPackagesTable.new(project) } diff --git a/spec/features/work_packages/table/relations_spec.rb b/spec/features/work_packages/table/relations_spec.rb index 9969a47cfe3..2c424e4ad8e 100644 --- a/spec/features/work_packages/table/relations_spec.rb +++ b/spec/features/work_packages/table/relations_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Work Package table relations', js: true, with_ee: %i[work_package_query_relation_columns] do +RSpec.describe 'Work Package table relations', js: true, with_ee: %i[work_package_query_relation_columns] do let(:user) { create(:admin) } let(:type) { create(:type) } diff --git a/spec/features/work_packages/table/scheduling/manual_scheduling_spec.rb b/spec/features/work_packages/table/scheduling/manual_scheduling_spec.rb index 4dde52bbca6..9be850b3316 100644 --- a/spec/features/work_packages/table/scheduling/manual_scheduling_spec.rb +++ b/spec/features/work_packages/table/scheduling/manual_scheduling_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Manual scheduling', js: true do +RSpec.describe 'Manual scheduling', js: true do let(:project) { create(:project, types: [type]) } let(:type) { create(:type) } diff --git a/spec/features/work_packages/table/switch_types_spec.rb b/spec/features/work_packages/table/switch_types_spec.rb index ea9f52d120d..6e0c0b08e26 100644 --- a/spec/features/work_packages/table/switch_types_spec.rb +++ b/spec/features/work_packages/table/switch_types_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Switching types in work package table', js: true do +RSpec.describe 'Switching types in work package table', js: true do let(:user) { create(:admin) } describe 'switching to required CF' do diff --git a/spec/features/work_packages/table/work_packages_table_project_include_spec.rb b/spec/features/work_packages/table/work_packages_table_project_include_spec.rb index a6e7c99e538..7a9673647c3 100644 --- a/spec/features/work_packages/table/work_packages_table_project_include_spec.rb +++ b/spec/features/work_packages/table/work_packages_table_project_include_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../project_include/project_include_shared_examples' -describe 'Work package project include', js: true do +RSpec.describe 'Work package project include', js: true do shared_let(:enabled_modules) { %w[work_package_tracking] } shared_let(:status) { create(:default_status) } shared_let(:priority) { create(:default_priority) } diff --git a/spec/features/work_packages/tabs/activity_notifications_spec.rb b/spec/features/work_packages/tabs/activity_notifications_spec.rb index db97a39e8c8..a906a8dc7d1 100644 --- a/spec/features/work_packages/tabs/activity_notifications_spec.rb +++ b/spec/features/work_packages/tabs/activity_notifications_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' require 'features/work_packages/work_packages_page' require 'support/edit_fields/edit_field' -describe 'Activity tab notifications', js: true, selenium: true do +RSpec.describe 'Activity tab notifications', js: true, selenium: true do shared_let(:project) { create(:project_with_types, public: true) } shared_let(:work_package) do work_package = create(:work_package, diff --git a/spec/features/work_packages/tabs/activity_revisions_spec.rb b/spec/features/work_packages/tabs/activity_revisions_spec.rb index 22dbf582645..568ea2dffc0 100644 --- a/spec/features/work_packages/tabs/activity_revisions_spec.rb +++ b/spec/features/work_packages/tabs/activity_revisions_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' require 'features/work_packages/work_packages_page' require 'support/edit_fields/edit_field' -describe 'Activity tab', js: true, selenium: true do +RSpec.describe 'Activity tab', js: true, selenium: true do def alter_work_package_at(work_package, attributes:, at:, user:) work_package.update(attributes.merge(updated_at: at)) diff --git a/spec/features/work_packages/tabs/activity_tab_spec.rb b/spec/features/work_packages/tabs/activity_tab_spec.rb index 1faab434c98..8f635421175 100644 --- a/spec/features/work_packages/tabs/activity_tab_spec.rb +++ b/spec/features/work_packages/tabs/activity_tab_spec.rb @@ -31,9 +31,9 @@ require 'spec_helper' require 'features/work_packages/work_packages_page' require 'support/edit_fields/edit_field' -describe 'Activity tab', - js: true, - selenium: true do +RSpec.describe 'Activity tab', + js: true, + selenium: true do def alter_work_package_at(work_package, attributes:, at:, user: User.current) work_package.update(attributes.merge(updated_at: at)) diff --git a/spec/features/work_packages/tabs/watcher_tab_spec.rb b/spec/features/work_packages/tabs/watcher_tab_spec.rb index 90c910d2708..593d20eeff2 100644 --- a/spec/features/work_packages/tabs/watcher_tab_spec.rb +++ b/spec/features/work_packages/tabs/watcher_tab_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Watcher tab', js: true, selenium: true do +RSpec.describe 'Watcher tab', js: true, selenium: true do include Components::Autocompleter::NgSelectAutocompleteHelpers let(:project) { create(:project) } diff --git a/spec/features/work_packages/work_package_workflow_form_spec.rb b/spec/features/work_packages/work_package_workflow_form_spec.rb index 3887e6cc325..7c167456cc4 100644 --- a/spec/features/work_packages/work_package_workflow_form_spec.rb +++ b/spec/features/work_packages/work_package_workflow_form_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'features/page_objects/notification' -describe 'Work package transitive status workflows', js: true do +RSpec.describe 'Work package transitive status workflows', js: true do let(:dev_role) do create(:role, permissions: %i[view_work_packages diff --git a/spec/features/work_packages/zen_mode_spec.rb b/spec/features/work_packages/zen_mode_spec.rb index f9fd0f3fb85..0a851e54159 100644 --- a/spec/features/work_packages/zen_mode_spec.rb +++ b/spec/features/work_packages/zen_mode_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe 'Zen mode', js: true do +RSpec.describe 'Zen mode', js: true do let(:dev_role) do create(:role, permissions: %i[view_work_packages diff --git a/spec/features/workflows/copy_spec.rb b/spec/features/workflows/copy_spec.rb index 2087438ec1a..e1eb23a3f44 100644 --- a/spec/features/workflows/copy_spec.rb +++ b/spec/features/workflows/copy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Workflow copy' do +RSpec.describe 'Workflow copy' do let(:role) { create(:role) } let(:type) { create(:type) } let(:admin) { create(:admin) } diff --git a/spec/features/wysiwyg/custom_css_classes_spec.rb b/spec/features/wysiwyg/custom_css_classes_spec.rb index 4a057aedb7d..6bbd6b527a4 100644 --- a/spec/features/wysiwyg/custom_css_classes_spec.rb +++ b/spec/features/wysiwyg/custom_css_classes_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Wysiwyg paragraphs in lists behavior (Regression #28765)', - js: true do +RSpec.describe 'Wysiwyg paragraphs in lists behavior (Regression #28765)', + js: true do let(:user) { create(:admin) } let(:project) { create(:project, enabled_module_names: %w[wiki]) } let(:editor) { Components::WysiwygEditor.new } diff --git a/spec/features/wysiwyg/html_encoding_spec.rb b/spec/features/wysiwyg/html_encoding_spec.rb index b5676f7392a..936fe8cfbd3 100644 --- a/spec/features/wysiwyg/html_encoding_spec.rb +++ b/spec/features/wysiwyg/html_encoding_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Wysiwyg escaping HTML entities (Regression #28906)', - js: true do +RSpec.describe 'Wysiwyg escaping HTML entities (Regression #28906)', + js: true do let(:user) { create(:admin) } let(:project) { create(:project, enabled_module_names: %w[wiki]) } let(:editor) { Components::WysiwygEditor.new } diff --git a/spec/features/wysiwyg/linking_spec.rb b/spec/features/wysiwyg/linking_spec.rb index 8d64d411791..e54a349385b 100644 --- a/spec/features/wysiwyg/linking_spec.rb +++ b/spec/features/wysiwyg/linking_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Wysiwyg linking', - js: true do +RSpec.describe 'Wysiwyg linking', + js: true do let(:user) { create(:admin) } let(:project) { create(:project, enabled_module_names: %w[wiki work_package_tracking]) } let(:editor) { Components::WysiwygEditor.new } diff --git a/spec/features/wysiwyg/macros/attribute_macros_spec.rb b/spec/features/wysiwyg/macros/attribute_macros_spec.rb index 922f32e9a40..ddb3eb567eb 100644 --- a/spec/features/wysiwyg/macros/attribute_macros_spec.rb +++ b/spec/features/wysiwyg/macros/attribute_macros_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Wysiwyg attribute macros', js: true do +RSpec.describe 'Wysiwyg attribute macros', js: true do shared_let(:admin) { create(:admin) } let(:user) { admin } let!(:project) { create(:project, identifier: 'some-project', enabled_module_names: %w[wiki work_package_tracking]) } diff --git a/spec/features/wysiwyg/macros/child_pages_spec.rb b/spec/features/wysiwyg/macros/child_pages_spec.rb index f9a0bc72b87..1fb5f3d4580 100644 --- a/spec/features/wysiwyg/macros/child_pages_spec.rb +++ b/spec/features/wysiwyg/macros/child_pages_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Wysiwyg child pages spec', - js: true do +RSpec.describe 'Wysiwyg child pages spec', + js: true do let(:project) do create(:project, enabled_module_names: %w[wiki]) diff --git a/spec/features/wysiwyg/macros/code_block_macro_spec.rb b/spec/features/wysiwyg/macros/code_block_macro_spec.rb index f6ae4523f04..45cc67f566b 100644 --- a/spec/features/wysiwyg/macros/code_block_macro_spec.rb +++ b/spec/features/wysiwyg/macros/code_block_macro_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Wysiwyg code block macro', - js: true do +RSpec.describe 'Wysiwyg code block macro', + js: true do shared_let(:admin) { create(:admin) } let(:user) { admin } let(:project) { create(:project, enabled_module_names: %w[wiki]) } diff --git a/spec/features/wysiwyg/macros/embedded_tables_spec.rb b/spec/features/wysiwyg/macros/embedded_tables_spec.rb index 555cc0df68b..4b81040a76d 100644 --- a/spec/features/wysiwyg/macros/embedded_tables_spec.rb +++ b/spec/features/wysiwyg/macros/embedded_tables_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Wysiwyg embedded work package tables', - js: true do +RSpec.describe 'Wysiwyg embedded work package tables', + js: true do shared_let(:admin) { create(:admin) } let(:user) { admin } let(:type_task) { create(:type_task) } diff --git a/spec/features/wysiwyg/macros/quicklink_macros_spec.rb b/spec/features/wysiwyg/macros/quicklink_macros_spec.rb index bedadd920aa..2228ee625e2 100644 --- a/spec/features/wysiwyg/macros/quicklink_macros_spec.rb +++ b/spec/features/wysiwyg/macros/quicklink_macros_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Wysiwyg work package quicklink macros', js: true do +RSpec.describe 'Wysiwyg work package quicklink macros', js: true do shared_let(:user) { create(:admin) } shared_let(:project) { create(:project_with_types) } let(:work_package) do diff --git a/spec/features/wysiwyg/macros/work_package_button_spec.rb b/spec/features/wysiwyg/macros/work_package_button_spec.rb index 42f9dbcb637..cb848c96dc8 100644 --- a/spec/features/wysiwyg/macros/work_package_button_spec.rb +++ b/spec/features/wysiwyg/macros/work_package_button_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Wysiwyg work package button spec', - js: true do +RSpec.describe 'Wysiwyg work package button spec', + js: true do shared_let(:admin) { create(:admin) } let(:user) { admin } diff --git a/spec/features/wysiwyg/non_breaking_spaces_spec.rb b/spec/features/wysiwyg/non_breaking_spaces_spec.rb index f844c088f3c..23cc9d157ad 100644 --- a/spec/features/wysiwyg/non_breaking_spaces_spec.rb +++ b/spec/features/wysiwyg/non_breaking_spaces_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Wysiwyg   behavior', - js: true do +RSpec.describe 'Wysiwyg   behavior', + js: true do shared_let(:admin) { create(:admin) } let(:user) { admin } diff --git a/spec/features/wysiwyg/paragraphs_in_lists_spec.rb b/spec/features/wysiwyg/paragraphs_in_lists_spec.rb index 5a01b763d8d..082ec88b4ae 100644 --- a/spec/features/wysiwyg/paragraphs_in_lists_spec.rb +++ b/spec/features/wysiwyg/paragraphs_in_lists_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Wysiwyg paragraphs in lists behavior (Regression #28765)', - js: true do +RSpec.describe 'Wysiwyg paragraphs in lists behavior (Regression #28765)', + js: true do let(:user) { create(:admin) } let(:project) { create(:project, enabled_module_names: %w[wiki]) } let(:editor) { Components::WysiwygEditor.new } diff --git a/spec/features/wysiwyg/tables_spec.rb b/spec/features/wysiwyg/tables_spec.rb index c25605d01f4..1293347c5cd 100644 --- a/spec/features/wysiwyg/tables_spec.rb +++ b/spec/features/wysiwyg/tables_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Wysiwyg tables', - js: true do +RSpec.describe 'Wysiwyg tables', + js: true do shared_let(:admin) { create(:admin) } let(:user) { admin } diff --git a/spec/features/wysiwyg/ui_localization_spec.rb b/spec/features/wysiwyg/ui_localization_spec.rb index b420db3ab87..5d9afa0dee1 100644 --- a/spec/features/wysiwyg/ui_localization_spec.rb +++ b/spec/features/wysiwyg/ui_localization_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'WYSIWYG UI localization', - js: true do +RSpec.describe 'WYSIWYG UI localization', + js: true do let(:user) { create(:admin, language:) } let(:project) { create(:project, enabled_module_names: %w[wiki]) } let(:editor) { Components::WysiwygEditor.new } diff --git a/spec/features/wysiwyg/user_mention_spec.rb b/spec/features/wysiwyg/user_mention_spec.rb index c804d2d170b..5f399c20a4f 100644 --- a/spec/features/wysiwyg/user_mention_spec.rb +++ b/spec/features/wysiwyg/user_mention_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Wysiwyg work package user mentions', - js: true do +RSpec.describe 'Wysiwyg work package user mentions', + js: true do let!(:user) { create(:admin, firstname: 'MeMyself', lastname: 'AndI', member_in_project: project) } let!(:user2) { create(:user, firstname: 'Foo', lastname: 'Bar', member_in_project: project) } let!(:group) { create(:group, firstname: 'Foogroup', lastname: 'Foogroup') } diff --git a/spec/features/wysiwyg/work_package_linking_spec.rb b/spec/features/wysiwyg/work_package_linking_spec.rb index eb3bdebd174..878c5891ad8 100644 --- a/spec/features/wysiwyg/work_package_linking_spec.rb +++ b/spec/features/wysiwyg/work_package_linking_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'Wysiwyg work package linking', - js: true do +RSpec.describe 'Wysiwyg work package linking', + js: true do let(:user) { create(:admin) } let(:project) { create(:project, enabled_module_names: %w[wiki work_package_tracking]) } let(:work_package) { create(:work_package, subject: 'Foobar', project:) } diff --git a/spec/helpers/additional_url_helper_spec.rb b/spec/helpers/additional_url_helper_spec.rb index 4f497f2d613..d7dde2902fa 100644 --- a/spec/helpers/additional_url_helper_spec.rb +++ b/spec/helpers/additional_url_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe AdditionalUrlHelpers do +RSpec.describe AdditionalUrlHelpers do describe '#configurable_home_url' do subject { helper.send :configurable_home_url } diff --git a/spec/helpers/angular_helper_spec.rb b/spec/helpers/angular_helper_spec.rb index 09b2e46ab3d..f1fc3d7c4ae 100644 --- a/spec/helpers/angular_helper_spec.rb +++ b/spec/helpers/angular_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe AngularHelper do +RSpec.describe AngularHelper do let(:tag_name) { 'op-test' } let(:options) do { diff --git a/spec/helpers/application_helper_spec.rb b/spec/helpers/application_helper_spec.rb index 9738d4e5724..dac9ba00b05 100644 --- a/spec/helpers/application_helper_spec.rb +++ b/spec/helpers/application_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ApplicationHelper do +RSpec.describe ApplicationHelper do describe '.link_to_if_authorized' do let(:project) { create(:valid_project) } let(:project_member) do diff --git a/spec/helpers/custom_styles_helper_spec.rb b/spec/helpers/custom_styles_helper_spec.rb index 3595df995dc..14a66fefe16 100644 --- a/spec/helpers/custom_styles_helper_spec.rb +++ b/spec/helpers/custom_styles_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomStylesHelper do +RSpec.describe CustomStylesHelper do let(:current_theme) { nil } let(:bim_edition?) { false } diff --git a/spec/helpers/frontend_asset_helper_spec.rb b/spec/helpers/frontend_asset_helper_spec.rb index c3da4b651b3..e646e1dba5a 100644 --- a/spec/helpers/frontend_asset_helper_spec.rb +++ b/spec/helpers/frontend_asset_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe FrontendAssetHelper do +RSpec.describe FrontendAssetHelper do describe '#include_frontend_assets' do context 'when in development or test' do before do diff --git a/spec/helpers/hook_helper_spec.rb b/spec/helpers/hook_helper_spec.rb index 44429db32e9..76883b68b86 100644 --- a/spec/helpers/hook_helper_spec.rb +++ b/spec/helpers/hook_helper_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe HookHelper do +RSpec.describe HookHelper do describe '#call_hook' do context 'when called within a controller' do let(:test_hook_controller_class) do diff --git a/spec/helpers/individual_principal_hooks_helper_spec.rb b/spec/helpers/individual_principal_hooks_helper_spec.rb index 9a9d1351ef6..ff607c0b80e 100644 --- a/spec/helpers/individual_principal_hooks_helper_spec.rb +++ b/spec/helpers/individual_principal_hooks_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe IndividualPrincipalHooksHelper do +RSpec.describe IndividualPrincipalHooksHelper do let(:user) { build(:user) } let(:placeholder_user) { build(:placeholder_user) } diff --git a/spec/helpers/no_results_helper_spec.rb b/spec/helpers/no_results_helper_spec.rb index ef9c9175696..41e7a7fe9c0 100644 --- a/spec/helpers/no_results_helper_spec.rb +++ b/spec/helpers/no_results_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe NoResultsHelper do +RSpec.describe NoResultsHelper do before do allow(helper).to receive(:t).with('.no_results_title_text', cascade: true).and_return("Nothing here!") allow(helper).to receive(:t).with('.no_results_content_text').and_return("Add some foo") diff --git a/spec/helpers/pagination_helper_spec.rb b/spec/helpers/pagination_helper_spec.rb index 1358d04e18f..e87b288bc4c 100644 --- a/spec/helpers/pagination_helper_spec.rb +++ b/spec/helpers/pagination_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe PaginationHelper do +RSpec.describe PaginationHelper do let(:paginator) do # creating a mock pagination object # this one is then identical (from the interface) to a active record diff --git a/spec/helpers/projects_helper_spec.rb b/spec/helpers/projects_helper_spec.rb index 1e1cbab96b3..b5439cb885f 100644 --- a/spec/helpers/projects_helper_spec.rb +++ b/spec/helpers/projects_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ProjectsHelper do +RSpec.describe ProjectsHelper do include ApplicationHelper include ProjectsHelper diff --git a/spec/helpers/removed_js_helpers_helper_spec.rb b/spec/helpers/removed_js_helpers_helper_spec.rb index 69764c8f880..cc96a118ed5 100644 --- a/spec/helpers/removed_js_helpers_helper_spec.rb +++ b/spec/helpers/removed_js_helpers_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RemovedJsHelpersHelper do +RSpec.describe RemovedJsHelpersHelper do include RemovedJsHelpersHelper describe 'link_to_function' do diff --git a/spec/helpers/search_helper_spec.rb b/spec/helpers/search_helper_spec.rb index 44502bc4b07..181a60a73bc 100644 --- a/spec/helpers/search_helper_spec.rb +++ b/spec/helpers/search_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'search/index' do +RSpec.describe 'search/index' do let(:project) { create(:project) } let(:scope) { 'foobar' } diff --git a/spec/helpers/security_badge_helper_spec.rb b/spec/helpers/security_badge_helper_spec.rb index 30f272ecb6b..66ee6bef3eb 100644 --- a/spec/helpers/security_badge_helper_spec.rb +++ b/spec/helpers/security_badge_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe SecurityBadgeHelper do +RSpec.describe SecurityBadgeHelper do describe '#security_badge_url' do before do # can't use with_settings since Setting.installation_uuid has a custom implementation diff --git a/spec/helpers/settings_helper_spec.rb b/spec/helpers/settings_helper_spec.rb index 84cf6898987..0d934ae95a1 100644 --- a/spec/helpers/settings_helper_spec.rb +++ b/spec/helpers/settings_helper_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'ostruct' -describe SettingsHelper do +RSpec.describe SettingsHelper do include Capybara::RSpecMatchers let(:options) { { class: 'custom-class' } } diff --git a/spec/helpers/sort_helper_spec.rb b/spec/helpers/sort_helper_spec.rb index 827f4b492f2..54108f2d68b 100644 --- a/spec/helpers/sort_helper_spec.rb +++ b/spec/helpers/sort_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe SortHelper do +RSpec.describe SortHelper do describe '#sort_init/#sort_update/#sort_clause' do # Needed to mimic being included in a controller def controller_name; 'foo'; end diff --git a/spec/helpers/tabs_helper_spec.rb b/spec/helpers/tabs_helper_spec.rb index 62a12812754..73884ffe456 100644 --- a/spec/helpers/tabs_helper_spec.rb +++ b/spec/helpers/tabs_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe TabsHelper do +RSpec.describe TabsHelper do include TabsHelper let(:given_tab) do diff --git a/spec/helpers/text_formatting_helper_spec.rb b/spec/helpers/text_formatting_helper_spec.rb index b61f913e486..fb55e78f84b 100644 --- a/spec/helpers/text_formatting_helper_spec.rb +++ b/spec/helpers/text_formatting_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe TextFormattingHelper do +RSpec.describe TextFormattingHelper do describe '#preview_context' do context 'for a News' do let(:news) { build_stubbed(:news) } diff --git a/spec/helpers/toolbar_helper_spec.rb b/spec/helpers/toolbar_helper_spec.rb index d84cca33da9..c8c791e2725 100644 --- a/spec/helpers/toolbar_helper_spec.rb +++ b/spec/helpers/toolbar_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ToolbarHelper do +RSpec.describe ToolbarHelper do describe '.toolbar' do it 'creates a default toolbar' do result = toolbar title: 'Title' diff --git a/spec/helpers/types_helper_spec.rb b/spec/helpers/types_helper_spec.rb index ad09b7eb465..ae55cd63332 100644 --- a/spec/helpers/types_helper_spec.rb +++ b/spec/helpers/types_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe TypesHelper do +RSpec.describe TypesHelper do let(:type) { build_stubbed(:type) } describe "#form_configuration_groups" do diff --git a/spec/helpers/users_helper_spec.rb b/spec/helpers/users_helper_spec.rb index a425ad91bdf..ee73ee5b880 100644 --- a/spec/helpers/users_helper_spec.rb +++ b/spec/helpers/users_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe UsersHelper do +RSpec.describe UsersHelper do def build_user(status, blocked) build_stubbed(:user, status:, diff --git a/spec/helpers/versions_helper_spec.rb b/spec/helpers/versions_helper_spec.rb index 62c20e1135b..79e56a2c63d 100644 --- a/spec/helpers/versions_helper_spec.rb +++ b/spec/helpers/versions_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe VersionsHelper do +RSpec.describe VersionsHelper do include ApplicationHelper let(:test_project) { build_stubbed(:valid_project) } diff --git a/spec/helpers/wiki_pages/at_version_spec.rb b/spec/helpers/wiki_pages/at_version_spec.rb index 7497d8b1bc3..87fbe1d42c8 100644 --- a/spec/helpers/wiki_pages/at_version_spec.rb +++ b/spec/helpers/wiki_pages/at_version_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WikiPages::AtVersion do +RSpec.describe WikiPages::AtVersion do let(:wiki_page) do build_stubbed(:wiki_page, author: first_journal_user, diff --git a/spec/helpers/work_packages_filter_helper_spec.rb b/spec/helpers/work_packages_filter_helper_spec.rb index 2f7e6ed634b..f5cfde8f099 100644 --- a/spec/helpers/work_packages_filter_helper_spec.rb +++ b/spec/helpers/work_packages_filter_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackagesFilterHelper do +RSpec.describe WorkPackagesFilterHelper do let(:project) { create(:project) } let(:version) { create(:version, project:) } let(:global) { false } diff --git a/spec/helpers/work_packages_helper_spec.rb b/spec/helpers/work_packages_helper_spec.rb index 5295c41144a..3f0c08bd64e 100644 --- a/spec/helpers/work_packages_helper_spec.rb +++ b/spec/helpers/work_packages_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackagesHelper do +RSpec.describe WorkPackagesHelper do let(:stub_work_package) { build_stubbed(:work_package, type: stub_type) } let(:stub_project) { build_stubbed(:project) } let(:stub_type) { build_stubbed(:type) } diff --git a/spec/lib/acts_as_journalized/journable_differ_spec.rb b/spec/lib/acts_as_journalized/journable_differ_spec.rb index fc12fd69c87..c7f89e63cbb 100644 --- a/spec/lib/acts_as_journalized/journable_differ_spec.rb +++ b/spec/lib/acts_as_journalized/journable_differ_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Acts::Journalized::JournableDiffer do +RSpec.describe Acts::Journalized::JournableDiffer do describe '.changes' do context 'when the objects are work packages' do let(:original) do diff --git a/spec/lib/acts_as_journalized/journaled_spec.rb b/spec/lib/acts_as_journalized/journaled_spec.rb index 0a7ac835299..f78f89712b1 100644 --- a/spec/lib/acts_as_journalized/journaled_spec.rb +++ b/spec/lib/acts_as_journalized/journaled_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Journalized Objects' do +RSpec.describe 'Journalized Objects' do describe 'journal_editable_by?' do context 'when the journable is a work package' do let!(:user) { create(:user, member_in_project: project, member_with_permissions: []) } diff --git a/spec/lib/acts_as_list/acts_as_list_patch_spec.rb b/spec/lib/acts_as_list/acts_as_list_patch_spec.rb index e6e6130049c..62c860025c3 100644 --- a/spec/lib/acts_as_list/acts_as_list_patch_spec.rb +++ b/spec/lib/acts_as_list/acts_as_list_patch_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Models acting as list (acts_as_list)' do +RSpec.describe 'Models acting as list (acts_as_list)' do it 'includes the patch' do expect(ActiveRecord::Acts::List::InstanceMethods.included_modules).to include(OpenProject::Patches::ActsAsList) end diff --git a/spec/lib/acts_as_watchable/lib/acts_as_watchable/routes_spec.rb b/spec/lib/acts_as_watchable/lib/acts_as_watchable/routes_spec.rb index 580228c6616..55a740bed8f 100644 --- a/spec/lib/acts_as_watchable/lib/acts_as_watchable/routes_spec.rb +++ b/spec/lib/acts_as_watchable/lib/acts_as_watchable/routes_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::Acts::Watchable::Routes do +RSpec.describe OpenProject::Acts::Watchable::Routes do let(:request) do Struct.new(:type, :id) do def path_parameters diff --git a/spec/lib/api/contracts/model_contract_spec.rb b/spec/lib/api/contracts/model_contract_spec.rb index a8d5f1e560e..a34e0ad9cc4 100644 --- a/spec/lib/api/contracts/model_contract_spec.rb +++ b/spec/lib/api/contracts/model_contract_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe ModelContract do +RSpec.describe ModelContract do let(:model) do double('The model', child_attribute: nil, diff --git a/spec/lib/api/decorators/aggregation_group_spec.rb b/spec/lib/api/decorators/aggregation_group_spec.rb index 25247865e3b..ab47ebeda0c 100644 --- a/spec/lib/api/decorators/aggregation_group_spec.rb +++ b/spec/lib/api/decorators/aggregation_group_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::Decorators::AggregationGroup do +RSpec.describe API::Decorators::AggregationGroup do let(:query) do query = build_stubbed(:query) query.group_by = :assigned_to diff --git a/spec/lib/api/decorators/formattable_spec.rb b/spec/lib/api/decorators/formattable_spec.rb index c519491dfb7..1183815476f 100644 --- a/spec/lib/api/decorators/formattable_spec.rb +++ b/spec/lib/api/decorators/formattable_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::Decorators::Formattable do +RSpec.describe API::Decorators::Formattable do let(:represented) { 'A **raw** string!' } subject { described_class.new(represented).to_json } diff --git a/spec/lib/api/decorators/link_object_spec.rb b/spec/lib/api/decorators/link_object_spec.rb index 4fbb40266be..85f8f0fc2c7 100644 --- a/spec/lib/api/decorators/link_object_spec.rb +++ b/spec/lib/api/decorators/link_object_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::Decorators::LinkObject do +RSpec.describe API::Decorators::LinkObject do include API::V3::Utilities::PathHelper let(:represented) { API::ParserStruct.new } diff --git a/spec/lib/api/utilities/property_name_converter_spec.rb b/spec/lib/api/utilities/property_name_converter_spec.rb index d0c6afb7eab..4a56d06e67a 100644 --- a/spec/lib/api/utilities/property_name_converter_spec.rb +++ b/spec/lib/api/utilities/property_name_converter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::Utilities::PropertyNameConverter do +RSpec.describe API::Utilities::PropertyNameConverter do describe '#from_ar_name' do let(:attribute_name) { :an_attribute } diff --git a/spec/lib/api/utilities/resource_link_parser_spec.rb b/spec/lib/api/utilities/resource_link_parser_spec.rb index 18dd95ef784..1c8f91f337f 100644 --- a/spec/lib/api/utilities/resource_link_parser_spec.rb +++ b/spec/lib/api/utilities/resource_link_parser_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::Utilities::ResourceLinkParser do +RSpec.describe API::Utilities::ResourceLinkParser do subject { described_class } describe '#parse' do diff --git a/spec/lib/api/utilities/url_props_parsing_helper_spec.rb b/spec/lib/api/utilities/url_props_parsing_helper_spec.rb index cee7096441d..1f729d2a71f 100644 --- a/spec/lib/api/utilities/url_props_parsing_helper_spec.rb +++ b/spec/lib/api/utilities/url_props_parsing_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::Utilities::UrlPropsParsingHelper do +RSpec.describe API::Utilities::UrlPropsParsingHelper do let(:clazz) do Class.new do include API::Utilities::UrlPropsParsingHelper diff --git a/spec/lib/api/v3/actions/action_sql_respresenter_rendering_spec.rb b/spec/lib/api/v3/actions/action_sql_respresenter_rendering_spec.rb index 9dccc2f6075..3cb972a297d 100644 --- a/spec/lib/api/v3/actions/action_sql_respresenter_rendering_spec.rb +++ b/spec/lib/api/v3/actions/action_sql_respresenter_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Actions::ActionSqlRepresenter, 'rendering' do +RSpec.describe API::V3::Actions::ActionSqlRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:scope) do diff --git a/spec/lib/api/v3/activities/activity_representer_rendering_spec.rb b/spec/lib/api/v3/activities/activity_representer_rendering_spec.rb index 7aab5920568..a69b5d7b138 100644 --- a/spec/lib/api/v3/activities/activity_representer_rendering_spec.rb +++ b/spec/lib/api/v3/activities/activity_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Activities::ActivityRepresenter, 'rendering' do +RSpec.describe API::V3::Activities::ActivityRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:current_user) do diff --git a/spec/lib/api/v3/attachments/attachment_metadata_representer_spec.rb b/spec/lib/api/v3/attachments/attachment_metadata_representer_spec.rb index e429f6f4cbd..f939d2f8b5d 100644 --- a/spec/lib/api/v3/attachments/attachment_metadata_representer_spec.rb +++ b/spec/lib/api/v3/attachments/attachment_metadata_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Attachments::AttachmentParsingRepresenter do +RSpec.describe API::V3::Attachments::AttachmentParsingRepresenter do let(:current_user) { build_stubbed(:user) } let(:metadata) do data = API::ParserStruct.new diff --git a/spec/lib/api/v3/attachments/attachment_representer_spec.rb b/spec/lib/api/v3/attachments/attachment_representer_spec.rb index cd174b44957..22750778343 100644 --- a/spec/lib/api/v3/attachments/attachment_representer_spec.rb +++ b/spec/lib/api/v3/attachments/attachment_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Attachments::AttachmentRepresenter do +RSpec.describe API::V3::Attachments::AttachmentRepresenter do include API::V3::Utilities::PathHelper let(:current_user) do diff --git a/spec/lib/api/v3/capabilities/capability_sql_representer_rendering_spec.rb b/spec/lib/api/v3/capabilities/capability_sql_representer_rendering_spec.rb index be2b25583ba..407616eb2ef 100644 --- a/spec/lib/api/v3/capabilities/capability_sql_representer_rendering_spec.rb +++ b/spec/lib/api/v3/capabilities/capability_sql_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Capabilities::CapabilitySqlRepresenter, 'rendering' do +RSpec.describe API::V3::Capabilities::CapabilitySqlRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:scope) do diff --git a/spec/lib/api/v3/capabilities/contexts/global_representer_rendering_spec.rb b/spec/lib/api/v3/capabilities/contexts/global_representer_rendering_spec.rb index 1b952e4dcde..e00b31bee45 100644 --- a/spec/lib/api/v3/capabilities/contexts/global_representer_rendering_spec.rb +++ b/spec/lib/api/v3/capabilities/contexts/global_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Capabilities::Contexts::GlobalRepresenter, 'rendering' do +RSpec.describe API::V3::Capabilities::Contexts::GlobalRepresenter, 'rendering' do include API::V3::Utilities::PathHelper subject { representer.to_json } diff --git a/spec/lib/api/v3/categories/category_collection_representer_spec.rb b/spec/lib/api/v3/categories/category_collection_representer_spec.rb index ad368211be8..bd4c34ef5fb 100644 --- a/spec/lib/api/v3/categories/category_collection_representer_spec.rb +++ b/spec/lib/api/v3/categories/category_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Categories::CategoryCollectionRepresenter do +RSpec.describe API::V3::Categories::CategoryCollectionRepresenter do let(:categories) { build_list(:category, 3) } let(:representer) do described_class.new(categories, diff --git a/spec/lib/api/v3/categories/category_representer_spec.rb b/spec/lib/api/v3/categories/category_representer_spec.rb index da304f9ac47..5f1cdad1860 100644 --- a/spec/lib/api/v3/categories/category_representer_spec.rb +++ b/spec/lib/api/v3/categories/category_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Categories::CategoryRepresenter do +RSpec.describe API::V3::Categories::CategoryRepresenter do let(:category) { build_stubbed(:category) } let(:user) { build(:user) } let(:representer) { described_class.new(category, current_user: double('current_user')) } diff --git a/spec/lib/api/v3/configuration/configuration_representer_spec.rb b/spec/lib/api/v3/configuration/configuration_representer_spec.rb index 0f39f36edea..0c5c85291c5 100644 --- a/spec/lib/api/v3/configuration/configuration_representer_spec.rb +++ b/spec/lib/api/v3/configuration/configuration_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Configuration::ConfigurationRepresenter do +RSpec.describe API::V3::Configuration::ConfigurationRepresenter do include API::V3::Utilities::PathHelper let(:represented) { Setting } diff --git a/spec/lib/api/v3/custom_actions/custom_action_execute_representer_parsing_spec.rb b/spec/lib/api/v3/custom_actions/custom_action_execute_representer_parsing_spec.rb index c5e8b6e80e6..f19e8a04959 100644 --- a/spec/lib/api/v3/custom_actions/custom_action_execute_representer_parsing_spec.rb +++ b/spec/lib/api/v3/custom_actions/custom_action_execute_representer_parsing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::CustomActions::CustomActionExecuteRepresenter, 'parsing' do +RSpec.describe API::V3::CustomActions::CustomActionExecuteRepresenter, 'parsing' do include API::V3::Utilities::PathHelper let(:struct) { OpenStruct.new } diff --git a/spec/lib/api/v3/custom_actions/custom_action_representer_generation_spec.rb b/spec/lib/api/v3/custom_actions/custom_action_representer_generation_spec.rb index 686ae749b1f..34eed2ee4ae 100644 --- a/spec/lib/api/v3/custom_actions/custom_action_representer_generation_spec.rb +++ b/spec/lib/api/v3/custom_actions/custom_action_representer_generation_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::CustomActions::CustomActionRepresenter do +RSpec.describe API::V3::CustomActions::CustomActionRepresenter do include API::V3::Utilities::PathHelper let(:custom_action) { build_stubbed(:custom_action) } diff --git a/spec/lib/api/v3/custom_options/custom_option_representer_spec.rb b/spec/lib/api/v3/custom_options/custom_option_representer_spec.rb index e0016a92190..d122dbd3bf4 100644 --- a/spec/lib/api/v3/custom_options/custom_option_representer_spec.rb +++ b/spec/lib/api/v3/custom_options/custom_option_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::CustomOptions::CustomOptionRepresenter do +RSpec.describe API::V3::CustomOptions::CustomOptionRepresenter do include API::V3::Utilities::PathHelper let(:custom_option) { build_stubbed(:custom_option, custom_field:) } diff --git a/spec/lib/api/v3/days/day_collection_representer_spec.rb b/spec/lib/api/v3/days/day_collection_representer_spec.rb index 679d61115c2..d52778d6b7d 100644 --- a/spec/lib/api/v3/days/day_collection_representer_spec.rb +++ b/spec/lib/api/v3/days/day_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Days::DayCollectionRepresenter do +RSpec.describe API::V3::Days::DayCollectionRepresenter do let(:days) do [ build(:day, date: Date.new(2022, 12, 27)), diff --git a/spec/lib/api/v3/days/day_representer_spec.rb b/spec/lib/api/v3/days/day_representer_spec.rb index e4bd71a2f59..d08d84f9b0e 100644 --- a/spec/lib/api/v3/days/day_representer_spec.rb +++ b/spec/lib/api/v3/days/day_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Days::DayRepresenter do +RSpec.describe API::V3::Days::DayRepresenter do let(:working) { true } let(:date) { Date.new(2022, 12, 27) } let(:day) do diff --git a/spec/lib/api/v3/days/non_working_day_collection_representer_spec.rb b/spec/lib/api/v3/days/non_working_day_collection_representer_spec.rb index 03ccbfd334f..6cc7c11073c 100644 --- a/spec/lib/api/v3/days/non_working_day_collection_representer_spec.rb +++ b/spec/lib/api/v3/days/non_working_day_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Days::NonWorkingDayCollectionRepresenter do +RSpec.describe API::V3::Days::NonWorkingDayCollectionRepresenter do let(:non_working_days) do [ build(:non_working_day, date: Date.new(2022, 12, 27)), diff --git a/spec/lib/api/v3/days/non_working_day_representer_spec.rb b/spec/lib/api/v3/days/non_working_day_representer_spec.rb index d85180cde8a..2df24edaf37 100644 --- a/spec/lib/api/v3/days/non_working_day_representer_spec.rb +++ b/spec/lib/api/v3/days/non_working_day_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Days::NonWorkingDayRepresenter do +RSpec.describe API::V3::Days::NonWorkingDayRepresenter do let(:non_working_day) { build_stubbed(:non_working_day, name: "Christmas day", date: Date.tomorrow) } let(:representer) { described_class.new(non_working_day, current_user: instance_double(User, name: 'current_user')) } diff --git a/spec/lib/api/v3/days/week_day_collection_representer_spec.rb b/spec/lib/api/v3/days/week_day_collection_representer_spec.rb index 3d01b61ff3e..d75afe24878 100644 --- a/spec/lib/api/v3/days/week_day_collection_representer_spec.rb +++ b/spec/lib/api/v3/days/week_day_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Days::WeekDayCollectionRepresenter do +RSpec.describe API::V3::Days::WeekDayCollectionRepresenter do let(:week_days) { WeekDay.all } let(:representer) do described_class.new(week_days, diff --git a/spec/lib/api/v3/days/week_day_representer_spec.rb b/spec/lib/api/v3/days/week_day_representer_spec.rb index 31b9e04bc31..e5a5917a648 100644 --- a/spec/lib/api/v3/days/week_day_representer_spec.rb +++ b/spec/lib/api/v3/days/week_day_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Days::WeekDayRepresenter do +RSpec.describe API::V3::Days::WeekDayRepresenter do let(:week_day) { build(:week_day, day: 1) } let(:representer) { described_class.new(week_day, current_user: instance_double(User, name: 'current_user')) } diff --git a/spec/lib/api/v3/formatter/txt_charset_spec.rb b/spec/lib/api/v3/formatter/txt_charset_spec.rb index a8b39d647a4..be41cc71238 100644 --- a/spec/lib/api/v3/formatter/txt_charset_spec.rb +++ b/spec/lib/api/v3/formatter/txt_charset_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Formatter::TxtCharset do +RSpec.describe API::V3::Formatter::TxtCharset do let(:umlaut_object_ascii) { 'ümläutß'.force_encoding('ASCII-8BIT') } let(:umlaut_object_utf8) { umlaut_object_ascii.force_encoding('utf-8') } let(:env) { {} } diff --git a/spec/lib/api/v3/groups/group_collection_representer_spec.rb b/spec/lib/api/v3/groups/group_collection_representer_spec.rb index 22b1465737f..c2951c01fed 100644 --- a/spec/lib/api/v3/groups/group_collection_representer_spec.rb +++ b/spec/lib/api/v3/groups/group_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Groups::GroupCollectionRepresenter do +RSpec.describe API::V3::Groups::GroupCollectionRepresenter do let(:self_base_link) { '/api/v3/groups' } let(:groups) do build_stubbed_list(:group, 3).tap do |groups| diff --git a/spec/lib/api/v3/groups/group_representer_spec.rb b/spec/lib/api/v3/groups/group_representer_spec.rb index 233d9aff0f8..26aab4e4dd6 100644 --- a/spec/lib/api/v3/groups/group_representer_spec.rb +++ b/spec/lib/api/v3/groups/group_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Groups::GroupRepresenter, 'rendering' do +RSpec.describe API::V3::Groups::GroupRepresenter, 'rendering' do include API::V3::Utilities::PathHelper subject(:generated) { representer.to_json } diff --git a/spec/lib/api/v3/groups/group_sql_representer_rendering_spec.rb b/spec/lib/api/v3/groups/group_sql_representer_rendering_spec.rb index 3fc51f80452..36667bc52db 100644 --- a/spec/lib/api/v3/groups/group_sql_representer_rendering_spec.rb +++ b/spec/lib/api/v3/groups/group_sql_representer_rendering_spec.rb @@ -26,7 +26,7 @@ require 'spec_helper' -describe API::V3::Groups::GroupSqlRepresenter, 'rendering' do +RSpec.describe API::V3::Groups::GroupSqlRepresenter, 'rendering' do include API::V3::Utilities::PathHelper subject(:json) do diff --git a/spec/lib/api/v3/help_texts/help_text_collection_representer_spec.rb b/spec/lib/api/v3/help_texts/help_text_collection_representer_spec.rb index 4d5fe1c9a71..6dc03b09f0a 100644 --- a/spec/lib/api/v3/help_texts/help_text_collection_representer_spec.rb +++ b/spec/lib/api/v3/help_texts/help_text_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::HelpTexts::HelpTextCollectionRepresenter do +RSpec.describe API::V3::HelpTexts::HelpTextCollectionRepresenter do let!(:help_texts) do [ build_stubbed(:work_package_help_text, attribute_name: 'id'), diff --git a/spec/lib/api/v3/help_texts/help_text_representer_spec.rb b/spec/lib/api/v3/help_texts/help_text_representer_spec.rb index 077e28c00cd..204e3c4a202 100644 --- a/spec/lib/api/v3/help_texts/help_text_representer_spec.rb +++ b/spec/lib/api/v3/help_texts/help_text_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::HelpTexts::HelpTextRepresenter do +RSpec.describe API::V3::HelpTexts::HelpTextRepresenter do include API::V3::Utilities::PathHelper let(:user) { build_stubbed(:admin) } diff --git a/spec/lib/api/v3/memberships/membership_collection_representer_spec.rb b/spec/lib/api/v3/memberships/membership_collection_representer_spec.rb index a1c420bea08..3bd1997cb38 100644 --- a/spec/lib/api/v3/memberships/membership_collection_representer_spec.rb +++ b/spec/lib/api/v3/memberships/membership_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Memberships::MembershipCollectionRepresenter do +RSpec.describe API::V3::Memberships::MembershipCollectionRepresenter do let(:self_base_link) { '/api/v3/members' } let(:members) do build_stubbed_list(:member, 3).tap do |members| diff --git a/spec/lib/api/v3/memberships/membership_payload_representer_spec.rb b/spec/lib/api/v3/memberships/membership_payload_representer_spec.rb index 2711853c97b..37400450211 100644 --- a/spec/lib/api/v3/memberships/membership_payload_representer_spec.rb +++ b/spec/lib/api/v3/memberships/membership_payload_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Memberships::MembershipPayloadRepresenter do +RSpec.describe API::V3::Memberships::MembershipPayloadRepresenter do let(:membership) { build_stubbed(:member) } current_user { build_stubbed(:user) } diff --git a/spec/lib/api/v3/memberships/membership_representer_rendering_spec.rb b/spec/lib/api/v3/memberships/membership_representer_rendering_spec.rb index d5063e0fbd2..195fb399a25 100644 --- a/spec/lib/api/v3/memberships/membership_representer_rendering_spec.rb +++ b/spec/lib/api/v3/memberships/membership_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Memberships::MembershipRepresenter, 'rendering' do +RSpec.describe API::V3::Memberships::MembershipRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:member) do diff --git a/spec/lib/api/v3/memberships/schemas/membership_schema_representer_spec.rb b/spec/lib/api/v3/memberships/schemas/membership_schema_representer_spec.rb index 8e960312d56..b187376f219 100644 --- a/spec/lib/api/v3/memberships/schemas/membership_schema_representer_spec.rb +++ b/spec/lib/api/v3/memberships/schemas/membership_schema_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Memberships::Schemas::MembershipSchemaRepresenter do +RSpec.describe API::V3::Memberships::Schemas::MembershipSchemaRepresenter do include API::V3::Utilities::PathHelper let(:current_user) { build_stubbed(:user) } diff --git a/spec/lib/api/v3/news/news_representer_rendering_spec.rb b/spec/lib/api/v3/news/news_representer_rendering_spec.rb index 2f1b089672b..3a0e5570fe7 100644 --- a/spec/lib/api/v3/news/news_representer_rendering_spec.rb +++ b/spec/lib/api/v3/news/news_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::News::NewsRepresenter, 'rendering' do +RSpec.describe API::V3::News::NewsRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:news) do diff --git a/spec/lib/api/v3/notifications/notification_collection_representer_spec.rb b/spec/lib/api/v3/notifications/notification_collection_representer_spec.rb index 3f081525d1d..b825781cd29 100644 --- a/spec/lib/api/v3/notifications/notification_collection_representer_spec.rb +++ b/spec/lib/api/v3/notifications/notification_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Notifications::NotificationCollectionRepresenter do +RSpec.describe API::V3::Notifications::NotificationCollectionRepresenter do let(:self_base_link) { '/api/v3/notifications' } let(:user) { build_stubbed(:user) } let(:notification_list) { build_stubbed_list(:notification, 3) } diff --git a/spec/lib/api/v3/notifications/notification_representer_rendering_spec.rb b/spec/lib/api/v3/notifications/notification_representer_rendering_spec.rb index 321888de1d7..49017c9fd0b 100644 --- a/spec/lib/api/v3/notifications/notification_representer_rendering_spec.rb +++ b/spec/lib/api/v3/notifications/notification_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Notifications::NotificationRepresenter, 'rendering' do +RSpec.describe API::V3::Notifications::NotificationRepresenter, 'rendering' do include API::V3::Utilities::PathHelper subject(:generated) { representer.to_json } diff --git a/spec/lib/api/v3/notifications/property_factory_spec.rb b/spec/lib/api/v3/notifications/property_factory_spec.rb index d3b00461794..e8fe05ab581 100644 --- a/spec/lib/api/v3/notifications/property_factory_spec.rb +++ b/spec/lib/api/v3/notifications/property_factory_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Notifications::PropertyFactory do +RSpec.describe API::V3::Notifications::PropertyFactory do let(:traits) { [] } let(:resource) { build_stubbed(:work_package, *traits) } diff --git a/spec/lib/api/v3/placeholder_users/placeholder_user_collection_representer_spec.rb b/spec/lib/api/v3/placeholder_users/placeholder_user_collection_representer_spec.rb index 2e2abc2bd4a..c604dedd8aa 100644 --- a/spec/lib/api/v3/placeholder_users/placeholder_user_collection_representer_spec.rb +++ b/spec/lib/api/v3/placeholder_users/placeholder_user_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::PlaceholderUsers::PlaceholderUserCollectionRepresenter do +RSpec.describe API::V3::PlaceholderUsers::PlaceholderUserCollectionRepresenter do let(:self_base_link) { '/api/v3/placeholder_users' } let(:collection_inner_type) { 'PlaceholderUser' } let(:total) { 3 } diff --git a/spec/lib/api/v3/placeholder_users/placeholder_user_representer_rendering_spec.rb b/spec/lib/api/v3/placeholder_users/placeholder_user_representer_rendering_spec.rb index ba8a772d568..0f57ac88160 100644 --- a/spec/lib/api/v3/placeholder_users/placeholder_user_representer_rendering_spec.rb +++ b/spec/lib/api/v3/placeholder_users/placeholder_user_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::PlaceholderUsers::PlaceholderUserRepresenter, 'rendering' do +RSpec.describe API::V3::PlaceholderUsers::PlaceholderUserRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:placeholder_user) { build_stubbed(:placeholder_user) } diff --git a/spec/lib/api/v3/placeholder_users/placeholder_user_sql_representer_rendering_spec.rb b/spec/lib/api/v3/placeholder_users/placeholder_user_sql_representer_rendering_spec.rb index 51dcdc970df..f09785c0ae9 100644 --- a/spec/lib/api/v3/placeholder_users/placeholder_user_sql_representer_rendering_spec.rb +++ b/spec/lib/api/v3/placeholder_users/placeholder_user_sql_representer_rendering_spec.rb @@ -26,7 +26,7 @@ require 'spec_helper' -describe API::V3::PlaceholderUsers::PlaceholderUserSqlRepresenter, 'rendering' do +RSpec.describe API::V3::PlaceholderUsers::PlaceholderUserSqlRepresenter, 'rendering' do include API::V3::Utilities::PathHelper subject(:json) do diff --git a/spec/lib/api/v3/posts/post_representer_rendering_spec.rb b/spec/lib/api/v3/posts/post_representer_rendering_spec.rb index 253fa2e1827..dd2b327ba8c 100644 --- a/spec/lib/api/v3/posts/post_representer_rendering_spec.rb +++ b/spec/lib/api/v3/posts/post_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Posts::PostRepresenter, 'rendering' do +RSpec.describe API::V3::Posts::PostRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:message) do diff --git a/spec/lib/api/v3/principals/principal_representer_factory_spec.rb b/spec/lib/api/v3/principals/principal_representer_factory_spec.rb index 91514f8e407..e08134c0b54 100644 --- a/spec/lib/api/v3/principals/principal_representer_factory_spec.rb +++ b/spec/lib/api/v3/principals/principal_representer_factory_spec.rb @@ -32,7 +32,7 @@ class TestRepresenter < API::Decorators::Single include ::API::Decorators::LinkedResource end -describe API::V3::Principals::PrincipalRepresenterFactory do +RSpec.describe API::V3::Principals::PrincipalRepresenterFactory do let(:current_user) { build_stubbed(:user) } let(:represented) do diff --git a/spec/lib/api/v3/principals/principal_sql_representer_rendering_spec.rb b/spec/lib/api/v3/principals/principal_sql_representer_rendering_spec.rb index db374ed587e..8226277431b 100644 --- a/spec/lib/api/v3/principals/principal_sql_representer_rendering_spec.rb +++ b/spec/lib/api/v3/principals/principal_sql_representer_rendering_spec.rb @@ -26,7 +26,7 @@ require 'spec_helper' -describe API::V3::Principals::PrincipalSqlRepresenter, 'rendering' do +RSpec.describe API::V3::Principals::PrincipalSqlRepresenter, 'rendering' do include API::V3::Utilities::PathHelper subject(:json) do diff --git a/spec/lib/api/v3/principals/principal_type_spec.rb b/spec/lib/api/v3/principals/principal_type_spec.rb index a1275f2b124..b9bb975e754 100644 --- a/spec/lib/api/v3/principals/principal_type_spec.rb +++ b/spec/lib/api/v3/principals/principal_type_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Principals::PrincipalType do +RSpec.describe API::V3::Principals::PrincipalType do let(:principal) { nil } subject { described_class.for(instance) } diff --git a/spec/lib/api/v3/priorities/priority_collection_representer_spec.rb b/spec/lib/api/v3/priorities/priority_collection_representer_spec.rb index 40bf0962b24..0e026e389be 100644 --- a/spec/lib/api/v3/priorities/priority_collection_representer_spec.rb +++ b/spec/lib/api/v3/priorities/priority_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Priorities::PriorityCollectionRepresenter do +RSpec.describe API::V3::Priorities::PriorityCollectionRepresenter do let(:priorities) { build_list(:priority, 3) } let(:representer) do described_class.new(priorities, self_link: '/api/v3/priorities', current_user: double('current_user')) diff --git a/spec/lib/api/v3/priorities/priority_representer_spec.rb b/spec/lib/api/v3/priorities/priority_representer_spec.rb index e87d36b8ccf..81485a0ada1 100644 --- a/spec/lib/api/v3/priorities/priority_representer_spec.rb +++ b/spec/lib/api/v3/priorities/priority_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Priorities::PriorityRepresenter do +RSpec.describe API::V3::Priorities::PriorityRepresenter do let(:priority) { build_stubbed(:priority) } let(:representer) { described_class.new(priority, current_user: double('current_user')) } diff --git a/spec/lib/api/v3/projects/copy/project_copy_payload_representer_spec.rb b/spec/lib/api/v3/projects/copy/project_copy_payload_representer_spec.rb index 8d205d399ac..7c2284e744e 100644 --- a/spec/lib/api/v3/projects/copy/project_copy_payload_representer_spec.rb +++ b/spec/lib/api/v3/projects/copy/project_copy_payload_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Projects::Copy::ProjectCopyPayloadRepresenter do +RSpec.describe API::V3::Projects::Copy::ProjectCopyPayloadRepresenter do shared_let(:current_user, reload: false) { build_stubbed(:user) } shared_let(:project, reload: false) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/projects/copy/project_copy_schema_representer_spec.rb b/spec/lib/api/v3/projects/copy/project_copy_schema_representer_spec.rb index 543e79b0e5a..2c8e5f28bcb 100644 --- a/spec/lib/api/v3/projects/copy/project_copy_schema_representer_spec.rb +++ b/spec/lib/api/v3/projects/copy/project_copy_schema_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Projects::Copy::ProjectCopySchemaRepresenter do +RSpec.describe API::V3::Projects::Copy::ProjectCopySchemaRepresenter do include API::V3::Utilities::PathHelper shared_let(:current_user, reload: false) { build_stubbed(:user) } diff --git a/spec/lib/api/v3/projects/project_collection_representer_spec.rb b/spec/lib/api/v3/projects/project_collection_representer_spec.rb index c42d08c8443..37372ab8c73 100644 --- a/spec/lib/api/v3/projects/project_collection_representer_spec.rb +++ b/spec/lib/api/v3/projects/project_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Projects::ProjectCollectionRepresenter do +RSpec.describe API::V3::Projects::ProjectCollectionRepresenter do shared_let(:projects) { create_list(:project, 3) } let(:self_base_link) { '/api/v3/projects' } diff --git a/spec/lib/api/v3/projects/project_payload_representer_parsing_spec.rb b/spec/lib/api/v3/projects/project_payload_representer_parsing_spec.rb index f8b55e5eecf..f0b331504bb 100644 --- a/spec/lib/api/v3/projects/project_payload_representer_parsing_spec.rb +++ b/spec/lib/api/v3/projects/project_payload_representer_parsing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Projects::ProjectPayloadRepresenter, 'parsing' do +RSpec.describe API::V3::Projects::ProjectPayloadRepresenter, 'parsing' do include API::V3::Utilities::PathHelper let(:object) do diff --git a/spec/lib/api/v3/projects/project_representer_rendering_spec.rb b/spec/lib/api/v3/projects/project_representer_rendering_spec.rb index 8c8dc5f030f..4640c1e4344 100644 --- a/spec/lib/api/v3/projects/project_representer_rendering_spec.rb +++ b/spec/lib/api/v3/projects/project_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Projects::ProjectRepresenter, 'rendering' do +RSpec.describe API::V3::Projects::ProjectRepresenter, 'rendering' do include API::V3::Utilities::PathHelper subject(:generated) { representer.to_json } diff --git a/spec/lib/api/v3/projects/project_sql_collection_representer_rendering_spec.rb b/spec/lib/api/v3/projects/project_sql_collection_representer_rendering_spec.rb index 146ec205b13..084d454e1ce 100644 --- a/spec/lib/api/v3/projects/project_sql_collection_representer_rendering_spec.rb +++ b/spec/lib/api/v3/projects/project_sql_collection_representer_rendering_spec.rb @@ -26,7 +26,7 @@ require 'spec_helper' -describe API::V3::Projects::ProjectSqlCollectionRepresenter, 'rendering' do +RSpec.describe API::V3::Projects::ProjectSqlCollectionRepresenter, 'rendering' do include API::V3::Utilities::PathHelper subject(:json) do diff --git a/spec/lib/api/v3/projects/project_sql_representer_rendering_spec.rb b/spec/lib/api/v3/projects/project_sql_representer_rendering_spec.rb index bb07c3e10c6..dc0236ed65d 100644 --- a/spec/lib/api/v3/projects/project_sql_representer_rendering_spec.rb +++ b/spec/lib/api/v3/projects/project_sql_representer_rendering_spec.rb @@ -26,7 +26,7 @@ require 'spec_helper' -describe API::V3::Projects::ProjectSqlRepresenter, 'rendering' do +RSpec.describe API::V3::Projects::ProjectSqlRepresenter, 'rendering' do include API::V3::Utilities::PathHelper subject(:json) do diff --git a/spec/lib/api/v3/projects/schemas/project_schema_representer_spec.rb b/spec/lib/api/v3/projects/schemas/project_schema_representer_spec.rb index 11ad66ca1f4..6f3eca2f989 100644 --- a/spec/lib/api/v3/projects/schemas/project_schema_representer_spec.rb +++ b/spec/lib/api/v3/projects/schemas/project_schema_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Projects::Schemas::ProjectSchemaRepresenter do +RSpec.describe API::V3::Projects::Schemas::ProjectSchemaRepresenter do include API::V3::Utilities::PathHelper let(:current_user) do diff --git a/spec/lib/api/v3/projects/statuses/status_representer_rendering_spec.rb b/spec/lib/api/v3/projects/statuses/status_representer_rendering_spec.rb index 54660366e06..ebcd6018799 100644 --- a/spec/lib/api/v3/projects/statuses/status_representer_rendering_spec.rb +++ b/spec/lib/api/v3/projects/statuses/status_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Projects::Statuses::StatusRepresenter, 'rendering' do +RSpec.describe API::V3::Projects::Statuses::StatusRepresenter, 'rendering' do include API::V3::Utilities::PathHelper subject { representer.to_json } diff --git a/spec/lib/api/v3/queries/columns/query_property_column_representer_spec.rb b/spec/lib/api/v3/queries/columns/query_property_column_representer_spec.rb index 3e37d32685e..882f29b7307 100644 --- a/spec/lib/api/v3/queries/columns/query_property_column_representer_spec.rb +++ b/spec/lib/api/v3/queries/columns/query_property_column_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Columns::QueryPropertyColumnRepresenter do +RSpec.describe API::V3::Queries::Columns::QueryPropertyColumnRepresenter do include API::V3::Utilities::PathHelper let(:column) { Query.available_columns.detect { |column| column.name == :status } } diff --git a/spec/lib/api/v3/queries/columns/query_relation_of_type_column_representer_spec.rb b/spec/lib/api/v3/queries/columns/query_relation_of_type_column_representer_spec.rb index 0a89720ced6..7ef7699dcfd 100644 --- a/spec/lib/api/v3/queries/columns/query_relation_of_type_column_representer_spec.rb +++ b/spec/lib/api/v3/queries/columns/query_relation_of_type_column_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Columns::QueryRelationOfTypeColumnRepresenter do +RSpec.describe API::V3::Queries::Columns::QueryRelationOfTypeColumnRepresenter do include API::V3::Utilities::PathHelper let(:type) { { name: :label_relates_to, sym_name: :label_relates_to, order: 1, sym: :relation1 } } diff --git a/spec/lib/api/v3/queries/columns/query_relation_to_type_column_representer_spec.rb b/spec/lib/api/v3/queries/columns/query_relation_to_type_column_representer_spec.rb index 71ee05fca7d..d5e8fd97d3e 100644 --- a/spec/lib/api/v3/queries/columns/query_relation_to_type_column_representer_spec.rb +++ b/spec/lib/api/v3/queries/columns/query_relation_to_type_column_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Columns::QueryRelationToTypeColumnRepresenter do +RSpec.describe API::V3::Queries::Columns::QueryRelationToTypeColumnRepresenter do include API::V3::Utilities::PathHelper let(:type) { build_stubbed(:type) } diff --git a/spec/lib/api/v3/queries/filters/query_filter_instance_representer_spec.rb b/spec/lib/api/v3/queries/filters/query_filter_instance_representer_spec.rb index 865e91a01f2..73da8756ab0 100644 --- a/spec/lib/api/v3/queries/filters/query_filter_instance_representer_spec.rb +++ b/spec/lib/api/v3/queries/filters/query_filter_instance_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Filters::QueryFilterInstanceRepresenter do +RSpec.describe API::V3::Queries::Filters::QueryFilterInstanceRepresenter do include API::V3::Utilities::PathHelper let(:operator) { '=' } diff --git a/spec/lib/api/v3/queries/filters/query_filter_representer_spec.rb b/spec/lib/api/v3/queries/filters/query_filter_representer_spec.rb index 5766fea97d0..232a3951e11 100644 --- a/spec/lib/api/v3/queries/filters/query_filter_representer_spec.rb +++ b/spec/lib/api/v3/queries/filters/query_filter_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Filters::QueryFilterRepresenter do +RSpec.describe API::V3::Queries::Filters::QueryFilterRepresenter do include API::V3::Utilities::PathHelper let(:filter) { Queries::WorkPackages::Filter::SubjectFilter.create! } diff --git a/spec/lib/api/v3/queries/group_bys/query_group_by_representer_spec.rb b/spec/lib/api/v3/queries/group_bys/query_group_by_representer_spec.rb index 8bbb59e49cc..7df68b5b361 100644 --- a/spec/lib/api/v3/queries/group_bys/query_group_by_representer_spec.rb +++ b/spec/lib/api/v3/queries/group_bys/query_group_by_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::GroupBys::QueryGroupByRepresenter do +RSpec.describe API::V3::Queries::GroupBys::QueryGroupByRepresenter do include API::V3::Utilities::PathHelper let(:column) { Query.available_columns.detect { |column| column.name == :status } } diff --git a/spec/lib/api/v3/queries/operators/query_operator_representer_spec.rb b/spec/lib/api/v3/queries/operators/query_operator_representer_spec.rb index 081f2bc99d3..5f1a9438772 100644 --- a/spec/lib/api/v3/queries/operators/query_operator_representer_spec.rb +++ b/spec/lib/api/v3/queries/operators/query_operator_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Operators::QueryOperatorRepresenter do +RSpec.describe API::V3::Queries::Operators::QueryOperatorRepresenter do include API::V3::Utilities::PathHelper let(:operator) { Queries::Operators::NotContains } diff --git a/spec/lib/api/v3/queries/queries_params_representer_spec.rb b/spec/lib/api/v3/queries/queries_params_representer_spec.rb index 0b9146d40c7..d4cd4cc8a15 100644 --- a/spec/lib/api/v3/queries/queries_params_representer_spec.rb +++ b/spec/lib/api/v3/queries/queries_params_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::QueryParamsRepresenter do +RSpec.describe API::V3::Queries::QueryParamsRepresenter do let(:query) { build_stubbed(:query, **params) } let(:instance) { described_class.new(query) } diff --git a/spec/lib/api/v3/queries/query_representer_parsing_spec.rb b/spec/lib/api/v3/queries/query_representer_parsing_spec.rb index 0ee25dc5c9e..f8094fdf2c4 100644 --- a/spec/lib/api/v3/queries/query_representer_parsing_spec.rb +++ b/spec/lib/api/v3/queries/query_representer_parsing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::QueryRepresenter, 'parsing' do +RSpec.describe API::V3::Queries::QueryRepresenter, 'parsing' do include API::V3::Utilities::PathHelper let(:query) { API::ParserStruct.new } diff --git a/spec/lib/api/v3/queries/query_representer_rendering_spec.rb b/spec/lib/api/v3/queries/query_representer_rendering_spec.rb index 79fa02df747..77121746ed0 100644 --- a/spec/lib/api/v3/queries/query_representer_rendering_spec.rb +++ b/spec/lib/api/v3/queries/query_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::QueryRepresenter do +RSpec.describe API::V3::Queries::QueryRepresenter do include API::V3::Utilities::PathHelper let(:query) { build_stubbed(:query, project:, views:) } diff --git a/spec/lib/api/v3/queries/schemas/all_principals_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/all_principals_filter_dependency_representer_spec.rb index 5c94cc2a847..dcded33f298 100644 --- a/spec/lib/api/v3/queries/schemas/all_principals_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/all_principals_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::AllPrincipalsFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::AllPrincipalsFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/schemas/blocks_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/blocks_filter_dependency_representer_spec.rb index bade3cf2f84..e2537425df5 100644 --- a/spec/lib/api/v3/queries/schemas/blocks_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/blocks_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' 5 -describe API::V3::Queries::Schemas::BlocksFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::BlocksFilterDependencyRepresenter do it_behaves_like 'relation filter dependency' do let(:filter) { Queries::WorkPackages::Filter::BlocksFilter.create!(context: query) } end diff --git a/spec/lib/api/v3/queries/schemas/boolean_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/boolean_filter_dependency_representer_spec.rb index 6ccf0f6afd9..2e7fccf2374 100644 --- a/spec/lib/api/v3/queries/schemas/boolean_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/boolean_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::BooleanFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::BooleanFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/schemas/category_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/category_filter_dependency_representer_spec.rb index eec287215d7..ed3ea09870b 100644 --- a/spec/lib/api/v3/queries/schemas/category_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/category_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::CategoryFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::CategoryFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/schemas/custom_option_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/custom_option_filter_dependency_representer_spec.rb index d55bb9fb5ac..8095271f960 100644 --- a/spec/lib/api/v3/queries/schemas/custom_option_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/custom_option_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::CustomOptionFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::CustomOptionFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/schemas/date_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/date_filter_dependency_representer_spec.rb index 511f21341c0..90b58a42070 100644 --- a/spec/lib/api/v3/queries/schemas/date_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/date_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::DateFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::DateFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/schemas/date_time_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/date_time_filter_dependency_representer_spec.rb index 11ca0b14f57..398a6d621bf 100644 --- a/spec/lib/api/v3/queries/schemas/date_time_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/date_time_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::DateTimeFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::DateTimeFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/schemas/duplicated_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/duplicated_filter_dependency_representer_spec.rb index 954c73f7042..9cd3bb1a741 100644 --- a/spec/lib/api/v3/queries/schemas/duplicated_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/duplicated_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' 5 -describe API::V3::Queries::Schemas::DuplicatedFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::DuplicatedFilterDependencyRepresenter do it_behaves_like 'relation filter dependency' do let(:filter) { Queries::WorkPackages::Filter::DuplicatedFilter.create!(context: query) } end diff --git a/spec/lib/api/v3/queries/schemas/duplicates_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/duplicates_filter_dependency_representer_spec.rb index 22dd65485d0..70f37d901f7 100644 --- a/spec/lib/api/v3/queries/schemas/duplicates_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/duplicates_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' 5 -describe API::V3::Queries::Schemas::DuplicatesFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::DuplicatesFilterDependencyRepresenter do it_behaves_like 'relation filter dependency' do let(:filter) { Queries::WorkPackages::Filter::DuplicatesFilter.create!(context: query) } end diff --git a/spec/lib/api/v3/queries/schemas/filter_dependency_representer_factory_spec.rb b/spec/lib/api/v3/queries/schemas/filter_dependency_representer_factory_spec.rb index 7f9b74d57fc..997eec423ac 100644 --- a/spec/lib/api/v3/queries/schemas/filter_dependency_representer_factory_spec.rb +++ b/spec/lib/api/v3/queries/schemas/filter_dependency_representer_factory_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::FilterDependencyRepresenterFactory do +RSpec.describe API::V3::Queries::Schemas::FilterDependencyRepresenterFactory do include API::V3::Utilities::PathHelper let(:operator) { Queries::Operators::Equals } diff --git a/spec/lib/api/v3/queries/schemas/float_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/float_filter_dependency_representer_spec.rb index 334ab704a23..7c2d75526ee 100644 --- a/spec/lib/api/v3/queries/schemas/float_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/float_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::FloatFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::FloatFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/schemas/follows_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/follows_filter_dependency_representer_spec.rb index 691a2c43285..d7deeedc38a 100644 --- a/spec/lib/api/v3/queries/schemas/follows_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/follows_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::FollowsFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::FollowsFilterDependencyRepresenter do it_behaves_like 'relation filter dependency' do let(:filter) { Queries::WorkPackages::Filter::FollowsFilter.create!(context: query) } end diff --git a/spec/lib/api/v3/queries/schemas/group_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/group_filter_dependency_representer_spec.rb index 2ef90b45d27..897d0d5df52 100644 --- a/spec/lib/api/v3/queries/schemas/group_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/group_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::GroupFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::GroupFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/schemas/id_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/id_filter_dependency_representer_spec.rb index 291d2d737e9..aba67db4ab5 100644 --- a/spec/lib/api/v3/queries/schemas/id_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/id_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::IdFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::IdFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/schemas/includes_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/includes_filter_dependency_representer_spec.rb index f718b33e843..06788afbc3f 100644 --- a/spec/lib/api/v3/queries/schemas/includes_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/includes_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' 5 -describe API::V3::Queries::Schemas::IncludesFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::IncludesFilterDependencyRepresenter do it_behaves_like 'relation filter dependency' do let(:filter) { Queries::WorkPackages::Filter::IncludesFilter.create!(context: query) } end diff --git a/spec/lib/api/v3/queries/schemas/integer_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/integer_filter_dependency_representer_spec.rb index cec70756207..c89ded277a6 100644 --- a/spec/lib/api/v3/queries/schemas/integer_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/integer_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::IntegerFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::IntegerFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/schemas/parent_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/parent_filter_dependency_representer_spec.rb index f8973d8ed1f..ea1773e5e44 100644 --- a/spec/lib/api/v3/queries/schemas/parent_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/parent_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::ParentFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::ParentFilterDependencyRepresenter do it_behaves_like 'relation filter dependency' do let(:filter) { Queries::WorkPackages::Filter::ParentFilter.create!(context: query) } end diff --git a/spec/lib/api/v3/queries/schemas/partof_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/partof_filter_dependency_representer_spec.rb index b11a87c9ac8..330a51487e9 100644 --- a/spec/lib/api/v3/queries/schemas/partof_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/partof_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' 5 -describe API::V3::Queries::Schemas::PartofFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::PartofFilterDependencyRepresenter do it_behaves_like 'relation filter dependency' do let(:filter) { Queries::WorkPackages::Filter::PartofFilter.create!(context: query) } end diff --git a/spec/lib/api/v3/queries/schemas/precedes_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/precedes_filter_dependency_representer_spec.rb index 00bb51f0b3f..e03c91864de 100644 --- a/spec/lib/api/v3/queries/schemas/precedes_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/precedes_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' 5 -describe API::V3::Queries::Schemas::PrecedesFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::PrecedesFilterDependencyRepresenter do it_behaves_like 'relation filter dependency' do let(:filter) { Queries::WorkPackages::Filter::PrecedesFilter.create!(context: query) } end diff --git a/spec/lib/api/v3/queries/schemas/priority_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/priority_filter_dependency_representer_spec.rb index 6c35303e457..0d823a346c8 100644 --- a/spec/lib/api/v3/queries/schemas/priority_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/priority_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::PriorityFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::PriorityFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/schemas/project_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/project_filter_dependency_representer_spec.rb index 1a3c93a237f..b75e36ceab5 100644 --- a/spec/lib/api/v3/queries/schemas/project_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/project_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::ProjectFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::ProjectFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:filter) { Queries::WorkPackages::Filter::ProjectFilter.create! } diff --git a/spec/lib/api/v3/queries/schemas/query_filter_instance_schema_representer_spec.rb b/spec/lib/api/v3/queries/schemas/query_filter_instance_schema_representer_spec.rb index 5851933f336..ce69838bf14 100644 --- a/spec/lib/api/v3/queries/schemas/query_filter_instance_schema_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/query_filter_instance_schema_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::QueryFilterInstanceSchemaRepresenter do +RSpec.describe API::V3::Queries::Schemas::QueryFilterInstanceSchemaRepresenter do include API::V3::Utilities::PathHelper let(:filter) { Queries::WorkPackages::Filter::StatusFilter.create! } diff --git a/spec/lib/api/v3/queries/schemas/query_schema_representer_spec.rb b/spec/lib/api/v3/queries/schemas/query_schema_representer_spec.rb index 32709e0cc9e..24b1dd0e9e3 100644 --- a/spec/lib/api/v3/queries/schemas/query_schema_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/query_schema_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::QuerySchemaRepresenter do +RSpec.describe API::V3::Queries::Schemas::QuerySchemaRepresenter do include API::V3::Utilities::PathHelper let(:query) do diff --git a/spec/lib/api/v3/queries/schemas/relates_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/relates_filter_dependency_representer_spec.rb index 0297e921c00..ebe4b771c6e 100644 --- a/spec/lib/api/v3/queries/schemas/relates_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/relates_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' 5 -describe API::V3::Queries::Schemas::RelatesFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::RelatesFilterDependencyRepresenter do it_behaves_like 'relation filter dependency' do let(:filter) { Queries::WorkPackages::Filter::RelatesFilter.create!(context: query) } end diff --git a/spec/lib/api/v3/queries/schemas/required_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/required_filter_dependency_representer_spec.rb index 87386d7ee99..b8463cc52a2 100644 --- a/spec/lib/api/v3/queries/schemas/required_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/required_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' 5 -describe API::V3::Queries::Schemas::RequiredFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::RequiredFilterDependencyRepresenter do it_behaves_like 'relation filter dependency' do let(:filter) { Queries::WorkPackages::Filter::RequiredFilter.create!(context: query) } end diff --git a/spec/lib/api/v3/queries/schemas/requires_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/requires_filter_dependency_representer_spec.rb index 5d52a8ed053..2c0ce138541 100644 --- a/spec/lib/api/v3/queries/schemas/requires_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/requires_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' 5 -describe API::V3::Queries::Schemas::RequiresFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::RequiresFilterDependencyRepresenter do it_behaves_like 'relation filter dependency' do let(:filter) { Queries::WorkPackages::Filter::RequiresFilter.create!(context: query) } end diff --git a/spec/lib/api/v3/queries/schemas/role_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/role_filter_dependency_representer_spec.rb index 1502103ee9b..0cc76d30ba3 100644 --- a/spec/lib/api/v3/queries/schemas/role_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/role_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::RoleFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::RoleFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:filter) { Queries::WorkPackages::Filter::RoleFilter.create! } diff --git a/spec/lib/api/v3/queries/schemas/status_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/status_filter_dependency_representer_spec.rb index 2ef1a86a510..fb60a606534 100644 --- a/spec/lib/api/v3/queries/schemas/status_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/status_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::StatusFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::StatusFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:filter) { Queries::WorkPackages::Filter::StatusFilter.create! } diff --git a/spec/lib/api/v3/queries/schemas/subproject_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/subproject_filter_dependency_representer_spec.rb index 9d95c765011..99f4efd7efe 100644 --- a/spec/lib/api/v3/queries/schemas/subproject_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/subproject_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::SubprojectFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::SubprojectFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/schemas/text_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/text_filter_dependency_representer_spec.rb index 825ce461580..e42d77eafa4 100644 --- a/spec/lib/api/v3/queries/schemas/text_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/text_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::TextFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::TextFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/schemas/type_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/type_filter_dependency_representer_spec.rb index fab03491f94..17b27c4b338 100644 --- a/spec/lib/api/v3/queries/schemas/type_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/type_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::TypeFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::TypeFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/schemas/user_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/user_filter_dependency_representer_spec.rb index a880a7e44ca..7145ea5d517 100644 --- a/spec/lib/api/v3/queries/schemas/user_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/user_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::UserFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::UserFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/schemas/version_filter_dependency_representer_spec.rb b/spec/lib/api/v3/queries/schemas/version_filter_dependency_representer_spec.rb index 5fb0b8d7ed6..d6cd998807c 100644 --- a/spec/lib/api/v3/queries/schemas/version_filter_dependency_representer_spec.rb +++ b/spec/lib/api/v3/queries/schemas/version_filter_dependency_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::Schemas::VersionFilterDependencyRepresenter do +RSpec.describe API::V3::Queries::Schemas::VersionFilterDependencyRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/queries/sort_bys/query_sort_by_representer_spec.rb b/spec/lib/api/v3/queries/sort_bys/query_sort_by_representer_spec.rb index a314e71c41f..60680a2a78e 100644 --- a/spec/lib/api/v3/queries/sort_bys/query_sort_by_representer_spec.rb +++ b/spec/lib/api/v3/queries/sort_bys/query_sort_by_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Queries::SortBys::QuerySortByRepresenter do +RSpec.describe API::V3::Queries::SortBys::QuerySortByRepresenter do include API::V3::Utilities::PathHelper let(:column_name) { 'status' } diff --git a/spec/lib/api/v3/relations/relation_collection_representer_spec.rb b/spec/lib/api/v3/relations/relation_collection_representer_spec.rb index f7378a89131..4945a63088f 100644 --- a/spec/lib/api/v3/relations/relation_collection_representer_spec.rb +++ b/spec/lib/api/v3/relations/relation_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Relations::RelationCollectionRepresenter do +RSpec.describe API::V3::Relations::RelationCollectionRepresenter do let(:work_package) do build_stubbed(:work_package) end diff --git a/spec/lib/api/v3/relations/relation_paginated_collection_representer_spec.rb b/spec/lib/api/v3/relations/relation_paginated_collection_representer_spec.rb index 124b811b523..da8339c9224 100644 --- a/spec/lib/api/v3/relations/relation_paginated_collection_representer_spec.rb +++ b/spec/lib/api/v3/relations/relation_paginated_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Relations::RelationPaginatedCollectionRepresenter do +RSpec.describe API::V3::Relations::RelationPaginatedCollectionRepresenter do let(:work_package) do build_stubbed(:work_package) end diff --git a/spec/lib/api/v3/relations/relation_representer_spec.rb b/spec/lib/api/v3/relations/relation_representer_spec.rb index 80961d33df0..259961e8454 100644 --- a/spec/lib/api/v3/relations/relation_representer_spec.rb +++ b/spec/lib/api/v3/relations/relation_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Relations::RelationRepresenter do +RSpec.describe API::V3::Relations::RelationRepresenter do let(:user) { build_stubbed(:admin) } let(:from) { build_stubbed(:work_package) } diff --git a/spec/lib/api/v3/repositories/revision_representer_spec.rb b/spec/lib/api/v3/repositories/revision_representer_spec.rb index 275a4cd346f..8b738ca6d66 100644 --- a/spec/lib/api/v3/repositories/revision_representer_spec.rb +++ b/spec/lib/api/v3/repositories/revision_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Repositories::RevisionRepresenter do +RSpec.describe API::V3::Repositories::RevisionRepresenter do include API::V3::Utilities::PathHelper let(:representer) { described_class.new(revision, current_user: double('current_user')) } diff --git a/spec/lib/api/v3/root_representer_spec.rb b/spec/lib/api/v3/root_representer_spec.rb index e51136d85bc..d0b58679a90 100644 --- a/spec/lib/api/v3/root_representer_spec.rb +++ b/spec/lib/api/v3/root_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::RootRepresenter do +RSpec.describe API::V3::RootRepresenter do include API::V3::Utilities::PathHelper let(:user) { build_stubbed(:user) } diff --git a/spec/lib/api/v3/statuses/status_collection_representer_spec.rb b/spec/lib/api/v3/statuses/status_collection_representer_spec.rb index 315c05732fe..0eefe1922de 100644 --- a/spec/lib/api/v3/statuses/status_collection_representer_spec.rb +++ b/spec/lib/api/v3/statuses/status_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Statuses::StatusCollectionRepresenter do +RSpec.describe API::V3::Statuses::StatusCollectionRepresenter do include API::V3::Utilities::PathHelper let(:statuses) { build_list(:status, 3) } diff --git a/spec/lib/api/v3/statuses/status_representer_spec.rb b/spec/lib/api/v3/statuses/status_representer_spec.rb index 517c125739b..9243ebc8046 100644 --- a/spec/lib/api/v3/statuses/status_representer_spec.rb +++ b/spec/lib/api/v3/statuses/status_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Statuses::StatusRepresenter do +RSpec.describe API::V3::Statuses::StatusRepresenter do let(:status) { build_stubbed(:status) } let(:representer) { described_class.new(status, current_user: double('current_user')) } diff --git a/spec/lib/api/v3/support/api_v3_collection.rb b/spec/lib/api/v3/support/api_v3_collection.rb index 0bdc635209a..5a193f067ca 100644 --- a/spec/lib/api/v3/support/api_v3_collection.rb +++ b/spec/lib/api/v3/support/api_v3_collection.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'generic APIv3 collection' do +RSpec.shared_examples_for 'generic APIv3 collection' do describe '_links' do it 'has a self link' do expect(collection).to be_json_eql(self_link.to_json).at_path('_links/self/href') @@ -48,7 +48,7 @@ shared_examples_for 'generic APIv3 collection' do end end -shared_examples_for 'unpaginated APIv3 collection' do |count, self_link, type| +RSpec.shared_examples_for 'unpaginated APIv3 collection' do |count, self_link, type| it_behaves_like 'generic APIv3 collection' do let(:self_link) { "/api/v3/#{self_link}" } let(:collection_inner_type) { type } @@ -63,7 +63,7 @@ shared_examples_for 'unpaginated APIv3 collection' do |count, self_link, type| end end -shared_examples_for 'offset-paginated APIv3 collection' do +RSpec.shared_examples_for 'offset-paginated APIv3 collection' do def make_link_for(page:, page_size:) page = ERB::Util::url_encode(page) page_size = ERB::Util::url_encode(page_size) diff --git a/spec/lib/api/v3/support/api_v3_digest.rb b/spec/lib/api/v3/support/api_v3_digest.rb index e1aa8528812..a823e7f6fe4 100644 --- a/spec/lib/api/v3/support/api_v3_digest.rb +++ b/spec/lib/api/v3/support/api_v3_digest.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'API V3 digest' do +RSpec.shared_examples_for 'API V3 digest' do it 'defines an algorithm' do expect(subject).to be_json_eql(algorithm.to_json).at_path("#{path}/algorithm") end diff --git a/spec/lib/api/v3/support/api_v3_filter_dependency.rb b/spec/lib/api/v3/support/api_v3_filter_dependency.rb index c6549803224..b2056ce1f20 100644 --- a/spec/lib/api/v3/support/api_v3_filter_dependency.rb +++ b/spec/lib/api/v3/support/api_v3_filter_dependency.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_examples_for 'filter dependency' do +RSpec.shared_examples_for 'filter dependency' do it_behaves_like 'has basic schema properties' do let(:name) { 'Values' } let(:required) { true } @@ -44,7 +44,7 @@ shared_examples_for 'filter dependency' do end end -shared_examples_for 'filter dependency with allowed link' do +RSpec.shared_examples_for 'filter dependency with allowed link' do it_behaves_like 'has basic schema properties' do let(:name) { 'Values' } let(:required) { true } @@ -62,7 +62,7 @@ shared_examples_for 'filter dependency with allowed link' do end end -shared_examples_for 'filter dependency with allowed value link collection' do +RSpec.shared_examples_for 'filter dependency with allowed value link collection' do it_behaves_like 'has basic schema properties' do let(:name) { 'Values' } let(:required) { true } @@ -80,14 +80,14 @@ shared_examples_for 'filter dependency with allowed value link collection' do end end -shared_examples_for 'filter dependency empty' do +RSpec.shared_examples_for 'filter dependency empty' do it 'is an empty object' do expect(subject) .to be_json_eql({}.to_json) end end -shared_examples_for 'relation filter dependency' do +RSpec.shared_examples_for 'relation filter dependency' do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project) } diff --git a/spec/lib/api/v3/support/api_v3_formattable.rb b/spec/lib/api/v3/support/api_v3_formattable.rb index 03f0c1b29d0..ce28d5484fb 100644 --- a/spec/lib/api/v3/support/api_v3_formattable.rb +++ b/spec/lib/api/v3/support/api_v3_formattable.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'API V3 formattable' do |property| +RSpec.shared_examples_for 'API V3 formattable' do |property| it { is_expected.to have_json_path(property) } it { is_expected.to be_json_eql(format.to_json).at_path(property + '/format') } diff --git a/spec/lib/api/v3/support/collection_examples.rb b/spec/lib/api/v3/support/collection_examples.rb index 45c824f14ba..0c0d9cdca1c 100644 --- a/spec/lib/api/v3/support/collection_examples.rb +++ b/spec/lib/api/v3/support/collection_examples.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_examples_for 'collection' do |name| +RSpec.shared_examples_for 'collection' do |name| it "has the #{name} property" do represented_elements = value.map { |v| element_decorator.call(v) } diff --git a/spec/lib/api/v3/support/date_time_examples.rb b/spec/lib/api/v3/support/date_time_examples.rb index 8b1e00a403c..51e23833ce5 100644 --- a/spec/lib/api/v3/support/date_time_examples.rb +++ b/spec/lib/api/v3/support/date_time_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'has ISO 8601 date only' do +RSpec.shared_examples_for 'has ISO 8601 date only' do it 'exists' do expect(subject).to have_json_path(json_path) end @@ -45,7 +45,7 @@ shared_examples_for 'has ISO 8601 date only' do end end -shared_examples_for 'has UTC ISO 8601 date and time' do +RSpec.shared_examples_for 'has UTC ISO 8601 date and time' do it 'exists' do expect(subject).to have_json_path(json_path) end diff --git a/spec/lib/api/v3/support/link_examples.rb b/spec/lib/api/v3/support/link_examples.rb index cd85d0c225e..e7074b12458 100644 --- a/spec/lib/api/v3/support/link_examples.rb +++ b/spec/lib/api/v3/support/link_examples.rb @@ -31,7 +31,7 @@ require 'spec_helper' # FIXME: deprecate this example and replace by 'has an untitled action link' # it does not work as intended (setting user has no effect, but by chance :role overrides base spec) # it does not check the actual href/method -shared_examples_for 'action link' do +RSpec.shared_examples_for 'action link' do let(:permissions) { %i(view_work_packages edit_work_packages) } let(:user) do build_stubbed(:user) @@ -64,7 +64,7 @@ shared_examples_for 'action link' do end end -shared_context 'action link shared' do +RSpec.shared_context 'action link shared' do let(:all_permissions) { OpenProject::AccessControl.permissions.map(&:name) } let(:permissions) { all_permissions } let(:action_link_user) do @@ -105,34 +105,34 @@ shared_context 'action link shared' do end end -shared_examples_for 'has an untitled action link' do +RSpec.shared_examples_for 'has an untitled action link' do include_context 'action link shared' it_behaves_like 'has an untitled link' end -shared_examples_for 'has a titled action link' do +RSpec.shared_examples_for 'has a titled action link' do include_context 'action link shared' it_behaves_like 'has a titled link' end -shared_examples_for 'has a titled link' do +RSpec.shared_examples_for 'has a titled link' do it { is_expected.to be_json_eql(href.to_json).at_path("_links/#{link}/href") } it { is_expected.to be_json_eql(title.to_json).at_path("_links/#{link}/title") } end -shared_examples_for 'has an untitled link' do +RSpec.shared_examples_for 'has an untitled link' do it { is_expected.to be_json_eql(href.to_json).at_path("_links/#{link}/href") } it { is_expected.not_to have_json_path("_links/#{link}/title") } end -shared_examples_for 'has a templated link' do +RSpec.shared_examples_for 'has a templated link' do it { is_expected.to be_json_eql(href.to_json).at_path("_links/#{link}/href") } it { is_expected.to be_json_eql(true.to_json).at_path("_links/#{link}/templated") } end -shared_examples_for 'has an empty link' do +RSpec.shared_examples_for 'has an empty link' do it { is_expected.to be_json_eql(nil.to_json).at_path("_links/#{link}/href") } it 'has no embedded resource' do @@ -140,15 +140,15 @@ shared_examples_for 'has an empty link' do end end -shared_examples_for 'has an empty link collection' do +RSpec.shared_examples_for 'has an empty link collection' do it { is_expected.to be_json_eql([].to_json).at_path("_links/#{link}") } end -shared_examples_for 'has a link collection' do +RSpec.shared_examples_for 'has a link collection' do it { is_expected.to be_json_eql(hrefs.to_json).at_path("_links/#{link}") } end -shared_examples_for 'has no link' do +RSpec.shared_examples_for 'has no link' do it { is_expected.not_to have_json_path("_links/#{link}") } it 'has no embedded resource' do diff --git a/spec/lib/api/v3/support/property_examples.rb b/spec/lib/api/v3/support/property_examples.rb index 13fb8ad2591..71db9f5fad7 100644 --- a/spec/lib/api/v3/support/property_examples.rb +++ b/spec/lib/api/v3/support/property_examples.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_examples_for 'property' do |name| +RSpec.shared_examples_for 'property' do |name| it "has the #{name} property" do expect(subject) .to be_json_eql(value.to_json) @@ -34,7 +34,7 @@ shared_examples_for 'property' do |name| end end -shared_examples_for 'formattable property' do |name| +RSpec.shared_examples_for 'formattable property' do |name| it "has the #{name} property" do expect(subject) .to be_json_eql(value.to_s.to_json) @@ -42,14 +42,14 @@ shared_examples_for 'formattable property' do |name| end end -shared_examples_for 'date property' do |name| +RSpec.shared_examples_for 'date property' do |name| it_behaves_like 'has ISO 8601 date only' do let(:json_path) { name.to_s } let(:date) { value } end end -shared_examples_for 'datetime property' do |name| +RSpec.shared_examples_for 'datetime property' do |name| it_behaves_like 'has UTC ISO 8601 date and time' do let(:json_path) { name.to_s } let(:date) { value } diff --git a/spec/lib/api/v3/support/schema_examples.rb b/spec/lib/api/v3/support/schema_examples.rb index 2470f70ffbf..fea2fc660d3 100644 --- a/spec/lib/api/v3/support/schema_examples.rb +++ b/spec/lib/api/v3/support/schema_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'has basic schema properties' do +RSpec.shared_examples_for 'has basic schema properties' do it 'exists' do expect(subject).to have_json_path(path) end @@ -82,7 +82,7 @@ shared_examples_for 'has basic schema properties' do end end -shared_examples_for 'indicates length requirements' do +RSpec.shared_examples_for 'indicates length requirements' do it 'indicates its minimum length' do if defined?(min_length) expect(subject) @@ -106,7 +106,7 @@ shared_examples_for 'indicates length requirements' do end end -shared_examples_for 'links to allowed values directly' do +RSpec.shared_examples_for 'links to allowed values directly' do it 'has the expected number of links' do expect(subject).to have_json_size(hrefs.size).at_path("#{path}/_links/allowedValues") end @@ -121,7 +121,7 @@ shared_examples_for 'links to allowed values directly' do end end -shared_examples_for 'links to and embeds allowed values directly' do +RSpec.shared_examples_for 'links to and embeds allowed values directly' do it_behaves_like 'links to allowed values directly' it 'has the expected number of embedded values' do @@ -138,13 +138,13 @@ shared_examples_for 'links to and embeds allowed values directly' do end end -shared_examples_for 'links to allowed values via collection link' do +RSpec.shared_examples_for 'links to allowed values via collection link' do it 'contains the link to the allowed values' do expect(subject).to be_json_eql(href.to_json).at_path("#{path}/_links/allowedValues/href") end end -shared_examples_for 'does not link to allowed values' do +RSpec.shared_examples_for 'does not link to allowed values' do it 'contains no link to the allowed values' do expect(subject).not_to have_json_path("#{path}/_links/allowedValues") end diff --git a/spec/lib/api/v3/types/type_representer_spec.rb b/spec/lib/api/v3/types/type_representer_spec.rb index 2a7985d2d94..f1c086d222e 100644 --- a/spec/lib/api/v3/types/type_representer_spec.rb +++ b/spec/lib/api/v3/types/type_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Types::TypeRepresenter do +RSpec.describe API::V3::Types::TypeRepresenter do let(:type) { build_stubbed(:type, color: build_stubbed(:color)) } let(:representer) { described_class.new(type, current_user: double('current_user')) } diff --git a/spec/lib/api/v3/user_preferences/notification_setting_representer_rendering_spec.rb b/spec/lib/api/v3/user_preferences/notification_setting_representer_rendering_spec.rb index a8264eb8263..8ac11a12893 100644 --- a/spec/lib/api/v3/user_preferences/notification_setting_representer_rendering_spec.rb +++ b/spec/lib/api/v3/user_preferences/notification_setting_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::UserPreferences::NotificationSettingRepresenter, 'rendering' do +RSpec.describe API::V3::UserPreferences::NotificationSettingRepresenter, 'rendering' do include API::V3::Utilities::PathHelper subject(:generated) { representer.to_json } diff --git a/spec/lib/api/v3/user_preferences/user_preference_representer_parsing_spec.rb b/spec/lib/api/v3/user_preferences/user_preference_representer_parsing_spec.rb index c3e56599b7a..3148d42ce01 100644 --- a/spec/lib/api/v3/user_preferences/user_preference_representer_parsing_spec.rb +++ b/spec/lib/api/v3/user_preferences/user_preference_representer_parsing_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe API::V3::UserPreferences::UserPreferenceRepresenter, - 'parsing' do +RSpec.describe API::V3::UserPreferences::UserPreferenceRepresenter, + 'parsing' do subject(:parsed) { representer.from_hash request_body } include API::V3::Utilities::PathHelper diff --git a/spec/lib/api/v3/user_preferences/user_preference_representer_rendering_spec.rb b/spec/lib/api/v3/user_preferences/user_preference_representer_rendering_spec.rb index 85967235db2..d5fb4fa2530 100644 --- a/spec/lib/api/v3/user_preferences/user_preference_representer_rendering_spec.rb +++ b/spec/lib/api/v3/user_preferences/user_preference_representer_rendering_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe API::V3::UserPreferences::UserPreferenceRepresenter, - 'rendering' do +RSpec.describe API::V3::UserPreferences::UserPreferenceRepresenter, + 'rendering' do include API::V3::Utilities::PathHelper let(:preference) do diff --git a/spec/lib/api/v3/users/unpaginated_user_collection_representer_spec.rb b/spec/lib/api/v3/users/unpaginated_user_collection_representer_spec.rb index 14a0e17a604..3cbd05d4725 100644 --- a/spec/lib/api/v3/users/unpaginated_user_collection_representer_spec.rb +++ b/spec/lib/api/v3/users/unpaginated_user_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Users::UnpaginatedUserCollectionRepresenter do +RSpec.describe API::V3::Users::UnpaginatedUserCollectionRepresenter do let(:users) do build_stubbed_list(:user, 3) diff --git a/spec/lib/api/v3/users/user_collection_representer_spec.rb b/spec/lib/api/v3/users/user_collection_representer_spec.rb index 9d6a988d9a1..d9db172ef2b 100644 --- a/spec/lib/api/v3/users/user_collection_representer_spec.rb +++ b/spec/lib/api/v3/users/user_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Users::UserCollectionRepresenter do +RSpec.describe API::V3::Users::UserCollectionRepresenter do let(:self_base_link) { '/api/v3/users' } let(:collection_inner_type) { 'User' } let(:total) { 3 } diff --git a/spec/lib/api/v3/users/user_representer_spec.rb b/spec/lib/api/v3/users/user_representer_spec.rb index 9558894ce8e..f6810caad13 100644 --- a/spec/lib/api/v3/users/user_representer_spec.rb +++ b/spec/lib/api/v3/users/user_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Users::UserRepresenter do +RSpec.describe API::V3::Users::UserRepresenter do let(:status) { Principal.statuses[:active] } let(:user) { build_stubbed(:user, status:) } let(:current_user) { build_stubbed(:user) } diff --git a/spec/lib/api/v3/users/user_sql_representer_rendering_spec.rb b/spec/lib/api/v3/users/user_sql_representer_rendering_spec.rb index 31aa40f999e..e2e26cdc67e 100644 --- a/spec/lib/api/v3/users/user_sql_representer_rendering_spec.rb +++ b/spec/lib/api/v3/users/user_sql_representer_rendering_spec.rb @@ -26,7 +26,7 @@ require 'spec_helper' -describe API::V3::Users::UserSqlRepresenter, 'rendering' do +RSpec.describe API::V3::Users::UserSqlRepresenter, 'rendering' do include API::V3::Utilities::PathHelper subject(:json) do diff --git a/spec/lib/api/v3/utilities/custom_field_injector_spec.rb b/spec/lib/api/v3/utilities/custom_field_injector_spec.rb index d06afe906ec..27ac3a4a65b 100644 --- a/spec/lib/api/v3/utilities/custom_field_injector_spec.rb +++ b/spec/lib/api/v3/utilities/custom_field_injector_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Utilities::CustomFieldInjector do +RSpec.describe API::V3::Utilities::CustomFieldInjector do include API::V3::Utilities::PathHelper let(:cf_path) { custom_field.attribute_name(:camel_case) } diff --git a/spec/lib/api/v3/utilities/date_time_formatter_spec.rb b/spec/lib/api/v3/utilities/date_time_formatter_spec.rb index 2c146f8b42d..d5d4c279855 100644 --- a/spec/lib/api/v3/utilities/date_time_formatter_spec.rb +++ b/spec/lib/api/v3/utilities/date_time_formatter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Utilities::DateTimeFormatter do +RSpec.describe API::V3::Utilities::DateTimeFormatter do subject { described_class } let(:date) { Time.zone.today } diff --git a/spec/lib/api/v3/utilities/path_helper_spec.rb b/spec/lib/api/v3/utilities/path_helper_spec.rb index 61b27540de7..24729076eeb 100644 --- a/spec/lib/api/v3/utilities/path_helper_spec.rb +++ b/spec/lib/api/v3/utilities/path_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Utilities::PathHelper do +RSpec.describe API::V3::Utilities::PathHelper do let(:helper) { Class.new.tap { |c| c.extend(API::V3::Utilities::PathHelper) }.api_v3_paths } shared_examples_for 'path' do |url| diff --git a/spec/lib/api/v3/utilities/resource_link_generator_spec.rb b/spec/lib/api/v3/utilities/resource_link_generator_spec.rb index 93b6eabe4fa..600e3926b3e 100644 --- a/spec/lib/api/v3/utilities/resource_link_generator_spec.rb +++ b/spec/lib/api/v3/utilities/resource_link_generator_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Utilities::ResourceLinkGenerator do +RSpec.describe API::V3::Utilities::ResourceLinkGenerator do include API::V3::Utilities::PathHelper subject { described_class } diff --git a/spec/lib/api/v3/values/property_date_representer_rendering_spec.rb b/spec/lib/api/v3/values/property_date_representer_rendering_spec.rb index 18bbae0420c..da638f76193 100644 --- a/spec/lib/api/v3/values/property_date_representer_rendering_spec.rb +++ b/spec/lib/api/v3/values/property_date_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Values::PropertyDateRepresenter, 'rendering' do +RSpec.describe API::V3::Values::PropertyDateRepresenter, 'rendering' do subject(:generated) { representer.to_json } let(:property) { 'abc' } diff --git a/spec/lib/api/v3/values/schemas/property_schema_representer_rendering_spec.rb b/spec/lib/api/v3/values/schemas/property_schema_representer_rendering_spec.rb index a0cb250d185..25a406ddc37 100644 --- a/spec/lib/api/v3/values/schemas/property_schema_representer_rendering_spec.rb +++ b/spec/lib/api/v3/values/schemas/property_schema_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Values::Schemas::PropertySchemaRepresenter, 'rendering' do +RSpec.describe API::V3::Values::Schemas::PropertySchemaRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:current_user) { build_stubbed(:user) } diff --git a/spec/lib/api/v3/values/schemas/value_schema_factory_spec.rb b/spec/lib/api/v3/values/schemas/value_schema_factory_spec.rb index ba1d04cbfa3..1672fd93b7c 100644 --- a/spec/lib/api/v3/values/schemas/value_schema_factory_spec.rb +++ b/spec/lib/api/v3/values/schemas/value_schema_factory_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Values::Schemas::ValueSchemaFactory do +RSpec.describe API::V3::Values::Schemas::ValueSchemaFactory do include API::V3::Utilities::PathHelper describe '.for' do diff --git a/spec/lib/api/v3/versions/schemas/version_schema_representer_spec.rb b/spec/lib/api/v3/versions/schemas/version_schema_representer_spec.rb index 07df4236b76..1ca23181970 100644 --- a/spec/lib/api/v3/versions/schemas/version_schema_representer_spec.rb +++ b/spec/lib/api/v3/versions/schemas/version_schema_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Versions::Schemas::VersionSchemaRepresenter do +RSpec.describe API::V3::Versions::Schemas::VersionSchemaRepresenter do include API::V3::Utilities::PathHelper let(:current_user) { build_stubbed(:user) } diff --git a/spec/lib/api/v3/versions/version_collection_representer_spec.rb b/spec/lib/api/v3/versions/version_collection_representer_spec.rb index 9083770c00c..b4ae2c810a9 100644 --- a/spec/lib/api/v3/versions/version_collection_representer_spec.rb +++ b/spec/lib/api/v3/versions/version_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Versions::VersionCollectionRepresenter do +RSpec.describe API::V3::Versions::VersionCollectionRepresenter do let(:self_link) { '/api/v3/projects/1/versions' } let(:versions) { build_stubbed_list(:version, 3) } let(:user) { build_stubbed(:user) } diff --git a/spec/lib/api/v3/versions/version_representer_rendering_spec.rb b/spec/lib/api/v3/versions/version_representer_rendering_spec.rb index a676b9dc524..4e94dbe91b1 100644 --- a/spec/lib/api/v3/versions/version_representer_rendering_spec.rb +++ b/spec/lib/api/v3/versions/version_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Versions::VersionRepresenter, 'rendering' do +RSpec.describe API::V3::Versions::VersionRepresenter, 'rendering' do let(:version) { build_stubbed(:version) } let(:permissions) { [:manage_versions] } let(:permissions) { [:manage_versions] } diff --git a/spec/lib/api/v3/views/view_representer_rendering_spec.rb b/spec/lib/api/v3/views/view_representer_rendering_spec.rb index 0059e84c236..ff7c6f429a7 100644 --- a/spec/lib/api/v3/views/view_representer_rendering_spec.rb +++ b/spec/lib/api/v3/views/view_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::Views::ViewRepresenter, 'rendering' do +RSpec.describe API::V3::Views::ViewRepresenter, 'rendering' do include API::V3::Utilities::PathHelper subject(:generated) { representer.to_json } diff --git a/spec/lib/api/v3/wiki_pages/wiki_page_representer_rendering_spec.rb b/spec/lib/api/v3/wiki_pages/wiki_page_representer_rendering_spec.rb index 0f6f99e28e5..739bde6e8c1 100644 --- a/spec/lib/api/v3/wiki_pages/wiki_page_representer_rendering_spec.rb +++ b/spec/lib/api/v3/wiki_pages/wiki_page_representer_rendering_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WikiPages::WikiPageRepresenter, 'rendering' do +RSpec.describe API::V3::WikiPages::WikiPageRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:wiki_page) do diff --git a/spec/lib/api/v3/work_packages/create_form_representer_spec.rb b/spec/lib/api/v3/work_packages/create_form_representer_spec.rb index f6df3a55744..abf97a45244 100644 --- a/spec/lib/api/v3/work_packages/create_form_representer_spec.rb +++ b/spec/lib/api/v3/work_packages/create_form_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::CreateFormRepresenter do +RSpec.describe API::V3::WorkPackages::CreateFormRepresenter do include API::V3::Utilities::PathHelper let(:errors) { [] } diff --git a/spec/lib/api/v3/work_packages/create_project_form_representer_spec.rb b/spec/lib/api/v3/work_packages/create_project_form_representer_spec.rb index 309e7110090..0b1242af224 100644 --- a/spec/lib/api/v3/work_packages/create_project_form_representer_spec.rb +++ b/spec/lib/api/v3/work_packages/create_project_form_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::CreateProjectFormRepresenter do +RSpec.describe API::V3::WorkPackages::CreateProjectFormRepresenter do include API::V3::Utilities::PathHelper let(:errors) { [] } diff --git a/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb b/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb index 1e7c79b3cae..db9d70e12cc 100644 --- a/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb +++ b/spec/lib/api/v3/work_packages/eager_loading/cache_checksum_integration_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './eager_loading_mock_wrapper' -describe API::V3::WorkPackages::EagerLoading::Checksum do +RSpec.describe API::V3::WorkPackages::EagerLoading::Checksum do let(:responsible) { create(:user) } let(:assignee) { create(:user) } let(:category) { create(:category) } diff --git a/spec/lib/api/v3/work_packages/eager_loading/cost_eager_loading_integration_spec.rb b/spec/lib/api/v3/work_packages/eager_loading/cost_eager_loading_integration_spec.rb index 3ec474446a5..231179ce904 100644 --- a/spec/lib/api/v3/work_packages/eager_loading/cost_eager_loading_integration_spec.rb +++ b/spec/lib/api/v3/work_packages/eager_loading/cost_eager_loading_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::WorkPackageEagerLoadingWrapper, 'cost eager loading', type: :model do +RSpec.describe API::V3::WorkPackages::WorkPackageEagerLoadingWrapper, 'cost eager loading', type: :model do let(:project) do work_package.project end diff --git a/spec/lib/api/v3/work_packages/eager_loading/custom_actions_integration_spec.rb b/spec/lib/api/v3/work_packages/eager_loading/custom_actions_integration_spec.rb index 9dd092fbced..ff36756e548 100644 --- a/spec/lib/api/v3/work_packages/eager_loading/custom_actions_integration_spec.rb +++ b/spec/lib/api/v3/work_packages/eager_loading/custom_actions_integration_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './eager_loading_mock_wrapper' -describe API::V3::WorkPackages::EagerLoading::CustomAction do +RSpec.describe API::V3::WorkPackages::EagerLoading::CustomAction do let!(:work_package1) { create(:work_package) } let!(:work_package2) { create(:work_package) } let!(:user) do diff --git a/spec/lib/api/v3/work_packages/eager_loading/custom_value_integration_spec.rb b/spec/lib/api/v3/work_packages/eager_loading/custom_value_integration_spec.rb index 9e19c97db08..f903e35530a 100644 --- a/spec/lib/api/v3/work_packages/eager_loading/custom_value_integration_spec.rb +++ b/spec/lib/api/v3/work_packages/eager_loading/custom_value_integration_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './eager_loading_mock_wrapper' -describe API::V3::WorkPackages::EagerLoading::CustomValue do +RSpec.describe API::V3::WorkPackages::EagerLoading::CustomValue do let!(:work_package) { create(:work_package) } let!(:type) { work_package.type } let!(:other_type) { create(:type) } diff --git a/spec/lib/api/v3/work_packages/eager_loading/project_integration_spec.rb b/spec/lib/api/v3/work_packages/eager_loading/project_integration_spec.rb index 234ec40b8bf..a39b12824cf 100644 --- a/spec/lib/api/v3/work_packages/eager_loading/project_integration_spec.rb +++ b/spec/lib/api/v3/work_packages/eager_loading/project_integration_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './eager_loading_mock_wrapper' -describe API::V3::WorkPackages::EagerLoading::Project do +RSpec.describe API::V3::WorkPackages::EagerLoading::Project do let!(:parent_work_package1) { create(:work_package, project: parent_project) } let!(:work_package1) { create(:work_package, project:, parent: parent_work_package1) } let!(:work_package2) { create(:work_package, project:, parent: parent_work_package1) } diff --git a/spec/lib/api/v3/work_packages/form_representer_spec.rb b/spec/lib/api/v3/work_packages/form_representer_spec.rb index fdcce23f4a0..0f0642c8367 100644 --- a/spec/lib/api/v3/work_packages/form_representer_spec.rb +++ b/spec/lib/api/v3/work_packages/form_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::FormRepresenter do +RSpec.describe API::V3::WorkPackages::FormRepresenter do include API::V3::Utilities::PathHelper let(:errors) { [] } diff --git a/spec/lib/api/v3/work_packages/schema/specific_work_package_schema_spec.rb b/spec/lib/api/v3/work_packages/schema/specific_work_package_schema_spec.rb index f33ed60ea40..7ee9e676d05 100644 --- a/spec/lib/api/v3/work_packages/schema/specific_work_package_schema_spec.rb +++ b/spec/lib/api/v3/work_packages/schema/specific_work_package_schema_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::Schema::SpecificWorkPackageSchema do +RSpec.describe API::V3::WorkPackages::Schema::SpecificWorkPackageSchema do let(:project) { build_stubbed(:project) } let(:type) { build_stubbed(:type) } let(:work_package) do diff --git a/spec/lib/api/v3/work_packages/schema/typed_work_package_schema_spec.rb b/spec/lib/api/v3/work_packages/schema/typed_work_package_schema_spec.rb index 6a4b209f385..f4c9c459f1d 100644 --- a/spec/lib/api/v3/work_packages/schema/typed_work_package_schema_spec.rb +++ b/spec/lib/api/v3/work_packages/schema/typed_work_package_schema_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::Schema::TypedWorkPackageSchema do +RSpec.describe API::V3::WorkPackages::Schema::TypedWorkPackageSchema do let(:project) { build(:project) } let(:type) { build(:type) } diff --git a/spec/lib/api/v3/work_packages/schema/work_package_schema_representer_spec.rb b/spec/lib/api/v3/work_packages/schema/work_package_schema_representer_spec.rb index 2f5c86edd13..6fa86bf4b73 100644 --- a/spec/lib/api/v3/work_packages/schema/work_package_schema_representer_spec.rb +++ b/spec/lib/api/v3/work_packages/schema/work_package_schema_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::Schema::WorkPackageSchemaRepresenter do +RSpec.describe API::V3::WorkPackages::Schema::WorkPackageSchemaRepresenter do include API::V3::Utilities::PathHelper let(:project) { build_stubbed(:project_with_types) } diff --git a/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_representer_spec.rb b/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_representer_spec.rb index 78d00901927..e084e8784e2 100644 --- a/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_representer_spec.rb +++ b/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::Schema::WorkPackageSumsSchemaRepresenter do +RSpec.describe API::V3::WorkPackages::Schema::WorkPackageSumsSchemaRepresenter do include API::V3::Utilities::PathHelper let(:custom_field) { build_stubbed(:integer_issue_custom_field) } diff --git a/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_spec.rb b/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_spec.rb index c6a53690739..0687d54c0ff 100644 --- a/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_spec.rb +++ b/spec/lib/api/v3/work_packages/schema/work_package_sums_schema_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::Schema::WorkPackageSumsSchema do +RSpec.describe API::V3::WorkPackages::Schema::WorkPackageSumsSchema do let(:current_user) { double('current user') } subject { described_class.new } diff --git a/spec/lib/api/v3/work_packages/update_form_representer_spec.rb b/spec/lib/api/v3/work_packages/update_form_representer_spec.rb index a4451eaa24c..8a5c7755e06 100644 --- a/spec/lib/api/v3/work_packages/update_form_representer_spec.rb +++ b/spec/lib/api/v3/work_packages/update_form_representer_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::UpdateFormRepresenter do +RSpec.describe API::V3::WorkPackages::UpdateFormRepresenter do include API::V3::Utilities::PathHelper let(:errors) { [] } diff --git a/spec/lib/api/v3/work_packages/work_package_at_timestamp_representer_rendering_spec.rb b/spec/lib/api/v3/work_packages/work_package_at_timestamp_representer_rendering_spec.rb index ac05f00c7d8..143ad1153ac 100644 --- a/spec/lib/api/v3/work_packages/work_package_at_timestamp_representer_rendering_spec.rb +++ b/spec/lib/api/v3/work_packages/work_package_at_timestamp_representer_rendering_spec.rb @@ -31,7 +31,7 @@ require 'spec_helper' # Note: The specs in this file do not attempt to test the properties themselves with all their possible # variations. This is done in length in the work_package_representer_spec.rb. Instead, the focus of the tests # here are on the selection of properties. -describe API::V3::WorkPackages::WorkPackageAtTimestampRepresenter, 'rendering' do +RSpec.describe API::V3::WorkPackages::WorkPackageAtTimestampRepresenter, 'rendering' do include API::V3::Utilities::PathHelper let(:current_user) { build_stubbed(:user) } diff --git a/spec/lib/api/v3/work_packages/work_package_collection_representer_spec.rb b/spec/lib/api/v3/work_packages/work_package_collection_representer_spec.rb index 24ab7388097..7cdab28949b 100644 --- a/spec/lib/api/v3/work_packages/work_package_collection_representer_spec.rb +++ b/spec/lib/api/v3/work_packages/work_package_collection_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::WorkPackageCollectionRepresenter do +RSpec.describe API::V3::WorkPackages::WorkPackageCollectionRepresenter do include API::V3::Utilities::PathHelper let(:self_base_link) { '/api/v3/example' } diff --git a/spec/lib/api/v3/work_packages/work_package_payload_representer_spec.rb b/spec/lib/api/v3/work_packages/work_package_payload_representer_spec.rb index db69f881da4..26a4979ff29 100644 --- a/spec/lib/api/v3/work_packages/work_package_payload_representer_spec.rb +++ b/spec/lib/api/v3/work_packages/work_package_payload_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::WorkPackagePayloadRepresenter do +RSpec.describe API::V3::WorkPackages::WorkPackagePayloadRepresenter do include API::V3::Utilities::PathHelper let(:work_package) do diff --git a/spec/lib/api/v3/work_packages/work_package_representer_spec.rb b/spec/lib/api/v3/work_packages/work_package_representer_spec.rb index af24d718603..ced00a7663a 100644 --- a/spec/lib/api/v3/work_packages/work_package_representer_spec.rb +++ b/spec/lib/api/v3/work_packages/work_package_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::WorkPackageRepresenter do +RSpec.describe API::V3::WorkPackages::WorkPackageRepresenter do include API::V3::Utilities::PathHelper let(:member) { build_stubbed(:user) } diff --git a/spec/lib/api/v3/work_packages/work_package_sql_representer_rendering_spec.rb b/spec/lib/api/v3/work_packages/work_package_sql_representer_rendering_spec.rb index 09aa7a9273f..08e8c0caff4 100644 --- a/spec/lib/api/v3/work_packages/work_package_sql_representer_rendering_spec.rb +++ b/spec/lib/api/v3/work_packages/work_package_sql_representer_rendering_spec.rb @@ -26,7 +26,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::WorkPackageSqlRepresenter, 'rendering' do +RSpec.describe API::V3::WorkPackages::WorkPackageSqlRepresenter, 'rendering' do include API::V3::Utilities::PathHelper subject(:json) do diff --git a/spec/lib/api/v3/work_packages/work_package_sums_representer_spec.rb b/spec/lib/api/v3/work_packages/work_package_sums_representer_spec.rb index 21a773b4239..4dde3cb81b9 100644 --- a/spec/lib/api/v3/work_packages/work_package_sums_representer_spec.rb +++ b/spec/lib/api/v3/work_packages/work_package_sums_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::WorkPackageSumsRepresenter do +RSpec.describe API::V3::WorkPackages::WorkPackageSumsRepresenter do let(:custom_field) do build_stubbed(:int_wp_custom_field, id: 1).tap do |cf| allow(WorkPackageCustomField) diff --git a/spec/lib/core_extensions/squish_sql_spec.rb b/spec/lib/core_extensions/squish_sql_spec.rb index 491dbd74149..258fe30c452 100644 --- a/spec/lib/core_extensions/squish_sql_spec.rb +++ b/spec/lib/core_extensions/squish_sql_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CoreExtensions::SquishSql do +RSpec.describe CoreExtensions::SquishSql do using described_class it 'removes single line SQL comments' do diff --git a/spec/lib/core_extensions/to_localized_slug_spec.rb b/spec/lib/core_extensions/to_localized_slug_spec.rb index b7c2357d6a4..1a4f9052633 100644 --- a/spec/lib/core_extensions/to_localized_slug_spec.rb +++ b/spec/lib/core_extensions/to_localized_slug_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe CoreExtensions::String, '#to_localized_slug' do +RSpec.describe CoreExtensions::String, '#to_localized_slug' do let(:input) { "dübelbädel! ..." } let(:slug) { input.to_localized_slug } diff --git a/spec/lib/custom_field_form_builder_spec.rb b/spec/lib/custom_field_form_builder_spec.rb index f8d9ff26f4e..044a634123f 100644 --- a/spec/lib/custom_field_form_builder_spec.rb +++ b/spec/lib/custom_field_form_builder_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'ostruct' -describe CustomFieldFormBuilder do +RSpec.describe CustomFieldFormBuilder do include Capybara::RSpecMatchers let(:helper) { ActionView::Base.new(ActionView::LookupContext.new(''), {}, @controller) } diff --git a/spec/lib/database_spec.rb b/spec/lib/database_spec.rb index 35e88e318d4..542aa5a6db4 100644 --- a/spec/lib/database_spec.rb +++ b/spec/lib/database_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe OpenProject::Database do +RSpec.describe OpenProject::Database do before do described_class.instance_variable_set(:@version, nil) end diff --git a/spec/lib/deprecated_alias_spec.rb b/spec/lib/deprecated_alias_spec.rb index 92befd1a95a..aa7858124f4 100644 --- a/spec/lib/deprecated_alias_spec.rb +++ b/spec/lib/deprecated_alias_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe DeprecatedAlias do +RSpec.describe DeprecatedAlias do let(:clazz) do Class.new do extend DeprecatedAlias diff --git a/spec/lib/i18n/pluralization_spec.rb b/spec/lib/i18n/pluralization_spec.rb index 40d4465f83f..a7c88f780b5 100644 --- a/spec/lib/i18n/pluralization_spec.rb +++ b/spec/lib/i18n/pluralization_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe I18n, 'pluralization', type: :helper do +RSpec.describe I18n, 'pluralization', type: :helper do describe 'with slowenian language and the :two plural key missing' do before do I18n.locale = :sl diff --git a/spec/lib/journal_formatter/active_status_spec.rb b/spec/lib/journal_formatter/active_status_spec.rb index a03c7cd75aa..796ef2de4a6 100644 --- a/spec/lib/journal_formatter/active_status_spec.rb +++ b/spec/lib/journal_formatter/active_status_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::JournalFormatter::ActiveStatus do +RSpec.describe OpenProject::JournalFormatter::ActiveStatus do let(:instance) { described_class.new(build(:project_journal)) } it "renders correctly when unarchiving" do diff --git a/spec/lib/journal_formatter/attachment_spec.rb b/spec/lib/journal_formatter/attachment_spec.rb index e5b94aa8d77..1af4d6f2675 100644 --- a/spec/lib/journal_formatter/attachment_spec.rb +++ b/spec/lib/journal_formatter/attachment_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::JournalFormatter::Attachment do +RSpec.describe OpenProject::JournalFormatter::Attachment do include ApplicationHelper include ActionView::Helpers::TagHelper # WARNING: the order of the modules is important to ensure that url_for of diff --git a/spec/lib/journal_formatter/custom_field_spec.rb b/spec/lib/journal_formatter/custom_field_spec.rb index 19547d00795..ba9eac48ffb 100644 --- a/spec/lib/journal_formatter/custom_field_spec.rb +++ b/spec/lib/journal_formatter/custom_field_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::JournalFormatter::CustomField do +RSpec.describe OpenProject::JournalFormatter::CustomField do include CustomFieldsHelper include ActionView::Helpers::TagHelper diff --git a/spec/lib/journal_formatter/day_count_spec.rb b/spec/lib/journal_formatter/day_count_spec.rb index 09a950c7480..2bced1e94e0 100644 --- a/spec/lib/journal_formatter/day_count_spec.rb +++ b/spec/lib/journal_formatter/day_count_spec.rb @@ -28,7 +28,7 @@ require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper.rb") -describe JournalFormatter::DayCount do +RSpec.describe JournalFormatter::DayCount do let(:klass) { described_class } let(:id) { 1 } let(:journal) do diff --git a/spec/lib/journal_formatter/diff_spec.rb b/spec/lib/journal_formatter/diff_spec.rb index 8ab0ca835ed..5b29c313a1c 100644 --- a/spec/lib/journal_formatter/diff_spec.rb +++ b/spec/lib/journal_formatter/diff_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::JournalFormatter::Diff do +RSpec.describe OpenProject::JournalFormatter::Diff do include ActionView::Helpers::TagHelper # WARNING: the order of the modules is important to ensure that url_for of # ActionController::UrlWriter is called and not the one of ActionView::Helpers::UrlHelper diff --git a/spec/lib/journal_formatter/ignore_non_working_days_spec.rb b/spec/lib/journal_formatter/ignore_non_working_days_spec.rb index 9f9605f8e6a..7e5ad2b7a74 100644 --- a/spec/lib/journal_formatter/ignore_non_working_days_spec.rb +++ b/spec/lib/journal_formatter/ignore_non_working_days_spec.rb @@ -28,7 +28,7 @@ require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper.rb") -describe OpenProject::JournalFormatter::IgnoreNonWorkingDays do +RSpec.describe OpenProject::JournalFormatter::IgnoreNonWorkingDays do let(:klass) { described_class } let(:id) { 1 } let(:journal) do diff --git a/spec/lib/journal_formatter/schedule_manually_spec.rb b/spec/lib/journal_formatter/schedule_manually_spec.rb index 7531a642b41..84682f24ca9 100644 --- a/spec/lib/journal_formatter/schedule_manually_spec.rb +++ b/spec/lib/journal_formatter/schedule_manually_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::JournalFormatter::ScheduleManually do +RSpec.describe OpenProject::JournalFormatter::ScheduleManually do let(:klass) { described_class } let(:id) { 1 } let(:journal) do diff --git a/spec/lib/journal_formatter/template_spec.rb b/spec/lib/journal_formatter/template_spec.rb index 8ac39e59728..9104383c0b5 100644 --- a/spec/lib/journal_formatter/template_spec.rb +++ b/spec/lib/journal_formatter/template_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::JournalFormatter::Template do +RSpec.describe OpenProject::JournalFormatter::Template do let(:instance) { described_class.new(build(:project_journal)) } it "renders correctly when marked as template" do diff --git a/spec/lib/journal_formatter/visibility_spec.rb b/spec/lib/journal_formatter/visibility_spec.rb index 73ea190d00a..26cf0ba07c7 100644 --- a/spec/lib/journal_formatter/visibility_spec.rb +++ b/spec/lib/journal_formatter/visibility_spec.rb @@ -28,7 +28,7 @@ require File.expand_path("#{File.dirname(__FILE__)}/../../spec_helper.rb") -describe OpenProject::JournalFormatter::Visibility do +RSpec.describe OpenProject::JournalFormatter::Visibility do let(:instance) { described_class.new(build(:project_journal)) } it "renders correctly when setting visibility" do diff --git a/spec/lib/journal_formatter/wiki_diff_spec.rb b/spec/lib/journal_formatter/wiki_diff_spec.rb index ee04277af5a..9dbf276a083 100644 --- a/spec/lib/journal_formatter/wiki_diff_spec.rb +++ b/spec/lib/journal_formatter/wiki_diff_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::JournalFormatter::WikiDiff do +RSpec.describe OpenProject::JournalFormatter::WikiDiff do include ActionView::Helpers::TagHelper # WARNING: the order of the modules is important to ensure that url_for of # ActionController::UrlWriter is called and not the one of ActionView::Helpers::UrlHelper diff --git a/spec/lib/open_project/access_control/permission_spec.rb b/spec/lib/open_project/access_control/permission_spec.rb index ee32dc5ab7b..d7cc94ae5a7 100644 --- a/spec/lib/open_project/access_control/permission_spec.rb +++ b/spec/lib/open_project/access_control/permission_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::AccessControl::Permission do +RSpec.describe OpenProject::AccessControl::Permission do describe '#dependencies' do context 'for a permission with a dependency' do subject { OpenProject::AccessControl.permission(:edit_work_packages) } diff --git a/spec/lib/open_project/access_control_spec.rb b/spec/lib/open_project/access_control_spec.rb index f766f6b96e5..e462639c703 100644 --- a/spec/lib/open_project/access_control_spec.rb +++ b/spec/lib/open_project/access_control_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::AccessControl do +RSpec.describe OpenProject::AccessControl do def setup_global_permissions OpenProject::AccessControl.map do |map| map.permission :proj0, { dont: :care }, require: :member, contract_actions: { foo: :create } diff --git a/spec/lib/open_project/authentication/strategies/warden/global_basic_auth_spec.rb b/spec/lib/open_project/authentication/strategies/warden/global_basic_auth_spec.rb index 4c1ff1660d7..9c0a288b4b0 100644 --- a/spec/lib/open_project/authentication/strategies/warden/global_basic_auth_spec.rb +++ b/spec/lib/open_project/authentication/strategies/warden/global_basic_auth_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' Strategies = OpenProject::Authentication::Strategies::Warden -describe Strategies::GlobalBasicAuth do +RSpec.describe Strategies::GlobalBasicAuth do let(:user) { 'someuser' } let(:password) { 'somepassword' } diff --git a/spec/lib/open_project/changed_by_system_spec.rb b/spec/lib/open_project/changed_by_system_spec.rb index 431750acc2b..1f546d677b8 100644 --- a/spec/lib/open_project/changed_by_system_spec.rb +++ b/spec/lib/open_project/changed_by_system_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::ChangedBySystem do +RSpec.describe OpenProject::ChangedBySystem do subject(:model) do model = News.new model.extend(described_class) diff --git a/spec/lib/open_project/configuration/helpers_spec.rb b/spec/lib/open_project/configuration/helpers_spec.rb index b5cc1f67928..6f8a0d0a473 100644 --- a/spec/lib/open_project/configuration/helpers_spec.rb +++ b/spec/lib/open_project/configuration/helpers_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'open_project/configuration/helpers' -describe OpenProject::Configuration::Helpers do +RSpec.describe OpenProject::Configuration::Helpers do let(:config) do {}.tap do |config| config.extend OpenProject::Configuration::Helpers diff --git a/spec/lib/open_project/configuration_spec.rb b/spec/lib/open_project/configuration_spec.rb index 6b418c8b306..a49726cf5f4 100644 --- a/spec/lib/open_project/configuration_spec.rb +++ b/spec/lib/open_project/configuration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::Configuration, :settings_reset do +RSpec.describe OpenProject::Configuration, :settings_reset do describe '.[setting]' do it 'fetches the value' do expect(described_class.app_title) diff --git a/spec/lib/open_project/content_type_detector_spec.rb b/spec/lib/open_project/content_type_detector_spec.rb index ff3377cfd41..4e581672645 100644 --- a/spec/lib/open_project/content_type_detector_spec.rb +++ b/spec/lib/open_project/content_type_detector_spec.rb @@ -56,7 +56,7 @@ require 'spec_helper' -describe OpenProject::ContentTypeDetector do +RSpec.describe OpenProject::ContentTypeDetector do it 'gives a sensible default when the name is empty' do expect(OpenProject::ContentTypeDetector.new('').detect).to eq('application/binary') end diff --git a/spec/lib/open_project/enterprise_spec.rb b/spec/lib/open_project/enterprise_spec.rb index 24181a941d6..2dfca45591c 100644 --- a/spec/lib/open_project/enterprise_spec.rb +++ b/spec/lib/open_project/enterprise_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'open_project/passwords' -describe OpenProject::Enterprise do +RSpec.describe OpenProject::Enterprise do # create 3 built-in users, only 2 of which are active # Also create a placeholder user which will not count against the limit let!(:system_user) { User.system } diff --git a/spec/lib/open_project/feature_decisions_spec.rb b/spec/lib/open_project/feature_decisions_spec.rb index bd193042299..a931ee306cd 100644 --- a/spec/lib/open_project/feature_decisions_spec.rb +++ b/spec/lib/open_project/feature_decisions_spec.rb @@ -27,7 +27,7 @@ # ++ require 'spec_helper' -describe OpenProject::FeatureDecisions, :settings_reset do +RSpec.describe OpenProject::FeatureDecisions, :settings_reset do let(:flag_name) { :example_flag } include_context 'with clean feature decisions' diff --git a/spec/lib/open_project/file_command_content_type_detector_spec.rb b/spec/lib/open_project/file_command_content_type_detector_spec.rb index 65f5e887a8a..f227d6b852e 100644 --- a/spec/lib/open_project/file_command_content_type_detector_spec.rb +++ b/spec/lib/open_project/file_command_content_type_detector_spec.rb @@ -56,7 +56,7 @@ require 'spec_helper' -describe OpenProject::FileCommandContentTypeDetector do +RSpec.describe OpenProject::FileCommandContentTypeDetector do it 'returns a content type based on the content of the file' do tempfile = Tempfile.new('something') tempfile.write('This is a file.') diff --git a/spec/lib/open_project/files_spec.rb b/spec/lib/open_project/files_spec.rb index de944372889..7b6578af286 100644 --- a/spec/lib/open_project/files_spec.rb +++ b/spec/lib/open_project/files_spec.rb @@ -56,7 +56,7 @@ require 'spec_helper' -describe OpenProject::Files do +RSpec.describe OpenProject::Files do describe 'build_uploaded_file' do let(:original_filename) { 'test.png' } let(:content_type) { 'image/png' } diff --git a/spec/lib/open_project/footer_spec.rb b/spec/lib/open_project/footer_spec.rb index 1ef4209d3b4..0dac6d322b4 100644 --- a/spec/lib/open_project/footer_spec.rb +++ b/spec/lib/open_project/footer_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'open_project/footer' -describe OpenProject::Footer do +RSpec.describe OpenProject::Footer do describe '.add_content' do context 'empty content' do before do diff --git a/spec/lib/open_project/form_tag_helper_spec.rb b/spec/lib/open_project/form_tag_helper_spec.rb index 789ff601738..abaf4632a24 100644 --- a/spec/lib/open_project/form_tag_helper_spec.rb +++ b/spec/lib/open_project/form_tag_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::FormTagHelper, type: :helper do +RSpec.describe OpenProject::FormTagHelper, type: :helper do let(:options) { {} } describe '#styled_form_tag' do diff --git a/spec/lib/open_project/hook_spec.rb b/spec/lib/open_project/hook_spec.rb index e8673efafe5..6be97a567c4 100644 --- a/spec/lib/open_project/hook_spec.rb +++ b/spec/lib/open_project/hook_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe OpenProject::Hook do +RSpec.describe OpenProject::Hook do let(:test_hook_class) do Class.new(OpenProject::Hook::ViewListener) end diff --git a/spec/lib/open_project/logging/log_extender_spec.rb b/spec/lib/open_project/logging/log_extender_spec.rb index 8427910ef8b..143513a3997 100644 --- a/spec/lib/open_project/logging/log_extender_spec.rb +++ b/spec/lib/open_project/logging/log_extender_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::Logging, 'Log extenders' do +RSpec.describe OpenProject::Logging, 'Log extenders' do subject { described_class.extend_payload!(payload, input_context) } let(:payload) do diff --git a/spec/lib/open_project/mime_type_spec.rb b/spec/lib/open_project/mime_type_spec.rb index 4330d9f9c2b..aba5b4048cc 100644 --- a/spec/lib/open_project/mime_type_spec.rb +++ b/spec/lib/open_project/mime_type_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe OpenProject::MimeType do +RSpec.describe OpenProject::MimeType do describe '#of' do to_test = { 'test.unk' => nil, 'test.txt' => 'text/plain', diff --git a/spec/lib/open_project/notifications_spec.rb b/spec/lib/open_project/notifications_spec.rb index 1684d14f984..2ab7de10d29 100644 --- a/spec/lib/open_project/notifications_spec.rb +++ b/spec/lib/open_project/notifications_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::Notifications do +RSpec.describe OpenProject::Notifications do let(:probe) { lambda { |*_args| } } let(:payload) { { 'test' => 'payload' } } diff --git a/spec/lib/open_project/object_linking_spec.rb b/spec/lib/open_project/object_linking_spec.rb deleted file mode 100644 index fd496062374..00000000000 --- a/spec/lib/open_project/object_linking_spec.rb +++ /dev/null @@ -1,32 +0,0 @@ -#-- copyright -# OpenProject is an open source project management software. -# Copyright (C) 2012-2023 the OpenProject GmbH -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License version 3. -# -# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows: -# Copyright (C) 2006-2013 Jean-Philippe Lang -# Copyright (C) 2010-2013 the ChiliProject Team -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License -# as published by the Free Software Foundation; either version 2 -# of the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. -# -# See COPYRIGHT and LICENSE files for more details. -#++ - -require 'spec_helper' - -describe OpenProject::ObjectLinking do -end diff --git a/spec/lib/open_project/omni_auth/authorization_spec.rb b/spec/lib/open_project/omni_auth/authorization_spec.rb index 839e20209e8..48a14bb8027 100644 --- a/spec/lib/open_project/omni_auth/authorization_spec.rb +++ b/spec/lib/open_project/omni_auth/authorization_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::OmniAuth::Authorization do +RSpec.describe OpenProject::OmniAuth::Authorization do describe '.after_login!' do let(:auth_hash) { Struct.new(:uid).new 'bar' } let(:user) { create(:user, mail: 'foo@bar.de') } diff --git a/spec/lib/open_project/passwords_spec.rb b/spec/lib/open_project/passwords_spec.rb index 443fbf7ac6a..831e50f8060 100644 --- a/spec/lib/open_project/passwords_spec.rb +++ b/spec/lib/open_project/passwords_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'open_project/passwords' -describe OpenProject::Passwords::Generator do +RSpec.describe OpenProject::Passwords::Generator do describe '#random_password', with_settings: { password_active_rules: %w(lowercase uppercase numeric special), @@ -43,13 +43,13 @@ describe OpenProject::Passwords::Generator do end end -describe OpenProject::Passwords::Evaluator, - with_settings: { - password_active_rules: %w(lowercase uppercase numeric), - password_min_adhered_rules: 3, - password_min_length: 4 - } do - it 'correctlies evaluate passwords' do +RSpec.describe OpenProject::Passwords::Evaluator, + with_settings: { + password_active_rules: %w(lowercase uppercase numeric), + password_min_adhered_rules: 3, + password_min_length: 4 + } do + it 'evaluates passwords correctly' do expect(OpenProject::Passwords::Evaluator.conforming?('abCD')).to be(false) expect(OpenProject::Passwords::Evaluator.conforming?('ab12')).to be(false) expect(OpenProject::Passwords::Evaluator.conforming?('12CD')).to be(false) diff --git a/spec/lib/open_project/plugins/acts_as_op_engine_spec.rb b/spec/lib/open_project/plugins/acts_as_op_engine_spec.rb index a0ed9e41712..0432d2c3f61 100644 --- a/spec/lib/open_project/plugins/acts_as_op_engine_spec.rb +++ b/spec/lib/open_project/plugins/acts_as_op_engine_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'roar/decorator' -describe OpenProject::Plugins::ActsAsOpEngine do +RSpec.describe OpenProject::Plugins::ActsAsOpEngine do class ActsAsOpEngineTestEngine < Rails::Engine include OpenProject::Plugins::ActsAsOpEngine end diff --git a/spec/lib/open_project/plugins/module_handler_spec.rb b/spec/lib/open_project/plugins/module_handler_spec.rb index eed5a817622..d7cdf0a4d9a 100644 --- a/spec/lib/open_project/plugins/module_handler_spec.rb +++ b/spec/lib/open_project/plugins/module_handler_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe OpenProject::Plugins::ModuleHandler do +RSpec.describe OpenProject::Plugins::ModuleHandler do let!(:all_former_permissions) { OpenProject::AccessControl.permissions } before do diff --git a/spec/lib/open_project/scm/adapters/git_adapter_spec.rb b/spec/lib/open_project/scm/adapters/git_adapter_spec.rb index ea7a8ed173a..d04f390f96b 100644 --- a/spec/lib/open_project/scm/adapters/git_adapter_spec.rb +++ b/spec/lib/open_project/scm/adapters/git_adapter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::SCM::Adapters::Git do +RSpec.describe OpenProject::SCM::Adapters::Git do shared_examples "git adapter specs" do let(:protocol) { "" } let(:url) { protocol + Rails.root.join('/tmp/does/not/exist.git').to_s } diff --git a/spec/lib/open_project/scm/adapters/subversion_adapter_spec.rb b/spec/lib/open_project/scm/adapters/subversion_adapter_spec.rb index 603f3d63d61..fa124c7b135 100644 --- a/spec/lib/open_project/scm/adapters/subversion_adapter_spec.rb +++ b/spec/lib/open_project/scm/adapters/subversion_adapter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::SCM::Adapters::Subversion do +RSpec.describe OpenProject::SCM::Adapters::Subversion do let(:root_url) { '/tmp/bar.svn' } let(:url) { "file://#{root_url}" } let(:config) { {} } diff --git a/spec/lib/open_project/scm/manager_spec.rb b/spec/lib/open_project/scm/manager_spec.rb index 39d93ffabbd..e768dde917b 100644 --- a/spec/lib/open_project/scm/manager_spec.rb +++ b/spec/lib/open_project/scm/manager_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::SCM::Manager do +RSpec.describe OpenProject::SCM::Manager do let(:vendor) { 'TestScm' } let(:scm_class) { Class.new } diff --git a/spec/lib/open_project/static_routing_spec.rb b/spec/lib/open_project/static_routing_spec.rb index c9d57343e28..41381a372d8 100644 --- a/spec/lib/open_project/static_routing_spec.rb +++ b/spec/lib/open_project/static_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::StaticRouting do +RSpec.describe OpenProject::StaticRouting do describe '.recognize_route' do subject { described_class.recognize_route path } diff --git a/spec/lib/open_project/storage_spec.rb b/spec/lib/open_project/storage_spec.rb index cd19ad20554..1fc14fe2a03 100644 --- a/spec/lib/open_project/storage_spec.rb +++ b/spec/lib/open_project/storage_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::Storage do +RSpec.describe OpenProject::Storage do before do allow(Setting).to receive(:enabled_scm).and_return(enabled_scms) allow(OpenProject::Configuration).to receive(:[]).and_call_original diff --git a/spec/lib/open_project/text_formatting/markdown/attribute_macros_spec.rb b/spec/lib/open_project/text_formatting/markdown/attribute_macros_spec.rb index 52f353ebb03..143ba65dd9d 100644 --- a/spec/lib/open_project/text_formatting/markdown/attribute_macros_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/attribute_macros_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting, - 'Attribute macros' do +RSpec.describe OpenProject::TextFormatting, + 'Attribute macros' do include_context 'expected markdown modules' describe 'attribute label macros' do diff --git a/spec/lib/open_project/text_formatting/markdown/blockquote_spec.rb b/spec/lib/open_project/text_formatting/markdown/blockquote_spec.rb index 216c0d12720..98a5ec2247e 100644 --- a/spec/lib/open_project/text_formatting/markdown/blockquote_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/blockquote_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting, - 'blockquote' do +RSpec.describe OpenProject::TextFormatting, + 'blockquote' do include_context 'expected markdown modules' it_behaves_like 'format_text produces' do diff --git a/spec/lib/open_project/text_formatting/markdown/child_pages_macro_spec.rb b/spec/lib/open_project/text_formatting/markdown/child_pages_macro_spec.rb index e08b9604865..fb32e80aa05 100644 --- a/spec/lib/open_project/text_formatting/markdown/child_pages_macro_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/child_pages_macro_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'OpenProject child pages macro' do +RSpec.describe 'OpenProject child pages macro' do include ActionView::Helpers::UrlHelper include OpenProject::StaticRouting::UrlHelpers include OpenProject::TextFormatting diff --git a/spec/lib/open_project/text_formatting/markdown/code_spec.rb b/spec/lib/open_project/text_formatting/markdown/code_spec.rb index a7d36db1e1d..6790541de9f 100644 --- a/spec/lib/open_project/text_formatting/markdown/code_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/code_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting, - 'code' do +RSpec.describe OpenProject::TextFormatting, + 'code' do include_context 'expected markdown modules' context 'inline code' do diff --git a/spec/lib/open_project/text_formatting/markdown/embedded_table_macro_spec.rb b/spec/lib/open_project/text_formatting/markdown/embedded_table_macro_spec.rb index 96358078a0e..9fa9dd25594 100644 --- a/spec/lib/open_project/text_formatting/markdown/embedded_table_macro_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/embedded_table_macro_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting, - 'toc macro' do +RSpec.describe OpenProject::TextFormatting, + 'toc macro' do include_context 'expected markdown modules' it_behaves_like 'format_text produces' do diff --git a/spec/lib/open_project/text_formatting/markdown/expected_markdown.rb b/spec/lib/open_project/text_formatting/markdown/expected_markdown.rb index 8bed5f497a2..baf274fbbdb 100644 --- a/spec/lib/open_project/text_formatting/markdown/expected_markdown.rb +++ b/spec/lib/open_project/text_formatting/markdown/expected_markdown.rb @@ -1,4 +1,4 @@ -shared_context 'expected markdown modules' do +RSpec.shared_context 'expected markdown modules' do include OpenProject::TextFormatting include ERB::Util include WorkPackagesHelper # soft-dependency @@ -11,7 +11,7 @@ shared_context 'expected markdown modules' do end end -shared_examples_for 'format_text produces' do +RSpec.shared_examples_for 'format_text produces' do let(:passed_options) { defined?(options) ? options : {} } subject { format_text(raw, passed_options) } diff --git a/spec/lib/open_project/text_formatting/markdown/headings_spec.rb b/spec/lib/open_project/text_formatting/markdown/headings_spec.rb index a352c938944..48d7c38a4f9 100644 --- a/spec/lib/open_project/text_formatting/markdown/headings_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/headings_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting, - 'headings' do +RSpec.describe OpenProject::TextFormatting, + 'headings' do include_context 'expected markdown modules' describe '.format_text' do diff --git a/spec/lib/open_project/text_formatting/markdown/images_spec.rb b/spec/lib/open_project/text_formatting/markdown/images_spec.rb index 1b241e5b741..4aca9d9f9d2 100644 --- a/spec/lib/open_project/text_formatting/markdown/images_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/images_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting, - 'images' do +RSpec.describe OpenProject::TextFormatting, + 'images' do include_context 'expected markdown modules' let(:options) { {} } diff --git a/spec/lib/open_project/text_formatting/markdown/in_tool_links_spec.rb b/spec/lib/open_project/text_formatting/markdown/in_tool_links_spec.rb index f0d6197ce19..18cbd6c36da 100644 --- a/spec/lib/open_project/text_formatting/markdown/in_tool_links_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/in_tool_links_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting, - 'in tool links' do +RSpec.describe OpenProject::TextFormatting, + 'in tool links' do include_context 'expected markdown modules' describe '.format_text' do diff --git a/spec/lib/open_project/text_formatting/markdown/include_wiki_page_macro_spec.rb b/spec/lib/open_project/text_formatting/markdown/include_wiki_page_macro_spec.rb index 801058b8dda..93339e1384b 100644 --- a/spec/lib/open_project/text_formatting/markdown/include_wiki_page_macro_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/include_wiki_page_macro_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'OpenProject include wiki page macro' do +RSpec.describe 'OpenProject include wiki page macro' do include ActionView::Helpers::UrlHelper include OpenProject::StaticRouting::UrlHelpers include OpenProject::TextFormatting diff --git a/spec/lib/open_project/text_formatting/markdown/lists_spec.rb b/spec/lib/open_project/text_formatting/markdown/lists_spec.rb index 44571f19bea..097fd100f4f 100644 --- a/spec/lib/open_project/text_formatting/markdown/lists_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/lists_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting, - 'lists' do +RSpec.describe OpenProject::TextFormatting, + 'lists' do include_context 'expected markdown modules' context 'ordered lists' do diff --git a/spec/lib/open_project/text_formatting/markdown/markdown_formatting_spec.rb b/spec/lib/open_project/text_formatting/markdown/markdown_formatting_spec.rb index aeddb3bcc9a..96199ac17e0 100644 --- a/spec/lib/open_project/text_formatting/markdown/markdown_formatting_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/markdown_formatting_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting::Formats::Markdown::Formatter do +RSpec.describe OpenProject::TextFormatting::Formats::Markdown::Formatter do it 'modifierses' do assert_html_output( '**bold**' => 'bold', diff --git a/spec/lib/open_project/text_formatting/markdown/mentions_spec.rb b/spec/lib/open_project/text_formatting/markdown/mentions_spec.rb index 27609f843d0..7d0390d0b93 100644 --- a/spec/lib/open_project/text_formatting/markdown/mentions_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/mentions_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting, - 'mentions' do +RSpec.describe OpenProject::TextFormatting, + 'mentions' do include_context 'expected markdown modules' describe '.format_text' do diff --git a/spec/lib/open_project/text_formatting/markdown/pandoc_wrapper_spec.rb b/spec/lib/open_project/text_formatting/markdown/pandoc_wrapper_spec.rb index 6efe99e75a7..d5d40ccffb5 100644 --- a/spec/lib/open_project/text_formatting/markdown/pandoc_wrapper_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/pandoc_wrapper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::TextFormatting::Formats::Markdown::PandocWrapper do +RSpec.describe OpenProject::TextFormatting::Formats::Markdown::PandocWrapper do let(:subject) { described_class.new } before do diff --git a/spec/lib/open_project/text_formatting/markdown/paragraphs_spec.rb b/spec/lib/open_project/text_formatting/markdown/paragraphs_spec.rb index 3eebb797778..d432d97bba5 100644 --- a/spec/lib/open_project/text_formatting/markdown/paragraphs_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/paragraphs_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting, - 'paragraphs' do +RSpec.describe OpenProject::TextFormatting, + 'paragraphs' do include_context 'expected markdown modules' it_behaves_like 'format_text produces' do diff --git a/spec/lib/open_project/text_formatting/markdown/setting_variable_spec.rb b/spec/lib/open_project/text_formatting/markdown/setting_variable_spec.rb index c2155f7460b..6b935c951f3 100644 --- a/spec/lib/open_project/text_formatting/markdown/setting_variable_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/setting_variable_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting, - 'Setting variable' do +RSpec.describe OpenProject::TextFormatting, + 'Setting variable' do include_context 'expected markdown modules' describe 'attribute label macros' do diff --git a/spec/lib/open_project/text_formatting/markdown/tables_spec.rb b/spec/lib/open_project/text_formatting/markdown/tables_spec.rb index 162d3e0b8bd..4f500bffd4e 100644 --- a/spec/lib/open_project/text_formatting/markdown/tables_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/tables_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting, - 'tables' do +RSpec.describe OpenProject::TextFormatting, + 'tables' do include_context 'expected markdown modules' context 'for a markdown table' do diff --git a/spec/lib/open_project/text_formatting/markdown/toc_macro_spec.rb b/spec/lib/open_project/text_formatting/markdown/toc_macro_spec.rb index 7dbe701b25f..dfc39a495d9 100644 --- a/spec/lib/open_project/text_formatting/markdown/toc_macro_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/toc_macro_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting, - 'toc macro' do +RSpec.describe OpenProject::TextFormatting, + 'toc macro' do include_context 'expected markdown modules' it_behaves_like 'format_text produces' do diff --git a/spec/lib/open_project/text_formatting/markdown/user_provided_links_spec.rb b/spec/lib/open_project/text_formatting/markdown/user_provided_links_spec.rb index 8e2c83e5b42..5d017adde31 100644 --- a/spec/lib/open_project/text_formatting/markdown/user_provided_links_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/user_provided_links_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting, - 'user provided links' do +RSpec.describe OpenProject::TextFormatting, + 'user provided links' do include_context 'expected markdown modules' context 'hardened against tabnabbing' do diff --git a/spec/lib/open_project/text_formatting/markdown/work_package_buttons_macro_spec.rb b/spec/lib/open_project/text_formatting/markdown/work_package_buttons_macro_spec.rb index 015cd7f5f87..1e08f0ae7e9 100644 --- a/spec/lib/open_project/text_formatting/markdown/work_package_buttons_macro_spec.rb +++ b/spec/lib/open_project/text_formatting/markdown/work_package_buttons_macro_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require_relative './expected_markdown' -describe OpenProject::TextFormatting, - 'work package button macro' do +RSpec.describe OpenProject::TextFormatting, + 'work package button macro' do include_context 'expected markdown modules' shared_let(:admin) { create(:admin) } diff --git a/spec/lib/open_project/text_formatting/plain_spec.rb b/spec/lib/open_project/text_formatting/plain_spec.rb index b959d6d1164..7c4e2a6cd5a 100644 --- a/spec/lib/open_project/text_formatting/plain_spec.rb +++ b/spec/lib/open_project/text_formatting/plain_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OpenProject::TextFormatting::Formats::Plain::Formatter do +RSpec.describe OpenProject::TextFormatting::Formats::Plain::Formatter do subject { described_class.new({}) } it 'plains text' do diff --git a/spec/lib/open_project/text_formatting/text_formatting_spec.rb b/spec/lib/open_project/text_formatting/text_formatting_spec.rb index b3f25efdae1..72377f3a21d 100644 --- a/spec/lib/open_project/text_formatting/text_formatting_spec.rb +++ b/spec/lib/open_project/text_formatting/text_formatting_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe OpenProject::TextFormatting do +RSpec.describe OpenProject::TextFormatting do include OpenProject::TextFormatting it 'markdowns formatter' do diff --git a/spec/lib/redmine/i18n_spec.rb b/spec/lib/redmine/i18n_spec.rb index 2737429cf2b..9795dbfad95 100644 --- a/spec/lib/redmine/i18n_spec.rb +++ b/spec/lib/redmine/i18n_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' module OpenProject - describe I18n, type: :helper do + RSpec.describe I18n, type: :helper do include Redmine::I18n let(:format) { '%d/%m/%Y' } diff --git a/spec/lib/redmine/menu_manager/mapper_spec.rb b/spec/lib/redmine/menu_manager/mapper_spec.rb index abbfe2c4b6e..8574a7e25a6 100644 --- a/spec/lib/redmine/menu_manager/mapper_spec.rb +++ b/spec/lib/redmine/menu_manager/mapper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Redmine::MenuManager::Mapper do +RSpec.describe Redmine::MenuManager::Mapper do let(:mapper) { described_class.new(:test_menu, {}) } shared_context 'with a single node pushed to root' do diff --git a/spec/lib/redmine/menu_manager/menu_helper_spec.rb b/spec/lib/redmine/menu_manager/menu_helper_spec.rb index 82726cbffba..b581a9db47c 100644 --- a/spec/lib/redmine/menu_manager/menu_helper_spec.rb +++ b/spec/lib/redmine/menu_manager/menu_helper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Redmine::MenuManager::MenuHelper, type: :helper do +RSpec.describe Redmine::MenuManager::MenuHelper, type: :helper do before do # Stub the current menu item in the controller def @controller.current_menu_item diff --git a/spec/lib/redmine/menu_manager/menu_item_spec.rb b/spec/lib/redmine/menu_manager/menu_item_spec.rb index f4ee3331b4c..50bfeea123e 100644 --- a/spec/lib/redmine/menu_manager/menu_item_spec.rb +++ b/spec/lib/redmine/menu_manager/menu_item_spec.rb @@ -26,7 +26,7 @@ require 'spec_helper' -describe Redmine::MenuManager::MenuItem do +RSpec.describe Redmine::MenuManager::MenuItem do describe '.new' do it 'creates an item with all required parameters' do expect(described_class.new(:test_good_menu, '/test', {})) diff --git a/spec/lib/redmine/menu_manager_spec.rb b/spec/lib/redmine/menu_manager_spec.rb index b57017ab5d7..ef1c2d792cb 100644 --- a/spec/lib/redmine/menu_manager_spec.rb +++ b/spec/lib/redmine/menu_manager_spec.rb @@ -26,7 +26,7 @@ require 'spec_helper' -describe Redmine::MenuManager do +RSpec.describe Redmine::MenuManager do describe '.items' do context 'for the top_menu' do it 'includes the expected items' do diff --git a/spec/lib/redmine/plugin_spec.rb b/spec/lib/redmine/plugin_spec.rb index f9dfe28d6d1..3c667260a56 100644 --- a/spec/lib/redmine/plugin_spec.rb +++ b/spec/lib/redmine/plugin_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Redmine::Plugin do +RSpec.describe Redmine::Plugin do let!(:registered_plugins) { described_class.instance_variable_get(:@registered_plugins) } before do diff --git a/spec/lib/redmine/unified_diff_spec.rb b/spec/lib/redmine/unified_diff_spec.rb index 70f860a4f73..b76bfd52e33 100644 --- a/spec/lib/redmine/unified_diff_spec.rb +++ b/spec/lib/redmine/unified_diff_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Redmine::UnifiedDiff do +RSpec.describe Redmine::UnifiedDiff do let(:diff_options) { {} } let(:instance) { described_class.new(diff, diff_options) } diff --git a/spec/lib/representable_spec.rb b/spec/lib/representable_spec.rb index b04b42f8afb..b19b63fd513 100644 --- a/spec/lib/representable_spec.rb +++ b/spec/lib/representable_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'representable/json' -describe Representable do +RSpec.describe Representable do let(:object) { Struct.new(:title).new('test') } class ReverseNamingStrategy diff --git a/spec/lib/tabular_form_builder_spec.rb b/spec/lib/tabular_form_builder_spec.rb index f5e1ab013a2..71bf4d1726f 100644 --- a/spec/lib/tabular_form_builder_spec.rb +++ b/spec/lib/tabular_form_builder_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'ostruct' -describe TabularFormBuilder do +RSpec.describe TabularFormBuilder do include Capybara::RSpecMatchers let(:helper) { ActionView::Base.new(ActionView::LookupContext.new(''), {}, nil) } diff --git a/spec/mailers/announcement_mailer_spec.rb b/spec/mailers/announcement_mailer_spec.rb index 3359736a382..fe20ba08332 100644 --- a/spec/mailers/announcement_mailer_spec.rb +++ b/spec/mailers/announcement_mailer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe AnnouncementMailer do +RSpec.describe AnnouncementMailer do let(:announcement_subject) { 'Some subject' } let(:recipient) { build_stubbed(:user) } let(:announcement_body) { 'Some body text' } diff --git a/spec/mailers/digest_mailer_spec.rb b/spec/mailers/digest_mailer_spec.rb index 21884996662..c2527f111a4 100644 --- a/spec/mailers/digest_mailer_spec.rb +++ b/spec/mailers/digest_mailer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe DigestMailer do +RSpec.describe DigestMailer do include OpenProject::ObjectLinking include ActionView::Helpers::UrlHelper include OpenProject::StaticRouting::UrlHelpers diff --git a/spec/mailers/member_mailer_spec.rb b/spec/mailers/member_mailer_spec.rb index ee15e4c64a8..d9037960ab0 100644 --- a/spec/mailers/member_mailer_spec.rb +++ b/spec/mailers/member_mailer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe MemberMailer do +RSpec.describe MemberMailer do include OpenProject::ObjectLinking include ActionView::Helpers::UrlHelper include OpenProject::StaticRouting::UrlHelpers diff --git a/spec/mailers/shared_examples.rb b/spec/mailers/shared_examples.rb index 0badd1048c6..15c9a781d7f 100644 --- a/spec/mailers/shared_examples.rb +++ b/spec/mailers/shared_examples.rb @@ -1,4 +1,4 @@ -shared_examples_for 'mail is sent' do +RSpec.shared_examples_for 'mail is sent' do let(:letters_sent_count) { 1 } let(:mail) { deliveries.first } let(:html_body) { mail.body.parts.detect { |p| p.content_type.include? 'text/html' }.body.encoded } @@ -16,13 +16,13 @@ shared_examples_for 'mail is sent' do end end -shared_examples_for 'multiple mails are sent' do |set_letters_sent_count| +RSpec.shared_examples_for 'multiple mails are sent' do |set_letters_sent_count| it_behaves_like 'mail is sent' do let(:letters_sent_count) { set_letters_sent_count } end end -shared_examples_for 'mail is not sent' do +RSpec.shared_examples_for 'mail is not sent' do it 'sends no mail' do expect(deliveries).to be_empty end diff --git a/spec/mailers/smtp_settings_spec.rb b/spec/mailers/smtp_settings_spec.rb index 0f3638db964..fc5cb841a60 100644 --- a/spec/mailers/smtp_settings_spec.rb +++ b/spec/mailers/smtp_settings_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe "SMTP settings" do +RSpec.describe "SMTP settings" do let(:smtp_settings) { {} } let(:enable_starttls_auto) { nil } let(:openssl_verify_mode) { nil } diff --git a/spec/mailers/user_mailer_spec.rb b/spec/mailers/user_mailer_spec.rb index 8200a2306b4..313b38517dd 100644 --- a/spec/mailers/user_mailer_spec.rb +++ b/spec/mailers/user_mailer_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_examples' -describe UserMailer do +RSpec.describe UserMailer do subject(:deliveries) { ActionMailer::Base.deliveries } let(:type_standard) { build_stubbed(:type_standard) } diff --git a/spec/mailers/work_package_mailer_spec.rb b/spec/mailers/work_package_mailer_spec.rb index 80ecdf76153..d3c27fa6034 100644 --- a/spec/mailers/work_package_mailer_spec.rb +++ b/spec/mailers/work_package_mailer_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './shared_examples' -describe WorkPackageMailer do +RSpec.describe WorkPackageMailer do include OpenProject::ObjectLinking include ActionView::Helpers::UrlHelper include OpenProject::StaticRouting::UrlHelpers diff --git a/spec/migrations/migrate_team_planner_permissions_spec.rb b/spec/migrations/migrate_team_planner_permissions_spec.rb index 48e0edd2963..076e2353cdc 100644 --- a/spec/migrations/migrate_team_planner_permissions_spec.rb +++ b/spec/migrations/migrate_team_planner_permissions_spec.rb @@ -29,7 +29,7 @@ require Rails.root.join("db/migrate/20220414085531_migrate_team_planner_permissions.rb") require 'spec_helper' -describe MigrateTeamPlannerPermissions, type: :model do +RSpec.describe MigrateTeamPlannerPermissions, type: :model do # Silencing migration logs, since we are not interested in that during testing subject { ActiveRecord::Migration.suppress_messages { described_class.new.up } } diff --git a/spec/migrations/restore_defaults_on_empty_settings_spec.rb b/spec/migrations/restore_defaults_on_empty_settings_spec.rb index 07376da7e70..5e280e7c8bd 100644 --- a/spec/migrations/restore_defaults_on_empty_settings_spec.rb +++ b/spec/migrations/restore_defaults_on_empty_settings_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require Rails.root.join("db/migrate/20220428071221_restore_defaults_on_empty_settings.rb") -describe RestoreDefaultsOnEmptySettings, type: :model do +RSpec.describe RestoreDefaultsOnEmptySettings, type: :model do # Silencing migration logs, since we are not interested in that during testing subject(:run_migration) { ActiveRecord::Migration.suppress_messages { described_class.new.up } } diff --git a/spec/models/actions/scopes/default_spec.rb b/spec/models/actions/scopes/default_spec.rb index 1ab2fc69b57..1d4dfbc4ec2 100644 --- a/spec/models/actions/scopes/default_spec.rb +++ b/spec/models/actions/scopes/default_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Actions::Scopes::Default do +RSpec.describe Actions::Scopes::Default do subject(:scope) { Action.default } describe '.default' do diff --git a/spec/models/activities/fetcher_integration_spec.rb b/spec/models/activities/fetcher_integration_spec.rb index 1ab4357381c..106f4311853 100644 --- a/spec/models/activities/fetcher_integration_spec.rb +++ b/spec/models/activities/fetcher_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Activities::Fetcher, 'integration' do +RSpec.describe Activities::Fetcher, 'integration' do shared_let(:user) { create(:user) } shared_let(:permissions) { %i[view_work_packages view_time_entries view_changesets view_wiki_edits] } shared_let(:role) { create(:role, permissions:) } diff --git a/spec/models/activities/work_package_activity_provider_spec.rb b/spec/models/activities/work_package_activity_provider_spec.rb index 13c9de20ca0..c0c34e72b3e 100644 --- a/spec/models/activities/work_package_activity_provider_spec.rb +++ b/spec/models/activities/work_package_activity_provider_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Activities::WorkPackageActivityProvider do +RSpec.describe Activities::WorkPackageActivityProvider do let(:event_scope) { 'work_packages' } let(:work_package_edit_event) { 'work_package-edit' } let(:work_package_closed_event) { 'work_package-closed' } diff --git a/spec/models/announcement_spec.rb b/spec/models/announcement_spec.rb index 2c6a8ff8c8a..57f4137e4fb 100644 --- a/spec/models/announcement_spec.rb +++ b/spec/models/announcement_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Announcement do +RSpec.describe Announcement do it do is_expected.to respond_to :text end it do is_expected.to respond_to :text= end it do is_expected.to respond_to :show_until end diff --git a/spec/models/application_record_spec.rb b/spec/models/application_record_spec.rb index 3c90ae7f1fd..2a6e4a5b76d 100644 --- a/spec/models/application_record_spec.rb +++ b/spec/models/application_record_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe ApplicationRecord do +RSpec.describe ApplicationRecord do describe '#most_recently_changed' do let!(:work_package) do create(:work_package).tap do |wp| diff --git a/spec/models/attachment_spec.rb b/spec/models/attachment_spec.rb index 59a7c1fd50f..cf964fcaaf3 100644 --- a/spec/models/attachment_spec.rb +++ b/spec/models/attachment_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe Attachment do +RSpec.describe Attachment do let(:stubbed_author) { build_stubbed(:user) } let(:author) { create(:user) } let(:long_description) { 'a' * 300 } diff --git a/spec/models/attribute_help_text/work_package_spec.rb b/spec/models/attribute_help_text/work_package_spec.rb index b31f6712fe0..a4a0f836edc 100644 --- a/spec/models/attribute_help_text/work_package_spec.rb +++ b/spec/models/attribute_help_text/work_package_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe AttributeHelpText::WorkPackage do +RSpec.describe AttributeHelpText::WorkPackage do def create_cf_help_text(custom_field) # Need to clear the request store after every creation as the available attributes are cached RequestStore.clear! diff --git a/spec/models/capabilities/scopes/default_spec.rb b/spec/models/capabilities/scopes/default_spec.rb index 0c9e01bacc0..c78f7083727 100644 --- a/spec/models/capabilities/scopes/default_spec.rb +++ b/spec/models/capabilities/scopes/default_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Capabilities::Scopes::Default do +RSpec.describe Capabilities::Scopes::Default do # we focus on the non current user capabilities to make the tests easier to understand subject(:scope) { Capability.default.where(principal_id: user.id) } diff --git a/spec/models/category_spec.rb b/spec/models/category_spec.rb index 20f4afa83f2..ec059eb7a41 100644 --- a/spec/models/category_spec.rb +++ b/spec/models/category_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Category do +RSpec.describe Category do let(:project) { create(:project) } let(:created_category) { create(:category, project:, assigned_to: assignee) } let(:assignee) { nil } diff --git a/spec/models/changeset_spec.rb b/spec/models/changeset_spec.rb index c44d2a485c0..556d098eb36 100644 --- a/spec/models/changeset_spec.rb +++ b/spec/models/changeset_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Changeset do +RSpec.describe Changeset do let(:email) { 'bob@bobbit.org' } with_virtual_subversion_repository do diff --git a/spec/models/color_spec.rb b/spec/models/color_spec.rb index cb4659bca0e..287690eda66 100644 --- a/spec/models/color_spec.rb +++ b/spec/models/color_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Color do +RSpec.describe Color do describe '- Relations' do describe '#planning_element_types' do it 'can read planning_element_types w/ the help of the has_many association' do diff --git a/spec/models/comment_spec.rb b/spec/models/comment_spec.rb index 6764fa4b630..20c3028f315 100644 --- a/spec/models/comment_spec.rb +++ b/spec/models/comment_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe Comment do +RSpec.describe Comment do shared_let(:user) { create(:user) } shared_let(:news) { create(:news) } let(:comment) { described_class.new(author: user, comments: 'some important words', commented: news) } diff --git a/spec/models/custom_action_spec.rb b/spec/models/custom_action_spec.rb index c06d9c94332..350f7ad6c94 100644 --- a/spec/models/custom_action_spec.rb +++ b/spec/models/custom_action_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomAction do +RSpec.describe CustomAction do let(:stubbed_instance) { build_stubbed(:custom_action) } let(:instance) { create(:custom_action, name: 'zzzzzzzzz') } let(:other_instance) { create(:custom_action, name: 'aaaaa') } diff --git a/spec/models/custom_actions/actions/assigned_to_spec.rb b/spec/models/custom_actions/actions/assigned_to_spec.rb index 9e3f69e9e63..f78b1d0e431 100644 --- a/spec/models/custom_actions/actions/assigned_to_spec.rb +++ b/spec/models/custom_actions/actions/assigned_to_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Actions::AssignedTo do +RSpec.describe CustomActions::Actions::AssignedTo do let(:key) { :assigned_to } let(:type) { :associated_property } let(:allowed_values) do diff --git a/spec/models/custom_actions/actions/custom_field_spec.rb b/spec/models/custom_actions/actions/custom_field_spec.rb index cde6ac76d3b..508020fbd8e 100644 --- a/spec/models/custom_actions/actions/custom_field_spec.rb +++ b/spec/models/custom_actions/actions/custom_field_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Actions::CustomField do +RSpec.describe CustomActions::Actions::CustomField do let(:list_custom_field) do build_stubbed(:list_wp_custom_field, custom_options: [build_stubbed(:custom_option, value: 'A'), diff --git a/spec/models/custom_actions/actions/date_spec.rb b/spec/models/custom_actions/actions/date_spec.rb index 3d9125e6a84..f2d133787da 100644 --- a/spec/models/custom_actions/actions/date_spec.rb +++ b/spec/models/custom_actions/actions/date_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Actions::Date do +RSpec.describe CustomActions::Actions::Date do let(:key) { :date } let(:type) { :date_property } let(:value) { Date.today } diff --git a/spec/models/custom_actions/actions/done_ratio_spec.rb b/spec/models/custom_actions/actions/done_ratio_spec.rb index 0eed037f074..21a49d67c2e 100644 --- a/spec/models/custom_actions/actions/done_ratio_spec.rb +++ b/spec/models/custom_actions/actions/done_ratio_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Actions::DoneRatio do +RSpec.describe CustomActions::Actions::DoneRatio do let(:key) { :done_ratio } let(:type) { :integer_property } diff --git a/spec/models/custom_actions/actions/due_date_spec.rb b/spec/models/custom_actions/actions/due_date_spec.rb index 0095e06a9c4..62091274dad 100644 --- a/spec/models/custom_actions/actions/due_date_spec.rb +++ b/spec/models/custom_actions/actions/due_date_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Actions::DueDate do +RSpec.describe CustomActions::Actions::DueDate do let(:key) { :due_date } let(:type) { :date_property } let(:value) { Date.today } diff --git a/spec/models/custom_actions/actions/estimated_hours_spec.rb b/spec/models/custom_actions/actions/estimated_hours_spec.rb index 05fca4108c0..83657c9da0d 100644 --- a/spec/models/custom_actions/actions/estimated_hours_spec.rb +++ b/spec/models/custom_actions/actions/estimated_hours_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Actions::EstimatedHours do +RSpec.describe CustomActions::Actions::EstimatedHours do let(:key) { :estimated_hours } let(:type) { :float_property } let(:value) { 1.0 } diff --git a/spec/models/custom_actions/actions/notify_spec.rb b/spec/models/custom_actions/actions/notify_spec.rb index fb74ba9ce52..1779860c3ef 100644 --- a/spec/models/custom_actions/actions/notify_spec.rb +++ b/spec/models/custom_actions/actions/notify_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Actions::Notify do +RSpec.describe CustomActions::Actions::Notify do let(:key) { :notify } let(:type) { :associated_property } let(:allowed_values) do diff --git a/spec/models/custom_actions/actions/priority_spec.rb b/spec/models/custom_actions/actions/priority_spec.rb index 4ba334a6578..c58478647b5 100644 --- a/spec/models/custom_actions/actions/priority_spec.rb +++ b/spec/models/custom_actions/actions/priority_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Actions::Priority do +RSpec.describe CustomActions::Actions::Priority do let(:key) { :priority } let(:type) { :associated_property } let(:allowed_values) do diff --git a/spec/models/custom_actions/actions/project_spec.rb b/spec/models/custom_actions/actions/project_spec.rb index 034e45f3ab6..cc9dedfa854 100644 --- a/spec/models/custom_actions/actions/project_spec.rb +++ b/spec/models/custom_actions/actions/project_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Actions::Project do +RSpec.describe CustomActions::Actions::Project do let(:key) { :project } let(:type) { :associated_property } let(:priority) { 10 } diff --git a/spec/models/custom_actions/actions/responsible_spec.rb b/spec/models/custom_actions/actions/responsible_spec.rb index 4d561f5c7df..f79dddc9437 100644 --- a/spec/models/custom_actions/actions/responsible_spec.rb +++ b/spec/models/custom_actions/actions/responsible_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Actions::Responsible do +RSpec.describe CustomActions::Actions::Responsible do let(:key) { :responsible } let(:type) { :associated_property } let(:allowed_values) do diff --git a/spec/models/custom_actions/actions/start_date_spec.rb b/spec/models/custom_actions/actions/start_date_spec.rb index adfa9fab74d..6fd66a05717 100644 --- a/spec/models/custom_actions/actions/start_date_spec.rb +++ b/spec/models/custom_actions/actions/start_date_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Actions::StartDate do +RSpec.describe CustomActions::Actions::StartDate do let(:key) { :start_date } let(:type) { :date_property } let(:value) { Date.today } diff --git a/spec/models/custom_actions/actions/status_spec.rb b/spec/models/custom_actions/actions/status_spec.rb index ebdd701a4c8..504dbfa31f3 100644 --- a/spec/models/custom_actions/actions/status_spec.rb +++ b/spec/models/custom_actions/actions/status_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Actions::Status do +RSpec.describe CustomActions::Actions::Status do let(:key) { :status } let(:type) { :associated_property } let(:allowed_values) do diff --git a/spec/models/custom_actions/actions/type_spec.rb b/spec/models/custom_actions/actions/type_spec.rb index 65d8f80869b..faa281962b6 100644 --- a/spec/models/custom_actions/actions/type_spec.rb +++ b/spec/models/custom_actions/actions/type_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Actions::Type do +RSpec.describe CustomActions::Actions::Type do let(:key) { :type } let(:priority) { 20 } let(:type) { :associated_property } diff --git a/spec/models/custom_actions/conditions/project_spec.rb b/spec/models/custom_actions/conditions/project_spec.rb index e2576660219..4a18e4d7b06 100644 --- a/spec/models/custom_actions/conditions/project_spec.rb +++ b/spec/models/custom_actions/conditions/project_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Conditions::Project do +RSpec.describe CustomActions::Conditions::Project do it_behaves_like 'associated custom condition' do let(:key) { :project } diff --git a/spec/models/custom_actions/conditions/role_spec.rb b/spec/models/custom_actions/conditions/role_spec.rb index a347dfd8428..9ce8c5c4065 100644 --- a/spec/models/custom_actions/conditions/role_spec.rb +++ b/spec/models/custom_actions/conditions/role_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Conditions::Role do +RSpec.describe CustomActions::Conditions::Role do it_behaves_like 'associated custom condition' do let(:key) { :role } diff --git a/spec/models/custom_actions/conditions/status_spec.rb b/spec/models/custom_actions/conditions/status_spec.rb index b18534cd5ee..c4699d51d6b 100644 --- a/spec/models/custom_actions/conditions/status_spec.rb +++ b/spec/models/custom_actions/conditions/status_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Conditions::Status do +RSpec.describe CustomActions::Conditions::Status do it_behaves_like 'associated custom condition' do let(:key) { :status } diff --git a/spec/models/custom_actions/conditions/type_spec.rb b/spec/models/custom_actions/conditions/type_spec.rb index 75f0f4d0808..621a34c9c97 100644 --- a/spec/models/custom_actions/conditions/type_spec.rb +++ b/spec/models/custom_actions/conditions/type_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative '../shared_expectations' -describe CustomActions::Conditions::Type do +RSpec.describe CustomActions::Conditions::Type do it_behaves_like 'associated custom condition' do let(:key) { :type } diff --git a/spec/models/custom_actions/shared_expectations.rb b/spec/models/custom_actions/shared_expectations.rb index 733f142dcad..9a4fc291121 100644 --- a/spec/models/custom_actions/shared_expectations.rb +++ b/spec/models/custom_actions/shared_expectations.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_context 'custom actions action' do +RSpec.shared_context 'custom actions action' do let(:instance) do described_class.new end @@ -46,7 +46,7 @@ shared_context 'custom actions action' do end end -shared_examples_for 'base custom action' do +RSpec.shared_examples_for 'base custom action' do include_context 'custom actions action' let(:expected_priority) do if defined?(priority) @@ -122,7 +122,7 @@ shared_examples_for 'base custom action' do end end -shared_examples_for 'associated custom action' do +RSpec.shared_examples_for 'associated custom action' do include_context 'custom actions action' do describe '#apply' do let(:work_package) { build_stubbed(:work_package) } @@ -142,7 +142,7 @@ shared_examples_for 'associated custom action' do end end -shared_examples_for 'associated custom action validations' do +RSpec.shared_examples_for 'associated custom action validations' do describe '#validate' do let(:errors) do build_stubbed(:custom_action).errors @@ -189,7 +189,7 @@ shared_examples_for 'associated custom action validations' do end end -shared_examples_for 'bool custom action validations' do +RSpec.shared_examples_for 'bool custom action validations' do describe '#validate' do let(:errors) do build_stubbed(:custom_action).errors @@ -234,7 +234,7 @@ shared_examples_for 'bool custom action validations' do end end -shared_examples_for 'int custom action validations' do +RSpec.shared_examples_for 'int custom action validations' do describe '#validate' do let(:errors) do build_stubbed(:custom_action).errors @@ -270,7 +270,7 @@ shared_examples_for 'int custom action validations' do end end -shared_examples_for 'float custom action validations' do +RSpec.shared_examples_for 'float custom action validations' do describe '#validate' do let(:errors) do build_stubbed(:custom_action).errors @@ -306,7 +306,7 @@ shared_examples_for 'float custom action validations' do end end -shared_examples_for 'string custom action validations' do +RSpec.shared_examples_for 'string custom action validations' do describe '#validate' do let(:errors) do build_stubbed(:custom_action).errors @@ -342,11 +342,11 @@ shared_examples_for 'string custom action validations' do end end -shared_examples_for 'text custom action validations' do +RSpec.shared_examples_for 'text custom action validations' do it_behaves_like 'string custom action validations' end -shared_examples_for 'date custom action validations' do +RSpec.shared_examples_for 'date custom action validations' do describe '#validate' do let(:errors) do build_stubbed(:custom_action).errors @@ -382,11 +382,11 @@ shared_examples_for 'date custom action validations' do end end -shared_examples_for 'associated values transformation' do +RSpec.shared_examples_for 'associated values transformation' do it_behaves_like 'int values transformation' end -shared_examples_for 'int values transformation' do +RSpec.shared_examples_for 'int values transformation' do describe '#values' do it 'transforms the values to integers' do instance.values = [42, nil, '23', 'some bogus', '12.34234', '42a34e324r32'] @@ -397,7 +397,7 @@ shared_examples_for 'int values transformation' do end end -shared_examples_for 'float values transformation' do +RSpec.shared_examples_for 'float values transformation' do describe '#values' do it 'transforms the values to integers' do instance.values = [42, nil, '23', 'some bogus', '12.34234', '42a34e324r32'] @@ -408,7 +408,7 @@ shared_examples_for 'float values transformation' do end end -shared_examples_for 'string values transformation' do +RSpec.shared_examples_for 'string values transformation' do describe '#values' do it 'transforms the values to integers' do instance.values = [42, nil, '23', 'some bogus', '12.34234', '42a34e324r32'] @@ -419,7 +419,7 @@ shared_examples_for 'string values transformation' do end end -shared_examples_for 'text values transformation' do +RSpec.shared_examples_for 'text values transformation' do describe '#values' do it 'transforms the values to integers' do instance.values = [42, nil, '23', 'some bogus', '12.34234', '42a34e324r32'] @@ -430,7 +430,7 @@ shared_examples_for 'text values transformation' do end end -shared_examples_for 'date values transformation' do +RSpec.shared_examples_for 'date values transformation' do describe '#values' do it 'transforms the values to integers' do instance.values = ["2015-03-29", Date.today, nil, (Date.today - 1.day).to_datetime, 'bogus', '%CURRENT_DATE%'] @@ -441,7 +441,7 @@ shared_examples_for 'date values transformation' do end end -shared_examples_for 'associated custom condition' do +RSpec.shared_examples_for 'associated custom condition' do let(:instance) do described_class.new end @@ -508,7 +508,7 @@ shared_examples_for 'associated custom condition' do end end -shared_examples_for 'date custom action apply' do +RSpec.shared_examples_for 'date custom action apply' do describe '#apply' do let(:work_package) { build_stubbed(:work_package) } diff --git a/spec/models/custom_field_spec.rb b/spec/models/custom_field_spec.rb index 05de4a78890..7304c1853a8 100644 --- a/spec/models/custom_field_spec.rb +++ b/spec/models/custom_field_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomField do +RSpec.describe CustomField do before do described_class.destroy_all end diff --git a/spec/models/custom_option_spec.rb b/spec/models/custom_option_spec.rb index ef0fa2bdfec..a6b1d30e01d 100644 --- a/spec/models/custom_option_spec.rb +++ b/spec/models/custom_option_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomOption do +RSpec.describe CustomOption do let(:custom_field) do cf = build(:wp_custom_field, field_format: 'list') cf.custom_options.build(value: 'some value') diff --git a/spec/models/custom_value/bool_strategy_spec.rb b/spec/models/custom_value/bool_strategy_spec.rb index a8a63f72b5b..c6028b05269 100644 --- a/spec/models/custom_value/bool_strategy_spec.rb +++ b/spec/models/custom_value/bool_strategy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomValue::BoolStrategy do +RSpec.describe CustomValue::BoolStrategy do let(:instance) { described_class.new(custom_value) } let(:custom_value) do double('CustomValue', diff --git a/spec/models/custom_value/date_strategy_spec.rb b/spec/models/custom_value/date_strategy_spec.rb index 1bc2be38d86..032fef81f86 100644 --- a/spec/models/custom_value/date_strategy_spec.rb +++ b/spec/models/custom_value/date_strategy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomValue::DateStrategy do +RSpec.describe CustomValue::DateStrategy do let(:instance) { described_class.new(custom_value) } let(:custom_value) do double('CustomValue', diff --git a/spec/models/custom_value/float_strategy_spec.rb b/spec/models/custom_value/float_strategy_spec.rb index 52c7adea632..14234107496 100644 --- a/spec/models/custom_value/float_strategy_spec.rb +++ b/spec/models/custom_value/float_strategy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomValue::FloatStrategy do +RSpec.describe CustomValue::FloatStrategy do let(:instance) { described_class.new(custom_value) } let(:custom_value) do double('CustomValue', diff --git a/spec/models/custom_value/format_strategy_spec.rb b/spec/models/custom_value/format_strategy_spec.rb index 7b889fc4424..515236acd80 100644 --- a/spec/models/custom_value/format_strategy_spec.rb +++ b/spec/models/custom_value/format_strategy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomValue::FormatStrategy do +RSpec.describe CustomValue::FormatStrategy do let(:custom_value) do double('CustomValue', value:) diff --git a/spec/models/custom_value/int_strategy_spec.rb b/spec/models/custom_value/int_strategy_spec.rb index 11511d92c5b..5cd94a4048a 100644 --- a/spec/models/custom_value/int_strategy_spec.rb +++ b/spec/models/custom_value/int_strategy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomValue::IntStrategy do +RSpec.describe CustomValue::IntStrategy do let(:instance) { described_class.new(custom_value) } let(:custom_value) do double('CustomValue', diff --git a/spec/models/custom_value/list_strategy_integration_spec.rb b/spec/models/custom_value/list_strategy_integration_spec.rb index 795da855af7..4d710870705 100644 --- a/spec/models/custom_value/list_strategy_integration_spec.rb +++ b/spec/models/custom_value/list_strategy_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomValue::ListStrategy, 'integration tests' do +RSpec.describe CustomValue::ListStrategy, 'integration tests' do let(:type) { create(:type) } let(:project) { create(:project, types: [type]) } let!(:custom_field) do diff --git a/spec/models/custom_value/list_strategy_spec.rb b/spec/models/custom_value/list_strategy_spec.rb index 268a2dbbb4c..004753cda34 100644 --- a/spec/models/custom_value/list_strategy_spec.rb +++ b/spec/models/custom_value/list_strategy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomValue::ListStrategy do +RSpec.describe CustomValue::ListStrategy do let(:instance) { described_class.new(custom_value) } let(:custom_field) { create(:list_wp_custom_field) } let(:custom_value) do diff --git a/spec/models/custom_value/string_strategy_spec.rb b/spec/models/custom_value/string_strategy_spec.rb index a34986cdd21..9a9af6feb5b 100644 --- a/spec/models/custom_value/string_strategy_spec.rb +++ b/spec/models/custom_value/string_strategy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomValue::StringStrategy do +RSpec.describe CustomValue::StringStrategy do let(:instance) { described_class.new(custom_value) } let(:custom_value) do double('CustomValue', diff --git a/spec/models/custom_value/user_strategy_spec.rb b/spec/models/custom_value/user_strategy_spec.rb index ab811770e5a..339d5ac147b 100644 --- a/spec/models/custom_value/user_strategy_spec.rb +++ b/spec/models/custom_value/user_strategy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomValue::UserStrategy do +RSpec.describe CustomValue::UserStrategy do let(:instance) { described_class.new(custom_value) } let(:custom_value) do double('CustomValue', diff --git a/spec/models/custom_value/version_strategy_spec.rb b/spec/models/custom_value/version_strategy_spec.rb index 9d2ffefe81b..23bc126bec1 100644 --- a/spec/models/custom_value/version_strategy_spec.rb +++ b/spec/models/custom_value/version_strategy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomValue::VersionStrategy do +RSpec.describe CustomValue::VersionStrategy do let(:instance) { described_class.new(custom_value) } let(:custom_value) do double('CustomValue', diff --git a/spec/models/custom_value_spec.rb b/spec/models/custom_value_spec.rb index 2a3ac60e5d2..3caceb0a48a 100644 --- a/spec/models/custom_value_spec.rb +++ b/spec/models/custom_value_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomValue do +RSpec.describe CustomValue do shared_let(:version) { create(:version) } let(:format) { 'bool' } diff --git a/spec/models/day_spec.rb b/spec/models/day_spec.rb index a2888da03c2..7a3eec7a45b 100644 --- a/spec/models/day_spec.rb +++ b/spec/models/day_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Day do +RSpec.describe Day do shared_let(:week_days) { week_with_saturday_and_sunday_as_weekend } let(:today) { Date.current } let(:date_range) { Date.new(2022, 1, 1)..Date.new(2022, 2, 1) } diff --git a/spec/models/deleted_user_spec.rb b/spec/models/deleted_user_spec.rb index 68b5469f8a2..bd9a3a19274 100644 --- a/spec/models/deleted_user_spec.rb +++ b/spec/models/deleted_user_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe DeletedUser do +RSpec.describe DeletedUser do let(:user) { DeletedUser.new } describe '#admin' do diff --git a/spec/models/enabled_module_spec.rb b/spec/models/enabled_module_spec.rb index 3d96412038d..de0319c81e2 100644 --- a/spec/models/enabled_module_spec.rb +++ b/spec/models/enabled_module_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe EnabledModule do +RSpec.describe EnabledModule do # Force reload, as association is not always(?) showing let(:project) { create(:project, enabled_module_names: modules).reload } diff --git a/spec/models/forum_spec.rb b/spec/models/forum_spec.rb index dbb952b81d5..e160737a470 100644 --- a/spec/models/forum_spec.rb +++ b/spec/models/forum_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'support/shared/acts_as_watchable' -describe Forum do +RSpec.describe Forum do it_behaves_like 'acts_as_watchable included' do let(:model_instance) { create(:forum) } let(:watch_permission) { :view_messages } # view_messages is a public permission diff --git a/spec/models/global_role_spec.rb b/spec/models/global_role_spec.rb index 18403e0797d..13206aa67d4 100644 --- a/spec/models/global_role_spec.rb +++ b/spec/models/global_role_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe GlobalRole do +RSpec.describe GlobalRole do before { GlobalRole.create name: 'globalrole', permissions: ['permissions'] } it { is_expected.to validate_presence_of :name } diff --git a/spec/models/group_performance_spec.rb b/spec/models/group_performance_spec.rb index 1217a624dca..365d7df16ab 100644 --- a/spec/models/group_performance_spec.rb +++ b/spec/models/group_performance_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../support/shared/become_member' -describe Group do +RSpec.describe Group do include BecomeMember let(:user) { build(:user) } diff --git a/spec/models/group_spec.rb b/spec/models/group_spec.rb index fd02e56177c..715ced69696 100644 --- a/spec/models/group_spec.rb +++ b/spec/models/group_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../support/shared/become_member' -describe Group do +RSpec.describe Group do let(:group) { create(:group) } let(:user) { create(:user) } let(:watcher) { create(:user) } diff --git a/spec/models/issue_priority_spec.rb b/spec/models/issue_priority_spec.rb index 65946967cb7..82c337e2a1a 100644 --- a/spec/models/issue_priority_spec.rb +++ b/spec/models/issue_priority_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe IssuePriority do +RSpec.describe IssuePriority do shared_let(:priority) { create(:priority) } shared_let(:default_priority) { create(:default_priority) } diff --git a/spec/models/journable/historic_active_record_relation_spec.rb b/spec/models/journable/historic_active_record_relation_spec.rb index 8f800463528..b5206913e9e 100644 --- a/spec/models/journable/historic_active_record_relation_spec.rb +++ b/spec/models/journable/historic_active_record_relation_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Journable::HistoricActiveRecordRelation do +RSpec.describe Journable::HistoricActiveRecordRelation do # See: https://github.com/opf/openproject/pull/11243 let(:before_monday) { "2022-01-01".to_datetime } diff --git a/spec/models/journable/timestamps_spec.rb b/spec/models/journable/timestamps_spec.rb index 2a83cc8bad5..88b9a89cacd 100644 --- a/spec/models/journable/timestamps_spec.rb +++ b/spec/models/journable/timestamps_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Journable::Timestamps do +RSpec.describe Journable::Timestamps do # See: https://github.com/opf/openproject/pull/11243 let(:before_monday) { "2022-01-01".to_datetime } diff --git a/spec/models/journable/with_historic_attributes_spec.rb b/spec/models/journable/with_historic_attributes_spec.rb index 4d5e7de89f4..6ab328a3bd0 100644 --- a/spec/models/journable/with_historic_attributes_spec.rb +++ b/spec/models/journable/with_historic_attributes_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe Journable::WithHistoricAttributes, - with_ee: %i[baseline_comparison], with_flag: { show_changes: true } do +RSpec.describe Journable::WithHistoricAttributes, + with_ee: %i[baseline_comparison], with_flag: { show_changes: true } do create_shared_association_defaults_for_work_package_factory shared_let(:baseline_time) { "2022-01-01".to_time } diff --git a/spec/models/journal/notification_configuration_spec.rb b/spec/models/journal/notification_configuration_spec.rb index bc24294841d..110e1e24858 100644 --- a/spec/models/journal/notification_configuration_spec.rb +++ b/spec/models/journal/notification_configuration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Journal::NotificationConfiguration do +RSpec.describe Journal::NotificationConfiguration do describe '.with' do let!(:send_notification_before) { described_class.active? } let!(:proc_called_counter) { OpenStruct.new called: false, send_notifications: send_notification_before } diff --git a/spec/models/journal/timestamps_spec.rb b/spec/models/journal/timestamps_spec.rb index bd611611fb4..9f200dd7bd2 100644 --- a/spec/models/journal/timestamps_spec.rb +++ b/spec/models/journal/timestamps_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Journal::Timestamps do +RSpec.describe Journal::Timestamps do # See: https://github.com/opf/openproject/pull/11243 let!(:work_package) { create(:work_package) } diff --git a/spec/models/journal_spec.rb b/spec/models/journal_spec.rb index c137a8817aa..72dda4a7886 100644 --- a/spec/models/journal_spec.rb +++ b/spec/models/journal_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe Journal do +RSpec.describe Journal do describe '#journable' do it 'raises no error on a new journal without a journable' do expect(Journal.new.journable) diff --git a/spec/models/ldap_auth_source_spec.rb b/spec/models/ldap_auth_source_spec.rb index 0933ded64b6..7f03c5faac7 100644 --- a/spec/models/ldap_auth_source_spec.rb +++ b/spec/models/ldap_auth_source_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe LdapAuthSource do +RSpec.describe LdapAuthSource do it 'creates' do a = described_class.new(name: 'My LDAP', host: 'ldap.example.net', port: 389, base_dn: 'dc=example,dc=net', attr_login: 'sAMAccountName') diff --git a/spec/models/mail_handler/user_creator_spec.rb b/spec/models/mail_handler/user_creator_spec.rb index 0943b36f5d0..7479b2b9fff 100644 --- a/spec/models/mail_handler/user_creator_spec.rb +++ b/spec/models/mail_handler/user_creator_spec.rb @@ -26,7 +26,7 @@ require 'spec_helper' -describe MailHandler::UserCreator do +RSpec.describe MailHandler::UserCreator do describe '.new_user_from_attributes' do context 'with sufficient information' do # [address, name] => [login, firstname, lastname] diff --git a/spec/models/mail_handler_spec.rb b/spec/models/mail_handler_spec.rb index 61e15c0551a..2a7c5faa4fd 100644 --- a/spec/models/mail_handler_spec.rb +++ b/spec/models/mail_handler_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe MailHandler do +RSpec.describe MailHandler do let(:anno_user) { User.anonymous } let(:project) { create(:valid_project, identifier: 'onlinestore', name: 'OnlineStore', public: false) } let(:public_project) { create(:valid_project, identifier: 'onlinestore', name: 'OnlineStore', public: true) } diff --git a/spec/models/member_spec.rb b/spec/models/member_spec.rb index 52491bf4861..eb475a4e80b 100644 --- a/spec/models/member_spec.rb +++ b/spec/models/member_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Member do +RSpec.describe Member do let(:user) { create(:user) } let(:role) { create(:role) } let(:project) { create(:project) } diff --git a/spec/models/members/roles_diff_spec.rb b/spec/models/members/roles_diff_spec.rb index eadf8715223..58889912d8c 100644 --- a/spec/models/members/roles_diff_spec.rb +++ b/spec/models/members/roles_diff_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Members::RolesDiff do +RSpec.describe Members::RolesDiff do let(:project) { build_stubbed(:project) } let(:group) { build_stubbed(:group) } let(:user) { build_stubbed(:user) } diff --git a/spec/models/members/scopes/not_locked_spec.rb b/spec/models/members/scopes/not_locked_spec.rb index aed5467e534..78039a1326b 100644 --- a/spec/models/members/scopes/not_locked_spec.rb +++ b/spec/models/members/scopes/not_locked_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Members::Scopes::NotLocked do +RSpec.describe Members::Scopes::NotLocked do let(:project) { create(:project) } let(:role) { create(:role) } diff --git a/spec/models/menu_item_spec.rb b/spec/models/menu_item_spec.rb index ab51378e4c5..eee64fc50db 100644 --- a/spec/models/menu_item_spec.rb +++ b/spec/models/menu_item_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe MenuItem do +RSpec.describe MenuItem do describe 'validations' do let(:item) { build(:menu_item) } diff --git a/spec/models/menu_items/wiki_menu_item_spec.rb b/spec/models/menu_items/wiki_menu_item_spec.rb index e6d8dc67cc1..4070f015083 100644 --- a/spec/models/menu_items/wiki_menu_item_spec.rb +++ b/spec/models/menu_items/wiki_menu_item_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe MenuItems::WikiMenuItem do +RSpec.describe MenuItems::WikiMenuItem do before do @project = create(:project, enabled_module_names: %w[activity]) @current = create(:user, login: 'user1', mail: 'user1@users.com') diff --git a/spec/models/messages/acts_as_journalized_spec.rb b/spec/models/messages/acts_as_journalized_spec.rb index 36263d8e432..b5dd2b03a0a 100644 --- a/spec/models/messages/acts_as_journalized_spec.rb +++ b/spec/models/messages/acts_as_journalized_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Message, 'acts_as_journalized' do +RSpec.describe Message, 'acts_as_journalized' do let(:user) { create(:user) } let(:project) { create(:project) } let!(:forum) do diff --git a/spec/models/messages_spec.rb b/spec/models/messages_spec.rb index 1d586ddd647..66eb515b967 100644 --- a/spec/models/messages_spec.rb +++ b/spec/models/messages_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'support/shared/acts_as_watchable' -describe Message do +RSpec.describe Message do let(:message) { create(:message) } it_behaves_like 'acts_as_watchable included' do diff --git a/spec/models/news_spec.rb b/spec/models/news_spec.rb index c2236f07206..7387b8c1b6a 100644 --- a/spec/models/news_spec.rb +++ b/spec/models/news_spec.rb @@ -30,7 +30,7 @@ require File.expand_path('../support/shared/become_member', __dir__) require 'support/shared/acts_as_watchable' -describe News do +RSpec.describe News do include BecomeMember let(:project) do diff --git a/spec/models/notification_settings/scopes/applicable_spec.rb b/spec/models/notification_settings/scopes/applicable_spec.rb index 41d43b9e0cc..fbef51d4269 100644 --- a/spec/models/notification_settings/scopes/applicable_spec.rb +++ b/spec/models/notification_settings/scopes/applicable_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe NotificationSettings::Scopes::Applicable do +RSpec.describe NotificationSettings::Scopes::Applicable do describe '.applicable' do subject(:scope) { NotificationSetting.applicable(project) } diff --git a/spec/models/notification_spec.rb b/spec/models/notification_spec.rb index 40cabb3c6d9..79075721170 100644 --- a/spec/models/notification_spec.rb +++ b/spec/models/notification_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe Notification do +RSpec.describe Notification do describe '.save' do context 'for a non existing journal (e.g. because it has been deleted)' do let(:notification) { build(:notification) } diff --git a/spec/models/notifications/scopes/reminder_mail_unsent_spec.rb b/spec/models/notifications/scopes/reminder_mail_unsent_spec.rb index 6f78700496b..08804d32d7f 100644 --- a/spec/models/notifications/scopes/reminder_mail_unsent_spec.rb +++ b/spec/models/notifications/scopes/reminder_mail_unsent_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Notifications::Scopes::MailReminderUnsent do +RSpec.describe Notifications::Scopes::MailReminderUnsent do describe '.unread_digest_mail' do subject(:scope) { Notification.mail_reminder_unsent } diff --git a/spec/models/notifications/scopes/unsent_reminders_before_spec.rb b/spec/models/notifications/scopes/unsent_reminders_before_spec.rb index d7ec7c85f08..3806a9e0db5 100644 --- a/spec/models/notifications/scopes/unsent_reminders_before_spec.rb +++ b/spec/models/notifications/scopes/unsent_reminders_before_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Notifications::Scopes::UnsentRemindersBefore do +RSpec.describe Notifications::Scopes::UnsentRemindersBefore do describe '.unsent_reminders_before' do subject(:scope) { Notification.unsent_reminders_before(recipient:, time:) } diff --git a/spec/models/notifications/scopes/visible_spec.rb b/spec/models/notifications/scopes/visible_spec.rb index 0218883575c..df0e395a639 100644 --- a/spec/models/notifications/scopes/visible_spec.rb +++ b/spec/models/notifications/scopes/visible_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Notifications::Scopes::Visible do +RSpec.describe Notifications::Scopes::Visible do describe '.visible' do subject(:scope) { Notification.visible(user) } diff --git a/spec/models/oauth_client_token_spec.rb b/spec/models/oauth_client_token_spec.rb index 61ea2f2430f..0bed639d4fd 100644 --- a/spec/models/oauth_client_token_spec.rb +++ b/spec/models/oauth_client_token_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OAuthClientToken do +RSpec.describe OAuthClientToken do let(:access_token) { "x" } let(:refresh_token) { "x" } let(:user) { create(:user) } diff --git a/spec/models/permitted_params_spec.rb b/spec/models/permitted_params_spec.rb index bd06286a62a..3d2c56bd980 100644 --- a/spec/models/permitted_params_spec.rb +++ b/spec/models/permitted_params_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe PermittedParams do +RSpec.describe PermittedParams do let(:user) { build_stubbed(:user) } let(:admin) { build_stubbed(:admin) } diff --git a/spec/models/placeholder_users/placeholder_user_spec.rb b/spec/models/placeholder_users/placeholder_user_spec.rb index c197c377ed4..6eaf52dc6df 100644 --- a/spec/models/placeholder_users/placeholder_user_spec.rb +++ b/spec/models/placeholder_users/placeholder_user_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe PlaceholderUser do +RSpec.describe PlaceholderUser do let(:placeholder_user) { build(:placeholder_user) } subject { placeholder_user } diff --git a/spec/models/placeholder_users/scopes/visible_spec.rb b/spec/models/placeholder_users/scopes/visible_spec.rb index 212418a3b7b..5f2a51cd97a 100644 --- a/spec/models/placeholder_users/scopes/visible_spec.rb +++ b/spec/models/placeholder_users/scopes/visible_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe PlaceholderUsers::Scopes::Visible do +RSpec.describe PlaceholderUsers::Scopes::Visible do describe '.visible' do shared_let(:project) { create(:project) } shared_let(:other_project) { create(:project) } diff --git a/spec/models/principal_spec.rb b/spec/models/principal_spec.rb index 6ce572d3f9a..37e28e44412 100644 --- a/spec/models/principal_spec.rb +++ b/spec/models/principal_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Principal do +RSpec.describe Principal do let(:user) { build(:user) } let(:group) { build(:group) } diff --git a/spec/models/principals/scopes/human_spec.rb b/spec/models/principals/scopes/human_spec.rb index 89705203a8f..ec77ea8a95b 100644 --- a/spec/models/principals/scopes/human_spec.rb +++ b/spec/models/principals/scopes/human_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Principals::Scopes::Human do +RSpec.describe Principals::Scopes::Human do describe '.human' do let!(:anonymous_user) { create(:anonymous) } let!(:system_user) { create(:system) } diff --git a/spec/models/principals/scopes/like_spec.rb b/spec/models/principals/scopes/like_spec.rb index fea2e3c4f4b..1d1b30a0cee 100644 --- a/spec/models/principals/scopes/like_spec.rb +++ b/spec/models/principals/scopes/like_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Principals::Scopes::Like do +RSpec.describe Principals::Scopes::Like do describe '.like' do let!(:login) do create(:principal, login: 'login') diff --git a/spec/models/principals/scopes/not_builtin_spec.rb b/spec/models/principals/scopes/not_builtin_spec.rb index 5093e7272d0..9bccc775d7a 100644 --- a/spec/models/principals/scopes/not_builtin_spec.rb +++ b/spec/models/principals/scopes/not_builtin_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Principals::Scopes::NotBuiltin do +RSpec.describe Principals::Scopes::NotBuiltin do describe '.not_builtin' do let!(:anonymous_user) { create(:anonymous) } let!(:system_user) { create(:system) } diff --git a/spec/models/principals/scopes/ordered_by_name_spec.rb b/spec/models/principals/scopes/ordered_by_name_spec.rb index ad2cf4c4c6e..7240ab9ad00 100644 --- a/spec/models/principals/scopes/ordered_by_name_spec.rb +++ b/spec/models/principals/scopes/ordered_by_name_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Principals::Scopes::OrderedByName do +RSpec.describe Principals::Scopes::OrderedByName do describe '.ordered_by_name' do shared_let(:alice) { create(:user, login: 'alice', firstname: 'Alice', lastname: 'Zetop') } shared_let(:eve) { create(:user, login: 'eve', firstname: 'Eve', lastname: 'Baddie') } diff --git a/spec/models/principals/scopes/possible_assignee_spec.rb b/spec/models/principals/scopes/possible_assignee_spec.rb index 6d469457867..e1903fe5c2c 100644 --- a/spec/models/principals/scopes/possible_assignee_spec.rb +++ b/spec/models/principals/scopes/possible_assignee_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Principals::Scopes::PossibleAssignee do +RSpec.describe Principals::Scopes::PossibleAssignee do let(:project) { create(:project) } let(:other_project) { create(:project) } let(:role_assignable) { true } diff --git a/spec/models/principals/scopes/possible_member_spec.rb b/spec/models/principals/scopes/possible_member_spec.rb index 434e14c503f..23a64eeee0d 100644 --- a/spec/models/principals/scopes/possible_member_spec.rb +++ b/spec/models/principals/scopes/possible_member_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Principals::Scopes::PossibleMember do +RSpec.describe Principals::Scopes::PossibleMember do let(:project) { create(:project) } let(:public_project) { create(:project, public: true) } let(:role) { create(:role) } diff --git a/spec/models/principals/scopes/user_spec.rb b/spec/models/principals/scopes/user_spec.rb index 2c4869e7d32..6ec45ece76a 100644 --- a/spec/models/principals/scopes/user_spec.rb +++ b/spec/models/principals/scopes/user_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Principals::Scopes::User do +RSpec.describe Principals::Scopes::User do describe '.user' do let!(:anonymous_user) { create(:anonymous) } let!(:system_user) { create(:system) } diff --git a/spec/models/principals/scopes/visible_spec.rb b/spec/models/principals/scopes/visible_spec.rb index 6b6ec07153c..7508a0285aa 100644 --- a/spec/models/principals/scopes/visible_spec.rb +++ b/spec/models/principals/scopes/visible_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Principals::Scopes::Visible do +RSpec.describe Principals::Scopes::Visible do describe '.visible' do shared_let(:role) { create(:role, permissions: %i[manage_members]) } diff --git a/spec/models/project_spec.rb b/spec/models/project_spec.rb index dc5b1538c39..6d4c404adad 100644 --- a/spec/models/project_spec.rb +++ b/spec/models/project_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require File.expand_path('../support/shared/become_member', __dir__) -describe Project do +RSpec.describe Project do include BecomeMember shared_let(:admin) { create(:admin) } diff --git a/spec/models/projects/activity_spec.rb b/spec/models/projects/activity_spec.rb index f0a29d008ea..2903d173698 100644 --- a/spec/models/projects/activity_spec.rb +++ b/spec/models/projects/activity_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::Activity, 'core' do +RSpec.describe Projects::Activity, 'core' do shared_let(:project) do create(:project, :updated_a_long_time_ago) end diff --git a/spec/models/projects/allowed_to_scope_spec.rb b/spec/models/projects/allowed_to_scope_spec.rb index bcebc4583b0..84a1783cc05 100644 --- a/spec/models/projects/allowed_to_scope_spec.rb +++ b/spec/models/projects/allowed_to_scope_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Project, 'allowed to' do +RSpec.describe Project, 'allowed to' do let(:user) { build(:user) } let(:anonymous) { build(:anonymous) } let(:admin) { build(:admin) } diff --git a/spec/models/projects/customizable_spec.rb b/spec/models/projects/customizable_spec.rb index a09eaf79a62..fb7e5c0f385 100644 --- a/spec/models/projects/customizable_spec.rb +++ b/spec/models/projects/customizable_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Project, 'customizable' do +RSpec.describe Project, 'customizable' do let(:project) do build_stubbed(:project, custom_values:) diff --git a/spec/models/projects/exporter/csv_integration_spec.rb b/spec/models/projects/exporter/csv_integration_spec.rb index 31f2f3f885e..701aa47df0a 100644 --- a/spec/models/projects/exporter/csv_integration_spec.rb +++ b/spec/models/projects/exporter/csv_integration_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative 'exportable_project_context' -describe Projects::Exports::CSV, 'integration' do +RSpec.describe Projects::Exports::CSV, 'integration' do include_context 'with a project with an arrangement of custom fields' include_context 'with an instance of the described exporter' diff --git a/spec/models/projects/exporter/exportable_project_context.rb b/spec/models/projects/exporter/exportable_project_context.rb index b96286b1806..7b902044fe4 100644 --- a/spec/models/projects/exporter/exportable_project_context.rb +++ b/spec/models/projects/exporter/exportable_project_context.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_context 'with a project with an arrangement of custom fields' do +RSpec.shared_context 'with a project with an arrangement of custom fields' do shared_let(:version_cf) { create(:version_project_custom_field, position: 1) } shared_let(:bool_cf) { create(:bool_project_custom_field, position: 2) } shared_let(:user_cf) { create(:user_project_custom_field, position: 3) } @@ -68,7 +68,7 @@ shared_context 'with a project with an arrangement of custom fields' do end end -shared_context 'with an instance of the described exporter' do +RSpec.shared_context 'with an instance of the described exporter' do before do login_as current_user end diff --git a/spec/models/projects/project_acts_as_journalized_spec.rb b/spec/models/projects/project_acts_as_journalized_spec.rb index e58fb3b702c..14d02b3f950 100644 --- a/spec/models/projects/project_acts_as_journalized_spec.rb +++ b/spec/models/projects/project_acts_as_journalized_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Project, 'acts_as_journalized' do +RSpec.describe Project, 'acts_as_journalized' do shared_let(:user) { create(:user) } let!(:project) do diff --git a/spec/models/projects/reorder_nested_set_spec.rb b/spec/models/projects/reorder_nested_set_spec.rb index bab7cba9374..5797fc20899 100644 --- a/spec/models/projects/reorder_nested_set_spec.rb +++ b/spec/models/projects/reorder_nested_set_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Project, 'reordering of nested set' do +RSpec.describe Project, 'reordering of nested set' do # Create some parents in non-alphabetical order shared_let(:parent_project_b) { create(:project, name: 'ParentB') } shared_let(:parent_project_a) { create(:project, name: 'ParentA') } diff --git a/spec/models/projects/storage_spec.rb b/spec/models/projects/storage_spec.rb index 933567f1c3f..a598481e2ca 100644 --- a/spec/models/projects/storage_spec.rb +++ b/spec/models/projects/storage_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::Storage do +RSpec.describe Projects::Storage do let(:project1) do create(:project) .reload # Reload required for wiki association to be available diff --git a/spec/models/queries/capabilities/capability_query_spec.rb b/spec/models/queries/capabilities/capability_query_spec.rb index b55a9fb6ebc..dca5cc5f2da 100644 --- a/spec/models/queries/capabilities/capability_query_spec.rb +++ b/spec/models/queries/capabilities/capability_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Capabilities::CapabilityQuery do +RSpec.describe Queries::Capabilities::CapabilityQuery do let(:instance) { described_class.new } current_user do diff --git a/spec/models/queries/capabilities/filters/action_filter_spec.rb b/spec/models/queries/capabilities/filters/action_filter_spec.rb index 55fb20a5114..502a539794e 100644 --- a/spec/models/queries/capabilities/filters/action_filter_spec.rb +++ b/spec/models/queries/capabilities/filters/action_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Capabilities::Filters::ActionFilter do +RSpec.describe Queries::Capabilities::Filters::ActionFilter do it_behaves_like 'basic query filter' do let(:class_key) { :action } let(:type) { :string } diff --git a/spec/models/queries/capabilities/filters/context_filter_spec.rb b/spec/models/queries/capabilities/filters/context_filter_spec.rb index aecb8eb2823..739eed19cd1 100644 --- a/spec/models/queries/capabilities/filters/context_filter_spec.rb +++ b/spec/models/queries/capabilities/filters/context_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Capabilities::Filters::ContextFilter do +RSpec.describe Queries::Capabilities::Filters::ContextFilter do it_behaves_like 'basic query filter' do let(:class_key) { :context } let(:type) { :string } diff --git a/spec/models/queries/capabilities/filters/id_filter_spec.rb b/spec/models/queries/capabilities/filters/id_filter_spec.rb index dbc5e2d8b67..9fea33ff6e8 100644 --- a/spec/models/queries/capabilities/filters/id_filter_spec.rb +++ b/spec/models/queries/capabilities/filters/id_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Capabilities::Filters::IdFilter do +RSpec.describe Queries::Capabilities::Filters::IdFilter do it_behaves_like 'basic query filter' do let(:class_key) { :id } let(:type) { :string } diff --git a/spec/models/queries/capabilities/filters/principal_id_filter_spec.rb b/spec/models/queries/capabilities/filters/principal_id_filter_spec.rb index 7a543563b98..cbc8e6d921a 100644 --- a/spec/models/queries/capabilities/filters/principal_id_filter_spec.rb +++ b/spec/models/queries/capabilities/filters/principal_id_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Capabilities::Filters::PrincipalIdFilter do +RSpec.describe Queries::Capabilities::Filters::PrincipalIdFilter do it_behaves_like 'basic query filter' do let(:class_key) { :principal_id } let(:type) { :integer } diff --git a/spec/models/queries/days/day_query_spec.rb b/spec/models/queries/days/day_query_spec.rb index b5e19a5df74..dccf7fbc1ce 100644 --- a/spec/models/queries/days/day_query_spec.rb +++ b/spec/models/queries/days/day_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Days::DayQuery do +RSpec.describe Queries::Days::DayQuery do let(:instance) { described_class.new } let(:base_scope) { Day.reorder(date: :asc) } let(:current_user) { build_stubbed(:admin) } diff --git a/spec/models/queries/days/filters/dates_interval_filter_spec.rb b/spec/models/queries/days/filters/dates_interval_filter_spec.rb index f0a7e30676e..deafa0a810d 100644 --- a/spec/models/queries/days/filters/dates_interval_filter_spec.rb +++ b/spec/models/queries/days/filters/dates_interval_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Days::Filters::DatesIntervalFilter do +RSpec.describe Queries::Days::Filters::DatesIntervalFilter do it_behaves_like 'basic query filter' do let(:type) { :date } let(:class_key) { :date } diff --git a/spec/models/queries/days/filters/working_filter_spec.rb b/spec/models/queries/days/filters/working_filter_spec.rb index 2372b8920e3..7bb588ebc1d 100644 --- a/spec/models/queries/days/filters/working_filter_spec.rb +++ b/spec/models/queries/days/filters/working_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Days::Filters::WorkingFilter do +RSpec.describe Queries::Days::Filters::WorkingFilter do it_behaves_like 'boolean query filter' do let(:model) { Day } let(:attribute) { :working } diff --git a/spec/models/queries/filters/available_filters_spec.rb b/spec/models/queries/filters/available_filters_spec.rb index 6a458dce9fd..01bfb923a58 100644 --- a/spec/models/queries/filters/available_filters_spec.rb +++ b/spec/models/queries/filters/available_filters_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Filters::AvailableFilters do +RSpec.describe Queries::Filters::AvailableFilters do let(:context) { build_stubbed(:project) } let(:register) { Queries::FilterRegister } let(:includer) do diff --git a/spec/models/queries/filters/base_spec.rb b/spec/models/queries/filters/base_spec.rb index 757b3b4a4bf..dae61ab0554 100644 --- a/spec/models/queries/filters/base_spec.rb +++ b/spec/models/queries/filters/base_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Filters::Base do +RSpec.describe Queries::Filters::Base do let(:integer_filter) do filter_class = Class.new(described_class) do def type diff --git a/spec/models/queries/members/filters/blocked_filter_spec.rb b/spec/models/queries/members/filters/blocked_filter_spec.rb index 8cec36a9bdf..f264a77694a 100644 --- a/spec/models/queries/members/filters/blocked_filter_spec.rb +++ b/spec/models/queries/members/filters/blocked_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Members::Filters::BlockedFilter do +RSpec.describe Queries::Members::Filters::BlockedFilter do it_behaves_like 'basic query filter' do let(:class_key) { :blocked } let(:type) { :list } diff --git a/spec/models/queries/members/filters/created_at_filter_spec.rb b/spec/models/queries/members/filters/created_at_filter_spec.rb index f083768b678..eb6134d61c8 100644 --- a/spec/models/queries/members/filters/created_at_filter_spec.rb +++ b/spec/models/queries/members/filters/created_at_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Members::Filters::CreatedAtFilter do +RSpec.describe Queries::Members::Filters::CreatedAtFilter do it_behaves_like 'basic query filter' do let(:class_key) { :created_at } let(:type) { :datetime_past } diff --git a/spec/models/queries/members/filters/group_filter_spec.rb b/spec/models/queries/members/filters/group_filter_spec.rb index 6dfce0fcaa3..47d596a8161 100644 --- a/spec/models/queries/members/filters/group_filter_spec.rb +++ b/spec/models/queries/members/filters/group_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Members::Filters::GroupFilter do +RSpec.describe Queries::Members::Filters::GroupFilter do let(:group1) { build_stubbed(:group) } let(:group2) { build_stubbed(:group) } diff --git a/spec/models/queries/members/filters/name_filter_spec.rb b/spec/models/queries/members/filters/name_filter_spec.rb index ce2ee68fdf1..c8d5aae5e18 100644 --- a/spec/models/queries/members/filters/name_filter_spec.rb +++ b/spec/models/queries/members/filters/name_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Members::Filters::NameFilter do +RSpec.describe Queries::Members::Filters::NameFilter do include_context 'filter tests' let(:values) { ['A name'] } let(:model) { Member.joins(:principal) } diff --git a/spec/models/queries/members/filters/principal_filter_spec.rb b/spec/models/queries/members/filters/principal_filter_spec.rb index 4c676e74e9b..7a620186bbc 100644 --- a/spec/models/queries/members/filters/principal_filter_spec.rb +++ b/spec/models/queries/members/filters/principal_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Members::Filters::PrincipalFilter do +RSpec.describe Queries::Members::Filters::PrincipalFilter do let(:user) { build_stubbed(:user) } let(:group) { build_stubbed(:group) } let(:current_user) { build_stubbed(:user) } diff --git a/spec/models/queries/members/filters/project_filter_spec.rb b/spec/models/queries/members/filters/project_filter_spec.rb index 53adee67224..0cc6e412205 100644 --- a/spec/models/queries/members/filters/project_filter_spec.rb +++ b/spec/models/queries/members/filters/project_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Members::Filters::ProjectFilter do +RSpec.describe Queries::Members::Filters::ProjectFilter do it_behaves_like 'basic query filter' do let(:class_key) { :project_id } let(:type) { :list_optional } diff --git a/spec/models/queries/members/filters/role_filter_spec.rb b/spec/models/queries/members/filters/role_filter_spec.rb index def86f8a5ae..792d76cbdfd 100644 --- a/spec/models/queries/members/filters/role_filter_spec.rb +++ b/spec/models/queries/members/filters/role_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Members::Filters::RoleFilter do +RSpec.describe Queries::Members::Filters::RoleFilter do let(:role1) { build_stubbed(:role) } let(:role2) { build_stubbed(:role) } diff --git a/spec/models/queries/members/filters/status_filter_spec.rb b/spec/models/queries/members/filters/status_filter_spec.rb index 239de72d1bf..1b8429646d6 100644 --- a/spec/models/queries/members/filters/status_filter_spec.rb +++ b/spec/models/queries/members/filters/status_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Members::Filters::StatusFilter do +RSpec.describe Queries::Members::Filters::StatusFilter do it_behaves_like 'basic query filter' do let(:class_key) { :status } let(:type) { :list } diff --git a/spec/models/queries/members/filters/updated_at_filter_spec.rb b/spec/models/queries/members/filters/updated_at_filter_spec.rb index 0953c353505..246d52ad6d7 100644 --- a/spec/models/queries/members/filters/updated_at_filter_spec.rb +++ b/spec/models/queries/members/filters/updated_at_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Members::Filters::UpdatedAtFilter do +RSpec.describe Queries::Members::Filters::UpdatedAtFilter do it_behaves_like 'basic query filter' do let(:class_key) { :updated_at } let(:type) { :datetime_past } diff --git a/spec/models/queries/members/members_query_integration_spec.rb b/spec/models/queries/members/members_query_integration_spec.rb index 970389a941c..77deafd83ef 100644 --- a/spec/models/queries/members/members_query_integration_spec.rb +++ b/spec/models/queries/members/members_query_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Members::MemberQuery, 'Integration' do +RSpec.describe Queries::Members::MemberQuery, 'Integration' do let(:instance) { described_class.new } current_user { user } diff --git a/spec/models/queries/news/filters/project_filter_spec.rb b/spec/models/queries/news/filters/project_filter_spec.rb index eff5394f756..f66fe579ff7 100644 --- a/spec/models/queries/news/filters/project_filter_spec.rb +++ b/spec/models/queries/news/filters/project_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::News::Filters::ProjectFilter do +RSpec.describe Queries::News::Filters::ProjectFilter do let(:project1) { build_stubbed(:project) } let(:project2) { build_stubbed(:project) } diff --git a/spec/models/queries/news/news_query_spec.rb b/spec/models/queries/news/news_query_spec.rb index 5ad739003ec..07c1751e445 100644 --- a/spec/models/queries/news/news_query_spec.rb +++ b/spec/models/queries/news/news_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::News::NewsQuery do +RSpec.describe Queries::News::NewsQuery do let(:user) { build_stubbed(:user) } let(:base_scope) { News.visible(user).order(id: :desc) } let(:instance) { described_class.new } diff --git a/spec/models/queries/non_working_days/filters/dates_interval_filter_spec.rb b/spec/models/queries/non_working_days/filters/dates_interval_filter_spec.rb index f7883c62262..25c9a65cd63 100644 --- a/spec/models/queries/non_working_days/filters/dates_interval_filter_spec.rb +++ b/spec/models/queries/non_working_days/filters/dates_interval_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::NonWorkingDays::Filters::DatesIntervalFilter do +RSpec.describe Queries::NonWorkingDays::Filters::DatesIntervalFilter do it_behaves_like 'basic query filter' do let(:type) { :date } let(:class_key) { :date } diff --git a/spec/models/queries/non_working_days/non_working_day_query_spec.rb b/spec/models/queries/non_working_days/non_working_day_query_spec.rb index 30e83398724..d4c10af02ee 100644 --- a/spec/models/queries/non_working_days/non_working_day_query_spec.rb +++ b/spec/models/queries/non_working_days/non_working_day_query_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/work_packages/shared/shared_examples_days' -describe Queries::NonWorkingDays::NonWorkingDayQuery do +RSpec.describe Queries::NonWorkingDays::NonWorkingDayQuery do shared_let(:first_of_may) { create(:non_working_day, date: Date.new(Date.current.year, 5, 1)) } shared_let(:christmas) { create(:non_working_day, date: Date.new(Date.current.year, 12, 25)) } shared_let(:new_year_day) { create(:non_working_day, date: Date.new(Date.current.year + 1, 1, 1)) } diff --git a/spec/models/queries/notifications/filters/id_filter_spec.rb b/spec/models/queries/notifications/filters/id_filter_spec.rb index 2667793b215..b0b5cadebd7 100644 --- a/spec/models/queries/notifications/filters/id_filter_spec.rb +++ b/spec/models/queries/notifications/filters/id_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Notifications::Filters::IdFilter do +RSpec.describe Queries::Notifications::Filters::IdFilter do it_behaves_like 'basic query filter' do let(:class_key) { :id } let(:type) { :list } diff --git a/spec/models/queries/notifications/filters/read_ian_filter_spec.rb b/spec/models/queries/notifications/filters/read_ian_filter_spec.rb index ff7f575695f..6ca26c6e7f2 100644 --- a/spec/models/queries/notifications/filters/read_ian_filter_spec.rb +++ b/spec/models/queries/notifications/filters/read_ian_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Notifications::Filters::ReadIanFilter do +RSpec.describe Queries::Notifications::Filters::ReadIanFilter do it_behaves_like 'basic query filter' do let(:type) { :list } let(:class_key) { :read_ian } diff --git a/spec/models/queries/notifications/filters/reason_filter_spec.rb b/spec/models/queries/notifications/filters/reason_filter_spec.rb index 55e12a26b1e..75d6649be5d 100644 --- a/spec/models/queries/notifications/filters/reason_filter_spec.rb +++ b/spec/models/queries/notifications/filters/reason_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Notifications::Filters::ReasonFilter do +RSpec.describe Queries::Notifications::Filters::ReasonFilter do it_behaves_like 'basic query filter' do let(:class_key) { :reason } let(:type) { :list } diff --git a/spec/models/queries/notifications/notification_query_spec.rb b/spec/models/queries/notifications/notification_query_spec.rb index 13797102ac4..abdfb5ac011 100644 --- a/spec/models/queries/notifications/notification_query_spec.rb +++ b/spec/models/queries/notifications/notification_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Notifications::NotificationQuery do +RSpec.describe Queries::Notifications::NotificationQuery do shared_let(:project) { create(:project) } shared_let(:recipient) { create(:user, member_in_project: project, member_with_permissions: %i[view_work_packages]) } diff --git a/spec/models/queries/placeholder_users/placeholder_user_query_spec.rb b/spec/models/queries/placeholder_users/placeholder_user_query_spec.rb index 94c9f2f60c9..d1197fd0d80 100644 --- a/spec/models/queries/placeholder_users/placeholder_user_query_spec.rb +++ b/spec/models/queries/placeholder_users/placeholder_user_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::PlaceholderUsers::PlaceholderUserQuery do +RSpec.describe Queries::PlaceholderUsers::PlaceholderUserQuery do let(:instance) { described_class.new } let(:base_scope) { PlaceholderUser.order(id: :desc) } diff --git a/spec/models/queries/principals/principal_query_integrations_spec.rb b/spec/models/queries/principals/principal_query_integrations_spec.rb index d964e0c0d3c..5e9d04bcc4c 100644 --- a/spec/models/queries/principals/principal_query_integrations_spec.rb +++ b/spec/models/queries/principals/principal_query_integrations_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Principals::PrincipalQuery, 'integration' do +RSpec.describe Queries::Principals::PrincipalQuery, 'integration' do let(:current_user) { create(:user) } let(:instance) { described_class.new } let!(:non_member_role) { create(:non_member) } diff --git a/spec/models/queries/projects/filters/active_filter_spec.rb b/spec/models/queries/projects/filters/active_filter_spec.rb index a3f36315660..2568ac6c53c 100644 --- a/spec/models/queries/projects/filters/active_filter_spec.rb +++ b/spec/models/queries/projects/filters/active_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::Filters::ActiveFilter do +RSpec.describe Queries::Projects::Filters::ActiveFilter do it_behaves_like 'boolean query filter' do let(:model) { Project } let(:attribute) { :active } diff --git a/spec/models/queries/projects/filters/created_at_filter_spec.rb b/spec/models/queries/projects/filters/created_at_filter_spec.rb index f4d15007e36..0940a677d9b 100644 --- a/spec/models/queries/projects/filters/created_at_filter_spec.rb +++ b/spec/models/queries/projects/filters/created_at_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::Filters::CreatedAtFilter do +RSpec.describe Queries::Projects::Filters::CreatedAtFilter do it_behaves_like 'basic query filter' do let(:class_key) { :created_at } let(:type) { :datetime_past } diff --git a/spec/models/queries/projects/filters/custom_field_filter_spec.rb b/spec/models/queries/projects/filters/custom_field_filter_spec.rb index bf59ff08b28..677325d85f0 100644 --- a/spec/models/queries/projects/filters/custom_field_filter_spec.rb +++ b/spec/models/queries/projects/filters/custom_field_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::Filters::CustomFieldFilter do +RSpec.describe Queries::Projects::Filters::CustomFieldFilter do let(:query) { Queries::Projects::ProjectQuery.new } let(:bool_project_custom_field) { build_stubbed(:bool_project_custom_field) } let(:int_project_custom_field) { build_stubbed(:int_project_custom_field) } diff --git a/spec/models/queries/projects/filters/latest_activity_at_filter_spec.rb b/spec/models/queries/projects/filters/latest_activity_at_filter_spec.rb index 952be3cf331..3dfa316fd04 100644 --- a/spec/models/queries/projects/filters/latest_activity_at_filter_spec.rb +++ b/spec/models/queries/projects/filters/latest_activity_at_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::Filters::LatestActivityAtFilter do +RSpec.describe Queries::Projects::Filters::LatestActivityAtFilter do it_behaves_like 'basic query filter' do let(:class_key) { :latest_activity_at } let(:type) { :datetime_past } diff --git a/spec/models/queries/projects/filters/name_and_identifier_filter_spec.rb b/spec/models/queries/projects/filters/name_and_identifier_filter_spec.rb index 01964c2555b..29738557d9a 100644 --- a/spec/models/queries/projects/filters/name_and_identifier_filter_spec.rb +++ b/spec/models/queries/projects/filters/name_and_identifier_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::Filters::NameAndIdentifierFilter do +RSpec.describe Queries::Projects::Filters::NameAndIdentifierFilter do include_context 'filter tests' let(:values) { ['A name'] } let(:model) { Project } diff --git a/spec/models/queries/projects/filters/name_filter_spec.rb b/spec/models/queries/projects/filters/name_filter_spec.rb index 594a7df7922..e76ab0c4a2c 100644 --- a/spec/models/queries/projects/filters/name_filter_spec.rb +++ b/spec/models/queries/projects/filters/name_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::Filters::NameFilter do +RSpec.describe Queries::Projects::Filters::NameFilter do include_context 'filter tests' let(:values) { ['A name'] } let(:model) { Project } diff --git a/spec/models/queries/projects/filters/parent_filter_spec.rb b/spec/models/queries/projects/filters/parent_filter_spec.rb index 428c19fa3dd..14db8b795c5 100644 --- a/spec/models/queries/projects/filters/parent_filter_spec.rb +++ b/spec/models/queries/projects/filters/parent_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::Filters::ParentFilter do +RSpec.describe Queries::Projects::Filters::ParentFilter do let(:project1) { build_stubbed(:project) } let(:project2) { build_stubbed(:project) } diff --git a/spec/models/queries/projects/filters/principal_filter_spec.rb b/spec/models/queries/projects/filters/principal_filter_spec.rb index 1a01d00f9b7..e9acf9732b0 100644 --- a/spec/models/queries/projects/filters/principal_filter_spec.rb +++ b/spec/models/queries/projects/filters/principal_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::Filters::PrincipalFilter do +RSpec.describe Queries::Projects::Filters::PrincipalFilter do let(:group1) { build_stubbed(:group) } let(:group2) { build_stubbed(:group) } let(:user1) { build_stubbed(:user) } diff --git a/spec/models/queries/projects/filters/project_status_filter_spec.rb b/spec/models/queries/projects/filters/project_status_filter_spec.rb index daa1f8381f2..66ed112ecfa 100644 --- a/spec/models/queries/projects/filters/project_status_filter_spec.rb +++ b/spec/models/queries/projects/filters/project_status_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::Filters::ProjectStatusFilter do +RSpec.describe Queries::Projects::Filters::ProjectStatusFilter do it_behaves_like 'basic query filter' do let(:class_key) { :project_status_code } let(:type) { :list_optional } diff --git a/spec/models/queries/projects/filters/public_filter_spec.rb b/spec/models/queries/projects/filters/public_filter_spec.rb index deb76de5927..53ff6d30d03 100644 --- a/spec/models/queries/projects/filters/public_filter_spec.rb +++ b/spec/models/queries/projects/filters/public_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::Filters::PublicFilter do +RSpec.describe Queries::Projects::Filters::PublicFilter do it_behaves_like 'boolean query filter' do let(:model) { Project } let(:attribute) { :public } diff --git a/spec/models/queries/projects/filters/type_filter_spec.rb b/spec/models/queries/projects/filters/type_filter_spec.rb index 8a3186524d6..d310f81cee2 100644 --- a/spec/models/queries/projects/filters/type_filter_spec.rb +++ b/spec/models/queries/projects/filters/type_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::Filters::TypeFilter do +RSpec.describe Queries::Projects::Filters::TypeFilter do it_behaves_like 'basic query filter' do let(:class_key) { :type_id } let(:type) { :list } diff --git a/spec/models/queries/projects/filters/user_action_filter_spec.rb b/spec/models/queries/projects/filters/user_action_filter_spec.rb index d58f5179ada..75d54a19a1c 100644 --- a/spec/models/queries/projects/filters/user_action_filter_spec.rb +++ b/spec/models/queries/projects/filters/user_action_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::Filters::UserActionFilter do +RSpec.describe Queries::Projects::Filters::UserActionFilter do it_behaves_like 'basic query filter' do let(:class_key) { :user_action } let(:type) { :list } diff --git a/spec/models/queries/projects/filters/visible_filter_spec.rb b/spec/models/queries/projects/filters/visible_filter_spec.rb index 5888bffb8ba..c665f898722 100644 --- a/spec/models/queries/projects/filters/visible_filter_spec.rb +++ b/spec/models/queries/projects/filters/visible_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::Filters::VisibleFilter do +RSpec.describe Queries::Projects::Filters::VisibleFilter do it_behaves_like 'basic query filter' do let(:class_key) { :visible } let(:type) { :list } diff --git a/spec/models/queries/projects/orders/latest_activity_at_order_spec.rb b/spec/models/queries/projects/orders/latest_activity_at_order_spec.rb index 50884ac7c45..42b1300682e 100644 --- a/spec/models/queries/projects/orders/latest_activity_at_order_spec.rb +++ b/spec/models/queries/projects/orders/latest_activity_at_order_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::Orders::LatestActivityAtOrder do +RSpec.describe Queries::Projects::Orders::LatestActivityAtOrder do let(:instance) do described_class.new('').tap do |i| i.direction = direction diff --git a/spec/models/queries/projects/orders/required_disk_space_order_spec.rb b/spec/models/queries/projects/orders/required_disk_space_order_spec.rb index 5584c632303..1143a0845f3 100644 --- a/spec/models/queries/projects/orders/required_disk_space_order_spec.rb +++ b/spec/models/queries/projects/orders/required_disk_space_order_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::Orders::RequiredDiskSpaceOrder do +RSpec.describe Queries::Projects::Orders::RequiredDiskSpaceOrder do let(:instance) do described_class.new('').tap do |i| i.direction = direction diff --git a/spec/models/queries/projects/project_query_spec.rb b/spec/models/queries/projects/project_query_spec.rb index 1678de999cc..74f4a48e2a1 100644 --- a/spec/models/queries/projects/project_query_spec.rb +++ b/spec/models/queries/projects/project_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Projects::ProjectQuery do +RSpec.describe Queries::Projects::ProjectQuery do let(:instance) { described_class.new } let(:base_scope) { Project.all.order(id: :desc) } let(:current_user) { build_stubbed(:admin) } diff --git a/spec/models/queries/queries/filters/project_filter_spec.rb b/spec/models/queries/queries/filters/project_filter_spec.rb index 5b34b80850a..5634119bd5f 100644 --- a/spec/models/queries/queries/filters/project_filter_spec.rb +++ b/spec/models/queries/queries/filters/project_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Queries::Filters::ProjectFilter do +RSpec.describe Queries::Queries::Filters::ProjectFilter do it_behaves_like 'basic query filter' do let(:class_key) { :project_id } let(:type) { :list_optional } diff --git a/spec/models/queries/queries/filters/updated_at_filter_spec.rb b/spec/models/queries/queries/filters/updated_at_filter_spec.rb index 6e9d7b5ed3d..816b8d6b19a 100644 --- a/spec/models/queries/queries/filters/updated_at_filter_spec.rb +++ b/spec/models/queries/queries/filters/updated_at_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Queries::Filters::UpdatedAtFilter do +RSpec.describe Queries::Queries::Filters::UpdatedAtFilter do it_behaves_like 'basic query filter' do let(:type) { :datetime_past } let(:class_key) { :updated_at } diff --git a/spec/models/queries/queries/query_query_spec.rb b/spec/models/queries/queries/query_query_spec.rb index 4e375ba76d6..d722f1edd94 100644 --- a/spec/models/queries/queries/query_query_spec.rb +++ b/spec/models/queries/queries/query_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Queries::QueryQuery do +RSpec.describe Queries::Queries::QueryQuery do let(:user) { build_stubbed(:user) } let(:instance) { described_class.new(user:) } let(:base_scope) { Query.visible(user).order(id: :desc) } diff --git a/spec/models/queries/relations/filters/from_filter_spec.rb b/spec/models/queries/relations/filters/from_filter_spec.rb index 4c3e3d08954..b18c88a8b85 100644 --- a/spec/models/queries/relations/filters/from_filter_spec.rb +++ b/spec/models/queries/relations/filters/from_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Relations::Filters::FromFilter do +RSpec.describe Queries::Relations::Filters::FromFilter do include_context 'filter tests' let(:values) { ['1'] } let(:model) { Relation } diff --git a/spec/models/queries/relations/filters/involved_filter_spec.rb b/spec/models/queries/relations/filters/involved_filter_spec.rb index bdbb61875f5..34041545c4b 100644 --- a/spec/models/queries/relations/filters/involved_filter_spec.rb +++ b/spec/models/queries/relations/filters/involved_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Relations::Filters::InvolvedFilter do +RSpec.describe Queries::Relations::Filters::InvolvedFilter do include_context 'filter tests' let(:values) { ['1'] } let(:model) { Relation } diff --git a/spec/models/queries/relations/filters/to_filter_spec.rb b/spec/models/queries/relations/filters/to_filter_spec.rb index 4737c299f07..d83d33a598c 100644 --- a/spec/models/queries/relations/filters/to_filter_spec.rb +++ b/spec/models/queries/relations/filters/to_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Relations::Filters::ToFilter do +RSpec.describe Queries::Relations::Filters::ToFilter do include_context 'filter tests' let(:values) { ['1'] } let(:model) { Relation } diff --git a/spec/models/queries/relations/relation_query_spec.rb b/spec/models/queries/relations/relation_query_spec.rb index b2e7254595a..915c1428ed6 100644 --- a/spec/models/queries/relations/relation_query_spec.rb +++ b/spec/models/queries/relations/relation_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Relations::RelationQuery do +RSpec.describe Queries::Relations::RelationQuery do let(:instance) { described_class.new } let(:base_scope) { Relation.order(id: :desc) } diff --git a/spec/models/queries/roles/filters/grantable_filter_spec.rb b/spec/models/queries/roles/filters/grantable_filter_spec.rb index b4e9fec292a..85fb3163d4f 100644 --- a/spec/models/queries/roles/filters/grantable_filter_spec.rb +++ b/spec/models/queries/roles/filters/grantable_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Roles::Filters::GrantableFilter do +RSpec.describe Queries::Roles::Filters::GrantableFilter do it_behaves_like 'basic query filter' do let(:class_key) { :grantable } let(:type) { :list } diff --git a/spec/models/queries/roles/filters/unit_filter_spec.rb b/spec/models/queries/roles/filters/unit_filter_spec.rb index 06732d85847..ac24c256b9c 100644 --- a/spec/models/queries/roles/filters/unit_filter_spec.rb +++ b/spec/models/queries/roles/filters/unit_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Roles::Filters::UnitFilter do +RSpec.describe Queries::Roles::Filters::UnitFilter do it_behaves_like 'basic query filter' do let(:class_key) { :unit } let(:type) { :list } diff --git a/spec/models/queries/users/filters/any_name_attribute_filter_spec.rb b/spec/models/queries/users/filters/any_name_attribute_filter_spec.rb index 8e1283baad7..9324c2cf9e8 100644 --- a/spec/models/queries/users/filters/any_name_attribute_filter_spec.rb +++ b/spec/models/queries/users/filters/any_name_attribute_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Users::Filters::AnyNameAttributeFilter do +RSpec.describe Queries::Users::Filters::AnyNameAttributeFilter do include_context 'filter tests' let(:values) { ['A name'] } let(:model) { User.user } diff --git a/spec/models/queries/users/filters/group_filter_spec.rb b/spec/models/queries/users/filters/group_filter_spec.rb index cfb1361ed4f..1afb8d5c702 100644 --- a/spec/models/queries/users/filters/group_filter_spec.rb +++ b/spec/models/queries/users/filters/group_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Users::Filters::GroupFilter do +RSpec.describe Queries::Users::Filters::GroupFilter do let(:group1) { build_stubbed(:group) } let(:group2) { build_stubbed(:group) } diff --git a/spec/models/queries/users/filters/name_filter_spec.rb b/spec/models/queries/users/filters/name_filter_spec.rb index 9535f009fb2..458a2934887 100644 --- a/spec/models/queries/users/filters/name_filter_spec.rb +++ b/spec/models/queries/users/filters/name_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Users::Filters::NameFilter do +RSpec.describe Queries::Users::Filters::NameFilter do include_context 'filter tests' let(:values) { ['A name'] } let(:model) { User.user } diff --git a/spec/models/queries/users/filters/status_filter_spec.rb b/spec/models/queries/users/filters/status_filter_spec.rb index 18213d73b7a..66597a75f40 100644 --- a/spec/models/queries/users/filters/status_filter_spec.rb +++ b/spec/models/queries/users/filters/status_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Users::Filters::StatusFilter do +RSpec.describe Queries::Users::Filters::StatusFilter do it_behaves_like 'basic query filter' do let(:class_key) { :status } let(:type) { :list } diff --git a/spec/models/queries/users/user_query_spec.rb b/spec/models/queries/users/user_query_spec.rb index e5a43ed2ef9..d5dba6df36e 100644 --- a/spec/models/queries/users/user_query_spec.rb +++ b/spec/models/queries/users/user_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Users::UserQuery do +RSpec.describe Queries::Users::UserQuery do let(:instance) { described_class.new } let(:base_scope) { User.user.order(id: :desc) } diff --git a/spec/models/queries/views/filters/type_filter_spec.rb b/spec/models/queries/views/filters/type_filter_spec.rb index 9d284b74759..c2eb0f74900 100644 --- a/spec/models/queries/views/filters/type_filter_spec.rb +++ b/spec/models/queries/views/filters/type_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Views::Filters::TypeFilter do +RSpec.describe Queries::Views::Filters::TypeFilter do let(:current_user) { create(:user) } before do diff --git a/spec/models/queries/work_packages/columns/custom_field_column_spec.rb b/spec/models/queries/work_packages/columns/custom_field_column_spec.rb index 4f330b514b3..6b91b9ba9f9 100644 --- a/spec/models/queries/work_packages/columns/custom_field_column_spec.rb +++ b/spec/models/queries/work_packages/columns/custom_field_column_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative 'shared_query_column_specs' -describe Queries::WorkPackages::Columns::CustomFieldColumn do +RSpec.describe Queries::WorkPackages::Columns::CustomFieldColumn do let(:project) { build_stubbed(:project) } let(:custom_field) { build_stubbed(:string_wp_custom_field) } let(:instance) { described_class.new(custom_field) } diff --git a/spec/models/queries/work_packages/columns/property_column_spec.rb b/spec/models/queries/work_packages/columns/property_column_spec.rb index 87a256e52ca..3b94e438cc2 100644 --- a/spec/models/queries/work_packages/columns/property_column_spec.rb +++ b/spec/models/queries/work_packages/columns/property_column_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative 'shared_query_column_specs' -describe Queries::WorkPackages::Columns::PropertyColumn do +RSpec.describe Queries::WorkPackages::Columns::PropertyColumn do let(:instance) { described_class.new(:query_column) } it_behaves_like 'query column' diff --git a/spec/models/queries/work_packages/columns/relation_of_type_column_spec.rb b/spec/models/queries/work_packages/columns/relation_of_type_column_spec.rb index 88f03c287d7..57edec3e60e 100644 --- a/spec/models/queries/work_packages/columns/relation_of_type_column_spec.rb +++ b/spec/models/queries/work_packages/columns/relation_of_type_column_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative 'shared_query_column_specs' -describe Queries::WorkPackages::Columns::RelationOfTypeColumn do +RSpec.describe Queries::WorkPackages::Columns::RelationOfTypeColumn do let(:project) { build_stubbed(:project) } let(:type) { build_stubbed(:type) } let(:instance) { described_class.new(type) } diff --git a/spec/models/queries/work_packages/columns/relation_to_type_column_spec.rb b/spec/models/queries/work_packages/columns/relation_to_type_column_spec.rb index bb7bf439c80..05f72541e9d 100644 --- a/spec/models/queries/work_packages/columns/relation_to_type_column_spec.rb +++ b/spec/models/queries/work_packages/columns/relation_to_type_column_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative 'shared_query_column_specs' -describe Queries::WorkPackages::Columns::RelationToTypeColumn do +RSpec.describe Queries::WorkPackages::Columns::RelationToTypeColumn do let(:project) { build_stubbed(:project) } let(:type) { build_stubbed(:type) } let(:instance) { described_class.new(type) } diff --git a/spec/models/queries/work_packages/columns/shared_query_column_specs.rb b/spec/models/queries/work_packages/columns/shared_query_column_specs.rb index e36238c052c..0b479049a68 100644 --- a/spec/models/queries/work_packages/columns/shared_query_column_specs.rb +++ b/spec/models/queries/work_packages/columns/shared_query_column_specs.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_examples_for 'query column' do |sortable_by_default: false| +RSpec.shared_examples_for 'query column' do |sortable_by_default: false| describe '#groupable' do it 'is the name if true is provided' do instance.groupable = true diff --git a/spec/models/queries/work_packages/columns/work_package_column_spec.rb b/spec/models/queries/work_packages/columns/work_package_column_spec.rb index 55e91328174..c0a7835f09e 100644 --- a/spec/models/queries/work_packages/columns/work_package_column_spec.rb +++ b/spec/models/queries/work_packages/columns/work_package_column_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Columns::WorkPackageColumn do +RSpec.describe Queries::WorkPackages::Columns::WorkPackageColumn do it "allows to be constructed with attribute highlightable" do expect(described_class.new('foo', highlightable: true).highlightable?).to be(true) end diff --git a/spec/models/queries/work_packages/filter/assigned_to_filter_spec.rb b/spec/models/queries/work_packages/filter/assigned_to_filter_spec.rb index bcae6e08284..f997fa9040b 100644 --- a/spec/models/queries/work_packages/filter/assigned_to_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/assigned_to_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::AssignedToFilter do +RSpec.describe Queries::WorkPackages::Filter::AssignedToFilter do let(:instance) do filter = described_class.create! filter.values = values diff --git a/spec/models/queries/work_packages/filter/assignee_or_group_filter_spec.rb b/spec/models/queries/work_packages/filter/assignee_or_group_filter_spec.rb index ec24f93dced..4049c68da0a 100644 --- a/spec/models/queries/work_packages/filter/assignee_or_group_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/assignee_or_group_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::AssigneeOrGroupFilter do +RSpec.describe Queries::WorkPackages::Filter::AssigneeOrGroupFilter do let(:instance) do filter = described_class.create! filter.values = values diff --git a/spec/models/queries/work_packages/filter/attachment_content_filter_spec.rb b/spec/models/queries/work_packages/filter/attachment_content_filter_spec.rb index 1d11edd06ba..0d7c13c77fb 100644 --- a/spec/models/queries/work_packages/filter/attachment_content_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/attachment_content_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::AttachmentContentFilter do +RSpec.describe Queries::WorkPackages::Filter::AttachmentContentFilter do if OpenProject::Database.allows_tsv? context 'WP with attachment' do let(:context) { nil } diff --git a/spec/models/queries/work_packages/filter/attachment_file_name_filter_spec.rb b/spec/models/queries/work_packages/filter/attachment_file_name_filter_spec.rb index e576175df9e..9537ca06e78 100644 --- a/spec/models/queries/work_packages/filter/attachment_file_name_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/attachment_file_name_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::AttachmentFileNameFilter do +RSpec.describe Queries::WorkPackages::Filter::AttachmentFileNameFilter do if OpenProject::Database.allows_tsv? it_behaves_like 'basic query filter' do let(:type) { :text } diff --git a/spec/models/queries/work_packages/filter/author_filter_spec.rb b/spec/models/queries/work_packages/filter/author_filter_spec.rb index d81090f3b6f..2ff31e252db 100644 --- a/spec/models/queries/work_packages/filter/author_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/author_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::AuthorFilter do +RSpec.describe Queries::WorkPackages::Filter::AuthorFilter do it_behaves_like 'basic query filter' do let(:type) { :list } let(:class_key) { :author_id } diff --git a/spec/models/queries/work_packages/filter/blocked_filter_spec.rb b/spec/models/queries/work_packages/filter/blocked_filter_spec.rb index a55847ba7c0..67f360a4e81 100644 --- a/spec/models/queries/work_packages/filter/blocked_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/blocked_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::BlockedFilter do +RSpec.describe Queries::WorkPackages::Filter::BlockedFilter do it_behaves_like 'filter by work package id' do let(:class_key) { :blocked } diff --git a/spec/models/queries/work_packages/filter/blocks_filter_spec.rb b/spec/models/queries/work_packages/filter/blocks_filter_spec.rb index e47c6dd728e..bd119a1caca 100644 --- a/spec/models/queries/work_packages/filter/blocks_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/blocks_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::BlocksFilter do +RSpec.describe Queries::WorkPackages::Filter::BlocksFilter do it_behaves_like 'filter by work package id' do let(:class_key) { :blocks } diff --git a/spec/models/queries/work_packages/filter/category_filter_spec.rb b/spec/models/queries/work_packages/filter/category_filter_spec.rb index 10314b4128c..af0736f2557 100644 --- a/spec/models/queries/work_packages/filter/category_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/category_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::CategoryFilter do +RSpec.describe Queries::WorkPackages::Filter::CategoryFilter do it_behaves_like 'basic query filter' do let(:type) { :list_optional } let(:class_key) { :category_id } diff --git a/spec/models/queries/work_packages/filter/comment_filter_spec.rb b/spec/models/queries/work_packages/filter/comment_filter_spec.rb index 39cc1f02f9d..a24059aa804 100644 --- a/spec/models/queries/work_packages/filter/comment_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/comment_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::CommentFilter do +RSpec.describe Queries::WorkPackages::Filter::CommentFilter do it_behaves_like 'basic query filter' do let(:type) { :text } let(:class_key) { :comment } diff --git a/spec/models/queries/work_packages/filter/created_at_filter_spec.rb b/spec/models/queries/work_packages/filter/created_at_filter_spec.rb index 6b3b444e64a..a4fb1f2635b 100644 --- a/spec/models/queries/work_packages/filter/created_at_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/created_at_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::CreatedAtFilter do +RSpec.describe Queries::WorkPackages::Filter::CreatedAtFilter do it_behaves_like 'basic query filter' do let(:type) { :datetime_past } let(:class_key) { :created_at } diff --git a/spec/models/queries/work_packages/filter/custom_fields/contains_text_custom_field_filter_spec.rb b/spec/models/queries/work_packages/filter/custom_fields/contains_text_custom_field_filter_spec.rb index 26cbe78a552..ff76051a5c9 100644 --- a/spec/models/queries/work_packages/filter/custom_fields/contains_text_custom_field_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/custom_fields/contains_text_custom_field_filter_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::CustomFieldFilter, - 'with contains filter (Regression test #28348)' do +RSpec.describe Queries::WorkPackages::Filter::CustomFieldFilter, + 'with contains filter (Regression test #28348)' do let(:cf_accessor) { custom_field.column_name } let(:query) { build_stubbed(:query, project:) } let(:instance) do diff --git a/spec/models/queries/work_packages/filter/custom_fields/custom_field_filter_spec.rb b/spec/models/queries/work_packages/filter/custom_fields/custom_field_filter_spec.rb index e7b844f2676..d47b9f0c1a3 100644 --- a/spec/models/queries/work_packages/filter/custom_fields/custom_field_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/custom_fields/custom_field_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::CustomFieldFilter do +RSpec.describe Queries::WorkPackages::Filter::CustomFieldFilter do let(:project) { build_stubbed(:project) } let(:bool_wp_custom_field) { build_stubbed(:bool_wp_custom_field) } let(:int_wp_custom_field) { build_stubbed(:int_wp_custom_field) } diff --git a/spec/models/queries/work_packages/filter/dates_interval_filter_spec.rb b/spec/models/queries/work_packages/filter/dates_interval_filter_spec.rb index 36be8bfb405..3ea665e70a7 100644 --- a/spec/models/queries/work_packages/filter/dates_interval_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/dates_interval_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::DatesIntervalFilter do +RSpec.describe Queries::WorkPackages::Filter::DatesIntervalFilter do it_behaves_like 'basic query filter' do let(:type) { :date } let(:class_key) { :dates_interval } diff --git a/spec/models/queries/work_packages/filter/description_filter_spec.rb b/spec/models/queries/work_packages/filter/description_filter_spec.rb index f8cd5a7f294..83458972f58 100644 --- a/spec/models/queries/work_packages/filter/description_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/description_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::DescriptionFilter do +RSpec.describe Queries::WorkPackages::Filter::DescriptionFilter do it_behaves_like 'basic query filter' do let(:type) { :text } let(:class_key) { :description } diff --git a/spec/models/queries/work_packages/filter/done_ratio_filter_spec.rb b/spec/models/queries/work_packages/filter/done_ratio_filter_spec.rb index 59feff35019..322bc334310 100644 --- a/spec/models/queries/work_packages/filter/done_ratio_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/done_ratio_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::DoneRatioFilter do +RSpec.describe Queries::WorkPackages::Filter::DoneRatioFilter do it_behaves_like 'basic query filter' do let(:type) { :integer } let(:class_key) { :done_ratio } diff --git a/spec/models/queries/work_packages/filter/due_date_filter_spec.rb b/spec/models/queries/work_packages/filter/due_date_filter_spec.rb index 496f3ec97e6..fe5750179a4 100644 --- a/spec/models/queries/work_packages/filter/due_date_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/due_date_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::DueDateFilter do +RSpec.describe Queries::WorkPackages::Filter::DueDateFilter do it_behaves_like 'basic query filter' do let(:type) { :date } let(:class_key) { :due_date } diff --git a/spec/models/queries/work_packages/filter/duplicated_filter_spec.rb b/spec/models/queries/work_packages/filter/duplicated_filter_spec.rb index 5a30b6d5f0a..6cdbd245eb4 100644 --- a/spec/models/queries/work_packages/filter/duplicated_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/duplicated_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::DuplicatedFilter do +RSpec.describe Queries::WorkPackages::Filter::DuplicatedFilter do it_behaves_like 'filter by work package id' do let(:class_key) { :duplicated } diff --git a/spec/models/queries/work_packages/filter/duplicates_filter_spec.rb b/spec/models/queries/work_packages/filter/duplicates_filter_spec.rb index fb51ce7c0c9..bd7e43a619b 100644 --- a/spec/models/queries/work_packages/filter/duplicates_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/duplicates_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::DuplicatesFilter do +RSpec.describe Queries::WorkPackages::Filter::DuplicatesFilter do it_behaves_like 'filter by work package id' do let(:class_key) { :duplicates } diff --git a/spec/models/queries/work_packages/filter/duration_filter_spec.rb b/spec/models/queries/work_packages/filter/duration_filter_spec.rb index 8d9d24801f4..a9f3df28072 100644 --- a/spec/models/queries/work_packages/filter/duration_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/duration_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::DurationFilter do +RSpec.describe Queries::WorkPackages::Filter::DurationFilter do it_behaves_like 'basic query filter' do let(:type) { :integer } let(:class_key) { :duration } diff --git a/spec/models/queries/work_packages/filter/estimated_hours_filter_spec.rb b/spec/models/queries/work_packages/filter/estimated_hours_filter_spec.rb index 559a2b05848..f357965645c 100644 --- a/spec/models/queries/work_packages/filter/estimated_hours_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/estimated_hours_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::EstimatedHoursFilter do +RSpec.describe Queries::WorkPackages::Filter::EstimatedHoursFilter do it_behaves_like 'basic query filter' do let(:type) { :integer } let(:class_key) { :estimated_hours } diff --git a/spec/models/queries/work_packages/filter/follows_filter_spec.rb b/spec/models/queries/work_packages/filter/follows_filter_spec.rb index 8cf8536a6c4..489909e7828 100644 --- a/spec/models/queries/work_packages/filter/follows_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/follows_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::FollowsFilter do +RSpec.describe Queries::WorkPackages::Filter::FollowsFilter do it_behaves_like 'filter by work package id' do let(:class_key) { :follows } diff --git a/spec/models/queries/work_packages/filter/group_filter_spec.rb b/spec/models/queries/work_packages/filter/group_filter_spec.rb index 7c64e9e2e85..f145f81e840 100644 --- a/spec/models/queries/work_packages/filter/group_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/group_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::GroupFilter do +RSpec.describe Queries::WorkPackages::Filter::GroupFilter do let(:group) { build_stubbed(:group) } it_behaves_like 'basic query filter' do diff --git a/spec/models/queries/work_packages/filter/id_filter_spec.rb b/spec/models/queries/work_packages/filter/id_filter_spec.rb index 250f8b60d35..dc8f38ae303 100644 --- a/spec/models/queries/work_packages/filter/id_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/id_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::IdFilter do +RSpec.describe Queries::WorkPackages::Filter::IdFilter do it_behaves_like 'filter by work package id' do let(:class_key) { :id } diff --git a/spec/models/queries/work_packages/filter/includes_filter_spec.rb b/spec/models/queries/work_packages/filter/includes_filter_spec.rb index d384f027a98..622f2a8d18b 100644 --- a/spec/models/queries/work_packages/filter/includes_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/includes_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::IncludesFilter do +RSpec.describe Queries::WorkPackages::Filter::IncludesFilter do it_behaves_like 'filter by work package id' do let(:class_key) { :includes } diff --git a/spec/models/queries/work_packages/filter/manual_sort_filter_spec.rb b/spec/models/queries/work_packages/filter/manual_sort_filter_spec.rb index 54ffd3eb5ef..e4dff2c355a 100644 --- a/spec/models/queries/work_packages/filter/manual_sort_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/manual_sort_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::ManualSortFilter do +RSpec.describe Queries::WorkPackages::Filter::ManualSortFilter do let!(:in_order) { create(:work_package) } let!(:in_order2) { create(:work_package) } let!(:out_order) { create(:work_package) } diff --git a/spec/models/queries/work_packages/filter/milestone_filter_spec.rb b/spec/models/queries/work_packages/filter/milestone_filter_spec.rb index 6457081fb61..cffad037766 100644 --- a/spec/models/queries/work_packages/filter/milestone_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/milestone_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::MilestoneFilter do +RSpec.describe Queries::WorkPackages::Filter::MilestoneFilter do it_behaves_like 'basic query filter' do let(:type) { :list } let(:class_key) { :is_milestone } diff --git a/spec/models/queries/work_packages/filter/parent_filter_spec.rb b/spec/models/queries/work_packages/filter/parent_filter_spec.rb index 972f3b7499a..b57caab5c93 100644 --- a/spec/models/queries/work_packages/filter/parent_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/parent_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::ParentFilter do +RSpec.describe Queries::WorkPackages::Filter::ParentFilter do let(:project) { build_stubbed(:project) } let(:query) do build_stubbed(:query, project:) diff --git a/spec/models/queries/work_packages/filter/partof_filter_spec.rb b/spec/models/queries/work_packages/filter/partof_filter_spec.rb index 88ea22a102b..2d7b3594203 100644 --- a/spec/models/queries/work_packages/filter/partof_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/partof_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::PartofFilter do +RSpec.describe Queries::WorkPackages::Filter::PartofFilter do it_behaves_like 'filter by work package id' do let(:class_key) { :partof } diff --git a/spec/models/queries/work_packages/filter/precedes_filter_spec.rb b/spec/models/queries/work_packages/filter/precedes_filter_spec.rb index 48932ab9c0d..56f48e61956 100644 --- a/spec/models/queries/work_packages/filter/precedes_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/precedes_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::PrecedesFilter do +RSpec.describe Queries::WorkPackages::Filter::PrecedesFilter do it_behaves_like 'filter by work package id' do let(:class_key) { :precedes } diff --git a/spec/models/queries/work_packages/filter/principal_loader_spec.rb b/spec/models/queries/work_packages/filter/principal_loader_spec.rb index 2b7b037aaae..a44404e2558 100644 --- a/spec/models/queries/work_packages/filter/principal_loader_spec.rb +++ b/spec/models/queries/work_packages/filter/principal_loader_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::PrincipalLoader do +RSpec.describe Queries::WorkPackages::Filter::PrincipalLoader do let(:user) { build_stubbed(:user) } let(:group) { build_stubbed(:group) } let(:placeholder_user) { build_stubbed(:placeholder_user) } diff --git a/spec/models/queries/work_packages/filter/priority_filter_spec.rb b/spec/models/queries/work_packages/filter/priority_filter_spec.rb index 56dc47560be..584bf00ca3a 100644 --- a/spec/models/queries/work_packages/filter/priority_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/priority_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::PriorityFilter do +RSpec.describe Queries::WorkPackages::Filter::PriorityFilter do let(:priority) { build_stubbed(:priority) } it_behaves_like 'basic query filter' do diff --git a/spec/models/queries/work_packages/filter/project_filter_instance_spec.rb b/spec/models/queries/work_packages/filter/project_filter_instance_spec.rb index fd9ebaf082b..1e9cadddc28 100644 --- a/spec/models/queries/work_packages/filter/project_filter_instance_spec.rb +++ b/spec/models/queries/work_packages/filter/project_filter_instance_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::ProjectFilter do +RSpec.describe Queries::WorkPackages::Filter::ProjectFilter do let(:query) { build(:query) } let(:instance) do described_class.create!(name: 'project', context: query, operator: '=', values: []) diff --git a/spec/models/queries/work_packages/filter/project_filter_spec.rb b/spec/models/queries/work_packages/filter/project_filter_spec.rb index 98d52077862..9e92a4736f3 100644 --- a/spec/models/queries/work_packages/filter/project_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/project_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::ProjectFilter do +RSpec.describe Queries::WorkPackages::Filter::ProjectFilter do it_behaves_like 'basic query filter' do let(:type) { :list } let(:class_key) { :project_id } diff --git a/spec/models/queries/work_packages/filter/relates_filter_spec.rb b/spec/models/queries/work_packages/filter/relates_filter_spec.rb index 051bacc5338..c5daa02bb6d 100644 --- a/spec/models/queries/work_packages/filter/relates_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/relates_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::RelatesFilter do +RSpec.describe Queries::WorkPackages::Filter::RelatesFilter do it_behaves_like 'filter by work package id' do let(:class_key) { :relates } diff --git a/spec/models/queries/work_packages/filter/required_filter_spec.rb b/spec/models/queries/work_packages/filter/required_filter_spec.rb index 378d7e72171..125479dd780 100644 --- a/spec/models/queries/work_packages/filter/required_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/required_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::RequiredFilter do +RSpec.describe Queries::WorkPackages::Filter::RequiredFilter do it_behaves_like 'filter by work package id' do let(:class_key) { :required } diff --git a/spec/models/queries/work_packages/filter/requires_filter_spec.rb b/spec/models/queries/work_packages/filter/requires_filter_spec.rb index e63463515d3..c9d96f707e9 100644 --- a/spec/models/queries/work_packages/filter/requires_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/requires_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::RequiresFilter do +RSpec.describe Queries::WorkPackages::Filter::RequiresFilter do it_behaves_like 'filter by work package id' do let(:class_key) { :requires } diff --git a/spec/models/queries/work_packages/filter/responsible_filter_spec.rb b/spec/models/queries/work_packages/filter/responsible_filter_spec.rb index 58e12397a54..b0de7a09c94 100644 --- a/spec/models/queries/work_packages/filter/responsible_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/responsible_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::ResponsibleFilter do +RSpec.describe Queries::WorkPackages::Filter::ResponsibleFilter do let(:instance) do filter = described_class.create! filter.values = values diff --git a/spec/models/queries/work_packages/filter/role_filter_spec.rb b/spec/models/queries/work_packages/filter/role_filter_spec.rb index fed7213bac8..be377a5f705 100644 --- a/spec/models/queries/work_packages/filter/role_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/role_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::RoleFilter do +RSpec.describe Queries::WorkPackages::Filter::RoleFilter do let(:role) { build_stubbed(:role) } it_behaves_like 'basic query filter' do diff --git a/spec/models/queries/work_packages/filter/search_filter_spec.rb b/spec/models/queries/work_packages/filter/search_filter_spec.rb index 0f462859172..72ca35d94e7 100644 --- a/spec/models/queries/work_packages/filter/search_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/search_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::SearchFilter do +RSpec.describe Queries::WorkPackages::Filter::SearchFilter do let(:context) { nil } let(:value) { 'bogus' } let(:operator) { '**' } diff --git a/spec/models/queries/work_packages/filter/start_date_filter_spec.rb b/spec/models/queries/work_packages/filter/start_date_filter_spec.rb index b171624867a..86731367ffe 100644 --- a/spec/models/queries/work_packages/filter/start_date_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/start_date_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::StartDateFilter do +RSpec.describe Queries::WorkPackages::Filter::StartDateFilter do it_behaves_like 'basic query filter' do let(:type) { :date } let(:class_key) { :start_date } diff --git a/spec/models/queries/work_packages/filter/status_filter_spec.rb b/spec/models/queries/work_packages/filter/status_filter_spec.rb index bd945302f35..c583a3d343c 100644 --- a/spec/models/queries/work_packages/filter/status_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/status_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::StatusFilter do +RSpec.describe Queries::WorkPackages::Filter::StatusFilter do let(:status) { build_stubbed(:status) } let(:status2) { build_stubbed(:status) } diff --git a/spec/models/queries/work_packages/filter/subject_filter_spec.rb b/spec/models/queries/work_packages/filter/subject_filter_spec.rb index e44fa6f6818..511b06320f0 100644 --- a/spec/models/queries/work_packages/filter/subject_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/subject_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::SubjectFilter do +RSpec.describe Queries::WorkPackages::Filter::SubjectFilter do it_behaves_like 'basic query filter' do let(:type) { :text } let(:class_key) { :subject } diff --git a/spec/models/queries/work_packages/filter/subject_or_id_filter_spec.rb b/spec/models/queries/work_packages/filter/subject_or_id_filter_spec.rb index 703db244091..f36db89e1c6 100644 --- a/spec/models/queries/work_packages/filter/subject_or_id_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/subject_or_id_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::SubjectOrIdFilter do +RSpec.describe Queries::WorkPackages::Filter::SubjectOrIdFilter do let(:value) { 'bogus' } let(:operator) { '**' } let(:subject) { 'Some subject' } diff --git a/spec/models/queries/work_packages/filter/subproject_filter_spec.rb b/spec/models/queries/work_packages/filter/subproject_filter_spec.rb index 4f41fd6d198..dd21a6a19e7 100644 --- a/spec/models/queries/work_packages/filter/subproject_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/subproject_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::SubprojectFilter do +RSpec.describe Queries::WorkPackages::Filter::SubprojectFilter do it_behaves_like 'basic query filter' do let(:type) { :list_optional } let(:class_key) { :subproject_id } diff --git a/spec/models/queries/work_packages/filter/type_filter_spec.rb b/spec/models/queries/work_packages/filter/type_filter_spec.rb index 71a61aad724..21b2475cb3f 100644 --- a/spec/models/queries/work_packages/filter/type_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/type_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::TypeFilter do +RSpec.describe Queries::WorkPackages::Filter::TypeFilter do it_behaves_like 'basic query filter' do let(:type) { :list } let(:class_key) { :type_id } diff --git a/spec/models/queries/work_packages/filter/updated_at_filter_spec.rb b/spec/models/queries/work_packages/filter/updated_at_filter_spec.rb index 4667f25a8b3..2e7dba41f33 100644 --- a/spec/models/queries/work_packages/filter/updated_at_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/updated_at_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::UpdatedAtFilter do +RSpec.describe Queries::WorkPackages::Filter::UpdatedAtFilter do it_behaves_like 'basic query filter' do let(:type) { :datetime_past } let(:class_key) { :updated_at } diff --git a/spec/models/queries/work_packages/filter/version_filter_spec.rb b/spec/models/queries/work_packages/filter/version_filter_spec.rb index 0e1da966f2f..120cff0c478 100644 --- a/spec/models/queries/work_packages/filter/version_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/version_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::VersionFilter do +RSpec.describe Queries::WorkPackages::Filter::VersionFilter do let(:version) { build_stubbed(:version) } it_behaves_like 'basic query filter' do diff --git a/spec/models/queries/work_packages/filter/watcher_filter_spec.rb b/spec/models/queries/work_packages/filter/watcher_filter_spec.rb index 9ad36b53b3c..f2624124e42 100644 --- a/spec/models/queries/work_packages/filter/watcher_filter_spec.rb +++ b/spec/models/queries/work_packages/filter/watcher_filter_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::WorkPackages::Filter::WatcherFilter do +RSpec.describe Queries::WorkPackages::Filter::WatcherFilter do let(:user) { build_stubbed(:user) } it_behaves_like 'basic query filter' do diff --git a/spec/models/queries/work_packages/manual_sorting_spec.rb b/spec/models/queries/work_packages/manual_sorting_spec.rb index 01f70f10f8f..199b6653553 100644 --- a/spec/models/queries/work_packages/manual_sorting_spec.rb +++ b/spec/models/queries/work_packages/manual_sorting_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Query, "manual sorting " do +RSpec.describe Query, "manual sorting " do shared_let(:user) { create(:admin) } shared_let(:project) { create(:project) } shared_let(:query) { create(:query, user:, project:) } diff --git a/spec/models/query/default_query_spec.rb b/spec/models/query/default_query_spec.rb index b6329f1d825..f6a647e6031 100644 --- a/spec/models/query/default_query_spec.rb +++ b/spec/models/query/default_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe "default query" do +RSpec.describe "default query" do let(:query) { Query.new_default } describe "highlighting mode" do diff --git a/spec/models/query/results_cf_sorting_integration_spec.rb b/spec/models/query/results_cf_sorting_integration_spec.rb index af5d2513e9e..053c978991c 100644 --- a/spec/models/query/results_cf_sorting_integration_spec.rb +++ b/spec/models/query/results_cf_sorting_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Query::Results, 'Sorting of custom field floats', with_mail: false do +RSpec.describe Query::Results, 'Sorting of custom field floats', with_mail: false do let(:query_results) do Query::Results.new query end diff --git a/spec/models/query/results_custom_field_filter_integration_spec.rb b/spec/models/query/results_custom_field_filter_integration_spec.rb index f342d079293..281828d580f 100644 --- a/spec/models/query/results_custom_field_filter_integration_spec.rb +++ b/spec/models/query/results_custom_field_filter_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Query::Results, 'Filtering custom fields', with_mail: false do +RSpec.describe Query::Results, 'Filtering custom fields', with_mail: false do shared_let(:user) { create(:admin) } shared_let(:custom_field) do create( diff --git a/spec/models/query/results_filter_on_historic_data_spec.rb b/spec/models/query/results_filter_on_historic_data_spec.rb index 630832a4d66..0ef4a8cc128 100644 --- a/spec/models/query/results_filter_on_historic_data_spec.rb +++ b/spec/models/query/results_filter_on_historic_data_spec.rb @@ -28,11 +28,11 @@ require 'spec_helper' -describe Query::Results, - 'Filter on historic data', - with_ee: %i[baseline_comparison], - with_flag: { show_changes: true }, - with_mail: false do +RSpec.describe Query::Results, + 'Filter on historic data', + with_ee: %i[baseline_comparison], + with_flag: { show_changes: true }, + with_mail: false do let(:historic_time) { "2022-08-01".to_datetime } let(:pre_historic_time) { historic_time - 1.day } let(:recent_time) { 1.hour.ago } diff --git a/spec/models/query/results_project_filter_integration_spec.rb b/spec/models/query/results_project_filter_integration_spec.rb index b8f807fe209..3379dde2d5b 100644 --- a/spec/models/query/results_project_filter_integration_spec.rb +++ b/spec/models/query/results_project_filter_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Query::Results, 'Project filter integration', with_mail: false do +RSpec.describe Query::Results, 'Project filter integration', with_mail: false do let(:query) do build(:query, user:, diff --git a/spec/models/query/results_sort_intergration_spec.rb b/spec/models/query/results_sort_intergration_spec.rb index 325a733633e..696e6d70a2e 100644 --- a/spec/models/query/results_sort_intergration_spec.rb +++ b/spec/models/query/results_sort_intergration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Query::Results, 'sorting and grouping', with_mail: false do +RSpec.describe Query::Results, 'sorting and grouping', with_mail: false do create_shared_association_defaults_for_work_package_factory let(:query) do diff --git a/spec/models/query/results_spec.rb b/spec/models/query/results_spec.rb index 483fc471d59..7d018e095a3 100644 --- a/spec/models/query/results_spec.rb +++ b/spec/models/query/results_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Query::Results, with_mail: false do +RSpec.describe Query::Results, with_mail: false do let(:query) do build(:query, show_hierarchies: false) diff --git a/spec/models/query/results_subject_filter_integration_spec.rb b/spec/models/query/results_subject_filter_integration_spec.rb index e3399d7bb94..498c79298b4 100644 --- a/spec/models/query/results_subject_filter_integration_spec.rb +++ b/spec/models/query/results_subject_filter_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Query::Results, 'Subject filter integration', with_mail: false do +RSpec.describe Query::Results, 'Subject filter integration', with_mail: false do let(:query_results) do described_class.new query end diff --git a/spec/models/query/results_subproject_filter_integration_spec.rb b/spec/models/query/results_subproject_filter_integration_spec.rb index 9396612acb8..e48d017ff6f 100644 --- a/spec/models/query/results_subproject_filter_integration_spec.rb +++ b/spec/models/query/results_subproject_filter_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Query::Results, 'Subproject filter integration', with_mail: false do +RSpec.describe Query::Results, 'Subproject filter integration', with_mail: false do let(:query) do build(:query, user:, diff --git a/spec/models/query/results_sums_integration_spec.rb b/spec/models/query/results_sums_integration_spec.rb index c0d43d83ccb..33fb1908c64 100644 --- a/spec/models/query/results_sums_integration_spec.rb +++ b/spec/models/query/results_sums_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Query::Results, 'sums' do +RSpec.describe Query::Results, 'sums' do let(:project) do create(:project).tap do |p| p.work_package_custom_fields << int_cf diff --git a/spec/models/query/results_version_integration_spec.rb b/spec/models/query/results_version_integration_spec.rb index 3ba0d93480f..2542b3de5bc 100644 --- a/spec/models/query/results_version_integration_spec.rb +++ b/spec/models/query/results_version_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Query::Results, 'Grouping and sorting for version', with_mail: false do +RSpec.describe Query::Results, 'Grouping and sorting for version', with_mail: false do let(:query_results) do Query::Results.new query end diff --git a/spec/models/query/scopes/visible_spec.rb b/spec/models/query/scopes/visible_spec.rb index d17c88f7644..8948c65b85c 100644 --- a/spec/models/query/scopes/visible_spec.rb +++ b/spec/models/query/scopes/visible_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Scopes::Visible do +RSpec.describe Queries::Scopes::Visible do describe '.visible' do subject(:scope) { Query.visible(user) } diff --git a/spec/models/query/sort_criteria_spec.rb b/spec/models/query/sort_criteria_spec.rb index 59749e0c75e..8066fd88727 100644 --- a/spec/models/query/sort_criteria_spec.rb +++ b/spec/models/query/sort_criteria_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Query::SortCriteria do +RSpec.describe Query::SortCriteria do let(:query) do build_stubbed(:query, show_hierarchies: false) diff --git a/spec/models/query/timestamps_spec.rb b/spec/models/query/timestamps_spec.rb index 5aaf6fff699..6aead098e81 100644 --- a/spec/models/query/timestamps_spec.rb +++ b/spec/models/query/timestamps_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe Query::Timestamps, - with_ee: %i[baseline_comparison], with_flag: { show_changes: true } do +RSpec.describe Query::Timestamps, + with_ee: %i[baseline_comparison], with_flag: { show_changes: true } do describe "#timestamps" do subject { query.timestamps } diff --git a/spec/models/query_spec.rb b/spec/models/query_spec.rb index 2735d5e17fa..ffc4684034b 100644 --- a/spec/models/query_spec.rb +++ b/spec/models/query_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe Query, - with_ee: %i[baseline_comparison conditional_highlighting work_package_query_relation_columns] do +RSpec.describe Query, + with_ee: %i[baseline_comparison conditional_highlighting work_package_query_relation_columns] do let(:query) { build(:query) } let(:project) { create(:project) } diff --git a/spec/models/relation_spec.rb b/spec/models/relation_spec.rb index 290755bda6a..b593a8eba54 100644 --- a/spec/models/relation_spec.rb +++ b/spec/models/relation_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe Relation do +RSpec.describe Relation do create_shared_association_defaults_for_work_package_factory let(:from) { create(:work_package) } diff --git a/spec/models/relations/scopes/visible_spec.rb b/spec/models/relations/scopes/visible_spec.rb index eb0210033ae..97bad3708a4 100644 --- a/spec/models/relations/scopes/visible_spec.rb +++ b/spec/models/relations/scopes/visible_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Relations::Scopes::Visible do +RSpec.describe Relations::Scopes::Visible do let(:from) { create(:work_package, project: project1) } let(:intermediary) { create(:work_package, project: project1) } let(:to) { create(:work_package, project: project2) } diff --git a/spec/models/reports_services_spec.rb b/spec/models/reports_services_spec.rb index 26e9c8b7d75..a22002435f0 100644 --- a/spec/models/reports_services_spec.rb +++ b/spec/models/reports_services_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Reports::ReportsService do +RSpec.describe Reports::ReportsService do let(:project) { create(:project) } it 'is initializable with a project' do diff --git a/spec/models/repository/git_spec.rb b/spec/models/repository/git_spec.rb index b03f745fb27..409360dc229 100644 --- a/spec/models/repository/git_spec.rb +++ b/spec/models/repository/git_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Repository::Git do +RSpec.describe Repository::Git do let(:encoding) { 'UTF-8' } let(:instance) { build(:repository_git, path_encoding: encoding) } let(:adapter) { instance.scm } diff --git a/spec/models/repository/subversion_spec.rb b/spec/models/repository/subversion_spec.rb index d0e893f00d2..7b6286aeb97 100644 --- a/spec/models/repository/subversion_spec.rb +++ b/spec/models/repository/subversion_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Repository::Subversion do +RSpec.describe Repository::Subversion do let(:instance) { build(:repository_subversion) } let(:adapter) { instance.scm } let(:config) { {} } diff --git a/spec/models/role_spec.rb b/spec/models/role_spec.rb index d91de85233f..afffba451c4 100644 --- a/spec/models/role_spec.rb +++ b/spec/models/role_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Role do +RSpec.describe Role do let(:permissions) { %i[permission1 permission2] } let(:build_role) { build(:role, permissions:) } let(:created_role) { create(:role, permissions:) } diff --git a/spec/models/sessions/active_record_sessions_spec.rb b/spec/models/sessions/active_record_sessions_spec.rb index 1e4cc52938f..386a2d9abb4 100644 --- a/spec/models/sessions/active_record_sessions_spec.rb +++ b/spec/models/sessions/active_record_sessions_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Sessions::UserSession do +RSpec.describe Sessions::UserSession do subject { described_class.new session_id: 'foo' } describe '#save' do diff --git a/spec/models/sessions/sql_bypass_sessions_spec.rb b/spec/models/sessions/sql_bypass_sessions_spec.rb index 89ce538e44b..a84788b678b 100644 --- a/spec/models/sessions/sql_bypass_sessions_spec.rb +++ b/spec/models/sessions/sql_bypass_sessions_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Sessions::SqlBypass do +RSpec.describe Sessions::SqlBypass do subject { build(:user_session, user:) } shared_examples 'augments the user_id attribute' do diff --git a/spec/models/setting_spec.rb b/spec/models/setting_spec.rb index d3391c59984..0d5c5f44eec 100644 --- a/spec/models/setting_spec.rb +++ b/spec/models/setting_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Setting do +RSpec.describe Setting do before do described_class.clear_cache described_class.destroy_all diff --git a/spec/models/status_spec.rb b/spec/models/status_spec.rb index cbec0c9095c..f6ac574d300 100644 --- a/spec/models/status_spec.rb +++ b/spec/models/status_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Status do +RSpec.describe Status do let(:stubbed_status) { build_stubbed(:status) } describe 'default status' do diff --git a/spec/models/system_user_spec.rb b/spec/models/system_user_spec.rb index 71409bf400b..06ceb26f0ac 100644 --- a/spec/models/system_user_spec.rb +++ b/spec/models/system_user_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe SystemUser do +RSpec.describe SystemUser do let(:system_user) { User.system } describe '#run_given' do diff --git a/spec/models/timestamp_spec.rb b/spec/models/timestamp_spec.rb index e9f1ab7e914..0eace508d2e 100644 --- a/spec/models/timestamp_spec.rb +++ b/spec/models/timestamp_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Timestamp do +RSpec.describe Timestamp do describe ".new" do describe "when calling without argument" do subject { described_class.new } diff --git a/spec/models/token/base_token_spec.rb b/spec/models/token/base_token_spec.rb index 8bb4882fe46..9db05dd854a 100644 --- a/spec/models/token/base_token_spec.rb +++ b/spec/models/token/base_token_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Token::Base do +RSpec.describe Token::Base do let(:user) { build(:user) } subject { described_class.new user: } diff --git a/spec/models/token/hashed_token_spec.rb b/spec/models/token/hashed_token_spec.rb index 7ae19d7fe09..cd31c3fb057 100644 --- a/spec/models/token/hashed_token_spec.rb +++ b/spec/models/token/hashed_token_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Token::HashedToken do +RSpec.describe Token::HashedToken do let(:user) { build(:user) } subject { described_class.new user: } diff --git a/spec/models/type/attribute_groups_spec.rb b/spec/models/type/attribute_groups_spec.rb index af884407d8e..eece940abf0 100644 --- a/spec/models/type/attribute_groups_spec.rb +++ b/spec/models/type/attribute_groups_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Type do +RSpec.describe Type do let(:type) { build(:type) } shared_let(:admin) { create(:admin) } diff --git a/spec/models/type_spec.rb b/spec/models/type_spec.rb index 4160b21c120..46a236ec560 100644 --- a/spec/models/type_spec.rb +++ b/spec/models/type_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Type do +RSpec.describe Type do let(:type) { build(:type) } let(:type2) { build(:type) } let(:project) { build(:project, no_types: true) } diff --git a/spec/models/types/scopes/milestone_spec.rb b/spec/models/types/scopes/milestone_spec.rb index 5732eab349f..2f628808577 100644 --- a/spec/models/types/scopes/milestone_spec.rb +++ b/spec/models/types/scopes/milestone_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Types::Scopes::Milestone do +RSpec.describe Types::Scopes::Milestone do let!(:milestone) { create(:type, is_milestone: true) } let!(:other_type) { create(:type, is_milestone: false) } diff --git a/spec/models/user_password_spec.rb b/spec/models/user_password_spec.rb index 6537a031ef9..49188de232f 100644 --- a/spec/models/user_password_spec.rb +++ b/spec/models/user_password_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe UserPassword do +RSpec.describe UserPassword do let(:old_password) { create(:old_user_password) } let(:user) { create(:user) } let(:password) { create(:user_password, user:, plain_password: 'adminAdmin!') } diff --git a/spec/models/user_passwords/sha1_spec.rb b/spec/models/user_passwords/sha1_spec.rb index b4a19066d3e..65f0fe62848 100644 --- a/spec/models/user_passwords/sha1_spec.rb +++ b/spec/models/user_passwords/sha1_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe UserPassword::SHA1 do +RSpec.describe UserPassword::SHA1 do let(:legacy_password) do pass = build(:legacy_sha1_password, plain_password: 'adminAdmin!') expect(pass).to receive(:salt_and_hash_password!).and_return nil diff --git a/spec/models/user_preference_spec.rb b/spec/models/user_preference_spec.rb index 46bc6abb065..53aff8ba98a 100644 --- a/spec/models/user_preference_spec.rb +++ b/spec/models/user_preference_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe UserPreference do +RSpec.describe UserPreference do subject(:preference) do build(:user_preference, user:, diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index a8ea76c7918..95e30938c49 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe User do +RSpec.describe User do let(:user) { build(:user) } let(:project) { create(:project_with_types) } let(:role) { create(:role, permissions: [:view_work_packages]) } diff --git a/spec/models/users/allowed_scope_spec.rb b/spec/models/users/allowed_scope_spec.rb index 7a6a4265ce4..52edcf0b40c 100644 --- a/spec/models/users/allowed_scope_spec.rb +++ b/spec/models/users/allowed_scope_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe User, 'allowed scope' do +RSpec.describe User, 'allowed scope' do let(:user) { member.principal } let(:anonymous) { build(:anonymous) } let(:project) { build(:project, public: false) } diff --git a/spec/models/users/allowed_to_spec.rb b/spec/models/users/allowed_to_spec.rb index c2120603b8f..868cf454a98 100644 --- a/spec/models/users/allowed_to_spec.rb +++ b/spec/models/users/allowed_to_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe User, 'allowed_to?' do +RSpec.describe User, 'allowed_to?' do let(:user) { build(:user) } let(:anonymous) { build(:anonymous) } let(:project) { build(:project, public: false) } diff --git a/spec/models/users/default_timezone_spec.rb b/spec/models/users/default_timezone_spec.rb index 28fb35f0906..fafde99a700 100644 --- a/spec/models/users/default_timezone_spec.rb +++ b/spec/models/users/default_timezone_spec.rb @@ -28,7 +28,7 @@ require "spec_helper" -describe User, "default time zone" do +RSpec.describe User, "default time zone" do let(:user) { create(:user) } context "with no system default set" do diff --git a/spec/models/users/scopes/find_by_login_spec.rb b/spec/models/users/scopes/find_by_login_spec.rb index be1ad844638..0b4867ed95d 100644 --- a/spec/models/users/scopes/find_by_login_spec.rb +++ b/spec/models/users/scopes/find_by_login_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Users::Scopes::FindByLogin do +RSpec.describe Users::Scopes::FindByLogin do let!(:activity) { create(:time_entry_activity) } let!(:project) { create(:project) } let!(:user) { create(:user, login:) } diff --git a/spec/models/users/scopes/having_reminder_mail_to_send_spec.rb b/spec/models/users/scopes/having_reminder_mail_to_send_spec.rb index 475717719c8..850dde0744e 100644 --- a/spec/models/users/scopes/having_reminder_mail_to_send_spec.rb +++ b/spec/models/users/scopes/having_reminder_mail_to_send_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe User, '.having_reminder_mail_to_send' do +RSpec.describe User, '.having_reminder_mail_to_send' do subject(:scope) do described_class.having_reminder_mail_to_send(scope_time) end diff --git a/spec/models/users/scopes/newest_spec.rb b/spec/models/users/scopes/newest_spec.rb index bf1beefe354..4a807fd24bf 100644 --- a/spec/models/users/scopes/newest_spec.rb +++ b/spec/models/users/scopes/newest_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Users::Scopes::Newest do +RSpec.describe Users::Scopes::Newest do describe '.newest' do let!(:anonymous_user) { create(:anonymous) } let!(:system_user) { create(:system) } diff --git a/spec/models/users/scopes/with_time_zone_spec.rb b/spec/models/users/scopes/with_time_zone_spec.rb index 67cef49f370..35453ff4e00 100644 --- a/spec/models/users/scopes/with_time_zone_spec.rb +++ b/spec/models/users/scopes/with_time_zone_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Users::Scopes::WithTimeZone do +RSpec.describe Users::Scopes::WithTimeZone do shared_let(:user_besancon) do create( :user, diff --git a/spec/models/version_spec.rb b/spec/models/version_spec.rb index f7d97e05e99..3a699bbd5d5 100644 --- a/spec/models/version_spec.rb +++ b/spec/models/version_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Version do +RSpec.describe Version do subject(:version) { build(:version, name: 'Test Version') } it { is_expected.to be_valid } diff --git a/spec/models/versions/scopes/order_by_semver_name_spec.rb b/spec/models/versions/scopes/order_by_semver_name_spec.rb index 034aceae87c..5d42101e398 100644 --- a/spec/models/versions/scopes/order_by_semver_name_spec.rb +++ b/spec/models/versions/scopes/order_by_semver_name_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Versions::Scopes::OrderBySemverName do +RSpec.describe Versions::Scopes::OrderBySemverName do let(:project) { create(:project) } let!(:version1) do create(:version, name: "aaaaa 1.", project:) diff --git a/spec/models/versions/scopes/rolled_up_spec.rb b/spec/models/versions/scopes/rolled_up_spec.rb index b37c7c9b50d..ff95169b2b6 100644 --- a/spec/models/versions/scopes/rolled_up_spec.rb +++ b/spec/models/versions/scopes/rolled_up_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Versions::Scopes::RolledUp do +RSpec.describe Versions::Scopes::RolledUp do shared_let(:parent_project) { create(:project) } shared_let(:project) { create(:project, parent: parent_project) } shared_let(:sibling_project) { create(:project, parent: parent_project) } diff --git a/spec/models/versions/scopes/shared_with_spec.rb b/spec/models/versions/scopes/shared_with_spec.rb index 3e6e5d270bb..272fe68209b 100644 --- a/spec/models/versions/scopes/shared_with_spec.rb +++ b/spec/models/versions/scopes/shared_with_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Versions::Scopes::SharedWith do +RSpec.describe Versions::Scopes::SharedWith do shared_let(:root_project) { create(:project) } shared_let(:parent_project) { create(:project, parent: root_project) } shared_let(:project) { create(:project, parent: parent_project) } diff --git a/spec/models/watcher_spec.rb b/spec/models/watcher_spec.rb index 945aec93391..bf20501cac4 100644 --- a/spec/models/watcher_spec.rb +++ b/spec/models/watcher_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Watcher, with_mail: false do +RSpec.describe Watcher, with_mail: false do let(:project) { watchable.project } let(:user) { build(:user, admin: true) } let(:watcher) do diff --git a/spec/models/wiki_page_spec.rb b/spec/models/wiki_page_spec.rb index c1a89077614..691589859bf 100644 --- a/spec/models/wiki_page_spec.rb +++ b/spec/models/wiki_page_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WikiPage do +RSpec.describe WikiPage do shared_let(:author) { create(:user) } shared_let(:project) { create(:project).reload } # a wiki is created for project, but the object doesn't know of it (FIXME?) diff --git a/spec/models/wiki_redirect_spec.rb b/spec/models/wiki_redirect_spec.rb index 956d2b07490..0e314c94fe2 100644 --- a/spec/models/wiki_redirect_spec.rb +++ b/spec/models/wiki_redirect_spec.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -describe WikiRedirect do +RSpec.describe WikiRedirect do let(:wiki) { create(:wiki) } let(:wiki_page) { create(:wiki_page, wiki:, title: 'Original title') } diff --git a/spec/models/wiki_spec.rb b/spec/models/wiki_spec.rb index a93e866ad72..19bd48b9909 100644 --- a/spec/models/wiki_spec.rb +++ b/spec/models/wiki_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Wiki do +RSpec.describe Wiki do let(:project) { create(:project, disable_modules: 'wiki') } let(:start_page) { 'The wiki start page' } let(:wiki) { project.create_wiki start_page: } diff --git a/spec/models/work_package/aggregate_ancestors_spec.rb b/spec/models/work_package/aggregate_ancestors_spec.rb index 85b70087336..cc065a1cda2 100644 --- a/spec/models/work_package/aggregate_ancestors_spec.rb +++ b/spec/models/work_package/aggregate_ancestors_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage::Ancestors do +RSpec.describe WorkPackage::Ancestors do let(:user) { create(:user) } let(:project) { create(:project) } let(:project2) { create(:project) } diff --git a/spec/models/work_package/ask_before_destruction_spec.rb b/spec/models/work_package/ask_before_destruction_spec.rb index 2728e6e2df7..3e90e145103 100644 --- a/spec/models/work_package/ask_before_destruction_spec.rb +++ b/spec/models/work_package/ask_before_destruction_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage do +RSpec.describe WorkPackage do let(:work_package) do create(:work_package, project:, status:) diff --git a/spec/models/work_package/exporter/csv_integration_spec.rb b/spec/models/work_package/exporter/csv_integration_spec.rb index ab2b763ab71..ee9df2f0126 100644 --- a/spec/models/work_package/exporter/csv_integration_spec.rb +++ b/spec/models/work_package/exporter/csv_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage::Exports::CSV, 'integration' do +RSpec.describe WorkPackage::Exports::CSV, 'integration' do before do login_as current_user end diff --git a/spec/models/work_package/hooks_spec.rb b/spec/models/work_package/hooks_spec.rb index d4265b29f2f..b6981ac0242 100644 --- a/spec/models/work_package/hooks_spec.rb +++ b/spec/models/work_package/hooks_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage do +RSpec.describe WorkPackage do describe "#create" do it "calls the create hook" do subject = "A new work package" diff --git a/spec/models/work_package/openproject_notifications_spec.rb b/spec/models/work_package/openproject_notifications_spec.rb index 9d6abf002ee..66683bdfc49 100644 --- a/spec/models/work_package/openproject_notifications_spec.rb +++ b/spec/models/work_package/openproject_notifications_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' ## # Tests that email notifications will be sent upon creating or changing a work package. -describe WorkPackage, with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe WorkPackage, with_settings: { journal_aggregation_time_minutes: 0 } do describe 'OpenProject notifications' do shared_let(:admin) { create(:admin) } diff --git a/spec/models/work_package/work_package_acts_as_customizable_spec.rb b/spec/models/work_package/work_package_acts_as_customizable_spec.rb index 0c9a42624ae..02365d7b67b 100644 --- a/spec/models/work_package/work_package_acts_as_customizable_spec.rb +++ b/spec/models/work_package/work_package_acts_as_customizable_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage, 'acts_as_customizable' do +RSpec.describe WorkPackage, 'acts_as_customizable' do let(:type) { create(:type_standard) } let(:project) { create(:project, types: [type]) } let(:user) { create(:user) } diff --git a/spec/models/work_package/work_package_acts_as_event_spec.rb b/spec/models/work_package/work_package_acts_as_event_spec.rb index bced302097c..2f6f0c6b405 100644 --- a/spec/models/work_package/work_package_acts_as_event_spec.rb +++ b/spec/models/work_package/work_package_acts_as_event_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage do +RSpec.describe WorkPackage do describe 'acts_as_event' do let(:stub_work_package) { build_stubbed(:work_package) } diff --git a/spec/models/work_package/work_package_acts_as_journalized_spec.rb b/spec/models/work_package/work_package_acts_as_journalized_spec.rb index 14a4783c4c4..0234a2f44c4 100644 --- a/spec/models/work_package/work_package_acts_as_journalized_spec.rb +++ b/spec/models/work_package/work_package_acts_as_journalized_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage do +RSpec.describe WorkPackage do describe '#journal' do let(:type) { create(:type) } let(:project) do diff --git a/spec/models/work_package/work_package_acts_as_searchable_spec.rb b/spec/models/work_package/work_package_acts_as_searchable_spec.rb index b35241cf92a..8500a9a4fbe 100644 --- a/spec/models/work_package/work_package_acts_as_searchable_spec.rb +++ b/spec/models/work_package/work_package_acts_as_searchable_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage, 'acts_as_searchable' do +RSpec.describe WorkPackage, 'acts_as_searchable' do include BecomeMember let(:wp_subject) { 'the quick brown fox jumps over the lazy dog' } diff --git a/spec/models/work_package/work_package_acts_as_watchable_spec.rb b/spec/models/work_package/work_package_acts_as_watchable_spec.rb index de3720448ec..110ac9d81ee 100644 --- a/spec/models/work_package/work_package_acts_as_watchable_spec.rb +++ b/spec/models/work_package/work_package_acts_as_watchable_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'support/shared/acts_as_watchable' -describe WorkPackage do +RSpec.describe WorkPackage do let(:project) { create(:project) } let(:work_package) do create(:work_package, diff --git a/spec/models/work_package/work_package_custom_actions_spec.rb b/spec/models/work_package/work_package_custom_actions_spec.rb index 9c40c2ca5ef..86f83505003 100644 --- a/spec/models/work_package/work_package_custom_actions_spec.rb +++ b/spec/models/work_package/work_package_custom_actions_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage, 'custom_actions' do +RSpec.describe WorkPackage, 'custom_actions' do let(:work_package) do build_stubbed(:work_package, project:) diff --git a/spec/models/work_package/work_package_custom_fields_spec.rb b/spec/models/work_package/work_package_custom_fields_spec.rb index 61e2ad9c1ee..e5b42e3c223 100644 --- a/spec/models/work_package/work_package_custom_fields_spec.rb +++ b/spec/models/work_package/work_package_custom_fields_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage do +RSpec.describe WorkPackage do describe '#custom_fields' do let(:type) { create(:type_standard) } let(:project) { create(:project, types: [type]) } diff --git a/spec/models/work_package/work_package_multi_value_custom_fields_spec.rb b/spec/models/work_package/work_package_multi_value_custom_fields_spec.rb index 4569848c025..34ee917a899 100644 --- a/spec/models/work_package/work_package_multi_value_custom_fields_spec.rb +++ b/spec/models/work_package/work_package_multi_value_custom_fields_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage do +RSpec.describe WorkPackage do let(:type) { create(:type) } let(:project) { create(:project, types: [type]) } diff --git a/spec/models/work_package/work_package_relations_spec.rb b/spec/models/work_package/work_package_relations_spec.rb index 03ae075570b..654e0074899 100644 --- a/spec/models/work_package/work_package_relations_spec.rb +++ b/spec/models/work_package/work_package_relations_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage do +RSpec.describe WorkPackage do describe '#relation' do let(:closed_state) do create(:status, diff --git a/spec/models/work_package/work_package_scheduling_spec.rb b/spec/models/work_package/work_package_scheduling_spec.rb index 18c536d4999..b1551959ba1 100644 --- a/spec/models/work_package/work_package_scheduling_spec.rb +++ b/spec/models/work_package/work_package_scheduling_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage do +RSpec.describe WorkPackage do describe '#overdue' do let(:work_package) do create(:work_package, diff --git a/spec/models/work_package/work_package_status_spec.rb b/spec/models/work_package/work_package_status_spec.rb index 6d2b38be6db..b1f71f6cb3b 100644 --- a/spec/models/work_package/work_package_status_spec.rb +++ b/spec/models/work_package/work_package_status_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage, 'status' do +RSpec.describe WorkPackage, 'status' do let(:status) { create(:status) } let!(:work_package) do create(:work_package, diff --git a/spec/models/work_package/work_package_visibility_spec.rb b/spec/models/work_package/work_package_visibility_spec.rb index bc00dd72617..54ef346d770 100644 --- a/spec/models/work_package/work_package_visibility_spec.rb +++ b/spec/models/work_package/work_package_visibility_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'WorkPackage-Visibility' do +RSpec.describe 'WorkPackage-Visibility' do shared_let(:admin) { create(:admin) } let(:anonymous) { create(:anonymous) } let(:user) { create(:user) } diff --git a/spec/models/work_package_custom_field_spec.rb b/spec/models/work_package_custom_field_spec.rb index cae5b6643bb..6c3bcda61ce 100644 --- a/spec/models/work_package_custom_field_spec.rb +++ b/spec/models/work_package_custom_field_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackageCustomField do +RSpec.describe WorkPackageCustomField do describe '.summable' do let!(:list_custom_field) do create(:list_wp_custom_field) diff --git a/spec/models/work_package_spec.rb b/spec/models/work_package_spec.rb index 2ec28e3e8e7..81d7d2fabf9 100644 --- a/spec/models/work_package_spec.rb +++ b/spec/models/work_package_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage do +RSpec.describe WorkPackage do let(:stub_work_package) { build_stubbed(:work_package) } let(:stub_version) { build_stubbed(:version) } let(:stub_project) { build_stubbed(:project) } diff --git a/spec/models/work_packages/blocks_relation_spec.rb b/spec/models/work_packages/blocks_relation_spec.rb index cb62745f1d4..aa525014a0e 100644 --- a/spec/models/work_packages/blocks_relation_spec.rb +++ b/spec/models/work_packages/blocks_relation_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage, 'blocks/blocked_by relations' do +RSpec.describe WorkPackage, 'blocks/blocked_by relations' do create_shared_association_defaults_for_work_package_factory shared_let(:work_package) { create(:work_package, subject: 'blocked wp') } diff --git a/spec/models/work_packages/derived_dates_spec.rb b/spec/models/work_packages/derived_dates_spec.rb index fb21ece4ecb..46d3d92fd81 100644 --- a/spec/models/work_packages/derived_dates_spec.rb +++ b/spec/models/work_packages/derived_dates_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage, 'derived dates' do +RSpec.describe WorkPackage, 'derived dates' do let(:work_package) do create(:work_package) end diff --git a/spec/models/work_packages/scopes/directly_related_spec.rb b/spec/models/work_packages/scopes/directly_related_spec.rb index 50ba9c9a6e7..4a378d89d1e 100644 --- a/spec/models/work_packages/scopes/directly_related_spec.rb +++ b/spec/models/work_packages/scopes/directly_related_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::Scopes::DirectlyRelated, '.directly_related scope' do +RSpec.describe WorkPackages::Scopes::DirectlyRelated, '.directly_related scope' do create_shared_association_defaults_for_work_package_factory shared_let(:origin) { create(:work_package) } diff --git a/spec/models/work_packages/scopes/for_scheduling_spec.rb b/spec/models/work_packages/scopes/for_scheduling_spec.rb index 53ef281da1c..a697245b43c 100644 --- a/spec/models/work_packages/scopes/for_scheduling_spec.rb +++ b/spec/models/work_packages/scopes/for_scheduling_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::Scopes::ForScheduling, 'allowed scope' do +RSpec.describe WorkPackages::Scopes::ForScheduling, 'allowed scope' do let(:project) { create(:project) } let(:origin) { create(:work_package, project:) } let(:predecessor) do diff --git a/spec/models/work_packages/scopes/involving_user_spec.rb b/spec/models/work_packages/scopes/involving_user_spec.rb index 1a4e9b6676d..fe98035fe95 100644 --- a/spec/models/work_packages/scopes/involving_user_spec.rb +++ b/spec/models/work_packages/scopes/involving_user_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::Scopes::InvolvingUser do +RSpec.describe WorkPackages::Scopes::InvolvingUser do create_shared_association_defaults_for_work_package_factory shared_let(:user) do diff --git a/spec/models/work_packages/scopes/relatable_spec.rb b/spec/models/work_packages/scopes/relatable_spec.rb index 4c65cfce1cb..9b4aab99487 100644 --- a/spec/models/work_packages/scopes/relatable_spec.rb +++ b/spec/models/work_packages/scopes/relatable_spec.rb @@ -26,7 +26,7 @@ require 'spec_helper' -describe WorkPackages::Scopes::Relatable, '.relatable scope' do +RSpec.describe WorkPackages::Scopes::Relatable, '.relatable scope' do create_shared_association_defaults_for_work_package_factory let(:origin) { create(:work_package) } diff --git a/spec/models/work_packages/search_spec.rb b/spec/models/work_packages/search_spec.rb index 102448df62f..10854b35afb 100644 --- a/spec/models/work_packages/search_spec.rb +++ b/spec/models/work_packages/search_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage, 'search' do +RSpec.describe WorkPackage, 'search' do shared_let(:description_searchword) { "descKeyword" } shared_let(:project) { create(:project) } shared_let(:work_package) do diff --git a/spec/models/work_packages/spent_time_spec.rb b/spec/models/work_packages/spent_time_spec.rb index 7d7a3fd00d0..9caa0ef791d 100644 --- a/spec/models/work_packages/spent_time_spec.rb +++ b/spec/models/work_packages/spent_time_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackage, 'spent_time' do +RSpec.describe WorkPackage, 'spent_time' do let(:project) do work_package.project end diff --git a/spec/models/workflow_spec.rb b/spec/models/workflow_spec.rb index 15b6d7c1f38..e4d76b6577b 100644 --- a/spec/models/workflow_spec.rb +++ b/spec/models/workflow_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Workflow do +RSpec.describe Workflow do describe '.copy' do shared_let(:status0) { create(:status) } shared_let(:status1) { create(:status) } diff --git a/spec/permissions/add_messages_spec.rb b/spec/permissions/add_messages_spec.rb index accdffb081d..97326278547 100644 --- a/spec/permissions/add_messages_spec.rb +++ b/spec/permissions/add_messages_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'support/permission_specs' -describe MessagesController, 'add_messages permission', type: :controller do +RSpec.describe MessagesController, 'add_messages permission', type: :controller do include PermissionSpecs check_permission_required_for('messages#preview', :add_messages) diff --git a/spec/permissions/copy_projects_spec.rb b/spec/permissions/copy_projects_spec.rb index 7e22987c22a..e1d197c3a02 100644 --- a/spec/permissions/copy_projects_spec.rb +++ b/spec/permissions/copy_projects_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require File.expand_path('../support/permission_specs', __dir__) -describe ProjectsController, 'copy_projects permission', type: :controller do +RSpec.describe ProjectsController, 'copy_projects permission', type: :controller do include PermissionSpecs check_permission_required_for('projects#copy', :copy_projects) diff --git a/spec/permissions/delete_work_packages_spec.rb b/spec/permissions/delete_work_packages_spec.rb index 4a2a0bba849..f26363efb1c 100644 --- a/spec/permissions/delete_work_packages_spec.rb +++ b/spec/permissions/delete_work_packages_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../support/permission_specs' -describe WorkPackages::BulkController, 'delete_work_packages permission', type: :controller do +RSpec.describe WorkPackages::BulkController, 'delete_work_packages permission', type: :controller do include PermissionSpecs check_permission_required_for('work_packages/bulk#destroy', :delete_work_packages) diff --git a/spec/permissions/edit_messages_spec.rb b/spec/permissions/edit_messages_spec.rb index 5a01e5bbdb0..a6e47ce93cd 100644 --- a/spec/permissions/edit_messages_spec.rb +++ b/spec/permissions/edit_messages_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'support/permission_specs' -describe MessagesController, 'edit_messages permission', type: :controller do +RSpec.describe MessagesController, 'edit_messages permission', type: :controller do include PermissionSpecs check_permission_required_for('messages#preview', :edit_messages) diff --git a/spec/permissions/edit_own_messages_spec.rb b/spec/permissions/edit_own_messages_spec.rb index 465ee14016b..605ae88c7ba 100644 --- a/spec/permissions/edit_own_messages_spec.rb +++ b/spec/permissions/edit_own_messages_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'support/permission_specs' -describe MessagesController, 'edit_own_messages permission', type: :controller do +RSpec.describe MessagesController, 'edit_own_messages permission', type: :controller do include PermissionSpecs check_permission_required_for('messages#preview', :edit_own_messages) diff --git a/spec/permissions/edit_wiki_pages_spec.rb b/spec/permissions/edit_wiki_pages_spec.rb index 5bf37c41eb9..6c414b72d51 100644 --- a/spec/permissions/edit_wiki_pages_spec.rb +++ b/spec/permissions/edit_wiki_pages_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'support/permission_specs' -describe WikiController, 'edit_wiki_pages permission', type: :controller do +RSpec.describe WikiController, 'edit_wiki_pages permission', type: :controller do include PermissionSpecs check_permission_required_for('wiki#preview', :edit_wiki_pages) diff --git a/spec/permissions/export_work_packages_spec.rb b/spec/permissions/export_work_packages_spec.rb index b9e29a8005f..0081756f80f 100644 --- a/spec/permissions/export_work_packages_spec.rb +++ b/spec/permissions/export_work_packages_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require File.expand_path('../support/permission_specs', __dir__) -describe WorkPackagesController, 'export_work_packages permission', type: :controller do +RSpec.describe WorkPackagesController, 'export_work_packages permission', type: :controller do include PermissionSpecs check_permission_required_for('work_packages#index', :export_work_packages) diff --git a/spec/permissions/manage_forums_spec.rb b/spec/permissions/manage_forums_spec.rb index 3a73b865788..b5ac7523da1 100644 --- a/spec/permissions/manage_forums_spec.rb +++ b/spec/permissions/manage_forums_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require File.expand_path('../support/permission_specs', __dir__) -describe ForumsController, 'manage_forums permission', type: :controller do +RSpec.describe ForumsController, 'manage_forums permission', type: :controller do include PermissionSpecs check_permission_required_for('forums#create', :manage_forums) diff --git a/spec/permissions/manage_news_spec.rb b/spec/permissions/manage_news_spec.rb index 70a98dece4c..74ec6f937b0 100644 --- a/spec/permissions/manage_news_spec.rb +++ b/spec/permissions/manage_news_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'support/permission_specs' -describe NewsController, 'manage_news permission', type: :controller do +RSpec.describe NewsController, 'manage_news permission', type: :controller do include PermissionSpecs check_permission_required_for('news#preview', :manage_news) diff --git a/spec/permissions/manage_repositories_spec.rb b/spec/permissions/manage_repositories_spec.rb index fa56fac732e..bb80ff9fa28 100644 --- a/spec/permissions/manage_repositories_spec.rb +++ b/spec/permissions/manage_repositories_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require File.expand_path('../support/permission_specs', __dir__) -describe RepositoriesController, 'manage_repository permission', type: :controller do +RSpec.describe RepositoriesController, 'manage_repository permission', type: :controller do include PermissionSpecs check_permission_required_for('repositories#edit', :manage_repository) diff --git a/spec/permissions/view_work_packages_spec.rb b/spec/permissions/view_work_packages_spec.rb index 7f6f75e946b..b66fa88b788 100644 --- a/spec/permissions/view_work_packages_spec.rb +++ b/spec/permissions/view_work_packages_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require File.expand_path('../support/permission_specs', __dir__) -describe WorkPackagesController, 'view_work_packages permission', type: :controller do +RSpec.describe WorkPackagesController, 'view_work_packages permission', type: :controller do include PermissionSpecs check_permission_required_for('work_packages#show', :view_work_packages) diff --git a/spec/permissions/work_packages_bulk_spec.rb b/spec/permissions/work_packages_bulk_spec.rb index bffd3a66d62..f20f19ac734 100644 --- a/spec/permissions/work_packages_bulk_spec.rb +++ b/spec/permissions/work_packages_bulk_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative '../support/permission_specs' -describe WorkPackages::BulkController, 'edit_work_packages permission', type: :controller do +RSpec.describe WorkPackages::BulkController, 'edit_work_packages permission', type: :controller do include PermissionSpecs check_permission_required_for('work_packages/bulk#edit', :edit_work_packages) diff --git a/spec/policies/query_policy_spec.rb b/spec/policies/query_policy_spec.rb index be90d7303c3..37a52be571b 100644 --- a/spec/policies/query_policy_spec.rb +++ b/spec/policies/query_policy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe QueryPolicy, type: :controller do +RSpec.describe QueryPolicy, type: :controller do let(:user) { build_stubbed(:user) } let(:project) { build_stubbed(:project) } let(:query) { build_stubbed(:query, project:, user:) } diff --git a/spec/policies/redirect_policy_spec.rb b/spec/policies/redirect_policy_spec.rb index 941731388aa..7b6846523de 100644 --- a/spec/policies/redirect_policy_spec.rb +++ b/spec/policies/redirect_policy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RedirectPolicy, type: :controller do +RSpec.describe RedirectPolicy, type: :controller do let(:host) { 'test.host' } let(:return_escaped) { true } diff --git a/spec/policies/work_package_policy_spec.rb b/spec/policies/work_package_policy_spec.rb index 734d8166576..7f09598c1b0 100644 --- a/spec/policies/work_package_policy_spec.rb +++ b/spec/policies/work_package_policy_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackagePolicy, type: :controller do +RSpec.describe WorkPackagePolicy, type: :controller do let(:user) { build_stubbed(:user) } let(:project) { build_stubbed(:project) } let(:work_package) { build_stubbed(:work_package, project:) } diff --git a/spec/requests/api/v3/action_resource_spec.rb b/spec/requests/api/v3/action_resource_spec.rb index 45a321e5e14..b711e75176d 100644 --- a/spec/requests/api/v3/action_resource_spec.rb +++ b/spec/requests/api/v3/action_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 action resource', content_type: :json do +RSpec.describe 'API v3 action resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/activities_api_spec.rb b/spec/requests/api/v3/activities_api_spec.rb index 34824804012..da781047eda 100644 --- a/spec/requests/api/v3/activities_api_spec.rb +++ b/spec/requests/api/v3/activities_api_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Activities::ActivitiesAPI, content_type: :json do +RSpec.describe API::V3::Activities::ActivitiesAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/activities_by_work_package_resource_spec.rb b/spec/requests/api/v3/activities_by_work_package_resource_spec.rb index f131fba6498..151e552c531 100644 --- a/spec/requests/api/v3/activities_by_work_package_resource_spec.rb +++ b/spec/requests/api/v3/activities_by_work_package_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Activities::ActivitiesByWorkPackageAPI do +RSpec.describe API::V3::Activities::ActivitiesByWorkPackageAPI do include API::V3::Utilities::PathHelper describe 'activities' do diff --git a/spec/requests/api/v3/attachments/attachment_resource_shared_examples.rb b/spec/requests/api/v3/attachments/attachment_resource_shared_examples.rb index d4e1562b9ee..5fea90472bb 100644 --- a/spec/requests/api/v3/attachments/attachment_resource_shared_examples.rb +++ b/spec/requests/api/v3/attachments/attachment_resource_shared_examples.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -shared_examples 'it supports direct uploads' do +RSpec.shared_examples 'it supports direct uploads' do include Rack::Test::Methods include API::V3::Utilities::PathHelper include FileHelpers @@ -186,7 +186,7 @@ shared_examples 'it supports direct uploads' do end end -shared_examples 'an APIv3 attachment resource', content_type: :json, type: :request do |include_by_container = true| +RSpec.shared_examples 'an APIv3 attachment resource', content_type: :json, type: :request do |include_by_container = true| include Rack::Test::Methods include API::V3::Utilities::PathHelper include FileHelpers diff --git a/spec/requests/api/v3/attachments/forum_message_spec.rb b/spec/requests/api/v3/attachments/forum_message_spec.rb index 1f7e46f1d35..50025bd5260 100644 --- a/spec/requests/api/v3/attachments/forum_message_spec.rb +++ b/spec/requests/api/v3/attachments/forum_message_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './attachment_resource_shared_examples' -describe "forum message attachments" do +RSpec.describe "forum message attachments" do it_behaves_like "an APIv3 attachment resource", include_by_container = false do let(:attachment_type) { :forum_message } diff --git a/spec/requests/api/v3/attachments/wiki_page_spec.rb b/spec/requests/api/v3/attachments/wiki_page_spec.rb index f8099d223da..d141ded5a2b 100644 --- a/spec/requests/api/v3/attachments/wiki_page_spec.rb +++ b/spec/requests/api/v3/attachments/wiki_page_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './attachment_resource_shared_examples' -describe "wiki page attachments" do +RSpec.describe "wiki page attachments" do it_behaves_like "an APIv3 attachment resource" do let(:attachment_type) { :wiki_page } diff --git a/spec/requests/api/v3/attachments/work_package_spec.rb b/spec/requests/api/v3/attachments/work_package_spec.rb index 587479e5bd5..b89bf214f1a 100644 --- a/spec/requests/api/v3/attachments/work_package_spec.rb +++ b/spec/requests/api/v3/attachments/work_package_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './attachment_resource_shared_examples' -describe "work package attachments" do +RSpec.describe "work package attachments" do it_behaves_like "an APIv3 attachment resource" do let(:attachment_type) { :work_package } diff --git a/spec/requests/api/v3/attachments/work_packages_export_spec.rb b/spec/requests/api/v3/attachments/work_packages_export_spec.rb index 78ca841b229..9a9f058bbb2 100644 --- a/spec/requests/api/v3/attachments/work_packages_export_spec.rb +++ b/spec/requests/api/v3/attachments/work_packages_export_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './attachment_resource_shared_examples' -describe "WorkPackages::Export attachments" do +RSpec.describe "WorkPackages::Export attachments" do it_behaves_like "an APIv3 attachment resource", include_by_container = false do let(:attachment_type) { :export } diff --git a/spec/requests/api/v3/attachments_spec.rb b/spec/requests/api/v3/attachments_spec.rb index c0e862b64ce..0e76c3a44c4 100644 --- a/spec/requests/api/v3/attachments_spec.rb +++ b/spec/requests/api/v3/attachments_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative 'attachments/attachment_resource_shared_examples' -describe API::V3::Attachments::AttachmentsAPI do +RSpec.describe API::V3::Attachments::AttachmentsAPI do include Rack::Test::Methods include API::V3::Utilities::PathHelper include FileHelpers diff --git a/spec/requests/api/v3/authentication_spec.rb b/spec/requests/api/v3/authentication_spec.rb index 8c0b6beb113..cc232b515c5 100644 --- a/spec/requests/api/v3/authentication_spec.rb +++ b/spec/requests/api/v3/authentication_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3 do +RSpec.describe API::V3 do let(:resource) { "/api/v3/projects" } let(:user) { create(:user) } diff --git a/spec/requests/api/v3/backups/backups_api_spec.rb b/spec/requests/api/v3/backups/backups_api_spec.rb index a1186dbc724..684c100c0fd 100644 --- a/spec/requests/api/v3/backups/backups_api_spec.rb +++ b/spec/requests/api/v3/backups/backups_api_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Backups::BackupsAPI, with_config: { backup_enabled: true } do +RSpec.describe API::V3::Backups::BackupsAPI, with_config: { backup_enabled: true } do include API::V3::Utilities::PathHelper let(:user) { create(:user, global_permissions: [:create_backup]) } diff --git a/spec/requests/api/v3/capabilities/contexts/global_resource_spec.rb b/spec/requests/api/v3/capabilities/contexts/global_resource_spec.rb index 222eb7b1d62..5e1ce4cef16 100644 --- a/spec/requests/api/v3/capabilities/contexts/global_resource_spec.rb +++ b/spec/requests/api/v3/capabilities/contexts/global_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 capabilities global context resource', content_type: :json do +RSpec.describe 'API v3 capabilities global context resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/capability_resource_spec.rb b/spec/requests/api/v3/capability_resource_spec.rb index ef6eeaff7bf..dd17b0766f6 100644 --- a/spec/requests/api/v3/capability_resource_spec.rb +++ b/spec/requests/api/v3/capability_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 capabilities resource', content_type: :json do +RSpec.describe 'API v3 capabilities resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/category_resource_spec.rb b/spec/requests/api/v3/category_resource_spec.rb index 4f68151a91f..aa6c302ae6f 100644 --- a/spec/requests/api/v3/category_resource_spec.rb +++ b/spec/requests/api/v3/category_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Category resource' do +RSpec.describe 'API v3 Category resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/configuration_resource_spec.rb b/spec/requests/api/v3/configuration_resource_spec.rb index f95c2022b46..6f11fb95f32 100644 --- a/spec/requests/api/v3/configuration_resource_spec.rb +++ b/spec/requests/api/v3/configuration_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Configuration resource' do +RSpec.describe 'API v3 Configuration resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/cors_header_spec.rb b/spec/requests/api/v3/cors_header_spec.rb index bb29c041c20..dc2647be81e 100644 --- a/spec/requests/api/v3/cors_header_spec.rb +++ b/spec/requests/api/v3/cors_header_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 CORS headers', - content_type: :json do +RSpec.describe 'API v3 CORS headers', + content_type: :json do include Rack::Test::Methods include Capybara::RSpecMatchers include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/custom_actions/custom_actions_api_spec.rb b/spec/requests/api/v3/custom_actions/custom_actions_api_spec.rb index dc65221e0f9..1ce6ab50506 100644 --- a/spec/requests/api/v3/custom_actions/custom_actions_api_spec.rb +++ b/spec/requests/api/v3/custom_actions/custom_actions_api_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API::V3::CustomActions::CustomActionsAPI' do +RSpec.describe 'API::V3::CustomActions::CustomActionsAPI' do include API::V3::Utilities::PathHelper let(:role) do diff --git a/spec/requests/api/v3/custom_options/custom_options_resource_spec.rb b/spec/requests/api/v3/custom_options/custom_options_resource_spec.rb index e76c76aad18..351fbdb90a6 100644 --- a/spec/requests/api/v3/custom_options/custom_options_resource_spec.rb +++ b/spec/requests/api/v3/custom_options/custom_options_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Custom Options resource', :aggregate_failures do +RSpec.describe 'API v3 Custom Options resource', :aggregate_failures do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/days/day_spec.rb b/spec/requests/api/v3/days/day_spec.rb index b87910b6211..b8fbcf1c9ae 100644 --- a/spec/requests/api/v3/days/day_spec.rb +++ b/spec/requests/api/v3/days/day_spec.rb @@ -27,8 +27,8 @@ require 'spec_helper' -describe API::V3::Days::DaysAPI, - content_type: :json do +RSpec.describe API::V3::Days::DaysAPI, + content_type: :json do include API::V3::Utilities::PathHelper shared_let(:working_days) { week_with_saturday_and_sunday_as_weekend } diff --git a/spec/requests/api/v3/days/non_working_days_index_resource_spec.rb b/spec/requests/api/v3/days/non_working_days_index_resource_spec.rb index 577cd6604ae..347549aace6 100644 --- a/spec/requests/api/v3/days/non_working_days_index_resource_spec.rb +++ b/spec/requests/api/v3/days/non_working_days_index_resource_spec.rb @@ -28,9 +28,9 @@ require 'spec_helper' require 'services/work_packages/shared/shared_examples_days' -describe API::V3::Days::NonWorkingDaysAPI, - 'index', - content_type: :json do +RSpec.describe API::V3::Days::NonWorkingDaysAPI, + 'index', + content_type: :json do include API::V3::Utilities::PathHelper let(:parsed_response) { JSON.parse(last_response.body) } diff --git a/spec/requests/api/v3/days/non_working_days_show_resource_spec.rb b/spec/requests/api/v3/days/non_working_days_show_resource_spec.rb index 0c901a08455..c45acb4fbd5 100644 --- a/spec/requests/api/v3/days/non_working_days_show_resource_spec.rb +++ b/spec/requests/api/v3/days/non_working_days_show_resource_spec.rb @@ -27,9 +27,9 @@ require 'spec_helper' -describe API::V3::Days::NonWorkingDaysAPI, - 'show', - content_type: :json do +RSpec.describe API::V3::Days::NonWorkingDaysAPI, + 'show', + content_type: :json do include API::V3::Utilities::PathHelper let(:non_working_day) { create(:non_working_day) } diff --git a/spec/requests/api/v3/days/week_show_resource_spec.rb b/spec/requests/api/v3/days/week_show_resource_spec.rb index b1bf98a5786..b2a93cf9ddc 100644 --- a/spec/requests/api/v3/days/week_show_resource_spec.rb +++ b/spec/requests/api/v3/days/week_show_resource_spec.rb @@ -27,9 +27,9 @@ require 'spec_helper' -describe API::V3::Days::WeekAPI, - 'show', - content_type: :json do +RSpec.describe API::V3::Days::WeekAPI, + 'show', + content_type: :json do include API::V3::Utilities::PathHelper let(:path) { api_v3_paths.days_week_day(1) } diff --git a/spec/requests/api/v3/days/week_spec.rb b/spec/requests/api/v3/days/week_spec.rb index d4568852f18..34866dedf15 100644 --- a/spec/requests/api/v3/days/week_spec.rb +++ b/spec/requests/api/v3/days/week_spec.rb @@ -27,9 +27,9 @@ require 'spec_helper' -describe API::V3::Days::WeekAPI, - 'index', - content_type: :json do +RSpec.describe API::V3::Days::WeekAPI, + 'index', + content_type: :json do include API::V3::Utilities::PathHelper let(:parsed_response) { JSON.parse(last_response.body) } diff --git a/spec/requests/api/v3/groups/group_resource_spec.rb b/spec/requests/api/v3/groups/group_resource_spec.rb index fa490ac2cb7..e87fd1d1893 100644 --- a/spec/requests/api/v3/groups/group_resource_spec.rb +++ b/spec/requests/api/v3/groups/group_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Group resource', content_type: :json do +RSpec.describe 'API v3 Group resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/help_texts/help_texts_resource_spec.rb b/spec/requests/api/v3/help_texts/help_texts_resource_spec.rb index dac6eecfbe2..39d6222e713 100644 --- a/spec/requests/api/v3/help_texts/help_texts_resource_spec.rb +++ b/spec/requests/api/v3/help_texts/help_texts_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Help texts resource' do +RSpec.describe 'API v3 Help texts resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/locale_spec.rb b/spec/requests/api/v3/locale_spec.rb index 30e76b51ad5..b53902d8462 100644 --- a/spec/requests/api/v3/locale_spec.rb +++ b/spec/requests/api/v3/locale_spec.rb @@ -32,7 +32,7 @@ require 'rack/test' # This takes the schema endpoint to test localization as there # are localized strings in the response. -describe 'API localization' do +RSpec.describe 'API localization' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/membership_resources_spec.rb b/spec/requests/api/v3/membership_resources_spec.rb index 401ab408993..5bc93fd5648 100644 --- a/spec/requests/api/v3/membership_resources_spec.rb +++ b/spec/requests/api/v3/membership_resources_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 memberships resource', content_type: :json do +RSpec.describe 'API v3 memberships resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/memberships/available_projects_resource_spec.rb b/spec/requests/api/v3/memberships/available_projects_resource_spec.rb index fc57e7cde31..b768540843a 100644 --- a/spec/requests/api/v3/memberships/available_projects_resource_spec.rb +++ b/spec/requests/api/v3/memberships/available_projects_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 memberships available projects resource' do +RSpec.describe 'API v3 memberships available projects resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/memberships/create_form_resource_spec.rb b/spec/requests/api/v3/memberships/create_form_resource_spec.rb index ecf5dfd4d09..099fb46b9f7 100644 --- a/spec/requests/api/v3/memberships/create_form_resource_spec.rb +++ b/spec/requests/api/v3/memberships/create_form_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Memberships::CreateFormAPI, content_type: :json do +RSpec.describe API::V3::Memberships::CreateFormAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/memberships/schemas/membership_schema_resource_spec.rb b/spec/requests/api/v3/memberships/schemas/membership_schema_resource_spec.rb index 7aec289783d..d90cfc46755 100644 --- a/spec/requests/api/v3/memberships/schemas/membership_schema_resource_spec.rb +++ b/spec/requests/api/v3/memberships/schemas/membership_schema_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Membership schema resource', content_type: :json do +RSpec.describe 'API v3 Membership schema resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/memberships/update_form_resource_spec.rb b/spec/requests/api/v3/memberships/update_form_resource_spec.rb index c72f37d29f7..2726bd6c90c 100644 --- a/spec/requests/api/v3/memberships/update_form_resource_spec.rb +++ b/spec/requests/api/v3/memberships/update_form_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Memberships::UpdateFormAPI, content_type: :json do +RSpec.describe API::V3::Memberships::UpdateFormAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/news_resource_spec.rb b/spec/requests/api/v3/news_resource_spec.rb index 59495b7e371..76725cdef20 100644 --- a/spec/requests/api/v3/news_resource_spec.rb +++ b/spec/requests/api/v3/news_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 news resource' do +RSpec.describe 'API v3 news resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/notifications/bulk_read_ian_resource_spec.rb b/spec/requests/api/v3/notifications/bulk_read_ian_resource_spec.rb index 68851183d6f..8121e8c6f47 100644 --- a/spec/requests/api/v3/notifications/bulk_read_ian_resource_spec.rb +++ b/spec/requests/api/v3/notifications/bulk_read_ian_resource_spec.rb @@ -27,9 +27,9 @@ require 'spec_helper' -describe API::V3::Notifications::NotificationsAPI, - 'bulk set read status', - content_type: :json do +RSpec.describe API::V3::Notifications::NotificationsAPI, + 'bulk set read status', + content_type: :json do include API::V3::Utilities::PathHelper shared_let(:project) { create(:project) } diff --git a/spec/requests/api/v3/notifications/bulk_unread_ian_resource_spec.rb b/spec/requests/api/v3/notifications/bulk_unread_ian_resource_spec.rb index c848c349fea..88c3c95682a 100644 --- a/spec/requests/api/v3/notifications/bulk_unread_ian_resource_spec.rb +++ b/spec/requests/api/v3/notifications/bulk_unread_ian_resource_spec.rb @@ -27,9 +27,9 @@ require 'spec_helper' -describe API::V3::Notifications::NotificationsAPI, - 'bulk unset read status', - content_type: :json do +RSpec.describe API::V3::Notifications::NotificationsAPI, + 'bulk unset read status', + content_type: :json do include API::V3::Utilities::PathHelper shared_let(:project) { create(:project) } diff --git a/spec/requests/api/v3/notifications/details_resource_spec.rb b/spec/requests/api/v3/notifications/details_resource_spec.rb index 0e302f0236a..20bf1bd357f 100644 --- a/spec/requests/api/v3/notifications/details_resource_spec.rb +++ b/spec/requests/api/v3/notifications/details_resource_spec.rb @@ -27,9 +27,9 @@ require 'spec_helper' -describe API::V3::Notifications::NotificationsAPI, - 'fetch notification details', - content_type: :json do +RSpec.describe API::V3::Notifications::NotificationsAPI, + 'fetch notification details', + content_type: :json do include API::V3::Utilities::PathHelper shared_let(:project) { create(:project) } diff --git a/spec/requests/api/v3/notifications/index_resource_spec.rb b/spec/requests/api/v3/notifications/index_resource_spec.rb index f9e039d3bdd..f7b79190dc0 100644 --- a/spec/requests/api/v3/notifications/index_resource_spec.rb +++ b/spec/requests/api/v3/notifications/index_resource_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Notifications::NotificationsAPI, - 'index', content_type: :json do +RSpec.describe API::V3::Notifications::NotificationsAPI, + 'index', content_type: :json do include API::V3::Utilities::PathHelper shared_let(:work_package) { create(:work_package) } diff --git a/spec/requests/api/v3/notifications/read_ian_resource_spec.rb b/spec/requests/api/v3/notifications/read_ian_resource_spec.rb index f04991d85f2..c16fe91eb7c 100644 --- a/spec/requests/api/v3/notifications/read_ian_resource_spec.rb +++ b/spec/requests/api/v3/notifications/read_ian_resource_spec.rb @@ -27,9 +27,9 @@ require 'spec_helper' -describe API::V3::Notifications::NotificationsAPI, - 'update read status', - content_type: :json do +RSpec.describe API::V3::Notifications::NotificationsAPI, + 'update read status', + content_type: :json do include API::V3::Utilities::PathHelper shared_let(:project) { create(:project) } diff --git a/spec/requests/api/v3/notifications/show_resource_examples.rb b/spec/requests/api/v3/notifications/show_resource_examples.rb index b1f8e9dc72a..8c21ef5c318 100644 --- a/spec/requests/api/v3/notifications/show_resource_examples.rb +++ b/spec/requests/api/v3/notifications/show_resource_examples.rb @@ -25,7 +25,7 @@ # # See COPYRIGHT and LICENSE files for more details. -shared_examples 'represents the notification' do +RSpec.shared_examples 'represents the notification' do it 'represents the notification', :aggregate_failures do expect(last_response.status) .to eq(200) diff --git a/spec/requests/api/v3/notifications/show_resource_spec.rb b/spec/requests/api/v3/notifications/show_resource_spec.rb index 115a66f026f..a9e8fc8b4ab 100644 --- a/spec/requests/api/v3/notifications/show_resource_spec.rb +++ b/spec/requests/api/v3/notifications/show_resource_spec.rb @@ -28,9 +28,9 @@ require 'spec_helper' require_relative './show_resource_examples' -describe API::V3::Notifications::NotificationsAPI, - 'show', - content_type: :json do +RSpec.describe API::V3::Notifications::NotificationsAPI, + 'show', + content_type: :json do include API::V3::Utilities::PathHelper shared_let(:recipient) do diff --git a/spec/requests/api/v3/placeholder_users/create_resource_spec.rb b/spec/requests/api/v3/placeholder_users/create_resource_spec.rb index 01d479ff9aa..fc2a68cd022 100644 --- a/spec/requests/api/v3/placeholder_users/create_resource_spec.rb +++ b/spec/requests/api/v3/placeholder_users/create_resource_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require 'rack/test' require_relative './create_shared_examples' -describe API::V3::PlaceholderUsers::PlaceholderUsersAPI, - 'create' do +RSpec.describe API::V3::PlaceholderUsers::PlaceholderUsersAPI, + 'create' do current_user { user } describe 'admin user' do diff --git a/spec/requests/api/v3/placeholder_users/create_shared_examples.rb b/spec/requests/api/v3/placeholder_users/create_shared_examples.rb index fce4267737c..0ee0cfa4f79 100644 --- a/spec/requests/api/v3/placeholder_users/create_shared_examples.rb +++ b/spec/requests/api/v3/placeholder_users/create_shared_examples.rb @@ -25,7 +25,7 @@ # # See COPYRIGHT and LICENSE files for more details. -shared_context 'create placeholder user request context' do +RSpec.shared_context 'create placeholder user request context' do include API::V3::Utilities::PathHelper let(:parameters) do @@ -40,7 +40,7 @@ shared_context 'create placeholder user request context' do let(:parsed_response) { JSON.parse(last_response.body) } end -shared_examples 'create placeholder user request flow' do +RSpec.shared_examples 'create placeholder user request flow' do include_context 'create placeholder user request context' describe 'with EE', with_ee: %i[placeholder_users] do diff --git a/spec/requests/api/v3/placeholder_users/delete_resource_examples.rb b/spec/requests/api/v3/placeholder_users/delete_resource_examples.rb index bcaf1fe87b3..56a3364ed33 100644 --- a/spec/requests/api/v3/placeholder_users/delete_resource_examples.rb +++ b/spec/requests/api/v3/placeholder_users/delete_resource_examples.rb @@ -25,7 +25,7 @@ # # See COPYRIGHT and LICENSE files for more details. -shared_examples 'deletion allowed' do +RSpec.shared_examples 'deletion allowed' do it 'responds with 202' do expect(last_response.status).to eq 202 end @@ -45,7 +45,7 @@ shared_examples 'deletion allowed' do end end -shared_examples 'deletion is not allowed' do +RSpec.shared_examples 'deletion is not allowed' do it 'responds with 403' do expect(last_response.status).to eq 403 end diff --git a/spec/requests/api/v3/placeholder_users/delete_resource_spec.rb b/spec/requests/api/v3/placeholder_users/delete_resource_spec.rb index a4d00aea6d1..6f163e9fee3 100644 --- a/spec/requests/api/v3/placeholder_users/delete_resource_spec.rb +++ b/spec/requests/api/v3/placeholder_users/delete_resource_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' require_relative './delete_resource_examples' -describe API::V3::PlaceholderUsers::PlaceholderUsersAPI, - 'delete' do +RSpec.describe API::V3::PlaceholderUsers::PlaceholderUsersAPI, + 'delete' do include API::V3::Utilities::PathHelper shared_let(:placeholder) { create(:placeholder_user, name: 'foo') } diff --git a/spec/requests/api/v3/placeholder_users/index_resource_spec.rb b/spec/requests/api/v3/placeholder_users/index_resource_spec.rb index f35bb065b78..018b76d3959 100644 --- a/spec/requests/api/v3/placeholder_users/index_resource_spec.rb +++ b/spec/requests/api/v3/placeholder_users/index_resource_spec.rb @@ -28,9 +28,9 @@ require 'spec_helper' require 'rack/test' -describe API::V3::PlaceholderUsers::PlaceholderUsersAPI, - 'index', - content_type: :json do +RSpec.describe API::V3::PlaceholderUsers::PlaceholderUsersAPI, + 'index', + content_type: :json do include API::V3::Utilities::PathHelper shared_let(:placeholder1) { create(:placeholder_user, name: 'foo') } diff --git a/spec/requests/api/v3/placeholder_users/show_resource_examples.rb b/spec/requests/api/v3/placeholder_users/show_resource_examples.rb index 71a79de6161..bbae0bcd777 100644 --- a/spec/requests/api/v3/placeholder_users/show_resource_examples.rb +++ b/spec/requests/api/v3/placeholder_users/show_resource_examples.rb @@ -25,7 +25,7 @@ # # See COPYRIGHT and LICENSE files for more details. -shared_examples 'represents the placeholder' do +RSpec.shared_examples 'represents the placeholder' do it do expect(last_response.status).to eq(200) expect(last_response.body) diff --git a/spec/requests/api/v3/placeholder_users/show_resource_spec.rb b/spec/requests/api/v3/placeholder_users/show_resource_spec.rb index e8585e35804..d94b5674a93 100644 --- a/spec/requests/api/v3/placeholder_users/show_resource_spec.rb +++ b/spec/requests/api/v3/placeholder_users/show_resource_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' require_relative './show_resource_examples' -describe API::V3::PlaceholderUsers::PlaceholderUsersAPI, - 'show' do +RSpec.describe API::V3::PlaceholderUsers::PlaceholderUsersAPI, + 'show' do include API::V3::Utilities::PathHelper shared_let(:placeholder) { create(:placeholder_user, name: 'foo') } diff --git a/spec/requests/api/v3/placeholder_users/update_resource_examples.rb b/spec/requests/api/v3/placeholder_users/update_resource_examples.rb index c2288da4860..58e36439b9e 100644 --- a/spec/requests/api/v3/placeholder_users/update_resource_examples.rb +++ b/spec/requests/api/v3/placeholder_users/update_resource_examples.rb @@ -25,7 +25,7 @@ # # See COPYRIGHT and LICENSE files for more details. -shared_examples 'updates the placeholder' do +RSpec.shared_examples 'updates the placeholder' do context 'with an empty name' do let(:parameters) do { name: '' } diff --git a/spec/requests/api/v3/placeholder_users/update_resource_spec.rb b/spec/requests/api/v3/placeholder_users/update_resource_spec.rb index 3eac4682770..975dc1f3d5a 100644 --- a/spec/requests/api/v3/placeholder_users/update_resource_spec.rb +++ b/spec/requests/api/v3/placeholder_users/update_resource_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' require_relative './update_resource_examples' -describe API::V3::PlaceholderUsers::PlaceholderUsersAPI, - 'update' do +RSpec.describe API::V3::PlaceholderUsers::PlaceholderUsersAPI, + 'update' do include API::V3::Utilities::PathHelper shared_let(:placeholder) { create(:placeholder_user, name: 'foo') } diff --git a/spec/requests/api/v3/posts_resource_spec.rb b/spec/requests/api/v3/posts_resource_spec.rb index 647b30a6fa8..dc643e8ff8c 100644 --- a/spec/requests/api/v3/posts_resource_spec.rb +++ b/spec/requests/api/v3/posts_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 posts resource' do +RSpec.describe 'API v3 posts resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/principals/principals_resource_spec.rb b/spec/requests/api/v3/principals/principals_resource_spec.rb index 1dbea15a61d..ea77250e71d 100644 --- a/spec/requests/api/v3/principals/principals_resource_spec.rb +++ b/spec/requests/api/v3/principals/principals_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Principals resource' do +RSpec.describe 'API v3 Principals resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/priority_resource_spec.rb b/spec/requests/api/v3/priority_resource_spec.rb index e6fe6791eed..3a6d6558c73 100644 --- a/spec/requests/api/v3/priority_resource_spec.rb +++ b/spec/requests/api/v3/priority_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Priority resource' do +RSpec.describe 'API v3 Priority resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/projects/available_assignees_api_spec.rb b/spec/requests/api/v3/projects/available_assignees_api_spec.rb index 0b31a1e4693..a7109525789 100644 --- a/spec/requests/api/v3/projects/available_assignees_api_spec.rb +++ b/spec/requests/api/v3/projects/available_assignees_api_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe "API::V3::Projects::AvailableAssigneesAPI" do +RSpec.describe "API::V3::Projects::AvailableAssigneesAPI" do include API::V3::Utilities::PathHelper it_behaves_like 'available principals', :assignees do diff --git a/spec/requests/api/v3/projects/available_parents_resource_spec.rb b/spec/requests/api/v3/projects/available_parents_resource_spec.rb index 53bc541ed21..b1c72c42c05 100644 --- a/spec/requests/api/v3/projects/available_parents_resource_spec.rb +++ b/spec/requests/api/v3/projects/available_parents_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Project available parents resource', content_type: :json do +RSpec.describe 'API v3 Project available parents resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/projects/available_responsibles_api_spec.rb b/spec/requests/api/v3/projects/available_responsibles_api_spec.rb index bf0df206002..0fad98ce8e9 100644 --- a/spec/requests/api/v3/projects/available_responsibles_api_spec.rb +++ b/spec/requests/api/v3/projects/available_responsibles_api_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe "API::V3::Projects::AvailableResponsiblesAPI" do +RSpec.describe "API::V3::Projects::AvailableResponsiblesAPI" do include API::V3::Utilities::PathHelper it_behaves_like 'available principals', :responsibles do diff --git a/spec/requests/api/v3/projects/copy/copy_form_resource_spec.rb b/spec/requests/api/v3/projects/copy/copy_form_resource_spec.rb index bb9e49890ad..b129d27daa1 100644 --- a/spec/requests/api/v3/projects/copy/copy_form_resource_spec.rb +++ b/spec/requests/api/v3/projects/copy/copy_form_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Projects::Copy::CreateFormAPI, content_type: :json do +RSpec.describe API::V3::Projects::Copy::CreateFormAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/projects/copy/copy_resource_spec.rb b/spec/requests/api/v3/projects/copy/copy_resource_spec.rb index 3b1311de384..df1bbf4fee5 100644 --- a/spec/requests/api/v3/projects/copy/copy_resource_spec.rb +++ b/spec/requests/api/v3/projects/copy/copy_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Projects::Copy::CopyAPI, content_type: :json do +RSpec.describe API::V3::Projects::Copy::CopyAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/projects/create_form_resource_spec.rb b/spec/requests/api/v3/projects/create_form_resource_spec.rb index 4c7f67a23b9..62d9b8676cb 100644 --- a/spec/requests/api/v3/projects/create_form_resource_spec.rb +++ b/spec/requests/api/v3/projects/create_form_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Projects::CreateFormAPI, content_type: :json do +RSpec.describe API::V3::Projects::CreateFormAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/projects/create_resource_spec.rb b/spec/requests/api/v3/projects/create_resource_spec.rb index a57c7ccc73e..6d4286f9357 100644 --- a/spec/requests/api/v3/projects/create_resource_spec.rb +++ b/spec/requests/api/v3/projects/create_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Project resource create', content_type: :json do +RSpec.describe 'API v3 Project resource create', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/projects/delete_resource_spec.rb b/spec/requests/api/v3/projects/delete_resource_spec.rb index 175199d5715..c34506a45c3 100644 --- a/spec/requests/api/v3/projects/delete_resource_spec.rb +++ b/spec/requests/api/v3/projects/delete_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Project resource delete', content_type: :json do +RSpec.describe 'API v3 Project resource delete', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/projects/index_resource_spec.rb b/spec/requests/api/v3/projects/index_resource_spec.rb index ef9c22268ae..9482d29e386 100644 --- a/spec/requests/api/v3/projects/index_resource_spec.rb +++ b/spec/requests/api/v3/projects/index_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Project resource index', content_type: :json do +RSpec.describe 'API v3 Project resource index', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/projects/schemas/project_schema_resource_spec.rb b/spec/requests/api/v3/projects/schemas/project_schema_resource_spec.rb index 9908accd1a5..821ad44e2f7 100644 --- a/spec/requests/api/v3/projects/schemas/project_schema_resource_spec.rb +++ b/spec/requests/api/v3/projects/schemas/project_schema_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Projects schema resource', content_type: :json do +RSpec.describe 'API v3 Projects schema resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/projects/show_resource_spec.rb b/spec/requests/api/v3/projects/show_resource_spec.rb index 0dd436f26a8..71d0d48edf6 100644 --- a/spec/requests/api/v3/projects/show_resource_spec.rb +++ b/spec/requests/api/v3/projects/show_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Project resource show', content_type: :json do +RSpec.describe 'API v3 Project resource show', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/projects/statuses/project_status_resource_spec.rb b/spec/requests/api/v3/projects/statuses/project_status_resource_spec.rb index 735e0d531eb..97d41437730 100644 --- a/spec/requests/api/v3/projects/statuses/project_status_resource_spec.rb +++ b/spec/requests/api/v3/projects/statuses/project_status_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Project status resource', content_type: :json do +RSpec.describe 'API v3 Project status resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/projects/update_form_resource_spec.rb b/spec/requests/api/v3/projects/update_form_resource_spec.rb index 242685a531f..45474c9f1dd 100644 --- a/spec/requests/api/v3/projects/update_form_resource_spec.rb +++ b/spec/requests/api/v3/projects/update_form_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Projects::UpdateFormAPI, content_type: :json do +RSpec.describe API::V3::Projects::UpdateFormAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/projects/update_resource_spec.rb b/spec/requests/api/v3/projects/update_resource_spec.rb index c47e438666b..f4cbd83f7a6 100644 --- a/spec/requests/api/v3/projects/update_resource_spec.rb +++ b/spec/requests/api/v3/projects/update_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Project resource update', content_type: :json do +RSpec.describe 'API v3 Project resource update', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/projects/version_resource_spec.rb b/spec/requests/api/v3/projects/version_resource_spec.rb index 3fd364cf2c7..eddd7a045b1 100644 --- a/spec/requests/api/v3/projects/version_resource_spec.rb +++ b/spec/requests/api/v3/projects/version_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe "API v3 project's versions resource" do +RSpec.describe "API v3 project's versions resource" do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/queries/columns/query_columns_resource_spec.rb b/spec/requests/api/v3/queries/columns/query_columns_resource_spec.rb index f81219b6ee1..1dcc4d0e415 100644 --- a/spec/requests/api/v3/queries/columns/query_columns_resource_spec.rb +++ b/spec/requests/api/v3/queries/columns/query_columns_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Query Column resource' do +RSpec.describe 'API v3 Query Column resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/queries/create_form_api_spec.rb b/spec/requests/api/v3/queries/create_form_api_spec.rb index fda50be988e..c223d619858 100644 --- a/spec/requests/api/v3/queries/create_form_api_spec.rb +++ b/spec/requests/api/v3/queries/create_form_api_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' require 'rack/test' -describe "POST /api/v3/queries/form", - with_ee: %i[baseline_comparison], with_flag: { show_changes: true } do +RSpec.describe "POST /api/v3/queries/form", + with_ee: %i[baseline_comparison], with_flag: { show_changes: true } do include API::V3::Utilities::PathHelper let(:path) { api_v3_paths.create_query_form } diff --git a/spec/requests/api/v3/queries/create_query_spec.rb b/spec/requests/api/v3/queries/create_query_spec.rb index 7d3453ac90b..6679cd91c55 100644 --- a/spec/requests/api/v3/queries/create_query_spec.rb +++ b/spec/requests/api/v3/queries/create_query_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe "POST /api/v3/queries", - with_ee: %i[baseline_comparison], with_flag: { show_changes: true } do +RSpec.describe "POST /api/v3/queries", + with_ee: %i[baseline_comparison], with_flag: { show_changes: true } do shared_let(:user) { create(:admin) } shared_let(:status) { create(:status) } shared_let(:project) { create(:project) } diff --git a/spec/requests/api/v3/queries/filters/query_filters_resource_spec.rb b/spec/requests/api/v3/queries/filters/query_filters_resource_spec.rb index ed93295b85c..d387b2ab9b9 100644 --- a/spec/requests/api/v3/queries/filters/query_filters_resource_spec.rb +++ b/spec/requests/api/v3/queries/filters/query_filters_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Query Filter resource' do +RSpec.describe 'API v3 Query Filter resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/queries/group_bys/query_group_bys_resource_spec.rb b/spec/requests/api/v3/queries/group_bys/query_group_bys_resource_spec.rb index 0b772f56c79..aee95a76ba0 100644 --- a/spec/requests/api/v3/queries/group_bys/query_group_bys_resource_spec.rb +++ b/spec/requests/api/v3/queries/group_bys/query_group_bys_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Query Group By resource' do +RSpec.describe 'API v3 Query Group By resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/queries/operators/query_operators_resource_spec.rb b/spec/requests/api/v3/queries/operators/query_operators_resource_spec.rb index edeb4c04dfc..09c73edc2c4 100644 --- a/spec/requests/api/v3/queries/operators/query_operators_resource_spec.rb +++ b/spec/requests/api/v3/queries/operators/query_operators_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Query Operator resource' do +RSpec.describe 'API v3 Query Operator resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/queries/order/query_order_api_spec.rb b/spec/requests/api/v3/queries/order/query_order_api_spec.rb index 423cced86c4..6d2cdb014d4 100644 --- a/spec/requests/api/v3/queries/order/query_order_api_spec.rb +++ b/spec/requests/api/v3/queries/order/query_order_api_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe "/api/v3/queries/:id/order" do +RSpec.describe "/api/v3/queries/:id/order" do let(:user) { create(:admin) } let(:query) { create(:query, name: "A Query", user:) } let(:path) { "/api/v3/queries/#{query.id}/order" } diff --git a/spec/requests/api/v3/queries/queries_by_project_resource_spec.rb b/spec/requests/api/v3/queries/queries_by_project_resource_spec.rb index f157d31c574..9789db73d91 100644 --- a/spec/requests/api/v3/queries/queries_by_project_resource_spec.rb +++ b/spec/requests/api/v3/queries/queries_by_project_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Query resource' do +RSpec.describe 'API v3 Query resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/queries/query_resource_spec.rb b/spec/requests/api/v3/queries/query_resource_spec.rb index 34643f70e26..6a4aec210ba 100644 --- a/spec/requests/api/v3/queries/query_resource_spec.rb +++ b/spec/requests/api/v3/queries/query_resource_spec.rb @@ -29,9 +29,9 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Query resource', - content_type: :json, - with_flag: { show_changes: true } do +RSpec.describe 'API v3 Query resource', + content_type: :json, + with_flag: { show_changes: true } do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/queries/schemas/query_filter_instance_schema_resource_spec.rb b/spec/requests/api/v3/queries/schemas/query_filter_instance_schema_resource_spec.rb index d493fab9665..26f163e3148 100644 --- a/spec/requests/api/v3/queries/schemas/query_filter_instance_schema_resource_spec.rb +++ b/spec/requests/api/v3/queries/schemas/query_filter_instance_schema_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Query Filter Schema resource' do +RSpec.describe 'API v3 Query Filter Schema resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/queries/schemas/query_project_schema_resource_spec.rb b/spec/requests/api/v3/queries/schemas/query_project_schema_resource_spec.rb index 366f470198e..1d3fb12038b 100644 --- a/spec/requests/api/v3/queries/schemas/query_project_schema_resource_spec.rb +++ b/spec/requests/api/v3/queries/schemas/query_project_schema_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Query Schema resource' do +RSpec.describe 'API v3 Query Schema resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/queries/schemas/query_schema_resource_spec.rb b/spec/requests/api/v3/queries/schemas/query_schema_resource_spec.rb index a2a9f24df04..179d1dd5c44 100644 --- a/spec/requests/api/v3/queries/schemas/query_schema_resource_spec.rb +++ b/spec/requests/api/v3/queries/schemas/query_schema_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Query Schema resource' do +RSpec.describe 'API v3 Query Schema resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/queries/sort_bys/query_sort_bys_resource_spec.rb b/spec/requests/api/v3/queries/sort_bys/query_sort_bys_resource_spec.rb index 9ada1e492d8..b10bcb35f85 100644 --- a/spec/requests/api/v3/queries/sort_bys/query_sort_bys_resource_spec.rb +++ b/spec/requests/api/v3/queries/sort_bys/query_sort_bys_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Query Sort Bys resource' do +RSpec.describe 'API v3 Query Sort Bys resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/queries/update_form_api_spec.rb b/spec/requests/api/v3/queries/update_form_api_spec.rb index 828a6e45d05..e7480c1be4f 100644 --- a/spec/requests/api/v3/queries/update_form_api_spec.rb +++ b/spec/requests/api/v3/queries/update_form_api_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' require 'rack/test' -describe "POST /api/v3/queries/form", - with_ee: %i[baseline_comparison], with_flag: { show_changes: true } do +RSpec.describe "POST /api/v3/queries/form", + with_ee: %i[baseline_comparison], with_flag: { show_changes: true } do include API::V3::Utilities::PathHelper let(:path) { api_v3_paths.query_form(query.id) } diff --git a/spec/requests/api/v3/queries/update_query_spec.rb b/spec/requests/api/v3/queries/update_query_spec.rb index 42c13136c56..0bc8c500c52 100644 --- a/spec/requests/api/v3/queries/update_query_spec.rb +++ b/spec/requests/api/v3/queries/update_query_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe "PATCH /api/v3/queries/:id", - with_ee: %i[baseline_comparison], with_flag: { show_changes: true } do +RSpec.describe "PATCH /api/v3/queries/:id", + with_ee: %i[baseline_comparison], with_flag: { show_changes: true } do shared_let(:user) { create(:admin) } shared_let(:status) { create(:status) } shared_let(:project) { create(:project) } diff --git a/spec/requests/api/v3/rack_deflater_spec.rb b/spec/requests/api/v3/rack_deflater_spec.rb index 4c8f9208878..ce4f9b763d8 100644 --- a/spec/requests/api/v3/rack_deflater_spec.rb +++ b/spec/requests/api/v3/rack_deflater_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Rack::Deflater do +RSpec.describe Rack::Deflater do include API::V3::Utilities::PathHelper let(:text) { 'text' } diff --git a/spec/requests/api/v3/relations/relations_api_spec.rb b/spec/requests/api/v3/relations/relations_api_spec.rb index 32448ab0884..a559640817f 100644 --- a/spec/requests/api/v3/relations/relations_api_spec.rb +++ b/spec/requests/api/v3/relations/relations_api_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'API v3 Relation resource', content_type: :json do +RSpec.describe 'API v3 Relation resource', content_type: :json do include API::V3::Utilities::PathHelper let(:user) { create(:admin) } diff --git a/spec/requests/api/v3/relations/relations_index_spec.rb b/spec/requests/api/v3/relations/relations_index_spec.rb index 174878138fc..ff2a7beede8 100644 --- a/spec/requests/api/v3/relations/relations_index_spec.rb +++ b/spec/requests/api/v3/relations/relations_index_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'GET /api/v3/relations' do +RSpec.describe 'GET /api/v3/relations' do let(:user) { create(:admin) } let(:work_package) { create(:work_package) } diff --git a/spec/requests/api/v3/relations_resource_spec.rb b/spec/requests/api/v3/relations_resource_spec.rb index a647f64675e..20d23f4ef6d 100644 --- a/spec/requests/api/v3/relations_resource_spec.rb +++ b/spec/requests/api/v3/relations_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Relation resource' do +RSpec.describe 'API v3 Relation resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/render_resource_spec.rb b/spec/requests/api/v3/render_resource_spec.rb index 2b2ac1b5f79..a4a4d8f1b46 100644 --- a/spec/requests/api/v3/render_resource_spec.rb +++ b/spec/requests/api/v3/render_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Render resource' do +RSpec.describe 'API v3 Render resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/repositories/revisions_by_work_package_resource_spec.rb b/spec/requests/api/v3/repositories/revisions_by_work_package_resource_spec.rb index 0a05423fca8..ed5093f2bbb 100644 --- a/spec/requests/api/v3/repositories/revisions_by_work_package_resource_spec.rb +++ b/spec/requests/api/v3/repositories/revisions_by_work_package_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Revisions by work package resource' do +RSpec.describe 'API v3 Revisions by work package resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper include FileHelpers diff --git a/spec/requests/api/v3/repositories/revisions_resource_spec.rb b/spec/requests/api/v3/repositories/revisions_resource_spec.rb index 9fa0a0a5d60..b6cb957e2e4 100644 --- a/spec/requests/api/v3/repositories/revisions_resource_spec.rb +++ b/spec/requests/api/v3/repositories/revisions_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Revisions resource' do +RSpec.describe 'API v3 Revisions resource' do include Rack::Test::Methods include Capybara::RSpecMatchers include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/role_resource_spec.rb b/spec/requests/api/v3/role_resource_spec.rb index f5116301b1b..7affa6b093d 100644 --- a/spec/requests/api/v3/role_resource_spec.rb +++ b/spec/requests/api/v3/role_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 roles resource' do +RSpec.describe 'API v3 roles resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/root_resource_spec.rb b/spec/requests/api/v3/root_resource_spec.rb index 99ef5dbe84c..e6fe8d1cef6 100644 --- a/spec/requests/api/v3/root_resource_spec.rb +++ b/spec/requests/api/v3/root_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Root resource' do +RSpec.describe 'API v3 Root resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/status_resource_spec.rb b/spec/requests/api/v3/status_resource_spec.rb index 3fcddda1ea6..6c86488986b 100644 --- a/spec/requests/api/v3/status_resource_spec.rb +++ b/spec/requests/api/v3/status_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Status resource' do +RSpec.describe 'API v3 Status resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/string_objects_resource_spec.rb b/spec/requests/api/v3/string_objects_resource_spec.rb index dd00a0ffac7..8bec16742b8 100644 --- a/spec/requests/api/v3/string_objects_resource_spec.rb +++ b/spec/requests/api/v3/string_objects_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 String Objects resource' do +RSpec.describe 'API v3 String Objects resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/support/api_helper.rb b/spec/requests/api/v3/support/api_helper.rb index 1645413b072..36aa7a1789c 100644 --- a/spec/requests/api/v3/support/api_helper.rb +++ b/spec/requests/api/v3/support/api_helper.rb @@ -26,11 +26,11 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_examples_for 'safeguarded API' do +RSpec.shared_examples_for 'safeguarded API' do it { expect(last_response.status).to eq(404) } end -shared_examples_for 'valid activity request' do +RSpec.shared_examples_for 'valid activity request' do shared_let(:admin) { create(:admin) } let(:status_code) { 200 } @@ -49,7 +49,7 @@ shared_examples_for 'valid activity request' do end end -shared_examples_for 'invalid activity request' do +RSpec.shared_examples_for 'invalid activity request' do shared_let(:admin) { create(:admin) } before do diff --git a/spec/requests/api/v3/support/api_v3_collection_response.rb b/spec/requests/api/v3/support/api_v3_collection_response.rb index 5561f9247fc..d6dd87c349e 100644 --- a/spec/requests/api/v3/support/api_v3_collection_response.rb +++ b/spec/requests/api/v3/support/api_v3_collection_response.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'API V3 collection response' do |total, count, element_type, collection_type = 'Collection'| +RSpec.shared_examples_for 'API V3 collection response' do |total, count, element_type, collection_type = 'Collection'| subject { last_response.body } # If an array of elements is provided, those elements are expected diff --git a/spec/requests/api/v3/support/authorization.rb b/spec/requests/api/v3/support/authorization.rb index 0a0e83eb5df..3acc8bdc05e 100644 --- a/spec/requests/api/v3/support/authorization.rb +++ b/spec/requests/api/v3/support/authorization.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'handling anonymous user' do +RSpec.shared_examples_for 'handling anonymous user' do context 'anonymous user' do before do allow(User).to receive(:current).and_return(User.anonymous) diff --git a/spec/requests/api/v3/support/response_examples.rb b/spec/requests/api/v3/support/response_examples.rb index 5fb1d01d9fa..b318d5bad36 100644 --- a/spec/requests/api/v3/support/response_examples.rb +++ b/spec/requests/api/v3/support/response_examples.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples_for 'successful response' do |code = 200| +RSpec.shared_examples_for 'successful response' do |code = 200| it "has the status code #{code}" do expect(last_response.status).to eq(code) end @@ -40,13 +40,13 @@ shared_examples_for 'successful response' do |code = 200| end end -shared_examples_for 'successful no content response' do |code = 204| +RSpec.shared_examples_for 'successful no content response' do |code = 204| it "has the status code #{code}" do expect(last_response.status).to eq(code) end end -shared_examples_for 'error response' do |code, id, provided_message = nil| +RSpec.shared_examples_for 'error response' do |code, id, provided_message = nil| let(:expected_message) do provided_message || message end @@ -78,35 +78,35 @@ shared_examples_for 'error response' do |code, id, provided_message = nil| end end -shared_examples_for 'invalid render context' do |message| +RSpec.shared_examples_for 'invalid render context' do |message| it_behaves_like 'error response', 400, 'InvalidRenderContext', message end -shared_examples_for 'invalid request body' do |message| +RSpec.shared_examples_for 'invalid request body' do |message| it_behaves_like 'error response', 400, 'InvalidRequestBody', message end -shared_examples_for 'invalid resource link' do |message| +RSpec.shared_examples_for 'invalid resource link' do |message| it_behaves_like 'error response', 422, 'ResourceTypeMismatch', message end -shared_examples_for 'unsupported content type' do |message| +RSpec.shared_examples_for 'unsupported content type' do |message| it_behaves_like 'error response', 415, 'TypeNotSupported', message end -shared_examples_for 'parse error' do |details| +RSpec.shared_examples_for 'parse error' do |details| it_behaves_like 'invalid request body', I18n.t('api_v3.errors.invalid_json') @@ -118,35 +118,35 @@ shared_examples_for 'parse error' do |details| end end -shared_examples_for 'invalid filters' do +RSpec.shared_examples_for 'invalid filters' do it_behaves_like 'error response', 400, 'InvalidQuery', I18n.t('api_v3.errors.missing_or_malformed_parameter', parameter: 'filters') end -shared_examples_for 'unauthenticated access' do +RSpec.shared_examples_for 'unauthenticated access' do it_behaves_like 'error response', 401, 'Unauthenticated', I18n.t('api_v3.errors.code_401') end -shared_examples_for 'unauthorized access' do +RSpec.shared_examples_for 'unauthorized access' do it_behaves_like 'error response', 403, 'MissingPermission', I18n.t('api_v3.errors.code_403') end -shared_examples_for 'not found' do |message = I18n.t('api_v3.errors.code_404')| +RSpec.shared_examples_for 'not found' do |message = I18n.t('api_v3.errors.code_404')| include_examples 'error response', 404, 'NotFound', message end -shared_examples_for 'param validation error' do +RSpec.shared_examples_for 'param validation error' do subject { JSON.parse(last_response.body) } it 'results in a validation error' do @@ -156,34 +156,34 @@ shared_examples_for 'param validation error' do end end -shared_examples_for 'update conflict' do +RSpec.shared_examples_for 'update conflict' do it_behaves_like 'error response', 409, 'UpdateConflict', I18n.t('api_v3.errors.code_409') end -shared_examples_for 'constraint violation' do +RSpec.shared_examples_for 'constraint violation' do it_behaves_like 'error response', 422, 'PropertyConstraintViolation' end -shared_examples_for 'format error' do |message| +RSpec.shared_examples_for 'format error' do |message| it_behaves_like 'error response', 422, 'PropertyFormatError', message end -shared_examples_for 'missing property' do |message| +RSpec.shared_examples_for 'missing property' do |message| it_behaves_like 'error response', 422, 'PropertyMissingError', message end -shared_examples_for 'read-only violation' do |attribute, model, attribute_message = nil| +RSpec.shared_examples_for 'read-only violation' do |attribute, model, attribute_message = nil| describe 'details' do subject { JSON.parse(last_response.body)['_embedded']['details'] } @@ -200,14 +200,14 @@ shared_examples_for 'read-only violation' do |attribute, model, attribute_messag message end -shared_examples_for 'multiple errors' do |code, _message| +RSpec.shared_examples_for 'multiple errors' do |code, _message| it_behaves_like 'error response', code, 'MultipleErrors', I18n.t('api_v3.errors.multiple_errors') end -shared_examples_for 'multiple errors of the same type' do |error_count, id| +RSpec.shared_examples_for 'multiple errors of the same type' do |error_count, id| subject { JSON.parse(last_response.body)['_embedded']['errors'] } it { expect(subject.count).to eq(error_count) } @@ -219,7 +219,7 @@ shared_examples_for 'multiple errors of the same type' do |error_count, id| end end -shared_examples_for 'multiple errors of the same type with details' do |expected_details, expected_detail_values| +RSpec.shared_examples_for 'multiple errors of the same type with details' do |expected_details, expected_detail_values| let(:errors) { JSON.parse(last_response.body)['_embedded']['errors'] } let(:details) do errors.each_with_object([]) { |error, l| l << error['_embedded']['details'] }.compact @@ -240,7 +240,7 @@ shared_examples_for 'multiple errors of the same type with details' do |expected end end -shared_examples_for 'multiple errors of the same type with messages' do +RSpec.shared_examples_for 'multiple errors of the same type with messages' do let(:errors) { JSON.parse(last_response.body)['_embedded']['errors'] } let(:actual_messages) do errors.each_with_object([]) { |error, l| l << error['message'] }.compact diff --git a/spec/requests/api/v3/types/type_resource_spec.rb b/spec/requests/api/v3/types/type_resource_spec.rb index 6f7bf5d966e..6640df06990 100644 --- a/spec/requests/api/v3/types/type_resource_spec.rb +++ b/spec/requests/api/v3/types/type_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Type resource' do +RSpec.describe 'API v3 Type resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/types/types_by_project_resource_spec.rb b/spec/requests/api/v3/types/types_by_project_resource_spec.rb index bb6183605cb..3942c0557be 100644 --- a/spec/requests/api/v3/types/types_by_project_resource_spec.rb +++ b/spec/requests/api/v3/types/types_by_project_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe '/api/v3/projects/:id/types' do +RSpec.describe '/api/v3/projects/:id/types' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/user/create_form_resource_spec.rb b/spec/requests/api/v3/user/create_form_resource_spec.rb index e5c551529bb..e18a9d70435 100644 --- a/spec/requests/api/v3/user/create_form_resource_spec.rb +++ b/spec/requests/api/v3/user/create_form_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Users::CreateFormAPI, content_type: :json do +RSpec.describe API::V3::Users::CreateFormAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/user/create_user_common_examples.rb b/spec/requests/api/v3/user/create_user_common_examples.rb index 45aad12eb70..31da1ee1000 100644 --- a/spec/requests/api/v3/user/create_user_common_examples.rb +++ b/spec/requests/api/v3/user/create_user_common_examples.rb @@ -25,7 +25,7 @@ # # See COPYRIGHT and LICENSE files for more details. -shared_examples 'represents the created user' do |expected_attributes| +RSpec.shared_examples 'represents the created user' do |expected_attributes| it 'returns the represented user' do send_request @@ -44,18 +44,18 @@ shared_examples 'represents the created user' do |expected_attributes| end end -shared_examples 'property is not writable' do |attributeName| +RSpec.shared_examples 'property is not writable' do |attribute_name| it 'returns an error for the unwritable property' do send_request attr = JSON.parse(last_response.body).dig "_embedded", "details", "attribute" expect(last_response.status).to eq 422 - expect(attr).to eq attributeName + expect(attr).to eq attribute_name end end -shared_examples 'create user request flow' do +RSpec.shared_examples 'create user request flow' do let(:errors) { parse_json(last_response.body)['_embedded']['errors'] } describe 'empty request body' do diff --git a/spec/requests/api/v3/user/create_user_resource_spec.rb b/spec/requests/api/v3/user/create_user_resource_spec.rb index 3155336595a..e6cda49de63 100644 --- a/spec/requests/api/v3/user/create_user_resource_spec.rb +++ b/spec/requests/api/v3/user/create_user_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' require_relative './create_user_common_examples' -describe API::V3::Users::UsersAPI do +RSpec.describe API::V3::Users::UsersAPI do include API::V3::Utilities::PathHelper let(:path) { api_v3_paths.users } diff --git a/spec/requests/api/v3/user/filters_spec.rb b/spec/requests/api/v3/user/filters_spec.rb index 901a5295d34..c454c24644c 100644 --- a/spec/requests/api/v3/user/filters_spec.rb +++ b/spec/requests/api/v3/user/filters_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe 'GET /api/v3/users' do +RSpec.describe 'GET /api/v3/users' do let!(:users) do [ create(:admin, login: 'admin', status: :active), diff --git a/spec/requests/api/v3/user/schemas/user_schema_resource_spec.rb b/spec/requests/api/v3/user/schemas/user_schema_resource_spec.rb index 8e289ffd0de..a1db833238a 100644 --- a/spec/requests/api/v3/user/schemas/user_schema_resource_spec.rb +++ b/spec/requests/api/v3/user/schemas/user_schema_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Users schema resource', content_type: :json do +RSpec.describe 'API v3 Users schema resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/user/update_form_resource_spec.rb b/spec/requests/api/v3/user/update_form_resource_spec.rb index 6afa2355b5e..9eefb8111ed 100644 --- a/spec/requests/api/v3/user/update_form_resource_spec.rb +++ b/spec/requests/api/v3/user/update_form_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Users::UpdateFormAPI, content_type: :json do +RSpec.describe API::V3::Users::UpdateFormAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/user/update_user_resource_spec.rb b/spec/requests/api/v3/user/update_user_resource_spec.rb index d30b40f27c5..f49dc4f9454 100644 --- a/spec/requests/api/v3/user/update_user_resource_spec.rb +++ b/spec/requests/api/v3/user/update_user_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Users::UsersAPI do +RSpec.describe API::V3::Users::UsersAPI do include API::V3::Utilities::PathHelper let(:path) { api_v3_paths.user(user.id) } diff --git a/spec/requests/api/v3/user/user_resource_spec.rb b/spec/requests/api/v3/user/user_resource_spec.rb index 6058d3f078a..d6efb7a89e3 100644 --- a/spec/requests/api/v3/user/user_resource_spec.rb +++ b/spec/requests/api/v3/user/user_resource_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 User resource', - content_type: :json do +RSpec.describe 'API v3 User resource', + content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/user/userlock_resource_spec.rb b/spec/requests/api/v3/user/userlock_resource_spec.rb index 5db55758aa5..527ad947151 100644 --- a/spec/requests/api/v3/user/userlock_resource_spec.rb +++ b/spec/requests/api/v3/user/userlock_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 UserLock resource', content_type: :json do +RSpec.describe 'API v3 UserLock resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/user_preferences/user_preferences_resource_spec.rb b/spec/requests/api/v3/user_preferences/user_preferences_resource_spec.rb index 248697b72e8..45cd564a330 100644 --- a/spec/requests/api/v3/user_preferences/user_preferences_resource_spec.rb +++ b/spec/requests/api/v3/user_preferences/user_preferences_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 UserPreferences resource', content_type: :json do +RSpec.describe 'API v3 UserPreferences resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/values/schemas/value_schema_resource_spec.rb b/spec/requests/api/v3/values/schemas/value_schema_resource_spec.rb index 2cc6e7953a0..c77967fa9cf 100644 --- a/spec/requests/api/v3/values/schemas/value_schema_resource_spec.rb +++ b/spec/requests/api/v3/values/schemas/value_schema_resource_spec.rb @@ -28,9 +28,9 @@ require 'spec_helper' -describe API::V3::Values::Schemas::ValueSchemaAPI, - 'show', - content_type: :json do +RSpec.describe API::V3::Values::Schemas::ValueSchemaAPI, + 'show', + content_type: :json do include API::V3::Utilities::PathHelper current_user { build_stubbed(:user) } diff --git a/spec/requests/api/v3/version_resource_spec.rb b/spec/requests/api/v3/version_resource_spec.rb index 860c09f2291..1835d57b0b2 100644 --- a/spec/requests/api/v3/version_resource_spec.rb +++ b/spec/requests/api/v3/version_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Version resource', content_type: :json do +RSpec.describe 'API v3 Version resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/versions/available_projects_resource_spec.rb b/spec/requests/api/v3/versions/available_projects_resource_spec.rb index 7be3d81eb9e..baf54f16be3 100644 --- a/spec/requests/api/v3/versions/available_projects_resource_spec.rb +++ b/spec/requests/api/v3/versions/available_projects_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 members available projects resource' do +RSpec.describe 'API v3 members available projects resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/versions/create_form_resource_spec.rb b/spec/requests/api/v3/versions/create_form_resource_spec.rb index 44bbc4b170c..f1389731c82 100644 --- a/spec/requests/api/v3/versions/create_form_resource_spec.rb +++ b/spec/requests/api/v3/versions/create_form_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Versions::CreateFormAPI, content_type: :json do +RSpec.describe API::V3::Versions::CreateFormAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/versions/project_resource_spec.rb b/spec/requests/api/v3/versions/project_resource_spec.rb index 8f68e929cca..2c1b7b3787e 100644 --- a/spec/requests/api/v3/versions/project_resource_spec.rb +++ b/spec/requests/api/v3/versions/project_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe "API v3 version's projects resource" do +RSpec.describe "API v3 version's projects resource" do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/versions/schemas/version_schema_resource_spec.rb b/spec/requests/api/v3/versions/schemas/version_schema_resource_spec.rb index 3486bb8adfe..fd3760ff917 100644 --- a/spec/requests/api/v3/versions/schemas/version_schema_resource_spec.rb +++ b/spec/requests/api/v3/versions/schemas/version_schema_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Version schema resource', content_type: :json do +RSpec.describe 'API v3 Version schema resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/versions/update_form_resource_spec.rb b/spec/requests/api/v3/versions/update_form_resource_spec.rb index dc3cd8b03e9..e68c9e24bd1 100644 --- a/spec/requests/api/v3/versions/update_form_resource_spec.rb +++ b/spec/requests/api/v3/versions/update_form_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Versions::UpdateFormAPI, content_type: :json do +RSpec.describe API::V3::Versions::UpdateFormAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/views/create_resource_spec.rb b/spec/requests/api/v3/views/create_resource_spec.rb index 2031e3a2ea0..cba367b63af 100644 --- a/spec/requests/api/v3/views/create_resource_spec.rb +++ b/spec/requests/api/v3/views/create_resource_spec.rb @@ -27,9 +27,9 @@ require 'spec_helper' -describe API::V3::Views::ViewsAPI, - 'create', - content_type: :json do +RSpec.describe API::V3::Views::ViewsAPI, + 'create', + content_type: :json do include API::V3::Utilities::PathHelper shared_let(:permitted_user) { create(:user) } diff --git a/spec/requests/api/v3/views/index_resource_spec.rb b/spec/requests/api/v3/views/index_resource_spec.rb index ca59d2cb6c9..5a5830f7d36 100644 --- a/spec/requests/api/v3/views/index_resource_spec.rb +++ b/spec/requests/api/v3/views/index_resource_spec.rb @@ -28,9 +28,9 @@ require 'spec_helper' require 'rack/test' -describe API::V3::Views::ViewsAPI, - 'index', - content_type: :json do +RSpec.describe API::V3::Views::ViewsAPI, + 'index', + content_type: :json do include API::V3::Utilities::PathHelper shared_let(:permitted_user) { create(:user) } diff --git a/spec/requests/api/v3/views/show_resource_spec.rb b/spec/requests/api/v3/views/show_resource_spec.rb index 86619b36876..3cf80349fb3 100644 --- a/spec/requests/api/v3/views/show_resource_spec.rb +++ b/spec/requests/api/v3/views/show_resource_spec.rb @@ -27,9 +27,9 @@ require 'spec_helper' -describe API::V3::Views::ViewsAPI, - 'show', - content_type: :json do +RSpec.describe API::V3::Views::ViewsAPI, + 'show', + content_type: :json do include API::V3::Utilities::PathHelper shared_let(:permitted_user) { create(:user) } diff --git a/spec/requests/api/v3/watcher_resource_spec.rb b/spec/requests/api/v3/watcher_resource_spec.rb index d76e6e5328d..c2f69f7ee2c 100644 --- a/spec/requests/api/v3/watcher_resource_spec.rb +++ b/spec/requests/api/v3/watcher_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Watcher resource', content_type: :json do +RSpec.describe 'API v3 Watcher resource', content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/wiki_pages_resource_spec.rb b/spec/requests/api/v3/wiki_pages_resource_spec.rb index fdc658bc74c..f11a3b113fd 100644 --- a/spec/requests/api/v3/wiki_pages_resource_spec.rb +++ b/spec/requests/api/v3/wiki_pages_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 wiki_pages resource' do +RSpec.describe 'API v3 wiki_pages resource' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/work_packages/available_projects_on_create_api_spec.rb b/spec/requests/api/v3/work_packages/available_projects_on_create_api_spec.rb index 79fbb5510af..aa0b20e3915 100644 --- a/spec/requests/api/v3/work_packages/available_projects_on_create_api_spec.rb +++ b/spec/requests/api/v3/work_packages/available_projects_on_create_api_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::WorkPackages::AvailableProjectsOnCreateAPI do +RSpec.describe API::V3::WorkPackages::AvailableProjectsOnCreateAPI do include API::V3::Utilities::PathHelper let(:add_role) do diff --git a/spec/requests/api/v3/work_packages/available_projects_on_edit_api_spec.rb b/spec/requests/api/v3/work_packages/available_projects_on_edit_api_spec.rb index 023564e7e37..4fb262cfc78 100644 --- a/spec/requests/api/v3/work_packages/available_projects_on_edit_api_spec.rb +++ b/spec/requests/api/v3/work_packages/available_projects_on_edit_api_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API::V3::WorkPackages::AvailableProjectsOnEditAPI' do +RSpec.describe 'API::V3::WorkPackages::AvailableProjectsOnEditAPI' do include API::V3::Utilities::PathHelper let(:edit_role) do diff --git a/spec/requests/api/v3/work_packages/available_relation_candidates_resource_spec.rb b/spec/requests/api/v3/work_packages/available_relation_candidates_resource_spec.rb index 30448e6c51d..237bb432335 100644 --- a/spec/requests/api/v3/work_packages/available_relation_candidates_resource_spec.rb +++ b/spec/requests/api/v3/work_packages/available_relation_candidates_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe API::V3::WorkPackages::AvailableRelationCandidatesAPI do +RSpec.describe API::V3::WorkPackages::AvailableRelationCandidatesAPI do shared_let(:user) { create(:admin) } shared_let(:project1) { create(:project) } diff --git a/spec/requests/api/v3/work_packages/by_project_create_resource_spec.rb b/spec/requests/api/v3/work_packages/by_project_create_resource_spec.rb index c6e3828afdb..a2026f1f2d5 100644 --- a/spec/requests/api/v3/work_packages/by_project_create_resource_spec.rb +++ b/spec/requests/api/v3/work_packages/by_project_create_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::WorkPackages::WorkPackagesByProjectAPI, content_type: :json do +RSpec.describe API::V3::WorkPackages::WorkPackagesByProjectAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/work_packages/by_project_index_resource_spec.rb b/spec/requests/api/v3/work_packages/by_project_index_resource_spec.rb index 27519adb3ca..19df61a71f9 100644 --- a/spec/requests/api/v3/work_packages/by_project_index_resource_spec.rb +++ b/spec/requests/api/v3/work_packages/by_project_index_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::WorkPackages::WorkPackagesByProjectAPI, content_type: :json do +RSpec.describe API::V3::WorkPackages::WorkPackagesByProjectAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/work_packages/create_form_resource_spec.rb b/spec/requests/api/v3/work_packages/create_form_resource_spec.rb index b3624f5ca18..bf7c1f28e7f 100644 --- a/spec/requests/api/v3/work_packages/create_form_resource_spec.rb +++ b/spec/requests/api/v3/work_packages/create_form_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::WorkPackages::CreateProjectFormAPI do +RSpec.describe API::V3::WorkPackages::CreateProjectFormAPI do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/work_packages/create_project_form_resource_spec.rb b/spec/requests/api/v3/work_packages/create_project_form_resource_spec.rb index 249ef82fdce..9c71e654450 100644 --- a/spec/requests/api/v3/work_packages/create_project_form_resource_spec.rb +++ b/spec/requests/api/v3/work_packages/create_project_form_resource_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::WorkPackages::CreateProjectFormAPI, content_type: :json do +RSpec.describe API::V3::WorkPackages::CreateProjectFormAPI, content_type: :json do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/work_packages/create_resource_spec.rb b/spec/requests/api/v3/work_packages/create_resource_spec.rb index 094f7dc7b56..53e125c913e 100644 --- a/spec/requests/api/v3/work_packages/create_resource_spec.rb +++ b/spec/requests/api/v3/work_packages/create_resource_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Work package resource', - content_type: :json do +RSpec.describe 'API v3 Work package resource', + content_type: :json do include API::V3::Utilities::PathHelper shared_let(:project) do diff --git a/spec/requests/api/v3/work_packages/delete_resource_spec.rb b/spec/requests/api/v3/work_packages/delete_resource_spec.rb index f91853778b2..b14445fc460 100644 --- a/spec/requests/api/v3/work_packages/delete_resource_spec.rb +++ b/spec/requests/api/v3/work_packages/delete_resource_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Work package resource', - content_type: :json do +RSpec.describe 'API v3 Work package resource', + content_type: :json do include API::V3::Utilities::PathHelper let(:work_package) do diff --git a/spec/requests/api/v3/work_packages/form/work_package_form_resource_spec.rb b/spec/requests/api/v3/work_packages/form/work_package_form_resource_spec.rb index 808e098d0f9..3a0bb09e5ee 100644 --- a/spec/requests/api/v3/work_packages/form/work_package_form_resource_spec.rb +++ b/spec/requests/api/v3/work_packages/form/work_package_form_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Work package form resource', with_mail: false do +RSpec.describe 'API v3 Work package form resource', with_mail: false do include Rack::Test::Methods include Capybara::RSpecMatchers include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/work_packages/index_resource_spec.rb b/spec/requests/api/v3/work_packages/index_resource_spec.rb index f47f33b89da..ba1ae3717ad 100644 --- a/spec/requests/api/v3/work_packages/index_resource_spec.rb +++ b/spec/requests/api/v3/work_packages/index_resource_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Work package resource', - content_type: :json do +RSpec.describe 'API v3 Work package resource', + content_type: :json do include API::V3::Utilities::PathHelper create_shared_association_defaults_for_work_package_factory diff --git a/spec/requests/api/v3/work_packages/show_resource_spec.rb b/spec/requests/api/v3/work_packages/show_resource_spec.rb index be993b365c9..36b14dab7ed 100644 --- a/spec/requests/api/v3/work_packages/show_resource_spec.rb +++ b/spec/requests/api/v3/work_packages/show_resource_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Work package resource', - content_type: :json do +RSpec.describe 'API v3 Work package resource', + content_type: :json do include Rack::Test::Methods include Capybara::RSpecMatchers include API::V3::Utilities::PathHelper diff --git a/spec/requests/api/v3/work_packages/update_resource_spec.rb b/spec/requests/api/v3/work_packages/update_resource_spec.rb index 712623ffe49..c3140de7345 100644 --- a/spec/requests/api/v3/work_packages/update_resource_spec.rb +++ b/spec/requests/api/v3/work_packages/update_resource_spec.rb @@ -29,8 +29,8 @@ require 'spec_helper' require 'rack/test' -describe 'API v3 Work package resource', - content_type: :json do +RSpec.describe 'API v3 Work package resource', + content_type: :json do include API::V3::Utilities::PathHelper create_shared_association_defaults_for_work_package_factory diff --git a/spec/requests/api/v3/work_packages/work_packages_schemas_resource_spec.rb b/spec/requests/api/v3/work_packages/work_packages_schemas_resource_spec.rb index 57c632b88ca..9d982706889 100644 --- a/spec/requests/api/v3/work_packages/work_packages_schemas_resource_spec.rb +++ b/spec/requests/api/v3/work_packages/work_packages_schemas_resource_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe API::V3::WorkPackages::Schema::WorkPackageSchemasAPI do +RSpec.describe API::V3::WorkPackages::Schema::WorkPackageSchemasAPI do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/auth/auth_source_sso_spec.rb b/spec/requests/auth/auth_source_sso_spec.rb index 453105de592..d15f019f065 100644 --- a/spec/requests/auth/auth_source_sso_spec.rb +++ b/spec/requests/auth/auth_source_sso_spec.rb @@ -28,9 +28,9 @@ require 'spec_helper' -describe AuthSourceSSO, - skip_2fa_stage: true, # Prevent redirects to 2FA stage - type: :rails_request do +RSpec.describe AuthSourceSSO, + skip_2fa_stage: true, # Prevent redirects to 2FA stage + type: :rails_request do let(:sso_config) do { header: "X-Remote-User", diff --git a/spec/requests/auth/oauth_login_csp_spec.rb b/spec/requests/auth/oauth_login_csp_spec.rb index 221df8be5f0..92a0ef25e40 100644 --- a/spec/requests/auth/oauth_login_csp_spec.rb +++ b/spec/requests/auth/oauth_login_csp_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe 'CSP appends on login form from oauth', - type: :rails_request do +RSpec.describe 'CSP appends on login form from oauth', + type: :rails_request do let!(:redirect_uri) { 'https://foobar.com' } let!(:oauth_app) { create(:oauth_application, redirect_uri:) } let(:oauth_path) do diff --git a/spec/requests/auth/token_based_access_spec.rb b/spec/requests/auth/token_based_access_spec.rb index e810c2b312d..9824c1bca2c 100644 --- a/spec/requests/auth/token_based_access_spec.rb +++ b/spec/requests/auth/token_based_access_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'Token based access', type: :rails_request, with_settings: { login_required?: false } do +RSpec.describe 'Token based access', type: :rails_request, with_settings: { login_required?: false } do let(:work_package) { create(:work_package) } let(:user) do create(:user, diff --git a/spec/requests/oauth/client_credentials_flow_spec.rb b/spec/requests/oauth/client_credentials_flow_spec.rb index 6d673e3fecf..7314e84003b 100644 --- a/spec/requests/oauth/client_credentials_flow_spec.rb +++ b/spec/requests/oauth/client_credentials_flow_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' require 'rest-client' # rubocop:disable Rails/HttpPositionalArguments -describe 'OAuth client credentials flow' do +RSpec.describe 'OAuth client credentials flow' do include Rack::Test::Methods let!(:application) { create(:oauth_application, client_credentials_user_id: user_id, name: 'Cool API app!') } diff --git a/spec/requests/oauth/oauth_application_spec.rb b/spec/requests/oauth/oauth_application_spec.rb index de58f663348..28fbbe9b758 100644 --- a/spec/requests/oauth/oauth_application_spec.rb +++ b/spec/requests/oauth/oauth_application_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'API v3 oauth applications resource', content_type: :json do +RSpec.describe 'API v3 oauth applications resource', content_type: :json do include API::V3::Utilities::PathHelper let(:current_user) { create(:admin) } diff --git a/spec/requests/oauth_clients/callback_flow_spec.rb b/spec/requests/oauth_clients/callback_flow_spec.rb index 0f5aea183f2..1a664a11389 100644 --- a/spec/requests/oauth_clients/callback_flow_spec.rb +++ b/spec/requests/oauth_clients/callback_flow_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'OAuthClient callback endpoint' do +RSpec.describe 'OAuthClient callback endpoint' do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/requests/oauth_clients/oauth_client_credentials_spec.rb b/spec/requests/oauth_clients/oauth_client_credentials_spec.rb index 79ff742b581..6ca233a97a8 100644 --- a/spec/requests/oauth_clients/oauth_client_credentials_spec.rb +++ b/spec/requests/oauth_clients/oauth_client_credentials_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'API v3 oauth applications resource', content_type: :json do +RSpec.describe 'API v3 oauth applications resource', content_type: :json do include API::V3::Utilities::PathHelper let(:oauth_client_credentials) { create(:oauth_client) } diff --git a/spec/requests/openid_google_provider_callback_spec.rb b/spec/requests/openid_google_provider_callback_spec.rb index 50fb32e395a..d0af8232539 100644 --- a/spec/requests/openid_google_provider_callback_spec.rb +++ b/spec/requests/openid_google_provider_callback_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'rack/test' -describe 'OpenID Google provider callback', with_ee: %i[openid_providers] do +RSpec.describe 'OpenID Google provider callback', with_ee: %i[openid_providers] do include Rack::Test::Methods include API::V3::Utilities::PathHelper diff --git a/spec/routing/account_spec.rb b/spec/routing/account_spec.rb index 38a1073eff5..1824e6df681 100644 --- a/spec/routing/account_spec.rb +++ b/spec/routing/account_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'account routes' do +RSpec.describe 'account routes' do it '/account/lost_password GET routes to account#lost_password' do expect(get('/account/lost_password')).to route_to('account#lost_password') end diff --git a/spec/routing/activities_spec.rb b/spec/routing/activities_spec.rb index 74a431c9fd3..2596aa3dfbd 100644 --- a/spec/routing/activities_spec.rb +++ b/spec/routing/activities_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ActivitiesController, 'routing' do +RSpec.describe ActivitiesController, 'routing' do it { expect(get('/activity')).to route_to(controller: 'activities', action: 'index') diff --git a/spec/routing/admin/incoming_mails_spec.rb b/spec/routing/admin/incoming_mails_spec.rb index b41a8928357..4ac7ad68b96 100644 --- a/spec/routing/admin/incoming_mails_spec.rb +++ b/spec/routing/admin/incoming_mails_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'admin incoming_mails routes' do +RSpec.describe 'admin incoming_mails routes' do it do expect(get('admin/settings/incoming_mails')) .to route_to('admin/settings/incoming_mails_settings#show') diff --git a/spec/routing/admin/mail_notifications_spec.rb b/spec/routing/admin/mail_notifications_spec.rb index 7849a2a9ccf..171061c1060 100644 --- a/spec/routing/admin/mail_notifications_spec.rb +++ b/spec/routing/admin/mail_notifications_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'admin mail_notifications routes' do +RSpec.describe 'admin mail_notifications routes' do it do expect(get('admin/settings/mail_notifications')) .to route_to('admin/settings/mail_notifications_settings#show') diff --git a/spec/routing/admin_spec.rb b/spec/routing/admin_spec.rb index 1d6061d05c5..39c8a054e28 100644 --- a/spec/routing/admin_spec.rb +++ b/spec/routing/admin_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'admin routes' do +RSpec.describe 'admin routes' do it 'connects GET /admin to admin#index' do expect(get('/admin')) .to route_to('admin#index') diff --git a/spec/routing/attachments_spec.rb b/spec/routing/attachments_spec.rb index f6c618d86a6..6f32d3a8b0f 100644 --- a/spec/routing/attachments_spec.rb +++ b/spec/routing/attachments_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'attachments routing', type: :request do +RSpec.describe 'attachments routing', type: :request do describe 'for backwards compatibility' do it 'redirects GET attachments/:id to api v3 attachments/:id/content' do get "/attachments/1" diff --git a/spec/routing/attribute_help_text_spec.rb b/spec/routing/attribute_help_text_spec.rb index b79ae81c05c..30006a376ec 100644 --- a/spec/routing/attribute_help_text_spec.rb +++ b/spec/routing/attribute_help_text_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe AttributeHelpTextsController do +RSpec.describe AttributeHelpTextsController do it 'routes CRUD to the controller' do expect(get('/admin/attribute_help_texts')) .to route_to(controller: 'attribute_help_texts', action: 'index') diff --git a/spec/routing/categories_spec.rb b/spec/routing/categories_spec.rb index 9653021067b..d411f0d26fb 100644 --- a/spec/routing/categories_spec.rb +++ b/spec/routing/categories_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CategoriesController do +RSpec.describe CategoriesController do it 'connects GET /projects/test/categories/new to categories#new' do expect(get('/projects/test/categories/new')).to route_to(controller: 'categories', action: 'new', diff --git a/spec/routing/custom_actions_spec.rb b/spec/routing/custom_actions_spec.rb index 660f7f7a24d..eb08d75c42e 100644 --- a/spec/routing/custom_actions_spec.rb +++ b/spec/routing/custom_actions_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'custom_actions routes' do +RSpec.describe 'custom_actions routes' do describe 'index' do it 'links GET /admin/custom_actions' do expect(get('/admin/custom_actions')) diff --git a/spec/routing/enterprise_routing_spec.rb b/spec/routing/enterprise_routing_spec.rb index f667bc852d3..ddf8b4f8d1d 100644 --- a/spec/routing/enterprise_routing_spec.rb +++ b/spec/routing/enterprise_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe EnterprisesController do +RSpec.describe EnterprisesController do context "when `ee_manager_visible`" do it 'connects GET /admin/enterprise to enterprises#show' do allow(OpenProject::Configuration).to receive(:ee_manager_visible?).and_return(true) diff --git a/spec/routing/enumerations_spec.rb b/spec/routing/enumerations_spec.rb index 9e2f90703ac..13b925fd41b 100644 --- a/spec/routing/enumerations_spec.rb +++ b/spec/routing/enumerations_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe EnumerationsController, 'routing' do +RSpec.describe EnumerationsController, 'routing' do context 'admin scoped' do it { expect(subject).to route(:get, 'admin/enumerations').to(controller: 'enumerations', diff --git a/spec/routing/errors_routing_spec.rb b/spec/routing/errors_routing_spec.rb index ff3da8cbe1d..e8e5efb8a33 100644 --- a/spec/routing/errors_routing_spec.rb +++ b/spec/routing/errors_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'errors routing' do +RSpec.describe 'errors routing' do it { is_expected.to route(:get, '/404').to(controller: 'errors', action: 'not_found') } it { is_expected.to route(:get, '/422').to(controller: 'errors', action: 'unacceptable') } it { is_expected.to route(:get, '/500').to(controller: 'errors', action: 'internal_error') } diff --git a/spec/routing/forums_routing_spec.rb b/spec/routing/forums_routing_spec.rb index 6822e1d787d..7b60eec4075 100644 --- a/spec/routing/forums_routing_spec.rb +++ b/spec/routing/forums_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ForumsController do +RSpec.describe ForumsController do it { expect(subject).to route(:get, '/projects/world_domination/forums').to(controller: 'forums', action: 'index', diff --git a/spec/routing/groups_spec.rb b/spec/routing/groups_spec.rb index 78099b05f82..99e89132a08 100644 --- a/spec/routing/groups_spec.rb +++ b/spec/routing/groups_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'groups routes' do +RSpec.describe 'groups routes' do it { expect(subject).to route(:get, '/admin/groups').to(controller: 'groups', action: 'index') diff --git a/spec/routing/help_routing_spec.rb b/spec/routing/help_routing_spec.rb index cb1d063cd71..3c540e18eb9 100644 --- a/spec/routing/help_routing_spec.rb +++ b/spec/routing/help_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe HelpController do +RSpec.describe HelpController do it 'connects GET /help/keyboard_shortcuts to help#keyboard_shortcuts' do expect(get('/help/keyboard_shortcuts')) .to route_to(controller: 'help', diff --git a/spec/routing/homescreen_spec.rb b/spec/routing/homescreen_spec.rb index 362ad8d836f..e1a9721d664 100644 --- a/spec/routing/homescreen_spec.rb +++ b/spec/routing/homescreen_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'homescreen routes' do +RSpec.describe 'homescreen routes' do it '/ routes to homscreen#index' do expect(get('/')).to route_to('homescreen#index') end diff --git a/spec/routing/journals_spec.rb b/spec/routing/journals_spec.rb index 7635406a370..9e84beaf3d9 100644 --- a/spec/routing/journals_spec.rb +++ b/spec/routing/journals_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe JournalsController do +RSpec.describe JournalsController do it 'connects GET /journals/ to journals#index' do expect(get('/journals/')).to route_to(controller: 'journals', action: 'index') diff --git a/spec/routing/members_spec.rb b/spec/routing/members_spec.rb index 3ceb2a87754..6c5dc884736 100644 --- a/spec/routing/members_spec.rb +++ b/spec/routing/members_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe MembersController do +RSpec.describe MembersController do context 'project scoped' do it { expect(subject).to route(:post, '/projects/5234/members').to(controller: 'members', diff --git a/spec/routing/messages_spec.rb b/spec/routing/messages_spec.rb index 8fdc6d0c2a4..bac34f28dca 100644 --- a/spec/routing/messages_spec.rb +++ b/spec/routing/messages_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe MessagesController, 'routing' do +RSpec.describe MessagesController, 'routing' do context 'project scoped' do it { expect(subject).to route(:get, '/forums/lala/topics/new').to(controller: 'messages', diff --git a/spec/routing/my_spec.rb b/spec/routing/my_spec.rb index 02da9cc0d93..cc8afc78103 100644 --- a/spec/routing/my_spec.rb +++ b/spec/routing/my_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'my routes' do +RSpec.describe 'my routes' do it '/my/account GET routes to my#account' do expect(get('/my/account')).to route_to('my#account') end diff --git a/spec/routing/news_comments_spec.rb b/spec/routing/news_comments_spec.rb index d9d0f49ae38..849b88281db 100644 --- a/spec/routing/news_comments_spec.rb +++ b/spec/routing/news_comments_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe News::CommentsController, 'routing' do +RSpec.describe News::CommentsController, 'routing' do context 'news scoped' do it { expect(subject).to route(:post, '/news/567/comments').to(controller: 'news/comments', diff --git a/spec/routing/news_spec.rb b/spec/routing/news_spec.rb index 37806b0a87f..2c6ccc6327b 100644 --- a/spec/routing/news_spec.rb +++ b/spec/routing/news_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe NewsController, 'routing' do +RSpec.describe NewsController, 'routing' do context 'project scoped' do it { expect(subject).to route(:get, '/projects/567/news').to(controller: 'news', diff --git a/spec/routing/old_issue_2_wp_spec.rb b/spec/routing/old_issue_2_wp_spec.rb index 8a513e43cc3..6fff616dd89 100644 --- a/spec/routing/old_issue_2_wp_spec.rb +++ b/spec/routing/old_issue_2_wp_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'routes for old issue uris', type: :request do +RSpec.describe 'routes for old issue uris', type: :request do # These are routing specs and should be moved to # spec/routing. # As redirect_to is not supported by routing specs they have diff --git a/spec/routing/project_routing_spec.rb b/spec/routing/project_routing_spec.rb index 96cf89e21df..b6fd4668863 100644 --- a/spec/routing/project_routing_spec.rb +++ b/spec/routing/project_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ProjectsController do +RSpec.describe ProjectsController do describe 'index' do it do expect(get('/projects')).to route_to( diff --git a/spec/routing/project_settings_routing_spec.rb b/spec/routing/project_settings_routing_spec.rb index 781d9c9d6b6..b2ba39d46fa 100644 --- a/spec/routing/project_settings_routing_spec.rb +++ b/spec/routing/project_settings_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::SettingsController do +RSpec.describe Projects::SettingsController do describe 'show' do it do expect(get('/projects/123/settings/general')) diff --git a/spec/routing/repositories_routing_spec.rb b/spec/routing/repositories_routing_spec.rb index 30134f2194c..e625a48084f 100644 --- a/spec/routing/repositories_routing_spec.rb +++ b/spec/routing/repositories_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe RepositoriesController do +RSpec.describe RepositoriesController do describe 'show' do it { expect(get('/projects/testproject/repository')) diff --git a/spec/routing/roles_spec.rb b/spec/routing/roles_spec.rb index 8164568bc40..c81427e989a 100644 --- a/spec/routing/roles_spec.rb +++ b/spec/routing/roles_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'roles routes' do +RSpec.describe 'roles routes' do context 'admin scoped' do it { expect(subject).to route(:get, 'admin/roles').to(controller: 'roles', diff --git a/spec/routing/search_spec.rb b/spec/routing/search_spec.rb index 9955994a7eb..6ee338bb265 100644 --- a/spec/routing/search_spec.rb +++ b/spec/routing/search_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe SearchController do +RSpec.describe SearchController do it 'connects GET /search to search#index' do expect(get('/search')).to route_to(controller: 'search', action: 'index') diff --git a/spec/routing/settings_spec.rb b/spec/routing/settings_spec.rb index 8e46ba5144b..c1c9450196f 100644 --- a/spec/routing/settings_spec.rb +++ b/spec/routing/settings_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'settings routes' do +RSpec.describe 'settings routes' do it do expect(get('/admin/settings/plugin/abc')) .to route_to(controller: 'admin/settings', diff --git a/spec/routing/short_uri_wp_spec.rb b/spec/routing/short_uri_wp_spec.rb index a982a5aadd5..db607276816 100644 --- a/spec/routing/short_uri_wp_spec.rb +++ b/spec/routing/short_uri_wp_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'routes for old issue uris', type: :request do +RSpec.describe 'routes for old issue uris', type: :request do # These are routing specs and should be moved to # spec/routing. # As redirect_to is not supported by routing specs they have diff --git a/spec/routing/status_routing_spec.rb b/spec/routing/status_routing_spec.rb index 271e65b83c9..1e718ac9295 100644 --- a/spec/routing/status_routing_spec.rb +++ b/spec/routing/status_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe StatusesController do +RSpec.describe StatusesController do describe 'index' do it { expect(get('/statuses')).to route_to(controller: 'statuses', action: 'index') } end diff --git a/spec/routing/types_spec.rb b/spec/routing/types_spec.rb index 911d811fc05..592f19a52a7 100644 --- a/spec/routing/types_spec.rb +++ b/spec/routing/types_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'types routes' do +RSpec.describe 'types routes' do it do expect(post('/types/move/123')).to route_to(controller: 'types', action: 'move', diff --git a/spec/routing/user_memberships_routing_spec.rb b/spec/routing/user_memberships_routing_spec.rb index 7a4d17115ab..64f7e87f03b 100644 --- a/spec/routing/user_memberships_routing_spec.rb +++ b/spec/routing/user_memberships_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Users::MembershipsController do +RSpec.describe Users::MembershipsController do describe 'routing' do it 'connects DELETE users/:user_id/memberships/:id' do expect(delete('/users/1/memberships/2')).to route_to(controller: 'users/memberships', diff --git a/spec/routing/users_routing_spec.rb b/spec/routing/users_routing_spec.rb index 08d4968b6e8..0e84c89c5a5 100644 --- a/spec/routing/users_routing_spec.rb +++ b/spec/routing/users_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe UsersController, 'routing' do +RSpec.describe UsersController, 'routing' do it { expect(subject).to route(:get, '/users').to(controller: 'users', action: 'index') diff --git a/spec/routing/versions_spec.rb b/spec/routing/versions_spec.rb index aacd4077b92..2fd92248d47 100644 --- a/spec/routing/versions_spec.rb +++ b/spec/routing/versions_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'versions routing' do +RSpec.describe 'versions routing' do it { expect(subject).to route(:get, '/versions/1').to(controller: 'versions', action: 'show', diff --git a/spec/routing/watchers_spec.rb b/spec/routing/watchers_spec.rb index 0e1b7ffafc7..f4477572e3a 100644 --- a/spec/routing/watchers_spec.rb +++ b/spec/routing/watchers_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WatchersController do +RSpec.describe WatchersController do shared_examples_for 'watched model routes' do before do expect(OpenProject::Acts::Watchable::Routes).to receive(:matches?).and_return(true) diff --git a/spec/routing/wiki_routing_spec.rb b/spec/routing/wiki_routing_spec.rb index fcb20cfb290..d1b77651fc4 100644 --- a/spec/routing/wiki_routing_spec.rb +++ b/spec/routing/wiki_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WikiController do +RSpec.describe WikiController do describe 'routing' do it { expect(subject).to route(:get, '/projects/567/wiki').to(controller: 'wiki', diff --git a/spec/routing/work_package/auto_completes_routing_spec.rb b/spec/routing/work_package/auto_completes_routing_spec.rb index 78b4fbacb75..b1571e6faf2 100644 --- a/spec/routing/work_package/auto_completes_routing_spec.rb +++ b/spec/routing/work_package/auto_completes_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::AutoCompletesController do +RSpec.describe WorkPackages::AutoCompletesController do it 'connects GET /work_packages/auto_completes to work_package/auto_complete#index' do expect(get('/work_packages/auto_complete')).to route_to(controller: 'work_packages/auto_completes', action: 'index') diff --git a/spec/routing/work_package/reports_routing_spec.rb b/spec/routing/work_package/reports_routing_spec.rb index b5750d577c5..cff29e1141f 100644 --- a/spec/routing/work_package/reports_routing_spec.rb +++ b/spec/routing/work_package/reports_routing_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackagesController do +RSpec.describe WorkPackagesController do it 'connects GET /project/1/work_packages/report to work_package/report#report' do expect(get('/projects/1/work_packages/report')).to route_to(controller: 'work_packages/reports', action: 'report', diff --git a/spec/routing/work_package_bulk_spec.rb b/spec/routing/work_package_bulk_spec.rb index fdeff54983c..12b8d301082 100644 --- a/spec/routing/work_package_bulk_spec.rb +++ b/spec/routing/work_package_bulk_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::BulkController do +RSpec.describe WorkPackages::BulkController do it 'connects GET /work_packages/bulk/edit to work_package_bulk/edit' do expect(get('/work_packages/bulk/edit')).to route_to(controller: 'work_packages/bulk', action: 'edit') diff --git a/spec/routing/work_packages_spec.rb b/spec/routing/work_packages_spec.rb index 75d890405bd..7230374f549 100644 --- a/spec/routing/work_packages_spec.rb +++ b/spec/routing/work_packages_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackagesController do +RSpec.describe WorkPackagesController do it 'connects GET /work_packages to work_packages#index' do expect(get('/work_packages')).to route_to(controller: 'work_packages', action: 'index') diff --git a/spec/routing/workflows_spec.rb b/spec/routing/workflows_spec.rb index a29098a5c8f..bbd927434a2 100644 --- a/spec/routing/workflows_spec.rb +++ b/spec/routing/workflows_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'workflows routes' do +RSpec.describe 'workflows routes' do it { expect(get('/workflows')).to route_to('workflows#show') } it { expect(get('/workflows/edit')).to route_to('workflows#edit') } diff --git a/spec/security/active_support_to_json_spec.rb b/spec/security/active_support_to_json_spec.rb index 994e85e3c36..3d658f077f2 100644 --- a/spec/security/active_support_to_json_spec.rb +++ b/spec/security/active_support_to_json_spec.rb @@ -36,7 +36,7 @@ require 'spec_helper' -describe ActiveSupport do +RSpec.describe ActiveSupport do active_support_default = ActiveSupport.escape_html_entities_in_json after do diff --git a/spec/seeders/demo_data/work_package_seeder_spec.rb b/spec/seeders/demo_data/work_package_seeder_spec.rb index 759437a0641..1851711357b 100644 --- a/spec/seeders/demo_data/work_package_seeder_spec.rb +++ b/spec/seeders/demo_data/work_package_seeder_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe DemoData::WorkPackageSeeder do +RSpec.describe DemoData::WorkPackageSeeder do shared_let(:work_week) { week_with_saturday_and_sunday_as_weekend } shared_let(:seeding) do [ diff --git a/spec/seeders/root_seeder_standard_edition_spec.rb b/spec/seeders/root_seeder_standard_edition_spec.rb index d389b26ac16..9e857a52465 100644 --- a/spec/seeders/root_seeder_standard_edition_spec.rb +++ b/spec/seeders/root_seeder_standard_edition_spec.rb @@ -29,9 +29,9 @@ require 'spec_helper' require_relative './root_seeder_shared_examples' -describe RootSeeder, - 'standard edition', - with_config: { edition: 'standard' } do +RSpec.describe RootSeeder, + 'standard edition', + with_config: { edition: 'standard' } do include RootSeederTestHelpers shared_examples 'creates standard demo data' do diff --git a/spec/seeders/setting_seeder_spec.rb b/spec/seeders/setting_seeder_spec.rb index 0037471d4ed..1d71b4b2583 100644 --- a/spec/seeders/setting_seeder_spec.rb +++ b/spec/seeders/setting_seeder_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe BasicData::SettingSeeder do +RSpec.describe BasicData::SettingSeeder do subject { described_class.new } let(:new_project_role) { Role.find_by(name: I18n.t(:default_role_project_admin)) } diff --git a/spec/services/add_work_package_note_service_spec.rb b/spec/services/add_work_package_note_service_spec.rb index cde979b2d71..2a20eabd4b8 100644 --- a/spec/services/add_work_package_note_service_spec.rb +++ b/spec/services/add_work_package_note_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe AddWorkPackageNoteService, type: :model do +RSpec.describe AddWorkPackageNoteService, type: :model do let(:user) { build_stubbed(:user) } let(:work_package) { build_stubbed(:work_package) } let(:instance) do diff --git a/spec/services/api/parser_struct_spec.rb b/spec/services/api/parser_struct_spec.rb index 25535565784..f42a9cff04f 100644 --- a/spec/services/api/parser_struct_spec.rb +++ b/spec/services/api/parser_struct_spec.rb @@ -26,7 +26,7 @@ require 'spec_helper' -describe API::ParserStruct do +RSpec.describe API::ParserStruct do let(:instance) { described_class.new } describe 'assigning a value and method creation' do diff --git a/spec/services/api/v3/parse_query_params_service_spec.rb b/spec/services/api/v3/parse_query_params_service_spec.rb index 73201b71e9b..cf3f85aa36a 100644 --- a/spec/services/api/v3/parse_query_params_service_spec.rb +++ b/spec/services/api/v3/parse_query_params_service_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe API::V3::ParseQueryParamsService, - type: :model do +RSpec.describe API::V3::ParseQueryParamsService, + type: :model do let(:instance) { described_class.new } let(:params) { {} } diff --git a/spec/services/api/v3/update_query_from_v3_params_service_spec.rb b/spec/services/api/v3/update_query_from_v3_params_service_spec.rb index 906d4d9e605..f72546b6c53 100644 --- a/spec/services/api/v3/update_query_from_v3_params_service_spec.rb +++ b/spec/services/api/v3/update_query_from_v3_params_service_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe API::V3::UpdateQueryFromV3ParamsService, - type: :model do +RSpec.describe API::V3::UpdateQueryFromV3ParamsService, + type: :model do let(:user) { build_stubbed(:user) } let(:query) { build_stubbed(:query) } diff --git a/spec/services/api/v3/work_package_collection_from_query_params_service_spec.rb b/spec/services/api/v3/work_package_collection_from_query_params_service_spec.rb index 9650e8cdab4..762ba2a3adc 100644 --- a/spec/services/api/v3/work_package_collection_from_query_params_service_spec.rb +++ b/spec/services/api/v3/work_package_collection_from_query_params_service_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe API::V3::WorkPackageCollectionFromQueryParamsService, - type: :model do +RSpec.describe API::V3::WorkPackageCollectionFromQueryParamsService, + type: :model do include API::V3::Utilities::PathHelper let(:mock_wp_collection_from_query_service) do diff --git a/spec/services/api/v3/work_package_collection_from_query_service_spec.rb b/spec/services/api/v3/work_package_collection_from_query_service_spec.rb index 2149e30e3f8..0188a8f6fd7 100644 --- a/spec/services/api/v3/work_package_collection_from_query_service_spec.rb +++ b/spec/services/api/v3/work_package_collection_from_query_service_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe API::V3::WorkPackageCollectionFromQueryService, - type: :model do +RSpec.describe API::V3::WorkPackageCollectionFromQueryService, + type: :model do include API::V3::Utilities::PathHelper let(:query) do diff --git a/spec/services/attachments/create_service_integration_spec.rb b/spec/services/attachments/create_service_integration_spec.rb index c8b57eda2e4..eb9b54b58db 100644 --- a/spec/services/attachments/create_service_integration_spec.rb +++ b/spec/services/attachments/create_service_integration_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe Attachments::CreateService, 'integration', with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe Attachments::CreateService, 'integration', with_settings: { journal_aggregation_time_minutes: 0 } do let(:description) { 'a fancy description' } subject { described_class.new(user:) } diff --git a/spec/services/attachments/delete_service_integration_spec.rb b/spec/services/attachments/delete_service_integration_spec.rb index cf6a7753019..7cb2df58c33 100644 --- a/spec/services/attachments/delete_service_integration_spec.rb +++ b/spec/services/attachments/delete_service_integration_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe Attachments::DeleteService, 'integration', with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe Attachments::DeleteService, 'integration', with_settings: { journal_aggregation_time_minutes: 0 } do subject(:call) { described_class.new(model: attachment, user:).call } let(:user) do diff --git a/spec/services/attachments/prepare_upload_service_integration_spec.rb b/spec/services/attachments/prepare_upload_service_integration_spec.rb index 9c6d3f504a1..3a67a8f563e 100644 --- a/spec/services/attachments/prepare_upload_service_integration_spec.rb +++ b/spec/services/attachments/prepare_upload_service_integration_spec.rb @@ -27,8 +27,8 @@ require 'spec_helper' -describe Attachments::PrepareUploadService, - 'integration' do +RSpec.describe Attachments::PrepareUploadService, + 'integration' do shared_let(:container) { create(:work_package) } shared_let(:user) do create(:user, diff --git a/spec/services/authentication/omniauth_service_spec.rb b/spec/services/authentication/omniauth_service_spec.rb index 2c1780136f5..1e42dbefd07 100644 --- a/spec/services/authentication/omniauth_service_spec.rb +++ b/spec/services/authentication/omniauth_service_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe Authentication::OmniauthService do +RSpec.describe Authentication::OmniauthService do let(:strategy) { double('Omniauth Strategy', name: 'saml') } let(:auth_hash) do OmniAuth::AuthHash.new( diff --git a/spec/services/authorization/enterprise_service_spec.rb b/spec/services/authorization/enterprise_service_spec.rb index d17026afc57..1b345e14c89 100644 --- a/spec/services/authorization/enterprise_service_spec.rb +++ b/spec/services/authorization/enterprise_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Authorization::EnterpriseService do +RSpec.describe Authorization::EnterpriseService do let(:token_object) do token = OpenProject::Token.new token.subscriber = 'Foobar' diff --git a/spec/services/authorization/query_transformation_spec.rb b/spec/services/authorization/query_transformation_spec.rb index 501041e8d86..e5231c62294 100644 --- a/spec/services/authorization/query_transformation_spec.rb +++ b/spec/services/authorization/query_transformation_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Authorization::QueryTransformation do +RSpec.describe Authorization::QueryTransformation do let(:on) { 'on' } let(:name) { 'name' } let(:after) { 'after' } diff --git a/spec/services/authorization/query_transformations_spec.rb b/spec/services/authorization/query_transformations_spec.rb index bd0ed3484e9..ce7e467e578 100644 --- a/spec/services/authorization/query_transformations_spec.rb +++ b/spec/services/authorization/query_transformations_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Authorization::QueryTransformations do +RSpec.describe Authorization::QueryTransformations do let(:instance) { described_class.new } context 'registering a transformation' do diff --git a/spec/services/authorization/user_allowed_query_spec.rb b/spec/services/authorization/user_allowed_query_spec.rb index 851b2819fb4..5cde29ef243 100644 --- a/spec/services/authorization/user_allowed_query_spec.rb +++ b/spec/services/authorization/user_allowed_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Authorization::UserAllowedQuery do +RSpec.describe Authorization::UserAllowedQuery do describe '.query' do let(:user) { member.principal } let(:anonymous) { build(:anonymous) } diff --git a/spec/services/authorization/user_allowed_service_spec.rb b/spec/services/authorization/user_allowed_service_spec.rb index a832c7f9558..196d9af14b1 100644 --- a/spec/services/authorization/user_allowed_service_spec.rb +++ b/spec/services/authorization/user_allowed_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Authorization::UserAllowedService do +RSpec.describe Authorization::UserAllowedService do let(:user) { build_stubbed(:user) } let(:instance) { described_class.new(user) } let(:action) { :an_action } diff --git a/spec/services/authorization/user_global_roles_query_spec.rb b/spec/services/authorization/user_global_roles_query_spec.rb index 03de3b7af97..35bed0f89e0 100644 --- a/spec/services/authorization/user_global_roles_query_spec.rb +++ b/spec/services/authorization/user_global_roles_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Authorization::UserGlobalRolesQuery do +RSpec.describe Authorization::UserGlobalRolesQuery do let(:user) { build(:user) } let(:anonymous) { build(:anonymous) } let(:project) { build(:project, public: false) } diff --git a/spec/services/authorization/user_project_roles_query_spec.rb b/spec/services/authorization/user_project_roles_query_spec.rb index 30e9c5e22cc..8ba6b889d8e 100644 --- a/spec/services/authorization/user_project_roles_query_spec.rb +++ b/spec/services/authorization/user_project_roles_query_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Authorization::UserProjectRolesQuery do +RSpec.describe Authorization::UserProjectRolesQuery do let(:user) { build(:user) } let(:anonymous) { build(:anonymous) } let(:project) { build(:project, public: false) } diff --git a/spec/services/backups/create_service_spec.rb b/spec/services/backups/create_service_spec.rb index 063810d2b31..3d1ea10eb2a 100644 --- a/spec/services/backups/create_service_spec.rb +++ b/spec/services/backups/create_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Backups::CreateService, type: :model do +RSpec.describe Backups::CreateService, type: :model do let(:user) { create(:admin) } let(:service) { described_class.new user:, backup_token: backup_token.plain_value } let(:backup_token) { create(:backup_token, user:) } diff --git a/spec/services/base/base_callable_spec.rb b/spec/services/base/base_callable_spec.rb index 61d37717f0e..586e1c681c6 100644 --- a/spec/services/base/base_callable_spec.rb +++ b/spec/services/base/base_callable_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe BaseServices::BaseCallable, type: :model do +RSpec.describe BaseServices::BaseCallable, type: :model do let(:test_service) do Class.new(BaseServices::BaseCallable) do def perform(*) diff --git a/spec/services/base_services/behaves_like_create_service.rb b/spec/services/base_services/behaves_like_create_service.rb index 35dbf0c4f3d..669107dd6fb 100644 --- a/spec/services/base_services/behaves_like_create_service.rb +++ b/spec/services/base_services/behaves_like_create_service.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples 'BaseServices create service' do +RSpec.shared_examples 'BaseServices create service' do let(:service_class) { described_class } let(:namespace) { service_class.to_s.deconstantize } let(:model_class) { namespace.singularize.constantize } diff --git a/spec/services/base_services/behaves_like_delete_service.rb b/spec/services/base_services/behaves_like_delete_service.rb index 4c8044822a3..fa2b76daba6 100644 --- a/spec/services/base_services/behaves_like_delete_service.rb +++ b/spec/services/base_services/behaves_like_delete_service.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples 'BaseServices delete service' do +RSpec.shared_examples 'BaseServices delete service' do subject(:service_call) { instance.call(call_attributes) } let(:service_class) { described_class } diff --git a/spec/services/base_services/behaves_like_update_service.rb b/spec/services/base_services/behaves_like_update_service.rb index d84b3281068..5bf0c681eaf 100644 --- a/spec/services/base_services/behaves_like_update_service.rb +++ b/spec/services/base_services/behaves_like_update_service.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples 'BaseServices update service' do +RSpec.shared_examples 'BaseServices update service' do let(:service_class) { described_class } let(:namespace) { service_class.to_s.deconstantize } let(:model_class) { namespace.singularize.constantize } diff --git a/spec/services/create_type_service_spec.rb b/spec/services/create_type_service_spec.rb index bf0e2aee6cb..e97230b2b75 100644 --- a/spec/services/create_type_service_spec.rb +++ b/spec/services/create_type_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/shared_type_service' -describe CreateTypeService do +RSpec.describe CreateTypeService do let(:type) { instance.type } let(:user) { build_stubbed(:admin) } diff --git a/spec/services/custom_actions/update_service_spec.rb b/spec/services/custom_actions/update_service_spec.rb index 30a8626b4aa..f7ed90cb563 100644 --- a/spec/services/custom_actions/update_service_spec.rb +++ b/spec/services/custom_actions/update_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomActions::UpdateService do +RSpec.describe CustomActions::UpdateService do let(:action) do action = build_stubbed(:custom_action) diff --git a/spec/services/custom_actions/update_work_package_service_spec.rb b/spec/services/custom_actions/update_work_package_service_spec.rb index 324e6983dec..0fc6d066288 100644 --- a/spec/services/custom_actions/update_work_package_service_spec.rb +++ b/spec/services/custom_actions/update_work_package_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomActions::UpdateWorkPackageService do +RSpec.describe CustomActions::UpdateWorkPackageService do let(:custom_action) do action = build_stubbed(:custom_action) diff --git a/spec/services/custom_fields/create_service_spec.rb b/spec/services/custom_fields/create_service_spec.rb index 0c83ec26400..e7688e0dd6e 100644 --- a/spec/services/custom_fields/create_service_spec.rb +++ b/spec/services/custom_fields/create_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe CustomFields::CreateService, type: :model do +RSpec.describe CustomFields::CreateService, type: :model do it_behaves_like 'BaseServices create service' do context 'when creating a project cf' do let(:model_instance) { build_stubbed(:project_custom_field) } diff --git a/spec/services/custom_fields/set_attributes_service_spec.rb b/spec/services/custom_fields/set_attributes_service_spec.rb index d4fef1846c4..b3bce4ad2ee 100644 --- a/spec/services/custom_fields/set_attributes_service_spec.rb +++ b/spec/services/custom_fields/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CustomFields::SetAttributesService, type: :model do +RSpec.describe CustomFields::SetAttributesService, type: :model do let(:user) { build_stubbed(:user) } let(:contract_instance) do contract = double('contract_instance') diff --git a/spec/services/custom_fields/update_service_spec.rb b/spec/services/custom_fields/update_service_spec.rb index 6b728065ada..a8e26d7f79c 100644 --- a/spec/services/custom_fields/update_service_spec.rb +++ b/spec/services/custom_fields/update_service_spec.rb @@ -29,6 +29,6 @@ require 'spec_helper' require 'services/base_services/behaves_like_update_service' -describe CustomFields::UpdateService, type: :model do +RSpec.describe CustomFields::UpdateService, type: :model do it_behaves_like 'BaseServices update service' end diff --git a/spec/services/groups/add_users_service_integration_spec.rb b/spec/services/groups/add_users_service_integration_spec.rb index fbcdf097309..25d368d716f 100644 --- a/spec/services/groups/add_users_service_integration_spec.rb +++ b/spec/services/groups/add_users_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Groups::AddUsersService, 'integration' do +RSpec.describe Groups::AddUsersService, 'integration' do subject(:service_call) { instance.call(ids: user_ids, message:) } let(:projects) { create_list(:project, 2) } diff --git a/spec/services/groups/cleanup_inherited_roles_service_integration_spec.rb b/spec/services/groups/cleanup_inherited_roles_service_integration_spec.rb index 4a5e3548c43..d92938abea3 100644 --- a/spec/services/groups/cleanup_inherited_roles_service_integration_spec.rb +++ b/spec/services/groups/cleanup_inherited_roles_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Groups::CleanupInheritedRolesService, 'integration', type: :model do +RSpec.describe Groups::CleanupInheritedRolesService, 'integration', type: :model do subject(:service_call) do members.destroy_all instance.call(params) diff --git a/spec/services/groups/create_inherited_roles_service_integration_spec.rb b/spec/services/groups/create_inherited_roles_service_integration_spec.rb index f5b02fa4aa8..e390aaf0fd9 100644 --- a/spec/services/groups/create_inherited_roles_service_integration_spec.rb +++ b/spec/services/groups/create_inherited_roles_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Groups::CreateInheritedRolesService, 'integration' do +RSpec.describe Groups::CreateInheritedRolesService, 'integration' do # The setup for these specs are a bit weird. First, the group is set up with its users already # attached. Then, the memberships of the group are added afterwards. # That way, the inherited roles are not yet created which they would otherwise by the group factory. diff --git a/spec/services/groups/set_attributes_service_spec.rb b/spec/services/groups/set_attributes_service_spec.rb index 4758925eebb..1c5635acb34 100644 --- a/spec/services/groups/set_attributes_service_spec.rb +++ b/spec/services/groups/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Groups::SetAttributesService, type: :model do +RSpec.describe Groups::SetAttributesService, type: :model do subject(:service_call) { instance.call(call_attributes) } let(:user) { build_stubbed(:user) } diff --git a/spec/services/groups/update_roles_service_integration_spec.rb b/spec/services/groups/update_roles_service_integration_spec.rb index b7ed7ea74f4..e53778d7d96 100644 --- a/spec/services/groups/update_roles_service_integration_spec.rb +++ b/spec/services/groups/update_roles_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Groups::UpdateRolesService, 'integration', type: :model do +RSpec.describe Groups::UpdateRolesService, 'integration', type: :model do subject(:service_call) { instance.call(member:, message:, send_notifications:) } let(:project) { create(:project) } diff --git a/spec/services/groups/update_service_spec.rb b/spec/services/groups/update_service_spec.rb index 03380f496c1..1765465faf6 100644 --- a/spec/services/groups/update_service_spec.rb +++ b/spec/services/groups/update_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_update_service' -describe Groups::UpdateService, type: :model do +RSpec.describe Groups::UpdateService, type: :model do it_behaves_like 'BaseServices update service' do let(:add_service_result) do ServiceResult.success diff --git a/spec/services/ldap/import_user_list_service_integration_spec.rb b/spec/services/ldap/import_user_list_service_integration_spec.rb index b9fee81057f..4b14bbf07ef 100644 --- a/spec/services/ldap/import_user_list_service_integration_spec.rb +++ b/spec/services/ldap/import_user_list_service_integration_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Ldap::ImportUsersFromListService do +RSpec.describe Ldap::ImportUsersFromListService do include_context 'with temporary LDAP' subject do diff --git a/spec/services/ldap/import_users_from_filter_service_integration_spec.rb b/spec/services/ldap/import_users_from_filter_service_integration_spec.rb index ed27e938b2b..19b20b08033 100644 --- a/spec/services/ldap/import_users_from_filter_service_integration_spec.rb +++ b/spec/services/ldap/import_users_from_filter_service_integration_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Ldap::ImportUsersFromFilterService do +RSpec.describe Ldap::ImportUsersFromFilterService do include_context 'with temporary LDAP' subject do diff --git a/spec/services/ldap/synchronize_users_service_integration_spec.rb b/spec/services/ldap/synchronize_users_service_integration_spec.rb index 675bd043512..28bc517f47c 100644 --- a/spec/services/ldap/synchronize_users_service_integration_spec.rb +++ b/spec/services/ldap/synchronize_users_service_integration_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Ldap::SynchronizeUsersService do +RSpec.describe Ldap::SynchronizeUsersService do include_context 'with temporary LDAP' subject do diff --git a/spec/services/members/cleanup_service_integration_spec.rb b/spec/services/members/cleanup_service_integration_spec.rb index 576e2ae93c3..0f1e1fb7036 100644 --- a/spec/services/members/cleanup_service_integration_spec.rb +++ b/spec/services/members/cleanup_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Members::CleanupService, 'integration', type: :model do +RSpec.describe Members::CleanupService, 'integration', type: :model do subject(:service_call) { instance.call } let(:user) { create(:user) } diff --git a/spec/services/members/create_service_spec.rb b/spec/services/members/create_service_spec.rb index 338e7781dd0..c747a183cae 100644 --- a/spec/services/members/create_service_spec.rb +++ b/spec/services/members/create_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Members::CreateService, type: :model do +RSpec.describe Members::CreateService, type: :model do let(:user1) { build_stubbed(:user) } let(:user2) { build_stubbed(:user) } let(:group) do diff --git a/spec/services/members/delete_service_spec.rb b/spec/services/members/delete_service_spec.rb index b1d2e4807f7..3083deb33a8 100644 --- a/spec/services/members/delete_service_spec.rb +++ b/spec/services/members/delete_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_delete_service' -describe Members::DeleteService, type: :model do +RSpec.describe Members::DeleteService, type: :model do it_behaves_like 'BaseServices delete service' do let(:principal) { user } before do diff --git a/spec/services/members/set_attributes_service_spec.rb b/spec/services/members/set_attributes_service_spec.rb index d58fd35b5cc..494ad657ae6 100644 --- a/spec/services/members/set_attributes_service_spec.rb +++ b/spec/services/members/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Members::SetAttributesService, type: :model do +RSpec.describe Members::SetAttributesService, type: :model do let(:user) { build_stubbed(:user) } let(:contract_class) do contract = double('contract_class') diff --git a/spec/services/members/update_service_spec.rb b/spec/services/members/update_service_spec.rb index 26a8916284f..f84dabb6002 100644 --- a/spec/services/members/update_service_spec.rb +++ b/spec/services/members/update_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_update_service' -describe Members::UpdateService, type: :model do +RSpec.describe Members::UpdateService, type: :model do it_behaves_like 'BaseServices update service' do let(:call_attributes) do { diff --git a/spec/services/messages/create_service_spec.rb b/spec/services/messages/create_service_spec.rb index 0a693c1778e..bf51d27d0e0 100644 --- a/spec/services/messages/create_service_spec.rb +++ b/spec/services/messages/create_service_spec.rb @@ -29,6 +29,6 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Messages::CreateService, type: :model do +RSpec.describe Messages::CreateService, type: :model do it_behaves_like 'BaseServices create service' end diff --git a/spec/services/messages/set_attributes_service_spec.rb b/spec/services/messages/set_attributes_service_spec.rb index 759b831f900..84fb74ce45c 100644 --- a/spec/services/messages/set_attributes_service_spec.rb +++ b/spec/services/messages/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Messages::SetAttributesService, type: :model do +RSpec.describe Messages::SetAttributesService, type: :model do let(:user) { build_stubbed(:user) } let(:forum) { build_stubbed(:forum) } let(:contract_instance) do diff --git a/spec/services/messages/update_service_spec.rb b/spec/services/messages/update_service_spec.rb index d39721ca655..0a8bf0c4876 100644 --- a/spec/services/messages/update_service_spec.rb +++ b/spec/services/messages/update_service_spec.rb @@ -29,6 +29,6 @@ require 'spec_helper' require 'services/base_services/behaves_like_update_service' -describe Messages::UpdateService, type: :model do +RSpec.describe Messages::UpdateService, type: :model do it_behaves_like 'BaseServices update service' end diff --git a/spec/services/notifications/create_from_journal_job_shared.rb b/spec/services/notifications/create_from_journal_job_shared.rb index b177a1a55f6..af8795996de 100644 --- a/spec/services/notifications/create_from_journal_job_shared.rb +++ b/spec/services/notifications/create_from_journal_job_shared.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -shared_context 'with CreateFromJournalJob context' do +RSpec.shared_context 'with CreateFromJournalJob context' do shared_let(:project) { create(:project_with_types) } let(:permissions) { [] } let(:recipient) do diff --git a/spec/services/notifications/create_from_model_service_comment_spec.rb b/spec/services/notifications/create_from_model_service_comment_spec.rb index 3186c1097ff..97f8d169fb9 100644 --- a/spec/services/notifications/create_from_model_service_comment_spec.rb +++ b/spec/services/notifications/create_from_model_service_comment_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative './create_from_journal_job_shared' -describe Notifications::CreateFromModelService, 'comment', with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe Notifications::CreateFromModelService, 'comment', with_settings: { journal_aggregation_time_minutes: 0 } do subject(:call) do described_class.new(resource).call(send_notifications) end diff --git a/spec/services/notifications/create_from_model_service_message_spec.rb b/spec/services/notifications/create_from_model_service_message_spec.rb index d89291d6403..b1a3f768304 100644 --- a/spec/services/notifications/create_from_model_service_message_spec.rb +++ b/spec/services/notifications/create_from_model_service_message_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative './create_from_journal_job_shared' -describe Notifications::CreateFromModelService, 'message', with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe Notifications::CreateFromModelService, 'message', with_settings: { journal_aggregation_time_minutes: 0 } do subject(:call) do described_class.new(journal).call(send_notifications) end diff --git a/spec/services/notifications/create_from_model_service_news_spec.rb b/spec/services/notifications/create_from_model_service_news_spec.rb index 6a4d892c1f4..2a172bc27c7 100644 --- a/spec/services/notifications/create_from_model_service_news_spec.rb +++ b/spec/services/notifications/create_from_model_service_news_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative './create_from_journal_job_shared' -describe Notifications::CreateFromModelService, 'news', with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe Notifications::CreateFromModelService, 'news', with_settings: { journal_aggregation_time_minutes: 0 } do subject(:call) do described_class.new(journal).call(send_notifications) end diff --git a/spec/services/notifications/create_from_model_service_wiki_spec.rb b/spec/services/notifications/create_from_model_service_wiki_spec.rb index 2df7e462303..56047cef9a9 100644 --- a/spec/services/notifications/create_from_model_service_wiki_spec.rb +++ b/spec/services/notifications/create_from_model_service_wiki_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require_relative './create_from_journal_job_shared' -describe Notifications::CreateFromModelService, 'wiki', with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe Notifications::CreateFromModelService, 'wiki', with_settings: { journal_aggregation_time_minutes: 0 } do subject(:call) do described_class.new(journal).call(send_notifications) end diff --git a/spec/services/notifications/create_from_model_service_work_package_spec.rb b/spec/services/notifications/create_from_model_service_work_package_spec.rb index 4dc7b3e2f1f..4a48a3573a0 100644 --- a/spec/services/notifications/create_from_model_service_work_package_spec.rb +++ b/spec/services/notifications/create_from_model_service_work_package_spec.rb @@ -28,9 +28,9 @@ require 'spec_helper' require_relative './create_from_journal_job_shared' -describe Notifications::CreateFromModelService, - 'work_package', - with_settings: { journal_aggregation_time_minutes: 0 } do +RSpec.describe Notifications::CreateFromModelService, + 'work_package', + with_settings: { journal_aggregation_time_minutes: 0 } do subject(:call) do described_class.new(journal).call(send_notifications) end diff --git a/spec/services/notifications/create_service_intergration_spec.rb b/spec/services/notifications/create_service_intergration_spec.rb index 97a25eec988..e6e40c6091f 100644 --- a/spec/services/notifications/create_service_intergration_spec.rb +++ b/spec/services/notifications/create_service_intergration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Notifications::CreateService, 'integration', type: :model do +RSpec.describe Notifications::CreateService, 'integration', type: :model do let(:work_package) { create(:work_package) } let(:project) { work_package.project } let(:journal) { work_package.journals.first } diff --git a/spec/services/notifications/create_service_spec.rb b/spec/services/notifications/create_service_spec.rb index ee753126ba7..4f05336b6aa 100644 --- a/spec/services/notifications/create_service_spec.rb +++ b/spec/services/notifications/create_service_spec.rb @@ -29,6 +29,6 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Notifications::CreateService, type: :model do +RSpec.describe Notifications::CreateService, type: :model do it_behaves_like 'BaseServices create service' end diff --git a/spec/services/notifications/mail_service_mentioned_integration_spec.rb b/spec/services/notifications/mail_service_mentioned_integration_spec.rb index e7f0fed191c..cc1f8d0af5f 100644 --- a/spec/services/notifications/mail_service_mentioned_integration_spec.rb +++ b/spec/services/notifications/mail_service_mentioned_integration_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative './mentioned_journals_shared' -describe Notifications::MailService, 'Mentioned integration', type: :model do +RSpec.describe Notifications::MailService, 'Mentioned integration', type: :model do include_context 'with a mentioned work package being updated again' let(:assignee) do diff --git a/spec/services/notifications/mail_service_spec.rb b/spec/services/notifications/mail_service_spec.rb index 86630b9c09b..cf71c249a06 100644 --- a/spec/services/notifications/mail_service_spec.rb +++ b/spec/services/notifications/mail_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Notifications::MailService, type: :model do +RSpec.describe Notifications::MailService, type: :model do require_relative './mentioned_journals_shared' subject(:call) { instance.call } diff --git a/spec/services/notifications/mentioned_journals_shared.rb b/spec/services/notifications/mentioned_journals_shared.rb index 19e68455764..48ee301288f 100644 --- a/spec/services/notifications/mentioned_journals_shared.rb +++ b/spec/services/notifications/mentioned_journals_shared.rb @@ -27,7 +27,7 @@ #++ require 'spec_helper' -shared_context 'with a mentioned work package being updated again' do +RSpec.shared_context 'with a mentioned work package being updated again' do let(:project) { create(:project) } let(:work_package) do diff --git a/spec/services/notifications/set_attributes_service_spec.rb b/spec/services/notifications/set_attributes_service_spec.rb index 66d6a611fc6..0068fd67849 100644 --- a/spec/services/notifications/set_attributes_service_spec.rb +++ b/spec/services/notifications/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Notifications::SetAttributesService, type: :model do +RSpec.describe Notifications::SetAttributesService, type: :model do let(:user) { build_stubbed(:user) } let(:contract_class) do contract = double('contract_class') diff --git a/spec/services/oauth_clients/connection_manager_spec.rb b/spec/services/oauth_clients/connection_manager_spec.rb index 8e665d7c79e..df92a54f244 100644 --- a/spec/services/oauth_clients/connection_manager_spec.rb +++ b/spec/services/oauth_clients/connection_manager_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'webmock/rspec' -describe OAuthClients::ConnectionManager, type: :model do +RSpec.describe OAuthClients::ConnectionManager, type: :model do let(:user) { create(:user) } let(:host) { "https://example.org" } let(:provider_type) { Storages::Storage::PROVIDER_TYPE_NEXTCLOUD } diff --git a/spec/services/oauth_clients/create_service_spec.rb b/spec/services/oauth_clients/create_service_spec.rb index 0ab81ccb930..748127ab672 100644 --- a/spec/services/oauth_clients/create_service_spec.rb +++ b/spec/services/oauth_clients/create_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe OAuthClients::CreateService, type: :model do +RSpec.describe OAuthClients::CreateService, type: :model do it_behaves_like 'BaseServices create service' do let(:factory) { :oauth_client } diff --git a/spec/services/oauth_clients/delete_service_spec.rb b/spec/services/oauth_clients/delete_service_spec.rb index 8f0b18bce4a..957118b45f0 100644 --- a/spec/services/oauth_clients/delete_service_spec.rb +++ b/spec/services/oauth_clients/delete_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_delete_service' -describe OAuthClients::DeleteService, type: :model do +RSpec.describe OAuthClients::DeleteService, type: :model do it_behaves_like 'BaseServices delete service' do let(:factory) { :oauth_client } end diff --git a/spec/services/oauth_clients/redirect_uri_from_state_service_spec.rb b/spec/services/oauth_clients/redirect_uri_from_state_service_spec.rb index 6e1d0bc1da4..9323d81bb26 100644 --- a/spec/services/oauth_clients/redirect_uri_from_state_service_spec.rb +++ b/spec/services/oauth_clients/redirect_uri_from_state_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'webmock/rspec' -describe OAuthClients::RedirectUriFromStateService, type: :model do +RSpec.describe OAuthClients::RedirectUriFromStateService, type: :model do let(:state) { 'asdf123425' } let(:redirect_uri) { File.join(API::V3::Utilities::PathHelper::ApiV3Path::root_url, 'foo/bar') } let(:cookies) { { "oauth_state_#{state}": redirect_uri }.with_indifferent_access } diff --git a/spec/services/oauth_clients/set_attributes_service_spec.rb b/spec/services/oauth_clients/set_attributes_service_spec.rb index a60ac501690..84263517cf3 100644 --- a/spec/services/oauth_clients/set_attributes_service_spec.rb +++ b/spec/services/oauth_clients/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe OAuthClients::SetAttributesService, type: :model do +RSpec.describe OAuthClients::SetAttributesService, type: :model do let(:current_user) { build_stubbed(:admin) } let(:contract_instance) do diff --git a/spec/services/parse_schema_filter_params_service_spec.rb b/spec/services/parse_schema_filter_params_service_spec.rb index 39905dacc62..ba6963a46cc 100644 --- a/spec/services/parse_schema_filter_params_service_spec.rb +++ b/spec/services/parse_schema_filter_params_service_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe ParseSchemaFilterParamsService do +RSpec.describe ParseSchemaFilterParamsService do let(:current_user) { build_stubbed(:user) } let(:instance) { described_class.new(user: current_user) } let(:project) { build_stubbed(:project) } diff --git a/spec/services/placeholder_users/create_service_spec.rb b/spec/services/placeholder_users/create_service_spec.rb index 0b1052ccb75..3c2ee9457ac 100644 --- a/spec/services/placeholder_users/create_service_spec.rb +++ b/spec/services/placeholder_users/create_service_spec.rb @@ -29,6 +29,6 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe PlaceholderUsers::CreateService, type: :model do +RSpec.describe PlaceholderUsers::CreateService, type: :model do it_behaves_like 'BaseServices create service' end diff --git a/spec/services/placeholder_users/delete_service_spec.rb b/spec/services/placeholder_users/delete_service_spec.rb index 3aad91fede1..acd70f013b7 100644 --- a/spec/services/placeholder_users/delete_service_spec.rb +++ b/spec/services/placeholder_users/delete_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe PlaceholderUsers::DeleteService, type: :model do +RSpec.describe PlaceholderUsers::DeleteService, type: :model do let(:placeholder_user) { build_stubbed(:placeholder_user) } let(:project) { build_stubbed(:project) } diff --git a/spec/services/placeholder_users/set_attributes_service_spec.rb b/spec/services/placeholder_users/set_attributes_service_spec.rb index 2968abe9656..b5bedeae165 100644 --- a/spec/services/placeholder_users/set_attributes_service_spec.rb +++ b/spec/services/placeholder_users/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe PlaceholderUsers::SetAttributesService, type: :model do +RSpec.describe PlaceholderUsers::SetAttributesService, type: :model do let(:current_user) { build_stubbed(:user) } let(:contract_instance) do diff --git a/spec/services/placeholder_users/update_service_spec.rb b/spec/services/placeholder_users/update_service_spec.rb index db8e27fa94d..5b3601fc3ad 100644 --- a/spec/services/placeholder_users/update_service_spec.rb +++ b/spec/services/placeholder_users/update_service_spec.rb @@ -29,6 +29,6 @@ require 'spec_helper' require 'services/base_services/behaves_like_update_service' -describe PlaceholderUsers::UpdateService, type: :model do +RSpec.describe PlaceholderUsers::UpdateService, type: :model do it_behaves_like 'BaseServices update service' end diff --git a/spec/services/principals/replace_references_service_call_integration_spec.rb b/spec/services/principals/replace_references_service_call_integration_spec.rb index ef8fe88afee..a68a12232f7 100644 --- a/spec/services/principals/replace_references_service_call_integration_spec.rb +++ b/spec/services/principals/replace_references_service_call_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Principals::ReplaceReferencesService, '#call', type: :model do +RSpec.describe Principals::ReplaceReferencesService, '#call', type: :model do subject(:service_call) { instance.call(from: principal, to: to_principal) } shared_let(:other_user) { create(:user) } diff --git a/spec/services/projects/archive_service_spec.rb b/spec/services/projects/archive_service_spec.rb index 73c44ce8bab..0e09f5ec7f1 100644 --- a/spec/services/projects/archive_service_spec.rb +++ b/spec/services/projects/archive_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::ArchiveService do +RSpec.describe Projects::ArchiveService do let(:project) { create(:project) } let(:subproject1) { create(:project) } let(:subproject2) { create(:project) } diff --git a/spec/services/projects/copy_service_integration_spec.rb b/spec/services/projects/copy_service_integration_spec.rb index 5063b9f7e38..0c0715dadb3 100644 --- a/spec/services/projects/copy_service_integration_spec.rb +++ b/spec/services/projects/copy_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::CopyService, 'integration', type: :model, with_ee: %i[readonly_work_packages] do +RSpec.describe Projects::CopyService, 'integration', type: :model, with_ee: %i[readonly_work_packages] do shared_let(:status_locked) { create(:status, is_readonly: true) } shared_let(:source) { create(:project, enabled_module_names: %w[wiki work_package_tracking]) } shared_let(:source_wp) { create(:work_package, project: source, subject: 'source wp') } diff --git a/spec/services/projects/create_service_spec.rb b/spec/services/projects/create_service_spec.rb index a9e52221ec3..3d06bf979bc 100644 --- a/spec/services/projects/create_service_spec.rb +++ b/spec/services/projects/create_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Projects::CreateService, type: :model do +RSpec.describe Projects::CreateService, type: :model do it_behaves_like 'BaseServices create service' do let(:new_project_role) { build_stubbed(:role) } let(:create_member_instance) { instance_double(Members::CreateService) } diff --git a/spec/services/projects/delete_service_spec.rb b/spec/services/projects/delete_service_spec.rb index 31245adf2a3..d82af27b4ae 100644 --- a/spec/services/projects/delete_service_spec.rb +++ b/spec/services/projects/delete_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::DeleteService, type: :model do +RSpec.describe Projects::DeleteService, type: :model do shared_let(:user) { create(:admin) } let(:project) { create(:project) } diff --git a/spec/services/projects/gantt_query_generator_service_spec.rb b/spec/services/projects/gantt_query_generator_service_spec.rb index 3bf9204c5cf..0847fca57e9 100644 --- a/spec/services/projects/gantt_query_generator_service_spec.rb +++ b/spec/services/projects/gantt_query_generator_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::GanttQueryGeneratorService, type: :model do +RSpec.describe Projects::GanttQueryGeneratorService, type: :model do let(:selected) { %w[1 2 3] } let(:instance) { described_class.new selected } let(:subject) { instance.call } diff --git a/spec/services/projects/schedule_deletion_service_spec.rb b/spec/services/projects/schedule_deletion_service_spec.rb index 8c98da89c0d..f12d2728d87 100644 --- a/spec/services/projects/schedule_deletion_service_spec.rb +++ b/spec/services/projects/schedule_deletion_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::ScheduleDeletionService, type: :model do +RSpec.describe Projects::ScheduleDeletionService, type: :model do let(:contract_class) do contract = double('contract_class', '<=': true) diff --git a/spec/services/projects/set_attributes_service_integration_spec.rb b/spec/services/projects/set_attributes_service_integration_spec.rb index 3d3551bbbd0..76ea50c6451 100644 --- a/spec/services/projects/set_attributes_service_integration_spec.rb +++ b/spec/services/projects/set_attributes_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::SetAttributesService, 'integration', type: :model do +RSpec.describe Projects::SetAttributesService, 'integration', type: :model do let(:user) do create(:user, global_permissions: %w[add_project]) end diff --git a/spec/services/projects/set_attributes_service_spec.rb b/spec/services/projects/set_attributes_service_spec.rb index 7f243fadccd..91c43463d0a 100644 --- a/spec/services/projects/set_attributes_service_spec.rb +++ b/spec/services/projects/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::SetAttributesService, type: :model do +RSpec.describe Projects::SetAttributesService, type: :model do let(:user) { build_stubbed(:user) } let(:contract_class) do contract = class_double(Projects::CreateContract) diff --git a/spec/services/projects/update_service_integration_spec.rb b/spec/services/projects/update_service_integration_spec.rb index 3c82f40f3e7..4aa6ad66e08 100644 --- a/spec/services/projects/update_service_integration_spec.rb +++ b/spec/services/projects/update_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::UpdateService, 'integration', type: :model do +RSpec.describe Projects::UpdateService, 'integration', type: :model do let(:user) do create(:user, member_in_project: project, diff --git a/spec/services/projects/update_service_spec.rb b/spec/services/projects/update_service_spec.rb index 3992485d02f..23cd6b5ac05 100644 --- a/spec/services/projects/update_service_spec.rb +++ b/spec/services/projects/update_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_update_service' -describe Projects::UpdateService, type: :model do +RSpec.describe Projects::UpdateService, type: :model do it_behaves_like 'BaseServices update service' do let!(:model_instance) do build_stubbed(:project, :with_status) diff --git a/spec/services/queries/create_service_spec.rb b/spec/services/queries/create_service_spec.rb index 1e6a559f710..591792a9b1c 100644 --- a/spec/services/queries/create_service_spec.rb +++ b/spec/services/queries/create_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::CreateService do +RSpec.describe Queries::CreateService do let(:user) { build_stubbed(:admin) } let(:instance) { described_class.new(user:) } diff --git a/spec/services/queries/filter_mappper_spec.rb b/spec/services/queries/filter_mappper_spec.rb index 14eb23bb87a..c57a8b8a273 100644 --- a/spec/services/queries/filter_mappper_spec.rb +++ b/spec/services/queries/filter_mappper_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Queries::Copy::FiltersMapper do +RSpec.describe Queries::Copy::FiltersMapper do let(:state) { Shared::ServiceState.new } let(:instance) { described_class.new(state, filters) } diff --git a/spec/services/queries/update_from_params_service_spec.rb b/spec/services/queries/update_from_params_service_spec.rb index e1d7fc988ac..38c53e3c6cf 100644 --- a/spec/services/queries/update_from_params_service_spec.rb +++ b/spec/services/queries/update_from_params_service_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe UpdateQueryFromParamsService, - type: :model do +RSpec.describe UpdateQueryFromParamsService, + type: :model do let(:user) { build_stubbed(:user) } let(:query) { build_stubbed(:query) } diff --git a/spec/services/queries/update_service_spec.rb b/spec/services/queries/update_service_spec.rb index 60b9f64ad26..77270827717 100644 --- a/spec/services/queries/update_service_spec.rb +++ b/spec/services/queries/update_service_spec.rb @@ -29,6 +29,6 @@ require 'spec_helper' require 'services/base_services/behaves_like_update_service' -describe Queries::UpdateService do +RSpec.describe Queries::UpdateService do it_behaves_like 'BaseServices update service' end diff --git a/spec/services/relations/create_service_spec.rb b/spec/services/relations/create_service_spec.rb index c90d934ca88..af6557736fe 100644 --- a/spec/services/relations/create_service_spec.rb +++ b/spec/services/relations/create_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' # rubocop:disable RSpec:MultipleMemoizedHelpers -describe Relations::CreateService do +RSpec.describe Relations::CreateService do let(:work_package1_start_date) { nil } let(:work_package1_due_date) { Date.today } let(:work_package2_start_date) { nil } diff --git a/spec/services/relations/update_service_spec.rb b/spec/services/relations/update_service_spec.rb index 976e5729953..c1087fa2843 100644 --- a/spec/services/relations/update_service_spec.rb +++ b/spec/services/relations/update_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Relations::UpdateService do +RSpec.describe Relations::UpdateService do let(:work_package1_start_date) { nil } let(:work_package1_due_date) { Date.today } let(:work_package2_start_date) { nil } diff --git a/spec/services/scm/checkout_instructions_service_spec.rb b/spec/services/scm/checkout_instructions_service_spec.rb index f28bfb1743e..210756d1413 100644 --- a/spec/services/scm/checkout_instructions_service_spec.rb +++ b/spec/services/scm/checkout_instructions_service_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe SCM::CheckoutInstructionsService do +RSpec.describe SCM::CheckoutInstructionsService do let(:user) { build(:user) } let(:project) { build(:project) } diff --git a/spec/services/scm/create_managed_repository_service_spec.rb b/spec/services/scm/create_managed_repository_service_spec.rb index e11eecae295..e8f710960c6 100644 --- a/spec/services/scm/create_managed_repository_service_spec.rb +++ b/spec/services/scm/create_managed_repository_service_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe SCM::CreateManagedRepositoryService do +RSpec.describe SCM::CreateManagedRepositoryService do let(:user) { build(:user) } let(:config) { {} } let(:project) { build(:project) } diff --git a/spec/services/scm/delete_managed_repository_service_spec.rb b/spec/services/scm/delete_managed_repository_service_spec.rb index 328ae6dc4d8..0963bf51e9f 100644 --- a/spec/services/scm/delete_managed_repository_service_spec.rb +++ b/spec/services/scm/delete_managed_repository_service_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe SCM::DeleteManagedRepositoryService do +RSpec.describe SCM::DeleteManagedRepositoryService do let(:user) { build(:user) } let(:config) { {} } let(:project) { build(:project) } diff --git a/spec/services/scm/repository_factory_service_spec.rb b/spec/services/scm/repository_factory_service_spec.rb index 5d89172f2da..307be034f84 100644 --- a/spec/services/scm/repository_factory_service_spec.rb +++ b/spec/services/scm/repository_factory_service_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe SCM::RepositoryFactoryService do +RSpec.describe SCM::RepositoryFactoryService do let(:user) { build(:user) } let(:project) { build(:project) } diff --git a/spec/services/service_result_spec.rb b/spec/services/service_result_spec.rb index 01c1190d8e7..7bfdeeb0ff3 100644 --- a/spec/services/service_result_spec.rb +++ b/spec/services/service_result_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ServiceResult, type: :model do +RSpec.describe ServiceResult, type: :model do let(:instance) { described_class.new } describe 'success' do diff --git a/spec/services/services/create_service_spec.rb b/spec/services/services/create_service_spec.rb index e3041aec924..d7bb8cf6c25 100644 --- a/spec/services/services/create_service_spec.rb +++ b/spec/services/services/create_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Views::CreateService, type: :model do +RSpec.describe Views::CreateService, type: :model do it_behaves_like 'BaseServices create service' do let(:call_attributes) do { diff --git a/spec/services/set_localization_service_spec.rb b/spec/services/set_localization_service_spec.rb index af5f62c4431..5309ae92b41 100644 --- a/spec/services/set_localization_service_spec.rb +++ b/spec/services/set_localization_service_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe SetLocalizationService do +RSpec.describe SetLocalizationService do let(:user) { build_stubbed(:user, language: user_language) } let(:http_accept_header) { "#{http_accept_language},en-US;q=0.8,en;q=0.6" } let(:instance) { described_class.new(user, http_accept_header) } diff --git a/spec/services/settings/update_service_spec.rb b/spec/services/settings/update_service_spec.rb index a8ac563a104..f1d70bf19d7 100644 --- a/spec/services/settings/update_service_spec.rb +++ b/spec/services/settings/update_service_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' require_relative 'shared/shared_call_examples' -describe Settings::UpdateService do +RSpec.describe Settings::UpdateService do let(:instance) do described_class.new(user:) end diff --git a/spec/services/settings/working_days_update_service_spec.rb b/spec/services/settings/working_days_update_service_spec.rb index 51f14e0eea2..7e0a6bfba6c 100644 --- a/spec/services/settings/working_days_update_service_spec.rb +++ b/spec/services/settings/working_days_update_service_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' require_relative 'shared/shared_call_examples' -describe Settings::WorkingDaysUpdateService do +RSpec.describe Settings::WorkingDaysUpdateService do let(:instance) do described_class.new(user:) end diff --git a/spec/services/shared/service_context_integration_spec.rb b/spec/services/shared/service_context_integration_spec.rb index 3127af96ee5..94b4b81fa02 100644 --- a/spec/services/shared/service_context_integration_spec.rb +++ b/spec/services/shared/service_context_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Shared::ServiceContext, 'integration', type: :model do +RSpec.describe Shared::ServiceContext, 'integration', type: :model do let(:user) { build_stubbed(:user) } let(:instance) do diff --git a/spec/services/shared_type_service.rb b/spec/services/shared_type_service.rb index fa49dfefcb7..1481355cf53 100644 --- a/spec/services/shared_type_service.rb +++ b/spec/services/shared_type_service.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_context 'with custom field params' do +RSpec.shared_context 'with custom field params' do let(:cf1) { create(:work_package_custom_field, field_format: 'text') } let(:cf2) { create(:work_package_custom_field, field_format: 'text') } let!(:cf3) { create(:work_package_custom_field, field_format: 'text') } @@ -47,7 +47,7 @@ shared_context 'with custom field params' do let(:params) { attribute_groups } end -shared_examples_for 'type service' do +RSpec.shared_examples_for 'type service' do let(:success) { true } let(:params) { {} } let!(:contract) do diff --git a/spec/services/update_projects_types_service_spec.rb b/spec/services/update_projects_types_service_spec.rb index 3f732570611..2ef479a6786 100644 --- a/spec/services/update_projects_types_service_spec.rb +++ b/spec/services/update_projects_types_service_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe UpdateProjectsTypesService do +RSpec.describe UpdateProjectsTypesService do let(:project) { instance_double(Project, types_used_by_work_packages: []) } let(:standard_type) { build_stubbed(:type_standard) } diff --git a/spec/services/update_query_from_params_service_spec.rb b/spec/services/update_query_from_params_service_spec.rb index 25fe4e1934e..16444654bf6 100644 --- a/spec/services/update_query_from_params_service_spec.rb +++ b/spec/services/update_query_from_params_service_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe UpdateQueryFromParamsService, - type: :model do +RSpec.describe UpdateQueryFromParamsService, + type: :model do let(:user) { build_stubbed(:user) } let(:query) { build_stubbed(:query) } diff --git a/spec/services/update_type_service_spec.rb b/spec/services/update_type_service_spec.rb index c873c56bb93..54794f9416b 100644 --- a/spec/services/update_type_service_spec.rb +++ b/spec/services/update_type_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/shared_type_service' -describe UpdateTypeService do +RSpec.describe UpdateTypeService do let(:type) { create(:type) } let(:user) { build_stubbed(:admin) } diff --git a/spec/services/user_preferences/update_service_integration_spec.rb b/spec/services/user_preferences/update_service_integration_spec.rb index a1b18b3220f..920346cce6b 100644 --- a/spec/services/user_preferences/update_service_integration_spec.rb +++ b/spec/services/user_preferences/update_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe UserPreferences::UpdateService, 'integration', type: :model do +RSpec.describe UserPreferences::UpdateService, 'integration', type: :model do shared_let(:current_user) do create(:user).tap do |u| u.pref.save diff --git a/spec/services/user_preferences/update_service_spec.rb b/spec/services/user_preferences/update_service_spec.rb index 401e6a93e37..cca59f8bff1 100644 --- a/spec/services/user_preferences/update_service_spec.rb +++ b/spec/services/user_preferences/update_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_update_service' -describe UserPreferences::UpdateService, type: :model do +RSpec.describe UserPreferences::UpdateService, type: :model do it_behaves_like 'BaseServices update service' do let(:params_success) { true } let(:params_errors) { ActiveModel::Errors.new({}) } diff --git a/spec/services/users/change_password_service_spec.rb b/spec/services/users/change_password_service_spec.rb index edf2c2f7921..cf5a8889cfd 100644 --- a/spec/services/users/change_password_service_spec.rb +++ b/spec/services/users/change_password_service_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe Users::ChangePasswordService do +RSpec.describe Users::ChangePasswordService do let(:user) { create(:user, password: old_password, password_confirmation: old_password) } let(:old_password) { 'AdminAdmin42' } let(:new_password) { 'SoreThroat33' } diff --git a/spec/services/users/create_service_spec.rb b/spec/services/users/create_service_spec.rb index 4dac20aee33..f9da69a8a21 100644 --- a/spec/services/users/create_service_spec.rb +++ b/spec/services/users/create_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_create_service' -describe Users::CreateService do +RSpec.describe Users::CreateService do it_behaves_like 'BaseServices create service' do context 'when the user being invited' do let(:model_instance) { build(:invited_user) } diff --git a/spec/services/users/delete_service_integration_spec.rb b/spec/services/users/delete_service_integration_spec.rb index 60c1160a150..5f299e16d5f 100644 --- a/spec/services/users/delete_service_integration_spec.rb +++ b/spec/services/users/delete_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Users::DeleteService, 'Integration', type: :model do +RSpec.describe Users::DeleteService, 'Integration', type: :model do let(:input_user) { create(:user) } let(:actor) { build_stubbed(:admin) } diff --git a/spec/services/users/delete_service_spec.rb b/spec/services/users/delete_service_spec.rb index a52f4fdbd40..16d36360ba6 100644 --- a/spec/services/users/delete_service_spec.rb +++ b/spec/services/users/delete_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Users::DeleteService, type: :model do +RSpec.describe Users::DeleteService, type: :model do let(:input_user) { build_stubbed(:user) } let(:project) { build_stubbed(:project) } diff --git a/spec/services/users/login_service_spec.rb b/spec/services/users/login_service_spec.rb index add514167b6..13e4b7b7649 100644 --- a/spec/services/users/login_service_spec.rb +++ b/spec/services/users/login_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Users::LoginService, type: :model do +RSpec.describe Users::LoginService, type: :model do let(:input_user) { build_stubbed(:user) } let(:controller) { double('ApplicationController') } let(:request) { {} } diff --git a/spec/services/users/register_user_service_spec.rb b/spec/services/users/register_user_service_spec.rb index a5b0cbdc592..796f016884a 100644 --- a/spec/services/users/register_user_service_spec.rb +++ b/spec/services/users/register_user_service_spec.rb @@ -27,7 +27,7 @@ require 'spec_helper' -describe Users::RegisterUserService do +RSpec.describe Users::RegisterUserService do let(:user) { build(:user) } let(:instance) { described_class.new(user) } let(:call) { instance.call } diff --git a/spec/services/users/replace_mentions_service_integration_spec.rb b/spec/services/users/replace_mentions_service_integration_spec.rb index 0509126be07..1cd4cb084f5 100644 --- a/spec/services/users/replace_mentions_service_integration_spec.rb +++ b/spec/services/users/replace_mentions_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Users::ReplaceMentionsService, 'integration' do +RSpec.describe Users::ReplaceMentionsService, 'integration' do subject(:service_call) { instance.call(from: principal, to: to_user) } shared_let(:other_user) { create(:user, firstname: 'Frank', lastname: 'Herbert') } diff --git a/spec/services/users/set_attributes_service_integration_spec.rb b/spec/services/users/set_attributes_service_integration_spec.rb index 5b9b26a9912..323b7c8d299 100644 --- a/spec/services/users/set_attributes_service_integration_spec.rb +++ b/spec/services/users/set_attributes_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Users::SetAttributesService, 'Integration', type: :model do +RSpec.describe Users::SetAttributesService, 'Integration', type: :model do let(:input_user) { create(:user) } let(:actor) { build_stubbed(:admin) } diff --git a/spec/services/users/set_attributes_service_spec.rb b/spec/services/users/set_attributes_service_spec.rb index 96d312887e2..bec58e765bc 100644 --- a/spec/services/users/set_attributes_service_spec.rb +++ b/spec/services/users/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Users::SetAttributesService, type: :model do +RSpec.describe Users::SetAttributesService, type: :model do subject(:call) { instance.call(params) } let(:current_user) { build_stubbed(:user) } diff --git a/spec/services/users/update_service_spec.rb b/spec/services/users/update_service_spec.rb index f56d794c8fa..edfe87acf2c 100644 --- a/spec/services/users/update_service_spec.rb +++ b/spec/services/users/update_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_update_service' -describe Users::UpdateService do +RSpec.describe Users::UpdateService do it_behaves_like 'BaseServices update service' do # The user service also tries to save the preferences before do diff --git a/spec/services/wiki_pages/copy_service_integration_spec.rb b/spec/services/wiki_pages/copy_service_integration_spec.rb index 81eacac6e07..4e27b20c821 100644 --- a/spec/services/wiki_pages/copy_service_integration_spec.rb +++ b/spec/services/wiki_pages/copy_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WikiPages::CopyService, 'integration', type: :model do +RSpec.describe WikiPages::CopyService, 'integration', type: :model do let(:user) do create(:user) do |user| create(:member, diff --git a/spec/services/wiki_pages/set_attributes_service_spec.rb b/spec/services/wiki_pages/set_attributes_service_spec.rb index 7f4bb220d1e..068ecd71828 100644 --- a/spec/services/wiki_pages/set_attributes_service_spec.rb +++ b/spec/services/wiki_pages/set_attributes_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WikiPages::SetAttributesService, type: :model do +RSpec.describe WikiPages::SetAttributesService, type: :model do let(:user) { build_stubbed(:user) } let(:contract_class) do contract = double('contract_class') diff --git a/spec/services/work_packages/copy_service_integration_spec.rb b/spec/services/work_packages/copy_service_integration_spec.rb index 3975dfdac61..a1fc0a45c2d 100644 --- a/spec/services/work_packages/copy_service_integration_spec.rb +++ b/spec/services/work_packages/copy_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::CopyService, 'integration', type: :model do +RSpec.describe WorkPackages::CopyService, 'integration', type: :model do let(:user) do create(:user, member_in_project: project, diff --git a/spec/services/work_packages/create_service_integration_spec.rb b/spec/services/work_packages/create_service_integration_spec.rb index 3c49da28a3a..179e68584cd 100644 --- a/spec/services/work_packages/create_service_integration_spec.rb +++ b/spec/services/work_packages/create_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::CreateService, 'integration', type: :model do +RSpec.describe WorkPackages::CreateService, 'integration', type: :model do let(:user) do create(:user, member_in_project: project, diff --git a/spec/services/work_packages/delete_service_integration_spec.rb b/spec/services/work_packages/delete_service_integration_spec.rb index 4a2e438d140..e205623c87b 100644 --- a/spec/services/work_packages/delete_service_integration_spec.rb +++ b/spec/services/work_packages/delete_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::DeleteService, 'integration', type: :model do +RSpec.describe WorkPackages::DeleteService, 'integration', type: :model do shared_let(:project) { create(:project) } shared_let(:role) do create(:role, diff --git a/spec/services/work_packages/delete_service_spec.rb b/spec/services/work_packages/delete_service_spec.rb index 8eaf18b9fc6..598f541b6f1 100644 --- a/spec/services/work_packages/delete_service_spec.rb +++ b/spec/services/work_packages/delete_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::DeleteService do +RSpec.describe WorkPackages::DeleteService do let(:user) do build_stubbed(:user) end diff --git a/spec/services/work_packages/set_attributes_service_spec.rb b/spec/services/work_packages/set_attributes_service_spec.rb index 3554e1ac5ad..adffc3979c3 100644 --- a/spec/services/work_packages/set_attributes_service_spec.rb +++ b/spec/services/work_packages/set_attributes_service_spec.rb @@ -28,8 +28,8 @@ require 'spec_helper' -describe WorkPackages::SetAttributesService, - type: :model do +RSpec.describe WorkPackages::SetAttributesService, + type: :model do let(:today) { Time.zone.today } let(:user) { build_stubbed(:user) } let(:project) do diff --git a/spec/services/work_packages/set_schedule_service_spec.rb b/spec/services/work_packages/set_schedule_service_spec.rb index f524160c0f2..562a49b0709 100644 --- a/spec/services/work_packages/set_schedule_service_spec.rb +++ b/spec/services/work_packages/set_schedule_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::SetScheduleService do +RSpec.describe WorkPackages::SetScheduleService do create_shared_association_defaults_for_work_package_factory let(:work_package) do diff --git a/spec/services/work_packages/set_schedule_service_working_days_spec.rb b/spec/services/work_packages/set_schedule_service_working_days_spec.rb index 09deb60dfb9..1bfcdeca4e7 100644 --- a/spec/services/work_packages/set_schedule_service_working_days_spec.rb +++ b/spec/services/work_packages/set_schedule_service_working_days_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::SetScheduleService, 'working days' do +RSpec.describe WorkPackages::SetScheduleService, 'working days' do create_shared_association_defaults_for_work_package_factory shared_let(:week_days) { week_with_saturday_and_sunday_as_weekend } diff --git a/spec/services/work_packages/update_ancestors/loader_spec.rb b/spec/services/work_packages/update_ancestors/loader_spec.rb index 618f13a9883..b44931568a6 100644 --- a/spec/services/work_packages/update_ancestors/loader_spec.rb +++ b/spec/services/work_packages/update_ancestors/loader_spec.rb @@ -26,7 +26,7 @@ require 'spec_helper' -describe WorkPackages::UpdateAncestors::Loader, type: :model do +RSpec.describe WorkPackages::UpdateAncestors::Loader, type: :model do shared_let(:grandgrandparent) do create(:work_package) end diff --git a/spec/services/work_packages/update_ancestors_service_spec.rb b/spec/services/work_packages/update_ancestors_service_spec.rb index 299d13d48f8..ebcc41ff12a 100644 --- a/spec/services/work_packages/update_ancestors_service_spec.rb +++ b/spec/services/work_packages/update_ancestors_service_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::UpdateAncestorsService, type: :model, with_mail: false do +RSpec.describe WorkPackages::UpdateAncestorsService, type: :model, with_mail: false do let(:user) { create(:user) } let(:estimated_hours) { [nil, nil, nil] } let(:done_ratios) { [0, 0, 0] } diff --git a/spec/services/work_packages/update_service_integration_spec.rb b/spec/services/work_packages/update_service_integration_spec.rb index 0ebf96e411f..7ebe9427c23 100644 --- a/spec/services/work_packages/update_service_integration_spec.rb +++ b/spec/services/work_packages/update_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::UpdateService, 'integration tests', type: :model, with_mail: false do +RSpec.describe WorkPackages::UpdateService, 'integration tests', type: :model, with_mail: false do let(:user) do create(:user, member_in_project: project, diff --git a/spec/services/work_packages/update_service_spec.rb b/spec/services/work_packages/update_service_spec.rb index 06311777579..c49341ca699 100644 --- a/spec/services/work_packages/update_service_spec.rb +++ b/spec/services/work_packages/update_service_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require 'services/base_services/behaves_like_update_service' -describe WorkPackages::UpdateService, type: :model do +RSpec.describe WorkPackages::UpdateService, type: :model do # This is now only a very basic test testing the structure of the service. # The domain tests are in the update_service_integration_spec.rb it_behaves_like 'BaseServices update service' do diff --git a/spec/services/workflows/bulk_update_service_integration_spec.rb b/spec/services/workflows/bulk_update_service_integration_spec.rb index a6a6078e5e5..7812d1549dc 100644 --- a/spec/services/workflows/bulk_update_service_integration_spec.rb +++ b/spec/services/workflows/bulk_update_service_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Workflows::BulkUpdateService, 'integration', type: :model do +RSpec.describe Workflows::BulkUpdateService, 'integration', type: :model do let(:type) do create(:type) end diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 25cfc0c561c..f263f9929a6 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -86,6 +86,11 @@ RSpec.configure do |config| # you configure your source control system to ignore this file. config.example_status_persistence_file_path = "tmp/spec_examples.txt" + # Limits the available syntax to the non-monkey patched syntax that is + # recommended. For more details, see: + # https://rspec.info/features/3-12/rspec-core/configuration/zero-monkey-patching-mode/ + config.disable_monkey_patching! + # Many RSpec users commonly either run the entire suite or an individual # file, and it's useful to allow more verbose output when running an # individual spec file. diff --git a/spec/support/api/v3/shared_available_principals_examples.rb b/spec/support/api/v3/shared_available_principals_examples.rb index e14f263018f..72a71f7af39 100644 --- a/spec/support/api/v3/shared_available_principals_examples.rb +++ b/spec/support/api/v3/shared_available_principals_examples.rb @@ -28,7 +28,7 @@ require 'rack/test' -shared_examples_for 'available principals' do |principals| +RSpec.shared_examples_for 'available principals' do |principals| include API::V3::Utilities::PathHelper current_user do diff --git a/spec/support/api/v3/work_packages/work_package_representer_eager_loading.rb b/spec/support/api/v3/work_packages/work_package_representer_eager_loading.rb index 96b3cce1ad9..235f8f58a7a 100644 --- a/spec/support/api/v3/work_packages/work_package_representer_eager_loading.rb +++ b/spec/support/api/v3/work_packages/work_package_representer_eager_loading.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_context 'eager loaded work package representer' do +RSpec.shared_context 'eager loaded work package representer' do before do allow(API::V3::WorkPackages::WorkPackageEagerLoadingWrapper) .to receive(:wrap_one) do |work_package, _user| diff --git a/spec/support/contracts/shared.rb b/spec/support/contracts/shared.rb index 3655a8d9f45..a25cea570e1 100644 --- a/spec/support/contracts/shared.rb +++ b/spec/support/contracts/shared.rb @@ -1,4 +1,4 @@ -shared_context 'model contract' do +RSpec.shared_context 'model contract' do shared_examples_for 'is not writable' do before do instance.model.attributes = { attribute => value } diff --git a/spec/support/queries/filters/shared_filter_examples.rb b/spec/support/queries/filters/shared_filter_examples.rb index c90374b9717..03e55c9dcff 100644 --- a/spec/support/queries/filters/shared_filter_examples.rb +++ b/spec/support/queries/filters/shared_filter_examples.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_context 'filter tests' do +RSpec.shared_context 'filter tests' do let(:context) { nil } let(:values) { ['bogus'] } let(:operator) { '=' } @@ -38,7 +38,7 @@ shared_context 'filter tests' do let(:model) { WorkPackage } end -shared_examples_for 'basic query filter' do +RSpec.shared_examples_for 'basic query filter' do include_context 'filter tests' let(:context) { build_stubbed(:query, project:) } @@ -72,7 +72,7 @@ shared_examples_for 'basic query filter' do end end -shared_examples_for 'list query filter' do |scope: true| +RSpec.shared_examples_for 'list query filter' do |scope: true| include_context 'filter tests' let(:attribute) { raise "needs to be defined" } let(:type) { :list } @@ -131,7 +131,7 @@ shared_examples_for 'list query filter' do |scope: true| end end -shared_examples_for 'list_optional query filter' do +RSpec.shared_examples_for 'list_optional query filter' do include_context 'filter tests' let(:attribute) { raise "needs to be defined" } let(:type) { :list_optional } @@ -222,7 +222,7 @@ shared_examples_for 'list_optional query filter' do end end -shared_examples_for 'list_optional group query filter' do +RSpec.shared_examples_for 'list_optional group query filter' do include_context 'filter tests' describe '#scope' do let(:values) { valid_values } @@ -290,7 +290,7 @@ shared_examples_for 'list_optional group query filter' do end end -shared_examples_for 'list_all query filter' do +RSpec.shared_examples_for 'list_all query filter' do include_context 'filter tests' let(:attribute) { raise "needs to be defined" } let(:type) { :list_all } @@ -370,7 +370,7 @@ shared_examples_for 'list_all query filter' do end end -shared_examples_for 'boolean query filter' do |scope: true| +RSpec.shared_examples_for 'boolean query filter' do |scope: true| include_context 'filter tests' let(:attribute) { raise "needs to be defined" } let(:type) { :list } @@ -451,7 +451,7 @@ shared_examples_for 'boolean query filter' do |scope: true| end end -shared_examples_for 'non ar filter' do +RSpec.shared_examples_for 'non ar filter' do describe '#ar_object_filter?' do it 'is false' do expect(instance) @@ -467,7 +467,7 @@ shared_examples_for 'non ar filter' do end end -shared_examples_for 'filter by work package id' do +RSpec.shared_examples_for 'filter by work package id' do include_context 'filter tests' let(:project) { build_stubbed(:project) } @@ -675,7 +675,7 @@ shared_examples_for 'filter by work package id' do end end -shared_examples_for 'operators for relation filters' do +RSpec.shared_examples_for 'operators for relation filters' do context "on '=' operator" do before do instance.operator = '=' @@ -699,7 +699,7 @@ shared_examples_for 'operators for relation filters' do end end -shared_examples_for 'filter for relation' do +RSpec.shared_examples_for 'filter for relation' do describe '#where' do let!(:filter_value_wp) { create(:work_package) } let(:wp_relation_type) { defined?(:relation_type) ? relation_type : raise('needs to be defined') } diff --git a/spec/support/queries/shared_get_individual_query_examples.rb b/spec/support/queries/shared_get_individual_query_examples.rb index ae8413b0d51..defba5bf4ee 100644 --- a/spec/support/queries/shared_get_individual_query_examples.rb +++ b/spec/support/queries/shared_get_individual_query_examples.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_examples_for 'GET individual query' do +RSpec.shared_examples_for 'GET individual query' do let(:work_package) { create(:work_package, project:) } let(:filter) { [] } let(:path) do diff --git a/spec/support/roles.rb b/spec/support/roles.rb index aee77866213..741e184033a 100644 --- a/spec/support/roles.rb +++ b/spec/support/roles.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_context 'with non-member permissions from non_member_permissions' do +RSpec.shared_context 'with non-member permissions from non_member_permissions' do around do |example| non_member = Role.non_member previous_permissions = non_member.permissions diff --git a/spec/support/scm/countable_repository.rb b/spec/support/scm/countable_repository.rb index 49483055622..596d594b19f 100644 --- a/spec/support/scm/countable_repository.rb +++ b/spec/support/scm/countable_repository.rb @@ -1,5 +1,5 @@ require 'open3' -shared_examples_for 'is a countable repository' do +RSpec.shared_examples_for 'is a countable repository' do let(:cache_time) { 720 } before do @@ -89,7 +89,7 @@ shared_examples_for 'is a countable repository' do end end -shared_examples_for 'is not a countable repository' do +RSpec.shared_examples_for 'is not a countable repository' do it 'is not countable' do expect(repository.scm).not_to be_storage_available end diff --git a/spec/support/scm/relocate_repository.rb b/spec/support/scm/relocate_repository.rb index c9df50019df..b65d7b96f91 100644 --- a/spec/support/scm/relocate_repository.rb +++ b/spec/support/scm/relocate_repository.rb @@ -1,4 +1,4 @@ -shared_examples_for 'repository can be relocated' do |vendor| +RSpec.shared_examples_for 'repository can be relocated' do |vendor| let(:job_call) do SCM::RelocateRepositoryJob.perform_now repository end diff --git a/spec/support/shared/acts_as_attachable.rb b/spec/support/shared/acts_as_attachable.rb index bfe415f439f..13d780bb23d 100644 --- a/spec/support/shared/acts_as_attachable.rb +++ b/spec/support/shared/acts_as_attachable.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_examples_for 'acts_as_attachable included' do +RSpec.shared_examples_for 'acts_as_attachable included' do let(:attachment1) { create(:attachment, container: nil, author: current_user) } let(:attachment2) { create(:attachment, container: nil, author: current_user) } let(:instance_project) { respond_to?(:project) ? project : model_instance.project } diff --git a/spec/support/shared/acts_as_customizable.rb b/spec/support/shared/acts_as_customizable.rb index e8d5be9a677..59fe08454c4 100644 --- a/spec/support/shared/acts_as_customizable.rb +++ b/spec/support/shared/acts_as_customizable.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_examples_for 'acts_as_customizable included' do +RSpec.shared_examples_for 'acts_as_customizable included' do describe '#custom_field_changes' do context 'when no custom field value exists' do before do diff --git a/spec/support/shared/acts_as_watchable.rb b/spec/support/shared/acts_as_watchable.rb index e92e0115fe8..d4e6c175a63 100644 --- a/spec/support/shared/acts_as_watchable.rb +++ b/spec/support/shared/acts_as_watchable.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_examples_for 'acts_as_watchable included' do +RSpec.shared_examples_for 'acts_as_watchable included' do before do unless defined?(model_instance) && defined?(watch_permission) && diff --git a/spec/support/shared/audits.rb b/spec/support/shared/audits.rb index 53ff151a7c9..dfaf86695c7 100644 --- a/spec/support/shared/audits.rb +++ b/spec/support/shared/audits.rb @@ -26,7 +26,7 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_examples_for 'creates an audit trail on destroy' do +RSpec.shared_examples_for 'creates an audit trail on destroy' do with_versioning do let(:whodunnit) { build_stubbed(:user) } diff --git a/spec/support/shared/forms_html.rb b/spec/support/shared/forms_html.rb index 4d611c24bd8..35ce9648a50 100644 --- a/spec/support/shared/forms_html.rb +++ b/spec/support/shared/forms_html.rb @@ -26,19 +26,19 @@ # See COPYRIGHT and LICENSE files for more details. #++ -shared_examples_for 'labelled' do +RSpec.shared_examples_for 'labelled' do it 'has a label with title' do expect(subject).to have_selector 'label.form--label[title]' end end -shared_examples_for 'not labelled' do +RSpec.shared_examples_for 'not labelled' do it 'does not have a label with title' do expect(subject).not_to have_selector 'label.form--label[title]' end end -shared_examples_for 'labelled by default' do +RSpec.shared_examples_for 'labelled by default' do context 'by default' do it_behaves_like 'labelled' end @@ -50,7 +50,7 @@ shared_examples_for 'labelled by default' do end end -shared_examples_for 'wrapped in container' do |container = 'field-container'| +RSpec.shared_examples_for 'wrapped in container' do |container = 'field-container'| it { is_expected.to have_selector "span.form--#{container}", count: 1 } context 'with additional class provided' do @@ -67,11 +67,11 @@ shared_examples_for 'wrapped in container' do |container = 'field-container'| end end -shared_examples_for 'not wrapped in container' do |container = 'field-container'| +RSpec.shared_examples_for 'not wrapped in container' do |container = 'field-container'| it { is_expected.not_to have_selector "span.form--#{container}" } end -shared_examples_for 'wrapped in field-container by default' do +RSpec.shared_examples_for 'wrapped in field-container by default' do context 'by default' do it_behaves_like 'wrapped in container' end diff --git a/spec/support/shared/permissions.rb b/spec/support/shared/permissions.rb index 19936e298c7..9136b05d590 100644 --- a/spec/support/shared/permissions.rb +++ b/spec/support/shared/permissions.rb @@ -74,14 +74,14 @@ module PermissionSpecHelpers end end -shared_context 'a controller action with unrestricted access' do +RSpec.shared_context 'a controller action with unrestricted access' do let(:valid_user) { create(:anonymous) } extend PermissionSpecHelpers spec_permissions(false) end -shared_context 'a controller action with require_login' do +RSpec.shared_context 'a controller action with require_login' do let(:valid_user) { create(:user) } let(:invalid_user) { create(:anonymous) } @@ -89,7 +89,7 @@ shared_context 'a controller action with require_login' do spec_permissions end -shared_context 'a controller action with require_admin' do +RSpec.shared_context 'a controller action with require_admin' do let(:valid_user) { User.where(admin: true).first || create(:admin) } let(:invalid_user) { create(:user) } @@ -97,7 +97,7 @@ shared_context 'a controller action with require_admin' do spec_permissions end -shared_context 'a controller action which needs project permissions' do +RSpec.shared_context 'a controller action which needs project permissions' do # Expecting the following environment # # let(:project) { create(:project) } diff --git a/spec/support/shared/rake.rb b/spec/support/shared/rake.rb index 5773668a8b2..2014c74a1c4 100644 --- a/spec/support/shared/rake.rb +++ b/spec/support/shared/rake.rb @@ -31,7 +31,7 @@ require 'rake' -shared_context 'rake' do +RSpec.shared_context 'rake' do let(:rake) { Rake::Application.new } let(:task_name) { self.class.description } let(:task_path) { "lib/tasks/#{task_name.split(':').first}" } diff --git a/spec/support/shared/with_mobile_screen.rb b/spec/support/shared/with_mobile_screen.rb index 1ff58ae4c70..2e3c887c21f 100644 --- a/spec/support/shared/with_mobile_screen.rb +++ b/spec/support/shared/with_mobile_screen.rb @@ -24,7 +24,7 @@ # # See COPYRIGHT and LICENSE files for more details. -shared_context 'with mobile screen size' do |width, height| +RSpec.shared_context 'with mobile screen size' do |width, height| let!(:height_before) do page.driver.browser.manage.window.size.height end diff --git a/spec/support/shared/with_test_ldap.rb b/spec/support/shared/with_test_ldap.rb index 04c2c7d67b5..1b15db0bef1 100644 --- a/spec/support/shared/with_test_ldap.rb +++ b/spec/support/shared/with_test_ldap.rb @@ -27,7 +27,7 @@ #++ require 'ladle' -shared_context 'with temporary LDAP' do +RSpec.shared_context 'with temporary LDAP' do # rubocop:disable RSpec/InstanceVariable before(:all) do ldif = Rails.root.join('spec/fixtures/ldap/users.ldif') diff --git a/spec/support/support_links.rb b/spec/support/support_links.rb index 42c4b512282..6243fa09859 100644 --- a/spec/support/support_links.rb +++ b/spec/support/support_links.rb @@ -29,7 +29,7 @@ # ++ # rubocop:disable RSpec/ContextWording -shared_context 'support links' do +RSpec.shared_context 'support links' do let(:support_link_as_community) { 'https://www.openproject.org/pricing/#support' } let(:support_link_as_enterprise) { 'https://www.openproject.org/docs/enterprise-guide/support/' } end diff --git a/spec/support/tempdir.rb b/spec/support/tempdir.rb index 887af786c11..a36b5be6b06 100644 --- a/spec/support/tempdir.rb +++ b/spec/support/tempdir.rb @@ -25,7 +25,7 @@ # # See COPYRIGHT and LICENSE files for more details. #++ -shared_context 'with tmpdir' do +RSpec.shared_context 'with tmpdir' do around do |example| Dir.mktmpdir do |dir| @tmpdir = dir diff --git a/spec/support/user_with_stubbed_permissions.rb b/spec/support/user_with_stubbed_permissions.rb index 2f1ee358e99..aeb6815cf5d 100644 --- a/spec/support/user_with_stubbed_permissions.rb +++ b/spec/support/user_with_stubbed_permissions.rb @@ -1,4 +1,4 @@ -shared_context 'user with stubbed permissions' do |attributes = {}| +RSpec.shared_context 'user with stubbed permissions' do |attributes = {}| let(:user) do raise "'let(:permissions)' needs to be defined" unless defined?(:permissions) raise "'let(:project)' needs to be defined" unless defined?(:project) diff --git a/spec/support_spec/schedule_helpers/chart_builder_spec.rb b/spec/support_spec/schedule_helpers/chart_builder_spec.rb index 393128a8ca7..b61e61c999f 100644 --- a/spec/support_spec/schedule_helpers/chart_builder_spec.rb +++ b/spec/support_spec/schedule_helpers/chart_builder_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ScheduleHelpers::ChartBuilder do +RSpec.describe ScheduleHelpers::ChartBuilder do include ActiveSupport::Testing::TimeHelpers let(:fake_today) { Date.new(2022, 6, 16) } # Thursday 16 June 2022 diff --git a/spec/support_spec/schedule_helpers/chart_representer_spec.rb b/spec/support_spec/schedule_helpers/chart_representer_spec.rb index a133ce7ef4c..e49b8a4c9db 100644 --- a/spec/support_spec/schedule_helpers/chart_representer_spec.rb +++ b/spec/support_spec/schedule_helpers/chart_representer_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ScheduleHelpers::ChartRepresenter do +RSpec.describe ScheduleHelpers::ChartRepresenter do describe '#normalized_to_s' do shared_let(:week_days) { week_with_saturday_and_sunday_as_weekend } diff --git a/spec/support_spec/schedule_helpers/chart_spec.rb b/spec/support_spec/schedule_helpers/chart_spec.rb index c21b580f9df..778c6ac54ff 100644 --- a/spec/support_spec/schedule_helpers/chart_spec.rb +++ b/spec/support_spec/schedule_helpers/chart_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ScheduleHelpers::Chart do +RSpec.describe ScheduleHelpers::Chart do include ActiveSupport::Testing::TimeHelpers let(:fake_today) { Date.new(2022, 6, 16) } # Thursday 16 June 2022 diff --git a/spec/support_spec/schedule_helpers/example_methods_spec.rb b/spec/support_spec/schedule_helpers/example_methods_spec.rb index af496f719e9..a4ab0659810 100644 --- a/spec/support_spec/schedule_helpers/example_methods_spec.rb +++ b/spec/support_spec/schedule_helpers/example_methods_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ScheduleHelpers::ExampleMethods do +RSpec.describe ScheduleHelpers::ExampleMethods do create_shared_association_defaults_for_work_package_factory describe 'create_schedule' do diff --git a/spec/support_spec/schedule_helpers/let_schedule_spec.rb b/spec/support_spec/schedule_helpers/let_schedule_spec.rb index 0ccbe710f94..4f672f1d814 100644 --- a/spec/support_spec/schedule_helpers/let_schedule_spec.rb +++ b/spec/support_spec/schedule_helpers/let_schedule_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ScheduleHelpers::LetSchedule do +RSpec.describe ScheduleHelpers::LetSchedule do create_shared_association_defaults_for_work_package_factory describe 'let_schedule' do diff --git a/spec/validator/secure_context_uri_validator_spec.rb b/spec/validator/secure_context_uri_validator_spec.rb index 9fd65e8ee41..ab961deef36 100644 --- a/spec/validator/secure_context_uri_validator_spec.rb +++ b/spec/validator/secure_context_uri_validator_spec.rb @@ -30,7 +30,7 @@ require 'spec_helper' -describe SecureContextUriValidator do +RSpec.describe SecureContextUriValidator do let(:host) { nil } let(:model_class) do Class.new do diff --git a/spec/views/account/login.html.erb_spec.rb b/spec/views/account/login.html.erb_spec.rb index 692a0bb0279..61c110b6d52 100644 --- a/spec/views/account/login.html.erb_spec.rb +++ b/spec/views/account/login.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'account/login' do +RSpec.describe 'account/login' do context 'with password login enabled' do before do render diff --git a/spec/views/account/register.html.erb_spec.rb b/spec/views/account/register.html.erb_spec.rb index 7e2cb668ae0..d9b4e041851 100644 --- a/spec/views/account/register.html.erb_spec.rb +++ b/spec/views/account/register.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'account/register' do +RSpec.describe 'account/register' do let(:user) { build(:user, auth_source: nil) } context 'with the email_login setting disabled (default value)' do diff --git a/spec/views/admin/enterprises/_current.html.erb_spec.rb b/spec/views/admin/enterprises/_current.html.erb_spec.rb index 7438b39014f..74ead4a4206 100644 --- a/spec/views/admin/enterprises/_current.html.erb_spec.rb +++ b/spec/views/admin/enterprises/_current.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'admin/enterprises/_current' do +RSpec.describe 'admin/enterprises/_current' do let(:current_user) { create(:admin) } let(:ee_token) { "v1_expired_with_7_days_reprieve_at_2021_09_01.token" } let(:current_time) { DateTime.now } diff --git a/spec/views/admin/settings/authentication/show.html.erb_spec.rb b/spec/views/admin/settings/authentication/show.html.erb_spec.rb index 31844df6835..1d20adf9b85 100644 --- a/spec/views/admin/settings/authentication/show.html.erb_spec.rb +++ b/spec/views/admin/settings/authentication/show.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'admin/settings/authentication_settings/show' do +RSpec.describe 'admin/settings/authentication_settings/show' do context 'with password login enabled' do before do allow(OpenProject::Configuration).to receive(:disable_password_login?).and_return(false) diff --git a/spec/views/common/validation_error.html.erb_spec.rb b/spec/views/common/validation_error.html.erb_spec.rb index a749561686c..a40a7995678 100644 --- a/spec/views/common/validation_error.html.erb_spec.rb +++ b/spec/views/common/validation_error.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'common/_validation_error' do +RSpec.describe 'common/_validation_error' do let(:error_message) { ['Something went completely wrong!'] } before do diff --git a/spec/views/custom_styles/show.html.erb_spec.rb b/spec/views/custom_styles/show.html.erb_spec.rb index f43d9200a6c..295c55cae6d 100644 --- a/spec/views/custom_styles/show.html.erb_spec.rb +++ b/spec/views/custom_styles/show.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'custom_styles/show' do +RSpec.describe 'custom_styles/show' do let(:user) { build(:admin) } before do diff --git a/spec/views/layouts/admin.html.erb_spec.rb b/spec/views/layouts/admin.html.erb_spec.rb index 27e3a487da5..606883bbf37 100644 --- a/spec/views/layouts/admin.html.erb_spec.rb +++ b/spec/views/layouts/admin.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'layouts/admin' do +RSpec.describe 'layouts/admin' do shared_let(:admin) { create(:admin) } include Redmine::MenuManager::MenuHelper diff --git a/spec/views/layouts/base.html.erb_spec.rb b/spec/views/layouts/base.html.erb_spec.rb index 11482903270..41027d20187 100644 --- a/spec/views/layouts/base.html.erb_spec.rb +++ b/spec/views/layouts/base.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'layouts/base' do +RSpec.describe 'layouts/base' do # This is to make `visit` available. It might be already included by the time # we reach this spec, but for running this spec alone we need it here. Best # of both worlds. diff --git a/spec/views/projects/settings/general/show.html.erb_spec.rb b/spec/views/projects/settings/general/show.html.erb_spec.rb index c6c7f311a40..4c8aeb4158b 100644 --- a/spec/views/projects/settings/general/show.html.erb_spec.rb +++ b/spec/views/projects/settings/general/show.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'projects/settings/general/show' do +RSpec.describe 'projects/settings/general/show' do let(:project) { build_stubbed(:project) } describe 'project copy permission' do diff --git a/spec/views/repositories/stats.html.erb_spec.rb b/spec/views/repositories/stats.html.erb_spec.rb index 1db75c75eca..3e6870419fa 100644 --- a/spec/views/repositories/stats.html.erb_spec.rb +++ b/spec/views/repositories/stats.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'repositories/stats' do +RSpec.describe 'repositories/stats' do let(:project) { create(:project) } before do diff --git a/spec/views/users/edit.html.erb_spec.rb b/spec/views/users/edit.html.erb_spec.rb index 3a57ab2bede..102bac0578c 100644 --- a/spec/views/users/edit.html.erb_spec.rb +++ b/spec/views/users/edit.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'users/edit' do +RSpec.describe 'users/edit' do let(:admin) { build(:admin) } before do diff --git a/spec/views/users/index.html.erb_spec.rb b/spec/views/users/index.html.erb_spec.rb index ebf063920ab..ec04ad39e1d 100644 --- a/spec/views/users/index.html.erb_spec.rb +++ b/spec/views/users/index.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'users/index' do +RSpec.describe 'users/index' do shared_let(:admin) { create(:admin) } let!(:user) { create(:user, firstname: "Scarlet", lastname: "Scallywag") } diff --git a/spec/views/users/show.html.erb_spec.rb b/spec/views/users/show.html.erb_spec.rb index 6744c3af44d..4964ce145e4 100644 --- a/spec/views/users/show.html.erb_spec.rb +++ b/spec/views/users/show.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'users/show' do +RSpec.describe 'users/show' do let(:project) { create(:valid_project) } let(:user) { create(:admin, member_in_project: project) } let(:custom_field) { create(:text_user_custom_field) } diff --git a/spec/views/wiki/new.html.erb_spec.rb b/spec/views/wiki/new.html.erb_spec.rb index 3efbc9abf2e..457cb2bf80d 100644 --- a/spec/views/wiki/new.html.erb_spec.rb +++ b/spec/views/wiki/new.html.erb_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'wiki/new' do +RSpec.describe 'wiki/new' do let(:project) { build_stubbed(:project) } let(:wiki) { build_stubbed(:wiki, project:) } let(:page) { build_stubbed(:wiki_page, wiki:, title: 'foo') } diff --git a/spec/views/work_package/auto_complete/index_spec.rb b/spec/views/work_package/auto_complete/index_spec.rb index d65171817ac..05693ef807e 100644 --- a/spec/views/work_package/auto_complete/index_spec.rb +++ b/spec/views/work_package/auto_complete/index_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe 'work_packages/auto_completes/index.html.erb' do +RSpec.describe 'work_packages/auto_completes/index.html.erb' do let(:work_package) do build(:work_package, subject: '') diff --git a/spec/workers/application_job_spec.rb b/spec/workers/application_job_spec.rb index 0a87a3400f1..1f249d92122 100644 --- a/spec/workers/application_job_spec.rb +++ b/spec/workers/application_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ApplicationJob do +RSpec.describe ApplicationJob do class JobMock < ApplicationJob def initialize(callback) @callback = callback diff --git a/spec/workers/attachments/cleanup_uncontainered_job_integration_spec.rb b/spec/workers/attachments/cleanup_uncontainered_job_integration_spec.rb index 5646ea10856..8e5e6b835c9 100644 --- a/spec/workers/attachments/cleanup_uncontainered_job_integration_spec.rb +++ b/spec/workers/attachments/cleanup_uncontainered_job_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Attachments::CleanupUncontaineredJob, type: :job do +RSpec.describe Attachments::CleanupUncontaineredJob, type: :job do let(:grace_period) { 120 } let!(:containered_attachment) { create(:attachment) } diff --git a/spec/workers/attachments/finish_direct_upload_job_integration_spec.rb b/spec/workers/attachments/finish_direct_upload_job_integration_spec.rb index ac3422f88d9..3e8f711857a 100644 --- a/spec/workers/attachments/finish_direct_upload_job_integration_spec.rb +++ b/spec/workers/attachments/finish_direct_upload_job_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Attachments::FinishDirectUploadJob, 'integration', type: :job do +RSpec.describe Attachments::FinishDirectUploadJob, 'integration', type: :job do shared_let(:user) { create(:admin) } let!(:pending_attachment) do diff --git a/spec/workers/backup_job_spec.rb b/spec/workers/backup_job_spec.rb index 1f6e6e98f52..c092bff0bf9 100644 --- a/spec/workers/backup_job_spec.rb +++ b/spec/workers/backup_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe BackupJob, type: :model do +RSpec.describe BackupJob, type: :model do shared_examples "it creates a backup" do |opts = {}| let(:job) { BackupJob.new } diff --git a/spec/workers/copy_project_job_spec.rb b/spec/workers/copy_project_job_spec.rb index 992f9aa5854..a3daaa81b0b 100644 --- a/spec/workers/copy_project_job_spec.rb +++ b/spec/workers/copy_project_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe CopyProjectJob, type: :model do +RSpec.describe CopyProjectJob, type: :model do let(:project) { create(:project, public: false) } let(:user) { create(:user) } let(:role) { create(:role, permissions: [:copy_projects]) } diff --git a/spec/workers/extract_fulltext_job_spec.rb b/spec/workers/extract_fulltext_job_spec.rb index c9b5542ff98..6a29454add9 100644 --- a/spec/workers/extract_fulltext_job_spec.rb +++ b/spec/workers/extract_fulltext_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe ExtractFulltextJob, type: :job do +RSpec.describe ExtractFulltextJob, type: :job do subject(:extracted_attributes) do perform_enqueued_jobs diff --git a/spec/workers/journals/completed_job_spec.rb b/spec/workers/journals/completed_job_spec.rb index 135b566ac19..de2a4bdd88d 100644 --- a/spec/workers/journals/completed_job_spec.rb +++ b/spec/workers/journals/completed_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Journals::CompletedJob, type: :model do +RSpec.describe Journals::CompletedJob, type: :model do let(:send_mail) { true } let(:journal) do diff --git a/spec/workers/ldap/synchronization_job_spec.rb b/spec/workers/ldap/synchronization_job_spec.rb index 4f59538bce0..e092f65d03e 100644 --- a/spec/workers/ldap/synchronization_job_spec.rb +++ b/spec/workers/ldap/synchronization_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Ldap::SynchronizationJob, type: :model do +RSpec.describe Ldap::SynchronizationJob, type: :model do let!(:auth_source) { create(:ldap_auth_source) } let(:job) { described_class.new } diff --git a/spec/workers/mails/member_created_job_spec.rb b/spec/workers/mails/member_created_job_spec.rb index d5dc607b169..5f1c3948d71 100644 --- a/spec/workers/mails/member_created_job_spec.rb +++ b/spec/workers/mails/member_created_job_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative 'shared/member_job' -describe Mails::MemberCreatedJob, type: :model do +RSpec.describe Mails::MemberCreatedJob, type: :model do include_examples 'member job' do let(:user_project_mail_method) { :added_project } diff --git a/spec/workers/mails/member_updated_job_spec.rb b/spec/workers/mails/member_updated_job_spec.rb index 2f3768bdb8d..4b6035e94e0 100644 --- a/spec/workers/mails/member_updated_job_spec.rb +++ b/spec/workers/mails/member_updated_job_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative 'shared/member_job' -describe Mails::MemberUpdatedJob, type: :model do +RSpec.describe Mails::MemberUpdatedJob, type: :model do include_examples 'member job' do let(:user_project_mail_method) { :updated_project } diff --git a/spec/workers/mails/reminder_job_spec.rb b/spec/workers/mails/reminder_job_spec.rb index d348b857cd0..ffc4c1186d5 100644 --- a/spec/workers/mails/reminder_job_spec.rb +++ b/spec/workers/mails/reminder_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Mails::ReminderJob, type: :model do +RSpec.describe Mails::ReminderJob, type: :model do subject(:job) { described_class.perform_now(recipient) } let(:recipient) do diff --git a/spec/workers/mails/shared/member_job.rb b/spec/workers/mails/shared/member_job.rb index dd1daf56ba0..91cedfc0701 100644 --- a/spec/workers/mails/shared/member_job.rb +++ b/spec/workers/mails/shared/member_job.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples 'member job' do +RSpec.shared_examples 'member job' do subject(:run_job) do described_class.perform_now(current_user:, member:, diff --git a/spec/workers/mails/shared/watcher_job.rb b/spec/workers/mails/shared/watcher_job.rb index 295f7596bbd..f5187541b6b 100644 --- a/spec/workers/mails/shared/watcher_job.rb +++ b/spec/workers/mails/shared/watcher_job.rb @@ -28,7 +28,7 @@ require 'spec_helper' -shared_examples "watcher job" do |action| +RSpec.shared_examples "watcher job" do |action| subject { described_class.perform_now(watcher_parameter, watcher_changer) } let(:action) { action } diff --git a/spec/workers/mails/watcher_added_job_spec.rb b/spec/workers/mails/watcher_added_job_spec.rb index ca2ca450dba..ee319db203d 100644 --- a/spec/workers/mails/watcher_added_job_spec.rb +++ b/spec/workers/mails/watcher_added_job_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative 'shared/watcher_job' -describe Mails::WatcherAddedJob, type: :model do +RSpec.describe Mails::WatcherAddedJob, type: :model do include_examples "watcher job", 'added' do let(:watcher_parameter) { watcher } end diff --git a/spec/workers/mails/watcher_removed_job_spec.rb b/spec/workers/mails/watcher_removed_job_spec.rb index e5176595777..f943b12d2da 100644 --- a/spec/workers/mails/watcher_removed_job_spec.rb +++ b/spec/workers/mails/watcher_removed_job_spec.rb @@ -29,7 +29,7 @@ require 'spec_helper' require_relative 'shared/watcher_job' -describe Mails::WatcherRemovedJob, type: :model do +RSpec.describe Mails::WatcherRemovedJob, type: :model do include_examples "watcher job", 'removed' do let(:watcher_parameter) { watcher.attributes } diff --git a/spec/workers/non_existing_job_class_spec.rb b/spec/workers/non_existing_job_class_spec.rb index d8dc5a7650e..cfef4ee2e23 100644 --- a/spec/workers/non_existing_job_class_spec.rb +++ b/spec/workers/non_existing_job_class_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe "NonExistingJobClass" do +RSpec.describe "NonExistingJobClass" do let!(:job_with_non_existing_class) do handler = <<~JOB.strip --- !ruby/object:ActiveJob::QueueAdapters::DelayedJobAdapter::JobWrapper diff --git a/spec/workers/notifications/create_date_alerts_notifications_job_spec.rb b/spec/workers/notifications/create_date_alerts_notifications_job_spec.rb index 598eb83a2ff..46b56a9a2b4 100644 --- a/spec/workers/notifications/create_date_alerts_notifications_job_spec.rb +++ b/spec/workers/notifications/create_date_alerts_notifications_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Notifications::CreateDateAlertsNotificationsJob, type: :job, with_ee: %i[date_alerts] do +RSpec.describe Notifications::CreateDateAlertsNotificationsJob, type: :job, with_ee: %i[date_alerts] do include ActiveSupport::Testing::TimeHelpers shared_let(:project) { create(:project, name: 'main') } diff --git a/spec/workers/notifications/group_member_altered_job_spec.rb b/spec/workers/notifications/group_member_altered_job_spec.rb index dbbfde1dfff..901565282b1 100644 --- a/spec/workers/notifications/group_member_altered_job_spec.rb +++ b/spec/workers/notifications/group_member_altered_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Notifications::GroupMemberAlteredJob, type: :model do +RSpec.describe Notifications::GroupMemberAlteredJob, type: :model do subject(:service_call) do described_class.new.perform(current_user, members_ids, message, send_notification) end diff --git a/spec/workers/notifications/schedule_date_alerts_notifications_job_spec.rb b/spec/workers/notifications/schedule_date_alerts_notifications_job_spec.rb index b256b040fb0..d733bd69b38 100644 --- a/spec/workers/notifications/schedule_date_alerts_notifications_job_spec.rb +++ b/spec/workers/notifications/schedule_date_alerts_notifications_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Notifications::ScheduleDateAlertsNotificationsJob, type: :job, with_ee: %i[date_alerts] do +RSpec.describe Notifications::ScheduleDateAlertsNotificationsJob, type: :job, with_ee: %i[date_alerts] do include ActiveSupport::Testing::TimeHelpers shared_let(:project) { create(:project, name: 'main') } diff --git a/spec/workers/notifications/schedule_reminder_mails_job_spec.rb b/spec/workers/notifications/schedule_reminder_mails_job_spec.rb index 6a108b1baa9..21c4b5e1427 100644 --- a/spec/workers/notifications/schedule_reminder_mails_job_spec.rb +++ b/spec/workers/notifications/schedule_reminder_mails_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Notifications::ScheduleReminderMailsJob, type: :job do +RSpec.describe Notifications::ScheduleReminderMailsJob, type: :job do subject(:job) { scheduled_job.invoke_job } let(:scheduled_job) do diff --git a/spec/workers/notifications/workflow_job_spec.rb b/spec/workers/notifications/workflow_job_spec.rb index d44ba5cab6f..9dfa5800bda 100644 --- a/spec/workers/notifications/workflow_job_spec.rb +++ b/spec/workers/notifications/workflow_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Notifications::WorkflowJob, type: :model do +RSpec.describe Notifications::WorkflowJob, type: :model do subject(:perform_job) do described_class.new.perform(state, *arguments) end diff --git a/spec/workers/principals/delete_job_integration_spec.rb b/spec/workers/principals/delete_job_integration_spec.rb index 6059a5eec4c..1d63b149913 100644 --- a/spec/workers/principals/delete_job_integration_spec.rb +++ b/spec/workers/principals/delete_job_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Principals::DeleteJob, type: :model do +RSpec.describe Principals::DeleteJob, type: :model do subject(:job) { described_class.perform_now(principal) } shared_let(:project) { create(:project) } diff --git a/spec/workers/projects/reorder_children_job_integration_spec.rb b/spec/workers/projects/reorder_children_job_integration_spec.rb index 9c84e04f21b..2d7b302b25d 100644 --- a/spec/workers/projects/reorder_children_job_integration_spec.rb +++ b/spec/workers/projects/reorder_children_job_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe Projects::ReorderHierarchyJob, type: :model do +RSpec.describe Projects::ReorderHierarchyJob, type: :model do subject(:job) { described_class.perform_now } shared_let(:parent_project_a) { create(:project, name: 'ParentA') } diff --git a/spec/workers/scm/create_local_repository_job_spec.rb b/spec/workers/scm/create_local_repository_job_spec.rb index 2657068f31e..4277aef4d23 100644 --- a/spec/workers/scm/create_local_repository_job_spec.rb +++ b/spec/workers/scm/create_local_repository_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe SCM::CreateLocalRepositoryJob do +RSpec.describe SCM::CreateLocalRepositoryJob do let(:instance) { described_class.new } # Allow to override configuration values to determine # whether to activate managed repositories diff --git a/spec/workers/user_job_spec.rb b/spec/workers/user_job_spec.rb index 324c267c49e..0aceb22cbfe 100644 --- a/spec/workers/user_job_spec.rb +++ b/spec/workers/user_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe UserJob do +RSpec.describe UserJob do let(:test_job) do Class.new(UserJob) do def execute(foo:) diff --git a/spec/workers/work_packages/exports/export_job_integration_spec.rb b/spec/workers/work_packages/exports/export_job_integration_spec.rb index 0d45a9011eb..54f04690d69 100644 --- a/spec/workers/work_packages/exports/export_job_integration_spec.rb +++ b/spec/workers/work_packages/exports/export_job_integration_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::ExportJob, 'Integration' do +RSpec.describe WorkPackages::ExportJob, 'Integration' do let(:project) { create(:project) } let(:user) do create(:user, diff --git a/spec/workers/work_packages/exports/export_job_spec.rb b/spec/workers/work_packages/exports/export_job_spec.rb index 656d3a673db..453a269f100 100644 --- a/spec/workers/work_packages/exports/export_job_spec.rb +++ b/spec/workers/work_packages/exports/export_job_spec.rb @@ -28,7 +28,7 @@ require 'spec_helper' -describe WorkPackages::ExportJob do +RSpec.describe WorkPackages::ExportJob do let(:user) { build_stubbed(:user) } let(:attachment) { double('Attachment', id: 1234) } let(:export) do