Files
Behrokh Satarnejad d924c255cf [69524] Primerize Types form configuration page (#22854)
* Create the section component

* Create the form configuration component

* Create a controller

* change form template

* Use primer dialog for reset to defaults button

* show WP configuration modal while creating a related WPs table

* Fix the drag and drop functionality without save button

* Fix renaming functionality

* Use generic drag and drop in form configuration and move all client side action handling to server side

* Fix embedded query form configuration regressions

* Add data test selectors to all elements that we used for test

* update the current tests with the new implementations and design

* Add new tests for new controller of sections and rows

* WP quesry row should only have edit quesry action

* Update transformer spec regarding the new changes

* Fix the failing test in reset form configuration and some tests for actions

* Fix rubocop errors

* Fix eslint errors

* Add spec for removing a section

* Use condensed border boxes

* fix failing specs

* fix failing specs

* Switch the buttons in form configuration component

* Create the section at the top of the list

* Instead of using UUID, use the name of the group as the key

* Add missing check for EE for section actions

* Remove angular components

* Use action list instead of a border box for left side panel

* Reduce the margin between the right side panel and sub header, add some space to the query table left side, span to the whole available space

* Show validation errors while updating and creating a section

* Use a danger dialog for reset to default

* Add a confirmation for removing the section

* Align items in the row

* Use test_selector instead of data-test-selector

* Create move_action in rb file

* Create move_action in rb file

* Simplify section component

* Simplify form configuration component

* Remove dialog for rename and delete section on missing EE

* Create a component for inactive attribute list

* Create a separate component for reset dialog

* Remove EE feedback dialog

* Remove form partial which is not needed anymore

* Remove unused js strings

* Update using update_via_turbo

* Remove form configuration rows controller

* Create a blanksalte component

* Fix failing specs

* Fix failing specs

* Fix failing specs

* Remove unused translation strings

* Align form configuration section routes with actual create flow

* Change section to group

* Change section to group in services and controllers

* Change section to group in en.yml

* Fix rubocop errors

* Move the query group persistence assertion from the JS feature spec
to the synchronous form configuration groups controller spec.

* Reuse query service result in embedded query build

* Keep inactive attribute filter after turbo list refresh

* Extract form configuration group edit state into form model

* Fix the failing test

* Potential fix for pull request finding 'CodeQL / Potentially uninitialized local variable'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* Rename inactive attribute component inputs

* Refine reset dialog wording for form configuration

* Use direct Turbo action for adding attribute groups

* Reuse generic filter-list controller for inactive attributes

* Remove focus impelementation in ts

* Group form configuration Stimulus controllers under one namespace

* Use turbo request service in form configuration controller

* Clarify legacy group key normalization in form config contract

* Replace inactive attribute list wrapper via turbo stream

* Extract duplicate untitled group key generation into Type::FormGroup.next_untitled_key

* Auto-generate untitled group name on create instead of returning an error

* Avoid mixed return types in form config group create service

* Extract shared form configuration group service behavior into concern

* Fix spacing for the last group and italic font for the placeholder rows

* Replace Angular no-results component with Primer Banner on form configuration page

* Hide dropped element immediately to prevent flickering before Turbo Stream response

* Reload type before rendering create error to prevent duplicate groups

* Await service initialization before use to prevent potential race condition

* Replace sleep calls with deterministic waits in form configuration spec

* Handle malformed JSON and invalid query errors gracefully in form configuration update

* Make query group label a clickable button and empty group hint italic

---------

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2026-05-13 12:56:18 +02:00

723 lines
21 KiB
Ruby

# frozen_string_literal: true
#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See COPYRIGHT and LICENSE files for more details.
#++
require "permitted_params/allowed_settings"
class PermittedParams
# This class intends to provide a method for all params hashes coming from the
# client and that are used for mass assignment.
#
# A method should look like the following:
#
# def name_of_the_params_key_referenced
# params.require(:name_of_the_params_key_referenced).permit(list_of_whitelisted_params)
# end
#
#
# A controller could use a permitted_params method like this
#
# model_instance.METHOD_USING_ASSIGMENT = permitted_params.name_of_the_params_key_referenced
#
attr_reader :params, :current_user
def initialize(params, current_user)
@params = params
@current_user = current_user
end
def self.permit(key, *params)
unless permitted_attributes.has_key?(key)
raise(ArgumentError, "no permitted params are configured for #{key}")
end
permitted_attributes[key].concat(params)
end
def attribute_help_text
params.require(:attribute_help_text).permit(*self.class.permitted_attributes[:attribute_help_text])
end
def ldap_auth_source
params.require(:ldap_auth_source).permit(*self.class.permitted_attributes[:ldap_auth_source])
end
def forum
params.require(:forum).permit(*self.class.permitted_attributes[:forum])
end
def forum?
params[:forum] ? forum : false
end
def forum_move
params.require(:forum).permit(*self.class.permitted_attributes[:move_to])
end
def color
params.require(:color).permit(*self.class.permitted_attributes[:color])
end
def color_move
params.require(:color).permit(*self.class.permitted_attributes[:move_to])
end
def custom_field
params.require(:custom_field).permit(*self.class.permitted_attributes[:custom_field])
end
def custom_action
whitelisted = params
.require(:custom_action)
.permit(*self.class.permitted_attributes[:custom_action])
whitelisted.merge(params[:custom_action].slice(:actions, :conditions).permit!)
end
def custom_field_type
params.require(:type)
end
def enumeration_type
params.fetch(:type, {})
end
def group
permitted_params = params.require(:group).permit(*self.class.permitted_attributes[:group])
permitted_params.merge(custom_field_values(:group))
end
def group_membership
params.permit(*self.class.permitted_attributes[:group_membership])
end
def update_work_package(args = {})
# used to be called new_work_package with an alias to update_work_package
permitted = permitted_attributes(:new_work_package, args)
permitted_params = params.require(:work_package).permit(*permitted)
permitted_params.merge(custom_field_values(:work_package))
end
def move_work_package(args = {})
permitted = permitted_attributes(:move_work_package, args)
permitted_params = params.permit(*permitted)
permitted_params
.merge(custom_field_values(required: false))
.merge(type_id: params[:new_type_id],
project_id: params[:new_project_id],
journal_notes: params[:notes])
end
def member
params.require(:member).permit(*self.class.permitted_attributes[:member])
end
def oauth_application
params.require(:application).permit(*self.class.permitted_attributes[:oauth_application]).tap do |app_params|
scopes = app_params[:scopes]
if scopes.present?
app_params[:scopes] = scopes.compact_blank.join(" ")
end
app_params
end
end
def projects_type_ids
params.require(:project).require(:type_ids).map(&:to_i).select { |x| x > 0 }
end
def query
# there is a weird bug in strong_parameters gem which makes the permit call
# on the sort_criteria pattern return the sort_criteria-hash contents AND
# the sort_criteria hash itself (again with content) in the same hash.
# Here we try to circumvent this
p = params.require(:query).permit(*self.class.permitted_attributes[:query])
p[:sort_criteria] = params
.require(:query)
.permit(sort_criteria: { "0" => [], "1" => [], "2" => [] })
p[:sort_criteria].delete :sort_criteria
p
end
def role
params.require(:role).permit(*self.class.permitted_attributes[:role])
end
def role?
params[:role] ? role : false
end
def status
params.require(:status).permit(*self.class.permitted_attributes[:status])
end
def settings(extra_permitted_filters = nil)
params.require(:settings).permit(*AllowedSettings.filters, *extra_permitted_filters)
end
def user(additional_params = [])
if params[:user].present?
permitted_params = params.require(:user).permit(*self.class.permitted_attributes[:user] + additional_params)
permitted_params.merge(custom_field_values(:user))
else
# This happens on the Profile page for LDAP user, no "user" hash is sent.
{}.merge(custom_field_values(:user, required: false))
end
end
def placeholder_user
params.require(:placeholder_user).permit(*self.class.permitted_attributes[:placeholder_user])
end
def user_register_via_omniauth
permitted_params = params
.require(:user)
.permit(:login, :firstname, :lastname, :mail, :language)
permitted_params.merge(custom_field_values(:user))
end
def user_create_as_admin(external_authentication,
change_password_allowed,
additional_params = [])
additional_params << :ldap_auth_source_id unless external_authentication
if current_user.admin?
additional_params << :force_password_change if change_password_allowed
additional_params << :admin
end
additional_params << :login if Users::BaseContract.new(User.new, current_user).writable?(:login)
user additional_params
end
def user_invitation
params
.require(:user_invitation)
.permit(:project_id, :principal_type, :id_or_email, :role_id, :message)
end
def type(args = {})
permitted = permitted_attributes(:type, args)
type_params = params.require(:type)
whitelisted = type_params.permit(*permitted)
if type_params[:attribute_groups]
whitelisted[:attribute_groups] = type_params[:attribute_groups]
end
whitelisted
end
def type_move
params.require(:type).permit(*self.class.permitted_attributes[:move_to])
end
def enumerations_move
params.require(:enumeration).permit(*self.class.permitted_attributes[:move_to])
end
def search
params.permit(*self.class.permitted_attributes[:search])
end
def wiki_page_rename
permitted = permitted_attributes(:wiki_page)
params.require(:page).permit(*permitted)
end
def wiki_page
permitted = permitted_attributes(:wiki_page)
params.require(:page).permit(*permitted)
end
def pref
params.fetch(:pref, {}).permit(:time_zone,
:theme,
:increase_theme_contrast,
:force_light_theme_contrast,
:force_dark_theme_contrast,
:comments_sorting,
:disable_keyboard_shortcuts,
:warn_on_leaving_unsaved,
:auto_hide_popups,
immediate_reminders: %i[mentioned personal_reminder],
daily_reminders: [:enabled, { times: [] }],
workdays: [],
pause_reminders: %i[enabled date_range])
end
def notification_setting_email_alerts
params.fetch(:notification_setting, {}).permit(*NotificationSetting.email_settings)
end
def notification_setting_participating
params.fetch(:notification_setting, {}).permit(:assignee, :responsible, :shared)
end
def notification_setting_non_participating
params.fetch(:notification_setting, {}).permit(*NotificationSetting.non_participating_settings)
end
def notification_setting_project
params.fetch(:notification_setting, {}).permit(
:project_id,
:assignee, :responsible, :shared,
*NotificationSetting.non_participating_settings
)
end
def project
whitelist = params.require(:project).permit(:name,
:description,
:public,
:responsible_id,
:identifier,
:project_type_id,
:parent_id,
:templated,
:status_code,
:status_explanation,
work_package_custom_field_ids: [],
type_ids: [],
enabled_module_names: [],
custom_comments: {})
whitelist
.tap { nilify_params!(it, :status_code) }
.merge(custom_field_values(:project))
end
def new_project
params
.expect(project: %i[name description parent_id workspace_type identifier] + [{ custom_comments: {} }])
.merge(custom_field_values(:project))
end
def copy_project_options
copy_options_params = params.expect(copy_options: [[{ dependencies: [] }], :send_notifications])
copy_options_params[:dependencies].compact_blank!
copy_options_params
end
def project_status
params
.expect(project: %i[status_code status_explanation])
.tap { nilify_params!(it, :status_code) }
end
def project_phase
params.require(:project_phase).permit(%i[start_date finish_date])
end
def project_custom_field_project_mapping
params.require(:project_custom_field_project_mapping)
.permit(*self.class.permitted_attributes[:project_custom_field_project_mapping])
.merge(params.permit(:value))
end
def news
params.require(:news).permit(:title, :summary, :description)
end
def category
params.require(:category).permit(:name, :assigned_to_id)
end
def version
permitted_params = params.fetch(:version, {}).permit(:name,
:description,
:effective_date,
:due_date,
:start_date,
:wiki_page_title,
:status,
:sharing)
permitted_params.merge(custom_field_values(:version, required: false))
end
def comment
params.require(:comment).permit(:commented, :author, :comments)
end
# `params.fetch` and not `require` because the update controller action associated
# with this is doing multiple things, therefore not requiring a message hash
# all the time.
def message(project = nil)
# TODO: Move this distinction into the contract where it belongs
if project && current_user.allowed_in_project?(:edit_messages, project)
params.fetch(:message, {}).permit(:subject, :content, :forum_id, :locked, :sticky)
else
params.fetch(:message, {}).permit(:subject, :content, :forum_id)
end
end
def attachments
params.permit(attachments: %i[file description id])["attachments"]
end
def enumerations # rubocop:disable Metrics/AbcSize
acceptable_params = %i[active is_default move_to name reassign_to_i
parent_id custom_field_values reassign_to_id]
whitelist = ActionController::Parameters.new
# Sometimes we receive one enumeration, sometimes many in params, hence
# the following branching.
if params[:enumerations].present?
params[:enumerations].each_key do |enum|
enum.tap do
whitelist[enum] = {}
acceptable_params.each do |param|
# We rely on enum being an integer, an id that is. This will blow up
# otherwise, which is fine.
next if params[:enumerations][enum][param].nil?
whitelist[enum][param] = params[:enumerations][enum][param]
end
end
end
else
params[:enumeration].each_key do |key|
whitelist[key] = params[:enumeration][key]
end
end
whitelist.permit!
end
def time_entry_activities_project
params.permit(time_entry_activities_project: %i[activity_id active]).require(:time_entry_activities_project)
end
def watcher
params.require(:watcher).permit(:watchable, :user, :user_id)
end
def reply
params.require(:reply).permit(:content, :subject)
end
def wiki
params.require(:wiki).permit(:start_page)
end
def repository_diff
params.permit(:rev, :rev_to, :project, :action, :controller)
end
def membership
params.require(:membership).permit(*self.class.permitted_attributes[:membership])
end
protected
def custom_field_values(key = nil, required: true)
values = build_custom_field_values(key, required:)
# only permit values following the schema
# 'id as string' => 'value as string'
values.select! { |k, v| k.to_i > 0 && (v.is_a?(String) || v.is_a?(Array)) }
# Reject blank values from include_hidden select fields
values.each_value { |v| v.compact_blank! if v.is_a?(Array) }
values.empty? ? {} : { "custom_field_values" => values.permit! }
end
def permitted_attributes(key, additions = {})
merged_args = { params:, current_user: }.merge(additions)
self.class.permitted_attributes[key].filter_map do |permission|
if permission.respond_to?(:call)
permission.call(merged_args)
else
permission
end
end
end
def self.permitted_attributes
@permitted_attributes ||= begin
params = {
attribute_help_text: %i(
type
attribute_name
help_text
caption
),
ldap_auth_source: %i(
name
host
port
tls_mode
account
account_password
base_dn
filter_string
onthefly_register
attr_login
attr_firstname
attr_lastname
attr_mail
attr_admin
verify_peer
tls_certificate_string
),
forum: %i(
name
description
),
color: %i(
name
hexcode
move_to
),
custom_action: %i(
name
description
move_to
),
custom_field: [
:editable,
:field_format,
:formula,
:is_filter,
:is_for_all,
:is_required,
:max_length,
:min_length,
:move_to,
:name,
:possible_values,
:regexp,
:searchable,
:admin_only,
:default_value,
:multi_value,
:content_right_to_left,
:custom_field_section_id,
:allow_non_open_versions,
:has_comment,
{ custom_options_attributes: %i(id value default_value position) },
{ type_ids: [] }
],
enumeration: %i(
active
is_default
move_to
name
reassign_to_id
),
group: %i[
lastname
parent_id
],
membership: [
:project_id,
{ role_ids: [] }
],
group_membership: [
:membership_id,
{ membership: [
:project_id,
{ role_ids: [] }
] }
],
member: [
{ role_ids: [] }
],
new_work_package: [
:assigned_to_id,
{ attachments: %i[file description] },
:category_id,
:description,
:done_ratio,
:due_date,
:estimated_hours,
:version_id,
:budget_id,
:parent_id,
:priority_id,
:remaining_hours,
:responsible_id,
:sprint_id,
:start_date,
:status_id,
:type_id,
:subject,
Proc.new do |args|
# avoid costly allowed_in_project? if the param is not there at all
if args[:params]["work_package"]&.has_key?("watcher_user_ids") &&
args[:current_user].allowed_in_project?(:add_work_package_watchers, args[:project])
{ watcher_user_ids: [] }
end
end,
# attributes unique to :new_work_package
:journal_notes,
:lock_version
],
move_work_package: %i[
assigned_to_id
responsible_id
start_date
due_date
status_id
version_id
priority_id
],
oauth_application: [
:name,
:redirect_uri,
:confidential,
:enabled,
:client_credentials_user_id,
{ scopes: [] }
],
placeholder_user: %i(
name
),
project_type: [
:name,
{ type_ids: [] }
],
project_custom_field_project_mapping: %i(
project_id
custom_field_id
custom_field_section_id
include_sub_projects
),
query: %i(
name
display_sums
public
group_by
),
role: [
:name,
:assignable,
:move_to,
{ permissions: [] }
],
search: %i(
q
offset
previous
scope
filter
submit
),
status: %i(
name
color_id
default_done_ratio
excluded_from_totals
is_closed
is_default
is_readonly
move_to
),
type: [
:name,
:is_in_roadmap,
:is_milestone,
:is_default,
:color_id,
:default,
:description,
{ project_ids: [] }
],
user: %i(
firstname
lastname
mail
mail_notification
language
custom_fields
),
wiki_page: %i(
title
parent_id
redirect_existing_links
text
lock_version
journal_notes
),
move_to: [:move_to]
}
# Accept new parameters, defaulting to an empty array
params.default = []
params
end
end
## Add attributes as permitted attributes (only to be used by the plugins plugin)
#
# attributes should be given as a Hash in the form
# {key: [:param1, :param2]}
def self.add_permitted_attributes(attributes)
attributes.each_pair do |key, attrs|
permitted_attributes[key] += attrs
end
end
def keys_whitelisted_by_list(hash, list)
(hash || {})
.keys
.select { |k| list.any? { |whitelisted| whitelisted.to_s == k.to_s || whitelisted === k } }
end
private
def build_custom_field_values(key, required:)
# When the key is false, it means we do not have a parent key,
# so we are searching the whole params hash.
key_to_fetch = key || :custom_field_values
# a hash of arbitrary values is not supported by strong params
# thus we do it by hand
object = required ? params.require(key_to_fetch) : params.fetch(key_to_fetch, {})
values = key ? object[:custom_field_values] : object
values || ActionController::Parameters.new
end
def nilify_params!(hash, *keys)
keys.each { |k| hash[k] = hash[k].presence if hash.key?(k) }
hash
end
end