Commit Graph

30 Commits

Author SHA1 Message Date
Alexander Brandon Coles e8767481e9 [#70166] Fix accessibility errors found by ERB Lint (#21503)
* Fix GitHub/NoTitleAttribute, LinkHasHref errors

- Replaces `title` attribute with `aria-label` for interactive elements.
- Removes `title` from non-interactive elements.
- Converts `<a>` tags without proper `href` to `<button>` elements,
  using Primer `Button`/`IconButton` where possible.

# Conflicts:
#	app/views/custom_fields/_custom_options.html.erb
#	spec/features/admin/custom_fields/shared_custom_field_expectations.rb
#	spec/features/admin/custom_fields/work_packages/list_spec.rb

* Fix Autocomplete missing errors

* Fix GitHub/NoPositiveTabIndex errors

Removes all positive `tabindex` values.

* Fix Rails/LinkToBlank errors

* Replace toast with Primer Banner on LDAP form

* Add frozen_string_literal

* Ignore erb lint for deprecated files

* Fix linting errors in repository module

* Fix linting errors in budgets and custom actions

* Fix linting errors in member form and 2fa

* Fix linting errors in mcost types and wiki help and storages

* Fix linting errors in multi select filters, ifc viewer, and unsupported browser banner

* Fix failing spec

* Use Primer banner instead of op-toast where ever it is possible

* Use octicon instead of op_icon

* Fix failing tests

* Use no-decoration-on-hover for button links and change the button with only an icon to primer icon button

* Keep webhook response modal activation selector class-based

* use icon button for edit of hourly rate

---------

Co-authored-by: Behrokh Satarnejad <b.satarnejad@openproject.com>
2026-05-07 10:31:10 +02:00
Henriette Darge c814a59bd4 Correctly show the blue info banner when no items are present. Further, show an error message when trying to delete the last custom option 2026-03-09 10:56:04 +01:00
Ivan Kuchin 2d2fccce8c add has_comment to field formats using primer form 2026-02-25 16:00:17 +01:00
Henriette Darge 6e228dc06a Fine-tune the shown forms of custom fields & fix tests 2026-02-23 09:08:21 +01:00
Ivan Kuchin 727809562f test weighted item list custom field format fields 2026-01-14 17:52:59 +01:00
Ivan Kuchin f6a878775a cleanup comments in custom field format shared spec 2026-01-14 17:52:58 +01:00
Ivan Kuchin 4f387ec1da test calculated value custom field format fields 2026-01-14 17:52:58 +01:00
Ivan Kuchin 16f518ee86 expect editable field for user custom field 2026-01-14 17:52:57 +01:00
Ivan Kuchin 0dcc6d3d11 expect is filter and content right to left fields for work package custom field 2026-01-14 17:52:57 +01:00
Ivan Kuchin af78060e11 expect searchable field for work package and project custom field 2026-01-14 17:52:56 +01:00
Ivan Kuchin b0bf2748e4 expect admin only field for user and project custom field 2026-01-14 17:52:56 +01:00
Ivan Kuchin c0e671f68e expect is for all field for work package and project custom field 2026-01-14 17:52:55 +01:00
Ivan Kuchin ef015df588 expect section field for project custom field 2026-01-14 17:52:55 +01:00
Ivan Kuchin d9703fa46f singularize type in custom field format shared spec 2026-01-14 17:52:54 +01:00
Ivan Kuchin c556643232 split field checks into multiple switches 2026-01-14 17:52:54 +01:00
Ivan Kuchin 0b88e29799 check presence of name field for all custom field formats 2026-01-14 17:52:54 +01:00
Ivan Kuchin c5a5bad6de combine expectations for Text, Integer and Float field formats 2026-01-14 17:52:53 +01:00
Ivan Kuchin eb063ccb03 fix expecations of custom field hierarchy field format 2026-01-14 17:52:52 +01:00
Ivan Kuchin e3b9f70e27 add link field format checks 2026-01-14 17:52:51 +01:00
Ivan Kuchin ab2019471b move click on field format selector outside of switch 2026-01-14 17:52:50 +01:00
Ivan Kuchin 237f026060 move switch for field formats inside single test to reduce repetition 2026-01-14 17:52:50 +01:00
Ivan Kuchin fe212fee56 test presence of fields/rich_text_fields instead of just labels, but absence of just labels in custom field format shared examples 2026-01-14 17:52:50 +01:00
Ivan Kuchin 0826a2b56d test presence of field labels or fieldsets instead of just texts in custom field format shared examples 2026-01-14 17:52:49 +01:00
Ivan Kuchin 5733b4a33a better dsl (expect_page_to_have) in custom field format shared examples 2026-01-14 17:52:49 +01:00
Ivan Kuchin 0009cfd1df adapt shared custom field expectations to test project attributes too 2026-01-14 17:52:46 +01:00
Ivan Kuchin fe31eda259 delete Page suffix for few feature spec page helpers that had it 2026-01-08 17:27:35 +01:00
ulferts a24f6bc414 consolidate custom field form and component 2025-12-17 17:12:45 +01:00
Eric Schubert ab2d9d1aaa [#59359] amended feature spec expectations 2025-09-29 14:53:56 +02:00
ulferts d6caec6c55 only display hierarchy option in dropdown if ee permits 2025-06-23 12:00:35 +02:00
ulferts f8fad16c77 move and adapt custom field feature specs 2025-06-23 12:00:33 +02:00