delete Page suffix for few feature spec page helpers that had it

This commit is contained in:
Ivan Kuchin
2025-12-18 21:06:41 +01:00
parent b660938cf0
commit fe31eda259
20 changed files with 27 additions and 27 deletions
@@ -29,7 +29,7 @@
# ++
RSpec.shared_examples_for "list custom fields" do |type|
let(:cf_page) { Pages::CustomFields::IndexPage.new }
let(:cf_page) { Pages::CustomFields::Index.new }
let(:user) { create(:admin) }
current_user { user }
@@ -94,7 +94,7 @@ RSpec.shared_examples_for "list custom fields" do |type|
end
RSpec.shared_examples_for "hierarchy custom fields on index page" do |type|
let(:cf_page) { Pages::CustomFields::IndexPage.new }
let(:cf_page) { Pages::CustomFields::Index.new }
let(:user) { create(:admin) }
current_user { user }
@@ -126,7 +126,7 @@ RSpec.shared_examples_for "hierarchy custom fields on index page" do |type|
end
RSpec.shared_examples_for "expected fields for the custom field's format" do |type, format|
let(:cf_page) { Pages::CustomFields::IndexPage.new }
let(:cf_page) { Pages::CustomFields::Index.new }
let(:user) { create(:admin) }
current_user { user }
@@ -34,8 +34,8 @@ require_relative "../shared_custom_field_expectations"
RSpec.describe "List custom fields edit", :js do
shared_let(:admin) { create(:admin) }
let(:index_cf_page) { Pages::CustomFields::IndexPage.new }
let(:new_cf_page) { Pages::CustomFields::NewPage.new }
let(:index_cf_page) { Pages::CustomFields::Index.new }
let(:new_cf_page) { Pages::CustomFields::New.new }
current_user { admin }
@@ -33,7 +33,7 @@ require "support/pages/custom_fields/index_page"
RSpec.describe "custom fields", :js do
shared_let(:user) { create(:admin) }
let(:cf_page) { Pages::CustomFields::IndexPage.new }
let(:cf_page) { Pages::CustomFields::Index.new }
current_user { user }
@@ -33,7 +33,7 @@ require "support/pages/custom_fields/index_page"
RSpec.describe "custom fields", :js do
let(:user) { create(:admin) }
let(:cf_page) { Pages::CustomFields::IndexPage.new }
let(:cf_page) { Pages::CustomFields::Index.new }
current_user { user }
@@ -33,7 +33,7 @@ require "support/pages/custom_fields/index_page"
RSpec.describe "custom fields", :js do
let(:user) { create(:admin) }
let(:cf_page) { Pages::CustomFields::IndexPage.new }
let(:cf_page) { Pages::CustomFields::Index.new }
current_user { user }
@@ -33,9 +33,9 @@ require_relative "../shared_custom_field_expectations"
RSpec.describe "work package custom fields of type hierarchy", :js do
shared_let(:admin) { create(:admin) }
let(:custom_field_index_page) { Pages::CustomFields::IndexPage.new }
let(:new_custom_field_page) { Pages::CustomFields::NewPage.new }
let(:hierarchy_page) { Pages::CustomFields::HierarchyPage.new }
let(:custom_field_index_page) { Pages::CustomFields::Index.new }
let(:new_custom_field_page) { Pages::CustomFields::New.new }
let(:hierarchy_page) { Pages::CustomFields::Hierarchy.new }
current_user { admin }
@@ -33,7 +33,7 @@ require "support/pages/custom_fields/index_page"
RSpec.describe "custom fields", :js do
let(:user) { create(:admin) }
let(:cf_page) { Pages::CustomFields::IndexPage.new }
let(:cf_page) { Pages::CustomFields::Index.new }
current_user { user }
@@ -32,7 +32,7 @@ require "spec_helper"
RSpec.describe "Link custom fields edit", :js do
shared_let(:admin) { create(:admin) }
let(:cf_page) { Pages::CustomFields::IndexPage.new }
let(:cf_page) { Pages::CustomFields::Index.new }
current_user { admin }
@@ -33,7 +33,7 @@ require "support/pages/custom_fields/index_page"
RSpec.describe "work package list custom fields", :js do
let(:user) { create(:admin) }
let(:cf_page) { Pages::CustomFields::IndexPage.new }
let(:cf_page) { Pages::CustomFields::Index.new }
before do
login_as user
@@ -5,7 +5,7 @@ require "support/pages/custom_fields/index_page"
RSpec.describe "custom fields", :js do
let(:user) { create(:admin) }
let(:cf_page) { Pages::CustomFields::IndexPage.new }
let(:cf_page) { Pages::CustomFields::Index.new }
let(:editor) { Components::WysiwygEditor.new "#custom_field_form" }
let(:type) { create(:type_task) }
let!(:project) { create(:project, enabled_module_names: %i[work_package_tracking], types: [type]) }
@@ -33,7 +33,7 @@ require "spec_helper"
RSpec.describe "Multi-value custom fields creation", :js, :selenium do
shared_let(:admin) { create(:admin) }
let(:index_cf_page) { Pages::CustomFields::IndexPage.new }
let(:index_cf_page) { Pages::CustomFields::Index.new }
current_user { admin }
@@ -32,8 +32,8 @@ require "spec_helper"
RSpec.describe "User custom fields edit", :js do
shared_let(:admin) { create(:admin) }
let(:index_cf_page) { Pages::CustomFields::IndexPage.new }
let(:new_cf_page) { Pages::CustomFields::NewPage.new }
let(:index_cf_page) { Pages::CustomFields::Index.new }
let(:new_cf_page) { Pages::CustomFields::New.new }
current_user { admin }
@@ -33,7 +33,7 @@ require "support/pages/custom_fields/index_page"
RSpec.describe "custom fields", :js do
let(:user) { create(:admin) }
let(:cf_page) { Pages::CustomFields::IndexPage.new }
let(:cf_page) { Pages::CustomFields::Index.new }
let(:for_all_cf) { create(:list_wp_custom_field, is_for_all: true) }
let(:project_specific_cf) { create(:integer_wp_custom_field) }
let(:work_package) do
@@ -17,7 +17,7 @@ end
RSpec.describe "Reordering custom options of a list custom field", :js, :selenium do
let(:user) { create(:admin) }
let(:cf_page) { Pages::CustomFields::IndexPage.new }
let(:cf_page) { Pages::CustomFields::Index.new }
let!(:custom_field) do
create(
+1 -1
View File
@@ -166,7 +166,7 @@ RSpec.describe "random password generation", :js do
end
context "as a user on his my page" do
let(:user_page) { Pages::My::PasswordPage.new }
let(:user_page) { Pages::My::Password.new }
let(:third_password) { "third_Password!123" }
before do
@@ -28,13 +28,13 @@
# See COPYRIGHT and LICENSE files for more details.
#++
require "support/pages/custom_fields/index_page"
require "support/pages/custom_fields/index"
module Pages
module Admin
module Settings
module ProjectCustomFields
class Index < ::Pages::CustomFields::IndexPage
class Index < ::Pages::CustomFields::Index
def path
"/admin/settings/project_custom_fields"
end
@@ -32,7 +32,7 @@ require "support/pages/page"
module Pages
module CustomFields
class HierarchyPage < Page
class Hierarchy < Page
def path
case @tab
when "items"
@@ -32,7 +32,7 @@ require "support/pages/page"
module Pages
module CustomFields
class IndexPage < Page
class Index < Page
def path
"/custom_fields"
end
@@ -32,7 +32,7 @@ require "support/pages/page"
module Pages
module CustomFields
class NewPage < Page
class New < Page
def path
"/custom_fields/new?type=#{@type}"
end
@@ -32,7 +32,7 @@ require "support/pages/page"
module Pages
module My
class PasswordPage < ::Pages::Page
class Password < ::Pages::Page
def path
"/my/password"
end