Commit Graph

212 Commits

Author SHA1 Message Date
OpenProject Actions CI 7e1c003ba7 Merge branch 'release/17.4' into dev 2026-05-20 06:43:24 +00:00
OpenProject Actions CI 82c65d6a27 Merge branch 'release/17.3' into release/17.4 2026-05-20 06:42:24 +00:00
Oliver Günther ac4794ad8f Use customizable? to check for non-customizable journables 2026-05-19 18:32:28 +02:00
Oliver Günther 7c5d5e3e66 Actually add participants to history of meeting and to journal details 2026-05-18 20:10:00 +02:00
as-op ed2881f594 [#74746] Avoid additional journal background jobs to be started by Jira import job
https://community.openproject.org/wp/74746
2026-05-07 14:59:44 +02:00
Ivan Kuchin 70c21d1255 Merge pull request #22214 from opf/bug/72823-refactor-projectcustomfields-loadservice
Bug/72823 refactor projectcustomfields loadservice
2026-03-10 15:13:16 +01:00
Ivan Kuchin 7296cdd4cf add missing check to custom_comment_for and custom_comment_changes 2026-03-09 17:05:37 +01:00
Ivan Kuchin fa69a60a44 bring order to custom values both in the relation and project custom fields load service 2026-03-05 15:57:33 +01:00
Ivan Kuchin 807c1bc6d5 Use stringify_keys instead of transform_keys(&:to_s)
Co-authored-by: Dombi Attila <83396+dombesz@users.noreply.github.com>
2026-02-25 20:07:28 +01:00
Ivan Kuchin 6a8975b419 handle delete custom fields in human attribute name 2026-02-25 20:07:26 +01:00
Ivan Kuchin 5bdf9f9874 don't use local variables automatically populated for named capture groups 2026-02-25 20:07:26 +01:00
Ivan Kuchin 73803c59cd add admin_only_allowed setting to acts_as_customizable 2026-02-25 20:07:13 +01:00
Ivan Kuchin 51bab06de3 rework setting custom comments to allow setting them also for inacessible custom fields
This should be blocked on contract level
2026-02-25 20:07:09 +01:00
Ivan Kuchin 73f941b11e handle custom comment human attribute name 2026-02-25 20:07:08 +01:00
Ivan Kuchin d5c0b9d84e set comments and show changes even if custom field doesn't allow comments
Otherwise contract doesn't know that there was an attempt to set
attribute
2026-02-25 20:07:08 +01:00
Ivan Kuchin c16dcaf52d add accessors for comments also when has_comment is false 2026-02-25 20:07:07 +01:00
Ivan Kuchin ddcbd6adc3 always return comment_attribute_name even when has_comment is false 2026-02-25 20:07:07 +01:00
Ivan Kuchin ca452da4bb add accessors for custom comments
It was needed by project create contract spec
2026-02-25 20:07:07 +01:00
Ivan Kuchin ba4cc09ffe move custom_comment_for to acts as customizable 2026-02-25 20:07:01 +01:00
Ivan Kuchin 875f600ae3 return changes to comments from custom_field_changes and changed_with_custom_fields 2026-02-25 20:06:59 +01:00
Ivan Kuchin 57a4a894bd include acts as customizable methods at start of call 2026-02-25 20:06:59 +01:00
Ivan Kuchin 09d176c107 allow to assign comments in a way similar to values 2026-02-25 20:06:59 +01:00
Ivan Kuchin 574857a6ba move adding custom_comments relation to acts_as_customizable and mark for autosave 2026-02-25 16:00:32 +01:00
Ivan Kuchin a7854fe6f2 move configuration for ability to have custom comments to acts_as_customizable 2026-02-25 16:00:32 +01:00
Ivan Kuchin 26142f1af8 transform keys to strings instead of converting to hash with indifferent access 2026-02-25 16:00:29 +01:00
Ivan Kuchin b188bda6cb move admin_only check of custom field related activity to the query
This should be more efficient and will ensure "The changes were
retracted" message shown when all changes are hidden
2026-02-25 16:00:26 +01:00
Ivan Kuchin c75b885a63 add custom comment changes 2026-02-25 16:00:25 +01:00
Ivan Kuchin bf1182ba7c refactor custom_field_values= to calm down rubocop 2026-02-05 14:15:20 +01:00
Ivan Kuchin 7e91103076 change custom_values_for_custom_field to accept custom field or id and as positional argument 2026-02-05 14:15:19 +01:00
Ivan Kuchin 9b7df9aef3 add custom_field_class method for customized models 2026-02-05 14:15:13 +01:00
OpenProject Actions CI ecf6b3752a Merge branch 'release/17.0' into dev 2025-12-09 03:48:44 +00:00
Oliver Günther 3aa5275567 Merge pull request #21214 from opf/feat/workflow-work-package
Recreate artifact on status change
2025-12-08 14:08:55 +01:00
Klaus Zanders e5dab38430 Add :validate_except_on, :validate_if, :validate_unless options for acts_as_customizable 2025-11-28 12:25:21 +01:00
Dombi Attila 53b0c14191 Skip validating custom fields when creating a project from a template. 2025-11-19 20:14:10 +02:00
Klaus Zanders 4ea48b0ee4 Correctly handle invisible changes 2025-11-14 12:19:08 +01:00
Klaus Zanders 6fc4dfb0aa Build correct changeset for multi-value custom fields 2025-11-14 12:14:35 +01:00
Dombi Attila bc11699ddd Change custom_value_for to return values based on the multi_value? only 2025-11-12 20:25:17 +02:00
Dombi Attila 652551d537 [#68040] Switching a multi select list cf to a single select cf of projects breaks opening the editing modal on the overview page
https://community.openproject.org/work_packages/68040

Change the custom_value_for method signature to always use a custom field.
2025-11-12 20:25:16 +02:00
Dombi Attila 513792ef89 [#67839] "Required for all projects" should not require a value to be set for a Calculated Value
https://community.openproject.org/work_packages/67839
2025-11-03 13:48:00 +02:00
ulferts edf3c709e3 Merge remote-tracking branch 'origin/dev' into feature/63550-allow-editing-of-individual-work-package-project-attributes-even-if-certain-other-attributes-are-invalid-eg-required-field-empty 2025-10-22 18:17:40 +02:00
Alexander Brandon Coles 7f44b74532 Merge pull request #19980 from opf/code-maintenance/frozen-strings-lib_static
Freeze string literals in lib_static
2025-10-21 16:42:23 +01:00
Tobias Dillmann 53405a79fb [#64523] Minor spelling corrections
Noted these while reading through ActsAsCustomizable
2025-10-17 19:31:54 +02:00
Dombi Attila df3fce73b7 Do not use a set, just make the custom_values_to_validate uniq. 2025-10-14 12:01:58 +02:00
Dombi Attila 9181281732 Validate custom fields in all the custom actions that are custom field related. 2025-10-14 12:01:58 +02:00
Dombi Attila f90b2fee27 Validate changed custom fields when executing custom actions 2025-10-14 12:01:58 +02:00
Dombi Attila 0b75d47bdb Fix specs, activate all cusotm fields validations on the work packages update api endpoint. 2025-10-14 12:01:58 +02:00
Dombi Attila 0be5920b65 Add User invite and ldap registration specs required custom field specs 2025-10-14 12:01:58 +02:00
Dombi Attila 84e95873fd Wp and group aac spec works 2025-10-14 12:01:58 +02:00
Dombi Attila 33306505b8 Remove unused code 2025-10-14 12:01:58 +02:00
Dombi Attila 2aae862d8a [#63550] Allow editing of individual work package/project attributes even if certain other attributes are invalid (eg. required field empty)
https://community.openproject.org/work_packages/63550
2025-10-14 12:01:58 +02:00