references/openproject
1
0
Fork 0
mirror of https://github.com/opf/openproject.git synced 2026-06-14 03:30:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor custom_field_values= to calm down rubocop

Browse Source
This commit is contained in:
Ivan Kuchin
2026-02-04 19:48:46 +01:00
parent 13bfd7cf24
commit bf1182ba7c
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib_static/plugins/acts_as_customizable/lib/acts_as_customizable.rb
+11 -7
View File
@@ -126,17 +126,13 @@ module Redmine
def custom_field_values=(values)
return unless values.is_a?(Hash) && values.any?
values.with_indifferent_access.each do |custom_field_id, val|
values.with_indifferent_access.each do |custom_field_id, new_values|
existing_cv_by_value = custom_values_for_custom_field(custom_field_id, all: true)
.group_by(&:value)
.transform_values(&:first)
new_values = Array(val).map { |v| v.respond_to?(:id) ? v.id.to_s : v.to_s }
next if existing_cv_by_value.empty?
if existing_cv_by_value.any?
assign_new_values custom_field_id, existing_cv_by_value, new_values
delete_obsolete_custom_values existing_cv_by_value, new_values
handle_minimum_custom_value custom_field_id, existing_cv_by_value, new_values
end
update_custom_value(custom_field_id, existing_cv_by_value, new_values)
end
end
@@ -435,6 +431,14 @@ module Redmine
touch if !saved_changes? && custom_values.loaded? && (custom_values.any?(&:saved_changes?) || custom_value_destroyed)
end
def update_custom_value(custom_field_id, existing_cv_by_value, new_values)
new_values = Array(new_values).map { |v| v.respond_to?(:id) ? v.id.to_s : v.to_s }
assign_new_values(custom_field_id, existing_cv_by_value, new_values)
delete_obsolete_custom_values(existing_cv_by_value, new_values)
handle_minimum_custom_value(custom_field_id, existing_cv_by_value, new_values)
end
def assign_new_values(custom_field_id, existing_cv_by_value, new_values)
(new_values - existing_cv_by_value.keys).each do |new_value|
add_custom_value(custom_field_id, new_value)