Commit Graph

47 Commits

Author SHA1 Message Date
Christophe Bliard 4c2a9d0aa8 Enable RSpec zero monkey patching mode
The plan for RSpec 4.0 is to disable monkey patching.

See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.
2023-05-31 19:22:29 +02:00
Dombi Attila 5fa819a54b Remove enterprise_token_helper.rb and the with_enterprise_token method 2023-05-08 08:08:30 +02:00
Markus Kahl faafa84608 allow to limit self registration for openid connect providers 2023-04-20 14:39:26 +02:00
Christophe Bliard 85b3258a29 Autocorrect with some rubocop cops
RSpec/Rails/InferredSpecType and Style/RedundantConstantBase

rubocop --autocorrect-all --only RSpec/Rails/InferredSpecType,Style/RedundantConstantBase spec modules/*/spec
2023-01-13 14:28:59 +01:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Eric Schubert c8f1e16005 [#43684] migrated op-modal to spot-modal (#11172)
* [#43684] migrated op-modal to spot-modal

- https://community.openproject.org/work_packages/43684
- amended styles
- removed "modal--title"
- removed header component
- removed closing icon
- fixed backdrop click
- removed jquery from modal service

* [#43684] removed unused styling

- fixed some inconsitencies
- readded removed icon
- removed listener on close button

* [#43684] combined spot-action-bar

- used spot-action-bar in combination with spot-modal--footer
- fixed some styling in action bar

* [#43684] replaced more op-modal

- moved spec selectors to spot-modal
- replaced found op-modal in html templates

* [#43684] add no margin to old buttons in new dialogs

- added mobile modal behavior
- fixed some feature spec selectors

* [#43684] added modal close on mobile resolutions

* [#43684] fixed PR issues

- removed old css classes from html
- fixed feature spec click
- readded tour trigger on modal cancel

* when clicking outside the modal it will be closed instaed of clicking on a close button

* exclude _center class from spot-modal sass file itself and add it to the component style sheet

* Words should be break in any case like when there is no space there

* remove unnecessary classes that never used like _fullscreen and _cente, remove _limited-height class to make all the modal look the same

Co-authored-by: bsatarnejad <b.satarnejad@gmail.com>
Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>
2022-08-29 10:53:41 +00:00
Christophe Bliard e160ba0555 Fix spec path to end with *_spec.rb 2022-06-03 09:51:24 +02:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
ulferts 6ad2713141 avoid autoloading ApplicationHelper during initialization 2022-04-04 16:04:46 +02:00
Christophe Bliard a33524ef6d remove ruby magic comment for utf-8
ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless
2022-03-10 19:36:58 +01:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Oliver Günther f08bea3467 Remove FactoryBot.* prefix where applicable 2022-01-25 08:19:06 +01:00
ulferts ac14e80220 fix sso icon position (#9960)
* fix sso icon position

* Add to auth_plugins sass

* rely on modifier class for icon padding

Co-authored-by: Oliver Günther <mail@oliverguenther.de>
2021-12-07 16:25:28 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
Oliver Günther 6a75cc9a30 Merge remote-tracking branch 'origin/release/11.4' into dev 2021-08-02 09:15:18 +02:00
Henriette Darge 8917a928e4 Change google logo and take care that auth plugin logos are correctly shown 2021-07-27 13:36:24 +02:00
luzpaz 2ae53bd252 Fix typos in user facing and non-user facing code (#9497)
* Fix typos in user facing and non-user facing code

Found via `codespell -q 3 -S ./config/locales -L ba,nd,parms,sur,varius`

* Fix strings in specs
2021-07-21 17:26:31 +02:00
Henriette Darge 2ee3a06c63 * Remove dead links (#9453)
* Use .org website address consistently
* Remove community address as homepage as it does not really offer any value
2021-07-14 15:51:09 +02:00
ulferts 5cb227796c Fix/hook service to openproject (#9214)
* move specs from legacy

* move Hook into OpenProject namespace

* replace class variables
2021-05-03 20:58:15 +02:00
Benjamin Bädorf 2667cd1581 Refactor/app header (#9110)
* [35527] Add quick add button menu in top menu

* Add quick menu item to top menu

* Refactor top_menu.sass to follow BEM

* Only render project-based path if persisted

* Render project types when in project context

* Add headline and determine if any types are visible

* Hide quick add menu for unauthorized users

* Fix login menu dropdown by adding class

* Add schematic for correctly generating components

* Add augment service for triggering invite user modal

* Fix allowed_to? check in menu

* Add spec

* Highlight types and show all

* Fix help menu overridden

* Extend spec

* Add parent_id to project in dropdown and expand advanced settings

* Reload the page if the modal returned any data

* Fix invalid url allowed check if there is no URL to check

* Basic BEM changes

* Remove old classes

* Update more classes

* Update togling logic

* Fixed menu opening and some styles

* Added op-menu

* Fix some help menu styles

* Add op-menu to help menug

* Add avatar border

* Fix auth_provider_spec

* Fix zen mode

* Fix static link help menu

* Fixed top menu specs

* Fix self registration specs

* Fix logout spec

* Fix bim revit navigation spec

* Fixed menu permissions spec

* Fix homescreen onboarding tour spec

* Fix top menu item spec

* Remove unused file

* Fix a lot of mobile styles

* Fix more mobile styles

* Fixed build

* Move quick add menu to right hand side

* Improve quick-add-button styles, fix main-menu-toggle close icon

* Remove add new project spec

* Fix spec

* Update project dropdown styles

* Fix click handler for chrome mobile, update some styles

Co-authored-by: Oliver Günther <mail@oliverguenther.de>
2021-04-06 11:09:06 +02:00
ulferts 1bdd2ab9ae safe automatic fixes by rubocop (#8994) 2021-02-11 16:02:18 +01:00
ulferts 6140f4c7e9 update copyright to 2021 (#8925)
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.

Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
ulferts 3926b4036e fix background-image style
This was wrongfully bulk changed when replacing the custom I18n function
2020-09-17 15:47:45 +02:00
ulferts 27b41a313c replace custom i18n function in views 2020-09-15 07:23:59 +02:00
Oliver Günther 623f8c772e Move module assets to frontend 2020-06-29 11:36:39 +02:00
Oliver Günther 77310bc4b4 Merge remote-tracking branch 'origin/release/10.6' into dev 2020-06-15 13:57:15 +02:00
Oliver Günther 211d9cd4eb Move provider finder into auth plugin 2020-06-12 08:16:54 +02:00
Oliver Günther e5cd25693f Allow to find omniauth strategy by name 2020-06-11 15:38:13 +02:00
Oliver Günther f832efa52c Merge remote-tracking branch 'origin/release/10.6' into dev 2020-05-19 09:30:10 +02:00
Oliver Günther eb4458a02e Ensure values are cached in RequestStore and file only loaded once 2020-05-18 14:11:02 +02:00
Henriette Darge a61bcc7132 Rename cost reports module && Correct author_urls 2020-05-15 15:06:21 +02:00
ulferts 399e8c3ed9 rename according to zeitwerk 2020-02-21 20:47:25 +01:00
Henriette Dinger bd7f4e4814 Update copyright notice 2020-01-15 11:31:26 +01:00
ulferts 57131fa32b continue adapting to altered project properties 2019-09-24 16:02:53 +02:00
Oliver Günther 2f54fe3a06 [31045] Make auth plugins except developer ee-only
https://community.openproject.com/wp/31045
2019-09-16 07:30:31 +02:00
Oliver Günther 1d235e0e9d [30898] Fix script_name reference to auth provider link
No idea why that is not respected by omniauth, but the same is happening
for the top menu bar

https://community.openproject.com/wp/30898
2019-08-30 14:36:04 +02:00
Henriette Dinger 45636116cc Take care that css is loaded at the when the header is loaded 2019-04-26 10:17:07 +02:00
Oliver Günther bb0f8a5d1a Show version as 'bundled' in admin/info 2019-03-15 12:00:49 +01:00
Oliver Günther e62f42f713 Fix bundled module versions 2019-03-15 11:56:08 +01:00
Oliver Günther 1cb18a1989 Fix gemspec 2019-03-15 11:50:16 +01:00
Oliver Günther 8352af2bf7 Remove module versions 2019-03-15 11:48:36 +01:00
Oliver Günther 8ab4f2a663 Boards module (#7008)
* Hack spike to show D&D use case

[ci skip]

* Add ordered work packages

* Save order on existing work packages

* Boards WIP

* CDK drag

* Add dragula handler

[ci skip]

* Add filter to return all manual sorted work packages

* Print icon on hover

* Boards routing and list components

* Better loading indicator on list with streaming result

[ci skip]

* Add new board and list buttons

[ci skip]

* Post new query

[ci skip]

* Added creation of new board lists with persisted queries

[ci skip]

* Render placeholder row in empty queries

 [ci skip]

* Push boards on grid

* Use base class in scope

[ci skip]

* Extend api for options

* Hack spike to show D&D use case

[ci skip]

* Add ordered work packages

* Save order on existing work packages

* Boards WIP

* CDK drag

* Add dragula handler

[ci skip]

* Add filter to return all manual sorted work packages

* Print icon on hover

* Boards routing and list components

* Better loading indicator on list with streaming result

[ci skip]

* Add new board and list buttons

[ci skip]

* Post new query

[ci skip]

* Added creation of new board lists with persisted queries

[ci skip]

* Render placeholder row in empty queries

 [ci skip]

* Save queries in grids

[ci skip]

* Renaming queries

[ci skip]

* Add existing work packages to board

[ci skip]

* Introduce card view component for work packages

* Extend grids to allow project scope for boards (#7025)

Extends the grid backend to also be able to handle boards. In particular, it adds the ability of boards to be attached to projects and changes the page property of grids to a scope property that better describes that more than one board can belong to the same scope (e.g. /projects/:project_id/boards).

For a fully featured board, though, widgets need to be able to store options, so that they can store queries. Those widgets might also need to have custom processing and validation. That part has not been implemented.

* introduce project association for boards

* have dedicated grid registration classes

* update and create form for board grids

* extract defaults into grid registration


[ci skip]

* Add drag and drop to card view

[ci skip]

* Add options to grid

* Fix option migration name

* Renaming boards

[ci skip]

* Frontend deletion of boards

* Avoid map on NodeList which doesnt exist

[ci skip]

* Add inline create to boards

[ci skip]

* Smaller create button

[ci skip]

* Add navigation for boards

* Make inner grid same height

* Replace index page with table

* Workaround for widget registration

[ci skip]

* Fixed height for cards and tables

[ci skip]

* Implement escape as cancel d&d action

[ci skip]

* Fix and extend grid specs for name and options

* Extend board specs for required name

* Fix migration for MySQL references

https://stackoverflow.com/a/45825566/420614

* Make board list extend from widget

Since we cannot configure widgets yet, it's not yet possible to use a
board-list widget anywhere.

* Fix specs

* Fix escape listener removal

[ci skip]

* Fix renamed to_path in relation spec

[ci skip]

* Allow deletion of grids for boards

* Avoid reloading resource multiple times with replays

* Frontend synchronization on deletion

[ci skip]

* Delete through table

* Use work packages board path

* Use work packages board path

* Fix augmented columns breaking re-rendering

* Fix duplicated permission with forums

* Strengthen tab switch in specs

* Add hidden flag for project-context queries

Allows the API to create a hidden query that will not be rendered to the
user even if it is within a project context.

* private queries

* Add hidden flag for project-context queries

Allows the API to create a hidden query that will not be rendered to the
user even if it is within a project context.

* Move boards below work packages

* Add Board configuration modal

* Fix reloading with onPush

* Saving / Switching of display mode

[ci skip]

* Extract wp-query-selectable-title into common component

* Fix renaming of board-list

* Fix auto-hide notifications in boards

* Add permissions to seeders

* Reorder lists in board

* Linting

* Remove default gravatar from settings

* Show assignees avatar in the card view of WPs

* Fix specs

* Add missing method

* Fix timeline icon

* Use URL as input to be able to show avatars for groups, too

* Fix test

* Add further specs

* Use correct data attribute to avoid unnecessary data base calls

* Add further specs

* Deletion of board lists

* Pass permission via gon to decide whether we can create boards

* Fix rename spec

* Cherry-pick of 7873d59 and 30abc7f
2019-02-18 15:59:54 +01:00
Oliver Günther e374528f64 Merge pull request #6814 from opf/bump/rails5-2
[28338] Upgrade to Rails 5.2

[ci skip]
2019-01-08 14:21:59 +01:00
Oliver Günther 0a50cc3f5a Clean up some unused files in modules
[ci skip]
2018-12-17 14:09:36 +01:00
Oliver Günther 4bb14e2a62 Upgrade to Rails 5.2 2018-12-03 10:29:18 +01:00
Oliver Günther a94ba2431d Make module engines refer to core version 2018-11-20 08:41:24 +01:00
Oliver Günther 7b1d888f7b Prepare for core integration 2018-11-14 13:49:57 +01:00