Commit Graph

24733 Commits

Author SHA1 Message Date
Mohamed Wael Khobalatte 2fc4ae16ea Add responsible disclosure section to the README 2015-10-23 14:33:55 +02:00
Mohamed Wael Khobalatte 972b04d86e Refactor to allow for strong params
We no longer need attr_accessible.
2015-10-23 14:33:55 +02:00
Magdalena Kafka e5378c54b3 Merge pull request #3668 from mk84/21705-attachment-section-styling
[21705] Attachment section styling
2015-10-23 11:07:33 +02:00
ulferts 67d8d3a3b3 Merge pull request #3672 from oliverguenther/housekeeping/refactor_structs
Remove Struct usage from services and other classes
2015-10-23 09:30:03 +02:00
ulferts 1870ca99ff Merge pull request #3666 from why-el/21795-conditionally-send-email
Send `watcher set` emails only when watcher allows email notifications
2015-10-23 08:38:20 +02:00
Oliver Günther 02807e02a8 Refactor CopyProjectJob to class 2015-10-23 07:47:19 +02:00
Oliver Günther 04ff74ac24 Refactor PermittedParams to class 2015-10-23 07:23:00 +02:00
Oliver Günther abf3f49b51 Refactor services to classes 2015-10-23 07:22:44 +02:00
Continuous Integration eb234424f4 Update reference to OpenProject-Translations 2015-10-23 01:12:23 +02:00
Oliver Günther e99872a904 Merge pull request #3671 from ulferts/fix/performance_on_activity
limit aggregation to one journable
2015-10-22 22:01:08 +02:00
Jens Ulferts 3734b3a232 limit aggregation to one journable
With only .where("#{table_name}.id = ?", notes_id) appended, the DB would aggregated all (from all journables of all types) and then select the one that is necessary. This takes a considerable amount of time.
The commit will limit the aggregation to one journalizable.
2015-10-22 15:53:05 +02:00
Magdalena Kafka 77c972dbdc Add space after attachments section in split-view 2015-10-22 11:52:16 +02:00
Magdalena Kafka c799a620f8 Use new dropzone style on wp create form 2015-10-22 10:41:15 +02:00
Magdalena Kafka ed13cbd7d6 Show attachment-icon before each attachment 2015-10-22 10:15:14 +02:00
Magdalena Kafka f60e1455cb Show border on attachments only on hover 2015-10-22 10:08:24 +02:00
ulferts 4a717c739c Merge pull request #3670 from ulferts/fix/relative_url_root_in_api_v3_routes
prepend relative url root to all v3 paths
2015-10-22 09:59:56 +02:00
Jens Ulferts b2c9096c8b prepend relative url root to all v3 paths 2015-10-22 09:43:29 +02:00
Continuous Integration 2b9fae8175 Update reference to OpenProject-Translations 2015-10-22 01:20:55 +02:00
Magdalena Kafka 309b2546e9 Merge pull request #3663 from mk84/21732-accessible-wp-toolbar
[21732] Accessible wp toolbar
2015-10-21 18:19:38 +02:00
Oliver Günther 4057250b5c Perl wrapper: Use rmtree for actual deletion 2015-10-21 18:13:23 +02:00
Magdalena Kafka cd436b40a3 Merge pull request #3664 from mk84/21731-wp-subject-label
[21731] WP subject label for screenreaders
2015-10-21 17:42:23 +02:00
Magdalena Kafka 9a0e49f6dd Remove file type icon and filesize from attachments 2015-10-21 16:35:02 +02:00
Mohamed Wael Khobalatte 7e7868b5a9 Send watcher set emails only when said watcher allows email notifications. 2015-10-21 11:59:10 +02:00
Jonas Heinrich f3ee986b38 Merge branch 'release/4.3' into dev
Conflicts:
	Gemfile.lock
	config/locales/en.yml
	lib/open_project/version.rb
2015-10-21 11:47:08 +02:00
Jonas Heinrich 27be658cdd Merge branch 'release/4.2' into dev
Conflicts:
	Gemfile
	Gemfile.lock
	lib/open_project/version.rb
	spec/lib/open_project/configuration_spec.rb
2015-10-21 11:28:45 +02:00
Magdalena Kafka dcab594e2f Add new styling for dropzone 2015-10-21 11:00:23 +02:00
Magdalena Kafka edcefd1c5f Restructure wp attachments layout
* move uploaded files list above dropzone
* always show border and icon for attachments
2015-10-21 11:00:22 +02:00
Oliver Günther 6390f80f79 Restore keys from configuration example
[ci skip]
2015-10-21 10:52:32 +02:00
Magdalena Kafka dbfcbe7f3c Add tabindex on wp subject for screenreaders 2015-10-21 10:13:49 +02:00
Magdalena Kafka a3cecef3c6 Use role textbox for textfields on inplace-edit-write elements 2015-10-21 10:13:49 +02:00
Oliver Günther 944dd0b647 Merge pull request #3658 from oliverguenther/fix/selenium_locale
Set accept_language in selenium fallback
2015-10-21 07:31:49 +02:00
Oliver Günther 8aac78d15f Merge pull request #3662 from ulferts/fix/remove_dead_visibility_scope
remove dead code
2015-10-21 07:31:25 +02:00
Continuous Integration fc851cb14d Update reference to OpenProject-Translations 2015-10-21 02:28:52 +02:00
Continuous Integration 4a6ba66259 Update reference to OpenProject-Translations 2015-10-21 01:16:34 +02:00
Jens Ulferts c3ab585e80 remove dead code 2015-10-20 15:50:26 +02:00
Peter Lehwess 7df4239192 Merge pull request #3636 from mk84/21734-flash-messages-redesign
[21734] Apply notification styles on flash messages and error explanations
2015-10-20 14:41:56 +02:00
jonasheinrich 3a23c0b1c1 Merge pull request #3644 from opf/ruby-2.2.3
Use ruby 2.2.3 on travis
2015-10-20 14:40:18 +02:00
Magdalena Kafka a4f89c0891 Merge pull request #3653 from mk84/21763-checkboxes-in-searchresults
[21763] Adjust height of checkboxes in searchfields
2015-10-20 14:39:31 +02:00
Magdalena Kafka 184957c01c Add accesskey attribute only if's not empty; place them on labels 2015-10-20 14:37:30 +02:00
Magdalena Kafka 7116a6aa76 Use correct id's on wp toolbar 2015-10-20 14:37:30 +02:00
ulferts 420089afcb Merge pull request #3659 from ulferts/fix/warn_on_leaving_unsaved_in_spec
really disable warn_leaving_unsaved in spec
2015-10-20 10:58:36 +02:00
Jens Ulferts 98c0e938f2 really disable warn_leaving_unsaved in spec
The mock was not effective as warn_on_leaving_unsaved? is used and not warn_on_leaving_unsaved (without ?)
2015-10-20 09:55:59 +02:00
Continuous Integration b6a4069146 Update reference to OpenProject-Translations 2015-10-20 02:29:33 +02:00
Continuous Integration d809966211 Update reference to OpenProject-Translations 2015-10-20 01:11:10 +02:00
Mohamed Wael Khobalatte acc7f1f3c2 Merge pull request #3649 from oliverguenther/fix/i18n_fallbacks
Load I18n::Backend::Fallbacks everytime
2015-10-19 21:34:31 +02:00
Oliver Günther eee7876a69 Set accept_language in selenium fallback
In order to force the correct locale in local Firefox browsers,
ensure that the default accepted language is english.

Otherwise, anonymous users in a, e.g., german locale will
receive spec errors due to localized strings.
2015-10-19 21:12:32 +02:00
Oliver Günther d84490bdb4 Merge pull request #3651 from oliverguenther/fix/webmock_failures
Fix occasional WebMock::NetConnectNotAllowedError
2015-10-19 20:15:27 +02:00
Peter Lehwess 59495a8263 Merge pull request #3655 from oliverguenther/fix/duplicate_migration_entries
Set migration_paths explicitly from config
2015-10-19 19:40:07 +02:00
Oliver Günther e011ef493e Merge pull request #3654 from why-el/21785-various-app-errors
Centralize favicons in one template and add Apple ones
2015-10-19 19:09:43 +02:00
Jens Ulferts 2d83c95ef0 adjust casing 2015-10-19 17:07:27 +02:00