Favorite is the correct term in the context of expressing a preference
for a particular project / other OpenProject domain object.
Updates `ActsAsFavorable` to `ActsAsFavoritable`, as well as filenames,
identifiers and strings to:
favored => favorited
favorable => favoritable
favoring => favoriting
Service accounts are intended to be special users
that are not explicitly manageable through the users UI
(just like "System" and the like), but are intended for
identification of "services", not real people.
The initial scope of this will be to allow authentication
of SCIM clients, that will be able to provision users into
and out of OpenProject. However, the general idea is to
allow using service accounts for generic application-to-application
communication as well. Given proper permissions and scopes (i.e. api_v3),
it would also be possible to use a service account for requests
against our normal APIv3.
- **it's** is a contraction of _it is_ or _it has_. It requires an
apostrophe.
- **its** is the posssive form of _it_, denoting ownership. It should
not use an apostrophe.
* Fix argument alignment since f08bea3467
The FactoryBot.* prefix has been removed in f08bea3467. Since then
rubocop complains about Layout/ArgumentAlignment. This commit fixes it.
* do not fix alignments for modules/*/spec yet
hoping to be under the limit of 65535 characters for reviewdog to report on rubocop errors
* Move replacing invalid references into separate job for principals
* Write migration to remove existing invalid custom values and responsible
* Fix other specs
* Fix other specs
* rewrite replacing user in records
* consolidate principal deletion
* include placeholder users in spec
Co-authored-by: ulferts <jens.ulferts@googlemail.com>
Klaus Zanders