https://community.openproject.org/wp/68380
This bug happened because we have to many different names for the same property:
- "Working days only" (UI)
- `ignoreNonWorkingDays` (frontend)
- `includeNonWorkingDays` (frontend)
- `ignore_non_working_days` (backend and database)
It is a matter of operator precedence. `do end` has lesser precedence
and thus the code
expect(page).to have_selector("input") do
...
end
is actually evaluated like
expect(page).to(have_selector("input")) do
...
end
Meaning the block is an argument to the `to` method. Looking into rspec
source code, the block is later discarded. So the value was never
actually checked.
The :css selector has been modified to allow usage of `value` in the
`have_selector` helper, which fixes the issue.
* before closing the modal reset the values
* reset the edit field value in closing the modal
* reset the dates in a separate method
* reset the edit field value in closing the modal
* Add regression spec
* fix eslint error
* Fix double submitting the changes
Co-authored-by: Oliver Günther <mail@oliverguenther.de>
Co-authored-by: Dombi Attila <83396+dombesz@users.noreply.github.com>
* change some of stylesheets
* change the style naming
* resolve the error
* improving the previous commit with Ben's comments
* improve the styles of breadcrumb
* change the stylesheet related to status button
* refactoring css stylesheets of wp single card
* fixing the errors of PR, correct selector
* change some of stylesheets
* change the style naming
* resolve the error
* improving the previous commit with Ben's comments
* improve the styles of breadcrumb
* change the stylesheet related to status button
* refactoring css stylesheets of wp single card
* fixing the errors of PR, correct selector
* resolve the error on PR related to boards onboarding
* wp relation and list view style changes
* resolve the errors of previous commit
* fix error in selecting wp relation
* fix the errors of wp relations ruby tests
* change the stylesheets of autocompleter and wp calendar
* change the style of grid page
* Some improvements to the BEM styling
* Prefix draggable-autocomplete BEM block with op-
* Fix spec selector
* Fix spec selector
Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>
* fix start_date expectation based on setting
* extract methods
* set dates of parent work package
* pass parent on form request
* have initial dates displayed correctly in wp create form
Christophe Bliard