Revert "Improve test perf: no wait to activate a field"

This reverts commit f6b44775d4.
This commit is contained in:
Aaron Contreras
2023-07-05 15:08:28 -05:00
parent 2c87cc9a52
commit d8b31370d2
3 changed files with 7 additions and 7 deletions
+2 -2
View File
@@ -103,8 +103,8 @@ class DateEditField < EditField
input_element.click
end
def active?(wait: 1)
page.has_selector?(modal_selector, wait:)
def active?
page.has_selector?(modal_selector, wait: 1)
end
def expect_active!
+3 -3
View File
@@ -72,7 +72,7 @@ class EditField
# Activate the field and check it opened correctly
def activate!(expect_open: true)
retry_block do
unless active?(wait: 0)
unless active?
SeleniumHubWaiter.wait unless using_cuprite?
scroll_to_and_click(display_element)
SeleniumHubWaiter.wait unless using_cuprite?
@@ -99,8 +99,8 @@ class EditField
end
end
def active?(wait: 1)
@context.has_selector? "#{@selector} #{input_selector}", wait:
def active?
@context.has_selector? "#{@selector} #{input_selector}", wait: 1
end
alias :editing? :active?
@@ -40,8 +40,8 @@ class WorkPackageStatusField < EditField
input_element.find('button', text: content).click
end
def active?(wait: 1)
page.has_selector? input_selector, wait:
def active?
page.has_selector? input_selector, wait: 1
end
alias :editing? :active?