3047 Commits

Author SHA1 Message Date
Eric Schubert a1f622b271 [#75749] fix test selector again 2026-06-12 11:21:33 +02:00
Eric Schubert 3ff9c12a21 Merge branch 'dev' into feature/75749-rename-ckeditor-macro-to--insert 2026-06-11 13:34:42 +02:00
Tobias Dillmann 61c5224cbd [#73887] mocked_permission_helper mirrors UserPermissibleService for empty project
It should not grant all permissions if the project argument is `nil`.
2026-06-10 19:47:12 +02:00
Tobias Dillmann 116f84e8d9 [#73887] Remove unnecessary cast 2026-06-10 19:47:12 +02:00
Tobias Dillmann c51da0534c [#73887] Backlog bucket WP details spec 2026-06-10 19:47:12 +02:00
Yauheni Suhakou beb0bd2cab Implement referencing pages query (#23544) 2026-06-10 16:11:15 +02:00
Jan Sandbrink f102eecdc3 Adapt to latest OpenProject plugin for XWiki
This now allows to fetch canonical page infos using GET and should
return a 404 if a page with the given name does not exist.
2026-06-10 08:37:26 +02:00
Ivan Kuchin 7b5403f1be Merge pull request #23515 from opf/pluck-matcher
Pluck matcher
2026-06-09 22:19:42 +02:00
Mir Bhatia 9f89ecda16 Merge pull request #23166 from opf/implementation/74725-build-select-panel-quickfilter
[#74725] Build select panel quickfilter
2026-06-09 15:38:06 +02:00
Eric Schubert e37d910c98 [#75749] fixed ckeditor page object 2026-06-09 15:36:07 +02:00
Jan Sandbrink fc8eb59663 Merge pull request #23554 from opf/stable-page-reference
XWiki: Stable page reference
2026-06-09 14:48:41 +02:00
ulferts db815d0d22 Merge remote-tracking branch 'origin/dev' into merge-release/17.5-20260609045502 2026-06-09 09:32:19 +02:00
Jan Sandbrink f466dd3832 Reduce maximum result size of XWiki search_pages
This is only done to improve worst-case latency, because
we perform one additional request per result.

Local testing showed a latency above 1000ms for 50 results
and ~500ms for 20 results. I'd expect real world scenarios to
be slightly worse, because of higher network latency.
2026-06-09 08:51:51 +02:00
Jan Sandbrink 1ba2bf95ce Use stable identifiers to fetch XWiki pages
We now have two ways to fetch page infos from XWiki:

* using the canonical identifier (but through a new endpoint that will resolve stable identifiers as well)
* using the stable identifier

Since we want to store the stable identifier, the stable version is the one exposed through the XWiki registry.
The canonical form is required to fully resolve some list queries from XWiki properly.
2026-06-09 08:51:27 +02:00
Mir Bhatia cc3c3fbdf6 Add component specs 2026-06-09 08:51:19 +02:00
Judith Roth 595872727c [STC-779] Add tests for CTRL-Z in documents
https://community.openproject.org/wp/STC-779
2026-06-08 16:26:19 +02:00
Jan Sandbrink 42ee5fc134 Allow to disable SSRF filter selectively in specs
Otherwise they would interfere with running specs when
recording VCR cassettes.
2026-06-08 08:15:39 +02:00
Henriette Darge 396de9362f [74625] Make project hierarchy collapsable in the global project selector (#23137)
* Use new async FilterableTreeView for global project selector

* Remove replaced angular component

* Fine tune sorting and expansion state of the new project selector

* Update primer to 0.86.1

* Add workspace information and filter results hierarchy information to project selector

* Include review feedback: Harmonize I18n keys, fix visible scope, use guarded local storage

* Add a turboFrame in the project select overlay to only load the projects when it is actually opened

* Restore BIM tab styles which were broken for a while already but the new project selector changes made it so bad that the test broke because the plus icon was overlapping the checkbox

* Clarify spec expectation
2026-06-08 08:14:47 +02:00
Ivan Kuchin 91c4566c55 chain experiment 2026-06-04 21:23:19 +02:00
Ivan Kuchin e0617c097a have_attr matcher 2026-06-04 21:23:19 +02:00
ulferts 6ab4d02059 attempt to fix flickering activity spec
rspec ./spec/features/activities/work_package/activities_spec.rb:678

The attempt is to have the frontend wait for the turbo stream response rather than a fixed timeout.
The removed wait_for seems to be non-functional.
2026-06-04 16:43:50 +02:00
Jan Sandbrink 37537eee2d Merge pull request #23465 from opf/xwiki-search
Implement real search_pages for XWiki
2026-06-03 16:09:29 +02:00
Alexander Brandon Coles 8448188061 Merge pull request #23489 from opf/code-maintenance/SDS-699-filters-form-specs
[OP-19453] Add spec coverage for filter input forms
2026-06-03 15:59:11 +02:00
Jan Sandbrink 31e4b7516d Implement real search_pages for XWiki
Fetching actual results from the connected XWiki
instance instead of faking it.
2026-06-03 15:39:26 +02:00
Alexander Brandon Coles fa5b7ee1b5 Merge remote-tracking branch 'opf/dev' into merge-release/17.5-20260603051246 2026-06-03 09:52:08 +02:00
Alexander Brandon Coles 434043bfd5 [OP-19453] Add spec coverage for filter input forms
Adds 47 specs across 6 form classes and a shared context.
Covers TextForm, ListForm, DateForm, BooleanForm, AutocompleteForm, and
AddFilterForm with assertions on rendered structure, data attributes,
and operator routing.

https://community.openproject.org/wp/OP-19453
2026-06-02 19:52:05 +02:00
Judith Roth 90317785d7 [#74654] Test markdown generation of BlockNote extensions
https://community.openproject.org/wp/74654
2026-06-02 17:02:40 +02:00
Oliver Günther 11dc79a74d Merge remote-tracking branch 'origin/release/17.5' into dev 2026-06-02 16:22:39 +02:00
Behrokh Satarnejad 74183943d5 Use test selectors instead of text selector 2026-06-01 18:58:47 +02:00
Alexander Brandon Coles ba80c908ca Merge pull request #21480 from opf/dependabot/bundler/dev/capybara_accessible_selectors-v0.16.0
Bump capybara_accessible_selectors from v0.15.0 to v0.16.0
2026-06-01 12:31:49 +02:00
OpenProject Actions CI b2f72fd486 Merge branch 'release/17.5' into dev 2026-05-30 04:49:04 +00:00
Alexander Brandon Coles 86e40ffffe Adapt specs to capybara_accessible_selectors 0.16
Refactors the custom `:list`/`:list_item` selectors onto CAS's
`add_role_selector` and drops the now-native `Capybara::Node::Simple#role`
hack. `:list_item` resolves the listitem role, so specs matching
non-listitem `<li>` are updated (`have_row` for the custom field table,
presentation dividers via CSS).

CAS 0.16 also resolves role selectors by computed role and accessible
name, which our CSS-styled tables and Primer menus do not expose through
plain markup. Affected feature specs switch to robust locators:
Capybara's `:table_row`, the FullCalendar `data-date`, and the action
menu's real accessible name ("Edit status").

The `:columnheader` `colindex` filter lost its off-by-one offset and now
uses the true 1-based `th` position. Also fixes Webhooks `RowComponent`
spec capitalization.
2026-05-29 20:41:25 +02:00
Judith Roth 4dd97c267c [#75231] Add tests for inserting WP links with # notation
https://community.openproject.org/wp/75231

in BlockNote editor
2026-05-29 10:30:29 +02:00
Judith Roth f1b1ab307d [#75231] Fix test for op-blocknote-extensions in open project
https://community.openproject.org/wp/75231
2026-05-29 10:30:29 +02:00
Alexander Brandon Coles 4ec84e75ac Merge pull request #23438 from opf/fix/flaky-inbox_column_spec
Fix flaky menu-based reorder specs, also renaming `wait_for_` Cuprite helpers
2026-05-28 18:09:20 +02:00
Alexander Brandon Coles d8708d8a62 Rename cuprite wait helper timeout: to wait:
Aligns with Capybara's `wait:` option naming conventions. A falsey value
skips the wait entirely, letting callers opt out of synchronisation.
2026-05-28 17:32:14 +02:00
Ivan Kuchin c5df0c29f0 Merge pull request #23182 from opf/code-maintenance/74769-remove-portfolio_models-feature-flag
[#74769] Remove portfolio_models feature flag
2026-05-28 17:20:48 +02:00
OpenProject Actions CI 3e02e2863f Merge branch 'release/17.5' into dev 2026-05-28 12:18:34 +00:00
Henriette Darge c74076a173 Merge pull request #23373 from opf/bug/64359-work-package-configuration-dialog-s-highlighting-tab-has-no-space-between-radio-buttons-and-labels
[64359] Work package configuration dialog's highlighting tab has no space between radio buttons and labels
2026-05-28 14:13:29 +02:00
Ivan Kuchin 1437167b0a handle multiple createable workspace types in specs 2026-05-28 13:54:35 +02:00
OpenProject Actions CI 49b802ca02 Merge branch 'release/17.5' into dev 2026-05-28 08:51:09 +00:00
Oliver Günther b0905e35b7 Merge pull request #23392 from opf/fix/ldap-seeder-aliases
Fix LDAP seeder not using env aliases and underscores
2026-05-28 08:56:14 +02:00
Oliver Günther a058f227f3 Add retry block on button save click 2026-05-28 08:32:49 +02:00
OpenProject Actions CI eb6717f81e Merge branch 'release/17.5' into dev 2026-05-27 14:11:35 +00:00
Oliver Günther 4724150e3d Avoid quote_string in favor of bindings where possible 2026-05-27 10:08:16 +02:00
Oliver Günther a1505dc0f5 Merge remote-tracking branch 'origin/release/17.5' into dev 2026-05-27 09:58:01 +02:00
Oliver Günther 46a4dbd1e6 Fix highlighting spec flakyness
The failing spec in this run
https://github.com/opf/openproject/actions/runs/26492229079/job/78012301717?pr=23371
was caused by the dialog not being open in the right tab.

Adding an expectation to it hopefully fixes it
2026-05-27 08:53:53 +02:00
Alexander Brandon Coles c776be17cc Make WP query history filter checks idempotent
Turbo can restore the query filter pane as either open or closed during
browser history traversal. Use an idempotent helper before asserting
restored filters so the spec checks the query state instead of depending
on the current pane visibility.
2026-05-26 23:17:42 +02:00
Kabiru Mwenja 9edacbf73f Merge pull request #22892 from opf/feature/blocknote-external-link-a11y
(Blocknote): Add screen-reader hint for external links
2026-05-26 14:47:00 +03:00
David F 3897c25139 Move autocomplete_options from FilterComponent to filter classes. wp/74380
As per review feedback from oliverguenther.
2026-05-26 08:14:56 +02:00