references/openproject
1
0
Fork 0
mirror of https://github.com/opf/openproject.git synced 2026-06-14 03:30:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename cuprite wait helper timeout: to wait:

Browse Source 
Aligns with Capybara's `wait:` option naming conventions. A falsey value
skips the wait entirely, letting callers opt out of synchronisation.
This commit is contained in:
Alexander Brandon Coles
2026-05-28 17:19:28 +02:00
parent c214fedc45
commit d8708d8a62
1 changed files with 23 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/support/shared/cuprite_helpers.rb
+23 -5
View File
@@ -86,12 +86,18 @@ end
# wait_for_turbo_stream { click_button "Save" }
# expect(page).to have_text("Saved")
#
def wait_for_turbo_stream(timeout: 10, &block)
def wait_for_turbo_stream(wait: 10, &block)
unless using_cuprite?
yield if block
return
end
unless wait
yield if block
return
end
timeout = wait == true ? 10 : wait
timeout_ms = timeout * 1000
page.execute_script(<<~JS, timeout_ms)
window.__opTurboStreamRendered = new Promise((resolve, reject) => {
@@ -124,12 +130,18 @@ end
# wait_for_turbo { click_link_or_button "Save" }
# expect(page).to have_text("Saved")
#
def wait_for_turbo(timeout: 10, &block)
def wait_for_turbo(wait: 10, &block)
unless using_cuprite?
yield if block
return
end
unless wait
yield if block
return
end
timeout = wait == true ? 10 : wait
timeout_ms = timeout * 1000
page.execute_script(<<~JS, timeout_ms)
window.__opTurboLoaded = new Promise((resolve, reject) => {
@@ -162,12 +174,18 @@ end
# wait_for_turbo_frame { click_link "Remove column" }
# expect(page).to have_text("Updated")
#
def wait_for_turbo_frame(timeout: 10, &block)
def wait_for_turbo_frame(wait: 10, &block)
unless using_cuprite?
yield if block
return
end
unless wait
yield if block
return
end
timeout = wait == true ? 10 : wait
timeout_ms = timeout * 1000
page.execute_script(<<~JS, timeout_ms)
window.__opTurboFrameLoaded = new Promise((resolve, reject) => {
@@ -205,8 +223,8 @@ end
# wait_for_ckeditor
# wait_for_turbo_stream { description_field.fill_and_submit_value(...) }
#
def wait_for_ckeditor(timeout: 20)
expect(page).to have_css(".ck-content", wait: timeout)
def wait_for_ckeditor(wait: 20)
expect(page).to have_css(".ck-content", wait:)
end
def using_cuprite?