* Fix argument alignment since f08bea3467
The FactoryBot.* prefix has been removed in f08bea3467. Since then
rubocop complains about Layout/ArgumentAlignment. This commit fixes it.
* do not fix alignments for modules/*/spec yet
hoping to be under the limit of 65535 characters for reviewdog to report on rubocop errors
The paths weren't properly escaped for URLs. This fix allows any
subdirectory of arbitrary chars to be displayed as a checkout URL.
This also fixes an escaping issue in the adapter that prohibits checking
folder with special characters which SVN doesn't care about.
Adds an `insecure` option to the `configuration.yml`.
This option only applies when the manages: key is set to a URL.
If the given URL uses SSL, certificate checking will be disabled.
This key is set for a packaged installation by default, since it communicates locally and
these installations may often include a snakeoil certificate.
This commit expects a managed remote to return at least a URL
to the repository, and optionally a path.
Note that OpenProject currently only supports local repositories for
Git, and thus using managed remotes with Git WILL require a path
returned from the remote.
For Subversion, also returning a `file://<path>` URL is sufficient,
since it can browse that. Returned external URLs must be accessible from
OpenProject, since we do not receive any authentication from the remote.
As webmock breaks default Net::HTTP behavior, it should not be run unless explictly requested.
Requiring it in the spec_helper breaks some other integration tests.
This commit starts the work to provide functionality with remote service hooks for managing repositories.
The main driver behind this is packager, for which we want apache to be the sole owner of the repositories it delivers, and OpenProject only as a reader, however it benefits other installations as well.
Jan Sandbrink