0b87e7543f
Freeze string literals in specs
...
Rolling out frozen string literals further by freezing all
string literals in core specs.
2025-05-05 09:29:55 +02:00
97ccf0bfc5
adjust internal comments internal representation
2025-04-24 13:12:32 +02:00
c2886046cd
update comment permission names
2025-04-24 13:12:32 +02:00
dfac1c9c56
notifications for internal comments
2025-04-10 10:55:29 +02:00
311e0d7283
sent notifications to users mentioning themselves again
...
But still prevent sending notification when the user is part of a group they mention.
2024-10-21 14:31:18 +02:00
1ad3b4ed4d
[57251] Fix mail_alert_sent not being set correctly on update
...
https://community.openproject.org/wp/57251
When a notification exists for a work package journal for a reason other
than :mentioned, then its `mail_alert_sent` value is `nil`.
On a subsequent update of the work package which mentions the user, the
existing notification is updated. In this update, the `mail_alert_sent`
value must be changed from `nil` to `false` if the reason is :mentioned.
Without it, the immediate notification email for the mention would not
be sent.
2024-10-15 09:14:43 +02:00
80408a5827
Merge remote-tracking branch 'origin/release/14.4' into dev
2024-08-23 08:51:14 +02:00
eb98b082a0
remove explicit project column from notifications
2024-08-22 10:07:15 +02:00
4911b8a149
remove years from copyrights (except for COPYRIGHT file)
2024-07-31 15:02:49 +02:00
0db3b6e7c8
Merge pull request #15734 from opf/bug/55255-notifications-are-sent-to-the-author-if-the-author-is-member-of-a-mentioned-group
...
[#55255 ] Notifications are sent to the author if the author is member of a @mentioned group
2024-06-04 10:11:53 -05:00
fbcae1e21a
[ #55255 ] Notifications are sent to the author if the author is member of a @mentioned group
...
https://community.openproject.org/work_packages/55255
2024-06-03 21:49:55 +03:00
4896c34178
fix signaling on the mail_alert_sent
...
It is now possible to distinguish by reason whether the mail_alert_sent field is set to true, nil or false.
This didn`t suffice though to have the immediate_reminders user preference handled for mentioning mails. Ideally, the preference would be handled
in the CreateFromModelService to have the field set correctly right away. This does not work with the current structure though so the alternative
of bailing on actually sending the mail is used. The property is then set to nil by that service upon identifying the user as not wanting
to receive mails
2024-06-03 13:48:18 +02:00
16f7a7eadd
Repair the stubbed user factory preference assignment logic.
2024-04-29 20:57:13 +02:00
3b2121f733
Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
...
This reverts commit 40b2bbeb09b4c6cb17cc
2024-03-21 11:31:17 +01:00
7787e457a3
Revert "Merge branch 'dev' into release/13.4"
...
This reverts commit a901541269e573ca00b7
2024-03-20 20:19:08 +01:00
9e4934cd0a
change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a
2024-03-20 18:05:22 +01:00
8fa8584538
Run rubocop --autocorrect on all files
...
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
c795874f7f
Update copyright year for 2024
...
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
6991520bf1
add shared to notification creation and notification center
2023-10-26 11:00:45 +02:00
5b2bc41f41
Merge remote-tracking branch 'origin/dev' into easier-factory-role-setup
2023-10-12 12:09:27 +02:00
2b2abf864a
introduce ProjectRole model
2023-10-09 14:34:20 +02:00
78c1e4fadb
Switch all uses of principal factories to use new interface
2023-10-09 10:39:44 +02:00
8380e0dcd4
Refactor add_jorunal method to use keyword arguments
2023-07-03 10:03:39 +02:00
4c2a9d0aa8
Enable RSpec zero monkey patching mode
...
The plan for RSpec 4.0 is to disable monkey patching.
See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.
2023-05-31 19:22:29 +02:00
a328940c3a
merge wiki_content into page
2023-04-05 10:05:20 +02:00
aa23106c11
lint: autocorrect RSpec/FactoryBot/ConsistentParenthesesStyle
...
command is
rubocop -A --only RSpec/FactoryBot/ConsistentParenthesesStyle modules spec
2023-03-07 15:04:32 +01:00
caf4588dcf
fix mentioning multiple users in a single line
...
Because of the .* introduced for excluding quoted lines, which is
greedy, only the last match was taken.
Now the quoted lines are excluded first. That leads to a simpler regexp.
2023-03-03 09:44:58 +01:00
21a696ef9b
Update copyright information for 2023
2022-12-30 15:51:26 +01:00
5f81d8a773
[ #45020 ] Replies to comments in which I was mentioned do create new, undesired notifications
...
https://community.openproject.org/work_packages/45020
2022-11-30 11:55:02 +01:00
bb4c3f2ab2
changed spec to allow for self-mentioning
2022-11-02 20:02:22 +01:00
4534007a3b
[ #43675 ] fig regarding comments
2022-09-27 22:31:22 +02:00
0c85cc4287
[ #43675 ] fix specs
2022-09-27 22:22:24 +02:00
a7febaf6a0
remove journal aggregate event
2022-07-06 17:47:55 +02:00
5da326043d
update spec expectation which used to be incorrect
2022-07-06 17:10:59 +02:00
1f8b81e04b
open up updating existing notifications
2022-07-06 17:10:51 +02:00
a16dfcfad9
linting
2022-07-06 17:10:43 +02:00
67e0039f72
handling existing notifications on creation -> update or destroy
2022-07-06 17:10:35 +02:00
b50855a955
Use ServiceResult factory methods where possible
...
All was automatic through the use of `rubocop --autocorrect --only
OpenProject/UseServiceResultFactoryMethods app lib lib_static modules
spec`.
2022-06-16 10:01:57 +02:00
48a4f1b6ad
lint with rubocop --autocorrect (safe cops only)
2022-06-02 10:40:10 +02:00
a33524ef6d
remove ruby magic comment for utf-8
...
ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless
2022-03-10 19:36:58 +01:00
bc8d423ec2
update copyright information for 2022
2022-03-01 17:05:59 +01:00
47a297daae
Fix argument alignment since f08bea3467 ( #10129 )
...
* Fix argument alignment since f08bea3467f08bea3467
2022-02-02 21:48:06 +01:00
f08bea3467
Remove FactoryBot.* prefix where applicable
2022-01-25 08:19:06 +01:00
443e6bf439
Add explict relocation spec
2021-11-10 14:29:54 +01:00
900ca53c18
[39177] Fix double mentioned notifications
...
By causing aggregated journals to update mentioned notifications before
the predecessor journal is destroyed, we can keep information about a
mention in the notification realm and skip creating another notification
for the same mention.
https://community.openproject.org/wp/39177
2021-11-09 15:51:29 +01:00
aff788bdf6
Merge remote-tracking branch 'origin/dev' into implementation/38884-notifications-send-out-mention-mail-on-mentioning
2021-10-01 11:39:21 +02:00
bbf05016b4
prevent non work package notifications to leak via the API
2021-10-01 09:50:43 +02:00
c92335606c
remove self mail prevention
...
Notification creation prevents self notification which in turn prevents self mailing
2021-09-30 12:59:26 +02:00
8aca19d827
sending empty mail on mentioning
2021-09-30 12:59:26 +02:00
18e4c37cf3
Fix setting of mail_reminder and mail_alert in create_from_model_service
2021-09-29 18:00:03 +02:00
Jan Sandbrink