Henriette Darge
f496da2aad
Merge release/16.0 into dev
2025-05-16 14:56:25 +02:00
Jan Sandbrink
0b87e7543f
Freeze string literals in specs
...
Rolling out frozen string literals further by freezing all
string literals in core specs.
2025-05-05 09:29:55 +02:00
Ivan Kuchin
4911b8a149
remove years from copyrights (except for COPYRIGHT file)
2024-07-31 15:02:49 +02:00
Oliver Günther
c7286fb91f
Set default host at all times
...
This results in us having to use a bit more helpers around request and feature specs
to ensure that the configured host name also matches the requested one.
2024-07-08 16:11:09 +02:00
Ivan Kuchin
6678cab48d
auto correct quotes
2024-03-28 18:22:34 +01:00
Oliver Günther
c1d5c23b1b
Allow logins to receive umlauts and other letter class chars
2024-03-25 08:47:14 +01:00
ulferts
3b2121f733
Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
...
This reverts commit 40b2bbeb09 , reversing
changes made to b4c6cb17cc .
2024-03-21 11:31:17 +01:00
Ivan Kuchin
7787e457a3
Revert "Merge branch 'dev' into release/13.4"
...
This reverts commit a901541269 , reversing
changes made to e573ca00b7 .
2024-03-20 20:19:08 +01:00
Ivan Kuchin
9e4934cd0a
change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a
2024-03-20 18:05:22 +01:00
ulferts
d257c30366
Merge remote-tracking branch 'origin/release/13.4' into dev
2024-03-18 09:45:27 +01:00
Oliver Günther
00c8c550dc
Convert stubbed account_controller specs into requests
...
The errors were not spotted as the controller spec was heavily stubbed
2024-03-11 20:34:05 +01:00
Oliver Günther
d7cfa42fa1
Merge contract errors into user
2024-03-11 20:31:22 +01:00
Oliver Günther
1f112eb94d
Adapt account controller so that we can find existing, but e.g, locked users
2024-02-06 16:08:51 +01:00
Oliver Günther
692c730195
Ensure we always look in LDAP for the user even if not onthefly
2024-02-06 16:05:59 +01:00
Oliver Günther
8a938b37c1
Adapt auth_source_sso with improved finding of users
2024-02-06 16:05:58 +01:00
Christophe Bliard
8fa8584538
Run rubocop --autocorrect on all files
...
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
Christophe Bliard
c795874f7f
Update copyright year for 2024
...
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
Klaus Zanders
78c1e4fadb
Switch all uses of principal factories to use new interface
2023-10-09 10:39:44 +02:00
Oliver Günther
e32d2d0058
Remove AuthSource base namespace, model
2023-07-27 08:16:43 +02:00
Christophe Bliard
4c2a9d0aa8
Enable RSpec zero monkey patching mode
...
The plan for RSpec 4.0 is to disable monkey patching.
See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.
2023-05-31 19:22:29 +02:00
Christophe Bliard
21a696ef9b
Update copyright information for 2023
2022-12-30 15:51:26 +01:00
Oliver Günther
0cb98b15bd
Merge remote-tracking branch 'origin/release/12.3' into dev
2022-11-10 16:08:05 +01:00
Oliver Günther
2d975cd9ad
Add native / custom schemes to form-action CSP
2022-11-07 11:50:05 +01:00
Oliver Günther
5acdcb178b
Add helper to disable 2FA stage redirects
...
Many specs depend on not redirecting to 2FA, so provide a helper to skip that stage
2022-10-10 21:18:03 +02:00
Christophe Bliard
48a4f1b6ad
lint with rubocop --autocorrect (safe cops only)
2022-06-02 10:40:10 +02:00
Christophe Bliard
a33524ef6d
remove ruby magic comment for utf-8
...
ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless
2022-03-10 19:36:58 +01:00
Christophe Bliard
bc8d423ec2
update copyright information for 2022
2022-03-01 17:05:59 +01:00
Christophe Bliard
47a297daae
Fix argument alignment since f08bea3467 ( #10129 )
...
* Fix argument alignment since f08bea3467
The FactoryBot.* prefix has been removed in f08bea3467 . Since then
rubocop complains about Layout/ArgumentAlignment. This commit fixes it.
* do not fix alignments for modules/*/spec yet
hoping to be under the limit of 65535 characters for reviewdog to report on rubocop errors
2022-02-02 21:48:06 +01:00
Oliver Günther
f08bea3467
Remove FactoryBot.* prefix where applicable
2022-01-25 08:19:06 +01:00
Oliver Günther
04964f21e2
[40248] Remember the back_url when initiating auth_source_sso
...
When the user creates a new session through auth source sso, they are
being logged in through `logged_user=` which calls the login service and
redirects back afterwards. But there is no back_url set, resulting in a
my page redirect.
https://community.openproject.org/wp/40248
2021-12-06 20:05:16 +01:00
Oliver Günther
ccfa29c728
Move license and copyright docs to root, fix names and references
2021-09-02 21:50:46 +02:00
Oliver Günther
0fa8b4a77b
Forward CSP extensions to login controller ( #9047 )
...
* Forward CSP extensions to login controller
* Extend spec for double auth code
* stabilize spec
On my machine, since I have an s3 bucket configured, the spec failed
Co-authored-by: ulferts <jens.ulferts@googlemail.com >
2021-03-01 22:18:03 +01:00
ulferts
1bdd2ab9ae
safe automatic fixes by rubocop ( #8994 )
2021-02-11 16:02:18 +01:00
ulferts
6140f4c7e9
update copyright to 2021 ( #8925 )
...
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.
Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
Henriette Dinger
bd7f4e4814
Update copyright notice
2020-01-15 11:31:26 +01:00
Jens Ulferts
200376b1d6
replace spec_legacy integration specs
2018-09-21 09:37:10 +02:00
Oliver Günther
177f4e8963
Remove APIV2 and project associations / reportings
...
[ci skip]
2018-01-17 17:23:56 +01:00
Oliver Günther
518c255c1a
Fix API token usage and specs
2017-11-09 14:13:50 +01:00
Oliver Günther
cbb0d90fde
Use Rack::Test in all request specs
2017-09-12 09:17:40 +02:00
Oliver Günther
7cf11bb689
Update copyright notice
2017-01-10 15:11:43 +01:00
Oliver Günther
688385428c
Avoid multiple requires of spec_helper
...
https://github.com/rspec/rspec-core/issues/1076
2016-10-31 20:38:35 +01:00
Oliver Günther
657db6839c
Remove more params deprecations
2016-10-26 09:31:09 +02:00
Oliver Günther
fb4bf739d9
Allow the configuration to disable APIv2 basic auth
2016-02-18 19:42:35 +01:00
Alex Coles
ce93701029
Fix syntax (w/Rubocop) in specs
...
Signed-off-by: Alex Coles <alex@alexbcoles.com >
2015-06-30 12:08:28 +02:00
Alex Coles
e0191e759c
Update year in copyright header to 2015
...
[ci skip]
2015-01-01 00:02:57 +00:00
Alex Coles
5afc11f19e
Fix syntax (w/Rubocop) in specs
...
Signed-off-by: Alex Coles <alex@alexbcoles.com >
2014-11-04 00:50:36 +01:00
Alex Coles
03978767be
Use 1.9+ Hash syntax in specs
...
Signed-off-by: Alex Coles <alex@alexbcoles.com >
2014-11-03 23:49:02 +01:00
Alex Coles
e137ed8135
Convert specs to RSpec 2.99.0 syntax with Transpec
...
This conversion is done by Transpec 2.3.1 with the following command:
transpec
* 72 conversions
from: describe 'some controller' { }
to: describe 'some controller', :type => :controller { }
* 57 conversions
from: describe 'some model' { }
to: describe 'some model', :type => :model { }
* 49 conversions
from: describe 'some view' { }
to: describe 'some view', :type => :view { }
* 34 conversions
from: obj.should
to: expect(obj).to
* 27 conversions
from: describe 'some routing' { }
to: describe 'some routing', :type => :routing { }
* 8 conversions
from: describe 'some feature' { }
to: describe 'some feature', :type => :feature { }
* 7 conversions
from: describe 'some helper' { }
to: describe 'some helper', :type => :helper { }
* 5 conversions
from: be_true
to: be_truthy
* 5 conversions
from: describe 'some request' { }
to: describe 'some request', :type => :request { }
* 2 conversions
from: obj.should_receive(:message)
to: expect(obj).to receive(:message)
* 2 conversions
from: obj.stub(:message)
to: allow(obj).to receive(:message)
* 1 conversion
from: before { example }
to: before { |example| example }
* 1 conversion
from: describe 'some mailer' { }
to: describe 'some mailer', :type => :mailer { }
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2014-06-26 15:04:58 +02:00
Alex Coles
0bdbdcac35
Convert specs to RSpec 2.14.8 syntax with Transpec
...
This conversion is done by Transpec 1.10.4 with the following command:
transpec
* 1414 conversions
from: obj.should
to: expect(obj).to
* 646 conversions
from: == expected
to: eq(expected)
* 376 conversions
from: obj.stub(:message)
to: allow(obj).to receive(:message)
* 107 conversions
from: obj.should_not
to: expect(obj).not_to
* 70 conversions
from: obj.should_receive(:message)
to: expect(obj).to receive(:message)
* 45 conversions
from: =~ [1, 2]
to: match_array([1, 2])
* 27 conversions
from: lambda { }.should
to: expect { }.to
* 13 conversions
from: Klass.any_instance.stub(:message)
to: allow_any_instance_of(Klass).to receive(:message)
* 8 conversions
from: === expected
to: be === expected
* 7 conversions
from: expect { }.not_to raise_error(SpecificErrorClass)
to: expect { }.not_to raise_error
* 6 conversions
from: =~ /pattern/
to: match(/pattern/)
* 2 conversions
from: obj.should_not_receive(:message)
to: expect(obj).not_to receive(:message)
* 1 conversion
from: < expected
to: be < expected
* 1 conversion
from: obj.stub!(:message)
to: allow(obj).to receive(:message)
* 1 conversion
from: stub('something')
to: double('something')
2014-03-31 10:50:22 +02:00
Johannes Wollert
8b096975fe
updates copyright headers
...
updates more copyright
more copyright headers
2014-02-27 16:39:51 +01:00