Restore the minimal admin settings blankslate so the admin menu route
remains valid after the sprint-based cleanup. Remove the remaining
settings-driven story/task classification code, dead models and
services, and the obsolete filter and spec setup that depended on it.
AnyFixture will create once instance of a factory for reuse in a number of specs.
This will work fine until we require a clean slate for a specific example.
As we have numerous tests that test like the database is empty,
we get a number of disadvantages:
- After an example with `with_clean_fixture` metadata, the fixture will only be regenerated
after the next example that uses it. This means the order of execution will change
the number of objects in the DB.
- The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will
result in.
- You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked
by myself.
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.
Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec.
They automatically are created whenever first hitting them.
This makes an excellent time saver for items that are commonly used, such as an admin user account
Validating attribute groups is only relevant when creating or
updating the type in the administration. There's no need to validate
this in the type itself.
https://community.openproject.com/wp/28543
CF on types can still be set through `custom_field_ids=` and is used in
e.g., a number of tests as is the standard way to define custom fields.
This is no problem until resetting the attribute groups, where the
default attribute groups will contain the custom fields formerly
defined.
Thus, explicitly resetting the attribute groups must also reset the
custom_field_ids.
https://community.openproject.com/wp/27487
* replace alias_method_chain
* remove deprecation silencing
* bump controller-testing
* introduce permitted params for settings
* replace various deprecations in controllers
* remove deprecation silencing for legacy_specs
* remove `puts` from spec
* replace deprecated access to errors
* remove unnecessary AR::Parameters usage in spec
* specify error to expect
* replace deprecations
* replace deprecated action calls in legacy function specs
* replace deprecations in functional controller tests
* replace deprecations in controllers/controller_specs
* remove params parser which does not seem to be in effect
It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code.
* replace deprecations in unit specs
* replace alias_method_chain
[ci skip]
* [25288] Re-add translations to default attribute groups
Uses symbols to mark internal attribute groups and translates them in
the schema representer to the user's locale.
* Extend form configuration front end for translated default groups
* fixing specs
* fix feature spec for attribute groups
* Add symbol test to attribute groups
[ci skip]
Alexander Brandon Coles