37 Commits

Author SHA1 Message Date
Klaus Zanders 4f0d6f6e39 Move specs for role into the base class 2025-12-18 11:51:58 +01:00
Jan Sandbrink 0b87e7543f Freeze string literals in specs
Rolling out frozen string literals further by freezing all
string literals in core specs.
2025-05-05 09:29:55 +02:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
ulferts 2b2abf864a introduce ProjectRole model 2023-10-09 14:34:20 +02:00
Christophe Bliard 4c2a9d0aa8 Enable RSpec zero monkey patching mode
The plan for RSpec 4.0 is to disable monkey patching.

See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.
2023-05-31 19:22:29 +02:00
Christophe Bliard 85b3258a29 Autocorrect with some rubocop cops
RSpec/Rails/InferredSpecType and Style/RedundantConstantBase

rubocop --autocorrect-all --only RSpec/Rails/InferredSpecType,Style/RedundantConstantBase spec modules/*/spec
2023-01-13 14:28:59 +01:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
ulferts 6af1d55164 replace legacy specs 2022-03-04 14:28:04 +01:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Oliver Günther f08bea3467 Remove FactoryBot.* prefix where applicable 2022-01-25 08:19:06 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
ulferts 1bdd2ab9ae safe automatic fixes by rubocop (#8994) 2021-02-11 16:02:18 +01:00
ulferts 6140f4c7e9 update copyright to 2021 (#8925)
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.

Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
Henriette Dinger bd7f4e4814 Update copyright notice 2020-01-15 11:31:26 +01:00
ulferts 57f7da4f39 reuse project services in controller 2019-09-18 15:39:59 +02:00
ulferts f1142c6654 move AccessControl into OpenProject namespace 2019-05-31 20:36:32 +02:00
Oliver Günther 059770f533 FactoryGirl => FactoryBot
Removes the deprecation
2018-05-07 22:38:20 +02:00
Oliver Günther 6ef4211e77 Bump copyright to 2018 (#6171)
[ci skip]
2018-02-12 08:51:12 +01:00
Oliver Günther 7cf11bb689 Update copyright notice 2017-01-10 15:11:43 +01:00
Jens Ulferts da7b63eeb7 discard empty and duplicate permissions 2016-09-21 16:39:50 +02:00
Jens Ulferts 693090136d normalize permissions
With rails 5 it is no longer possible to create an sql like statement via arel which will check whether a serialized array contains a string. AR will only allow to create a match against an array if the column itself is marked to serialize an array. Because of this and in order to increase the normalization of the data, the permissions are no longer serialized and are  moved into a separate table instead. While this is still not normalized, it satisfies the needs
2016-09-08 08:50:50 +02:00
Alex Coles ebbc9e3d7d Prefer #not_to over #to_not in specs
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-03-11 16:25:19 -03:00
Alex Coles e0191e759c Update year in copyright header to 2015
[ci skip]
2015-01-01 00:02:57 +00:00
Alex Coles 5afc11f19e Fix syntax (w/Rubocop) in specs
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-11-04 00:50:36 +01:00
Alex Coles 03978767be Use 1.9+ Hash syntax in specs
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-11-03 23:49:02 +01:00
Alex Coles e137ed8135 Convert specs to RSpec 2.99.0 syntax with Transpec
This conversion is done by Transpec 2.3.1 with the following command:
    transpec

* 72 conversions
    from: describe 'some controller' { }
      to: describe 'some controller', :type => :controller { }

* 57 conversions
    from: describe 'some model' { }
      to: describe 'some model', :type => :model { }

* 49 conversions
    from: describe 'some view' { }
      to: describe 'some view', :type => :view { }

* 34 conversions
    from: obj.should
      to: expect(obj).to

* 27 conversions
    from: describe 'some routing' { }
      to: describe 'some routing', :type => :routing { }

* 8 conversions
    from: describe 'some feature' { }
      to: describe 'some feature', :type => :feature { }

* 7 conversions
    from: describe 'some helper' { }
      to: describe 'some helper', :type => :helper { }

* 5 conversions
    from: be_true
      to: be_truthy

* 5 conversions
    from: describe 'some request' { }
      to: describe 'some request', :type => :request { }

* 2 conversions
    from: obj.should_receive(:message)
      to: expect(obj).to receive(:message)

* 2 conversions
    from: obj.stub(:message)
      to: allow(obj).to receive(:message)

* 1 conversion
    from: before { example }
      to: before { |example| example }

* 1 conversion
    from: describe 'some mailer' { }
      to: describe 'some mailer', :type => :mailer { }

For more details: https://github.com/yujinakayama/transpec#supported-conversions
2014-06-26 15:04:58 +02:00
Alex Coles 81682a7417 Fix whitespace in specs
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-05-29 23:49:27 +02:00
Johannes Wollert 8b096975fe updates copyright headers
updates more copyright

more copyright headers
2014-02-27 16:39:51 +01:00
Philipp Tessenow a1e67dd460 new copyright header #1903 2013-09-16 17:59:31 +02:00
Jens Ulferts 21459a384f provide every possible file with a short copyright notice
This was done using the rake task: rake copyright:update
2013-06-07 10:49:57 +02:00
Martin Linkhorst 85b34be86c make this test less brittle 2013-02-12 17:53:05 +01:00
Martin Linkhorst 8bcd0cc619 migrate specs from core_tests as of revision 2f2aff7 on github remote 2012-12-04 14:28:15 +01:00