52 Commits

Author SHA1 Message Date
Tom Hykel 91c3d143dc fix(ui): Numeric ID instead of semantic one on the Activity page (WP #74912) (#23345)
---------

Co-authored-by: Kabiru Mwenja <k.mwenja@openproject.com>
2026-05-29 14:45:43 +03:00
Klaus Zanders 1d64471fb2 fix activity provider for time entries 2025-07-09 10:41:14 +02:00
Ivan Kuchin a222d63844 remove project_attributes alias for project_details scope 2025-06-20 12:59:45 +02:00
Jan Sandbrink 0b87e7543f Freeze string literals in specs
Rolling out frozen string literals further by freezing all
string literals in core specs.
2025-05-05 09:29:55 +02:00
Bruno Pagno aa53f1fa09 remove internal comments feature flag 2025-04-29 10:30:11 +02:00
Bruno Pagno 97ccf0bfc5 adjust internal comments internal representation 2025-04-24 13:12:32 +02:00
Bruno Pagno c2886046cd update comment permission names 2025-04-24 13:12:32 +02:00
Bruno Pagno be9afb37b8 Merge remote-tracking branch 'origin/dev' into implementation/60980-introduce-work-package-restricted-comments-as-part-of-journal-notes 2025-03-20 18:03:18 +01:00
Ivan Kuchin bd7e7b218a handle old project_attributes event type filter 2025-03-20 13:54:06 +01:00
Ivan Kuchin 22093e88dd test activities fetcher scopes 2025-03-20 13:54:05 +01:00
Ivan Kuchin 236b527b54 cleanup before adding scope tests 2025-03-20 13:54:05 +01:00
Ivan Kuchin 565dcb120a simplify understanding errors by comparing objects instead of their ids 2025-03-20 13:54:05 +01:00
Ivan Kuchin 06b683ce93 rename events.project_attributes to events.project_details 2025-03-20 13:54:04 +01:00
Kabiru Mwenja b901590dce Extend comments with restricted visibility feature flag (#18245) 2025-03-12 13:56:41 +03:00
Bruno Pagno 01a376a56f include specs 2025-03-07 15:52:40 +01:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard 8fa8584538 Run rubocop --autocorrect on all files
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
Klaus Zanders 0c3d440a12 Do not change behavior in AccessControl#permission method, but do it locally 2023-10-31 11:22:50 +01:00
Klaus Zanders 1af13d044a Keep public permissions around in spec 2023-10-31 11:13:23 +01:00
ulferts 2b2abf864a introduce ProjectRole model 2023-10-09 14:34:20 +02:00
Christophe Bliard 4c2a9d0aa8 Enable RSpec zero monkey patching mode
The plan for RSpec 4.0 is to disable monkey patching.

See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.
2023-05-31 19:22:29 +02:00
ulferts a328940c3a merge wiki_content into page 2023-04-05 10:05:20 +02:00
Mir Bhatia 0e0b6a04f2 Remove unnecessary view_budgets permission 2023-03-30 10:52:43 +02:00
Mir Bhatia ff31c57620 Add test to check for exclusion of budgets 2023-03-29 18:38:57 +02:00
Mir Bhatia 484301752f Remove changes from fetcher_integration_spec 2023-03-29 17:56:02 +02:00
Mir Bhatia 21993dd100 Fix fetcher_integration_spec 2023-03-27 13:23:07 +02:00
Mir Bhatia 7721596d12 Fix broken specs 2023-03-27 13:23:07 +02:00
Mir Bhatia 54badcd5cc Add failing tests 2023-03-27 13:23:07 +02:00
Christophe Bliard c43fccf246 lint: autocorrect Style/HashSyntax
command is

    rubocop -A --only Style/HashSyntax app lib lib_static modules spec
2023-03-07 15:07:44 +01:00
Christophe Bliard aa23106c11 lint: autocorrect RSpec/FactoryBot/ConsistentParenthesesStyle
command is

    rubocop -A --only RSpec/FactoryBot/ConsistentParenthesesStyle modules spec
2023-03-07 15:04:32 +01:00
Christophe Bliard 09c76f987c refactor: Reduce code duplication
`Activities::DaysComponent` factorizes the code to generate the HTML for
the activities per days.

By moving `journal` into `Activities::Event`, `journals_by_id` does not
need to be passed around anymore. Eager loading of journals is moved to
`Activities::Fetcher` instead of being handled by the controller. It
also means that the atom feed will be slower as it does not need the
journals information.
2023-02-16 16:34:07 +01:00
Christophe Bliard 85b3258a29 Autocorrect with some rubocop cops
RSpec/Rails/InferredSpecType and Style/RedundantConstantBase

rubocop --autocorrect-all --only RSpec/Rails/InferredSpecType,Style/RedundantConstantBase spec modules/*/spec
2023-01-13 14:28:59 +01:00
Christophe Bliard 556f2d57da Fix flaky test
Events can be any type, and some types can have identical ids. Thus asserting on ids only is brittle. Filtering for work packages and then testing ids fixes the flakiness.
2023-01-02 09:43:18 +01:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Christophe Bliard 4c44c91ada Fix tests about project activity being present now 2022-12-12 14:48:44 +01:00
Oliver Günther 7710c4bf0f Fix meeting spec directly setting time and refactor 2022-09-05 09:06:51 +02:00
Oliver Günther 11b45715f8 Use times for the find_events method 2022-09-01 21:43:28 +02:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
Christophe Bliard a33524ef6d remove ruby magic comment for utf-8
ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless
2022-03-10 19:36:58 +01:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Christophe Bliard 47a297daae Fix argument alignment since f08bea3467 (#10129)
* Fix argument alignment since f08bea3467

The FactoryBot.* prefix has been removed in f08bea3467. Since then
rubocop complains about Layout/ArgumentAlignment. This commit fixes it.

* do not fix alignments for modules/*/spec yet

hoping to be under the limit of 65535 characters for reviewdog to report on rubocop errors
2022-02-02 21:48:06 +01:00
Oliver Günther f08bea3467 Remove FactoryBot.* prefix where applicable 2022-01-25 08:19:06 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
ulferts 1bdd2ab9ae safe automatic fixes by rubocop (#8994) 2021-02-11 16:02:18 +01:00
ulferts 6140f4c7e9 update copyright to 2021 (#8925)
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.

Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
ulferts 64d0f57d85 Feature/aggregated activities (#8221)
* use cte for aggregated journal

* Revert "use cte for aggregated journal"

This reverts commit 5fedefefdd.

* add another subselect that could later on be provided from the outside

* allow passing a nukleous sql to aggregated journals

* wip - using aggregated journal for activity

* new sql for aggregated journals

* start implementing new aggregated query

* additional documentation

* consolidate activity functionality

* simplify by turing into instance methods

* move activity fetcher out of redmine

* remove verb verification made obsolete

Without catchall routes, the dispatching handles it

* remove duplicate authorize check

* refactor activities controller

* refactory activity fetcher

* cache avatar file

* sort choosable events

* remove legacy spec covered by contemporary

* speed up aggregated journals via CTE

* instance var might never have been set

* ensure the event_types are always transmitted

* correctly reset the avatar cache

* fix avatar fetcher expectation regarding wiki pages

* adapt spec

[ci skip]
2020-04-27 08:04:28 +02:00