* Create a FullView::CopyComponent for WorkPackages which is routed from rails
* Remove angular splitCopy route and component as it was overwritten by the angular fullCopy route for quite some time already and nobody complained. So we decided to remove the splitCopy completely
* Create FullView::CreateComponent for WorkPackages which is now routed from rails instead of Angular
* First draft of implementing the FullView route for WorkPackages from rails
* Pass correct tab from the URL to the FullView::ShowComponent
* Do a hard reload to "create" route when we are not routed from Angular
* Adapt routing spec to new WorkPackage routes and to some fine-tuning with the WP routes
* Show correct tab in WP Full view and change URL when clicking a tab entry
* Adapt to new rails based routing
* Fix some routes and redirects
* Make sure, the split screen stil renders correctly
* Remove back button from WP full view
* Fix routing issues
* Start fixing specs
* Attempt to override the browser history to be able to use browser back
* Use helper function to build new WP url string
* Adapt spec that now partially renders backend toasts
* Remove ability to move to fullscreen
Theoretically, we can re-add it by posting to some form endpoint, but
not worth it for the first iteration
* Disable cache-control on angular routed pages, so back links work
* Fix double click to fullscreen
* Adapt navigation and title setting
* Let WP breadcrumb to a hard reload instead of Angular transition
* Redirect when the WP route is incomplete (this is the attempt to re-implement an angular functionality)
* Navigate with Turbo when double clicking a card
* Adapt onboarding tour to new hard reload when switching to WP full view
* Fix some specs
* Fix more tests
* Hide Overview tab on FullView
* Correct check for incomplete routes
* Do a hard refresh when coming from slpit screen to full view
* Fix notification navigation
* Adapt attachment spec as the tab switch cannot be done anymore while dragging
* Fix more tests
* Please rubocop and fix more tests
* Attempt to fix navigation_spec
* Add debian_base for pullpreview
---------
Co-authored-by: Oliver Günther <mail@oliverguenther.de>
Attachment scenarios are covered in `spec/features/activities/work_package/activity_tab_comment_editor_spec.rb`
Notably: there is no longer a special permission for adding attachments to wp comments, rather they are treated
as inline- if a user can comment, then they can add attachments.
The lifecycle of the attachment is tied to it's containing comment.
The flaky test fixed 59eb308cbb was failing because the test was not
waiting for the attachments element to be displayed. In some other
similar tests, the code was waiting for it, and one test ever scrolled
to that element.
If code was properly factored, the above test would never have been
flaky.
This commit is an attempt to factor the interactions with the
attachments list so that the next test written using it will be reliable
by default.
* Initial attachment list changes
* Merge attachment list and uploads
* Move upload mechanisms to op-attachment
* Refactoring attachment styles
* Fix state handling of attachments
* Drag and drop works
* Improve drop zone styles
* Small style improvement
* Remove debug log
* Finished wiki attachments upload spec
* Attachments upload spec for forum works
* Add feature spec for document drag & drop
* Add feature spec for budget attachment drag & drop
* Add feature spec for workpackge attachment drag & drop
* Add default value for attachment list to fix specs
* Fix attachment list for work package create page, remove unused styles
* Fix linting errors
* Add extra checks in document attachment uplaod spec
* Adress PR comments
* Fix broken selector in spec
* Make sure to blur in the ckeditor instance
* Fix meeting module attachment spec
* Fix qa selector
* Fix eslint errors
* Fix rubocop errors
- https://community.openproject.org/work_packages/41340
- added new files tab to wp details view
- added attachments components to files tab
- removed attachments from wp single view, except for wp creation
- fixed a couple of eslint issues in affected files
- migrated attachments to resource store
- added upload to attachment store
- pull in newly built ckeditor
- removed old, hacky regression test
* Fix argument alignment since f08bea3467
The FactoryBot.* prefix has been removed in f08bea3467. Since then
rubocop complains about Layout/ArgumentAlignment. This commit fixes it.
* do not fix alignments for modules/*/spec yet
hoping to be under the limit of 65535 characters for reviewdog to report on rubocop errors
* Rename most notification to toaster instances
* Frontend builds
* Fix spec build
* Rename more notification elements to toaster
* Rename toaster-box to op-toast
* Fix op-toast-container
* Rename toasters upload progress
* Try fixing page.rb toaster check
* Fix some specs, break some others
* Correctly overwrite toast_type
* Fix more specs
* Fix one more notification to toaster rename
* Fix linting errors, harmonize naming more
* Remove byebug debugging statement
* Remove byebug debugging statement
* Rename notification in the backend, too
* Rename more instances of notifications to toastService
* Rename backend back to notification since bundle gems expect it there
* expect_toaster -> expect_toast
Co-authored-by: Henriette Darge <h.darge@openproject.com>
This is a refactoring of the CSS classes in the WYSIWYG editor. The classes now use proper BEM and are almost completely independent of other CSS. It also includes small style refactorings, like a reduction of heading size in attribute fields, and an increase in heading size in all other instances.
* Initial class definitions
* Added more classes
* Added Table of Contents basics
* CkEditor applying custom CSS classes to p, h1, h2, h3, h4, h5, h6, li and blockquote
* CKEditorInspector removed
* op css class for headings
* op css class for paragraphs
* op css class for code/code block
* adapt specs to altered markdown/html generation
* adapt grid/budget representers to altered signature
* op css class for lists
* op css class for toc
* op css class for links
* Start working on typography css
* op css class for tables
* Fixing more typography, trying out larger headers
* Applying custom classes to li, a, blockquote, figure, table, tr, td, th, image, codeblock, figcaption and macros
* adapt specs to altered link classes
* op css class for images
* apply user content container class throughout application
* CSS alignment custom classes applied to table
* op css class for task list checkbox
* Added task checkbox class
* amend list checkbox class in backend
* op css class for table thead element
* adapt specs on image html generation
* Updated table and typography styles
* Update typography and figure styles
* Figure overflow handling
* Table alignment styles + ckEditor styles removed
* rename wiki-anchor to op-uc-link_permalink
* wrap table in div as well as figure
* Updated code-block
* Update permalinks
* Fixed a lot about tables
* Removed Description header from work-packages page
* Fix frontend styles
* Add placeholder styling, fix toc
* Fixed figure print
* working with table aligns
* Custom class add to task lists
* Custom classes applied to theads
* op-uc-container custom class added to container
* Codeblocks inside pre elements
* Fix: single <code> and <a> tags
* explicitly require overwritten gem class
Apparently, the gem is not loaded yet when it is registered as a filter when in eager loading mode
* adapt spec expectation to altered toc rendering
* CkInspector removed
* Latest ckeditor changes
* remove highlight css class from wiki content
* allow html pipleline to handle macros with additional classes
* Fixed a lot of print css for tables
* Add general print css back in
* Update Table of Contents styling
* Custom classes on ul, ol, li and task-lists
* Revert "Custom classes on ul, ol, li and task-lists"
This reverts commit 0d27d28137.
* Custom classes on ul, ol, li and task-lists
* Custom classes on column's th
* remove placeholder class when rendering
* WOrking on task lists
* Changing task-list classes, changed tests
* Updated list styles
* Remove unused todo list styles
* remove checked in binstubs
* Fix table of contents
* adapt todo list handing in backend pipeline
* adapt specs to altered css classes
* Add numbers to table of contents
* Better comments in table of contents
* Fix: wrap single <table> with a <figure>
* Fixes to todo list design
* Updated todo list scss to fix nested lists
* adapt selectors in table spec
* Update table styles
* Improve table borders more
* Custom classes specs
* Fix: no need to remove regular list classes when its type changes
* Add modifier for inline headings
* Update table editing styles
* Remove break-word tests
* wrap images just like tables
* Update figure content styles
* Fix: All tests passing (ul.op-uc-list_task-list)
* div.op-uc-figure--content wrapping tables
* Specs for figures wrappers div.op-uc-figure--content
* Fix: add custom classes to links and codes again
* Table wrapper div reverted + specs
* Fix inline palceholders
* Custom macro type classes
* Add basic macro placeholder changes
* Move heading permalink after text
* Fix word-break spec
* Sending figure styles to the backend (width)
* extend test to take ckeditor placeholder into account
* avoid adding bem classes multiple times
* attempt to fix flickering spec
* Removing image spinner when uploading finishes
* adapt spec expectations
Co-authored-by: Aleix Suau <info@macrofonoestudio.es>
Co-authored-by: ulferts <jens.ulferts@googlemail.com>
Henriette Darge