modules/team_planner/spec/features/query_handling_spec.rb sometimes
misses the dropdown, because it does not wait long enough after adding a
filter, and once the filter is applied, the page state is reset and the
dropdown is closed, which leads to the error.
Estimated time => Work
Remaining time => Remaining work
Progress (%) => % Complete
The export pdf test needed to be fixed too: The test has been updated to expect
only 1 page instead of two. As fields having been renamed, they are now
shorter. So some vertical space is saved and the additional page break
is not triggered anymore before rendering the custom fields.
There was a race-condition where the saving of the query was happening
as the update request for the added filter was also happening, causing
the frontend to not register the save as a successful creation but
as a successful update (from the added filter), causing the spec to
fail under conditions where it's execution was too fast.
The bcf_view_management spec is behaving a bit differently than others.
After adding the first filter, the filter count is still expected to
be "1" for some reason and starts incrementing with every other filter
added from then on. An injectable `initial_filter_count`.
**NOTE**: This is only a patch to aid in the flakiness that everyone
is experiencing but ultimately I would expect the "Save" button and
the "Save as" button to be disabled until every already performed
request is done (which would prevent this from happening to some users
just performing things at Capybara speed, or for some users under high
latency regions).
Jan Sandbrink