spec is ./modules/reporting/spec/features/update_entries_spec.rb:72
job run is https://github.com/opf/openproject/actions/runs/14646323170/job/41135997810
It was failing when submitting the time logging modal before the work
package was loaded. As it was not loaded, it was empty, and as it was
empty, it was displaying an error "Work package is invalid" and the time
was not updated.
As the time was not updated, the spec was failing looking for "2.00
hours" (the new value) but only getting "5.00 hours" (the old value).
Fix is to wait for the autocompleter to be fully loaded before
proceeding with submit. This is done by waiting for `ng-spinner-loader`
to not be visible anymore.
This is needed to make these two statements equivalent:
expect(page).not_to have_xpath('a')
expect(page).to have_no_xpath('a')
So that the both matchers return early on element absence, instead of
timing out.
This is the continuation of e85b47979a.
* [#43684] migrated op-modal to spot-modal
- https://community.openproject.org/work_packages/43684
- amended styles
- removed "modal--title"
- removed header component
- removed closing icon
- fixed backdrop click
- removed jquery from modal service
* [#43684] removed unused styling
- fixed some inconsitencies
- readded removed icon
- removed listener on close button
* [#43684] combined spot-action-bar
- used spot-action-bar in combination with spot-modal--footer
- fixed some styling in action bar
* [#43684] replaced more op-modal
- moved spec selectors to spot-modal
- replaced found op-modal in html templates
* [#43684] add no margin to old buttons in new dialogs
- added mobile modal behavior
- fixed some feature spec selectors
* [#43684] added modal close on mobile resolutions
* [#43684] fixed PR issues
- removed old css classes from html
- fixed feature spec click
- readded tour trigger on modal cancel
* when clicking outside the modal it will be closed instaed of clicking on a close button
* exclude _center class from spot-modal sass file itself and add it to the component style sheet
* Words should be break in any case like when there is no space there
* remove unnecessary classes that never used like _fullscreen and _cente, remove _limited-height class to make all the modal look the same
Co-authored-by: bsatarnejad <b.satarnejad@gmail.com>
Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>
- https://community.openproject.org/work_packages/39772
- added op-sidemenu to wp-query-select
- replaced jquery ui in wp-query-select
- added css padding override for items with icon in op-sidemenu
- changed databinding to observables
- Rename "collapsible menu" to "searchable menu" and let it handle only the things needed for the searching.
- Apply correct classes for query-select-menu so that it is scrollable again
- All other (obsolete) parts have been removed.
- Adapt test to new styling of reports sidebar
* Replace accessible-by-keyboard
* Replace messed up inplace styles with work-package-comment bem block
The styles are not used anymore except for work package comments anyway
* Replace split view icons with buttons
* Make back-button its own bem block
* Replace button in hide-section component
* Replace activity buttons
* Replace notification icon
* Replace collapsible-section
* Replace config-menu
* Make attribute help text trigger a button
* Ensure all buttons are role=button
* Replace inplace save controls
* Replace relations buttons
* Replace relation toggle button
* Replace relation row buttons
* Replace breadcrumb parent
* Replace activities toggler
* Remove accessible-by-keyboard component
* Fix button role to button type
* Fix indent
* Bemmify media query
* Fix specs
Mir Bhatia