The flaky test fixed 59eb308cbb was failing because the test was not
waiting for the attachments element to be displayed. In some other
similar tests, the code was waiting for it, and one test ever scrolled
to that element.
If code was properly factored, the above test would never have been
flaky.
This commit is an attempt to factor the interactions with the
attachments list so that the next test written using it will be reliable
by default.
* [#43577] Fix drag and drop by counting drag over and leave
- https://community.openproject.org/work_packages/43577
- replace action button text for attaching files
- refactored drag and drop behaviour
- on any global dragenter increase a counter
- on any global dragleave decrease counter
- if counter is 0 -> no global dragging is happening (mouse was moved out of window)
- this way, we are independent from the order in which the DragEvents are fired by the browser (bigger differences between Firefox and Chrome)
Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>
* Initial attachment list changes
* Merge attachment list and uploads
* Move upload mechanisms to op-attachment
* Refactoring attachment styles
* Fix state handling of attachments
* Drag and drop works
* Improve drop zone styles
* Small style improvement
* Remove debug log
* Finished wiki attachments upload spec
* Attachments upload spec for forum works
* Add feature spec for document drag & drop
* Add feature spec for budget attachment drag & drop
* Add feature spec for workpackge attachment drag & drop
* Add default value for attachment list to fix specs
* Fix attachment list for work package create page, remove unused styles
* Fix linting errors
* Add extra checks in document attachment uplaod spec
* Adress PR comments
* Fix broken selector in spec
* Make sure to blur in the ckeditor instance
* Fix meeting module attachment spec
* Fix qa selector
* Fix eslint errors
* Fix rubocop errors
- https://community.openproject.org/work_packages/41340
- added new files tab to wp details view
- added attachments components to files tab
- removed attachments from wp single view, except for wp creation
- fixed a couple of eslint issues in affected files
- migrated attachments to resource store
- added upload to attachment store
- pull in newly built ckeditor
- removed old, hacky regression test
* Fix argument alignment since f08bea3467
The FactoryBot.* prefix has been removed in f08bea3467. Since then
rubocop complains about Layout/ArgumentAlignment. This commit fixes it.
* do not fix alignments for modules/*/spec yet
hoping to be under the limit of 65535 characters for reviewdog to report on rubocop errors
* Rename most notification to toaster instances
* Frontend builds
* Fix spec build
* Rename more notification elements to toaster
* Rename toaster-box to op-toast
* Fix op-toast-container
* Rename toasters upload progress
* Try fixing page.rb toaster check
* Fix some specs, break some others
* Correctly overwrite toast_type
* Fix more specs
* Fix one more notification to toaster rename
* Fix linting errors, harmonize naming more
* Remove byebug debugging statement
* Remove byebug debugging statement
* Rename notification in the backend, too
* Rename more instances of notifications to toastService
* Rename backend back to notification since bundle gems expect it there
* expect_toaster -> expect_toast
Co-authored-by: Henriette Darge <h.darge@openproject.com>
* destroy notifications upon journal destruction
* breakup spec by journable
* have a dedicated job for scheduling journal completed events
* generate notifications in delayed job
* route wiki journal events through notifications
* combine mail sending for notifications into single job
* robustness if a journal is deleted
* linting
* differentiate BaseJournal and AssociatedJournal
BaseJournal holds the data of a journal that reflects the columns in the journaled model while AssociatedJournal reflects the columns of a model associated to the journaled model via a has_many/one association
* route news journal events through notifications
This does not yet include notifications for comments on news
* include news comment in notification workflow
* have the whole workflow in a single state machine job
* include forum message in notification workflow
* include document in notification workflow
* less dependencies from acts as watchable
* fix, test and document workflow job
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.
Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
* rename timestamps on time entry
* add updated_at filter/order for time entries
* rename on cost entries as well
This will make handling in the cost query easier
* adapt specs
* linting
* adapt project activity
* update references to updated_on
* remove outdated docs/code
* global memberships are just memberships
* rewire global membership creation/update/deletion
* delete no longer required code and patches
* move code to core
* move specs to core
* completely remove global roles in the form of a plugin
* adapt specs
* remove unused methods
* migrate existing data
* adapt membership representer to changed timestamps
* global memberships available via API
* implements created/update_at filters on memberships
* update member on roles being added/removed
* specify default value for created_at
* fix project permission check and validation on members
* adapt membership schema
* adapt usage of sort by on members widget
* support created/updated_on for api sort and filter
* remove outdated model file
* rename timestamps
* allow specifying timestamp column for aaj
* reload column information
* further rename of created_on
* include updated_at into journal creation
* adapt document updated_at calculation
* remove references to JournalVersion
Jan Sandbrink