Verify that semantic work package identifiers (e.g. "TESTPROJ-1")
are resolved end-to-end through the controller and API layers,
using with_settings/with_flag helpers instead of allow mocks.
Replace stubbed work package and mock permission chain with real
database records and role membership. This eliminates rubocop violations
(ExpectInHook, StubbedMock, MessageChain) while also testing the actual
finder path through WorkPackage.visible.
Extract FinderMethods module that transparently resolves both numeric and
semantic identifiers (e.g. "PROJ-42") using FriendlyId's Object#friendly_id?
for dispatch. The module is included in both the WorkPackage class and
extended onto every relation, so scoped queries like
WorkPackage.visible(user).find("PROJ-42") work seamlessly.
- Override find to resolve semantic IDs via identifier column + alias table
- Override exists? with the same resolution chain
- Refactor find_by_id_or_identifier to use friendly_id? instead of semantic_id?
- Update API route to accept string IDs (type: Integer → type: String)
- Update controller and ViewComponent finders to use find_by_id_or_identifier
- Pass display_id from Rails views to Angular custom elements
Adds `GET /api/v3/projects/:id/configuration` endpoint that returns
all global configuration properties plus project-specific settings.
This allows client apps to check both enterprise token features
(availableFeatures) and project settings (enabledInternalComments)
in a single API call.
* Create a FullView::CopyComponent for WorkPackages which is routed from rails
* Remove angular splitCopy route and component as it was overwritten by the angular fullCopy route for quite some time already and nobody complained. So we decided to remove the splitCopy completely
* Create FullView::CreateComponent for WorkPackages which is now routed from rails instead of Angular
* First draft of implementing the FullView route for WorkPackages from rails
* Pass correct tab from the URL to the FullView::ShowComponent
* Do a hard reload to "create" route when we are not routed from Angular
* Adapt routing spec to new WorkPackage routes and to some fine-tuning with the WP routes
* Show correct tab in WP Full view and change URL when clicking a tab entry
* Adapt to new rails based routing
* Fix some routes and redirects
* Make sure, the split screen stil renders correctly
* Remove back button from WP full view
* Fix routing issues
* Start fixing specs
* Attempt to override the browser history to be able to use browser back
* Use helper function to build new WP url string
* Adapt spec that now partially renders backend toasts
* Remove ability to move to fullscreen
Theoretically, we can re-add it by posting to some form endpoint, but
not worth it for the first iteration
* Disable cache-control on angular routed pages, so back links work
* Fix double click to fullscreen
* Adapt navigation and title setting
* Let WP breadcrumb to a hard reload instead of Angular transition
* Redirect when the WP route is incomplete (this is the attempt to re-implement an angular functionality)
* Navigate with Turbo when double clicking a card
* Adapt onboarding tour to new hard reload when switching to WP full view
* Fix some specs
* Fix more tests
* Hide Overview tab on FullView
* Correct check for incomplete routes
* Do a hard refresh when coming from slpit screen to full view
* Fix notification navigation
* Adapt attachment spec as the tab switch cannot be done anymore while dragging
* Fix more tests
* Please rubocop and fix more tests
* Attempt to fix navigation_spec
* Add debian_base for pullpreview
---------
Co-authored-by: Oliver Günther <mail@oliverguenther.de>
* Fix argument alignment since f08bea3467
The FactoryBot.* prefix has been removed in f08bea3467. Since then
rubocop complains about Layout/ArgumentAlignment. This commit fixes it.
* do not fix alignments for modules/*/spec yet
hoping to be under the limit of 65535 characters for reviewdog to report on rubocop errors
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.
Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
* deprecated method
* remove apparently unused methods
* append id desc sorting to work packages
* enforce sorting is applied in query results
* ensure deterministic order in base query
* Hack spike to show D&D use case
[ci skip]
* Add ordered work packages
* Save order on existing work packages
* Boards WIP
* CDK drag
* Add dragula handler
[ci skip]
* Add filter to return all manual sorted work packages
* Print icon on hover
* Boards routing and list components
* Better loading indicator on list with streaming result
[ci skip]
* Add new board and list buttons
[ci skip]
* Post new query
[ci skip]
* Added creation of new board lists with persisted queries
[ci skip]
* Render placeholder row in empty queries
[ci skip]
* Push boards on grid
* Use base class in scope
[ci skip]
* Extend api for options
* Hack spike to show D&D use case
[ci skip]
* Add ordered work packages
* Save order on existing work packages
* Boards WIP
* CDK drag
* Add dragula handler
[ci skip]
* Add filter to return all manual sorted work packages
* Print icon on hover
* Boards routing and list components
* Better loading indicator on list with streaming result
[ci skip]
* Add new board and list buttons
[ci skip]
* Post new query
[ci skip]
* Added creation of new board lists with persisted queries
[ci skip]
* Render placeholder row in empty queries
[ci skip]
* Save queries in grids
[ci skip]
* Renaming queries
[ci skip]
* Add existing work packages to board
[ci skip]
* Introduce card view component for work packages
* Extend grids to allow project scope for boards (#7025)
Extends the grid backend to also be able to handle boards. In particular, it adds the ability of boards to be attached to projects and changes the page property of grids to a scope property that better describes that more than one board can belong to the same scope (e.g. /projects/:project_id/boards).
For a fully featured board, though, widgets need to be able to store options, so that they can store queries. Those widgets might also need to have custom processing and validation. That part has not been implemented.
* introduce project association for boards
* have dedicated grid registration classes
* update and create form for board grids
* extract defaults into grid registration
[ci skip]
* Add drag and drop to card view
[ci skip]
* Add options to grid
* Fix option migration name
* Renaming boards
[ci skip]
* Frontend deletion of boards
* Avoid map on NodeList which doesnt exist
[ci skip]
* Add inline create to boards
[ci skip]
* Smaller create button
[ci skip]
* Add navigation for boards
* Make inner grid same height
* Replace index page with table
* Workaround for widget registration
[ci skip]
* Fixed height for cards and tables
[ci skip]
* Implement escape as cancel d&d action
[ci skip]
* Fix and extend grid specs for name and options
* Extend board specs for required name
* Fix migration for MySQL references
https://stackoverflow.com/a/45825566/420614
* Make board list extend from widget
Since we cannot configure widgets yet, it's not yet possible to use a
board-list widget anywhere.
* Fix specs
* Fix escape listener removal
[ci skip]
* Fix renamed to_path in relation spec
[ci skip]
* Allow deletion of grids for boards
* Avoid reloading resource multiple times with replays
* Frontend synchronization on deletion
[ci skip]
* Delete through table
* Use work packages board path
* Use work packages board path
* Fix augmented columns breaking re-rendering
* Fix duplicated permission with forums
* Strengthen tab switch in specs
* Add hidden flag for project-context queries
Allows the API to create a hidden query that will not be rendered to the
user even if it is within a project context.
* private queries
* Add hidden flag for project-context queries
Allows the API to create a hidden query that will not be rendered to the
user even if it is within a project context.
* Move boards below work packages
* Add Board configuration modal
* Fix reloading with onPush
* Saving / Switching of display mode
[ci skip]
* Extract wp-query-selectable-title into common component
* Fix renaming of board-list
* Fix auto-hide notifications in boards
* Add permissions to seeders
* Reorder lists in board
* Linting
* Remove default gravatar from settings
* Show assignees avatar in the card view of WPs
* Fix specs
* Add missing method
* Fix timeline icon
* Use URL as input to be able to show avatars for groups, too
* Fix test
* Add further specs
* Use correct data attribute to avoid unnecessary data base calls
* Add further specs
* Deletion of board lists
* Pass permission via gon to decide whether we can create boards
* Fix rename spec
* Cherry-pick of 7873d59 and 30abc7f
* replace rails based calendar with angular
* render empty calendar
* update query on month switch
* introduce specific interval filter
* show colors
* remove now unused filter partial
* start on retaining the view in the url
* hide datesInterval filter
* I18n for calendars title
* stengthen explicity of expected filters
* spec moving to the next month
* fix FilterSerializer reference
* remove outdated feature spec
* rework calendar controller specs
* avoid undefined columns
* bump ng-calendar to 1.7.0
* Revert "fix FilterSerializer reference"
This reverts commit 2bb2e574cdd664a02a4eb9c3e94b5a170aec0a67.
* Revert "avoid undefined columns"
This reverts commit bcbb381b34b095526d3ee1aa15d6263a658c03c0.
* load initial query only after calendar has been loaded
* implement month remembering
* implement history back and forth
* cleanup code
* remove unused methods
* remove order value from filters
* replace rails calendar widget completely
* fix shrinkwrap
* move module into correct namespace
* linting
* remove unused js
* calculate full calendar height dynamically
* setting calendar locale from service
* retain week on reload
* show notification in case of too many results
* show tooltip on hover
* go to work package on click
* deactivate tooltip before wp show
* narrow down style to tooltip
* [28885] Improve html title consistency when navigating to queries
Currently, query names are not reflected in the HTML title. This results in 'wrong' titles being shown when entering a split or full view and then returning back to the list.
https://community.openproject.com/wp/28885
[ci skip]
Tomas Hykel