Henriette Darge
4b1fc96ccd
Show banner after successfully deletion of version
2026-04-30 09:26:27 +02:00
Jan Sandbrink
0b87e7543f
Freeze string literals in specs
...
Rolling out frozen string literals further by freezing all
string literals in core specs.
2025-05-05 09:29:55 +02:00
Henriette Darge
a1809640fe
Adapt tests to new PageHeader structure
2024-11-26 11:08:17 +01:00
Oliver Günther
fa99c5bef6
Render with status: :unprocessable_entity
2024-10-11 08:42:58 +02:00
Ivan Kuchin
4911b8a149
remove years from copyrights (except for COPYRIGHT file)
2024-07-31 15:02:49 +02:00
Ivan Kuchin
0b87ed9b6a
remove newlines from context descriptions
2024-07-29 19:27:17 +02:00
Christophe Bliard
a885fef2bd
Conform to RSpecRails/HaveHttpStatus cop
...
With a hack to get `have_http_status` to work with `Rack::MockResponse`.
2024-06-24 17:50:57 +02:00
ulferts
3b2121f733
Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
...
This reverts commit 40b2bbeb09 , reversing
changes made to b4c6cb17cc .
2024-03-21 11:31:17 +01:00
Ivan Kuchin
7787e457a3
Revert "Merge branch 'dev' into release/13.4"
...
This reverts commit a901541269 , reversing
changes made to e573ca00b7 .
2024-03-20 20:19:08 +01:00
Ivan Kuchin
9e4934cd0a
change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a
2024-03-20 18:05:22 +01:00
Christophe Bliard
c795874f7f
Update copyright year for 2024
...
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
ulferts
60ed64cd04
use error_messages_for method now
2023-10-24 12:06:36 +02:00
Aaron Contreras
72798a05e2
Fix Sub Projects filter in Roadmap unable to be deselected
...
By adding a `hidden_field_tag` with a value of 0, clicking on "Apply"
will submit the param as a _falsey_ value, allowing for the deselect
behavior, while maintaining the intent of including the subprojects
by default unless told otherwise if the setting dictates so.
2023-08-09 17:20:05 -05:00
Christophe Bliard
4c2a9d0aa8
Enable RSpec zero monkey patching mode
...
The plan for RSpec 4.0 is to disable monkey patching.
See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.
2023-05-31 19:22:29 +02:00
Christophe Bliard
aa23106c11
lint: autocorrect RSpec/FactoryBot/ConsistentParenthesesStyle
...
command is
rubocop -A --only RSpec/FactoryBot/ConsistentParenthesesStyle modules spec
2023-03-07 15:04:32 +01:00
Christophe Bliard
85b3258a29
Autocorrect with some rubocop cops
...
RSpec/Rails/InferredSpecType and Style/RedundantConstantBase
rubocop --autocorrect-all --only RSpec/Rails/InferredSpecType,Style/RedundantConstantBase spec modules/*/spec
2023-01-13 14:28:59 +01:00
Christophe Bliard
21a696ef9b
Update copyright information for 2023
2022-12-30 15:51:26 +01:00
Christophe Bliard
48a4f1b6ad
lint with rubocop --autocorrect (safe cops only)
2022-06-02 10:40:10 +02:00
Christophe Bliard
bc8d423ec2
update copyright information for 2022
2022-03-01 17:05:59 +01:00
Oliver Günther
f08bea3467
Remove FactoryBot.* prefix where applicable
2022-01-25 08:19:06 +01:00
ulferts
f89f19dffc
use resouce based routing
2021-10-29 15:48:18 +02:00
ulferts
83cdefaa55
move version to nested settings
2021-10-28 12:44:44 +02:00
Oliver Günther
ccfa29c728
Move license and copyright docs to root, fix names and references
2021-09-02 21:50:46 +02:00
ulferts
1bdd2ab9ae
safe automatic fixes by rubocop ( #8994 )
2021-02-11 16:02:18 +01:00
luz paz
3683042c9b
Fix typos in user facing and non-user facing code
...
Found via `codespell v2.1.dev0`
2021-01-24 15:08:21 +01:00
ulferts
6140f4c7e9
update copyright to 2021 ( #8925 )
...
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.
Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
ulferts
0b15db3c9a
rename fixed_version to version
2020-03-27 09:10:44 +01:00
ulferts
85390687b7
adapt specs
2020-03-25 14:39:27 +01:00
Henriette Dinger
bd7f4e4814
Update copyright notice
2020-01-15 11:31:26 +01:00
Henriette Dinger
7167a85cb0
Fix specs by correcting the project settings paths and do some minor selector changes
2020-01-06 10:51:19 +01:00
ulferts
a749e40c45
enforce setting existing wiki page for version
2019-12-10 13:35:22 +01:00
Markus Kahl
9826318412
don't map IDs on IDs
2019-05-29 11:39:52 +01:00
Oliver Günther
183ad1480e
Replace deprecated controller success? with succesful?
2018-12-03 10:31:58 +01:00
Jens Ulferts
8acc345eaf
implement replacing graph on version/show by embedded graph
2018-10-09 13:29:20 +02:00
Oliver Günther
059770f533
FactoryGirl => FactoryBot
...
Removes the deprecation
2018-05-07 22:38:20 +02:00
Oliver Günther
6ef4211e77
Bump copyright to 2018 ( #6171 )
...
[ci skip]
2018-02-12 08:51:12 +01:00
Oliver Günther
7cf11bb689
Update copyright notice
2017-01-10 15:11:43 +01:00
Oliver Günther
92aebdcec4
Fix params deprecation
...
Fixes in spec/controllers:
```
DEPRECATION WARNING: ActionController::TestCase HTTP request methods will accept only
keyword arguments in future Rails versions.
```
2016-10-17 11:56:44 +02:00
Oliver Günther
57a4539ddb
Remove unused format.js versions#create
2016-09-05 09:05:58 +02:00
Mohamed Wael Khobalatte
6f1d668c39
Fix issue with versions/new being not accessible
2015-10-23 17:57:16 +02:00
Mohamed Wael Khobalatte
626779d92d
Use assert_select instead of deprecated assert_tag
2015-10-04 20:37:54 +01:00
Stefan Botzenhart
1c01b5801e
Use login_as helper method throughout all specs
2015-10-02 16:50:57 +02:00
Oliver Günther
471fc04663
Fix ActionController::InvalidCrossOriginRequest in specs
...
https://github.com/rails/rails/pull/13345 introduced CSRF protection
to gets with JavaScript responses.
2015-08-19 16:28:57 +02:00
Alex Coles
ce93701029
Fix syntax (w/Rubocop) in specs
...
Signed-off-by: Alex Coles <alex@alexbcoles.com >
2015-06-30 12:08:28 +02:00
Alex Coles
57618b25ec
Replace dynamic finder usages with #find_by, etc.
...
This patch replaces all dynamic finders, for the sake of consistency,
although only some methods are deprecated. See:
https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders
* Revert some `User#find_by_login` usages in cuke steps accidentally
removed in 74228b59 .
User Story # 20325
Signed-off-by: Alex Coles <alex@alexbcoles.com >
2015-06-30 11:50:26 +02:00
Alex Coles
077e42ba06
Make VersionsController#update use PATCH
...
Signed-off-by: Alex Coles <alex@alexbcoles.com >
2015-06-11 10:52:42 +02:00
Alex Coles
e49a3c0deb
Update HTML attr order in VersionsController spec
...
Signed-off-by: Alex Coles <alex@alexbcoles.com >
2015-05-02 02:17:44 +02:00
Alex Coles
e5da2578d5
Merge branch 'dev' into feature/rails4
...
Signed-off-by: Alex Coles <alex@alexbcoles.com >
Conflicts:
.travis.yml
Gemfile
Gemfile.lock
README.md
app/assets/stylesheets/external.css.sass.erb
app/assets/stylesheets/legacy/main.css.sass
app/models/work_package.rb
config/routes.rb
lib/tabular_form_builder.rb
spec/controllers/versions_controller_spec.rb
spec/exemplars/type_exemplar.rb
spec/factories/type_factory.rb
spec/legacy/unit/default_data_spec.rb
spec/legacy/unit/helpers/application_helper_spec.rb
spec/legacy/unit/mail_handler_spec.rb
spec/legacy/unit/project_spec.rb
spec/legacy/unit/time_entry_activity_spec.rb
spec/legacy/unit/type_spec.rb
spec/models/work_package/work_package_validations_spec.rb
spec/requests/api/v3/render_resource_spec.rb
test/functional/types_controller_test.rb
test/test_helper.rb
test/unit/version_test.rb
2015-05-01 11:39:24 +02:00
Alex Coles
a5b827209b
Merge branch 'dev' into feature/rspec-3
...
Signed-off-by: Alex Coles <alex@alexbcoles.com >
Conflicts:
spec/lib/api/v3/work_packages/schema/work_package_schema_spec.rb
spec/models/work_package_spec.rb
2015-03-21 10:56:39 -03:00
Alex Coles
fda43ac304
Replace VersionsController#create RJS with jQuery
...
Matches `CategoriesController#create` implementation: see 4cc9aaf8 .
Signed-off-by: Alex Coles <alex@alexbcoles.com >
2015-03-12 17:57:36 -03:00