59 Commits

Author SHA1 Message Date
Mir Bhatia 027c006bba Fix link 2026-04-01 09:37:01 +02:00
Mir Bhatia 42620b5af2 Revert "Fix link"
This reverts commit fea3a14b50.
2026-04-01 09:31:58 +02:00
Mir Bhatia fea3a14b50 Fix link 2026-04-01 09:27:51 +02:00
Klaus Zanders 20060a86b6 Allow to access news#show globally 2026-02-10 18:32:36 +01:00
Klaus Zanders 05df992b61 Properly load news through scopes 2026-02-09 15:07:54 +01:00
Alexander Brandon Coles ac84c7fc58 Update more actions to respond with 303 See Other 2025-09-26 09:15:24 +02:00
Behrokh Satarnejad 25f61a6781 Bump op-primer-view-component to 0.68.0 (#19026)
* update core with new primer view components version

* change h1 to h2 in news test for page header title

* fix failing test in files page header

* fix failing test in saml providers page header

* fix failing test in my page page header

* fix failing test in meetings page header

* use have_heading instead of test selector

* use have_heading instead of test selector

* use have-heading in storages test
2025-05-27 14:22:59 +02:00
Jan Sandbrink 0b87e7543f Freeze string literals in specs
Rolling out frozen string literals further by freezing all
string literals in core specs.
2025-05-05 09:29:55 +02:00
Henriette Darge a1809640fe Adapt tests to new PageHeader structure 2024-11-26 11:08:17 +01:00
Oliver Günther fa99c5bef6 Render with status: :unprocessable_entity 2024-10-11 08:42:58 +02:00
Oliver Günther 1cf49e2c9f Adapt specs 2024-09-30 20:37:00 +02:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
ulferts 195c2b84ba spec speedup 2024-06-24 16:49:17 +02:00
ulferts 3660031344 adapt spec setup 2024-06-21 13:34:02 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard 8fa8584538 Run rubocop --autocorrect on all files
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
Christophe Bliard 4c2a9d0aa8 Enable RSpec zero monkey patching mode
The plan for RSpec 4.0 is to disable monkey patching.

See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.
2023-05-31 19:22:29 +02:00
Christophe Bliard 85b3258a29 Autocorrect with some rubocop cops
RSpec/Rails/InferredSpecType and Style/RedundantConstantBase

rubocop --autocorrect-all --only RSpec/Rails/InferredSpecType,Style/RedundantConstantBase spec modules/*/spec
2023-01-13 14:28:59 +01:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Christophe Bliard cd4d2c1be1 add permission tests on storages/admin/projects_storages path 2022-03-25 16:50:15 +01:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Oliver Günther f08bea3467 Remove FactoryBot.* prefix where applicable 2022-01-25 08:19:06 +01:00
Benjamin Bädorf 3aaac1c7ce Rename most notification to toaster instances (#9765)
* Rename most notification to toaster instances

* Frontend builds

* Fix spec build

* Rename more notification elements to toaster

* Rename toaster-box to op-toast

* Fix op-toast-container

* Rename toasters upload progress

* Try fixing page.rb toaster check

* Fix some specs, break some others

* Correctly overwrite toast_type

* Fix more specs

* Fix one more notification to toaster rename

* Fix linting errors, harmonize naming more

* Remove byebug debugging statement

* Remove byebug debugging statement

* Rename notification in the backend, too

* Rename more instances of notifications to toastService

* Rename backend back to notification since bundle gems expect it there

* expect_toaster -> expect_toast

Co-authored-by: Henriette Darge <h.darge@openproject.com>
2021-11-04 16:25:55 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
ulferts 1f024e5796 remove no_self_notified user preference 2021-08-23 20:12:15 +02:00
ulferts 63ad2e8dd1 Generate IAN near real time (#9570)
* destroy notifications upon journal destruction

* breakup spec by journable

* have a dedicated job for scheduling journal completed events

* generate notifications in delayed job

* route wiki journal events through notifications

* combine mail sending for notifications into single job

* robustness if a journal is deleted

* linting

* differentiate BaseJournal and AssociatedJournal

BaseJournal holds the data of a journal that reflects the columns in the journaled model while AssociatedJournal reflects the columns of a model associated to the journaled model via a has_many/one association

* route news journal events through notifications

This does not yet include notifications for comments on news

* include news comment in notification workflow

* have the whole workflow in a single state machine job

* include forum message in notification workflow

* include document in notification workflow

* less dependencies from acts as watchable

* fix, test and document workflow job
2021-08-23 15:25:47 +02:00
ulferts 1bdd2ab9ae safe automatic fixes by rubocop (#8994) 2021-02-11 16:02:18 +01:00
ulferts 6140f4c7e9 update copyright to 2021 (#8925)
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.

Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
ulferts a62c157f18 rename news created_on column to created_at 2020-02-17 13:12:57 +01:00
Henriette Dinger bd7f4e4814 Update copyright notice 2020-01-15 11:31:26 +01:00
Oliver Günther 7a09d8fcdd delay all jobs 2019-10-30 15:15:31 +01:00
Oliver Günther 0d5f50395e [29253] Render error message in production on pending migrations
Creates a new warning bar (previously top-shelf item) that renders a
warning when migrations are pending. These did raise exceptions before
in production and would result in users running in internal errors due
to pending migration on some actions on the instance.

https://community.openproject.com/wp/29253
2019-04-24 07:45:09 +02:00
Oliver Günther 183ad1480e Replace deprecated controller success? with succesful? 2018-12-03 10:31:58 +01:00
Jens Ulferts 97ad5e0008 reenable previews 2018-07-17 12:14:52 +02:00
Oliver Günther 059770f533 FactoryGirl => FactoryBot
Removes the deprecation
2018-05-07 22:38:20 +02:00
Oliver Günther 6ef4211e77 Bump copyright to 2018 (#6171)
[ci skip]
2018-02-12 08:51:12 +01:00
Oliver Günther 7cf11bb689 Update copyright notice 2017-01-10 15:11:43 +01:00
Oliver Günther 92aebdcec4 Fix params deprecation
Fixes in spec/controllers:

```
DEPRECATION WARNING: ActionController::TestCase HTTP request methods will accept only
keyword arguments in future Rails versions.
```
2016-10-17 11:56:44 +02:00
Oliver Günther e9cd24f2bf Add support for parent-scoped with_settings data 2016-04-22 10:19:20 +02:00
Markus Kahl 4eda276ecb always clear delivieries so one does not have to worry about it 2015-09-23 15:18:47 +02:00
Jan Sandbrink d6f2ca0e1c Merge remote-tracking branch 'upstream/release/4.2' into dev
Conflicts:
	Gemfile
	Gemfile.lock
	app/workers/delete_user_job.rb
	db/migrate/migration_utils/legacy_yamler.rb
	lib/open_project/version.rb
	spec/legacy/unit/journal_observer_spec.rb
	spec/models/work_package/work_package_planning_spec.rb
	spec/requests/api/v3/work_packages/work_packages_by_project_resource_spec.rb
	spec/workers/mail_notification_jobs/shared_examples.rb
2015-09-02 14:06:00 +02:00
Jens Ulferts 3aa8a144d6 adapt specs to send mails on self action 2015-08-14 09:08:54 +02:00
Alex Coles 57618b25ec Replace dynamic finder usages with #find_by, etc.
This patch replaces all dynamic finders, for the sake of consistency,
although only some methods are deprecated. See:
https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders

* Revert some `User#find_by_login` usages in cuke steps accidentally
  removed in 74228b59.

User Story # 20325

Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-06-30 11:50:26 +02:00
Alex Coles ebbc9e3d7d Prefer #not_to over #to_not in specs
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-03-11 16:25:19 -03:00
Alex Coles e0191e759c Update year in copyright header to 2015
[ci skip]
2015-01-01 00:02:57 +00:00
Alex Coles 5afc11f19e Fix syntax (w/Rubocop) in specs
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-11-04 00:50:36 +01:00
Alex Coles 03978767be Use 1.9+ Hash syntax in specs
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-11-03 23:49:02 +01:00