98 Commits

Author SHA1 Message Date
Klaus Zanders 15a41d2957 Fix specs 2026-03-06 13:29:07 +01:00
Klaus Zanders 5959386860 Add feature flag for working times 2026-03-06 13:28:06 +01:00
Henriette Darge f039bef878 Adapt test to new ID generation on Primer checkboxes 2026-02-06 11:12:16 +01:00
Oliver Günther 7026df4771 Log failed logins when using password change 2025-12-01 10:06:43 +01:00
Alexander Brandon Coles 3757b22880 [#65403] Rename Settings to Language and Region
Renames menu items, headings, routes and controller actions.

N.B. Uses **locale** in code (to encapsulate both language and region),
and **Language and Region** in user-facing text.
2025-08-27 18:28:02 +01:00
Klaus Zanders cbdc7e83f5 move specs from my controller to new access tokens controller 2025-08-18 13:42:49 +02:00
Henriette Darge 2dbeb00282 Introduce a new setting to disable the keyboard shortcuts 2025-06-23 11:21:51 +02:00
Jan Sandbrink 0b87e7543f Freeze string literals in specs
Rolling out frozen string literals further by freezing all
string literals in core specs.
2025-05-05 09:29:55 +02:00
Oliver Günther 47d62ba9df Fix renders after redirect 2024-10-11 08:43:01 +02:00
Oliver Günther 9dd1b79abe Merge remote-tracking branch 'origin/release/14.4' into dev 2024-08-13 10:05:30 +02:00
Judith Roth 22f88d0989 [#56780] Avoid crashing the page on access token create
https://community.openproject.org/work_packages/56780

The previous behaviour was like this:
If the API Token Creation was not successful, the form in the dialog was
reloaded via turbo with error messages / form validations.
If the API Token Creation was successful, a full page reload was triggered
(so that the flash was shown and the table was updated).
Unfortunately, Turbo  does not recognize the full page reload and therefore
does not load and initialize javascript linked in the page - so our Angular
App did not get initialized.

Since people were unhappy about the flash in general (because it's easy
to be missed by the user who has to copy the new token), it was decided
to switch to using a modal to avoid the full page reload.
2024-08-08 16:12:37 +02:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
Andreas Pfohl 169f4b4666 [56168] Fixed MyController specs 2024-07-10 09:15:15 +02:00
Andreas Pfohl fe0b946da0 [48619] Fixed "my" feature spec for api tokens 2024-07-03 09:38:20 +02:00
Andreas Pfohl 6d2d7e3279 [48619] Fixed unit tests for new access token 2024-07-03 09:38:18 +02:00
Andreas Pfohl aa4213f166 [48619] Added naming of new API tokens 2024-07-03 09:38:16 +02:00
Christophe Bliard a885fef2bd Conform to RSpecRails/HaveHttpStatus cop
With a hack to get `have_http_status` to work with `Rack::MockResponse`.
2024-06-24 17:50:57 +02:00
Oliver Günther 99e915b2c9 Changing mail address should invalidate tokens on top of session 2024-06-10 15:20:27 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard 8fa8584538 Run rubocop --autocorrect on all files
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
Dombi Attila 9fbe0729b8 Remove the default admin shared context as it is not necessary. 2023-11-01 15:04:45 +02:00
Dombi Attila fbb2844069 [#50208] Disabling the default admin user is possible via a system user (#14057)
* [#50208] When disabling the default `admin` user, after an update two `admin` users exists in the database.

https://community.openproject.org/work_packages/50208

* fix specs
2023-11-01 08:29:36 +01:00
Christophe Bliard df827db627 Refactor CustomField factories using traits
Reduce duplication and harmonize the factory names:
- bool/boolean => boolean
- int/integer => integer

Co-authored-by: Aaron Contreras <aaronlcaq@gmail.com>
2023-08-29 08:57:39 +02:00
Marcello Rocha fd0d2643ba updates tests 2023-08-02 11:08:43 +02:00
Marcello Rocha 22d128a8f7 Initial mess 2023-08-02 10:48:04 +02:00
Jonas Jabari 06fb90e423 Merge branch 'dev' into feature/15339-share-project-calendars-using-the-icalendar-format 2023-06-01 11:07:58 +02:00
Christophe Bliard 4c2a9d0aa8 Enable RSpec zero monkey patching mode
The plan for RSpec 4.0 is to disable monkey patching.

See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.
2023-05-31 19:22:29 +02:00
Jonas Jabari 2c16b907c2 fixed and refactored specs 2023-05-30 16:53:51 +02:00
Jonas Jabari 15a9fe3901 fixed rubocop issues 2023-05-22 16:27:03 +02:00
Jonas Jabari a41fe0c64c finalized specs adjustments 2023-05-19 17:18:23 +02:00
Jonas Jabari e146ed5b20 added query scope to ical tokens based on feedback from Marc and Niels, adjusted specs accordingly 2023-04-25 15:53:19 +02:00
Jonas Jabari 19c5b2d755 implemented feedback from @ulferts around ical token management and token usage 2023-03-30 16:46:57 +08:00
Jonas Jabari 1abf957c78 fixed rubocop issues outside of the calendar module introduced while working on this PR 2023-03-17 16:01:29 +08:00
jjabari-op 9e26b4791a Merge branch 'dev' into feature/15339-share-project-calendars-using-the-icalendar-format 2023-03-16 15:36:25 +07:00
Christophe Bliard aa23106c11 lint: autocorrect RSpec/FactoryBot/ConsistentParenthesesStyle
command is

    rubocop -A --only RSpec/FactoryBot/ConsistentParenthesesStyle modules spec
2023-03-07 15:04:32 +01:00
Christophe Bliard dfbe67205b [34594] Show confirmation message in the selected language 2023-03-06 10:47:35 +01:00
Jonas Jabari 5736f48cd4 added specs for ical token management and added translations 2023-02-27 18:13:59 +08:00
Christophe Bliard 85b3258a29 Autocorrect with some rubocop cops
RSpec/Rails/InferredSpecType and Style/RedundantConstantBase

rubocop --autocorrect-all --only RSpec/Rails/InferredSpecType,Style/RedundantConstantBase spec modules/*/spec
2023-01-13 14:28:59 +01:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Oliver Günther f08bea3467 Remove FactoryBot.* prefix where applicable 2022-01-25 08:19:06 +01:00
Oliver Günther a93b065971 [39736] Better password confirmation message
https://community.openproject.org/wp/39736
2021-11-09 09:52:01 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
ulferts 1f024e5796 remove no_self_notified user preference 2021-08-23 20:12:15 +02:00
Oliver Günther 83253981d2 [38325] Using existing gem for email validations
Our email validation is too strict for RFC compliant emails.
Instead of trying to do it ourselves (email validation regexps are hard!),
let's just use a gem to do that for us.

Note: The gem also has a strict mode that could be optionally enabled. This however
results in some emails on community to become invalid. I left it on the default mode for now.

https://community.openproject.org/work_packages/38325
2021-07-27 20:52:24 +02:00
ulferts 1bdd2ab9ae safe automatic fixes by rubocop (#8994) 2021-02-11 16:02:18 +01:00