64 Commits

Author SHA1 Message Date
Klaus Zanders dd7edda50e Extract build_quote message to reduce AbcSize 2026-03-23 10:19:22 +01:00
Klaus Zanders d094eb703b fix messages spec 2026-02-09 15:08:17 +01:00
Klaus Zanders 32569a675f Fix forum routes & tests 2026-02-09 15:07:55 +01:00
Jan Sandbrink 0b87e7543f Freeze string literals in specs
Rolling out frozen string literals further by freezing all
string literals in core specs.
2025-05-05 09:29:55 +02:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard 8fa8584538 Run rubocop --autocorrect on all files
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
Oliver Günther ae36beee69 Merge remote-tracking branch 'origin/release/13.0' into dev 2023-11-21 07:20:46 +01:00
Oliver Günther b582c81a53 Add user name validation 2023-11-21 07:19:38 +01:00
Oliver Günther d60120f1fb Adapt specs now that login_required defaults to true 2023-11-08 11:30:58 +01:00
ulferts 2b2abf864a introduce ProjectRole model 2023-10-09 14:34:20 +02:00
Christophe Bliard 4c2a9d0aa8 Enable RSpec zero monkey patching mode
The plan for RSpec 4.0 is to disable monkey patching.

See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.
2023-05-31 19:22:29 +02:00
Christophe Bliard c43fccf246 lint: autocorrect Style/HashSyntax
command is

    rubocop -A --only Style/HashSyntax app lib lib_static modules spec
2023-03-07 15:07:44 +01:00
Christophe Bliard aa23106c11 lint: autocorrect RSpec/FactoryBot/ConsistentParenthesesStyle
command is

    rubocop -A --only RSpec/FactoryBot/ConsistentParenthesesStyle modules spec
2023-03-07 15:04:32 +01:00
Christophe Bliard 8b2a8154b4 Fix escaping of quoted forum messages 2023-03-03 15:58:44 +01:00
Christophe Bliard 85b3258a29 Autocorrect with some rubocop cops
RSpec/Rails/InferredSpecType and Style/RedundantConstantBase

rubocop --autocorrect-all --only RSpec/Rails/InferredSpecType,Style/RedundantConstantBase spec modules/*/spec
2023-01-13 14:28:59 +01:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Christophe Bliard 47a297daae Fix argument alignment since f08bea3467 (#10129)
* Fix argument alignment since f08bea3467

The FactoryBot.* prefix has been removed in f08bea3467. Since then
rubocop complains about Layout/ArgumentAlignment. This commit fixes it.

* do not fix alignments for modules/*/spec yet

hoping to be under the limit of 65535 characters for reviewdog to report on rubocop errors
2022-02-02 21:48:06 +01:00
Oliver Günther f08bea3467 Remove FactoryBot.* prefix where applicable 2022-01-25 08:19:06 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
ulferts 2a015eeac3 Feature/journal aggregation on write (#9396)
* aggregate journals on write - simple implementation

* remove references to aggregated journals on read

* rewrite existing journals to be aggregated

* remove aggregated journal reference

* only delete predecessor if it can be aggregated

* fix aggregation condition

* adapt specs

* remove aggregated journal functionality from production code

The code is still necessary in a migration for the time being

* adapt specs

* use polymorphic belongs_to for journal data

The association can then be employed for eager loading

* eager load for activity rendering
2021-06-17 20:08:58 +02:00
ulferts 6140f4c7e9 update copyright to 2021 (#8925)
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.

Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
ulferts 983709db89 rewrite acts as journalized to create journals in sql 2020-05-25 10:43:04 +02:00
ulferts 70a29885d5 fix topic attachment upload 2020-03-02 15:49:32 +01:00
Henriette Dinger bd7f4e4814 Update copyright notice 2020-01-15 11:31:26 +01:00
Oliver Günther c5994d3b9b Rename Boards to Forums 2019-03-13 16:24:15 +01:00
Oliver Günther 183ad1480e Replace deprecated controller success? with succesful? 2018-12-03 10:31:58 +01:00
Jens Ulferts 97ad5e0008 reenable previews 2018-07-17 12:14:52 +02:00
Oliver Günther 059770f533 FactoryGirl => FactoryBot
Removes the deprecation
2018-05-07 22:38:20 +02:00
Oliver Günther 72cf7e2fb4 Update secure_headers 2018-03-05 20:44:49 +01:00
Oliver Günther 8c477e5860 Fix more project settings related specs 2018-03-05 14:16:37 +01:00
Oliver Günther 6ef4211e77 Bump copyright to 2018 (#6171)
[ci skip]
2018-02-12 08:51:12 +01:00
Oliver Günther 26dff6132e Remove default route (#6137)
* Remove default route

* Fix and clean legacy specs

* Fix specs

* Fix missing ID in request parameters in view specs

https://stackoverflow.com/a/21789313

* Fix more invalid routes in specs

* Pass parameter to omniauth spec

* Add required ID parameter to types controller

* Fix invalid omniauth URL

* Fix project_id params in repository controller spec

* Fix missing project id in projects controller spec

* Fix missing params and failure url for omniauth

* Fix invalid route name

* Temporarily skip broken specs on dev

[ci skip]
2018-01-22 08:44:15 +01:00
Oliver Günther 7cf11bb689 Update copyright notice 2017-01-10 15:11:43 +01:00
Oliver Günther 4fb23c957b Restructure spec_helper into rails_helper and support files 2016-10-31 20:38:36 +01:00
Jens Ulferts bafaab4d7b use fixture_file_upload to spec file upload 2016-09-12 11:02:37 +02:00
Alex Coles e4c87bc2b4 Merge branch 'dev' into feature/rails4
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-08-08 19:44:58 +01:00
Alexander Bach a8e1aadec7 replace changed_data by details
working towards making the alias obsolete...
2015-08-06 09:32:15 +02:00
Alex Coles ce93701029 Fix syntax (w/Rubocop) in specs
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-06-30 12:08:28 +02:00
Alex Coles e5da2578d5 Merge branch 'dev' into feature/rails4
Signed-off-by: Alex Coles <alex@alexbcoles.com>

Conflicts:
	.travis.yml
	Gemfile
	Gemfile.lock
	README.md
	app/assets/stylesheets/external.css.sass.erb
	app/assets/stylesheets/legacy/main.css.sass
	app/models/work_package.rb
	config/routes.rb
	lib/tabular_form_builder.rb
	spec/controllers/versions_controller_spec.rb
	spec/exemplars/type_exemplar.rb
	spec/factories/type_factory.rb
	spec/legacy/unit/default_data_spec.rb
	spec/legacy/unit/helpers/application_helper_spec.rb
	spec/legacy/unit/mail_handler_spec.rb
	spec/legacy/unit/project_spec.rb
	spec/legacy/unit/time_entry_activity_spec.rb
	spec/legacy/unit/type_spec.rb
	spec/models/work_package/work_package_validations_spec.rb
	spec/requests/api/v3/render_resource_spec.rb
	test/functional/types_controller_test.rb
	test/test_helper.rb
	test/unit/version_test.rb
2015-05-01 11:39:24 +02:00
Alex Coles 2efd6f4e45 Move legacy specs under spec/legacy
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-04-06 01:51:11 +02:00
Alex Coles 3785fdc9ed Use #describe, #context with String arg not symbol
The semantics of `describe` have changed in RSpec 3: passing a symbol
rather than a string will change the value of the described object.

See discussion here: https://github.com/rspec/rspec-core/issues/1114

Signed-off-by: Alex Coles <alex@alexbcoles.com>
2015-03-11 01:13:11 -03:00
Alex Coles e0191e759c Update year in copyright header to 2015
[ci skip]
2015-01-01 00:02:57 +00:00
Martin Linkhorst 964ff49007 make attachment specs more realistic
the sent params to not match the ones that are actually sent when running the server.
change them to mirror the real world better
2014-12-18 15:49:23 +01:00
Alex Coles 1bb21b23c7 Remove option passed to render_template matcher
Signed-off-by: Alex Coles <alex@alexbcoles.com>
2014-11-06 21:53:17 +01:00