eae05f9d1a
Fix after login redirect not ending up on configured URL by default
...
We used request.url and a back_url for the home path to redirect users
if they did not end up trying to access on a deep link.
In case you access / and get redirected by require_login, you want users
to end up on the after_login_default_redirect_url
Likewise, if you access /login without a back_url, you want the same
behavior
Deep linking logins are unchanged
https://community.openproject.org/work_packages/74756
2026-05-08 09:26:58 +02:00
0b87e7543f
Freeze string literals in specs
...
Rolling out frozen string literals further by freezing all
string literals in core specs.
2025-05-05 09:29:55 +02:00
4911b8a149
remove years from copyrights (except for COPYRIGHT file)
2024-07-31 15:02:49 +02:00
fdbd6b6d5a
forcing to specify allowed actions when forfeiting authorization check
2024-06-11 10:29:22 +02:00
ed5a162230
allow actions to be called on those not using default authorization before_actions
2024-06-07 16:55:40 +02:00
3b2121f733
Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
...
This reverts commit 40b2bbeb09b4c6cb17cc
2024-03-21 11:31:17 +01:00
7787e457a3
Revert "Merge branch 'dev' into release/13.4"
...
This reverts commit a901541269e573ca00b7
2024-03-20 20:19:08 +01:00
9e4934cd0a
change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a
2024-03-20 18:05:22 +01:00
c795874f7f
Update copyright year for 2024
...
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
ae36beee69
Merge remote-tracking branch 'origin/release/13.0' into dev
2023-11-21 07:20:46 +01:00
b582c81a53
Add user name validation
2023-11-21 07:19:38 +01:00
d60120f1fb
Adapt specs now that login_required defaults to true
2023-11-08 11:30:58 +01:00
4c2a9d0aa8
Enable RSpec zero monkey patching mode
...
The plan for RSpec 4.0 is to disable monkey patching.
See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.
2023-05-31 19:22:29 +02:00
85b3258a29
Autocorrect with some rubocop cops
...
RSpec/Rails/InferredSpecType and Style/RedundantConstantBase
rubocop --autocorrect-all --only RSpec/Rails/InferredSpecType,Style/RedundantConstantBase spec modules/*/spec
2023-01-13 14:28:59 +01:00
21a696ef9b
Update copyright information for 2023
2022-12-30 15:51:26 +01:00
4a94e03b04
bump rubocop and apply autofixes for new cops
2022-10-21 22:29:12 +02:00
961907110e
make op error handler work in cluster mode outside controllers again
2022-08-09 12:53:32 +02:00
48a4f1b6ad
lint with rubocop --autocorrect (safe cops only)
2022-06-02 10:40:10 +02:00
bc8d423ec2
update copyright information for 2022
2022-03-01 17:05:59 +01:00
f08bea3467
Remove FactoryBot.* prefix where applicable
2022-01-25 08:19:06 +01:00
ccfa29c728
Move license and copyright docs to root, fix names and references
2021-09-02 21:50:46 +02:00
6140f4c7e9
update copyright to 2021 ( #8925 )
...
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.
Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
bd7f4e4814
Update copyright notice
2020-01-15 11:31:26 +01:00
2e989fb0fc
test for status explicitly
2019-08-12 16:42:39 +02:00
059770f533
FactoryGirl => FactoryBot
...
Removes the deprecation
2018-05-07 22:38:20 +02:00
6ef4211e77
Bump copyright to 2018 ( #6171 )
...
[ci skip]
2018-02-12 08:51:12 +01:00
7cf11bb689
Update copyright notice
2017-01-10 15:11:43 +01:00
d7042a2bf0
fix specs
2016-09-09 15:41:12 +02:00
ce93701029
Fix syntax (w/Rubocop) in specs
...
Signed-off-by: Alex Coles <alex@alexbcoles.com >
2015-06-30 12:08:28 +02:00
ebbc9e3d7d
Prefer #not_to over #to_not in specs
...
Signed-off-by: Alex Coles <alex@alexbcoles.com >
2015-03-11 16:25:19 -03:00
e0191e759c
Update year in copyright header to 2015
...
[ci skip]
2015-01-01 00:02:57 +00:00
5afc11f19e
Fix syntax (w/Rubocop) in specs
...
Signed-off-by: Alex Coles <alex@alexbcoles.com >
2014-11-04 00:50:36 +01:00
03978767be
Use 1.9+ Hash syntax in specs
...
Signed-off-by: Alex Coles <alex@alexbcoles.com >
2014-11-03 23:49:02 +01:00
e137ed8135
Convert specs to RSpec 2.99.0 syntax with Transpec
...
This conversion is done by Transpec 2.3.1 with the following command:
transpec
* 72 conversions
from: describe 'some controller' { }
to: describe 'some controller', :type => :controller { }
* 57 conversions
from: describe 'some model' { }
to: describe 'some model', :type => :model { }
* 49 conversions
from: describe 'some view' { }
to: describe 'some view', :type => :view { }
* 34 conversions
from: obj.should
to: expect(obj).to
* 27 conversions
from: describe 'some routing' { }
to: describe 'some routing', :type => :routing { }
* 8 conversions
from: describe 'some feature' { }
to: describe 'some feature', :type => :feature { }
* 7 conversions
from: describe 'some helper' { }
to: describe 'some helper', :type => :helper { }
* 5 conversions
from: be_true
to: be_truthy
* 5 conversions
from: describe 'some request' { }
to: describe 'some request', :type => :request { }
* 2 conversions
from: obj.should_receive(:message)
to: expect(obj).to receive(:message)
* 2 conversions
from: obj.stub(:message)
to: allow(obj).to receive(:message)
* 1 conversion
from: before { example }
to: before { |example| example }
* 1 conversion
from: describe 'some mailer' { }
to: describe 'some mailer', :type => :mailer { }
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2014-06-26 15:04:58 +02:00
efe24e1049
Convert specs to RSpec 2.99.0 syntax with Transpec
...
This conversion is done by Transpec 1.12.0 with the following command:
transpec
* 100 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 17 conversions
from: expect(collection).to have(n).items
to: expect(collection.size).to eq(n)
* 10 conversions
from: obj.stub(:message)
to: allow(obj).to receive(:message)
* 9 conversions
from: be_true
to: be_truthy
* 9 conversions
from: expect(obj).to have(n).errors_on(...)
to: expect(obj.errors_on(...).size).to eq(n)
* 8 conversions
from: obj.should
to: expect(obj).to
* 4 conversions
from: Klass.any_instance.stub(:message)
to: allow_any_instance_of(Klass).to receive(:message)
* 2 conversions
from: be_false
to: be_falsey
* 2 conversions
from: expect(obj).to have(n).error_on(...)
to: expect(obj.error_on(...).size).to eq(n)
* 2 conversions
from: pending 'is an example' { }
to: skip 'is an example' { }
* 1 conversion
from: before { example }
to: before { |example| example }
* 1 conversion
from: expect(collection).to have_at_least(n).items
to: expect(collection.size).to be >= n
* 1 conversion
from: obj.unstub(:message)
to: allow(obj).to receive(:message).and_call_original
* 1 conversion
from: pending
to: skip
2014-06-12 13:47:51 +02:00
c2fdfd0f1d
Fix API requests without CSRF token being rejected
2014-05-14 15:46:33 +02:00
bd8dea129c
add specs for handle_unverified_request in app controller
2014-05-02 11:13:06 +02:00
0bdbdcac35
Convert specs to RSpec 2.14.8 syntax with Transpec
...
This conversion is done by Transpec 1.10.4 with the following command:
transpec
* 1414 conversions
from: obj.should
to: expect(obj).to
* 646 conversions
from: == expected
to: eq(expected)
* 376 conversions
from: obj.stub(:message)
to: allow(obj).to receive(:message)
* 107 conversions
from: obj.should_not
to: expect(obj).not_to
* 70 conversions
from: obj.should_receive(:message)
to: expect(obj).to receive(:message)
* 45 conversions
from: =~ [1, 2]
to: match_array([1, 2])
* 27 conversions
from: lambda { }.should
to: expect { }.to
* 13 conversions
from: Klass.any_instance.stub(:message)
to: allow_any_instance_of(Klass).to receive(:message)
* 8 conversions
from: === expected
to: be === expected
* 7 conversions
from: expect { }.not_to raise_error(SpecificErrorClass)
to: expect { }.not_to raise_error
* 6 conversions
from: =~ /pattern/
to: match(/pattern/)
* 2 conversions
from: obj.should_not_receive(:message)
to: expect(obj).not_to receive(:message)
* 1 conversion
from: < expected
to: be < expected
* 1 conversion
from: obj.stub!(:message)
to: allow(obj).to receive(:message)
* 1 conversion
from: stub('something')
to: double('something')
2014-03-31 10:50:22 +02:00
8b096975fe
updates copyright headers
...
updates more copyright
more copyright headers
2014-02-27 16:39:51 +01:00
43475fbcf1
shortens ApplicationController spec
2013-10-17 16:33:04 +02:00
a1e67dd460
new copyright header #1903
2013-09-16 17:59:31 +02:00
38cdf2e2dd
Add option to log user for all requests
...
Also remove before filter that worked around some session cookie bug
in Rails. This workaround wasn't effective anyway, since our session
cookie names don't contain chiliproject any more.
2013-09-02 08:14:18 +01:00
Oliver Günther