30 Commits

Author SHA1 Message Date
Oliver Günther ad4549847b Fix env name SSRF by using the actual defined value 2026-03-17 15:03:26 +01:00
Markus Kahl 05602f1542 rubocop 2026-03-09 13:33:12 +00:00
Markus Kahl 9e7833ce46 prevent timing attacks in ssrf protected test email 2026-03-09 12:27:54 +00:00
Markus Kahl 2a56b3beea rubocop 2026-03-07 13:51:58 +00:00
Markus Kahl 7afb5f92ef fix test_mail_notification_spec 2026-03-05 12:15:36 +00:00
Markus Kahl 42d97005e2 add OpenProject::SsrfProtection, use it when sending test email to prevent attack 2026-03-05 12:15:35 +00:00
Jan Sandbrink 0b87e7543f Freeze string literals in specs
Rolling out frozen string literals further by freezing all
string literals in core specs.
2025-05-05 09:29:55 +02:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
Henriette Darge 4f2b8d39c2 Replace old icons with Octicons inside the main menu 2024-06-11 12:46:23 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard 8fa8584538 Run rubocop --autocorrect on all files
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
Aaron Contreras 3c4a7de6f1 Remove #force_user_language action
Cleaning up the no-longer used action.
2023-06-13 08:29:38 -05:00
Christophe Bliard 0d7a20bc08 Fix 500 error on POST /admin/force_user_language 2023-06-08 15:27:29 +02:00
Christophe Bliard 4c2a9d0aa8 Enable RSpec zero monkey patching mode
The plan for RSpec 4.0 is to disable monkey patching.

See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.
2023-05-31 19:22:29 +02:00
Eric Schubert 4d05975675 [#47362] Replace spot-icon with boxed icons
- https://community.openproject.org/work_packages/47362
- added new icon font for spot icons
- replaced container containing spot-icon with `inline-flex`
2023-04-25 09:43:03 +02:00
Christophe Bliard aa23106c11 lint: autocorrect RSpec/FactoryBot/ConsistentParenthesesStyle
command is

    rubocop -A --only RSpec/FactoryBot/ConsistentParenthesesStyle modules spec
2023-03-07 15:04:32 +01:00
Christophe Bliard 85b3258a29 Autocorrect with some rubocop cops
RSpec/Rails/InferredSpecType and Style/RedundantConstantBase

rubocop --autocorrect-all --only RSpec/Rails/InferredSpecType,Style/RedundantConstantBase spec modules/*/spec
2023-01-13 14:28:59 +01:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Oliver Günther f08bea3467 Remove FactoryBot.* prefix where applicable 2022-01-25 08:19:06 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
Oliver Günther 34f8e9dff8 Validate admin guard for all settings writers (#9012)
* Validate admin guard for all settings writers

* Add spec to test access to all links under admin

* Fix broken specs

* Keep only UpdateContract and add spec

* Move admin settings under their own namespace for clarity

Move all admin related settings under ::Admin::SettingsController

* Fix more paths and views for settings

Adds another spec to ensure all links in admin can be viewed by admin

* Fix wrongly changed settings path for repositories page

* Use plugin name for plugin settings
2021-02-22 20:46:27 +01:00
ulferts 6140f4c7e9 update copyright to 2021 (#8925)
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.

Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
Henriette Dinger bd7f4e4814 Update copyright notice 2020-01-15 11:31:26 +01:00
Markus Kahl 444afb25b0 hide menu items both from side menu and overview panel 2019-09-23 13:36:02 +01:00
Henriette Dinger 8a620b8852 Move admin_controller spec from legacy to spec && rename admin index page to "index" && adapt view spec 2019-07-08 09:53:31 +02:00