33 Commits

Author SHA1 Message Date
Mir Bhatia 3178db63dd Update delete contract to use same error messages 2025-09-16 17:06:21 +02:00
Mir Bhatia ef5150649a Add checks for update and delete actions 2025-09-16 17:06:20 +02:00
Mir Bhatia d9bbc37e96 Add validation for 'to' work package 2025-09-16 17:06:20 +02:00
Jan Sandbrink 0b87e7543f Freeze string literals in specs
Rolling out frozen string literals further by freezing all
string literals in core specs.
2025-05-05 09:29:55 +02:00
ulferts e41058ed04 use _id where appropriate to fix specs 2025-02-13 12:53:36 +01:00
Henriette Darge 2accaac69a Update test to have a to_id present 2025-02-13 12:53:18 +01:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
Klaus Zanders 1660fce6ef Manage some leftover copyright noticesthat still mention 2023 2024-07-03 08:42:09 +02:00
Oliver Günther e3e8d78972 Rename delay to lag
https://community.openproject.org/work_packages/44054
2024-04-08 19:31:38 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
ulferts f3a6372a66 spec error object is of the model 2023-10-24 11:54:39 +02:00
ulferts 17ec434095 fix spec descriptions and improve readability 2023-10-24 09:17:40 +02:00
ulferts 02d3135d5b avoid unnecessary db call 2023-10-24 09:09:58 +02:00
ulferts 4c2d9f9b24 add specs for relation contract 2023-10-20 16:34:22 +02:00
Christophe Bliard 4c2a9d0aa8 Enable RSpec zero monkey patching mode
The plan for RSpec 4.0 is to disable monkey patching.

See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.
2023-05-31 19:22:29 +02:00
Christophe Bliard aa23106c11 lint: autocorrect RSpec/FactoryBot/ConsistentParenthesesStyle
command is

    rubocop -A --only RSpec/FactoryBot/ConsistentParenthesesStyle modules spec
2023-03-07 15:04:32 +01:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
Christophe Bliard a33524ef6d remove ruby magic comment for utf-8
ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless
2022-03-10 19:36:58 +01:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Oliver Günther f08bea3467 Remove FactoryBot.* prefix where applicable 2022-01-25 08:19:06 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
ulferts 6140f4c7e9 update copyright to 2021 (#8925)
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.

Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
2021-01-13 17:47:45 +01:00
Henriette Dinger bd7f4e4814 Update copyright notice 2020-01-15 11:31:26 +01:00
Oliver Günther 059770f533 FactoryGirl => FactoryBot
Removes the deprecation
2018-05-07 22:38:20 +02:00
Oliver Günther 6ef4211e77 Bump copyright to 2018 (#6171)
[ci skip]
2018-02-12 08:51:12 +01:00
ulferts 0c0b16508b Fix/bump representable (#5465)
* bump reform and roar -> bumps representer

* adapt to changed validation interface

* disable initializer patch for now

* adapt to changed representable attr interface

* can no longer have private methods inside a representer

* private no longer possible for representer

* bump reform

* wip - restyle validation

* remove commented out patch

* apply injection as prescribed

* reactivate reform error symbols patch

* remove patch to Hash superfluous wit ruby 2.3

* remove outdated human_attribute_name patch

* whitespace fixes

* adapt filter name after removal of human_attribute_name patch

* adapt filter specs to no longer rely on human_attribute_name patch

* fix version filter name

* remove reliance on no longer existing human_attribute_name patch

* use correct key in journal formatter

* remove private from representer

* adapt to altered setter interface

* reenable i18n for error messages in contracts

* no private methods in representer

* defined model for contracts

* fix validaton

* instantiate correct Object

* define model for contract

* circumvent now existing render method on reform

* replace deprecated constant

* patch correct reform class - not the module - via prepend

* refactor too complex method

* replace deprations

* remove remnants of parentId

* prevent error symbols from existing twice

* adapt user representer to altered setter interface

* adapt watcher representer to altered setter interface

* remove now unnessary patch

* adapt setter to altered interface

* adapt spec

* fix custom field setters

* remove parentId from wp representer

As the parent is a wp resource, clients should use the parent link instead

* adapt spec to changed valid? interface

* remove parentId from wp schema

* replace references of parentId in frontend

* remove TODO

[ci skip]
2017-06-02 09:10:51 +02:00
Oliver Günther 7cf11bb689 Update copyright notice 2017-01-10 15:11:43 +01:00
Markus Kahl e7f9564441 whitespace 2016-11-01 13:04:03 +01:00
Markus Kahl 6b84e9788c fixed the relations contract which was sabotaged by delayed_job 2016-11-01 11:52:24 +01:00