64 Commits

Author SHA1 Message Date
Mir Bhatia c8148ab799 Fix more redirection HTTP statuses 2026-04-22 16:44:50 +02:00
Henriette Darge d0ebdbdd8a Adapt test to new DangerDialogs 2026-04-10 10:56:14 +02:00
Oliver Günther ad4b84e1dd Fix edit flow of LDAP groups 2025-09-09 11:20:31 +02:00
Oliver Günther c304da7aa2 Add helper method to wrap banner and content into one check 2025-06-12 13:59:00 +02:00
Oliver Günther d6b24d7e5d Remove common shared_upsell and enterprise upsell page examples
No longer in use except one-drive
2025-06-12 13:59:00 +02:00
Oliver Günther e27ac494d3 Consistent naming of upsell, not upsale 2025-04-24 15:52:34 +02:00
Oliver Günther 18574696f5 Fix specs 2025-04-07 10:55:25 +02:00
Ivan Kuchin dfead9fdbe frozen_string_literal in changed specs 2025-03-18 19:35:08 +01:00
Ivan Kuchin 2c1d112aea use require_relative in specs 2025-03-18 19:35:08 +01:00
Oliver Günther fa99c5bef6 Render with status: :unprocessable_entity 2024-10-11 08:42:58 +02:00
Oliver Günther cd2d0f0e1a Remove primerized_flash prefix in methods 2024-09-30 21:39:36 +02:00
Oliver Günther 1cf49e2c9f Adapt specs 2024-09-30 20:37:00 +02:00
Henriette Darge 337efdf508 Harmonize breadcrumb structure for Authentication menu with the help of PageHeader 2024-07-30 08:38:07 +02:00
Christophe Bliard a885fef2bd Conform to RSpecRails/HaveHttpStatus cop
With a hack to get `have_http_status` to work with `Rack::MockResponse`.
2024-06-24 17:50:57 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard 8fa8584538 Run rubocop --autocorrect on all files
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
ulferts 2b2abf864a introduce ProjectRole model 2023-10-09 14:34:20 +02:00
Oliver Günther 3ae353381b Rename tlsverify to tls_verify 2023-07-27 19:31:21 +02:00
Oliver Günther 9400b52ed4 Add specs that UI is disabled with ENV 2023-07-27 16:20:15 +02:00
Oliver Günther e32d2d0058 Remove AuthSource base namespace, model 2023-07-27 08:16:43 +02:00
bsatarnejad 85411f20c7 change tests due to replacing .flash with .op-toast 2023-07-18 16:47:45 +02:00
Christophe Bliard 4c2a9d0aa8 Enable RSpec zero monkey patching mode
The plan for RSpec 4.0 is to disable monkey patching.

See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.
2023-05-31 19:22:29 +02:00
Christophe Bliard 9e865b4f7b lint: Run rubocop safe autocorrect
Command is `rubocop --safe --autocorrect app lib lib_static modules spec`
2023-03-09 10:25:57 +01:00
Christophe Bliard 393d71373f lint: Make rubocop happier 2023-03-07 15:47:03 +01:00
Christophe Bliard aa23106c11 lint: autocorrect RSpec/FactoryBot/ConsistentParenthesesStyle
command is

    rubocop -A --only RSpec/FactoryBot/ConsistentParenthesesStyle modules spec
2023-03-07 15:04:32 +01:00
Christophe Bliard 85b3258a29 Autocorrect with some rubocop cops
RSpec/Rails/InferredSpecType and Style/RedundantConstantBase

rubocop --autocorrect-all --only RSpec/Rails/InferredSpecType,Style/RedundantConstantBase spec modules/*/spec
2023-01-13 14:28:59 +01:00
Oliver Günther 1f821cb8f6 Adapt spec now that we take over memberships 2022-09-29 15:56:34 +02:00
ulferts 07376d7294 Merge branch 'release/12.1' into dev 2022-07-06 11:16:13 +02:00
Oliver Günther 13c997f3a5 Rollback changes on failure to committing changes to the group 2022-07-05 09:21:46 +02:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
Oliver Günther 22cf9ea47c Add LDAP user synchronization job 2022-03-31 09:46:21 +02:00
Oliver Günther 7215753d0c Merge remote-tracking branch 'origin/release/12.0' into dev 2022-02-28 09:46:00 +01:00
Oliver Günther 820602cac1 Run LDAP synchronize call in a mutex per synchronized group 2022-02-23 07:50:01 +01:00
Christophe Bliard d17d31eca7 Fix argument alignment since f08bea3467 for modules specs
The FactoryBot.* prefix has been removed in f08bea3. Since then rubocop complains about Layout/ArgumentAlignment. This commit fixes it.
2022-02-03 10:18:24 +01:00
Oliver Günther f08bea3467 Remove FactoryBot.* prefix where applicable 2022-01-25 08:19:06 +01:00
Markus Kahl 96e7f858c9 rubocop 2021-10-26 14:29:05 +01:00
Markus Kahl d86e2787c7 Merge branch 'release/11.4' into dev 2021-10-20 13:44:48 +01:00
Markus Kahl 9eefd4c761 Merge pull request #9740 from opf/fix/39121/ldap-groups-case
[39121] LDAP groups Also find users with non matching case
2021-10-11 12:20:35 +01:00
Oliver Günther 3edc5b9e42 [39121] Also find users with non matching case
https://community.openproject.org/wp/39121
2021-10-11 10:57:13 +02:00
Oliver Günther d70856977a [39120] Ensure synchronized group is saved with the filter
When the group was already persisted, calling `.replace` on the filter
does not save the group, nor does :autosave on the association.

https://community.openproject.org/wp/39120
2021-10-11 10:41:31 +02:00
ulferts 8ef6c1110c Merge branch 'release/11.3' into dev 2021-09-13 09:44:34 +02:00
Oliver Günther 4f7a0e55b2 [38614] Use the Groups::UpdateService to remove users from the group
https://community.openproject.org/wp/38614
2021-09-07 12:52:35 +02:00
ulferts 63ad2e8dd1 Generate IAN near real time (#9570)
* destroy notifications upon journal destruction

* breakup spec by journable

* have a dedicated job for scheduling journal completed events

* generate notifications in delayed job

* route wiki journal events through notifications

* combine mail sending for notifications into single job

* robustness if a journal is deleted

* linting

* differentiate BaseJournal and AssociatedJournal

BaseJournal holds the data of a journal that reflects the columns in the journaled model while AssociatedJournal reflects the columns of a model associated to the journaled model via a has_many/one association

* route news journal events through notifications

This does not yet include notifications for comments on news

* include news comment in notification workflow

* have the whole workflow in a single state machine job

* include forum message in notification workflow

* include document in notification workflow

* less dependencies from acts as watchable

* fix, test and document workflow job
2021-08-23 15:25:47 +02:00
ulferts b813e8b93f Fix/bump gems (#9259)
* bump aws-partitions

* bump database_cleaner-active_record

* bump rb-fsevent

* bump recaptcha

* bump sentry-ruby & sentry-ruby-core

* bump terminal-table

* bump date_validator

* bump factory_bot & factory_bot_rails

* avoid eager loading models via factories
2021-05-12 13:42:21 +02:00
Oliver Günther 9256c9b46c Allow to disable ldap groups sync with env flag (#9211) 2021-05-03 15:09:43 +01:00
Oliver Günther 6086f320e8 [37036] Always return user attributes when sync_users enabled
When a synchronized group has sync_users enabled, we want to synchronize the user

to OpenProject even if the connection doesn't have onthefly_register enabled.

But currently, the user attributes (name, mail, etc.) are only returned if onthefly_register is set

so the synchronization will never work without it being set on the connnection

https://community.openproject.org/wp/37036
2021-04-28 14:22:31 +02:00
Oliver Günther d1c9c32fa0 Remove ldap group memberships when user is destroyed (#9037) 2021-02-22 20:21:47 +01:00
Oliver Günther 4980b4fb4a Allow LDAP filters and groups to individually sync users (#9031) 2021-02-22 15:24:16 +00:00