Those self-tests are "basic" in the sense that they only validate
their compliance with our documented schema in one representation.
These test cases don't yet cover/validate whether the generated
representation also fulfills the schema under different circumstances,
for example when rendering for a user with fewer privileges, not allowed
to see certain fields.
Where necessary, the schema was changed to reflect the reality, e.g.
when those tests revealed that a "required" field might be missing due to
a lack of permissions.
In a few cases the implementation was adapted to allow for stricter guarantees
of the specified schema, for example links allowed to leave out the title key
already, so its not necessary to emit `title: nil` in cases where a title is
not known.
* add x-scroll when the content is overflew
* exchange the Provider and the Creator columns
* change the layout of file storage list page based on new design for different breakpoints
* remove unnecessary class
* add a new class to hide an element for tablet and mini laptops
* clean style sheet file from unnecessary rules
* add an input for setting classes to the name of principal component
* remove extra avatar component and use a class instead, to hide the name of avatar for mini laptop and tablet
* fix specs for avatar helper
* Update frontend/src/global_styles/layout/_base_mobile.sass
Co-authored-by: Henriette Darge <h.darge@openproject.com>
* make the class name optional and use two classes for hiding name of avatar for tablet and small screen laptop
* fix eslint errors
* fix spec failing
* use one class for hiding element in tablet and small laptop mode
---------
Co-authored-by: Henriette Darge <h.darge@openproject.com>
* Fix implicit block syntax deprecation warnings in `user_spec.rb`
```
The implicit block expectation syntax is deprecated, you should pass
a block rather than an argument to `expect` to use the provided block
expectation matcher or the matcher must implement
`supports_value_expectations?`.
e.g `expect { value }.to change `User#local_avatar_attachment``
not `expect(value).to change `User#local_avatar_attachment``
```
```
The implicit block expectation syntax is deprecated, you should
pass a block rather than an argument to `expect` to use the provided
block expectation matcher or the matcher must implement
`supports_value_expectations?`.
e.g `expect { value }.to raise Exception`
not `expect(value).to raise Exception`
```
* Adjust context phrasing to adhere to Rubocop guidelines
"^when" instead of "^WHEN"
* Adjust `require` statement to use interpolation
Appeases Rubocop complaint for String concatenation being used instead
of String interpolation.
* Use `specify` instead of `it` for no implicit subject example
* Fix members autocompleter to allow hrefs
* Add rendering of different avatar types
* Remove unused code in backend avatar rendering
* Add very basic test that the avatar gets customized per type
* Allow avatar rendering in the CreateAutocompleter
* Restructure avatars into BEM css
* Remove avatar-classes in favor of passing size from backend
* Remove to avoid confusion
We use tracking with both href and , and was introduced
to avoid a property called href to be overridden, but that was never a problem before.
So from now we can safely use .href
* Fix broken principal avatar in user activity
* Ensure filters get updated even if the form is not reloaded
There was a bug in conditionallyLoadForm that checked the property of link (always undefined)
and would thus always reload a form.
What we actually need is a form that gets reloaded only when the query link changes, but still update
services from the updated query, such as filters
* Adapt specs to changes classes
* Rename op-principal-avatar to op-avatar
* Fix some ium stylings
* Extend create service to also test with empty names
* Add PrincipalLike type to pass around non-created placeholder refs
* Add icon-context
* Move principal rendering to its own module
* Fix emit create new placeholder to principals
* Revert op-principal for now
* Add memberships form API to properly post
* Fix types for returned principals
* Move untilDestroyed in role
* Filter input if not string in role-search
* Pass correct inputs to success component
* Return principal after saving membership
* Fix small stuff around the ium
* Fix the way HalResources are selected and passed
* Move principal module to be exported by common
* Disable quotemark in tslint until eslint is enabled
* Fix image path in success
* Adapt modal to run all steps in one within the modal helper component
* Several fixes to modals
* Fix ium success component styles,
* Registration modal y-overflow
* Add SMTP parameters to .env.example
* Add disabled option to op-option-list, disabled placeholder users for non-ee instances
* Add correct ee link to placeholder user option
* Fix build
* Removed unused sass files
* Fix principal search not found indicator, added placeholder add image
* Fix enterprise edition url, use dirty instead of touched check
* Use backend class names for frontend principal types
* Fix duplicate import and principal type usage
* Also disable banners if with_ee is present in test
* Extend specs for placeholders
* Fix disabled attribute
* Extend spec WIP
* Improved inline-validation styles, fixed more PrincipalType usages
* Add group happy path test, fix more PrincipalType usage
* Fix a translation
* Revert line deletion
* Rewrite same spec examples into shared examples
* Fix name of shared example
* Dont run assets:clean to remove angular assets
* Output whether assets are there at all
* Update user-avatar usages to principal
* Fix some op-principal usages
* Fix principal typing
* Remove ls of non-existent directory
* Rename more user-avatar instances
* Avatars now render correctly
* Fix an op-principal instance, default to avatar class for avatars
* Always add principal id to default principal tag
* Small fixes to op-principal
* Fix multiline user display
* Dirty fix for capybara click events
* Update avatar sizing
* Fixed some specs
* Fix unit specs
* Added op-link styles
* Fix add placeholder image link
* Remove byebug debugger statements
Co-authored-by: Oliver Günther <mail@oliverguenther.de>
Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded.
Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013
Creates a new warning bar (previously top-shelf item) that renders a
warning when migrations are pending. These did raise exceptions before
in production and would result in users running in internal errors due
to pending migration on some actions on the instance.
https://community.openproject.com/wp/29253
* Hack spike to show D&D use case
[ci skip]
* Add ordered work packages
* Save order on existing work packages
* Boards WIP
* CDK drag
* Add dragula handler
[ci skip]
* Add filter to return all manual sorted work packages
* Print icon on hover
* Boards routing and list components
* Better loading indicator on list with streaming result
[ci skip]
* Add new board and list buttons
[ci skip]
* Post new query
[ci skip]
* Added creation of new board lists with persisted queries
[ci skip]
* Render placeholder row in empty queries
[ci skip]
* Push boards on grid
* Use base class in scope
[ci skip]
* Extend api for options
* Hack spike to show D&D use case
[ci skip]
* Add ordered work packages
* Save order on existing work packages
* Boards WIP
* CDK drag
* Add dragula handler
[ci skip]
* Add filter to return all manual sorted work packages
* Print icon on hover
* Boards routing and list components
* Better loading indicator on list with streaming result
[ci skip]
* Add new board and list buttons
[ci skip]
* Post new query
[ci skip]
* Added creation of new board lists with persisted queries
[ci skip]
* Render placeholder row in empty queries
[ci skip]
* Save queries in grids
[ci skip]
* Renaming queries
[ci skip]
* Add existing work packages to board
[ci skip]
* Introduce card view component for work packages
* Extend grids to allow project scope for boards (#7025)
Extends the grid backend to also be able to handle boards. In particular, it adds the ability of boards to be attached to projects and changes the page property of grids to a scope property that better describes that more than one board can belong to the same scope (e.g. /projects/:project_id/boards).
For a fully featured board, though, widgets need to be able to store options, so that they can store queries. Those widgets might also need to have custom processing and validation. That part has not been implemented.
* introduce project association for boards
* have dedicated grid registration classes
* update and create form for board grids
* extract defaults into grid registration
[ci skip]
* Add drag and drop to card view
[ci skip]
* Add options to grid
* Fix option migration name
* Renaming boards
[ci skip]
* Frontend deletion of boards
* Avoid map on NodeList which doesnt exist
[ci skip]
* Add inline create to boards
[ci skip]
* Smaller create button
[ci skip]
* Add navigation for boards
* Make inner grid same height
* Replace index page with table
* Workaround for widget registration
[ci skip]
* Fixed height for cards and tables
[ci skip]
* Implement escape as cancel d&d action
[ci skip]
* Fix and extend grid specs for name and options
* Extend board specs for required name
* Fix migration for MySQL references
https://stackoverflow.com/a/45825566/420614
* Make board list extend from widget
Since we cannot configure widgets yet, it's not yet possible to use a
board-list widget anywhere.
* Fix specs
* Fix escape listener removal
[ci skip]
* Fix renamed to_path in relation spec
[ci skip]
* Allow deletion of grids for boards
* Avoid reloading resource multiple times with replays
* Frontend synchronization on deletion
[ci skip]
* Delete through table
* Use work packages board path
* Use work packages board path
* Fix augmented columns breaking re-rendering
* Fix duplicated permission with forums
* Strengthen tab switch in specs
* Add hidden flag for project-context queries
Allows the API to create a hidden query that will not be rendered to the
user even if it is within a project context.
* private queries
* Add hidden flag for project-context queries
Allows the API to create a hidden query that will not be rendered to the
user even if it is within a project context.
* Move boards below work packages
* Add Board configuration modal
* Fix reloading with onPush
* Saving / Switching of display mode
[ci skip]
* Extract wp-query-selectable-title into common component
* Fix renaming of board-list
* Fix auto-hide notifications in boards
* Add permissions to seeders
* Reorder lists in board
* Linting
* Remove default gravatar from settings
* Show assignees avatar in the card view of WPs
* Fix specs
* Add missing method
* Fix timeline icon
* Use URL as input to be able to show avatars for groups, too
* Fix test
* Add further specs
* Use correct data attribute to avoid unnecessary data base calls
* Add further specs
* Deletion of board lists
* Pass permission via gon to decide whether we can create boards
* Fix rename spec
* Cherry-pick of 7873d59 and 30abc7f
Oliver Günther