76 Commits

Author SHA1 Message Date
dependabot[bot] 69415a4191 Bump rspec from 3.13.1 to 3.13.2
Bumps [rspec](https://github.com/rspec/rspec) from 3.13.1 to 3.13.2.
- [Commits](https://github.com/rspec/rspec/compare/rspec-v3.13.1...rspec-v3.13.2)

---
updated-dependencies:
- dependency-name: rspec
  dependency-version: 3.13.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-10-22 07:26:35 +00:00
Markus Kahl 8305bf2387 silence rubocop for now 2025-08-05 15:31:03 +01:00
Markus Kahl b1161f290b Merge branch 'release/16.2' into merge-16.2-into-16.3 2025-08-05 15:24:59 +01:00
Jan Sandbrink c00fefe8ce Fix creation of plugin auth providers
The previous implementation would have failed when
starting with an empty database and trying to migrate it.

We now ensure that the database exists, by running the creation
of plugin auth providers in the seeders. Since there is also a migration
that's supposed to convert old identity_urls to auth provider links
and that migration needs the auth providers already, it does the same
as the seeder.
2025-08-04 14:23:10 +02:00
OpenProject Actions CI 2e37c926fb Merge branch 'release/16.2' into dev 2025-07-29 03:59:49 +00:00
Jan Sandbrink bd4b09592b Fix registration of auth providers through register_auth_providers
This is the only and official API to register an auth provider.
However, so far it was optional to create a database entry in the
auth_providers table and only OIDC and SAML did that.

On the other hand, we added expectations about auth providers have
a database entry in more and more places of the codebase.

Now making sure that every auth provider is represented in the database.
2025-07-28 09:01:10 +02:00
Henriette Darge a877bf802d Provide correct aria attributes for quick add menu and fix some more tests 2025-07-23 11:46:35 +02:00
Henriette Darge ee8452282a [63485] Remove show_local_breadcrumb and default_breadcrumb (#18663)
* add a new helper for breadcrumb in wiki page

* set page header in destroy page

* set page header in edit page

* set page header in history and rename and edit parent pages

* change toolbar items into page header items

* add new wiki action to sub header

* remove version edit page which is not in use any more

* add export as a menu item of the header

* fix rubocup errors

* fix failing tests

* replace page header in annotate page

* replace page header in diff page

* add page header in select menu page

* fix rubocup errors

* fix errors on rename test

* fix errors on selecting items from toolbar

* fix errors on tests for child pages

* set correct permission for configure menu item

* replace page header in summary page

* replace page header in summary details page

* edit docs of sub header

* add page header in wiki new page

* remove controller and a route for edit method

* undo changes for docs of sub header

* extract header in show page into a new component

* use helper method in header component

* add wiki module to the breadcrumb

* rename page header component for wiki page

* simplify how lock and lock implemented

* extract sub header

* remove wiki title from header of history page

* fix page header in new page

* use page.find_test_selector in test

* fix failing test for summary page

* fix failing test for wiki child pages

* change the summary test

* use test selector for page header title

* undo changes for activate user in admin

* use test selector in adding editing history test

* use test selector in attachment upload test

* use test selector in child pages tests

* use test selector in wiki menu items tests

* change test selector for breadcrumbs

* extract conditions to show edit button into a method

* extract conditions to show rollback action menu item into a method

* extract conditions to show create button into a method

* fix duplicated code in test

* Remove outdated `show_local_breadcrumb` method which is replaced by the Primer::PageHeader breadcrumb

* Remove `default_breadcrumb` method as it serves no prupose any more

* Remove the old breadcrumb and its hook completely

* remove breadcrumbs path from rename

* fix translations errors in storages

* undo changes on translations

* remove default breadcrumbs in time tracking controller

---------

Co-authored-by: Behrokh Satarnejad <b.satarnejad@openproject.com>
Co-authored-by: Behrokh Satarnejad <62008897+bsatarnejad@users.noreply.github.com>
2025-04-23 10:40:43 +02:00
Oliver Günther dc369872e8 Fix specs 2025-04-07 10:55:23 +02:00
Oliver Günther edc0a2a47e Replace show_banners with hide_banners
Encode features in the configuration API, instead of relying on a boolean yes/no flag
2025-04-07 10:55:21 +02:00
ulferts 11095cf22b use rails 5.1 defaults 2025-03-12 10:55:29 +01:00
Ivan Kuchin fb715f21b9 erb_lint auto fix quotes 2025-02-11 18:49:19 +01:00
Pavel Balashou e0c5dd3ef6 Update OIDC configuration UI. 2024-10-21 13:03:46 +02:00
Oliver Günther 150d5d1f5b Setup providers 2024-09-26 11:35:11 +02:00
Oliver Günther 64a94a4567 Match constant names 2024-09-20 10:24:00 +02:00
Oliver Günther fb2bca5608 Remove leftover files and licenses already covered in root folder 2024-08-08 14:43:03 +02:00
Oliver Günther 9586b06db3 Merge pull request #16331 from opf/chore/verify_partial_doubles
Set verify_partial_doubles=true
2024-08-06 10:54:18 +02:00
Oliver Günther 74fa859e5f Pass correct nil 2024-08-05 19:31:30 +02:00
Oliver Günther 1df0c00c2a Adapt affected specs to opt-out of double verification 2024-08-05 19:31:30 +02:00
Ivan Kuchin 4911b8a149 remove years from copyrights (except for COPYRIGHT file) 2024-07-31 15:02:49 +02:00
Ivan Kuchin fa5d03eae0 rubocop safe autocorrect all except Rails/WhereRange 2024-05-30 19:54:08 +02:00
Aaron Dewes b9d3a9647d fix: Openproject / Open Project -> OpenProject
This fixes the spelling of OpenProject in a few places
2024-04-26 12:06:51 +02:00
ulferts 3b2121f733 Revert "Merge remote-tracking branch 'origin/release/13.4' into dev"
This reverts commit 40b2bbeb09, reversing
changes made to b4c6cb17cc.
2024-03-21 11:31:17 +01:00
Ivan Kuchin 7787e457a3 Revert "Merge branch 'dev' into release/13.4"
This reverts commit a901541269, reversing
changes made to e573ca00b7.
2024-03-20 20:19:08 +01:00
Ivan Kuchin 9e4934cd0a change quotes using rubocop --only Style/StringLiterals,Style/QuotedSymbols -a 2024-03-20 18:05:22 +01:00
Christophe Bliard 8fa8584538 Run rubocop --autocorrect on all files
Only the safe cops have run. rubocop version is 1.59.0.
2024-01-05 15:27:09 +01:00
Christophe Bliard c795874f7f Update copyright year for 2024
command used: `rg -l 'Copyright \(C\) 2012-202\d the OpenProject' | xargs -n 100 sed -i -r 's/Copyright \(C\) 2012-202. the OpenProject/Copyright (C) 2012-2024 the OpenProject/'`
2024-01-02 16:23:54 +01:00
Oliver Günther 47b32dd5cc Move use_graph_api and self_registration OIDC options into configuration 2023-10-11 16:50:53 +02:00
Oliver Günther 8b19e9a80f Pass strategy key into filtered_strategy? 2023-07-03 13:08:44 +02:00
Christophe Bliard 4c2a9d0aa8 Enable RSpec zero monkey patching mode
The plan for RSpec 4.0 is to disable monkey patching.

See https://github.com/rspec/rspec-core/blob/main/features/configuration/zero_monkey_patching_mode.feature for details.
2023-05-31 19:22:29 +02:00
Dombi Attila 5fa819a54b Remove enterprise_token_helper.rb and the with_enterprise_token method 2023-05-08 08:08:30 +02:00
Markus Kahl faafa84608 allow to limit self registration for openid connect providers 2023-04-20 14:39:26 +02:00
Christophe Bliard 85b3258a29 Autocorrect with some rubocop cops
RSpec/Rails/InferredSpecType and Style/RedundantConstantBase

rubocop --autocorrect-all --only RSpec/Rails/InferredSpecType,Style/RedundantConstantBase spec modules/*/spec
2023-01-13 14:28:59 +01:00
Christophe Bliard 21a696ef9b Update copyright information for 2023 2022-12-30 15:51:26 +01:00
Eric Schubert c8f1e16005 [#43684] migrated op-modal to spot-modal (#11172)
* [#43684] migrated op-modal to spot-modal

- https://community.openproject.org/work_packages/43684
- amended styles
- removed "modal--title"
- removed header component
- removed closing icon
- fixed backdrop click
- removed jquery from modal service

* [#43684] removed unused styling

- fixed some inconsitencies
- readded removed icon
- removed listener on close button

* [#43684] combined spot-action-bar

- used spot-action-bar in combination with spot-modal--footer
- fixed some styling in action bar

* [#43684] replaced more op-modal

- moved spec selectors to spot-modal
- replaced found op-modal in html templates

* [#43684] add no margin to old buttons in new dialogs

- added mobile modal behavior
- fixed some feature spec selectors

* [#43684] added modal close on mobile resolutions

* [#43684] fixed PR issues

- removed old css classes from html
- fixed feature spec click
- readded tour trigger on modal cancel

* when clicking outside the modal it will be closed instaed of clicking on a close button

* exclude _center class from spot-modal sass file itself and add it to the component style sheet

* Words should be break in any case like when there is no space there

* remove unnecessary classes that never used like _fullscreen and _cente, remove _limited-height class to make all the modal look the same

Co-authored-by: bsatarnejad <b.satarnejad@gmail.com>
Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>
2022-08-29 10:53:41 +00:00
Christophe Bliard e160ba0555 Fix spec path to end with *_spec.rb 2022-06-03 09:51:24 +02:00
Christophe Bliard 48a4f1b6ad lint with rubocop --autocorrect (safe cops only) 2022-06-02 10:40:10 +02:00
ulferts 6ad2713141 avoid autoloading ApplicationHelper during initialization 2022-04-04 16:04:46 +02:00
Christophe Bliard a33524ef6d remove ruby magic comment for utf-8
ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless
2022-03-10 19:36:58 +01:00
Christophe Bliard bc8d423ec2 update copyright information for 2022 2022-03-01 17:05:59 +01:00
Oliver Günther f08bea3467 Remove FactoryBot.* prefix where applicable 2022-01-25 08:19:06 +01:00
ulferts ac14e80220 fix sso icon position (#9960)
* fix sso icon position

* Add to auth_plugins sass

* rely on modifier class for icon padding

Co-authored-by: Oliver Günther <mail@oliverguenther.de>
2021-12-07 16:25:28 +01:00
Oliver Günther ccfa29c728 Move license and copyright docs to root, fix names and references 2021-09-02 21:50:46 +02:00
Oliver Günther 6a75cc9a30 Merge remote-tracking branch 'origin/release/11.4' into dev 2021-08-02 09:15:18 +02:00
Henriette Darge 8917a928e4 Change google logo and take care that auth plugin logos are correctly shown 2021-07-27 13:36:24 +02:00
luzpaz 2ae53bd252 Fix typos in user facing and non-user facing code (#9497)
* Fix typos in user facing and non-user facing code

Found via `codespell -q 3 -S ./config/locales -L ba,nd,parms,sur,varius`

* Fix strings in specs
2021-07-21 17:26:31 +02:00
Henriette Darge 2ee3a06c63 * Remove dead links (#9453)
* Use .org website address consistently
* Remove community address as homepage as it does not really offer any value
2021-07-14 15:51:09 +02:00
ulferts 5cb227796c Fix/hook service to openproject (#9214)
* move specs from legacy

* move Hook into OpenProject namespace

* replace class variables
2021-05-03 20:58:15 +02:00
Benjamin Bädorf 2667cd1581 Refactor/app header (#9110)
* [35527] Add quick add button menu in top menu

* Add quick menu item to top menu

* Refactor top_menu.sass to follow BEM

* Only render project-based path if persisted

* Render project types when in project context

* Add headline and determine if any types are visible

* Hide quick add menu for unauthorized users

* Fix login menu dropdown by adding class

* Add schematic for correctly generating components

* Add augment service for triggering invite user modal

* Fix allowed_to? check in menu

* Add spec

* Highlight types and show all

* Fix help menu overridden

* Extend spec

* Add parent_id to project in dropdown and expand advanced settings

* Reload the page if the modal returned any data

* Fix invalid url allowed check if there is no URL to check

* Basic BEM changes

* Remove old classes

* Update more classes

* Update togling logic

* Fixed menu opening and some styles

* Added op-menu

* Fix some help menu styles

* Add op-menu to help menug

* Add avatar border

* Fix auth_provider_spec

* Fix zen mode

* Fix static link help menu

* Fixed top menu specs

* Fix self registration specs

* Fix logout spec

* Fix bim revit navigation spec

* Fixed menu permissions spec

* Fix homescreen onboarding tour spec

* Fix top menu item spec

* Remove unused file

* Fix a lot of mobile styles

* Fix more mobile styles

* Fixed build

* Move quick add menu to right hand side

* Improve quick-add-button styles, fix main-menu-toggle close icon

* Remove add new project spec

* Fix spec

* Update project dropdown styles

* Fix click handler for chrome mobile, update some styles

Co-authored-by: Oliver Günther <mail@oliverguenther.de>
2021-04-06 11:09:06 +02:00
ulferts 1bdd2ab9ae safe automatic fixes by rubocop (#8994) 2021-02-11 16:02:18 +01:00