mirror of
https://github.com/opf/openproject.git
synced 2026-06-14 03:30:14 +00:00
Add an empty widget so that the tests are not confused
The previous defaults were not applied, causing the my page to be empty. It now has a default, but we want to restore the previously tested rows and columns
This commit is contained in:
@@ -21,5 +21,11 @@ FactoryBot.define do
|
||||
)
|
||||
]
|
||||
end
|
||||
|
||||
trait :empty do
|
||||
widgets { [] }
|
||||
row_count { 1 }
|
||||
column_count { 1 }
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
@@ -46,6 +46,11 @@ RSpec.describe "Custom text widget on my page", :js do
|
||||
let(:other_user) do
|
||||
create(:user, member_with_permissions: { project => permissions })
|
||||
end
|
||||
|
||||
let!(:my_page_grid) do
|
||||
create(:my_page, :empty, user:)
|
||||
end
|
||||
|
||||
let(:my_page) do
|
||||
Pages::My::Page.new
|
||||
end
|
||||
|
||||
@@ -53,6 +53,10 @@ RSpec.describe "My page documents widget", :js do
|
||||
Pages::My::Page.new
|
||||
end
|
||||
|
||||
let!(:my_page_grid) do
|
||||
create(:my_page, :empty, user:)
|
||||
end
|
||||
|
||||
before do
|
||||
login_as user
|
||||
|
||||
|
||||
+4
@@ -67,6 +67,10 @@ RSpec.describe "My spent time widget with a negative time zone", :js,
|
||||
let!(:week_days) { week_with_saturday_and_sunday_as_weekend }
|
||||
let!(:non_working_day) { create(:non_working_day, date: tuesday) }
|
||||
|
||||
let!(:my_page_grid) do
|
||||
create(:my_page, :empty, user:)
|
||||
end
|
||||
|
||||
before do
|
||||
login_as user
|
||||
my_page.visit!
|
||||
|
||||
@@ -53,6 +53,10 @@ RSpec.describe "My page news widget spec", :js do
|
||||
Pages::My::Page.new
|
||||
end
|
||||
|
||||
let!(:my_page_grid) do
|
||||
create(:my_page, :empty, user:)
|
||||
end
|
||||
|
||||
before do
|
||||
login_as user
|
||||
|
||||
|
||||
@@ -107,6 +107,11 @@ RSpec.describe "My page time entries current user widget spec", :js do
|
||||
create(:user,
|
||||
member_with_permissions: { project => %i[view_time_entries edit_time_entries view_work_packages log_own_time] })
|
||||
end
|
||||
|
||||
let!(:my_page_grid) do
|
||||
create(:my_page, :empty, user:)
|
||||
end
|
||||
|
||||
let(:my_page) do
|
||||
Pages::My::Page.new
|
||||
end
|
||||
|
||||
@@ -161,6 +161,10 @@ RSpec.describe "Arbitrary WorkPackage query table widget on my page", :js do
|
||||
context "without the permission to save queries" do
|
||||
let(:permissions) { %i[view_work_packages add_work_packages] }
|
||||
|
||||
let!(:my_page_grid) do
|
||||
create(:my_page, :empty, user:)
|
||||
end
|
||||
|
||||
it "cannot add the widget" do
|
||||
my_page.expect_unable_to_add_widget(1, 1, :within, "Work packages table")
|
||||
end
|
||||
|
||||
@@ -46,6 +46,10 @@ RSpec.describe "Work package watched widget on My page", :js do
|
||||
Pages::My::Page.new
|
||||
end
|
||||
|
||||
let!(:my_page_grid) do
|
||||
create(:my_page, :empty, user:)
|
||||
end
|
||||
|
||||
before do
|
||||
login_as user
|
||||
work_package.add_watcher(user)
|
||||
|
||||
@@ -76,7 +76,7 @@ RSpec.describe "POST /api/v3/grids/form", content_type: :json do
|
||||
}
|
||||
end
|
||||
|
||||
it "contains default data in the payload" do
|
||||
it "contains default data in the payload" do # rubocop:disable RSpec/ExampleLength
|
||||
expected = {
|
||||
rowCount: 1,
|
||||
columnCount: 2,
|
||||
|
||||
@@ -41,6 +41,11 @@ RSpec.describe "Favorite projects", :js do
|
||||
end
|
||||
let(:projects_page) { Pages::Projects::Index.new }
|
||||
let(:top_menu) { Components::Projects::TopMenu.new }
|
||||
|
||||
let!(:my_page_grid) do
|
||||
create(:my_page, :empty, user:)
|
||||
end
|
||||
|
||||
let(:my_page) do
|
||||
Pages::My::Page.new
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user