references/openproject
1
0
Fork 0
mirror of https://github.com/opf/openproject.git synced 2026-06-14 03:30:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use new helpers in flaky specs to properly wait for turbo

Browse Source
This commit is contained in:
Klaus Zanders
2026-03-20 14:59:39 +01:00
parent 6fb0a0e897
commit ea2f602d79
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/features/projects/favorite_spec.rb
+3 -1
View File
@@ -61,7 +61,9 @@ RSpec.describe "Favorite projects", :js do
visit project_path(project)
expect(page).to have_css "a", accessible_name: "Add to favorites"
click_link_or_button(accessible_name: "Add to favorites")
wait_for_turbo do
click_link_or_button(accessible_name: "Add to favorites")
end
expect(page).to have_css "a", accessible_name: "Remove from favorites"
spec/features/projects/persisted_lists_sharing_spec.rb
+4 -6
View File
@@ -366,13 +366,11 @@ RSpec.describe "Project list sharing",
# Toggle the switch to make the project list query public
share_dialog.expect_toggle_public_off
share_dialog.toggle_public
retry_block do
# dialog body is replaced on toggle by turbo stream, we have to wait for the render to be completed so we
# retry the expectation until the toggle is on again
share_dialog.expect_toggle_public_on
wait_for_turbo_stream do
share_dialog.toggle_public
end
share_dialog.expect_toggle_public_on
share_dialog.close
# Reopen the dialog and expect the public state to be kept