references/openproject
1
0
Fork 0
mirror of https://github.com/opf/openproject.git synced 2026-06-14 03:30:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add "Beta" to semantic identifier setting page

Browse Source
This commit is contained in:
Tomas Hykel
2026-05-29 10:30:29 +02:00
parent c8c9c4207b
commit dca5065e56
4 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/components/work_packages/admin/settings/identifier_settings_form_component.rb
+7 -2
View File
@@ -144,13 +144,18 @@ module WorkPackages
elsif completed?
{ values: identifier_values(checked: Setting[:work_packages_identifier]) }
else
{ button_options: { data: { action: "change->admin--work-packages-identifier#handleChange" } } }
{
values: identifier_values(checked: Setting[:work_packages_identifier]),
button_options: { data: { action: "change->admin--work-packages-identifier#handleChange" } }
}
end
end
def identifier_values(checked:)
Setting::WorkPackageIdentifier::ALLOWED_VALUES.map do |v|
{ name: v, value: v, checked: v == checked }
entry = { name: v, value: v, checked: v == checked }
entry[:label] = "#{I18n.t("setting_work_packages_identifier_#{v}")} (Beta)" if v == "semantic"
entry
end
end
end
config/locales/en.yml
+1 -1
View File
@@ -65,7 +65,7 @@ en:
col_identifier: "Identifier"
col_project: "Project"
col_reserved: "Reserved"
not_available_in_semantic_mode: "Reserved identifiers are only available in classic identifier mode."
not_available_in_semantic_mode: "Reserved identifiers are only available in numeric identifier mode."
filter_label: "Filter identifiers"
btn_release: "Release"
released_notice: "Identifier \"%{identifier}\" has been released."
spec/components/work_packages/admin/settings/identifier_settings_form_component_spec.rb
+4 -4
View File
@@ -104,7 +104,7 @@ RSpec.describe WorkPackages::Admin::Settings::IdentifierSettingsFormComponent, t
it "renders the radio buttons as disabled" do
render_component(component)
expect(page).to have_field("Instance-wide numerical sequence (default)", disabled: true)
expect(page).to have_field("Project-based semantic identifiers", disabled: true)
expect(page).to have_field("Project-based semantic identifiers (Beta)", disabled: true)
end
it "does not render the save or autofix buttons" do
@@ -136,7 +136,7 @@ RSpec.describe WorkPackages::Admin::Settings::IdentifierSettingsFormComponent, t
it "renders the radio buttons as enabled" do
render_component(component)
expect(page).to have_field("Instance-wide numerical sequence (default)", disabled: false)
expect(page).to have_field("Project-based semantic identifiers", disabled: false)
expect(page).to have_field("Project-based semantic identifiers (Beta)", disabled: false)
end
it "does not call PreviewQuery" do
@@ -147,7 +147,7 @@ RSpec.describe WorkPackages::Admin::Settings::IdentifierSettingsFormComponent, t
context "with semantic setting", with_settings: { work_packages_identifier: "semantic" } do
it "shows semantic as selected" do
render_component(component)
expect(page).to have_field("Project-based semantic identifiers", checked: true)
expect(page).to have_field("Project-based semantic identifiers (Beta)", checked: true)
expect(page).to have_field("Instance-wide numerical sequence (default)", checked: false)
end
end
@@ -156,7 +156,7 @@ RSpec.describe WorkPackages::Admin::Settings::IdentifierSettingsFormComponent, t
it "shows classic as selected" do
render_component(component)
expect(page).to have_field("Instance-wide numerical sequence (default)", checked: true)
expect(page).to have_field("Project-based semantic identifiers", checked: false)
expect(page).to have_field("Project-based semantic identifiers (Beta)", checked: false)
end
end
end
spec/features/admin/settings/work_packages_identifier_spec.rb
+2 -2
View File
@@ -48,7 +48,7 @@ RSpec.describe "Work packages identifier admin settings", :js do
context "when no projects have problematic identifiers" do
it "saves the setting without showing a dialog" do
visit_settings
choose "Project-based semantic identifiers"
choose "Project-based semantic identifiers (Beta)"
click_button "Convert identifiers"
@@ -80,7 +80,7 @@ RSpec.describe "Work packages identifier admin settings", :js do
context "when switching to semantic" do
before do
visit_settings
choose "Project-based semantic identifiers"
choose "Project-based semantic identifiers (Beta)"
end
it "shows the autofix section after selecting semantic" do