references/openproject
1
0
Fork 0
mirror of https://github.com/opf/openproject.git synced 2026-06-14 03:30:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor refactoring

Browse Source
This commit is contained in:
Jonas Jabari
2023-12-06 14:01:00 +01:00
parent 5d97caf300
commit ce8a66edfc
2 changed files with 21 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/components/settings/project_custom_field_sections/custom_field_row_component.rb
+13 -4
View File
@@ -50,10 +50,19 @@ module Settings
end
def move_actions(menu)
move_action_item(menu, :highest, t("label_agenda_item_move_to_top"), "move-to-top") unless @project_custom_field.first?
move_action_item(menu, :higher, t("label_agenda_item_move_up"), "chevron-up") unless @project_custom_field.first?
move_action_item(menu, :lower, t("label_agenda_item_move_down"), "chevron-down") unless @project_custom_field.last?
unless @project_custom_field.last?
# TODO: these methods trigger database queries for each custom field displayed
# it would be nice if can eager load this information
first_in_list = @project_custom_field.first?
last_in_list = @project_custom_field.last?
unless first_in_list
move_action_item(menu, :highest, t("label_agenda_item_move_to_top"),
"move-to-top")
move_action_item(menu, :higher, t("label_agenda_item_move_up"), "chevron-up")
end
unless last_in_list
move_action_item(menu, :lower, t("label_agenda_item_move_down"),
"chevron-down")
move_action_item(menu, :lowest, t("label_agenda_item_move_to_bottom"),
"move-to-bottom")
end
app/components/settings/project_custom_field_sections/show_component.rb
+8 -5
View File
@@ -64,16 +64,19 @@ module Settings
end
def move_actions(menu)
unless @project_custom_field_section.first?
# TODO: these methods trigger database queries for each section displayed
# it would be nice if can eager load this information
first_in_list = @project_custom_field_section.first?
last_in_list = @project_custom_field_section.last?
unless first_in_list
move_action_item(menu, :highest, t("label_agenda_item_move_to_top"),
"move-to-top")
move_action_item(menu, :higher, t("label_agenda_item_move_up"), "chevron-up")
end
move_action_item(menu, :higher, t("label_agenda_item_move_up"), "chevron-up") unless @project_custom_field_section.first?
unless @project_custom_field_section.last?
unless last_in_list
move_action_item(menu, :lower, t("label_agenda_item_move_down"),
"chevron-down")
end
unless @project_custom_field_section.last?
move_action_item(menu, :lowest, t("label_agenda_item_move_to_bottom"),
"move-to-bottom")
end