references/openproject
1
0
Fork 0
mirror of https://github.com/opf/openproject.git synced 2026-06-13 19:20:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix rubocop issue in Controller

Browse Source
This commit is contained in:
Klaus Zanders
2026-06-09 11:50:28 +02:00
parent 69f15b7fab
commit c0ecc6af5d
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/resource_management/app/controllers/resource_management/resource_allocations_controller.rb
+11 -9
View File
@@ -53,17 +53,11 @@ module ::ResourceManagement
def create
# The confirmation step's "Back" button resubmits the carried form values
# so the editable step can be re-rendered pre-filled.
return render_allocation_step(set_attributes(create_params).result) if params[:back].present?
return render_back_step if params[:back].present?
validation = set_attributes(create_params)
if validation.failure?
return render_allocation_step(validation.result, status: :unprocessable_entity)
end
if validation.result.schedule_violation && params[:confirmed].blank?
return render_outside_dates_step(validation.result)
end
return render_allocation_step(validation.result, status: :unprocessable_entity) if validation.failure?
return render_outside_dates_step(validation.result) if needs_date_confirmation?(validation.result)
persist_allocation
end
@@ -113,6 +107,14 @@ module ::ResourceManagement
end
end
def render_back_step
render_allocation_step(set_attributes(create_params).result)
end
def needs_date_confirmation?(allocation)
allocation.schedule_violation && params[:confirmed].blank?
end
def set_attributes(attributes)
ResourceAllocations::SetAttributesService
.new(user: current_user, model: ResourceAllocation.new, contract_class: ResourceAllocations::CreateContract)