references/openproject
1
0
Fork 0
mirror of https://github.com/opf/openproject.git synced 2026-06-13 19:20:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleaner argument names in move_work_package_to_target_component_via_turbo_stream

Browse Source
This commit is contained in:
Ivan Kuchin
2026-06-02 18:53:02 +02:00
parent 24a5b24bcd
commit 9b7ffa8cae
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/backlogs/app/controllers/backlogs/work_packages_controller.rb
+9 -9
View File
@@ -65,13 +65,13 @@ module Backlogs
def move # rubocop:disable Metrics/AbcSize
# Capture the source before the call; the service reloads @work_package internally via #move_after.
source = @work_package.sprint
source_sprint = @work_package.sprint
call = ::Backlogs::WorkPackages::UpdateService.new(user: current_user, story: @work_package)
.call(**move_params.to_h.symbolize_keys)
if call.success?
move_work_package_to_target_component_via_turbo_stream(source:, target: call.result.sprint)
move_work_package_to_target_component_via_turbo_stream(source_sprint:, target_sprint: call.result.sprint)
if work_package_invisible_after_move?(call.result)
backlog_name = call.result.backlog_bucket&.name || I18n.t(:label_inbox)
@@ -90,17 +90,17 @@ module Backlogs
private
def move_work_package_to_target_component_via_turbo_stream(source:, target:)
if source != target
replace_component_via_turbo_stream(source)
def move_work_package_to_target_component_via_turbo_stream(source_sprint:, target_sprint:)
if source_sprint != target_sprint
replace_component_via_turbo_stream(sprint: source_sprint)
end
replace_component_via_turbo_stream(target)
replace_component_via_turbo_stream(sprint: target_sprint)
end
def replace_component_via_turbo_stream(container)
component = if container
sprint_component(sprint: container)
def replace_component_via_turbo_stream(sprint:)
component = if sprint
sprint_component(sprint:)
else
backlog_component
end