references/openproject
1
0
Fork 0
mirror of https://github.com/opf/openproject.git synced 2026-06-14 03:30:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Rubocop ABC size in before_perform

Browse Source 
Extracts failure aggregation into its own method.
This commit is contained in:
Alexander Brandon Coles
2026-03-21 21:16:58 -04:00
parent 089bbedefc
commit 81f0b666c8
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/boards/app/services/boards/sprint_task_board_create_service.rb
+11 -6
View File
@@ -35,12 +35,8 @@ module Boards
def before_perform(_service_result)
create_queries_results = create_queries(params)
failures = create_queries_results.select(&:failure?)
if failures.any?
return ServiceResult.failure.tap do |result|
failures.each { |f| result.add_dependent!(f) }
end
end
failure_result = aggregate_failures(create_queries_results)
return failure_result if failure_result
set_attributes(params.merge(query_ids: create_queries_results.map { it.result.id })).tap do |service_result|
service_result.result.linked = params[:sprint] if service_result.success?
@@ -49,6 +45,15 @@ module Boards
private
def aggregate_failures(results)
failures = results.select(&:failure?)
return nil if failures.empty?
ServiceResult.failure.tap do |result|
failures.each { |f| result.add_dependent!(f) }
end
end
def create_query_params(params, status)
default_create_query_params(params).merge(
name: query_name(status),