Merge pull request #17212 from opf/chore/unflicker-contract-spec

[chore] make flickering disappear

spec/contracts/custom_fields/hierarchy/insert_item_contract_spec.rb

@@ -67,15 +67,31 @@ RSpec.describe CustomFields::Hierarchy::InsertItemContract do
       it "is invalid" do
         result = subject.call(params)
         expect(result).to be_failure
-        expect(result.errors.to_h).to include(label: ["must be unique within the same hierarchy level."])
+        expect(result.errors.to_h).to include(label: [I18n.t("dry_validation.errors.rules.label.not_unique")])
       end
 
-      context "if locale is set to 'de'" do
+      context "if another locale is set" do
+        let(:mordor) { "agh burzum-ishi krimpatul" }
+
+        before do
+          I18n.config.enforce_available_locales = false
+          I18n.backend.store_translations(
+            :mo,
+            { dry_validation: {
+              errors: { rules: { label: { not_unique: mordor } } }
+            } }
+          )
+        end
+
+        after do
+          I18n.config.enforce_available_locales = true
+        end
+
         it "is invalid with localized validation errors" do
-          I18n.with_locale(:de) do
+          I18n.with_locale(:mo) do
             result = subject.call(params)
             expect(result).to be_failure
-            expect(result.errors.to_h).to include(label: ["muss innerhalb der gleichen Hierarchieebene eindeutig sein."])
+            expect(result.errors.to_h).to include(label: [mordor])
           end
         end
       end
@@ -89,7 +105,7 @@ RSpec.describe CustomFields::Hierarchy::InsertItemContract do
       it "is invalid with localized validation errors" do
         result = subject.call(params)
         expect(result).to be_failure
-        expect(result.errors.to_h).to include(short: ["must be unique within the same hierarchy level."])
+        expect(result.errors.to_h).to include(short: [I18n.t("dry_validation.errors.rules.short.not_unique")])
       end
     end
 
@@ -108,7 +124,7 @@ RSpec.describe CustomFields::Hierarchy::InsertItemContract do
       it "is invalid" do
         result = subject.call(params)
         expect(result).to be_failure
-        expect(result.errors.to_h).to include(short: ["must be a string"])
+        expect(result.errors.to_h).to include(short: [I18n.t("dry_validation.errors.str?")])
       end
     end